June 2018 - Devel - libvirt List Archives

Re: [libvirt] [Qemu-devel] [PATCH v7 1/3] qmp: adding 'wakeup-suspend-support' in query-target
by Markus Armbruster 20 Jun '18

20 Jun '18

Cc'ing a few more people. Daniel Henrique Barboza <danielhb(a)linux.ibm.com> writes: > When issuing the qmp/hmp 'system_wakeup' command, what happens in a > nutshell is: > > - qmp_system_wakeup_request set runstate to RUNNING, sets a wakeup_reason > and notify the event > - in the main_loop, all vcpus are paused, a system reset is issued, all > subscribers of wakeup_notifiers receives a notification, vcpus are then > resumed and the wake up QAPI event is fired > > Note that this procedure alone doesn't ensure that the guest will awake > from SUSPENDED state - the subscribers of the wake up event must take > action to resume the guest, otherwise the guest will simply reboot. > > At this moment there are only two subscribers of the wake up event: one > in hw/acpi/core.c and another one in hw/i386/xen/xen-hvm.c. This means > that system_wakeup does not work as intended with other architectures. > > However, only the presence of 'system_wakeup' is required for QGA to > support 'guest-suspend-ram' and 'guest-suspend-hybrid' at this moment. > This means that the user/management will expect to suspend the guest using > one of those suspend commands and then resume execution using system_wakeup, > regardless of the support offered in system_wakeup in the first place. > > This patch adds a new flag called 'wakeup-suspend-support' in TargetInfo > that allows the caller to query if the guest supports wake up from > suspend via system_wakeup. It goes over the subscribers of the wake up > event and, if it's empty, it assumes that the guest does not support > wake up from suspend (and thus, pm-suspend itself). > > This is the expected output of query-target when running a x86 guest: > > {"execute" : "query-target"} > {"return": {"arch": "x86_64", "wakeup-suspend-support": true}} > > This is the output when running a pseries guest: > > {"execute" : "query-target"} > {"return": {"arch": "ppc64", "wakeup-suspend-support": false}} > > Given that the TargetInfo structure is read-only, adding a new flag to > it is backwards compatible. There is no need to deprecate the old > TargetInfo format. > > With this extra tool, management can avoid situations where a guest > that does not have proper suspend/wake capabilities ends up in > inconsistent state (e.g. > https://github.com/open-power-host-os/qemu/issues/31) > > Reported-by: Balamuruhan S <bala24(a)linux.vnet.ibm.com> > Signed-off-by: Daniel Henrique Barboza <danielhb(a)linux.ibm.com> Is query-target is the right place to carry this flag? v7 is rather late for this kind of question; my sincere apologies. The flag is true after qemu_register_wakeup_notifier(). Callers so far: * piix4_pm_realize() via acpi_pm1_cnt_init() This is the realize method of device PIIX4_PM. It's an optional onboard device (suppressed by -no-acpi) of machine types pc-i440fx-VERSION, pc-VERSION, malta. * pc_q35_init() via ich9_lpc_pm_init(), ich9_pm_init(), acpi_pm1_cnt_init() This is the initialization method of machine types pc-q35-VERSION. Note that -no-acpi is not honored. * vt82c686b_pm_realize() via acpi_pm1_cnt_init() This is the realize method of device VT82C686B_PM. It's an onboard device of machine type fulong2e. Again, -no-acpi is not honored. * xen_hvm_init() This one gets called with -accel xen. I suspect the actual callback xen_wakeup_notifier() doesn't actually make wakeup work, unlike the acpi_notify_wakeup() callback registered by the other callers. Issue#1: this calls into question your assumption that the existence of a wake-up notifier implies wake-up works. It still holds if --accel xen is only accepted together with other configuration that triggers registration of acpi_notify_wakeup(). Is it? Stefano, Anthony? Issue#2: the flag isn't a property of the target. Due to -no-acpi, it's not even a property of the machine type. If it was, query-machines would be the natural owner of the flag. Perhaps query-machines is still the proper owner. The value of wakeup-suspend-support would have to depend on -no-acpi for the machine types that honor it. Not ideal; I'd prefer MachineInfo to be static. Tolerable? I guess that's also a libvirt question.

3 14

[libvirt] [dbus PATCH] maint: fix coding style
by Katerina Koukiou 20 Jun '18

20 Jun '18

Signed-off-by: Katerina Koukiou <kkoukiou(a)redhat.com> --- src/connect.c | 12 ++++++------ src/domain.c | 2 +- src/events.c | 24 ++++++++++++------------ src/network.c | 2 +- src/util.c | 6 +++--- src/util.h | 4 ++-- 6 files changed, 25 insertions(+), 25 deletions(-) diff --git a/src/connect.c b/src/connect.c index 2e57d69..09e5628 100644 --- a/src/connect.c +++ b/src/connect.c @@ -1187,12 +1187,12 @@ virtDBusConnectNWFilterDefineXML(GVariant *inArgs, static void virtDBusConnectNWFilterLookupByName(GVariant *inArgs, - GUnixFDList *inFDs G_GNUC_UNUSED, - const gchar *objectPath G_GNUC_UNUSED, - gpointer userData, - GVariant **outArgs, - GUnixFDList **outFDs G_GNUC_UNUSED, - GError **error) + GUnixFDList *inFDs G_GNUC_UNUSED, + const gchar *objectPath G_GNUC_UNUSED, + gpointer userData, + GVariant **outArgs, + GUnixFDList **outFDs G_GNUC_UNUSED, + GError **error) { virtDBusConnect *connect = userData; g_autoptr(virNWFilter) nwfilter = NULL; diff --git a/src/domain.c b/src/domain.c index 4aeb855..5c5e6da 100644 --- a/src/domain.c +++ b/src/domain.c @@ -2189,7 +2189,7 @@ virtDBusDomainMigrateToURI3(GVariant *inArgs, virtDBusConnect *connect = userData; g_autoptr(virDomain) domain = NULL; g_autoptr(GVariantIter) iter = NULL; - const gchar* dconuri; + const gchar *dconuri; g_auto(virtDBusUtilTypedParams) params = { 0 }; guint flags; diff --git a/src/events.c b/src/events.c index 7cdc71d..e635a61 100644 --- a/src/events.c +++ b/src/events.c @@ -546,10 +546,10 @@ virtDBusEventsDomainDiskChange(virConnectPtr connection G_GNUC_UNUSED, static gint virtDBusEventsNetworkEvent(virConnectPtr connection G_GNUC_UNUSED, - virNetworkPtr network, - gint event, - gint detail G_GNUC_UNUSED, - gpointer opaque) + virNetworkPtr network, + gint event, + gint detail G_GNUC_UNUSED, + gpointer opaque) { virtDBusConnect *connect = opaque; g_autofree gchar *path = NULL; @@ -592,10 +592,10 @@ virtDBusEventsNodeDeviceEvent(virConnectPtr connection G_GNUC_UNUSED, static gint virtDBusEventsSecretEvent(virConnectPtr connection G_GNUC_UNUSED, - virSecretPtr secret, - gint event, - gint detail, - gpointer opaque) + virSecretPtr secret, + gint event, + gint detail, + gpointer opaque) { virtDBusConnect *connect = opaque; g_autofree gchar *path = NULL; @@ -615,10 +615,10 @@ virtDBusEventsSecretEvent(virConnectPtr connection G_GNUC_UNUSED, static gint virtDBusEventsStoragePoolEvent(virConnectPtr connection G_GNUC_UNUSED, - virStoragePoolPtr storagePool, - gint event, - gint detail, - gpointer opaque) + virStoragePoolPtr storagePool, + gint event, + gint detail, + gpointer opaque) { virtDBusConnect *connect = opaque; g_autofree gchar *path = NULL; diff --git a/src/network.c b/src/network.c index 1bacb81..3957ee6 100644 --- a/src/network.c +++ b/src/network.c @@ -235,7 +235,7 @@ virtDBusNetworkGetDHCPLeases(GVariant *inArgs, g_variant_builder_add(&builder, "(sxisssuss)", lease->iface, lease->expirytime, lease->type, lease->mac, - lease->iaid ? lease->iaid : "" , + lease->iaid ? lease->iaid : "", lease->ipaddr, lease->prefix, lease->hostname ? lease->hostname : "", lease->clientid ? lease->clientid : ""); diff --git a/src/util.c b/src/util.c index a1b29dd..8c822f2 100644 --- a/src/util.c +++ b/src/util.c @@ -348,8 +348,8 @@ virtDBusUtilVirNodeDeviceListFree(virNodeDevicePtr *devs) virNWFilterPtr virtDBusUtilVirNWFilterFromBusPath(virConnectPtr connection, - const gchar *path, - const gchar *nwfilterPath) + const gchar *path, + const gchar *nwfilterPath) { g_autofree gchar *name = NULL; gsize prefixLen = strlen(nwfilterPath) + 1; @@ -361,7 +361,7 @@ virtDBusUtilVirNWFilterFromBusPath(virConnectPtr connection, gchar * virtDBusUtilBusPathForVirNWFilter(virNWFilterPtr nwfilter, - const gchar *nwfilterPath) + const gchar *nwfilterPath) { gchar uuid[VIR_UUID_STRING_BUFLEN] = ""; g_autofree gchar *newUuid = NULL; diff --git a/src/util.h b/src/util.h index 7db0e25..a688a3d 100644 --- a/src/util.h +++ b/src/util.h @@ -67,8 +67,8 @@ G_DEFINE_AUTOPTR_CLEANUP_FUNC(virDomainStatsRecordPtr, virDomainStatsRecordListF virNetworkPtr virtDBusUtilVirNetworkFromBusPath(virConnectPtr connection, - const gchar *path, - const gchar *networkPath); + const gchar *path, + const gchar *networkPath); gchar * virtDBusUtilBusPathForVirNetwork(virNetworkPtr network, -- 2.15.0

2 1

[libvirt] [PATCH] conf: Remove unused virDomainDefNewFull
by Cole Robinson 20 Jun '18

20 Jun '18

The last usages were removed with the xend driver in 1dac5fbbbb0 Signed-off-by: Cole Robinson <crobinso(a)redhat.com> --- src/conf/domain_conf.c | 22 ---------------------- src/conf/domain_conf.h | 3 --- src/libvirt_private.syms | 1 - 3 files changed, 26 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 522e0c2bf3..f0b604e125 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -3241,28 +3241,6 @@ virDomainDefNew(void) } -virDomainDefPtr -virDomainDefNewFull(const char *name, - const unsigned char *uuid, - int id) -{ - virDomainDefPtr def; - - if (!(def = virDomainDefNew())) - return NULL; - - if (VIR_STRDUP(def->name, name) < 0) { - VIR_FREE(def); - return NULL; - } - - memcpy(def->uuid, uuid, VIR_UUID_BUFLEN); - def->id = id; - - return def; -} - - void virDomainObjAssignDef(virDomainObjPtr domain, virDomainDefPtr def, bool live, diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 6344c02d1c..8cefef535a 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -2919,9 +2919,6 @@ virDomainChrSourceDefNew(virDomainXMLOptionPtr xmlopt); virDomainChrDefPtr virDomainChrDefNew(virDomainXMLOptionPtr xmlopt); virDomainDefPtr virDomainDefNew(void); -virDomainDefPtr virDomainDefNewFull(const char *name, - const unsigned char *uuid, - int id); void virDomainObjAssignDef(virDomainObjPtr domain, virDomainDefPtr def, diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index ea24f2847c..98913a577a 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -287,7 +287,6 @@ virDomainDefMaybeAddController; virDomainDefMaybeAddInput; virDomainDefNeedsPlacementAdvice; virDomainDefNew; -virDomainDefNewFull; virDomainDefParseFile; virDomainDefParseNode; virDomainDefParseString; -- 2.17.1

2 2

[libvirt] [PATCH] qemu: Fix domain resume after failed migration
by Jiri Denemark 19 Jun '18

19 Jun '18

Libvirt relies on being able to kill the destination domain and resume the source one during migration until we called "cont" on the destination. Unfortunately, QEMU automatically activates block devices at the end of migration even when it's called with -S. This wasn't a big issue in the past since the guest is not running and thus no data are written to the block devices. However, when QEMU introduced its internal block device locks, we can no longer resume the source domain once the destination domain already activated the block devices (and thus acquired all locks) unless the destination domain is killed first. Since it's impossible to synchronize the destination and the source libvirt daemons after a failed migration, QEMU introduced a new migration capability called "late-block-activat" which ensures QEMU won't activate block devices until it gets "cont". The only thing we need to do is to enable this capability whenever QEMU supports it. https://bugzilla.redhat.com/show_bug.cgi?id=1568407 QEMU commit implementing the capability: v2.12.0-952-g0f073f44df Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/qemu/qemu_migration_params.c | 4 ++++ src/qemu/qemu_migration_params.h | 1 + 2 files changed, 5 insertions(+) diff --git a/src/qemu/qemu_migration_params.c b/src/qemu/qemu_migration_params.c index 2083563d32..63d20ff5dc 100644 --- a/src/qemu/qemu_migration_params.c +++ b/src/qemu/qemu_migration_params.c @@ -84,6 +84,7 @@ VIR_ENUM_IMPL(qemuMigrationCapability, QEMU_MIGRATION_CAP_LAST, "postcopy-ram", "compress", "pause-before-switchover", + "late-block-activate", ); @@ -129,6 +130,9 @@ struct _qemuMigrationParamsTPMapItem { static const qemuMigrationParamsAlwaysOnItem qemuMigrationParamsAlwaysOn[] = { {QEMU_MIGRATION_CAP_PAUSE_BEFORE_SWITCHOVER, QEMU_MIGRATION_SOURCE}, + + {QEMU_MIGRATION_CAP_LATE_BLOCK_ACTIVATE, + QEMU_MIGRATION_DESTINATION}, }; /* Translation from virDomainMigrateFlags to qemuMigrationCapability. */ diff --git a/src/qemu/qemu_migration_params.h b/src/qemu/qemu_migration_params.h index 9a865b19f3..bee503d0f4 100644 --- a/src/qemu/qemu_migration_params.h +++ b/src/qemu/qemu_migration_params.h @@ -37,6 +37,7 @@ typedef enum { QEMU_MIGRATION_CAP_POSTCOPY, QEMU_MIGRATION_CAP_COMPRESS, QEMU_MIGRATION_CAP_PAUSE_BEFORE_SWITCHOVER, + QEMU_MIGRATION_CAP_LATE_BLOCK_ACTIVATE, QEMU_MIGRATION_CAP_LAST } qemuMigrationCapability; -- 2.17.1

4 3

[libvirt] [v2 RESEND 0/3] qemu: Allow concurrent access to monitor and guest agent
by Michal Privoznik 19 Jun '18

19 Jun '18

Obsoletes: https://www.redhat.com/archives/libvir-list/2018-June/msg01320.html This is the same version as the one linked above, but since I've merged my other patchset that touches the same area in the code reviewers will get merge conflicts when applying these. Rebase & resend. Michal Privoznik (3): qemu: Introduce qemuDomainAgentJob qemu: Introduce APIs for manipulating qemuDomainAgentJob qemu: Switch code to use new agent job APIs src/qemu/THREADS.txt | 112 +++++++++++++++++++++++++--- src/qemu/qemu_domain.c | 193 ++++++++++++++++++++++++++++++++++++++++--------- src/qemu/qemu_domain.h | 30 ++++++++ src/qemu/qemu_driver.c | 91 ++++++++++++++--------- 4 files changed, 346 insertions(+), 80 deletions(-) -- 2.16.4

3 8

[libvirt] [dbus PATCH 00/14] Introduce NodeDevice APIs
by Katerina Koukiou 19 Jun '18

19 Jun '18

Katerina Koukiou (14): Introduce NodeDevice Interface Implement ListNodeDevices method for Connect Interface Register NodeDevice Lifecycle Events Implement NodeDeviceCreateXML method for Connect Interface Implement Destroy method for NodeDevice Interface Implement Detach method for NodeDevice Interface Implement Name property for NodeDevice Interface Implement Parent property for NodeDevice Interface Implement GetXMLDesc property for NodeDevice Interface Implement ListCaps method for NodeDevicesInterface Implement NodeDeviceLookupByName method for Connect Interface Implement NodeDeviceLookupSCSIHostByWWN method for Connect Interface Implement ReAttach method for NodeDevice Interface Implement Reset method for NodeDevice Interface data/Makefile.am | 1 + data/org.libvirt.Connect.xml | 34 +++++ data/org.libvirt.NodeDevice.xml | 45 +++++++ src/Makefile.am | 1 + src/connect.c | 148 +++++++++++++++++++++ src/connect.h | 2 + src/events.c | 42 ++++++ src/nodedev.c | 283 ++++++++++++++++++++++++++++++++++++++++ src/nodedev.h | 9 ++ src/util.c | 35 +++++ src/util.h | 15 +++ tests/Makefile.am | 1 + tests/libvirttest.py | 13 ++ tests/test_connect.py | 27 ++++ tests/test_nodedev.py | 52 ++++++++ tests/xmldata.py | 16 +++ 16 files changed, 724 insertions(+) create mode 100644 data/org.libvirt.NodeDevice.xml create mode 100644 src/nodedev.c create mode 100644 src/nodedev.h create mode 100755 tests/test_nodedev.py -- 2.15.0

2 28

[libvirt] [PATCH 0/2] A potential deadlock fix for SEV and a tiny cleanup
by Erik Skultety 19 Jun '18

19 Jun '18

*** BLURB HERE *** Erik Skultety (2): qemu: sev: Use EnterMonitor instead of EnterMonitorAsync qemu: sev: Don't jump to endjob if SEV measurement retrieval fails src/qemu/qemu_driver.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) -- 2.14.4

2 5

[libvirt] [PATCH v2 0/3] Implement the HTM pSeries feature
by Andrea Bolognani 19 Jun '18

19 Jun '18

Applies cleanly on top of b1acfaaf890a16ecb2fecdbe7f121eff314dd0e9. Changes from [v1]: * drop qom-list-properties machinery, as equivalent functionality has been merged in the meantime; * don't introduce scaffolding for uniform machine option handling as a requirement for implementing this specific feature: we can do ad-hoc processing for now, per the status quo, then clean up everything (including existing features) with a separate series later. Changes from [RFC v3]: * can be considered for merging, since the QEMU part already has; * fix compatibility issues with QEMU <2.12 spotted by Shivaprasad; * drop all features except for HTM, at least for the time being; * add documentation. Changes from [RFC v2]: * use qom-list-properties to probe availability; * test all features with a single XML file. Changes from [RFC v1]: * don't nest features inside a <pseries/> element; * implement all optional features. [v1] https://www.redhat.com/archives/libvir-list/2018-March/msg00474.html [RFC v3] https://www.redhat.com/archives/libvir-list/2018-March/msg00042.html [RFC v2] https://www.redhat.com/archives/libvir-list/2018-February/msg00310.html [RFC v1] https://www.redhat.com/archives/libvir-list/2018-January/msg00779.html Andrea Bolognani (3): qemu: Add capability for the HTM pSeries feature qemu: Implement the HTM pSeries feature news: Update for the HTM pSeries feature docs/formatdomain.html.in | 8 + docs/news.xml | 9 + docs/schemas/domaincommon.rng | 5 + src/conf/domain_conf.c | 19 ++ src/conf/domain_conf.h | 1 + src/qemu/qemu_capabilities.c | 8 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 20 ++ src/qemu/qemu_domain.c | 13 ++ .../caps_2.12.0.aarch64.replies | 48 +++-- .../caps_2.12.0.aarch64.xml | 2 +- .../caps_2.12.0.ppc64.replies | 197 ++++++++++++++++-- .../caps_2.12.0.ppc64.xml | 3 +- .../caps_2.12.0.s390x.replies | 52 +++-- .../caps_2.12.0.s390x.xml | 2 +- .../caps_2.12.0.x86_64.replies | 64 +++--- .../caps_2.12.0.x86_64.xml | 2 +- tests/qemuxml2argvdata/pseries-features.args | 3 +- tests/qemuxml2argvdata/pseries-features.xml | 1 + tests/qemuxml2argvtest.c | 1 + tests/qemuxml2xmltest.c | 1 + 21 files changed, 383 insertions(+), 77 deletions(-) -- 2.17.1

1 3

[libvirt] [PATCH] tests: Fix qemucapsfixreplies
by Andrea Bolognani 19 Jun '18

19 Jun '18

Since e6be524508d5 we include the executed command along with the reply in *.replies files, which breaks the renumbering logic implemented in qemucapsfixreplies. Adapt the script so that it works with the new format. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- tests/qemucapsfixreplies | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tests/qemucapsfixreplies b/tests/qemucapsfixreplies index 4e3371a1f7..597f9ecd6e 100755 --- a/tests/qemucapsfixreplies +++ b/tests/qemucapsfixreplies @@ -8,7 +8,7 @@ if [ "$#" -ne 1 ] || [ "$1" = "--help" ] || [ ! -f "$1" ]; then fi awk -i inplace \ - 'BEGIN {count=1; pattern="libvirt-[0-9]+"} + 'BEGIN {last=0; pattern="libvirt-[0-9]+"} { if (match($0, "libvirt-1[^0-9]")) { count=1; @@ -16,7 +16,11 @@ awk -i inplace \ if (match($0, pattern)) { str="libvirt-" count; sub(pattern, str, $0); - count++; + if (last != count) { + last=count; + } else { + count++; + } } print }' "$1" -- 2.17.1

2 1

[libvirt] [PATCH] Add condiitonal definition for constants
by Daniel P. Berrangé 19 Jun '18

19 Jun '18

To be able to build against older libvirt, we need to conditionally define the constants, even though they're not exposed in the public API. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- Pushed as build fix. connect_compat.h | 16 ++++++++++++++++ domain_compat.h | 4 ++++ 2 files changed, 20 insertions(+) diff --git a/connect_compat.h b/connect_compat.h index cd6d678..f780e58 100644 --- a/connect_compat.h +++ b/connect_compat.h @@ -243,4 +243,20 @@ int virNodeGetSEVInfoCompat(virConnectPtr conn, int *nparams, unsigned int flags); +#ifndef VIR_NODE_SEV_CBITPOS +#define VIR_NODE_SEV_CBITPOS "cbitpos" +#endif + +#ifndef VIR_NODE_SEV_REDUCED_PHYS_BITS +#define VIR_NODE_SEV_REDUCED_PHYS_BITS "reduced-phys-bits" +#endif + +#ifndef VIR_NODE_SEV_PDH +#define VIR_NODE_SEV_PDH "pdh" +#endif + +#ifndef VIR_NODE_SEV_CERT_CHAIN +#define VIR_NODE_SEV_CERT_CHAIN "cert-chain" +#endif + #endif /* LIBVIRT_GO_CONNECT_COMPAT_H__ */ diff --git a/domain_compat.h b/domain_compat.h index 5c93ef5..345505c 100644 --- a/domain_compat.h +++ b/domain_compat.h @@ -1042,4 +1042,8 @@ int virDomainGetLaunchSecurityInfoCompat(virDomainPtr domain, int *nparams, unsigned int flags); +#ifndef VIR_DOMAIN_LAUNCH_SECURITY_SEV_MEASUREMENT +#define VIR_DOMAIN_LAUNCH_SECURITY_SEV_MEASUREMENT "sev-measurement" +#endif + #endif /* LIBVIRT_GO_DOMAIN_COMPAT_H__ */ -- 2.17.0

2 1