June 2018 - Devel - libvirt List Archives

[libvirt] [PATCHv3 0/7] Finish the conversion to virConfGetValue* functions
by Fabiano Fidêncio 11 Jun '18

11 Jun '18

This patchset finishes the conversion to virConfGetValue* functions, started by Daniel Berrange a few months ago. Please, mind that although we could make virConfGetValue* functions more generic in order to support numbers and booleans as strings, that doesn't seem the safest path to take. The side-effect of this is that we will have to live with some specific code doing that as part of vmx and xen_common. Once this patchset gets merged, https://wiki.libvirt.org/page/BiteSizedTasks#Finish_conversion_to_virConfGe… can be removed. - Changes since v1: All the "values" from virConfGetValueString() are freed - Changes since v2: All comments from Ján Tomko have been addressed; A few leaks were (possibly) found and they're addressed in the last patch of the series; Fabiano Fidêncio (7): xen_xm: Split the per-disk logic from xenParseXMDisk() xen_vm: convert to typesafe virConf accessors vmx: convert to typesafe virConf accessors xen_common: Split per-PCI logic from xenParsePCI() xen_common: Split per-Vfi logic from xenParseVif() xen_common: convert to typesafe virConf acessors xen_common: Fix a few memory leaks src/vmx/vmx.c | 194 +++++-------- src/xenconfig/xen_common.c | 701 +++++++++++++++++++++++---------------------- src/xenconfig/xen_xm.c | 306 ++++++++++---------- 3 files changed, 595 insertions(+), 606 deletions(-) -- 2.14.3

2 15

[libvirt] [dbus PATCH] Implement Undefine method for NWFilter Interface
by Katerina Koukiou 11 Jun '18

11 Jun '18

Signed-off-by: Katerina Koukiou <kkoukiou(a)redhat.com> --- All other NWFilter APIs are merged but I forgot this one as Jano noticed. data/org.libvirt.NWFilter.xml | 4 ++++ src/nwfilter.c | 21 +++++++++++++++++++++ 2 files changed, 25 insertions(+) diff --git a/data/org.libvirt.NWFilter.xml b/data/org.libvirt.NWFilter.xml index 69e3357..b8aae02 100644 --- a/data/org.libvirt.NWFilter.xml +++ b/data/org.libvirt.NWFilter.xml @@ -19,5 +19,9 @@ <arg name="flags" type="u" direction="in"/> <arg name="xml" type="s" direction="out"/> </method> + <method name="Undefine"> + <annotation name="org.gtk.GDBus.DocString" + value="See https://libvirt.org/html/libvirt-libvirt-nwfilter.html#virNWFilterUndefine"/> + </method> </interface> </node> diff --git a/src/nwfilter.c b/src/nwfilter.c index acfbdd5..3fc6e12 100644 --- a/src/nwfilter.c +++ b/src/nwfilter.c @@ -92,6 +92,26 @@ virtDBusNWFilterGetXMLDesc(GVariant *inArgs, *outArgs = g_variant_new("(s)", xml); } +static void +virtDBusNWFilterUndefine(GVariant *inArgs G_GNUC_UNUSED, + GUnixFDList *inFDs G_GNUC_UNUSED, + const gchar *objectPath, + gpointer userData, + GVariant **outArgs G_GNUC_UNUSED, + GUnixFDList **outFDs G_GNUC_UNUSED, + GError **error) +{ + virtDBusConnect *connect = userData; + g_autoptr(virNWFilter) nwfilter = NULL; + + nwfilter = virtDBusNWFilterGetVirNWFilter(connect, objectPath, error); + if (!nwfilter) + return; + + if (virNWFilterUndefine(nwfilter) < 0) + virtDBusUtilSetLastVirtError(error); +} + static virtDBusGDBusPropertyTable virtDBusNWFilterPropertyTable[] = { { "Name", virtDBusNWFilterGetName, NULL }, { "UUID", virtDBusNWFilterGetUUID, NULL }, @@ -100,6 +120,7 @@ static virtDBusGDBusPropertyTable virtDBusNWFilterPropertyTable[] = { static virtDBusGDBusMethodTable virtDBusNWFilterMethodTable[] = { { "GetXMLDesc", virtDBusNWFilterGetXMLDesc }, + { "Undefine", virtDBusNWFilterUndefine}, { 0 } }; -- 2.15.0

2 1

[libvirt] [PATCH 00/12] Various apparmor related changes (part )
by Christian Ehrhardt 11 Jun '18

11 Jun '18

Hi, this is a continuation of the ongoing effort to feed back Ubuntu apparmor Delta on libvirt to the community (or to sort out remaining todos or to keep them distro specific). In that it is a follow on to: - https://www.redhat.com/archives/libvir-list/2017-May/msg00630.html - https://www.redhat.com/archives/libvir-list/2017-May/msg00887.html I punted those we had discussions on and decided to rework in the last rounds out of the submission. But in exchange pulled in some more changes we had that are now ready for discussion. That way I prepared the next set of 12 changes which I hereby submit for your consideration into 3.11. Christian Ehrhardt (3): apparmor, libvirt-qemu: add default pki path of lbvirt-spice apparmor, libvirt-qemu: add generic base vfio device apparmor, libvirt-qemu: qemu won't call qemu-nbd Jamie Strandboge (5): apparmor, libvirt-qemu: Allow read access to sysfs system info apparmor, libvirt-qemu: Allow qemu-block-extra libraries apparmor, libvirtd: Allow ixr to /var/lib/libvirt/virtd* apparmor, virt-aa-helper: Allow access to ecryptfs files apparmor, virt-aa-helper: Allow access to /sys/bus/usb/devices Serge Hallyn (3): apparmor, libvirt-qemu: Allow use of sgabios apparmor, libvirt-qemu: Allow read access to max_mem_regions apparmor, libvirt-qemu: Allow access to hugepage mounts Stefan Bader (1): apparmor, libvirt-qemu: Silence lttng related deny messages examples/apparmor/libvirt-qemu | 26 +++++++++++++++++++++++- examples/apparmor/usr.lib.libvirt.virt-aa-helper | 6 ++++++ examples/apparmor/usr.sbin.libvirtd | 4 ++++ 3 files changed, 35 insertions(+), 1 deletion(-) -- 2.7.4

5 56

[libvirt] [PATCH 0/6] Some Coverity patches
by John Ferlan 11 Jun '18

11 Jun '18

Resolve a few things that have built up previous and a couple that are more recent. John Ferlan (6): vbox: Fix resource leak vbox: Fix resource leak qemu: Fix Coverity build for qemu_monitor test: Fix resource leak in qemumonitorjsontest test: Check return status for libxlxml2domconfigtest conf: Check error from virXMLFormatElement call src/conf/domain_conf.c | 3 ++- src/qemu/qemu_monitor.h | 2 +- src/vbox/vbox_common.c | 28 +++++++++++++++------------- tests/libxlxml2domconfigtest.c | 4 +++- tests/qemumonitorjsontest.c | 2 +- 5 files changed, 22 insertions(+), 17 deletions(-) -- 2.14.4

2 7

[libvirt] [jenkins-ci PATCH] guests: Don't use templates in conditionals
by Andrea Bolognani 11 Jun '18

11 Jun '18

We're not supposed to use Jinja2 templates in this context, as recent versions of Ansible very helpfully point out. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- guests/tasks/base.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/guests/tasks/base.yml b/guests/tasks/base.yml index c69c701..3793153 100644 --- a/guests/tasks/base.yml +++ b/guests/tasks/base.yml @@ -21,14 +21,14 @@ os_version: Sid when: - os_name == 'Debian' - - '{{ ansible_distribution_major_version|match("^.*/sid$") }}' + - ansible_distribution_major_version|match("^.*/sid$") - name: Set additional facts (OS) set_fact: os_version: Current when: - ansible_distribution == 'FreeBSD' - - '{{ ansible_distribution_release|match("^.*-CURRENT$") }}' + - ansible_distribution_release|match("^.*-CURRENT$") - name: Set additional facts (package format) set_fact: -- 2.17.1

2 1

[libvirt] [jenkins-ci PATCH] guests: Don't use filters as conditionals
by Andrea Bolognani 11 Jun '18

11 Jun '18

Recent versions of Ansible point out this mistake too. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- To be applied on top of https://www.redhat.com/archives/libvir-list/2018-June/msg00685.html Should have posted both at the same time as a series, but it's too late for that now ¯\_(ツ)_/¯ guests/tasks/base.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/guests/tasks/base.yml b/guests/tasks/base.yml index 3793153..b774b29 100644 --- a/guests/tasks/base.yml +++ b/guests/tasks/base.yml @@ -21,14 +21,14 @@ os_version: Sid when: - os_name == 'Debian' - - ansible_distribution_major_version|match("^.*/sid$") + - ansible_distribution_major_version is match("^.*/sid$") - name: Set additional facts (OS) set_fact: os_version: Current when: - ansible_distribution == 'FreeBSD' - - ansible_distribution_release|match("^.*-CURRENT$") + - ansible_distribution_release is match("^.*-CURRENT$") - name: Set additional facts (package format) set_fact: -- 2.17.1

2 1

[libvirt] [PATCH] bhyve: tests: Add missing data files
by Roman Bogorodskiy 11 Jun '18

11 Jun '18

Add missing data files for bhyve cpu topology tests that should have been added in b66fda0a74. Signed-off-by: Roman Bogorodskiy <bogorodskiy(a)gmail.com> --- Pushed under the build breaker rule. ...yvexml2argv-cputopology-nvcpu-mismatch.xml | 26 +++++++++++++++++++ .../bhyvexml2argv-cputopology.args | 9 +++++++ .../bhyvexml2argv-cputopology.ldargs | 3 +++ .../bhyvexml2argv-cputopology.xml | 26 +++++++++++++++++++ 4 files changed, 64 insertions(+) create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-cputopology-nvcpu-mismatch.xml create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-cputopology.args create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-cputopology.ldargs create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-cputopology.xml diff --git a/tests/bhyvexml2argvdata/bhyvexml2argv-cputopology-nvcpu-mismatch.xml b/tests/bhyvexml2argvdata/bhyvexml2argv-cputopology-nvcpu-mismatch.xml new file mode 100644 index 0000000000..5bd05fb7da --- /dev/null +++ b/tests/bhyvexml2argvdata/bhyvexml2argv-cputopology-nvcpu-mismatch.xml @@ -0,0 +1,26 @@ +<domain type='bhyve'> + <name>bhyve</name> + <uuid>df3be7e7-a104-11e3-aeb0-50e5492bd3dc</uuid> + <memory>219136</memory> + <vcpu>4</vcpu> + <cpu> + <topology sockets='1' cores='2' threads='1'/> + </cpu> + <os> + <type>hvm</type> + </os> + <devices> + <disk type='file'> + <driver name='file' type='raw'/> + <source file='/tmp/freebsd.img'/> + <target dev='hda' bus='sata'/> + <address type='drive' controller='0' bus='0' target='2' unit='0'/> + </disk> + <interface type='bridge'> + <mac address='52:54:00:b9:94:02'/> + <model type='virtio'/> + <source bridge="virbr0"/> + <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/> + </interface> + </devices> +</domain> diff --git a/tests/bhyvexml2argvdata/bhyvexml2argv-cputopology.args b/tests/bhyvexml2argvdata/bhyvexml2argv-cputopology.args new file mode 100644 index 0000000000..2d175a4178 --- /dev/null +++ b/tests/bhyvexml2argvdata/bhyvexml2argv-cputopology.args @@ -0,0 +1,9 @@ +/usr/sbin/bhyve \ +-c cpus=2,sockets=1,cores=2,threads=1 \ +-m 214 \ +-u \ +-H \ +-P \ +-s 0:0,hostbridge \ +-s 2:0,ahci,hd:/tmp/freebsd.img \ +-s 3:0,virtio-net,faketapdev,mac=52:54:00:b9:94:02 bhyve diff --git a/tests/bhyvexml2argvdata/bhyvexml2argv-cputopology.ldargs b/tests/bhyvexml2argvdata/bhyvexml2argv-cputopology.ldargs new file mode 100644 index 0000000000..32538b558e --- /dev/null +++ b/tests/bhyvexml2argvdata/bhyvexml2argv-cputopology.ldargs @@ -0,0 +1,3 @@ +/usr/sbin/bhyveload \ +-m 214 \ +-d /tmp/freebsd.img bhyve diff --git a/tests/bhyvexml2argvdata/bhyvexml2argv-cputopology.xml b/tests/bhyvexml2argvdata/bhyvexml2argv-cputopology.xml new file mode 100644 index 0000000000..83c7d423c4 --- /dev/null +++ b/tests/bhyvexml2argvdata/bhyvexml2argv-cputopology.xml @@ -0,0 +1,26 @@ +<domain type='bhyve'> + <name>bhyve</name> + <uuid>df3be7e7-a104-11e3-aeb0-50e5492bd3dc</uuid> + <memory>219136</memory> + <vcpu>2</vcpu> + <cpu> + <topology sockets='1' cores='2' threads='1'/> + </cpu> + <os> + <type>hvm</type> + </os> + <devices> + <disk type='file'> + <driver name='file' type='raw'/> + <source file='/tmp/freebsd.img'/> + <target dev='hda' bus='sata'/> + <address type='drive' controller='0' bus='0' target='2' unit='0'/> + </disk> + <interface type='bridge'> + <mac address='52:54:00:b9:94:02'/> + <model type='virtio'/> + <source bridge="virbr0"/> + <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/> + </interface> + </devices> +</domain> -- 2.17.0

2 1

[libvirt] [RFC PATCH 0/7] Enable vfio-pci 'property' for mediated devices
by Erik Skultety 11 Jun '18

11 Jun '18

Since QEMU 2.12 there's a new vfio-pci device property 'display' with values on/off/auto. This special kind of display allows using a mediated device which is a VGA compatible device for a display output. There are 2 different implementations of how the device output is handled, referred to as dmabuf and vfio region mapping (currently NVIDIA uses the latter, while Intel relies on the former). From libvirt's perspective the important difference is that dmabuf requires OpenGL support whereas vfio regions don't (it will of course work even with OpenGL enabled). There's a catch though - because of several constraints in the vendor drivers (as discussed here [1]), there currently isn't a reasonable way for libvirt (other than spawning a dummy QEMU instance) to probe such mediated devices for the display mode they use. This the nr.1 reason why libvirt is not going to support the value 'auto' with QEMU and will default to 'off' instead in all cases to stay safe the least and therefore is going to rely on users being able to configure this properly otherwise they'll get an error. Once there's a way for libvirt to probe the nature of the display-capable mediated devices, we can consider adding support for 'auto' value meaning that libvirt is going to take care of adding an appropriate Spice/VNC graphics device depending on the system if these are missing in the config, otherwise the user's choice is always favoured. TL;DR: - we have a new attribute value for vfio-pci mediated devices called 'display' -> devices can now format this new 'display=on/off' property to the cmdline - if user enables the vfio display (display=on) but doesn't enable OpenGL for Spice, we automatically assume the usage of '-display egl-headless' (uses local drm nodes) which works both for Spice and VNC -> if OpenGL is enabled, then '-display egl-headless' is not necessary Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1475770 [1] https://www.redhat.com/archives/libvir-list/2018-May/msg00243.html Erik Skultety (7): conf: Remove a redundant model/address-type check in mdev post parse qemu: command: Move graphics iteration to its own function conf: Introduce virDomainDefHasSpiceGL helper conf: Introduce new <hostdev> attribute 'display' qemu: caps: Add vfio-pci.display capability qemu: domain: Set default vfio-pci display value depending on capability qemu: command: Enable formatting vfio-pci.display option onto cmdline docs/formatdomain.html.in | 16 ++++- docs/schemas/domaincommon.rng | 5 ++ src/conf/domain_conf.c | 56 +++++++++++---- src/conf/domain_conf.h | 4 ++ src/libvirt_private.syms | 1 + src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 84 +++++++++++++++------- src/qemu/qemu_domain.c | 75 +++++++++++++++++++ tests/qemucapabilitiesdata/caps_2.12.0.aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_2.12.0.ppc64.xml | 1 + tests/qemucapabilitiesdata/caps_2.12.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml | 1 + .../hostdev-mdev-display-missing-graphics.xml | 35 +++++++++ .../hostdev-mdev-display-spice-no-opengl.args | 32 +++++++++ .../hostdev-mdev-display-spice-no-opengl.xml | 41 +++++++++++ .../hostdev-mdev-display-spice-opengl.args | 31 ++++++++ .../hostdev-mdev-display-spice-opengl.xml | 41 +++++++++++ .../qemuxml2argvdata/hostdev-mdev-display-vnc.args | 32 +++++++++ .../qemuxml2argvdata/hostdev-mdev-display-vnc.xml | 39 ++++++++++ tests/qemuxml2argvtest.c | 23 ++++++ .../hostdev-mdev-display-spice-no-opengl.xml | 47 ++++++++++++ .../hostdev-mdev-display-spice-opengl.xml | 48 +++++++++++++ .../hostdev-mdev-display-vnc.xml | 47 ++++++++++++ tests/qemuxml2xmltest.c | 3 + 25 files changed, 626 insertions(+), 41 deletions(-) create mode 100644 tests/qemuxml2argvdata/hostdev-mdev-display-missing-graphics.xml create mode 100644 tests/qemuxml2argvdata/hostdev-mdev-display-spice-no-opengl.args create mode 100644 tests/qemuxml2argvdata/hostdev-mdev-display-spice-no-opengl.xml create mode 100644 tests/qemuxml2argvdata/hostdev-mdev-display-spice-opengl.args create mode 100644 tests/qemuxml2argvdata/hostdev-mdev-display-spice-opengl.xml create mode 100644 tests/qemuxml2argvdata/hostdev-mdev-display-vnc.args create mode 100644 tests/qemuxml2argvdata/hostdev-mdev-display-vnc.xml create mode 100644 tests/qemuxml2xmloutdata/hostdev-mdev-display-spice-no-opengl.xml create mode 100644 tests/qemuxml2xmloutdata/hostdev-mdev-display-spice-opengl.xml create mode 100644 tests/qemuxml2xmloutdata/hostdev-mdev-display-vnc.xml -- 2.14.3

3 24

[libvirt] [PATCH] qemu: Fixing uninitialised variable inside virQEMUDriverConfigLoadFile.
by Julio Faracco 11 Jun '18

11 Jun '18

Since virConfGetValueBool() can return earlier, the parameter 'value' might be not initialised properly inside this method. Another proof: Valgrind is returning this error during the libvirtd daemon startup: ==16199== Conditional jump or move depends on uninitialised value(s) ==16199== at 0x27FFFEF4: virQEMUDriverConfigLoadFile (qemu_conf.c:809) ==16199== by 0x2807665C: qemuStateInitialize (qemu_driver.c:654) ==16199== by 0x5535428: virStateInitialize (libvirt.c:662) ==16199== by 0x12AED8: daemonRunStateInit (remote_daemon.c:802) ==16199== by 0x536DE18: virThreadHelper (virthread.c:206) ==16199== by 0x6CB36DA: start_thread (pthread_create.c:463) ==16199== by 0x6FEC88E: clone (clone.S:95) Signed-off-by: Julio Faracco <jcfaracco(a)gmail.com> --- src/qemu/qemu_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index f079ae3221..95f81703fd 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu/qemu_conf.c @@ -511,7 +511,7 @@ int virQEMUDriverConfigLoadFile(virQEMUDriverConfigPtr cfg, char **nvram = NULL; char *corestr = NULL; char **namespaces = NULL; - bool tmp; + bool tmp = false; /* Just check the file is readable before opening it, otherwise * libvirt emits an error. -- 2.17.1

2 1

[libvirt] [PATCH 0/4] TSEG v2
by Martin Kletzander 10 Jun '18

10 Jun '18

I forgot to note the list of changes against v1, so here goes an arbitrary list of some changes that I remember (can suck out of e-mail history): - SMM=on/off is allowed to be specified for i440fx - More use of virXMLFormatElement - Fixed some commit messages - Fixed wording and some details in docs - Don't record the size of extended TSEG in config XML if not explicitly requested Martin Kletzander (4): qemu: Move checks for SMM from command-line creation into validation phase conf, schema, docs: Add support for TSEG size setting qemu: Add capability flag for setting the extended tseg size qemu: Add support for setting the TSEG size docs/formatdomain.html.in | 48 ++++++++++++- docs/schemas/domaincommon.rng | 5 ++ src/conf/domain_conf.c | 65 +++++++++++++++++- src/conf/domain_conf.h | 3 + src/qemu/qemu_capabilities.c | 21 +++--- src/qemu/qemu_capabilities.h | 5 +- src/qemu/qemu_command.c | 30 ++++++--- src/qemu/qemu_domain.c | 50 +++++++++++++- tests/genericxml2xmlindata/tseg.xml | 23 +++++++ tests/genericxml2xmltest.c | 2 + .../caps_1.5.3.x86_64.replies | 38 +++++++++-- .../caps_1.5.3.x86_64.xml | 3 +- .../caps_1.6.0.x86_64.replies | 38 +++++++++-- .../caps_1.6.0.x86_64.xml | 3 +- .../caps_1.7.0.x86_64.replies | 38 +++++++++-- .../caps_1.7.0.x86_64.xml | 3 +- .../caps_2.1.1.x86_64.replies | 38 +++++++++-- .../caps_2.1.1.x86_64.xml | 3 +- .../caps_2.10.0.x86_64.replies | 48 ++++++++++--- .../caps_2.10.0.x86_64.xml | 3 +- .../caps_2.12.0.x86_64.replies | 67 +++++++++++++++---- .../caps_2.12.0.x86_64.xml | 4 +- .../caps_2.4.0.x86_64.replies | 38 +++++++++-- .../caps_2.4.0.x86_64.xml | 3 +- .../caps_2.5.0.x86_64.replies | 40 +++++++++-- .../caps_2.5.0.x86_64.xml | 3 +- .../caps_2.6.0.x86_64.replies | 40 +++++++++-- .../caps_2.6.0.x86_64.xml | 3 +- .../caps_2.7.0.x86_64.replies | 40 +++++++++-- .../caps_2.7.0.x86_64.xml | 3 +- .../caps_2.8.0.x86_64.replies | 40 +++++++++-- .../caps_2.8.0.x86_64.xml | 3 +- .../caps_2.9.0.x86_64.replies | 48 ++++++++++--- .../caps_2.9.0.x86_64.xml | 3 +- .../tseg-explicit-size.x86_64-latest.args | 35 ++++++++++ tests/qemuxml2argvdata/tseg-explicit-size.xml | 23 +++++++ tests/qemuxml2argvdata/tseg-i440fx.xml | 23 +++++++ tests/qemuxml2argvdata/tseg-invalid-size.xml | 23 +++++++ tests/qemuxml2argvtest.c | 25 +++++++ .../qemuxml2xmloutdata/tseg-explicit-size.xml | 46 +++++++++++++ .../tseg-old-machine-type.xml | 44 ++++++++++++ tests/qemuxml2xmloutdata/tseg.xml | 44 ++++++++++++ tests/qemuxml2xmltest.c | 9 +++ 43 files changed, 941 insertions(+), 133 deletions(-) create mode 100644 tests/genericxml2xmlindata/tseg.xml create mode 100644 tests/qemuxml2argvdata/tseg-explicit-size.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/tseg-explicit-size.xml create mode 100644 tests/qemuxml2argvdata/tseg-i440fx.xml create mode 100644 tests/qemuxml2argvdata/tseg-invalid-size.xml create mode 100644 tests/qemuxml2xmloutdata/tseg-explicit-size.xml create mode 100644 tests/qemuxml2xmloutdata/tseg-old-machine-type.xml create mode 100644 tests/qemuxml2xmloutdata/tseg.xml -- 2.17.1

3 18