April 2018 - Devel - libvirt List Archives

[libvirt] [PATCH v3 0/3] Improve handling of multipath devices
by Michal Privoznik 04 Apr '18

04 Apr '18

The saga continues. Turns out, this is bug in both libvirt AND kernel. Firstly, kernel uses different CGroup for checking open() than for ioctl() [1]. However, libvirt needs to allow all targets in the CGroup too. Not only it's logical, kernel devel says it never worked. QEMU was able to open the devmapper device but any subsequent read()/write() would fail because of CGroup perms. Anyway, it's not only RHEL which is affected by this bug. I've upgraded my Gentoo to 4.16 and I'm hitting it even though I was not with 4.15. It all started with upstream kernel commit of 519049afead4f7c3e6446028. This changed call in dm_blk_ioctl() from dm_grab_bdev_for_ioctl() to dm_get_bdev_for_ioctl(). The former merely increases refcount on some internal kernel strcut, the latter calls blkdev_get() which calls __blkdev_get() which actually performs CGroup check. 1: https://bugzilla.redhat.com/show_bug.cgi?id=1557769#c54 Diff to v2: - Changed virDevMapperGetTargets() to do recursive target fetching, and at the same time make it return string list of devices rather than MAJ:MIN pairs. This is because dm_task_set_name() accepts path as string. There's also dm_task_set_major_minor() but: a) handling multiple arrays and merging them (because of recursion) - the code would look ugly, b) we don't need to introduce virDomainAuditCgroupMajorMinor() just to pass MAJ:MIN to it. - Implemented dropping of permissions when unplugging a disk (was missing in previous versions) Michal Privoznik (3): util: Introduce virDevMapperGetTargets qemu_cgroup: Handle device mapper targets properly news: Document device mapper fix docs/news.xml | 10 +++ libvirt.spec.in | 2 + src/libvirt_private.syms | 4 + src/qemu/qemu_cgroup.c | 69 +++++++++++++--- src/util/Makefile.inc.am | 2 + src/util/virdevmapper.c | 200 +++++++++++++++++++++++++++++++++++++++++++++++ src/util/virdevmapper.h | 31 ++++++++ 7 files changed, 309 insertions(+), 9 deletions(-) create mode 100644 src/util/virdevmapper.c create mode 100644 src/util/virdevmapper.h -- 2.16.1

2 7

[libvirt] how to expose missing libxl APIs in xml?
by Olaf Hering 04 Apr '18

04 Apr '18

libvirt lacks support for various API interfaces provided by libxl. There is probably no list to track the items not supported by libvirt. Where should such list be maintained, in libvirt.git? The specific case I have right now is this member of libxl_domain_build_info: tools/libxl/libxl_types.idl:483: ("max_grant_frames", uint32, {'init_val': 'LIBXL_MAX_GRANT_FRAMES_DEFAULT'}), How should this be exposed in the guest xml? Olaf

1 0

[libvirt] [Question] Any plan about supporting MBA (Memory Bandwidth Allocation) in libvirt ?
by Zhanghailiang 04 Apr '18

04 Apr '18

Hi, Intel RDT/MBA has been supported by kernel for a time, we also support CAT in libvirt, which is part of RDT. but I didn't find any discussion or patches about MBA feature in Libvirt, does anyone propose supporting it in libvirt ? Thanks, Hailiang

2 1

[libvirt] [PATCH v2 0/3] Clean/fix test driver usage of FindBy{UUID|ID}
by John Ferlan 04 Apr '18

04 Apr '18

v1: https://www.redhat.com/archives/libvir-list/2018-March/msg00507.html e.g., part of a 20 patch series: https://www.redhat.com/archives/libvir-list/2018-March/msg00489.html Changes since v1: * Add patches 2 and 3 essentially... Doing the same ByIDRef as ByUUIDRef and fixing the ListRemove consumers to do the Lock. NB: The ByIDRef logic was formerly part of patch 20 - this just extracts it a bit to make it more orderly. John Ferlan (3): test: Use virDomainObjListFindByUUIDRef test: Use virDomainObjListFindByIDRef test: Need to relock afer virDomainObjListRemove src/test/test_driver.c | 42 +++++++++++++++++++++++++----------------- 1 file changed, 25 insertions(+), 17 deletions(-) -- 2.13.6

2 7

[libvirt] [dbus PATCH 0/5] Introduce Network Interface
by Katerina Koukiou 04 Apr '18

04 Apr '18

This patchset introduces also some basic methods and properties for Network interface. More functionality will be added in following patchsets. New functions are covered by the test suite. Katerina Koukiou (5): Introduce Network Interface Implement ListNetworks method for Connect interface Implement virtDBusUtilVirNetworkFromBusPath helper function. Implement Name property for Network interface Implement NetworkLookupByName method for Connect interface data/Makefile.am | 3 +- data/org.libvirt.Connect.xml | 12 +++++ data/org.libvirt.Network.xml | 11 +++++ src/Makefile.am | 3 +- src/connect.c | 75 ++++++++++++++++++++++++++++++ src/connect.h | 1 + src/network.c | 107 +++++++++++++++++++++++++++++++++++++++++++ src/network.h | 9 ++++ src/util.c | 33 +++++++++++++ src/util.h | 15 ++++++ test/Makefile.am | 3 +- test/libvirttest.py | 12 +++++ test/test_connect.py | 11 +++++ 13 files changed, 292 insertions(+), 3 deletions(-) create mode 100644 data/org.libvirt.Network.xml create mode 100644 src/network.c create mode 100644 src/network.h -- 2.15.0

1 6

[libvirt] hash: failed on concurrent iterating.
by Zhangzijian 04 Apr '18

04 Apr '18

In function 'virHashForEach/virHashSearch', 'table->iterating' prevent concurrent iterating. But most caller evoke it, after hold a read lock. This will lead the second caller failed to iterate the table. So, the caller should hold a write lock, then iterate the table.

4 6

[libvirt] [PATCH] tests: utils: Fix out-of-bounds access to memory in virTestCompareToFile
by Peter Krempa 04 Apr '18

04 Apr '18

Similarly to 3506f1ecfde, the contents of 'cmpcontent' may be an empty string so the following code would access memory out of the array. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- tests/testutils.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/testutils.c b/tests/testutils.c index 4bd1b63755..7c095caac9 100644 --- a/tests/testutils.c +++ b/tests/testutils.c @@ -797,10 +797,11 @@ virTestCompareToFile(const char *strcontent, if (filecontent) { size_t filecontentLen = strlen(filecontent); + size_t cmpcontentLen = strlen(cmpcontent); if (filecontentLen > 0 && filecontent[filecontentLen - 1] == '\n' && - cmpcontent[strlen(cmpcontent) - 1] != '\n') { + (cmpcontentLen == 0 || cmpcontent[cmpcontentLen - 1] != '\n')) { if (virAsprintf(&fixedcontent, "%s\n", cmpcontent) < 0) goto failure; cmpcontent = fixedcontent; -- 2.16.2

2 1

[libvirt] [libvirt PATCH] qemu: Add support for specifying SPICE TLS ciphers
by Ján Tomko 04 Apr '18

04 Apr '18

From: Christophe Fergeau <cfergeau(a)redhat.com> This commit adds a 'spice_tls_ciphers' parameter in qemu.conf which allows to configure which TLS ciphers SPICE will be using for its TLS connections. https://bugzilla.redhat.com/show_bug.cgi?id=1562032 Signed-off-by: Christophe Fergeau <cfergeau(a)redhat.com> Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- This is mostly useful as a workaround for missing crypto policies, so I'm not sure if it's upstream material. Changes from the patch attached to the BZ: ciphers(2) -> ciphers(1) Added augeas changes and tests escape the string before passing it to QEMU src/qemu/libvirtd_qemu.aug | 1 + src/qemu/qemu.conf | 5 ++++ src/qemu/qemu_command.c | 8 +++++- src/qemu/qemu_conf.c | 3 +++ src/qemu/qemu_conf.h | 1 + src/qemu/test_libvirtd_qemu.aug.in | 1 + .../graphics-spice-sasl-ciphers.args | 29 ++++++++++++++++++++++ .../graphics-spice-sasl-ciphers.xml | 1 + tests/qemuxml2argvtest.c | 5 ++++ 9 files changed, 53 insertions(+), 1 deletion(-) create mode 100644 tests/qemuxml2argvdata/graphics-spice-sasl-ciphers.args create mode 120000 tests/qemuxml2argvdata/graphics-spice-sasl-ciphers.xml diff --git a/src/qemu/libvirtd_qemu.aug b/src/qemu/libvirtd_qemu.aug index c19bf3a43..15222d7e3 100644 --- a/src/qemu/libvirtd_qemu.aug +++ b/src/qemu/libvirtd_qemu.aug @@ -44,6 +44,7 @@ module Libvirtd_qemu = let spice_entry = str_entry "spice_listen" | bool_entry "spice_tls" | str_entry "spice_tls_x509_cert_dir" + | str_entry "spice_tls_ciphers" | bool_entry "spice_auto_unix_socket" | str_entry "spice_password" | bool_entry "spice_sasl" diff --git a/src/qemu/qemu.conf b/src/qemu/qemu.conf index 07eab7eff..1d7b6c555 100644 --- a/src/qemu/qemu.conf +++ b/src/qemu/qemu.conf @@ -181,6 +181,11 @@ #spice_tls_x509_cert_dir = "/etc/pki/libvirt-spice" +# The ciphers used by spice can be overridden here. This is an OpenSSL cipher +# list as documented in ciphers(1) +#spice_tls_ciphers = "DEFAULT" + + # Enable this option to have SPICE served over an automatically created # unix socket. This prevents unprivileged access from users on the # host machine. diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 682d71441..adf0b2cb9 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -8028,8 +8028,14 @@ qemuBuildGraphicsSPICECommandLine(virQEMUDriverConfigPtr cfg, !cfg->spicePassword) virBufferAddLit(&opt, "disable-ticketing,"); - if (hasSecure) + if (hasSecure) { virBufferAsprintf(&opt, "x509-dir=%s,", cfg->spiceTLSx509certdir); + if (cfg->spiceTLSCiphers) { + virBufferAddLit(&opt, "tls-ciphers="); + virQEMUBuildBufferEscapeComma(&opt, cfg->spiceTLSCiphers); + virBufferAddLit(&opt, ","); + } + } switch (graphics->data.spice.defaultMode) { case VIR_DOMAIN_GRAPHICS_SPICE_CHANNEL_MODE_SECURE: diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index 36cf3a281..92afd252d 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu/qemu_conf.c @@ -374,6 +374,7 @@ static void virQEMUDriverConfigDispose(void *obj) VIR_FREE(cfg->vncSASLdir); VIR_FREE(cfg->spiceTLSx509certdir); + VIR_FREE(cfg->spiceTLSCiphers); VIR_FREE(cfg->spiceListen); VIR_FREE(cfg->spicePassword); VIR_FREE(cfg->spiceSASLdir); @@ -550,6 +551,8 @@ int virQEMUDriverConfigLoadFile(virQEMUDriverConfigPtr cfg, goto cleanup; if (virConfGetValueString(conf, "spice_tls_x509_cert_dir", &cfg->spiceTLSx509certdir) < 0) goto cleanup; + if (virConfGetValueString(conf, "spice_tls_ciphers", &cfg->spiceTLSCiphers) < 0) + goto cleanup; if (virConfGetValueBool(conf, "spice_sasl", &cfg->spiceSASL) < 0) goto cleanup; if (virConfGetValueString(conf, "spice_sasl_dir", &cfg->spiceSASLdir) < 0) diff --git a/src/qemu/qemu_conf.h b/src/qemu/qemu_conf.h index e1ad5463f..9ab9f4e37 100644 --- a/src/qemu/qemu_conf.h +++ b/src/qemu/qemu_conf.h @@ -128,6 +128,7 @@ struct _virQEMUDriverConfig { bool spiceTLS; char *spiceTLSx509certdir; + char *spiceTLSCiphers; bool spiceSASL; char *spiceSASLdir; char *spiceListen; diff --git a/src/qemu/test_libvirtd_qemu.aug.in b/src/qemu/test_libvirtd_qemu.aug.in index 688e5b9fd..2f62b383e 100644 --- a/src/qemu/test_libvirtd_qemu.aug.in +++ b/src/qemu/test_libvirtd_qemu.aug.in @@ -17,6 +17,7 @@ module Test_libvirtd_qemu = { "spice_listen" = "0.0.0.0" } { "spice_tls" = "1" } { "spice_tls_x509_cert_dir" = "/etc/pki/libvirt-spice" } +{ "spice_tls_ciphers" = "DEFAULT" } { "spice_auto_unix_socket" = "1" } { "spice_password" = "XYZ12345" } { "spice_sasl" = "1" } diff --git a/tests/qemuxml2argvdata/graphics-spice-sasl-ciphers.args b/tests/qemuxml2argvdata/graphics-spice-sasl-ciphers.args new file mode 100644 index 000000000..2f608ad7c --- /dev/null +++ b/tests/qemuxml2argvdata/graphics-spice-sasl-ciphers.args @@ -0,0 +1,29 @@ +LC_ALL=C \ +PATH=/bin \ +HOME=/home/test \ +USER=test \ +LOGNAME=test \ +SASL_CONF_PATH=/root/.sasl2 \ +QEMU_AUDIO_DRV=spice \ +/usr/bin/qemu-system-i686 \ +-name QEMUGuest1 \ +-S \ +-M pc \ +-m 214 \ +-smp 1,sockets=1,cores=1,threads=1 \ +-uuid c7a5fdbd-edaf-9455-926a-d65c16db1809 \ +-nodefaults \ +-chardev socket,id=charmonitor,path=/tmp/lib/domain--1-QEMUGuest1/monitor.sock,\ +server,nowait \ +-mon chardev=charmonitor,id=monitor,mode=readline \ +-no-acpi \ +-boot c \ +-usb \ +-drive file=/dev/HostVG/QEMUGuest1,format=raw,if=none,id=drive-ide0-0-0 \ +-device ide-drive,bus=ide.0,unit=0,drive=drive-ide0-0-0,id=ide0-0-0 \ +-spice port=5903,tls-port=5904,addr=127.0.0.1,sasl,\ +x509-dir=/etc/pki/libvirt-spice,tls-ciphers=DEFAULT,tls-channel=default \ +-vga qxl \ +-global qxl-vga.ram_size=67108864 \ +-global qxl-vga.vram_size=33554432 \ +-device virtio-balloon-pci,id=balloon0,bus=pci.0,addr=0x3 diff --git a/tests/qemuxml2argvdata/graphics-spice-sasl-ciphers.xml b/tests/qemuxml2argvdata/graphics-spice-sasl-ciphers.xml new file mode 120000 index 000000000..1bfac9efa --- /dev/null +++ b/tests/qemuxml2argvdata/graphics-spice-sasl-ciphers.xml @@ -0,0 +1 @@ +graphics-spice-sasl.xml \ No newline at end of file diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 308d71f72..29f702c5c 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -1126,6 +1126,11 @@ mymain(void) DO_TEST("graphics-spice-sasl", QEMU_CAPS_SPICE, QEMU_CAPS_DEVICE_QXL); + ignore_value(VIR_STRDUP(driver.config->spiceTLSCiphers, "DEFAULT")); + DO_TEST("graphics-spice-sasl-ciphers", + QEMU_CAPS_SPICE, + QEMU_CAPS_DEVICE_QXL); + VIR_FREE(driver.config->spiceTLSCiphers); VIR_FREE(driver.config->spiceSASLdir); driver.config->spiceSASL = 0; DO_TEST("graphics-spice-agentmouse", -- 2.13.6

4 3

[libvirt] [PATCH 00/44] Require QEMU 1.3.0 or newer
by Ján Tomko 03 Apr '18

03 Apr '18

It's been a while since we last bumped the minimum QEMU version. Let's get rid of -help parsing and bring our test suite closer to real world usage by implying lots of capabilities. Ján Tomko (44): qemuxml2argvtest: Fix q35-virt-manager capabilities Delete bogus cpu-host-passthrough test Force QMP capability probing Require QEMU 1.3.0 Deprecate QEMU_CAPS_PCI_MULTIFUNCTION Deprecate QEMU_CAPS_NETDEV Clean up qemuDomainAttachNetDevice Remove unused qemuDomainNetVLAN Remove qemuDomainSupportsNetdev Deprecate QEMU_CAPS_MONITOR_JSON Deprecate QEMU_CAPS_NO_USER_CONFIG Deprecate QEMU_CAPS_MEM_PATH Deprecate QEMU_CAPS_DRIVE_SERIAL Deprecate QEMU_CAPS_SDL Deprecate QEMU_CAPS_RTC Deprecate QEMU_CAPS_RTC_TD_HACK Deprecate QEMU_CAPS_VHOST_NET Deprecate QEMU_CAPS_NODEFCONFIG Deprecate QEMU_CAPS_BOOT_MENU Deprecate QEMU_CAPS_FSDEV Deprecate QEMU_CAPS_NAME_PROCESS Deprecate QEMU_CAPS_SMBIOS_TYPE Deprecate QEMU_CAPS_VGA_NONE Deprecate QEMU_CAPS_DRIVE_AIO Deprecate QEMU_CAPS_CHARDEV_SPICEVMC Deprecate QEMU_CAPS_DEVICE_SPICEVMC Deprecate QEMU_CAPS_DRIVE_CACHE_DIRECTSYNC Deprecate QEMU_CAPS_NO_SHUTDOWN Deprecate QEMU_CAPS_DRIVE_CACHE_UNSAFE Deprecate QEMU_CAPS_FSDEV_READONLY Deprecate QEMU_CAPS_DRIVE_COPY_ON_READ Deprecate QEMU_CAPS_FSDEV_WRITEOUT Deprecate QEMU_CAPS_DRIVE_IOTUNE Deprecate QEMU_CAPS_WAKEUP Deprecate QEMU_CAPS_NETDEV_BRIDGE Deprecate QEMU_CAPS_SECCOMP_SANDBOX Deprecate QEMU_CAPS_DTB Deprecate QEMU_CAPS_IPV6_MIGRATION Deprecate QEMU_CAPS_MACHINE_OPT Deprecate QEMU_CAPS_DUMP_GUEST_CORE Deprecate QEMU_CAPS_VNC_SHARE_POLICY Deprecate QEMU_CAPS_HOST_PCI_MULTIDOMAIN Deprecate QEMU_CAPS_DISPLAY Deprecate QEMU_CAPS_MACHINE_USB_OPT cfg.mk | 2 +- src/qemu/qemu_capabilities.c | 931 +--------- src/qemu/qemu_capabilities.h | 74 +- src/qemu/qemu_capspriv.h | 17 +- src/qemu/qemu_command.c | 690 +++---- src/qemu/qemu_domain.c | 16 - src/qemu/qemu_domain.h | 6 - src/qemu/qemu_driver.c | 48 +- src/qemu/qemu_hotplug.c | 147 +- src/qemu/qemu_interface.c | 4 +- src/qemu/qemu_interface.h | 1 - src/qemu/qemu_migration.c | 10 +- src/qemu/qemu_process.c | 23 +- tests/Makefile.am | 8 +- .../qemucapabilitiesdata/caps_1.2.2.x86_64.replies | 1886 -------------------- tests/qemucapabilitiesdata/caps_1.2.2.x86_64.xml | 172 -- tests/qemucapabilitiesdata/caps_1.3.1.x86_64.xml | 35 - tests/qemucapabilitiesdata/caps_1.4.2.x86_64.xml | 35 - tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml | 35 - tests/qemucapabilitiesdata/caps_1.6.0.x86_64.xml | 35 - tests/qemucapabilitiesdata/caps_1.7.0.x86_64.xml | 35 - tests/qemucapabilitiesdata/caps_2.1.1.x86_64.xml | 35 - tests/qemucapabilitiesdata/caps_2.10.0.aarch64.xml | 35 - tests/qemucapabilitiesdata/caps_2.10.0.ppc64.xml | 35 - tests/qemucapabilitiesdata/caps_2.10.0.s390x.xml | 35 - tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml | 35 - tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml | 35 - tests/qemucapabilitiesdata/caps_2.12.0.aarch64.xml | 35 - tests/qemucapabilitiesdata/caps_2.12.0.ppc64.xml | 35 - tests/qemucapabilitiesdata/caps_2.12.0.s390x.xml | 35 - tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml | 35 - tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml | 35 - tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml | 35 - tests/qemucapabilitiesdata/caps_2.6.0.aarch64.xml | 35 - tests/qemucapabilitiesdata/caps_2.6.0.ppc64.xml | 35 - tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml | 35 - tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml | 35 - tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml | 35 - tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml | 35 - tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml | 35 - tests/qemucapabilitiesdata/caps_2.9.0.ppc64.xml | 35 - tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml | 35 - tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml | 35 - tests/qemucapabilitiestest.c | 1 - tests/qemucapsprobe.c | 2 +- tests/qemuhelpdata/qemu-0.12.1 | 198 -- tests/qemuhelpdata/qemu-0.12.1-device | 62 - tests/qemuhelpdata/qemu-1.0 | 253 --- tests/qemuhelpdata/qemu-1.0-device | 148 -- tests/qemuhelpdata/qemu-1.1.0 | 269 --- tests/qemuhelpdata/qemu-1.1.0-device | 170 -- tests/qemuhelpdata/qemu-1.2.0 | 272 --- tests/qemuhelpdata/qemu-kvm-0.12.3 | 215 --- tests/qemuhelpdata/qemu-kvm-0.12.3-device | 63 - tests/qemuhelpdata/qemu-kvm-0.13.0 | 242 --- tests/qemuhelpdata/qemu-kvm-0.13.0-device | 90 - tests/qemuhelpdata/qemu-kvm-1.2.0 | 277 --- tests/qemuhelptest.c | 437 ----- .../aarch64-aavmf-virtio-mmio.args | 14 +- tests/qemuxml2argvdata/aarch64-acpi-uefi.args | 9 +- .../qemuxml2argvdata/aarch64-cpu-passthrough.args | 10 +- tests/qemuxml2argvdata/aarch64-gic-host.args | 9 +- tests/qemuxml2argvdata/aarch64-gic-none-tcg.args | 9 +- tests/qemuxml2argvdata/aarch64-gic-v2.args | 9 +- tests/qemuxml2argvdata/aarch64-gic-v3.args | 9 +- tests/qemuxml2argvdata/aarch64-kvm-32-on-64.args | 14 +- tests/qemuxml2argvdata/aarch64-noacpi-nouefi.args | 9 +- tests/qemuxml2argvdata/aarch64-noacpi-uefi.args | 9 +- tests/qemuxml2argvdata/aarch64-pci-serial.args | 10 +- .../aarch64-usb-controller-nec-xhci.args | 9 +- .../aarch64-usb-controller-qemu-xhci.args | 9 +- tests/qemuxml2argvdata/aarch64-video-default.args | 8 +- .../aarch64-video-virtio-gpu-pci.args | 16 +- .../aarch64-virt-2.6-virtio-pci-default.args | 15 +- .../qemuxml2argvdata/aarch64-virt-default-nic.args | 14 +- tests/qemuxml2argvdata/aarch64-virt-virtio.args | 14 +- .../aarch64-virtio-pci-default.args | 15 +- .../aarch64-virtio-pci-manual-addresses.args | 20 +- tests/qemuxml2argvdata/acpi-table.args | 9 +- tests/qemuxml2argvdata/arm-vexpressa9-basic.args | 10 +- tests/qemuxml2argvdata/arm-vexpressa9-nodevs.args | 10 +- tests/qemuxml2argvdata/arm-vexpressa9-virtio.args | 14 +- tests/qemuxml2argvdata/arm-virt-virtio.args | 14 +- tests/qemuxml2argvdata/autoindex.args | 9 +- tests/qemuxml2argvdata/balloon-ccw-deflate.args | 10 +- tests/qemuxml2argvdata/balloon-device-auto.args | 10 +- .../balloon-device-deflate-off.args | 10 +- tests/qemuxml2argvdata/balloon-device-deflate.args | 10 +- tests/qemuxml2argvdata/balloon-device-period.args | 10 +- tests/qemuxml2argvdata/balloon-device.args | 10 +- tests/qemuxml2argvdata/balloon-mmio-deflate.args | 10 +- tests/qemuxml2argvdata/bios-nvram-secure.args | 11 +- tests/qemuxml2argvdata/bios-nvram.args | 11 +- tests/qemuxml2argvdata/bios.args | 11 +- tests/qemuxml2argvdata/blkdeviotune-group-num.args | 9 +- .../qemuxml2argvdata/blkdeviotune-max-length.args | 9 +- tests/qemuxml2argvdata/blkdeviotune-max.args | 9 +- tests/qemuxml2argvdata/blkdeviotune.args | 9 +- tests/qemuxml2argvdata/blkiotune-device.args | 9 +- tests/qemuxml2argvdata/blkiotune.args | 9 +- tests/qemuxml2argvdata/boot-cdrom.args | 9 +- tests/qemuxml2argvdata/boot-complex-bootindex.args | 20 +- tests/qemuxml2argvdata/boot-complex.args | 19 +- tests/qemuxml2argvdata/boot-floppy-q35.args | 9 +- tests/qemuxml2argvdata/boot-floppy.args | 9 +- .../boot-menu-disable-drive-bootindex.args | 9 +- .../qemuxml2argvdata/boot-menu-disable-drive.args | 9 +- tests/qemuxml2argvdata/boot-menu-disable.args | 9 +- .../boot-menu-enable-bootindex.args | 9 +- .../boot-menu-enable-with-timeout.args | 9 +- tests/qemuxml2argvdata/boot-menu-enable.args | 9 +- tests/qemuxml2argvdata/boot-multi.args | 9 +- tests/qemuxml2argvdata/boot-network.args | 9 +- tests/qemuxml2argvdata/boot-order.args | 15 +- tests/qemuxml2argvdata/boot-strict.args | 20 +- tests/qemuxml2argvdata/bootindex-floppy-q35.args | 9 +- tests/qemuxml2argvdata/channel-guestfwd.args | 10 +- tests/qemuxml2argvdata/channel-spicevmc-old.args | 29 - tests/qemuxml2argvdata/channel-spicevmc-old.xml | 35 - tests/qemuxml2argvdata/channel-spicevmc.args | 8 +- tests/qemuxml2argvdata/channel-virtio-auto.args | 10 +- tests/qemuxml2argvdata/channel-virtio-autoadd.args | 10 +- .../channel-virtio-autoassign.args | 10 +- tests/qemuxml2argvdata/channel-virtio-default.args | 10 +- tests/qemuxml2argvdata/channel-virtio-state.args | 10 +- tests/qemuxml2argvdata/channel-virtio-unix.args | 10 +- tests/qemuxml2argvdata/channel-virtio.args | 10 +- tests/qemuxml2argvdata/chardev-reconnect.args | 10 +- tests/qemuxml2argvdata/clock-catchup.args | 8 +- tests/qemuxml2argvdata/clock-france.args | 8 +- tests/qemuxml2argvdata/clock-hpet-off.args | 8 +- .../clock-localtime-basis-localtime.args | 8 +- tests/qemuxml2argvdata/clock-localtime.args | 10 +- tests/qemuxml2argvdata/clock-timer-hyperv-rtc.args | 9 +- tests/qemuxml2argvdata/clock-utc.args | 10 +- tests/qemuxml2argvdata/clock-variable.args | 8 +- tests/qemuxml2argvdata/console-compat-auto.args | 9 +- tests/qemuxml2argvdata/console-compat-chardev.args | 10 +- tests/qemuxml2argvdata/console-compat.args | 9 +- tests/qemuxml2argvdata/console-sclp.args | 10 +- tests/qemuxml2argvdata/console-virtio-ccw.args | 10 +- tests/qemuxml2argvdata/console-virtio-many.args | 10 +- tests/qemuxml2argvdata/console-virtio-s390.args | 10 +- tests/qemuxml2argvdata/console-virtio.args | 10 +- tests/qemuxml2argvdata/controller-order.args | 13 +- tests/qemuxml2argvdata/cpu-Haswell-noTSX.args | 9 +- tests/qemuxml2argvdata/cpu-Haswell.args | 9 +- tests/qemuxml2argvdata/cpu-Haswell2.args | 9 +- tests/qemuxml2argvdata/cpu-Haswell3.args | 9 +- tests/qemuxml2argvdata/cpu-cache-disable.args | 9 +- tests/qemuxml2argvdata/cpu-cache-disable2.args | 9 +- tests/qemuxml2argvdata/cpu-cache-disable3.args | 9 +- tests/qemuxml2argvdata/cpu-cache-emulate-l3.args | 9 +- tests/qemuxml2argvdata/cpu-cache-passthrough.args | 9 +- tests/qemuxml2argvdata/cpu-cache-passthrough2.args | 9 +- tests/qemuxml2argvdata/cpu-check-default-none.args | 9 +- .../qemuxml2argvdata/cpu-check-default-none2.args | 9 +- .../cpu-check-default-partial.args | 9 +- .../cpu-check-default-partial2.args | 9 +- tests/qemuxml2argvdata/cpu-check-none.args | 9 +- tests/qemuxml2argvdata/cpu-eoi-disabled.args | 9 +- tests/qemuxml2argvdata/cpu-eoi-enabled.args | 9 +- tests/qemuxml2argvdata/cpu-exact1.args | 9 +- tests/qemuxml2argvdata/cpu-exact2-nofallback.args | 9 +- tests/qemuxml2argvdata/cpu-exact2.args | 9 +- tests/qemuxml2argvdata/cpu-fallback.args | 9 +- tests/qemuxml2argvdata/cpu-host-kvmclock.args | 10 +- tests/qemuxml2argvdata/cpu-host-model-cmt.args | 9 +- .../qemuxml2argvdata/cpu-host-model-fallback.args | 9 +- tests/qemuxml2argvdata/cpu-host-model-vendor.args | 9 +- tests/qemuxml2argvdata/cpu-host-model.args | 9 +- .../cpu-host-passthrough-features.args | 9 +- tests/qemuxml2argvdata/cpu-host-passthrough.args | 9 +- tests/qemuxml2argvdata/cpu-hotplug-startup.args | 9 +- tests/qemuxml2argvdata/cpu-kvmclock.args | 10 +- tests/qemuxml2argvdata/cpu-minimum1.args | 9 +- tests/qemuxml2argvdata/cpu-minimum2.args | 9 +- tests/qemuxml2argvdata/cpu-numa-disjoint.args | 9 +- tests/qemuxml2argvdata/cpu-numa-memshared.args | 9 +- .../cpu-numa-no-memory-element.args | 9 +- tests/qemuxml2argvdata/cpu-numa1.args | 9 +- tests/qemuxml2argvdata/cpu-numa2.args | 9 +- tests/qemuxml2argvdata/cpu-s390-features.args | 9 +- tests/qemuxml2argvdata/cpu-s390-zEC12.args | 9 +- tests/qemuxml2argvdata/cpu-strict1.args | 9 +- tests/qemuxml2argvdata/cpu-topology1.args | 9 +- tests/qemuxml2argvdata/cpu-topology2.args | 9 +- tests/qemuxml2argvdata/cpu-topology3.args | 9 +- tests/qemuxml2argvdata/cpu-tsc-frequency.args | 9 +- tests/qemuxml2argvdata/cputune-numatune.args | 9 +- tests/qemuxml2argvdata/cputune-zero-shares.args | 9 +- tests/qemuxml2argvdata/cputune.args | 9 +- tests/qemuxml2argvdata/debug-threads.args | 9 +- tests/qemuxml2argvdata/default-kvm-host-arch.args | 9 +- tests/qemuxml2argvdata/default-qemu-host-arch.args | 9 +- tests/qemuxml2argvdata/disk-aio.args | 9 +- tests/qemuxml2argvdata/disk-blockio.args | 10 +- tests/qemuxml2argvdata/disk-cdrom-empty.args | 9 +- tests/qemuxml2argvdata/disk-cdrom-network-ftp.args | 9 +- .../qemuxml2argvdata/disk-cdrom-network-ftps.args | 9 +- .../qemuxml2argvdata/disk-cdrom-network-http.args | 9 +- .../qemuxml2argvdata/disk-cdrom-network-https.args | 9 +- .../qemuxml2argvdata/disk-cdrom-network-tftp.args | 9 +- .../disk-cdrom-tray-no-device-cap.args | 9 +- tests/qemuxml2argvdata/disk-cdrom-tray.args | 11 +- tests/qemuxml2argvdata/disk-cdrom.args | 9 +- tests/qemuxml2argvdata/disk-copy_on_read.args | 17 +- tests/qemuxml2argvdata/disk-drive-boot-cdrom.args | 9 +- tests/qemuxml2argvdata/disk-drive-boot-disk.args | 9 +- .../disk-drive-cache-directsync.args | 9 +- .../qemuxml2argvdata/disk-drive-cache-unsafe.args | 9 +- .../qemuxml2argvdata/disk-drive-cache-v2-none.args | 9 +- tests/qemuxml2argvdata/disk-drive-cache-v2-wb.args | 9 +- tests/qemuxml2argvdata/disk-drive-cache-v2-wt.args | 9 +- .../qemuxml2argvdata/disk-drive-copy-on-read.args | 9 +- .../qemuxml2argvdata/disk-drive-detect-zeroes.args | 11 +- tests/qemuxml2argvdata/disk-drive-discard.args | 11 +- .../disk-drive-error-policy-enospace.args | 7 +- .../disk-drive-error-policy-stop.args | 7 +- .../disk-drive-error-policy-wreport-rignore.args | 7 +- tests/qemuxml2argvdata/disk-drive-fmt-qcow.args | 9 +- .../disk-drive-network-gluster.args | 9 +- .../disk-drive-network-iscsi-auth.args | 9 +- .../disk-drive-network-iscsi-lun.args | 10 +- .../qemuxml2argvdata/disk-drive-network-iscsi.args | 9 +- .../disk-drive-network-nbd-export.args | 9 +- .../disk-drive-network-nbd-ipv6-export.args | 9 +- .../disk-drive-network-nbd-ipv6.args | 9 +- .../disk-drive-network-nbd-unix.args | 9 +- tests/qemuxml2argvdata/disk-drive-network-nbd.args | 9 +- .../disk-drive-network-rbd-auth-AES.args | 9 +- .../disk-drive-network-rbd-auth.args | 9 +- .../disk-drive-network-rbd-ipv6.args | 9 +- tests/qemuxml2argvdata/disk-drive-network-rbd.args | 9 +- .../disk-drive-network-sheepdog.args | 9 +- .../disk-drive-network-source-auth.args | 9 +- .../disk-drive-network-tlsx509-vxhs.args | 15 +- .../qemuxml2argvdata/disk-drive-network-vxhs.args | 11 +- tests/qemuxml2argvdata/disk-drive-no-boot.args | 9 +- .../qemuxml2argvdata/disk-drive-readonly-disk.args | 10 +- .../disk-drive-readonly-no-device.args | 10 +- .../disk-drive-shared-locking.args | 9 +- tests/qemuxml2argvdata/disk-drive-shared.args | 9 +- .../disk-floppy-tray-no-device-cap.args | 9 +- tests/qemuxml2argvdata/disk-floppy-tray.args | 9 +- tests/qemuxml2argvdata/disk-floppy.args | 9 +- tests/qemuxml2argvdata/disk-geometry.args | 9 +- .../disk-hostdev-scsi-virtio-iscsi-auth-AES.args | 9 +- tests/qemuxml2argvdata/disk-ide-drive-split.args | 10 +- tests/qemuxml2argvdata/disk-ide-wwn.args | 9 +- tests/qemuxml2argvdata/disk-ioeventfd.args | 15 +- tests/qemuxml2argvdata/disk-iscsi.args | 9 +- .../qemuxml2argvdata/disk-many-format-probing.args | 9 +- tests/qemuxml2argvdata/disk-many.args | 9 +- tests/qemuxml2argvdata/disk-order.args | 9 +- tests/qemuxml2argvdata/disk-sata-device.args | 10 +- tests/qemuxml2argvdata/disk-scsi-device-auto.args | 10 +- tests/qemuxml2argvdata/disk-scsi-device.args | 10 +- tests/qemuxml2argvdata/disk-scsi-disk-split.args | 10 +- tests/qemuxml2argvdata/disk-scsi-disk-vpd.args | 10 +- tests/qemuxml2argvdata/disk-scsi-disk-wwn.args | 12 +- .../disk-scsi-lun-passthrough.args | 9 +- tests/qemuxml2argvdata/disk-scsi-megasas.args | 10 +- tests/qemuxml2argvdata/disk-scsi-mptsas1068.args | 10 +- tests/qemuxml2argvdata/disk-scsi-virtio-scsi.args | 10 +- tests/qemuxml2argvdata/disk-scsi-vscsi.args | 10 +- tests/qemuxml2argvdata/disk-serial.args | 9 +- tests/qemuxml2argvdata/disk-snapshot.args | 9 +- tests/qemuxml2argvdata/disk-source-pool-mode.args | 10 +- tests/qemuxml2argvdata/disk-source-pool.args | 10 +- .../disk-usb-device-removable.args | 10 +- tests/qemuxml2argvdata/disk-usb-device.args | 10 +- tests/qemuxml2argvdata/disk-virtio-ccw-many.args | 9 +- tests/qemuxml2argvdata/disk-virtio-ccw.args | 9 +- .../qemuxml2argvdata/disk-virtio-drive-queues.args | 9 +- tests/qemuxml2argvdata/disk-virtio-s390.args | 9 +- tests/qemuxml2argvdata/disk-virtio-scsi-ccw.args | 9 +- .../disk-virtio-scsi-cmd_per_lun.args | 10 +- .../disk-virtio-scsi-ioeventfd.args | 10 +- .../disk-virtio-scsi-max_sectors.args | 10 +- .../disk-virtio-scsi-num_queues.args | 10 +- tests/qemuxml2argvdata/disk-virtio.args | 9 +- tests/qemuxml2argvdata/encrypted-disk-usage.args | 9 +- tests/qemuxml2argvdata/encrypted-disk.args | 9 +- tests/qemuxml2argvdata/eoi-disabled.args | 9 +- tests/qemuxml2argvdata/eoi-enabled.args | 9 +- tests/qemuxml2argvdata/event_idx.args | 17 +- .../fd-memory-no-numa-topology.args | 9 +- .../qemuxml2argvdata/fd-memory-numa-topology.args | 9 +- .../qemuxml2argvdata/fd-memory-numa-topology2.args | 9 +- .../qemuxml2argvdata/fd-memory-numa-topology3.args | 9 +- tests/qemuxml2argvdata/fips-enabled.args | 9 +- tests/qemuxml2argvdata/floppy-drive-fat.args | 9 +- tests/qemuxml2argvdata/fs9p-ccw.args | 10 +- tests/qemuxml2argvdata/fs9p.args | 10 +- .../qemuxml2argvdata/graphics-sdl-fullscreen.args | 7 +- tests/qemuxml2argvdata/graphics-sdl.args | 7 +- .../graphics-spice-agent-file-xfer.args | 7 +- .../graphics-spice-agentmouse.args | 8 +- .../graphics-spice-auto-socket-cfg.args | 7 +- .../graphics-spice-auto-socket.args | 7 +- .../graphics-spice-compression.args | 7 +- tests/qemuxml2argvdata/graphics-spice-no-args.args | 7 +- tests/qemuxml2argvdata/graphics-spice-qxl-vga.args | 7 +- tests/qemuxml2argvdata/graphics-spice-sasl.args | 7 +- tests/qemuxml2argvdata/graphics-spice-socket.args | 7 +- tests/qemuxml2argvdata/graphics-spice-timeout.args | 14 +- .../qemuxml2argvdata/graphics-spice-usb-redir.args | 8 +- tests/qemuxml2argvdata/graphics-spice.args | 7 +- .../graphics-vnc-auto-socket-cfg.args | 7 +- .../qemuxml2argvdata/graphics-vnc-auto-socket.args | 7 +- .../graphics-vnc-no-listen-attr.args | 7 +- tests/qemuxml2argvdata/graphics-vnc-none.args | 7 +- tests/qemuxml2argvdata/graphics-vnc-policy.args | 7 +- .../graphics-vnc-remove-generated-socket.args | 7 +- tests/qemuxml2argvdata/graphics-vnc-sasl.args | 7 +- .../graphics-vnc-socket-new-cmdline.args | 7 +- tests/qemuxml2argvdata/graphics-vnc-socket.args | 7 +- tests/qemuxml2argvdata/graphics-vnc-tls.args | 7 +- tests/qemuxml2argvdata/graphics-vnc-websocket.args | 7 +- tests/qemuxml2argvdata/graphics-vnc.args | 7 +- .../qemuxml2argvdata/hostdev-mdev-precreated.args | 10 +- .../hostdev-pci-address-device.args | 10 +- tests/qemuxml2argvdata/hostdev-pci-address.args | 9 +- .../hostdev-scsi-lsi-iscsi-auth.args | 9 +- tests/qemuxml2argvdata/hostdev-scsi-lsi-iscsi.args | 9 +- tests/qemuxml2argvdata/hostdev-scsi-lsi.args | 9 +- tests/qemuxml2argvdata/hostdev-scsi-readonly.args | 9 +- .../hostdev-scsi-vhost-scsi-ccw.args | 9 +- .../hostdev-scsi-vhost-scsi-pci.args | 9 +- .../hostdev-scsi-vhost-scsi-pcie.args | 9 +- .../hostdev-scsi-virtio-iscsi-auth.args | 9 +- .../hostdev-scsi-virtio-iscsi.args | 9 +- .../qemuxml2argvdata/hostdev-scsi-virtio-scsi.args | 9 +- .../hostdev-usb-address-device-boot.args | 10 +- .../hostdev-usb-address-device.args | 10 +- tests/qemuxml2argvdata/hostdev-usb-address.args | 9 +- .../qemuxml2argvdata/hostdev-vfio-multidomain.args | 10 +- tests/qemuxml2argvdata/hostdev-vfio.args | 10 +- tests/qemuxml2argvdata/hotplug-base.args | 9 +- tests/qemuxml2argvdata/hugepages-memaccess.args | 9 +- tests/qemuxml2argvdata/hugepages-memaccess2.args | 9 +- tests/qemuxml2argvdata/hugepages-numa.args | 6 +- tests/qemuxml2argvdata/hugepages-pages.args | 9 +- tests/qemuxml2argvdata/hugepages-pages2.args | 9 +- tests/qemuxml2argvdata/hugepages-pages3.args | 9 +- tests/qemuxml2argvdata/hugepages-pages5.args | 9 +- tests/qemuxml2argvdata/hugepages-pages6.args | 9 +- tests/qemuxml2argvdata/hugepages-pages7.args | 9 +- tests/qemuxml2argvdata/hugepages-shared.args | 9 +- tests/qemuxml2argvdata/hugepages.args | 9 +- tests/qemuxml2argvdata/hyperv-off.args | 9 +- tests/qemuxml2argvdata/hyperv-panic.args | 9 +- tests/qemuxml2argvdata/hyperv.args | 9 +- tests/qemuxml2argvdata/input-usbmouse-addr.args | 10 +- tests/qemuxml2argvdata/input-usbmouse.args | 9 +- tests/qemuxml2argvdata/input-usbtablet.args | 9 +- tests/qemuxml2argvdata/input-virtio-ccw.args | 9 +- .../qemuxml2argvdata/intel-iommu-caching-mode.args | 14 +- .../qemuxml2argvdata/intel-iommu-device-iotlb.args | 9 +- tests/qemuxml2argvdata/intel-iommu-eim.args | 9 +- tests/qemuxml2argvdata/intel-iommu-machine.args | 9 +- tests/qemuxml2argvdata/intel-iommu.args | 9 +- .../iothreads-disk-virtio-ccw.args | 9 +- tests/qemuxml2argvdata/iothreads-disk.args | 9 +- tests/qemuxml2argvdata/iothreads-ids-partial.args | 9 +- tests/qemuxml2argvdata/iothreads-ids.args | 9 +- .../iothreads-virtio-scsi-ccw.args | 9 +- .../iothreads-virtio-scsi-pci.args | 9 +- tests/qemuxml2argvdata/iothreads.args | 9 +- tests/qemuxml2argvdata/kvm-features-off.args | 9 +- tests/qemuxml2argvdata/kvm-features.args | 9 +- tests/qemuxml2argvdata/kvm-pit-delay.args | 9 +- tests/qemuxml2argvdata/kvm-pit-discard.args | 9 +- tests/qemuxml2argvdata/kvm.args | 9 +- tests/qemuxml2argvdata/kvmclock+eoi-disabled.args | 9 +- tests/qemuxml2argvdata/kvmclock.args | 9 +- tests/qemuxml2argvdata/luks-disks-source.args | 9 +- tests/qemuxml2argvdata/luks-disks.args | 9 +- .../qemuxml2argvdata/mach-virt-console-virtio.args | 10 +- .../qemuxml2argvdata/mach-virt-serial-native.args | 10 +- tests/qemuxml2argvdata/mach-virt-serial-pci.args | 10 +- tests/qemuxml2argvdata/mach-virt-serial-usb.args | 10 +- .../machine-aeskeywrap-off-cap.args | 10 +- .../machine-aeskeywrap-off-caps.args | 10 +- .../machine-aeskeywrap-on-cap.args | 9 +- .../machine-aeskeywrap-on-caps.args | 9 +- tests/qemuxml2argvdata/machine-aliases1.args | 9 +- tests/qemuxml2argvdata/machine-aliases2.args | 9 +- tests/qemuxml2argvdata/machine-core-cfg-off.args | 9 +- tests/qemuxml2argvdata/machine-core-off.args | 9 +- tests/qemuxml2argvdata/machine-core-on.args | 9 +- .../machine-deakeywrap-off-cap.args | 10 +- .../machine-deakeywrap-off-caps.args | 10 +- .../machine-deakeywrap-on-cap.args | 9 +- .../machine-deakeywrap-on-caps.args | 9 +- .../machine-keywrap-none-caps.args | 9 +- tests/qemuxml2argvdata/machine-keywrap-none.args | 9 +- .../machine-loadparm-multiple-disks-nets-s390.args | 21 +- .../machine-loadparm-net-s390.args | 15 +- tests/qemuxml2argvdata/machine-loadparm-s390.args | 9 +- tests/qemuxml2argvdata/machine-smm-opt.args | 9 +- tests/qemuxml2argvdata/machine-usb-opt.args | 9 +- tests/qemuxml2argvdata/machine-vmport-opt.args | 9 +- tests/qemuxml2argvdata/master-key.args | 9 +- .../qemuxml2argvdata/memory-hotplug-dimm-addr.args | 9 +- tests/qemuxml2argvdata/memory-hotplug-dimm.args | 9 +- .../memory-hotplug-nvdimm-access.args | 9 +- .../memory-hotplug-nvdimm-label.args | 9 +- tests/qemuxml2argvdata/memory-hotplug-nvdimm.args | 9 +- .../memory-hotplug-ppc64-nonuma.args | 9 +- tests/qemuxml2argvdata/memory-hotplug.args | 9 +- tests/qemuxml2argvdata/memtune-unlimited.args | 9 +- tests/qemuxml2argvdata/memtune.args | 9 +- tests/qemuxml2argvdata/migrate-numa-unaligned.args | 9 +- tests/qemuxml2argvdata/migrate.args | 9 +- tests/qemuxml2argvdata/minimal-msg-timestamp.args | 9 +- tests/qemuxml2argvdata/minimal.args | 9 +- tests/qemuxml2argvdata/misc-acpi.args | 9 +- tests/qemuxml2argvdata/misc-disable-s3.args | 9 +- tests/qemuxml2argvdata/misc-disable-suspends.args | 9 +- tests/qemuxml2argvdata/misc-enable-s4.args | 9 +- tests/qemuxml2argvdata/misc-no-reboot.args | 8 +- tests/qemuxml2argvdata/misc-uuid.args | 9 +- tests/qemuxml2argvdata/mlock-off.args | 9 +- tests/qemuxml2argvdata/mlock-on.args | 9 +- tests/qemuxml2argvdata/mlock-unsupported.args | 9 +- tests/qemuxml2argvdata/monitor-json.args | 8 +- .../qemuxml2argvdata/multifunction-pci-device.args | 10 +- tests/qemuxml2argvdata/name-escape.args | 7 +- tests/qemuxml2argvdata/net-client.args | 14 +- tests/qemuxml2argvdata/net-eth-hostip.args | 14 +- tests/qemuxml2argvdata/net-eth-ifname.args | 14 +- tests/qemuxml2argvdata/net-eth-names.args | 18 +- tests/qemuxml2argvdata/net-eth.args | 14 +- .../qemuxml2argvdata/net-hostdev-multidomain.args | 10 +- .../net-hostdev-vfio-multidomain.args | 10 +- tests/qemuxml2argvdata/net-hostdev-vfio.args | 10 +- tests/qemuxml2argvdata/net-hostdev.args | 10 +- tests/qemuxml2argvdata/net-mcast.args | 14 +- tests/qemuxml2argvdata/net-server.args | 14 +- tests/qemuxml2argvdata/net-udp.args | 15 +- tests/qemuxml2argvdata/net-user-addr.args | 9 +- tests/qemuxml2argvdata/net-user.args | 14 +- tests/qemuxml2argvdata/net-vhostuser-multiq.args | 9 +- tests/qemuxml2argvdata/net-vhostuser.args | 9 +- tests/qemuxml2argvdata/net-virtio-ccw.args | 19 +- tests/qemuxml2argvdata/net-virtio-device.args | 16 +- .../net-virtio-disable-offloads.args | 14 +- tests/qemuxml2argvdata/net-virtio-netdev.args | 10 +- .../qemuxml2argvdata/net-virtio-rxtxqueuesize.args | 15 +- tests/qemuxml2argvdata/net-virtio-s390.args | 13 +- tests/qemuxml2argvdata/net-virtio.args | 14 +- tests/qemuxml2argvdata/no-kvm-pit-device.args | 9 +- tests/qemuxml2argvdata/no-shutdown.args | 7 +- tests/qemuxml2argvdata/nographics-display.args | 7 +- tests/qemuxml2argvdata/nographics-vga.args | 9 +- tests/qemuxml2argvdata/nographics.args | 9 +- tests/qemuxml2argvdata/nosharepages.args | 9 +- .../numad-auto-memory-vcpu-cpuset.args | 9 +- ...d-auto-memory-vcpu-no-cpuset-and-placement.args | 9 +- .../numad-auto-vcpu-static-numatune.args | 9 +- .../numad-static-memory-auto-vcpu.args | 9 +- tests/qemuxml2argvdata/numad.args | 9 +- .../numatune-auto-nodeset-invalid.args | 9 +- tests/qemuxml2argvdata/numatune-auto-prefer.args | 9 +- tests/qemuxml2argvdata/numatune-distances.args | 9 +- .../numatune-memnode-no-memory.args | 9 +- tests/qemuxml2argvdata/numatune-memnode.args | 9 +- tests/qemuxml2argvdata/numatune-memory.args | 9 +- tests/qemuxml2argvdata/panic-double.args | 10 +- tests/qemuxml2argvdata/panic-no-address.args | 10 +- tests/qemuxml2argvdata/panic.args | 10 +- .../qemuxml2argvdata/parallel-parport-chardev.args | 10 +- tests/qemuxml2argvdata/parallel-tcp-chardev.args | 10 +- tests/qemuxml2argvdata/pci-autoadd-addr.args | 9 +- tests/qemuxml2argvdata/pci-autoadd-idx.args | 9 +- tests/qemuxml2argvdata/pci-autofill-addr.args | 9 +- tests/qemuxml2argvdata/pci-bridge-many-disks.args | 9 +- tests/qemuxml2argvdata/pci-bridge.args | 158 +- tests/qemuxml2argvdata/pci-expander-bus.args | 160 +- tests/qemuxml2argvdata/pci-many.args | 9 +- tests/qemuxml2argvdata/pci-rom.args | 22 +- tests/qemuxml2argvdata/pci-serial-dev-chardev.args | 10 +- tests/qemuxml2argvdata/pcie-expander-bus.args | 164 +- .../pcie-root-port-model-generic.args | 9 +- .../pcie-root-port-model-ioh3420.args | 9 +- tests/qemuxml2argvdata/pcie-root-port.args | 9 +- tests/qemuxml2argvdata/pcie-root.args | 9 +- .../pcie-switch-downstream-port.args | 9 +- .../pcie-switch-upstream-port.args | 9 +- tests/qemuxml2argvdata/pcihole64-q35.args | 9 +- tests/qemuxml2argvdata/pcihole64.args | 9 +- tests/qemuxml2argvdata/pmu-feature-off.args | 9 +- tests/qemuxml2argvdata/pmu-feature.args | 9 +- tests/qemuxml2argvdata/ppc-dtb.args | 9 +- .../ppc64-usb-controller-legacy.args | 9 +- .../ppc64-usb-controller-qemu-xhci.args | 9 +- tests/qemuxml2argvdata/ppc64-usb-controller.args | 9 +- tests/qemuxml2argvdata/ppce500-serial.args | 9 +- tests/qemuxml2argvdata/pseries-basic.args | 10 +- tests/qemuxml2argvdata/pseries-console-virtio.args | 10 +- .../pseries-cpu-compat-power9.args | 10 +- tests/qemuxml2argvdata/pseries-cpu-compat.args | 10 +- tests/qemuxml2argvdata/pseries-cpu-exact.args | 10 +- tests/qemuxml2argvdata/pseries-cpu-le.args | 10 +- tests/qemuxml2argvdata/pseries-features.args | 9 +- tests/qemuxml2argvdata/pseries-hostdevs-1.args | 10 +- tests/qemuxml2argvdata/pseries-hostdevs-2.args | 10 +- tests/qemuxml2argvdata/pseries-hostdevs-3.args | 10 +- .../pseries-machine-max-cpu-compat.args | 10 +- tests/qemuxml2argvdata/pseries-many-buses-1.args | 10 +- tests/qemuxml2argvdata/pseries-many-buses-2.args | 10 +- tests/qemuxml2argvdata/pseries-many-devices.args | 10 +- tests/qemuxml2argvdata/pseries-nvram.args | 9 +- tests/qemuxml2argvdata/pseries-panic-missing.args | 10 +- .../qemuxml2argvdata/pseries-panic-no-address.args | 10 +- .../pseries-phb-default-missing.args | 10 +- tests/qemuxml2argvdata/pseries-phb-numa-node.args | 9 +- tests/qemuxml2argvdata/pseries-phb-simple.args | 10 +- tests/qemuxml2argvdata/pseries-serial-native.args | 10 +- tests/qemuxml2argvdata/pseries-serial-pci.args | 10 +- tests/qemuxml2argvdata/pseries-serial-usb.args | 10 +- tests/qemuxml2argvdata/pseries-usb-default.args | 10 +- tests/qemuxml2argvdata/pseries-usb-kbd.args | 10 +- tests/qemuxml2argvdata/pseries-usb-multi.args | 10 +- .../pseries-vio-user-assigned.args | 10 +- tests/qemuxml2argvdata/pseries-vio.args | 10 +- tests/qemuxml2argvdata/pv-spinlock-disabled.args | 9 +- tests/qemuxml2argvdata/pv-spinlock-enabled.args | 9 +- tests/qemuxml2argvdata/q35-acpi-nouefi.args | 9 +- tests/qemuxml2argvdata/q35-acpi-uefi.args | 9 +- .../qemuxml2argvdata/q35-default-devices-only.args | 9 +- tests/qemuxml2argvdata/q35-multifunction.args | 9 +- tests/qemuxml2argvdata/q35-noacpi-nouefi.args | 9 +- tests/qemuxml2argvdata/q35-pci-force-address.args | 14 +- tests/qemuxml2argvdata/q35-pcie-autoadd.args | 9 +- tests/qemuxml2argvdata/q35-pcie.args | 9 +- .../qemuxml2argvdata/q35-pm-disable-fallback.args | 9 +- tests/qemuxml2argvdata/q35-pm-disable.args | 9 +- tests/qemuxml2argvdata/q35-usb2-multi.args | 9 +- tests/qemuxml2argvdata/q35-usb2-reorder.args | 9 +- tests/qemuxml2argvdata/q35-usb2.args | 9 +- tests/qemuxml2argvdata/q35-virt-manager-basic.args | 6 +- tests/qemuxml2argvdata/q35-virtio-pci.args | 9 +- tests/qemuxml2argvdata/q35.args | 9 +- tests/qemuxml2argvdata/qemu-ns-alt.args | 9 +- .../qemuxml2argvdata/qemu-ns-commandline-ns0.args | 9 +- .../qemuxml2argvdata/qemu-ns-commandline-ns1.args | 9 +- tests/qemuxml2argvdata/qemu-ns-commandline.args | 9 +- .../qemu-ns-domain-commandline-ns0.args | 9 +- .../qemu-ns-domain-commandline.args | 9 +- tests/qemuxml2argvdata/qemu-ns-domain-ns0.args | 9 +- tests/qemuxml2argvdata/qemu-ns-no-env.args | 9 +- tests/qemuxml2argvdata/qemu-ns.args | 9 +- .../qemuxml2argvdata/reboot-timeout-disabled.args | 9 +- tests/qemuxml2argvdata/reboot-timeout-enabled.args | 9 +- tests/qemuxml2argvdata/restore-v2-fd.args | 9 +- tests/qemuxml2argvdata/restore-v2.args | 9 +- .../s390-allow-bogus-usb-controller.args | 10 +- .../s390-allow-bogus-usb-none.args | 10 +- tests/qemuxml2argvdata/s390-panic-missing.args | 10 +- tests/qemuxml2argvdata/s390-panic-no-address.args | 10 +- tests/qemuxml2argvdata/s390-serial-2.args | 10 +- tests/qemuxml2argvdata/s390-serial-console.args | 10 +- tests/qemuxml2argvdata/s390-serial.args | 10 +- tests/qemuxml2argvdata/seclabel-dac-none.args | 9 +- .../seclabel-dynamic-baselabel.args | 9 +- .../seclabel-dynamic-labelskip.args | 9 +- .../seclabel-dynamic-override.args | 9 +- .../qemuxml2argvdata/seclabel-dynamic-relabel.args | 9 +- tests/qemuxml2argvdata/seclabel-dynamic.args | 9 +- tests/qemuxml2argvdata/seclabel-none.args | 9 +- .../seclabel-static-labelskip.args | 9 +- .../qemuxml2argvdata/seclabel-static-relabel.args | 9 +- tests/qemuxml2argvdata/seclabel-static.args | 9 +- .../serial-dev-chardev-iobase.args | 10 +- tests/qemuxml2argvdata/serial-dev-chardev.args | 10 +- tests/qemuxml2argvdata/serial-file-chardev.args | 10 +- tests/qemuxml2argvdata/serial-file-log.args | 9 +- tests/qemuxml2argvdata/serial-many-chardev.args | 10 +- tests/qemuxml2argvdata/serial-pty-chardev.args | 10 +- .../qemuxml2argvdata/serial-spiceport-nospice.args | 9 +- tests/qemuxml2argvdata/serial-spiceport.args | 8 +- tests/qemuxml2argvdata/serial-tcp-chardev.args | 10 +- .../serial-tcp-telnet-chardev.args | 10 +- .../serial-tcp-tlsx509-chardev-notls.args | 10 +- .../serial-tcp-tlsx509-chardev-verify.args | 10 +- .../serial-tcp-tlsx509-chardev.args | 10 +- .../serial-tcp-tlsx509-secret-chardev.args | 10 +- tests/qemuxml2argvdata/serial-udp-chardev.args | 10 +- tests/qemuxml2argvdata/serial-unix-chardev.args | 10 +- tests/qemuxml2argvdata/serial-vc-chardev.args | 10 +- tests/qemuxml2argvdata/shmem-plain-doorbell.args | 9 +- tests/qemuxml2argvdata/shmem.args | 9 +- tests/qemuxml2argvdata/smartcard-controller.args | 10 +- .../smartcard-host-certificates.args | 10 +- tests/qemuxml2argvdata/smartcard-host.args | 10 +- .../smartcard-passthrough-spicevmc.args | 10 +- .../smartcard-passthrough-tcp.args | 10 +- tests/qemuxml2argvdata/smbios.args | 9 +- tests/qemuxml2argvdata/smp.args | 9 +- tests/qemuxml2argvdata/sound-device.args | 10 +- tests/qemuxml2argvdata/sound.args | 9 +- tests/qemuxml2argvdata/tpm-passthrough.args | 11 +- .../usb-controller-default-q35.args | 9 +- .../usb-controller-explicit-q35.args | 9 +- .../qemuxml2argvdata/usb-controller-qemu-xhci.args | 9 +- tests/qemuxml2argvdata/usb-controller-xhci.args | 10 +- tests/qemuxml2argvdata/usb-controller.args | 10 +- tests/qemuxml2argvdata/usb-hub-autoadd-deluxe.args | 10 +- tests/qemuxml2argvdata/usb-hub-autoadd.args | 10 +- tests/qemuxml2argvdata/usb-hub.args | 10 +- tests/qemuxml2argvdata/usb-ich9-autoassign.args | 10 +- tests/qemuxml2argvdata/usb-ich9-companion.args | 10 +- tests/qemuxml2argvdata/usb-ich9-ehci-addr.args | 10 +- tests/qemuxml2argvdata/usb-long-port-path.args | 10 +- tests/qemuxml2argvdata/usb-none.args | 10 +- tests/qemuxml2argvdata/usb-piix3-controller.args | 10 +- tests/qemuxml2argvdata/usb-port-autoassign.args | 10 +- tests/qemuxml2argvdata/usb-port-missing.args | 10 +- tests/qemuxml2argvdata/usb-ports.args | 10 +- tests/qemuxml2argvdata/usb-redir-boot.args | 10 +- .../qemuxml2argvdata/usb-redir-filter-version.args | 10 +- tests/qemuxml2argvdata/usb-redir-filter.args | 10 +- tests/qemuxml2argvdata/usb-redir.args | 10 +- tests/qemuxml2argvdata/usb-xhci-autoassign.args | 10 +- tests/qemuxml2argvdata/usb1-usb2.args | 10 +- tests/qemuxml2argvdata/user-aliases-usb.args | 9 +- tests/qemuxml2argvdata/user-aliases.args | 25 +- tests/qemuxml2argvdata/vcpu-placement-static.args | 9 +- .../video-device-pciaddr-default.args | 7 +- .../qemuxml2argvdata/video-qxl-device-vgamem.args | 9 +- tests/qemuxml2argvdata/video-qxl-device.args | 9 +- tests/qemuxml2argvdata/video-qxl-heads.args | 9 +- tests/qemuxml2argvdata/video-qxl-nodevice.args | 9 +- tests/qemuxml2argvdata/video-qxl-noheads.args | 9 +- .../video-qxl-sec-device-vgamem.args | 9 +- tests/qemuxml2argvdata/video-qxl-sec-device.args | 9 +- .../qemuxml2argvdata/video-vga-device-vgamem.args | 9 +- tests/qemuxml2argvdata/video-vga-device.args | 9 +- tests/qemuxml2argvdata/video-vga-nodevice.args | 9 +- tests/qemuxml2argvdata/video-vga-qxl-heads.args | 9 +- tests/qemuxml2argvdata/video-virtio-gpu-ccw.args | 7 +- .../qemuxml2argvdata/video-virtio-gpu-device.args | 9 +- .../video-virtio-gpu-secondary.args | 9 +- .../video-virtio-gpu-spice-gl.args | 7 +- tests/qemuxml2argvdata/video-virtio-gpu-virgl.args | 9 +- tests/qemuxml2argvdata/video-virtio-vga.args | 9 +- .../qemuxml2argvdata/virtio-input-passthrough.args | 9 +- tests/qemuxml2argvdata/virtio-input.args | 9 +- tests/qemuxml2argvdata/virtio-lun.args | 16 +- tests/qemuxml2argvdata/virtio-options.args | 15 +- tests/qemuxml2argvdata/virtio-rng-ccw.args | 10 +- tests/qemuxml2argvdata/virtio-rng-default.args | 9 +- tests/qemuxml2argvdata/virtio-rng-egd.args | 9 +- tests/qemuxml2argvdata/virtio-rng-multiple.args | 9 +- tests/qemuxml2argvdata/virtio-rng-random.args | 9 +- tests/qemuxml2argvdata/vmcoreinfo.args | 9 +- tests/qemuxml2argvdata/watchdog-device.args | 10 +- tests/qemuxml2argvdata/watchdog-diag288.args | 10 +- tests/qemuxml2argvdata/watchdog-dump.args | 9 +- tests/qemuxml2argvdata/watchdog-injectnmi.args | 9 +- tests/qemuxml2argvdata/watchdog.args | 9 +- tests/qemuxml2argvdata/x86-kvm-32-on-64.args | 9 +- tests/qemuxml2argvtest.c | 744 +++----- tests/qemuxml2xmltest.c | 119 +- 667 files changed, 4571 insertions(+), 10320 deletions(-) delete mode 100644 tests/qemucapabilitiesdata/caps_1.2.2.x86_64.replies delete mode 100644 tests/qemucapabilitiesdata/caps_1.2.2.x86_64.xml delete mode 100644 tests/qemuhelpdata/qemu-0.12.1 delete mode 100644 tests/qemuhelpdata/qemu-0.12.1-device delete mode 100644 tests/qemuhelpdata/qemu-1.0 delete mode 100644 tests/qemuhelpdata/qemu-1.0-device delete mode 100644 tests/qemuhelpdata/qemu-1.1.0 delete mode 100644 tests/qemuhelpdata/qemu-1.1.0-device delete mode 100644 tests/qemuhelpdata/qemu-1.2.0 delete mode 100644 tests/qemuhelpdata/qemu-kvm-0.12.3 delete mode 100644 tests/qemuhelpdata/qemu-kvm-0.12.3-device delete mode 100644 tests/qemuhelpdata/qemu-kvm-0.13.0 delete mode 100644 tests/qemuhelpdata/qemu-kvm-0.13.0-device delete mode 100644 tests/qemuhelpdata/qemu-kvm-1.2.0 delete mode 100644 tests/qemuhelptest.c delete mode 100644 tests/qemuxml2argvdata/channel-spicevmc-old.args delete mode 100644 tests/qemuxml2argvdata/channel-spicevmc-old.xml -- 2.16.1

6 61

[libvirt] [RFC PATCH 0/2] qemu: deny privilege elevation and spawn in seccomp
by Ján Tomko 03 Apr '18

03 Apr '18

QEMU changed the behavior of -sandbox on since 2.11 and it no longer whitelists all the possible calls. Override the meaning of seccomp_sandbox = 1 in qemu.conf to block the privilege elevation set and spawn set on top of the default. Do the same by default even if no option is specified, hoping that this should be enough for everybody (TM) Sending as RFC to ask whether: * this is a sensible default * a coarse setting like this is enough or it makes sense to expose the individual sets in qemu.conf (in that case - can I reasonably promote an int setting to a list of strings?) Ján Tomko (2): Introduce QEMU_CAPS_SECCOMP_BLACKLIST qemu: deny privilege elevation and spawn in seccomp src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 10 +++++-- tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_2.12.0.aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_2.12.0.ppc64.xml | 1 + tests/qemucapabilitiesdata/caps_2.12.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml | 1 + tests/qemuxml2argvdata/minimal-sandbox.args | 25 ++++++++++++++++ tests/qemuxml2argvdata/minimal-sandbox.xml | 34 ++++++++++++++++++++++ tests/qemuxml2argvtest.c | 3 ++ 11 files changed, 78 insertions(+), 2 deletions(-) create mode 100644 tests/qemuxml2argvdata/minimal-sandbox.args create mode 100644 tests/qemuxml2argvdata/minimal-sandbox.xml -- 2.13.6

2 3