April 2018 - Devel - libvirt List Archives

[libvirt] [PATCH v2 0/2] Rename/remove virDomainObjListFindBy{UUID|ID}Ref
by John Ferlan 20 Apr '18

20 Apr '18

These were actually posted before as part of a larger series to rework/rename virDomainObjListFindBy{UUID|ID}Ref as patches 19 and 20: https://www.redhat.com/archives/libvir-list/2018-March/msg00508.html https://www.redhat.com/archives/libvir-list/2018-March/msg00509.html Even though it's only 6 weeks ago, attempting to remember what (if anything) has changed is challenging. In the long run, the point is that the *Ref specific functions are now removed. This makes it much easier for the next step which will be to modify the Add/Remove logic to be simpler and more realistic w/r/t expectations as well as remove a few comments in the code that indicate some day we need to fix this crazy problem (some day is getting closer). John Ferlan (2): conf: Rework/rename virDomainObjListFindByUUIDRef conf: Rework/rename virDomainObjListFindByIDRef src/bhyve/bhyve_driver.c | 6 ++-- src/conf/virdomainobjlist.c | 66 ++++++++++---------------------------------- src/conf/virdomainobjlist.h | 4 --- src/libvirt_private.syms | 2 -- src/libxl/libxl_domain.c | 2 +- src/libxl/libxl_driver.c | 6 ++-- src/lxc/lxc_driver.c | 7 ++--- src/openvz/openvz_driver.c | 4 +-- src/qemu/qemu_driver.c | 9 +++--- src/test/test_driver.c | 6 ++-- src/uml/uml_driver.c | 6 ++-- src/util/virclosecallbacks.c | 4 +-- src/vmware/vmware_driver.c | 4 +-- src/vz/vz_driver.c | 6 ++-- src/vz/vz_sdk.c | 14 +++++----- src/vz/vz_utils.c | 2 +- 16 files changed, 51 insertions(+), 97 deletions(-) -- 2.13.6

2 4

[libvirt] [PATCH] git: add config file telling git-publish how to send patches
by Daniel P. Berrangé 20 Apr '18

20 Apr '18

The "git-publish" tool is a useful git extension for sending patch series for code review. It automatically creates versioned tags each time code on a branch is sent, so that there is a record of each version. It also remembers the cover letter so it does not need re-entering each time the series is reposted. With this config file present it is now sufficient[1] to run $ git publish to send all patches in a branch to the list for review [1] Assuming your $HOME/.gitconfig has an SMTP server listed at least e.g. [sendemail] smtpserver = smtp.example.com Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- .gitpublish | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 .gitpublish diff --git a/.gitpublish b/.gitpublish new file mode 100644 index 0000000000..857f0d552c --- /dev/null +++ b/.gitpublish @@ -0,0 +1,3 @@ +[gitpublishprofile "default"] +base = master +to = libvir-list(a)redhat.com -- 2.14.3

3 7

[libvirt] [dbus PATCH] Fix GError memory leaks
by Pavel Hrdina 20 Apr '18

20 Apr '18

Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- src/gdbus.c | 8 ++++---- src/main.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/gdbus.c b/src/gdbus.c index cb06813..3407116 100644 --- a/src/gdbus.c +++ b/src/gdbus.c @@ -86,7 +86,7 @@ virtDBusGDBusHandlePropertyGet(GVariant *parameters, const gchar *interface; const gchar *name; GVariant *value = NULL; - GError *error = NULL; + g_autoptr(GError) error = NULL; g_variant_get(parameters, "(&s&s)", &interface, &name); @@ -128,7 +128,7 @@ virtDBusGDBusHandlePropertySet(GVariant *parameters, const gchar *interface; const gchar *name; g_autoptr(GVariant) value = NULL; - GError *error = NULL; + g_autoptr(GError) error = NULL; g_variant_get(parameters, "(&s&sv)", &interface, &name, &value); @@ -162,7 +162,7 @@ virtDBusGDBusHandlePropertyGetAll(GDBusMethodInvocation *invocation, { GVariant *value; g_auto(GVariantBuilder) builder; - GError *error = NULL; + g_autoptr(GError) error = NULL; g_variant_builder_init(&builder, G_VARIANT_TYPE("(a{sv})")); @@ -202,7 +202,7 @@ virtDBusGDBusHandleMethod(GVariant *parameters, GUnixFDList *inFDs = NULL; GVariant *outArgs = NULL; GUnixFDList *outFDs = NULL; - GError *error = NULL; + g_autoptr(GError) error = NULL; for (gint i = 0; data->methods[i].name; i++) { if (g_str_equal(methodName, data->methods[i].name)) { diff --git a/src/main.c b/src/main.c index b3baf76..eb30ef8 100644 --- a/src/main.c +++ b/src/main.c @@ -52,7 +52,7 @@ virtDBusAcquired(GDBusConnection *connection, gpointer opaque) { virtDBusRegisterData *data = opaque; - GError *error = NULL; + g_autoptr(GError) error = NULL; for (gsize i = 0; i < data->ndrivers; i += 1) { virtDBusConnectNew(&data->connectList[i], connection, -- 2.14.3

2 1

[libvirt] [dbus PATCH 0/3] Introduce GVariant to TypedParams helper
by Pavel Hrdina 20 Apr '18

20 Apr '18

Pavel Hrdina (3): util: Introduce virtDBusUtilTypedParams util: Introduce virtDBusUtilGVariantToTypedParams domain: Implement SetPerfEvents method data/org.libvirt.Domain.xml | 6 +++ src/domain.c | 31 ++++++++++++++++ src/util.c | 89 +++++++++++++++++++++++++++++++++++++++++++++ src/util.h | 17 +++++++++ 4 files changed, 143 insertions(+) -- 2.14.3

2 6

[libvirt] --disable-nls is ignored in master
by Olaf Hering 20 Apr '18

20 Apr '18

It seems some of the recent changes for 'po' broke the --disable-nls configure option. I expect no locales will be installed with --disable-nls, but they are installed anyway. This leads to the well known "error: Installed (but unpackaged) file(s) found:" failure. I tested libvirt-20180420T081114.3c66d5108. Olaf

2 1

[libvirt] [dbus PATCH v2] Implement GetAllDomainStats method for Connect Interface
by Katerina Koukiou 20 Apr '18

20 Apr '18

Signed-off-by: Katerina Koukiou <kkoukiou(a)redhat.com> --- data/org.libvirt.Connect.xml | 7 +++++++ src/connect.c | 47 ++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 54 insertions(+) diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml index 14e66e4..ee7bfdc 100644 --- a/data/org.libvirt.Connect.xml +++ b/data/org.libvirt.Connect.xml @@ -94,6 +94,13 @@ <arg name="flags" type="u" direction="in"/> <arg name="storagePoolSources" type="s" direction="out"/> </method> + <method name="GetAllDomainStats"> + <annotation name="org.gtk.GDBus.DocString" + value="See https://libvirt.org/html/libvirt-libvirt-domain.html#virConnectGetAllDomain…"/> + <arg name="stats" type="u" direction="in"/> + <arg name="flags" type="u" direction="in"/> + <arg name="records" type="a(sa{sv})" direction="out"/> + </method> <method name="GetCapabilities"> <annotation name="org.gtk.GDBus.DocString" value="See https://libvirt.org/html/libvirt-libvirt-host.html#virConnectGetCapabilities"/> diff --git a/src/connect.c b/src/connect.c index 1ef5c93..48db724 100644 --- a/src/connect.c +++ b/src/connect.c @@ -503,6 +503,52 @@ virtDBusConnectFindStoragePoolSources(GVariant *inArgs, *outArgs = g_variant_new("(s)", ret); } +static void +virtDBusConnectGetAllDomainStats(GVariant *inArgs, + GUnixFDList *inFDs G_GNUC_UNUSED, + const gchar *objectPath G_GNUC_UNUSED, + gpointer userData, + GVariant **outArgs, + GUnixFDList **outFDs G_GNUC_UNUSED, + GError **error) +{ + virtDBusConnect *connect = userData; + g_autoptr(virDomainStatsRecordPtr) records = NULL; + guint stats; + gint nstats; + guint flags; + GVariant *gret; + GVariantBuilder builder; + + g_variant_get(inArgs, "(uu)", &stats, &flags); + + if (!virtDBusConnectOpen(connect, error)) + return; + + nstats = virConnectGetAllDomainStats(connect->connection, + stats, &records, flags); + if (nstats < 0) + return virtDBusUtilSetLastVirtError(error); + + g_variant_builder_init(&builder, G_VARIANT_TYPE("a(sa{sv})")); + + for (gint i = 0; i < nstats; i++) { + const gchar* name; + GVariant *grecords; + + g_variant_builder_open(&builder, G_VARIANT_TYPE("(sa{sv})")); + name = virDomainGetName(records[i]->dom); + grecords = virtDBusUtilTypedParamsToGVariant(records[i]->params, + records[i]->nparams); + g_variant_builder_add(&builder, "s", name); + g_variant_builder_add_value(&builder, grecords); + g_variant_builder_close(&builder); + } + gret = g_variant_builder_end(&builder); + + *outArgs = g_variant_new_tuple(&gret, 1); +} + static void virtDBusConnectGetCPUModelNames(GVariant *inArgs, GUnixFDList *inFDs G_GNUC_UNUSED, @@ -808,6 +854,7 @@ static virtDBusGDBusMethodTable virtDBusConnectMethodTable[] = { { "DomainRestore", virtDBusConnectDomainRestoreFlags }, { "DomainSaveImageDefineXML", virtDBusConnectDomainSaveImageDefineXML }, { "FindStoragePoolSources", virtDBusConnectFindStoragePoolSources }, + { "GetAllDomainStats", virtDBusConnectGetAllDomainStats }, { "GetCapabilities", virtDBusConnectGetCapabilities }, { "GetCPUModelNames", virtDBusConnectGetCPUModelNames }, { "GetDomainCapabilities", virtDBusConnectGetDomainCapabilities }, -- 2.15.0

2 1

[libvirt] [PATCH] remote: remove obsolete & incorrect comment from libvirtd.conf
by Daniel P. Berrangé 20 Apr '18

20 Apr '18

The libvirtd.conf file has a comment pointing people to format.html which has nothing todo with the configuration file format. It also has a comment about tests/daemon-conf which no longer exists, and even if it did exist such comment is not relevant to end users when this file is installed in /etc/. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- src/remote/libvirtd.conf | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/remote/libvirtd.conf b/src/remote/libvirtd.conf index 7d823cf1ad..28df4021aa 100644 --- a/src/remote/libvirtd.conf +++ b/src/remote/libvirtd.conf @@ -1,10 +1,5 @@ # Master libvirt daemon configuration file # -# For further information consult https://libvirt.org/format.html -# -# NOTE: the tests/daemon-conf regression test script requires -# that each "PARAMETER = VALUE" line in this file have the parameter -# name just after a leading "#". ################################################################# # -- 2.14.3

2 1

[libvirt] [dbus PATCH 0/8] Last APIs for Connect Interface
by Katerina Koukiou 20 Apr '18

20 Apr '18

Notes: - I am not confident about the dummy test on StoragePoolSources. - In GetAllDomainStats I was not able to find a way to create output (aa{sv}) as we need. So I created simple (av), hiding the inner array type. Katerina Koukiou (8): Implement BaselineCPU method for Connect Interface Implement CompareCPU method for Connect Interface Implement FindStoragePoolSources for Domain Interface Move definition for g_autoptr virDomainStatsRecordPtr to util.h Implement GetAllDomainStats method for Connect Interface Introduce virtDBusUtilStringListFree Implement GetCPUModelNames method for Connect Interface Implement GetDomainCapabilties method for Connect Interface data/org.libvirt.Connect.xml | 47 ++++++++++ src/connect.c | 219 +++++++++++++++++++++++++++++++++++++++++++ src/domain.c | 2 - src/util.c | 9 ++ src/util.h | 9 ++ tests/test_connect.py | 9 ++ 6 files changed, 293 insertions(+), 2 deletions(-) -- 2.15.0

3 24

[libvirt] [REPOST PATCH 0/2] vz - Clean/fix test driver usage of FindBy{UUID|ID}
by John Ferlan 20 Apr '18

20 Apr '18

Reposting patches 16-17 from: https://www.redhat.com/archives/libvir-list/2018-March/msg00489.html Reposting and using the vz prefix to make it clearer/cleaner as to what's changing (since the 20 patch series perhaps was a bit too daunting to look through it all). There are no changes since v1. John Ferlan (2): vz: Unify vzDomObjFromDomain{Ref} vz: Use virDomainObjListFindBy{UUID|ID}Ref src/vz/vz_driver.c | 119 ++++++++++++++++++++++++++--------------------------- src/vz/vz_sdk.c | 15 +++---- src/vz/vz_utils.c | 32 +------------- src/vz/vz_utils.h | 1 - 4 files changed, 68 insertions(+), 99 deletions(-) -- 2.13.6

2 8

[libvirt] [PATCH jenkins-ci] Add missing job dependencies for libvirt-glib/virt-viewer mingw builds
by Daniel P. Berrangé 20 Apr '18

20 Apr '18

Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- projects/libvirt-glib.yaml | 4 ++-- projects/virt-viewer.yaml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/projects/libvirt-glib.yaml b/projects/libvirt-glib.yaml index 2d0e721..286d25b 100644 --- a/projects/libvirt-glib.yaml +++ b/projects/libvirt-glib.yaml @@ -15,13 +15,13 @@ parent_jobs: 'libvirt-glib-master-check' machines: '{rpm_machines}' - autotools-build-job: - parent_jobs: + parent_jobs: 'libvirt-master-build-mingw32' variant: -mingw32 local_env: '{mingw32_local_env}' autogen_args: '{mingw32_autogen_args}' machines: '{mingw_machines}' - autotools-build-job: - parent_jobs: + parent_jobs: 'libvirt-master-build-mingw64' variant: -mingw64 local_env: '{mingw64_local_env}' autogen_args: '{mingw64_autogen_args}' diff --git a/projects/virt-viewer.yaml b/projects/virt-viewer.yaml index 3726cd0..633ac9a 100644 --- a/projects/virt-viewer.yaml +++ b/projects/virt-viewer.yaml @@ -14,13 +14,13 @@ parent_jobs: 'virt-viewer-master-check' machines: '{rpm_machines}' - autotools-build-job: - parent_jobs: + parent_jobs: 'libvirt-glib-master-build-mingw32' variant: -mingw32 local_env: '{mingw32_local_env}' autogen_args: '{mingw32_autogen_args}' machines: '{mingw_machines}' - autotools-build-job: - parent_jobs: + parent_jobs: 'libvirt-glib-master-build-mingw64' variant: -mingw64 local_env: '{mingw64_local_env}' autogen_args: '{mingw64_autogen_args}' -- 2.14.3

2 1