August 2017 - Devel - libvirt List Archives

[libvirt] [PATCH 0/8] some parsing cleanup and improvements
by Pavel Hrdina 14 Aug '17

14 Aug '17

Pavel Hrdina (8): util: introduce virXMLNodeNameEqual use virXMLNodeNameEqual instead of xmlStrEqual conf: cleanup virDomainChrSourceDef parsing conf: use virXMLPropString for KeyWrapCipherDef parsing conf: use virXMLPropString for disk geometry parsing conf: use virXMLPropString for IOThread parsing conf: use virXMLPropString for IOThread pin parsing conf: use virXMLPropString for Domain def parsing src/conf/cpu_conf.c | 2 +- src/conf/domain_conf.c | 373 ++++++++++++++++------------------- src/conf/interface_conf.c | 2 +- src/conf/netdev_bandwidth_conf.c | 6 +- src/conf/netdev_vport_profile_conf.c | 2 +- src/conf/network_conf.c | 12 +- src/conf/node_device_conf.c | 2 +- src/conf/nwfilter_conf.c | 6 +- src/conf/nwfilter_params.c | 2 +- src/conf/secret_conf.c | 2 +- src/conf/snapshot_conf.c | 2 +- src/conf/storage_conf.c | 4 +- src/conf/virnetworkobj.c | 2 +- src/conf/virsavecookie.c | 2 +- src/esx/esx_vi_types.c | 9 +- src/libvirt_private.syms | 1 + src/security/virt-aa-helper.c | 2 +- src/test/test_driver.c | 2 +- src/util/virxml.c | 16 ++ src/util/virxml.h | 3 + src/vz/vz_sdk.c | 2 +- tools/virsh-domain.c | 18 +- tools/virsh-interface.c | 12 +- 23 files changed, 236 insertions(+), 248 deletions(-) -- 2.13.5

2 10

[libvirt] [PATCH v2] tests: add qemu x86 kvm 32-on-64 test
by Cole Robinson 14 Aug '17

14 Aug '17

There's some specific logic in qemuBuildCpuCommandLine to support auto adding -cpu qemu 32 for arch=i686 with an x86_64 qemu binary. Add a test case for it Signed-off-by: Cole Robinson <crobinso(a)redhat.com> --- v2: Drop unnecessary qemu-kvm path usage .../qemuxml2argv-x86-kvm-32-on-64.args | 21 +++++++++++++++++++++ .../qemuxml2argv-x86-kvm-32-on-64.xml | 13 +++++++++++++ tests/qemuxml2argvtest.c | 1 + 3 files changed, 35 insertions(+) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-x86-kvm-32-on-64.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-x86-kvm-32-on-64.xml diff --git a/tests/qemuxml2argvdata/qemuxml2argv-x86-kvm-32-on-64.args b/tests/qemuxml2argvdata/qemuxml2argv-x86-kvm-32-on-64.args new file mode 100644 index 000000000..5b644b0a6 --- /dev/null +++ b/tests/qemuxml2argvdata/qemuxml2argv-x86-kvm-32-on-64.args @@ -0,0 +1,21 @@ +LC_ALL=C \ +PATH=/bin \ +HOME=/home/test \ +USER=test \ +LOGNAME=test \ +QEMU_AUDIO_DRV=none \ +/usr/bin/qemu-system-x86_64 \ +-name kvm \ +-S \ +-machine pc,accel=kvm \ +-cpu qemu32 \ +-m 4096 \ +-smp 1,sockets=1,cores=1,threads=1 \ +-uuid d091ea82-29e6-2e34-3005-f02617b36e87 \ +-nographic \ +-nodefaults \ +-chardev socket,id=charmonitor,path=/tmp/lib/domain--1-kvm/monitor.sock,server,\ +nowait \ +-mon chardev=charmonitor,id=monitor,mode=readline \ +-no-acpi \ +-boot c diff --git a/tests/qemuxml2argvdata/qemuxml2argv-x86-kvm-32-on-64.xml b/tests/qemuxml2argvdata/qemuxml2argv-x86-kvm-32-on-64.xml new file mode 100644 index 000000000..37f53bf2a --- /dev/null +++ b/tests/qemuxml2argvdata/qemuxml2argv-x86-kvm-32-on-64.xml @@ -0,0 +1,13 @@ +<domain type='kvm'> + <name>kvm</name> + <uuid>d091ea82-29e6-2e34-3005-f02617b36e87</uuid> + <memory unit='KiB'>4194304</memory> + <os> + <type arch='i686'>hvm</type> + </os> + <devices> + <emulator>/usr/bin/qemu-system-x86_64</emulator> + <controller type='usb' model='none'/> + <memballoon model='none'/> + </devices> +</domain> diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index aa83013a2..f74d45ba0 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -709,6 +709,7 @@ mymain(void) DO_TEST("kvm", QEMU_CAPS_MACHINE_OPT); DO_TEST("default-kvm-host-arch", QEMU_CAPS_MACHINE_OPT); DO_TEST("default-qemu-host-arch", QEMU_CAPS_MACHINE_OPT); + DO_TEST("x86-kvm-32-on-64", QEMU_CAPS_MACHINE_OPT); DO_TEST("boot-cdrom", NONE); DO_TEST("boot-network", NONE); DO_TEST("boot-floppy", NONE); -- 2.13.3

2 1

[libvirt] Request for review: [PATCH v3 0/3] implement migrate-getmaxdowntime command
by Scott Garfinkle 14 Aug '17

14 Aug '17

I think this may have gotten lost in the 3.6 release. Does someone have the time to review this, please? The patches still apply cleanly (albeit with fuzz) at the current level. -Scott Garfinkle

2 1

[libvirt] [PATCH] vbox: fix typo in warning message
by Guido Günther 14 Aug '17

14 Aug '17

--- src/vbox/vbox_tmpl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vbox/vbox_tmpl.c b/src/vbox/vbox_tmpl.c index 07f25ba24f..dffeabde02 100644 --- a/src/vbox/vbox_tmpl.c +++ b/src/vbox/vbox_tmpl.c @@ -1836,7 +1836,7 @@ _mediumCreateDiffStorage(IMedium *medium ATTRIBUTE_UNUSED, if (variantSize == 0) return 0; if (variantSize > 1) - VIR_WARN("Only one variant is avaible in current version"); + VIR_WARN("Only one variant is available in current version"); return medium->vtbl->CreateDiffStorage(medium, target, variant[0], progress); #else /* VBOX_API_VERSION >= 4003000 */ return medium->vtbl->CreateDiffStorage(medium, target, variantSize, variant, progress); -- 2.14.0

3 3

[libvirt] [PATCH 0/2] Two Coverity Fixes (thanks John!)
by Laine Stump 14 Aug '17

14 Aug '17

John found these two problems with Coverity after I pushed my series fixing MAC address saving/setting on Mellanox dual port NICs. Laine Stump (2): util: fix Coverity complaint (and actual bug) in virHostdevReadNetConfig() util: fix Coverity complaint in virNetDevSetNetConfig() src/util/virhostdev.c | 2 +- src/util/virnetdev.c | 4 +--- 2 files changed, 2 insertions(+), 4 deletions(-) -- 2.13.3

3 4

[libvirt] [PATCH v2] Update to latest keycodemapdb content
by Daniel P. Berrange 14 Aug '17

14 Aug '17

Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- src/Makefile.am | 2 +- src/keycodemapdb | 2 +- src/util/virkeycode.c | 5 ++--- tests/virkeycodetest.c | 4 ++-- 4 files changed, 6 insertions(+), 7 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index b8e875482..45b58c0ad 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -252,7 +252,7 @@ util/virkey%.7: util/virkey%.pod rm -f $@-t1 && \ mv $@-t2 $@ -KEYCODES = linux osx atset1 atset2 atset3 xt xtkbd usb win32 rfb +KEYCODES = linux osx atset1 atset2 atset3 xtkbd usb win32 rfb KEYNAMES = linux osx win32 KEYTABLES = \ diff --git a/src/keycodemapdb b/src/keycodemapdb index 7bf5710b2..267157b96 160000 --- a/src/keycodemapdb +++ b/src/keycodemapdb @@ -1 +1 @@ -Subproject commit 7bf5710b22aa8d58b7eeaaf3dc6960c26cade4f0 +Subproject commit 267157b96c62b5445de9cddd21de42fcd943ffe6 diff --git a/src/util/virkeycode.c b/src/util/virkeycode.c index e09aaadaa..eda263218 100644 --- a/src/util/virkeycode.c +++ b/src/util/virkeycode.c @@ -30,7 +30,6 @@ #include "virkeycodetable_rfb.h" #include "virkeycodetable_usb.h" #include "virkeycodetable_win32.h" -#include "virkeycodetable_xt.h" #include "virkeycodetable_xtkbd.h" #include "virkeynametable_linux.h" #include "virkeynametable_osx.h" @@ -44,7 +43,8 @@ static const char **virKeymapNames[VIR_KEYCODE_SET_LAST] = { static const unsigned short *virKeymapValues[VIR_KEYCODE_SET_LAST] = { [VIR_KEYCODE_SET_LINUX] = virKeyCodeTable_linux, - [VIR_KEYCODE_SET_XT] = virKeyCodeTable_xt, + /* XT is same as AT Set1 - it was included by mistake */ + [VIR_KEYCODE_SET_XT] = virKeyCodeTable_atset1, [VIR_KEYCODE_SET_ATSET1] = virKeyCodeTable_atset1, [VIR_KEYCODE_SET_ATSET2] = virKeyCodeTable_atset2, [VIR_KEYCODE_SET_ATSET3] = virKeyCodeTable_atset3, @@ -57,7 +57,6 @@ static const unsigned short *virKeymapValues[VIR_KEYCODE_SET_LAST] = { #define VIR_KEYMAP_ENTRY_MAX ARRAY_CARDINALITY(virKeyCodeTable_linux) -verify(VIR_KEYMAP_ENTRY_MAX == ARRAY_CARDINALITY(virKeyCodeTable_xt)); verify(VIR_KEYMAP_ENTRY_MAX == ARRAY_CARDINALITY(virKeyCodeTable_atset1)); verify(VIR_KEYMAP_ENTRY_MAX == ARRAY_CARDINALITY(virKeyCodeTable_atset2)); verify(VIR_KEYMAP_ENTRY_MAX == ARRAY_CARDINALITY(virKeyCodeTable_atset3)); diff --git a/tests/virkeycodetest.c b/tests/virkeycodetest.c index d754385be..4092aa119 100644 --- a/tests/virkeycodetest.c +++ b/tests/virkeycodetest.c @@ -56,9 +56,9 @@ static int testKeycodeMapping(const void *data ATTRIBUTE_UNUSED) TRANSLATE(LINUX, USB, 111, 76); TRANSLATE(LINUX, RFB, 88, 88); TRANSLATE(LINUX, RFB, 160, 163); - TRANSLATE(ATSET2, ATSET3, 259, 55); + TRANSLATE(ATSET2, ATSET3, 131, 55); TRANSLATE(OSX, WIN32, 90, 131); - TRANSLATE(OSX, ATSET1, 90, 0); + TRANSLATE(OSX, ATSET1, 90, 90); TRANSLATE(OSX, ATSET1, 3200, -1); #undef TRANSLATE -- 2.13.3

2 1

[libvirt] [PATCH v2 0/7] properly deal with multiple netdevs on a single PF (i.e. Mellanox dual port NICS)
by Laine Stump 12 Aug '17

12 Aug '17

I had already sent 3 patches to properly support macvtap passthrough of both ports of a dual port VF, and those patches were ACKed by Michal: https://www.redhat.com/archives/libvir-list/2017-August/msg00170.html When Michal sent the ACK, I was already working on a V2 that updated Patch 2 (now Patch 3), and added on some more patches in order to properly support VFIO device assignment of VFs on these cards (but only if they've been setup in single port mode). A scorecard: Patch 1 - same as V1, already ACKed Patch 2 - NEW trivial patch to make an arg of a function const Patch 3 - update virPCIGetNetName() - improved from V1 Patch 4 - match phys_port_id, slightly modified from V1 due to change in virPCIGetNetName in new Patch 3. Patch 5 - NEW save/set/restore using correct PF netdev during vfio Patch 6 - NEW eliminate bogus error logs when trying to read saved net config Patch 7 - NEW fix checking of PF online status for dual port cards Here's the original cover letter blurb: The commit log of Patch 1 explains the majority of the reason for these patches. In short, they disambiguate the multiple netdevs per PCI device on the SRIOV PF and VFs of a Mellanox dual port NIC *when converting from a VF netdev to a PF netdev and vice versa*. This permits us to set the vlan tag and MAC address for the correct VF netdev (and detect the online status of the correct PF netdev for that VF) when using a VF in macvtap passthrough mode. (in other words, with these patches in place, it is possible to use *all* the VF netdevs on both ports of a dual port mellanox NIC for macvtap passthrough.) These patches *do not* solve the problem of saving/setting the mac address/vlan tag for *both* ports when using a dual port VF for PCI device assignment with VFIO (see my RFC email from last week). Since I learned from responses to the RFC that these "dual netdevs on a single PCI PF/VF" cards are legacy, and all new Mellanox products have only one netdev per PF/VF (like all the other SRIOV NICs on the market), I've decided that it's not worth cluttering up libvirt's XML with config for a dying breed. Since it's possible to support VFIO device assignment on those cards when the VFs are in single port mode, I think it is worthwhile to make that work, so that owners of the older cards can get maximum value from their investment. Laine Stump (7): util: new function virNetDevGetPhysPortID() util: Fix const'ness of 1st arg to virPCIGetNetName() util: make virPCIGetNetName() more versatile util: match phys_port_id when converting PF-netdev to/from VF-netdev util: save the correct VF's info when using a dual port SRIOV NIC in single port mode util: restructure virNetDevReadNetConfig() to eliminate false error logs util: check for PF online status earlier in guest startup src/libvirt_private.syms | 1 + src/util/virhostdev.c | 137 ++++++++++++++++++++++++++------------ src/util/virnetdev.c | 159 ++++++++++++++++++++++++++++++++++---------- src/util/virnetdev.h | 5 ++ src/util/virnetdevmacvlan.c | 5 +- src/util/virpci.c | 97 +++++++++++++++++++++++---- src/util/virpci.h | 9 ++- 7 files changed, 316 insertions(+), 97 deletions(-) -- 2.13.3

3 10

[libvirt] [PATCH] apparmor, libvirt-qemu: Allow QEMU to gather information about available host resources.
by intrigeri 11 Aug '17

11 Aug '17

--- examples/apparmor/libvirt-qemu | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/examples/apparmor/libvirt-qemu b/examples/apparmor/libvirt-qemu index f462d7428c..dcfb1a5985 100644 --- a/examples/apparmor/libvirt-qemu +++ b/examples/apparmor/libvirt-qemu @@ -169,3 +169,9 @@ @{PROC}/device-tree/ r, @{PROC}/device-tree/** r, /sys/firmware/devicetree/** r, + + # for gathering information about available host resources + /sys/devices/system/cpu/ r, + /sys/devices/system/node/ r, + /sys/devices/system/node/node[0-9]*/meminfo r, + /sys/module/vhost/parameters/max_mem_regions r, -- 2.14.0

3 2

[libvirt] [PATCH] m4: workaround clang/glibc problem with isnan()
by Daniel P. Berrange 11 Aug '17

11 Aug '17

When building libvirt with clang we get bogus warnings about 'double' being promoted to 'long double' when calling isnan(). https://bugzilla.redhat.com/show_bug.cgi?id=1472437 Detect this broken isnan() / compiler combination and disable the -Wdouble-promotion flag. Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- m4/virt-compile-warnings.m4 | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/m4/virt-compile-warnings.m4 b/m4/virt-compile-warnings.m4 index fa0940fc6..7b56115ce 100644 --- a/m4/virt-compile-warnings.m4 +++ b/m4/virt-compile-warnings.m4 @@ -134,6 +134,24 @@ AC_DEFUN([LIBVIRT_COMPILE_WARNINGS],[ [lv_cv_gcc_wlogical_op_equal_expr_broken=yes]) CFLAGS="$save_CFLAGS"]) + AC_CACHE_CHECK([whether clang gives bogus warnings for -Wdouble-promotion], + [lv_cv_clang_double_promotion_broken], [ + save_CFLAGS="$CFLAGS" + CFLAGS="-O2 -Wdouble-promotion -Werror" + AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[ + #include <math.h> + ]], [[ + float f = 0.0; + return isnan(f);]])], + [lv_cv_clang_double_promotion_broken=no], + [lv_cv_clang_double_promotion_broken=yes]) + CFLAGS="$save_CFLAGS"]) + + if test "$lv_cv_clang_double_promotion_broken" = "yes"; + then + dontwarn="$dontwarn -Wdouble-promotion" + fi + # We might fundamentally need some of these disabled forever, but # ideally we'd turn many of them on dontwarn="$dontwarn -Wfloat-equal" -- 2.13.3

2 1

[libvirt] [PATCH 0/5] Random pre-CAT cleanups
by Martin Kletzander 11 Aug '17

11 Aug '17

There are some patches that don't look related, but I found out they are messed up when working on previous versions that got discarded. Why not keep the cleanups, though, right? Martin Kletzander (5): virxml: Fix indentation tests: Fix indentation in virfilewrapper.c Move resctrl-related code from conf/capabilities to util/virresctrl util: Make virResctrlGetCacheControlType() behave like other functions util: Rename virResctrl to virResctrlInfo include/libvirt/virterror.h | 1 + src/Makefile.am | 1 + src/conf/capabilities.c | 144 +++++----------------------------- src/conf/capabilities.h | 26 +----- src/libvirt_private.syms | 7 ++ src/util/virerror.c | 1 + src/util/virresctrl.c | 187 ++++++++++++++++++++++++++++++++++++++++++++ src/util/virresctrl.h | 63 +++++++++++++++ src/util/virxml.c | 34 ++++---- tests/virfilewrapper.c | 4 +- 10 files changed, 302 insertions(+), 166 deletions(-) create mode 100644 src/util/virresctrl.c create mode 100644 src/util/virresctrl.h -- 2.14.0

2 6