March 2017 - Devel - libvirt List Archives

[libvirt] [GSOC] project libvirt fuzzing
by Da L 31 Mar '17

31 Mar '17

Dear all, This is my first post in the list. I am currently a graduate student studying computer science, particularly interested in visualization technologies and I have been using QEMU for a variety of projects for a while. Two of the courses that I am taking this semester really attracted me to the libvirt community are Advanced Operating Systems and Secure Software Development. I have been learning kernel fuzzing as well as other general fuzzing tools. Then I found the topic of "QEMU command line generator XML fuzzing" is pretty interesting and totally in line with my interest and background. Though I have read through the documentations on the website, just to make sure I am doing it correctly, could anyone confirm this project is still available? And what I need to do next in order to participate the project this summer? Do I need to find a mentor by myself? Potentially, I could find my OS or Security professor as my mentor, but I am not sure yet which would be the best way. Thanks, Dan

6 18

[libvirt] [PATCH v2 0/4] Add schema validation for news
by Peter Krempa 31 Mar '17

31 Mar '17

v2: - rename DO_TEST to DO_TEST_DIR along with changes in the first patch - add 'abs_srcdir' to the tested XML path so that vpath builds work - fix wording of the rules for adding news entries - fix commit messages Peter Krempa (4): tests: schema: Add possibility to validate individual files news: Introduce rules for the schema file and fix offending lines schema: Introduce schema for the news.xml file news: Add template for a <release> section docs/news.xml | 62 ++++++++++++++++++++++++++++++++--------- docs/schemas/news.rng | 73 ++++++++++++++++++++++++++++++++++++++++++++++++ tests/virschematest.c | 77 ++++++++++++++++++++++++++++++++------------------- 3 files changed, 171 insertions(+), 41 deletions(-) create mode 100644 docs/schemas/news.rng -- 2.12.1

2 7

[libvirt] [PATCH] news: Make changes understandable for users
by Martin Kletzander 30 Mar '17

30 Mar '17

When reading release notes, patch summary is not always the best description of what users can expect in new version. I propose changing it slightly so that it describes what exactly happens and when. However, we do not have to add every single code change to the news file, that would be ridiculous and unreadable for users. If the patch subject needs changes like this one, I'm rather tempted to say that such changes should not be in the news file at all. So that would be the other way how to fix this. Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- docs/news.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/news.xml b/docs/news.xml index eb0f2426be25..494c6489b9c5 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -706,7 +706,7 @@ </change> <change> <summary> - logical: Need to overwrite/clear more than just first 512 bytes + Overwrite (clear) 2 KB instead of just 512 bytes when initializing logical device </summary> </change> <change> -- 2.12.2

4 9

[libvirt] [PATCH] network: Drop unused networkRestartRadvd
by Michal Privoznik 30 Mar '17

30 Mar '17

Since its introduction in 1ce4922e720 this function lived as an outcast in an #if 0 block. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/network/bridge_driver.c | 27 --------------------------- 1 file changed, 27 deletions(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 5ccd37a..ddd2a3a 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -1980,33 +1980,6 @@ networkRefreshRadvd(virNetworkDriverStatePtr driver, return kill(network->radvdPid, SIGHUP); } -#if 0 -/* currently unused, so it causes a build error unless we #if it out */ -static int -networkRestartRadvd(virNetworkObjPtr network) -{ - char *radvdpidbase; - - /* if there is a running radvd, kill it */ - if (network->radvdPid > 0) { - /* essentially ignore errors from the following two functions, - * since there's really no better recovery to be done than to - * just push ahead (and that may be exactly what's needed). - */ - if ((networkKillDaemon(network->radvdPid, "radvd", - network->def->name) >= 0) && - ((radvdpidbase = networkRadvdPidfileBasename(network->def->name)) - != NULL)) { - virPidFileDelete(driver->pidDir, radvdpidbase); - VIR_FREE(radvdpidbase); - } - network->radvdPid = -1; - } - /* now start radvd if it should be started */ - return networkStartRadvd(network); -} -#endif /* #if 0 */ - static int networkRefreshDaemonsHelper(virNetworkObjPtr net, void *opaque) -- 2.10.2

2 1

[libvirt] Entering freeze for libvirt-3.2.0
by Daniel Veillard 30 Mar '17

30 Mar '17

Hi all, as planned I tagged RC1 in git and pushed signed tarball and rpms to the usual place: ftp://libvirt.org/libvirt/ I had an issue with networking in my limited testing, without time to really dig it seems my guest image wasn't able to do DNS resolution, that could be an issue on my side though, and https://ci.centos.org/view/libvirt/ while not all green seems rather positive ! Please give it a try, I will probably push RC2 on Thursday, and assuming everything goes fine a release over the week-end, thanks ! Daniel -- Daniel Veillard | Red Hat Developers Tools http://developer.redhat.com/ veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

2 3

[libvirt] [PATCH 0/3] storage: remove inactive transient pools after restart
by Peter Krempa 30 Mar '17

30 Mar '17

Peter Krempa (3): storage: backend: Use correct stringifier for pool type storage: driver: Split out code fixing pool state after deactivation storage: driver: Remove unavailable transient pools after restart src/storage/storage_backend.c | 2 +- src/storage/storage_driver.c | 68 ++++++++++++++++++++++++++----------------- 2 files changed, 42 insertions(+), 28 deletions(-) -- 2.12.1

2 5

[libvirt] [PATCH] [libvirt-php] fix libvirt_stream_send/libvirt_stream_recv
by Vasiliy Tolstov 30 Mar '17

30 Mar '17

When php disable call pass time by reference this breaks libvirt_stream_recv and also bring more memory allocations from zend engine. Vasiliy Tolstov (1): fix libvirt_stream_send/libvirt_stream_recv src/libvirt-php.c | 36 ++++++++++++++++-------------------- 1 file changed, 16 insertions(+), 20 deletions(-) -- 2.9.3

2 4

[libvirt] [PATCH] [libvirt-php] allow to specify empty base and top
by Vasiliy Tolstov 30 Mar '17

30 Mar '17

allow to specify empty base and top to do active block commit Vasiliy Tolstov (1): allow to specify empty base and top for block commit src/libvirt-php.c | 22 ++++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-) -- 2.9.3

2 2

[libvirt] [PATCH 0/3] Fix gluster volume lookup of multiple volumes
by Peter Krempa 30 Mar '17

30 Mar '17

Fix the broken XPath and add tests. Peter Krempa (3): storage: util: Split out the gluster volume extraction code into new function test: Introduce testing of virStorageUtilGlusterExtractPoolSources storage: Fix XPath for looking up gluster volume name src/storage/storage_util.c | 93 +++++++++++-------- src/storage/storage_util.h | 4 + tests/Makefile.am | 15 ++- .../virstorageutildata/gluster-parse-basic-dst.xml | 6 ++ .../virstorageutildata/gluster-parse-basic-src.xml | 47 ++++++++++ .../gluster-parse-multivol-dst.xml | 14 +++ .../gluster-parse-multivol-src.xml | 32 +++++++ tests/virstorageutiltest.c | 103 +++++++++++++++++++++ 8 files changed, 272 insertions(+), 42 deletions(-) create mode 100644 tests/virstorageutildata/gluster-parse-basic-dst.xml create mode 100644 tests/virstorageutildata/gluster-parse-basic-src.xml create mode 100644 tests/virstorageutildata/gluster-parse-multivol-dst.xml create mode 100644 tests/virstorageutildata/gluster-parse-multivol-src.xml create mode 100644 tests/virstorageutiltest.c -- 2.12.1

1 4

[libvirt] [PATCH] qemuDomainSnapshotPrepare: Don't always assume vm->def->os.loader
by Michal Privoznik 30 Mar '17

30 Mar '17

In 9e2465834 a check that denies internal snapshots when pflash based loader is configured for the domain. However, if there's none and an user tries to do an internal snapshot they will witness daemon crash as in that case vm->def->os.loader is NULL and we dereference it unconditionally. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/qemu/qemu_driver.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 40c2eab..3cc4f4d 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -13889,6 +13889,7 @@ qemuDomainSnapshotPrepare(virConnectPtr conn, * Avoid the issues by forbidding internal snapshot with pflash completely. */ if (found_internal && + vm->def->os.loader && vm->def->os.loader->type == VIR_DOMAIN_LOADER_TYPE_PFLASH) { virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s", _("internal snapshots of a VM with pflash based " -- 2.10.2

2 1