June 2016 - Devel - libvirt List Archives

[libvirt] [PATCH v3 0/7] Introducing storage pool lifecycle event APIs
by Jovanka Gulicoska 15 Jun '16

15 Jun '16

Changes since v2 listed in every commit separately Introducing implementation of storage pool event APIs. Code changes follow network event APIs. Implemented functions: virStoragePoolEventRegisterAny(), virStoragePoolEventDeregisterAny(), virStoragePoolLifeCycleEventNew(), introduced STARTED, STOPPED, DEFINE, UNDEFINE and REFRESHED. STARTED signal is emiited in storagePoolCreateXML() and storagePoolCreate() DEFINED signal is emitted in storagePoolDefineXML() UNDEFINED signal is emitted in storagePoolUndefine() STOPPED signal is emitted in storagePoolDestroy() and storagePoolRefresh() REFRESHED signal is emitted in storagePoolRefresh() There are also test as well as unittests for the new functions and signals. This is part of a GSOC project: Asynchronous lifecycle events for storage objects As part of the project there should also be implementation for storage volume events. For now there's no signal when volumes are created or deleted, they can also be implemented, but probably the easiest way is to have apps watch for REFRESH signal, and later extend storage driver code to refresh a pool after volume APIs are called. Jovanka Gulicoska (7): Introduce storage lifecycle event APIs conf: add storage_event handling test: implement storage lifecycle event APIs remote: implement storage lifecycle event APIs storage: implement storage lifecycle event APIs event-test: support storage lifecycle event APIs virsh: Introduce virsh-pool command daemon/libvirtd.h | 2 + daemon/remote.c | 207 ++++++++++++++++++++++++++++++- examples/object-events/event-test.c | 73 +++++++++++ include/libvirt/libvirt-storage.h | 93 ++++++++++++++ src/Makefile.am | 5 + src/conf/storage_conf.h | 4 + src/conf/storage_event.c | 235 ++++++++++++++++++++++++++++++++++++ src/conf/storage_event.h | 58 +++++++++ src/datatypes.h | 13 ++ src/driver-storage.h | 13 ++ src/libvirt-storage.c | 125 +++++++++++++++++++ src/libvirt_private.syms | 5 + src/libvirt_public.syms | 6 + src/remote/remote_driver.c | 128 ++++++++++++++++++++ src/remote/remote_protocol.x | 43 ++++++- src/remote_protocol-structs | 16 +++ src/storage/storage_driver.c | 110 +++++++++++++++++ src/test/test_driver.c | 71 +++++++++++ tests/objecteventtest.c | 177 +++++++++++++++++++++++++++ tools/virsh-pool.c | 184 ++++++++++++++++++++++++++++ 20 files changed, 1564 insertions(+), 4 deletions(-) create mode 100644 src/conf/storage_event.c create mode 100644 src/conf/storage_event.h -- 2.5.5

5 16

[libvirt] esx: What does "No storage volume with key or path" mean?
by Richard W.M. Jones 15 Jun '16

15 Jun '16

We've had a report of a particular vCenter server (using VMware clustering, we think) where virStorageVolInfo of a guest volume fails with: Storage volume not found: No storage volume with key or path '[...] ...' The error comes from esxVI_LookupFileInfoByDatastorePath: https://libvirt.org/git/?p=libvirt.git;a=blob;f=src/esx/esx_vi.c;h=f7eeeb5c… What does it mean? The reporter also said they could do some (frankly voodoo) moving guests around and then the error went away. We're not sure if that was just coincidence. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into KVM guests. http://libguestfs.org/virt-v2v

1 1

[libvirt] [PATCH] vz: get rid of unused home state variable in private domain obj
by Nikolay Shirokovskiy 15 Jun '16

15 Jun '16

Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy(a)virtuozzo.com> --- src/vz/vz_sdk.c | 16 ---------------- src/vz/vz_utils.h | 1 - 2 files changed, 17 deletions(-) diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c index 2275572..3fe17e0 100644 --- a/src/vz/vz_sdk.c +++ b/src/vz/vz_sdk.c @@ -447,7 +447,6 @@ prlsdkDomObjFreePrivate(void *p) PrlHandle_Free(pdom->sdkdom); PrlHandle_Free(pdom->cache.stats); virCondDestroy(&pdom->cache.cond); - VIR_FREE(pdom->home); VIR_FREE(p); }; @@ -1484,7 +1483,6 @@ prlsdkLoadDomain(vzDriverPtr driver, virDomainObjPtr dom) virDomainDefPtr def = NULL; vzDomObjPtr pdom = NULL; VIRTUAL_MACHINE_STATE domainState; - char *home = NULL; PRL_RESULT pret; PRL_UINT32 ram; @@ -1541,17 +1539,6 @@ prlsdkLoadDomain(vzDriverPtr driver, virDomainObjPtr dom) pret = PrlVmCfg_GetEnvId(sdkdom, &envId); prlsdkCheckRetGoto(pret, error); - if (!(home = prlsdkGetStringParamVar(PrlVmCfg_GetHomePath, sdkdom))) - goto error; - - /* For VMs home is actually /directory/config.pvs */ - if (!IS_CT(def)) { - /* Get rid of /config.pvs in path string */ - char *s = strrchr(home, '/'); - if (s) - *s = '\0'; - } - pret = PrlVmCfg_GetAutoStart(sdkdom, &autostart); prlsdkCheckRetGoto(pret, error); if (autostart != PAO_VM_START_ON_LOAD && @@ -1588,8 +1575,6 @@ prlsdkLoadDomain(vzDriverPtr driver, virDomainObjPtr dom) virDomainDefFree(dom->def); dom->def = def; pdom->id = envId; - VIR_FREE(pdom->home); - pdom->home = home; prlsdkConvertDomainState(domainState, envId, dom); @@ -1607,7 +1592,6 @@ prlsdkLoadDomain(vzDriverPtr driver, virDomainObjPtr dom) return 0; error: PrlHandle_Free(sdkdom); - VIR_FREE(home); virDomainDefFree(def); return -1; } diff --git a/src/vz/vz_utils.h b/src/vz/vz_utils.h index ba4d3c5..1e2ed30 100644 --- a/src/vz/vz_utils.h +++ b/src/vz/vz_utils.h @@ -103,7 +103,6 @@ typedef struct _vzCountersCache vzCountersCache; struct vzDomObj { int id; - char *home; PRL_HANDLE sdkdom; vzCountersCache cache; }; -- 1.8.3.1

2 1

[libvirt] [PATCH] check-spacing: fix error message
by Ján Tomko 15 Jun '16

15 Jun '16

The check for whitespace before comma or semicolon referred to comma as colon. --- build-aux/check-spacing.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Pushed as trivial. diff --git a/build-aux/check-spacing.pl b/build-aux/check-spacing.pl index f4fedbc..448acf2 100755 --- a/build-aux/check-spacing.pl +++ b/build-aux/check-spacing.pl @@ -138,7 +138,7 @@ foreach my $file (@ARGV) { if ($data =~ /\s[;,]/) { unless ($data =~ /\S; ; / || $data =~ /^\s+;/) { - print "Whitespace before (semi)colon:\n"; + print "Whitespace before semicolon or comma:\n"; print "$file:$.: $line"; $ret = 1; } -- 2.7.3

1 0

[libvirt] [PATCH 0/9] syntax-check: make spacing check faster
by Ján Tomko 15 Jun '16

15 Jun '16

Simplify some regexes to increase coverage and speed up the execution. Reduces (git ls-files "*.c" | xargs build-aux/bracket-spacing.pl) by half a second (from 1.9s to 1.33s), the effect on complete syntax-check is only ~150 ms. Ján Tomko (9): vbox: reformat multi-line error reports maint: remove whitespace from closing parentheses Rename virAssertCmpInt to testAssertEq Rename bracket-spacing.pl to check-spacing.pl check-spacing: rewrite whitespace check before (semi)colon check-spacing: rewrite regex for checking the closing parenthesis check-spacing: simplify keyword spacing check check-spacing: remove virAssertCmpInt exception check-spacing: use non-capturing groups build-aux/bracket-spacing.pl | 204 ------------------------------------------ build-aux/check-spacing.pl | 204 ++++++++++++++++++++++++++++++++++++++++++ cfg.mk | 6 +- src/qemu/qemu_command.c | 3 +- src/vbox/vbox_common.c | 8 +- src/vbox/vbox_snapshot_conf.c | 68 +++++++------- src/vz/vz_driver.c | 3 +- src/vz/vz_sdk.c | 3 +- tests/viratomictest.c | 52 +++++------ 9 files changed, 274 insertions(+), 277 deletions(-) delete mode 100755 build-aux/bracket-spacing.pl create mode 100755 build-aux/check-spacing.pl -- 2.7.3

2 18

[libvirt] [PATCH] maint: Switch to xz compressed PAX release archives
by Andrea Bolognani 15 Jun '16

15 Jun '16

This allows us to produce releases that are roughly a third in size, have no limitation on path lenght, and are still readable by all supported platforms. --- And what better time to switch than the 2.0.0 release? :) configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 0114149..7d16e5a 100644 --- a/configure.ac +++ b/configure.ac @@ -24,7 +24,7 @@ AH_BOTTOM([#include <config-post.h>]) AC_CONFIG_MACRO_DIR([m4]) dnl Make automake keep quiet about wildcards & other GNUmake-isms; also keep dnl quiet about the fact that we intentionally cater to automake 1.9 -AM_INIT_AUTOMAKE([-Wno-portability -Wno-obsolete tar-ustar subdir-objects]) +AM_INIT_AUTOMAKE([-Wno-portability -Wno-obsolete tar-pax no-dist-gzip dist-xz subdir-objects]) dnl older automake's default of ARFLAGS=cru is noisy on newer binutils; dnl we don't really need the 'u' even in older toolchains. Then there is dnl older libtool, which spelled it AR_FLAGS -- 2.5.5

2 1

[libvirt] Bump tar format?
by Andrea Bolognani 15 Jun '16

15 Jun '16

Hi everyone, commit cc3d52e[1] has apparently broken 'make dist' for at least some platforms: Fedora 20 is fine[2], but both Fedora 21 and rawhide[3][4] are currently failing. My laptop is running Fedora 22 and can make dist just fine, which is of course very confusing. The issue is caused by the following tar error: tar: libvirt-1.2.18/tests/nodeinfodata/linux-deconfigured-cpus/ \ node/node0/cpu16/topology/core_siblings_list: \ link name is too long; not dumped There seem to be basically two ways to solve the failure: 1. rename the test case, making it shorter; 2. bump tar format from ustar, which has limitations on the length of file names, to posix/pax, which has no such limitations. I'm not a fan of the former option because short names are usually very opaque, see tests/nodeinfodata/linux-test[0-8] for some perfect examples. On the other hand, I'm not sure whether bumping the tar version would affect portability in a significant way: the automake documentation[5] reports that this format is very young and should probably be restricted to packages that target only very modern platforms but the GNU tar documentation[6], while containing some warnings as well, suggest that this format is going to become the default. Any suggestions on how to proceed? Cheers. [1] https://www.redhat.com/archives/libvir-list/2015-July/msg00662.html [2] https://ci.centos.org/view/libvirt-project/job/libvirt-daemon -rpm/systems=libvirt-fedora-20/327/ [3] https://ci.centos.org/view/libvirt-project/job/libvirt-daemon -rpm/systems=libvirt-fedora-21/327/ [4] https://ci.centos.org/view/libvirt-project/job/libvirt-daemon -rpm/systems=libvirt-fedora-rawhide/327/ [5] https://www.gnu.org/software/automake/manual/html_node/List-of -Automake-options.html [6] http://www.gnu.org/software/tar/manual/html_chapter/tar_8.html -- Andrea Bolognani Software Engineer - Virtualization Team

6 13

[libvirt] [PATCH] virHostCPUGetInfo: Fix build on non-Unix like systems
by Michal Privoznik 15 Jun '16

15 Jun '16

This function is plenty of ifdefs providing implementations for Linux, *BSD and OS-X. However, if we are being build for any other architecture, all that's left behind by preprocessor is just a error reporting call and return of -1. In that case, passed arguments are unused: ../../src/util/virhostcpu.c: In function 'virHostCPUGetInfo': ../../src/util/virhostcpu.c:966:33: error: unused parameter 'cpus' [-Werror=unused-parameter] unsigned int *cpus, ^~~~ Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/util/virhostcpu.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/util/virhostcpu.c b/src/util/virhostcpu.c index 00c09cd..a481be0 100644 --- a/src/util/virhostcpu.c +++ b/src/util/virhostcpu.c @@ -963,12 +963,12 @@ virHostCPUParseMapLinux(int max_cpuid, const char *path) int virHostCPUGetInfo(virArch hostarch ATTRIBUTE_UNUSED, - unsigned int *cpus, - unsigned int *mhz, - unsigned int *nodes, - unsigned int *sockets, - unsigned int *cores, - unsigned int *threads) + unsigned int *cpus ATTRIBUTE_UNUSED, + unsigned int *mhz ATTRIBUTE_UNUSED, + unsigned int *nodes ATTRIBUTE_UNUSED, + unsigned int *sockets ATTRIBUTE_UNUSED, + unsigned int *cores ATTRIBUTE_UNUSED, + unsigned int *threads ATTRIBUTE_UNUSED) { #ifdef __linux__ int ret = -1; -- 2.8.4

2 1

[libvirt] [PATCH 0/2] Speed up syntax-check
by Ján Tomko 15 Jun '16

15 Jun '16

Remove one inefficient regex not applicable to libvirt codebase and join non-reentrant functions into a single regex to reduce the time taken by the two slowest syntax-checks: 4.03 unmarked_diagnostics 4.03 vulnerable_makefile_CVE-2009-4029 4.03 size_of_brackets 4.03 spec_indentation 4.33 require_config_h_first 5.88 prohibit_nonreentrant 7.72 prohibit_undesirable_word_seq This reduces the overall 'make -j9 syntax-check' time for me from ~8s to ~4.5s. Ján Tomko (2): cfg.mk: override gnulib's undesirable_word_seq check cfg.mk: use a single regex for all non-reentrant functions Makefile.nonreentrant | 8 ++++++++ cfg.mk | 18 ++++++++---------- 2 files changed, 16 insertions(+), 10 deletions(-) -- 2.7.3

2 4

[libvirt] [PATCH] A word error about S3/S4 operations for guest
by sannyshao 15 Jun '16

15 Jun '16

--- docs/formatdomain.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 82b6aae..dd9f153 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -1462,7 +1462,7 @@ <dl> <dt><code>pm</code></dt> <dd>These elements enable ('yes') or disable ('no') BIOS support - for S3 (suspend-to-disk) and S4 (suspend-to-mem) ACPI sleep + for S3 (suspend-to-mem) and S4 (suspend-to-disk) ACPI sleep states. If nothing is specified, then the hypervisor will be left with its default value.</dd> </dl> -- 1.8.3.1

2 1