April 2016 - Devel - libvirt List Archives

[libvirt] [libvirt-glib] events: Mark 'eventlock' as static
by Christophe Fergeau 21 Apr '16

21 Apr '16

It's not used outside of the libvirt-glib-event.c file, so there is no good reason for not having it static. As it was not listed in libvirt-glib.sym, this will make no change to the publicly exported symbols (ie this is not an ABI change). --- libvirt-glib/libvirt-glib-event.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt-glib/libvirt-glib-event.c b/libvirt-glib/libvirt-glib-event.c index f8227d6..4548aa6 100644 --- a/libvirt-glib/libvirt-glib-event.c +++ b/libvirt-glib/libvirt-glib-event.c @@ -110,7 +110,7 @@ struct gvir_event_timeout virFreeCallback ff; }; -GMutex *eventlock = NULL; +static GMutex *eventlock = NULL; static int nextwatch = 1; static GPtrArray *handles; -- 2.5.0

1 1

[libvirt] [PATCH 0/4] Fix python sanity check after moving typedParam stuff to libvirt-common.h
by Peter Krempa 21 Apr '16

21 Apr '16

Fixes the following breakage: Cannot get a value of enum VIR_TYPED_PARAM_BOOLEAN (originally VIR_DOMAIN_BLKIO_PARAM_BOOLEAN) Cannot get a value of enum VIR_TYPED_PARAM_DOUBLE (originally VIR_DOMAIN_BLKIO_PARAM_DOUBLE) Cannot get a value of enum VIR_TYPED_PARAM_INT (originally VIR_DOMAIN_BLKIO_PARAM_INT) ... Peter Krempa (4): include: common: Fix file header for apibuild.py apibuild: Allow completely skipping certain macros api: Generate docs for libvirt-common.h include: common: Fix function formatting docs/Makefile.am | 1 + docs/apibuild.py | 12 +++ docs/sitemap.html.in | 4 + include/libvirt/libvirt-common.h.in | 173 ++++++++++++++++-------------------- 4 files changed, 95 insertions(+), 95 deletions(-) -- 2.8.1

2 7

[libvirt] [PATCH 0/2] virsh: perf: Trivial fixes of a memleak and coding style
by Peter Krempa 21 Apr '16

21 Apr '16

Both are pushed under the trivial rule. Peter Krempa (2): virsh: perf: Don't leak domain virsh: perf: Remove unnecessary 'error' label tools/virsh-domain.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) -- 2.8.1

2 3

[libvirt] [PATCH 0/9] Admin API: Introduce client listing API
by Erik Skultety 21 Apr '16

21 Apr '16

This series introduces API to list all clients connected to a specific server. Clients are now identified by 64-bit wide IDs and store their connection timestamp. Along with these attributes, transport type of the connection is returned back to the caller as well. Erik Skultety (9): rpc: virnetserverclient: Identify clients by an integer ID rpc: virnetserverclient: Introduce new attribute conn_time to client admin: Introduce virAdmClient client-side object rpc: gendispatch: Tune it to support client structure rpc: virnetserver: Support retrieval of a list of clients include: admin: export connection transport constants rpc: virnetserverclient: Implement client connection transport retrieval admin: Introduce listing clients virt-admin: Introduce srv-clients-list command daemon/admin.c | 15 +++ daemon/admin_server.c | 24 ++++ daemon/admin_server.h | 4 + daemon/libvirtd.c | 4 +- include/libvirt/libvirt-admin.h | 36 ++++++ src/admin/admin_protocol.x | 29 ++++- src/admin/admin_remote.c | 6 + src/admin_protocol-structs | 19 +++ src/datatypes.c | 35 +++++ src/datatypes.h | 47 +++++++ src/libvirt-admin.c | 131 +++++++++++++++++++ src/libvirt_admin_private.syms | 3 + src/libvirt_admin_public.syms | 5 + src/libvirt_remote.syms | 2 + src/locking/lock_daemon.c | 2 +- src/logging/log_daemon.c | 2 +- src/lxc/lxc_controller.c | 2 +- src/rpc/gendispatch.pl | 61 +++++++-- src/rpc/virnetserver.c | 64 +++++++++- src/rpc/virnetserver.h | 6 + src/rpc/virnetserverclient.c | 106 ++++++++++++++-- src/rpc/virnetserverclient.h | 10 +- tests/Makefile.am | 7 + tests/virnetdaemondata/input-data-client-ids.json | 69 ++++++++++ .../input-data-client-timestamp.json | 71 +++++++++++ .../virnetdaemondata/output-data-admin-nomdns.json | 6 + .../output-data-admin-server-names.json | 6 + .../virnetdaemondata/output-data-anon-clients.json | 3 + tests/virnetdaemondata/output-data-client-ids.json | 69 ++++++++++ .../output-data-client-timestamp.json | 71 +++++++++++ .../output-data-initial-nomdns.json | 3 + tests/virnetdaemondata/output-data-initial.json | 3 + .../output-data-no-keepalive-required.json | 6 + tests/virnetdaemonmock.c | 34 +++++ tests/virnetdaemontest.c | 13 +- tests/virnetserverclienttest.c | 2 +- tools/virt-admin.c | 141 +++++++++++++++++++++ tools/virt-admin.pod | 7 + 38 files changed, 1085 insertions(+), 39 deletions(-) create mode 100644 tests/virnetdaemondata/input-data-client-ids.json create mode 100644 tests/virnetdaemondata/input-data-client-timestamp.json create mode 100644 tests/virnetdaemondata/output-data-client-ids.json create mode 100644 tests/virnetdaemondata/output-data-client-timestamp.json create mode 100644 tests/virnetdaemonmock.c -- 2.4.11

1 9

[libvirt] [PATCH v6 0/5] vz: add migration support
by Nikolay Shirokovskiy 21 Apr '16

21 Apr '16

Difference from v5 ================== 1. managed case is implemented 2. p2p follows managed migration flow now 3. 'vz: fix const correctness case' is needed to implement managed case. 4. misc options that are always on for vz (--live, --compressed) are not required to be set explicitly. 5. --offline is not supported anymore but migration of inactive domains is possible without this option set. Nikolay Shirokovskiy (5): vz: save session uuid on login vz: fix const correctness case vz: implement managed migration vz: implement p2p migration vz: cleanup: define vz format of uuids src/vz/vz_driver.c | 555 +++++++++++++++++++++++++++++++++++++++++++++++++++++ src/vz/vz_sdk.c | 89 +++++++-- src/vz/vz_sdk.h | 6 + src/vz/vz_utils.c | 2 +- src/vz/vz_utils.h | 6 +- 5 files changed, 641 insertions(+), 17 deletions(-) -- 1.8.3.1

2 7

[libvirt] [PATCH] Bump minimum libvirt requirement to 1.2.13
by Christophe Fergeau 21 Apr '16

21 Apr '16

libvirt-php uses VIR_STORAGE_VOL_CREATE_REFLINK which was introduced in commit v1.2.12-18-g95da191 (so first available in the 1.2.13 release). --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 7a634ca..bce3de2 100644 --- a/configure.ac +++ b/configure.ac @@ -39,7 +39,7 @@ if test "$prefix" = "/usr" && test "$sysconfdir" = '${prefix}/etc' ; then sysconfdir='/etc' fi -LIBVIRT_REQUIRED=1.2.9 +LIBVIRT_REQUIRED=1.2.13 PKG_CHECK_MODULES(LIBVIRT, libvirt >= $LIBVIRT_REQUIRED) PKG_CHECK_MODULES(QEMU, libvirt-qemu) AC_SUBST([QEMU_CFLAGS]) -- 2.5.5

4 6

[libvirt] [libvirt-php][PATCH 0/4] Fix build again
by Michal Privoznik 21 Apr '16

21 Apr '16

There were some problems with my build fixes. Hopefully, these will make it work for everybody again. Michal Privoznik (4): Get php cflags at configure Get rid of $DEFINES src: Distribute config.m4 libvirt-php.so: Avoid versioning library configure.ac | 5 +++++ src/Makefile.am | 13 ++++++++----- 2 files changed, 13 insertions(+), 5 deletions(-) -- 2.7.3

2 10

[libvirt] [PATCH 0/3] Perform some minor rather cosmetic adjustments to tests
by Erik Skultety 21 Apr '16

21 Apr '16

When I was adding new admin related tests, I noticed that we have some test data leftovers in the repo, as well as having a test that isn't enabled, although it should be and that we still have some JSON test data using tabs for indentation...my bad, I got through the log history only to see that when I merged a patch to fix this, I failed to do it properly. Erik Skultety (3): tests: remove virnetservertest data leftovers tests: virnetdaemon: Replace tabs with spaces tests: virnetdaemontest: Enable testing for no-keepalive-required .../input-data-admin-server-names.json | 204 +++++++++---------- .../output-data-no-keepalive-required.json | 224 ++++++++++----------- tests/virnetdaemontest.c | 1 + .../input-data-initial-nomdns.json | 61 ------ .../output-data-initial-nomdns.json | 62 ------ 5 files changed, 215 insertions(+), 337 deletions(-) delete mode 100644 tests/virnetserverdata/input-data-initial-nomdns.json delete mode 100644 tests/virnetserverdata/output-data-initial-nomdns.json -- 2.4.11

2 5

[libvirt] [PATCH] virsh: re-fix help printing without connection
by Roman Bogorodskiy 21 Apr '16

21 Apr '16

Re-do 0217089 so it does not add regression for commit c0726e0 that allowed to print help without making a connection to the daemon. --- tools/virsh.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index e14410b..366956c 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -962,14 +962,16 @@ main(int argc, char **argv) if (!vshInit(ctl, cmdGroups, NULL)) exit(EXIT_FAILURE); - ctl->connname = vshStrdup(ctl, virGetEnvBlockSUID("VIRSH_DEFAULT_CONNECT_URI")); - if (!virshParseArgv(ctl, argc, argv) || !virshInit(ctl)) { virshDeinit(ctl); exit(EXIT_FAILURE); } + if (!ctl->connname) + ctl->connname = vshStrdup(ctl, + virGetEnvBlockSUID("VIRSH_DEFAULT_CONNECT_URI")); + if (!ctl->imode) { ret = vshCommandRun(ctl, ctl->cmd); } else { -- 2.7.4

2 2

[libvirt] Release of libvirt-php-0.5.2
by Michal Privoznik 21 Apr '16

21 Apr '16

After 5 months of development I'm more than proud to announce that libvirt-php-0.5.2 is out!It can be downloaded from http://libvirt.org/sources/php/libvirt-php-0.5.2.tar.gz This release focused on adapting to PHP7 and yet again some more bug fixes. The diff stat is rather big, but that's mostly because of all the documentation that has been added to PHP functions that we expose. I'd like to thank everybody who participated, namely Neal and Remi for proposing their patches and testing mine, Vasiliy for his valuable input. Lets make the next release even better! Michal

3 4