November 2016 - Devel - libvirt List Archives

[libvirt] [PATCH 0/6] Add group_name support for <iotune>
by John Ferlan 07 Nov '16

07 Nov '16

https://bugzilla.redhat.com/show_bug.cgi?id=1336564 Add support for "group" name in <iotune>. The odd thing about the <iotune> group name is that support was added in qemu after the _max parameters, but before the _max_length - so when building the command line - that needs to be followed. At least it's far less complicated than the _length parameters. John Ferlan (6): include: Add new "group_name" definition for iotune throttling caps: Add new capability for the iotune group name qemu: Add support for parsing iotune group setting conf: Add support for blkiotune group_name option qemu: Add the group name option to the iotune command line virsh: Add group name to blkdeviotune output docs/formatdomain.html.in | 11 ++++ docs/schemas/domaincommon.rng | 5 ++ include/libvirt/libvirt-domain.h | 15 +++++ src/conf/domain_conf.c | 10 +++ src/conf/domain_conf.h | 1 + src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 13 ++++ src/qemu/qemu_driver.c | 50 +++++++++++++-- src/qemu/qemu_monitor.c | 2 + src/qemu/qemu_monitor.h | 1 + src/qemu/qemu_monitor_json.c | 21 +++++- src/qemu/qemu_monitor_json.h | 1 + tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml | 1 + .../caps_2.6.0-gicv2.aarch64.xml | 1 + .../caps_2.6.0-gicv3.aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_2.6.0.ppc64le.xml | 1 + tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml | 1 + tests/qemumonitorjsontest.c | 74 +++++++++++++++++----- .../qemuxml2argv-blkdeviotune-group-num.args | 32 ++++++++++ .../qemuxml2argv-blkdeviotune-group-num.xml | 61 ++++++++++++++++++ tests/qemuxml2argvtest.c | 4 ++ .../qemuxml2xmlout-blkdeviotune-group-num.xml | 1 + tests/qemuxml2xmltest.c | 1 + tools/virsh-domain.c | 17 +++++ tools/virsh.pod | 5 +- 28 files changed, 309 insertions(+), 26 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-blkdeviotune-group-num.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-blkdeviotune-group-num.xml create mode 120000 tests/qemuxml2xmloutdata/qemuxml2xmlout-blkdeviotune-group-num.xml -- 2.7.4

3 16

Re: [libvirt] [PATCH 1/2] vbox: add vbox 5.1 C API header file.
by Eric Blake 07 Nov '16

07 Nov '16

On 11/07/2016 03:03 PM, Dawid Zamirski wrote: > > extracted from VirutalBox SDK and reindented with cppi. > --- > src/vbox/vbox_CAPI_v5_1.h | 26117 ++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 26117 insertions(+) > create mode 100644 src/vbox/vbox_CAPI_v5_1.h 1.1 Meg of generated code is a lot to send to the mailing list. Can you compress the patch so that it isn't taxing the list server quite so hard? Or if someone with push rights agrees, send them the patch on the side and get it committed without going through the list (as there's very little that actually needs a review). -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org

2 1

[libvirt] [PATCH v2 0/8] aggregate multiple pcie-root-ports onto a single slot
by Laine Stump 07 Nov '16

07 Nov '16

This is just a rebase of v1 of the same series, reposted to make it easier for Andrea to review. Laine Stump (8): conf: use struct instead of int for each slot in virDomainPCIAddressBus conf: eliminate concept of "reserveEntireSlot" conf: eliminate repetitive code in virDomainPCIAddressGetNextSlot() conf: start search for next unused PCI address at same slot as previous find conf: new function virDomainPCIAddressIsMulti() qemu: use virDomainPCIAddressIsMulti() to determine multifunction setting conf: aggregate multiple devices on a slot when assigning PCI addresses conf: aggregate multiple pcie-root-ports onto a single slot src/conf/domain_addr.c | 290 ++++++++++++++------- src/conf/domain_addr.h | 48 +++- src/libvirt_private.syms | 1 + src/qemu/qemu_command.c | 16 +- src/qemu/qemu_domain_address.c | 35 ++- .../qemuxml2argv-pcie-root-port.args | 5 +- .../qemuxml2argv-pcie-switch-upstream-port.args | 5 +- .../qemuxml2argv-q35-default-devices-only.args | 7 +- .../qemuxml2argv-q35-multifunction.args | 43 +++ .../qemuxml2argv-q35-multifunction.xml | 51 ++++ .../qemuxml2argv-q35-pcie-autoadd.args | 30 ++- tests/qemuxml2argvdata/qemuxml2argv-q35-pcie.args | 28 +- .../qemuxml2argv-q35-virt-manager-basic.args | 13 +- .../qemuxml2argv-q35-virtio-pci.args | 28 +- tests/qemuxml2argvtest.c | 25 ++ .../qemuxml2xmlout-pcie-root-port.xml | 2 +- .../qemuxml2xmlout-pcie-switch-upstream-port.xml | 4 +- .../qemuxml2xmlout-q35-default-devices-only.xml | 8 +- .../qemuxml2xmlout-q35-multifunction.xml | 120 +++++++++ .../qemuxml2xmlout-q35-pcie-autoadd.xml | 52 ++-- .../qemuxml2xmloutdata/qemuxml2xmlout-q35-pcie.xml | 48 ++-- .../qemuxml2xmlout-q35-virt-manager-basic.xml | 20 +- .../qemuxml2xmlout-q35-virtio-pci.xml | 48 ++-- tests/qemuxml2xmltest.c | 25 ++ 24 files changed, 676 insertions(+), 276 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-q35-multifunction.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-q35-multifunction.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-q35-multifunction.xml -- 2.7.4

1 8

[libvirt] [PATCH] Unbreak rebuilding docs with release tarballs
by Guido Günther 07 Nov '16

07 Nov '16

Release tarballs ship the include/libvirt/libvirt-common.h. when srcdir != builddir we end up including libvirt-common.h twice: from $top_srcdir/include/libvirt-common.h and from $builddir/include/libvirt-common.h leading to function virTypedParamsGetUInt from /tmp/buildd/libvirt-2.4.0/debian/build/docs/../include/libvirt/libvirt-common.h redeclared in /tmp/buildd/libvirt-2.4.0/docs/../include/libvirt/libvirt-common.h function virTypedParamsAddBoolean from /tmp/buildd/libvirt-2.4.0/debian/build/docs/../include/libvirt/libvirt-common.h redeclared in /tmp/buildd/libvirt-2.4.0/docs/../include/libvirt/libvirt-common.h … Only add the builddir to the search list if there is no pregenerated libvirt-common.h. Reuse the existing check that predates the libvirt.h → libvirt-common.h split and that probably was meant for exactly that. References: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=842452 --- docs/apibuild.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/docs/apibuild.py b/docs/apibuild.py index 8728b27..47f340c 100755 --- a/docs/apibuild.py +++ b/docs/apibuild.py @@ -2607,10 +2607,9 @@ class app: dirs = [srcdir + "/../src", srcdir + "/../src/util", srcdir + "/../include/libvirt"] - if builddir: + if (builddir and + not os.path.exists(srcdir + "/../include/libvirt/libvirt-common.h")): dirs.append(builddir + "/../include/libvirt") - if glob.glob(srcdir + "/../include/libvirt/libvirt.h") == [] : - dirs.append("../include/libvirt") builder = docBuilder(name, srcdir, dirs, []) elif glob.glob("src/libvirt.c") != [] : if not quiet: -- 2.10.1

2 2

[libvirt] [PATCH] spec: Run all make jobs in parallel
by Andrea Bolognani 07 Nov '16

07 Nov '16

Commit e8861f69714f changed our spec file to compile and run tests in parallel. That's a very good step forward, but why stop there? Let's run *all* make jobs in parallel and really put those expensive cores to use! On my laptop, this shaves ~10s off 'make rpm'. --- libvirt.spec.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 5133936..a2c2f2f 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1210,9 +1210,9 @@ rm -fr %{buildroot} # Avoid using makeinstall macro as it changes prefixes rather than setting # DESTDIR. Newer make_install macro would be better but it's not available # on RHEL 5, thus we need to expand it here. -make install DESTDIR=%{?buildroot} SYSTEMD_UNIT_DIR=%{_unitdir} +make %{?_smp_mflags} install DESTDIR=%{?buildroot} SYSTEMD_UNIT_DIR=%{_unitdir} -make -C examples distclean +make %{?_smp_mflags} -C examples distclean rm -f $RPM_BUILD_ROOT%{_libdir}/*.la rm -f $RPM_BUILD_ROOT%{_libdir}/*.a -- 2.7.4

2 2

[libvirt] [PATCH] Allow saving QEMU libvirt state to a pipe
by Roy Keene 07 Nov '16

07 Nov '16

All, Currently the "virsh save" command opens a file to save a domain's XML and memory state, does the save, and then re-opens the file to simulate seeking to the beginning to update the header to indicate that the file is complete. For pipes this is not possible, attempting to re-open the pipe will not connect you to the same consumer. Seeking is also not possible on a pipe. Attached is a patch that detects if the file being written to is not seekable, and if so writes the completed header initially, then writes the normal data, and avoids re-opening the file. This is useful to me for saving a VM state directly to Ceph RBD images without having an intermediate file. I've tested this patch successfully (against v1.3.5) for both saving and restoring a domain: # *( fifo="$(mktemp -u)"; mkfifo "${fifo}" && virsh save one-0 "${fifo}" & cat "${fifo}" | rbd import - rbd/test1234 & wait; rm -f "${fifo}" )* Domain one-0 saved to /tmp/tmp.HK4hChiQqB # # *( fifo="$(mktemp -u)"; mkfifo "${fifo}" && rbd export rbd/test1234 - > "${fifo}" & virsh restore "${fifo}" & wait; rm -f "${fifo}" ) * Exporting image: 100% complete...done. Domain restored from /tmp/tmp.0YaUZ5Y2yT # *virsh list* Id Name State ---------------------------------------------------- 11 one-0 running # -- Roy Keene Knight Point Systems, LLC Service-Disabled Veteran-Owned Business 1775 Wiehle Avenue Suite 101 | Reston, VA 20190 c: 813-956-3808 f: 571-266-3106 www.knightpoint.com DHS EAGLE II Prime Contractor: FC1 SDVOSB Track GSA Schedule 70 SDVOSB: GS-35F-0646S GSA MOBIS Schedule: GS-10F-0404Y ISO 20000 / ISO 27001 Notice: This e-mail message, including any attachments, is for the sole use of the intended recipient(s) and may contain confidential and privileged information. Any unauthorized review, copy, use, disclosure, or distribution is STRICTLY prohibited. If you are not the intended recipient, please contact the sender by reply e-mail and destroy all copies of the original message.

3 3

[libvirt] qemu: domain notification for serial channel changes
by Matt Broadstone 07 Nov '16

07 Nov '16

Hi, I was in the process of implementing a custom qemu agent which communicates over virtio-serial channels, when I noticed that the only way to receive channel state change notifications was to poll the domstatus XML file. There does seem to be code in libvirt to monitor for serial change events (https://libvirt.org/git/?p=libvirt.git;a=blob;f=src/qemu/qemu_driver.c;h=38…) however it's hardcoded/specific to the qemu-ga (explicitly checking for ports named "org.qemu.guest_agent.0"). It occurs to me that while there was a class of events added for guest lifecycle changes, it might be a more generic solution to provide events for character device changes. Am I missing some existing functionality here? I'm a first-time poster here so I was hoping to both signal my intent to implement something more generic, as well as ping the community to see if there would be interest in this work or reasons why I shouldn't be doing this. Regards, Matt

3 6

[libvirt] [PATCH v2] bhyve: add e1000 nic support
by Roman Bogorodskiy 07 Nov '16

07 Nov '16

Changes since v1: - Fix indentation - Don't leak nic_model in bhyveBuildNetArgStr, and actually convert it to use 'goto out' to the clean up routine instead of explicit calls to VIR_FREE for every case - Add support for e1000 for argv2xml code, along with tests Roman Bogorodskiy (1): bhyve: add e1000 nic support src/bhyve/bhyve_capabilities.c | 27 ++++++++ src/bhyve/bhyve_capabilities.h | 1 + src/bhyve/bhyve_command.c | 74 ++++++++++++++-------- src/bhyve/bhyve_parse_command.c | 9 ++- tests/bhyveargv2xmldata/bhyveargv2xml-e1000.args | 8 +++ tests/bhyveargv2xmldata/bhyveargv2xml-e1000.xml | 28 ++++++++ .../bhyveargv2xmldata/bhyveargv2xml-virtio-net.xml | 2 + .../bhyveargv2xml-virtio-net4.xml | 1 + tests/bhyveargv2xmltest.c | 1 + .../bhyvexml2argvdata/bhyvexml2argv-net-e1000.args | 9 +++ .../bhyvexml2argv-net-e1000.ldargs | 3 + .../bhyvexml2argvdata/bhyvexml2argv-net-e1000.xml | 22 +++++++ tests/bhyvexml2argvtest.c | 7 +- 13 files changed, 162 insertions(+), 30 deletions(-) create mode 100644 tests/bhyveargv2xmldata/bhyveargv2xml-e1000.args create mode 100644 tests/bhyveargv2xmldata/bhyveargv2xml-e1000.xml create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-net-e1000.args create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-net-e1000.ldargs create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-net-e1000.xml -- 2.9.2

2 3

[libvirt] [PATCH 00/17] Redo website layout and branding
by Daniel P. Berrange 07 Nov '16

07 Nov '16

The current libvirt website design dates from 2008 and has not changed significantly since. Compared to contemporary open source project websites it looks pretty dated and cluttered. This series incrementally changes the website to have a completely new layout and branding. Since the original adobe illustrator files are long since lost, this series introduces a newly created variant of the libvirt logo with Inkscape as an SVG file. The libvirt logo used a specific font with angled tops to letters like "l", "b" and "t" - this is the "Overpass" font, made available by Red Hat under an open source font license. The re-branding makes use of webfont support so that we can use this font across the entire libvirt website for a consistent look. The colors of the website CSS now exactly match the colors used in the logo in most places. The bigger change is in the layout, with the huge left hand sitemap nav bar being removed to give more space to the main content. The front page now directly links to the key pages that were shown to be highly visited in the apache web logs. Most of the rest of the links are now available from the "docs.html" page linked from "Learn" in the top nav bar. Another key change is that the download page now covers all language bindings, test suites, docs released by the project, not merely the core C library. Finally a new page "contribute.html" is added as the source of information useful to people wishing to get involved in the libvirt project. View the new site here https://berrange.fedorapeople.org/libvirt-new-website/ Note that the front page includes a feed of 4 most recent blog posts, however, if visiting over https:// this will be blocked by browsers. In firefox you can tell it to allow http:// content temporarily at which point the feed will appear. I'll be doing a proper fix by getting a TLS cert for virt-tools.org website setup. Daniel P. Berrange (17): docs: use overpass font for website docs: switch to new website banner docs: redo style of front page docs: add footer to all pages docs: simplify style for headers docs: add page describing contribution to libvirt docs: add three core links in the header bar docs: remove todo page docs: remove related links page Revert "syntax-check: Enforce <code> inside <dt> elements" docs: rewrite content on front page to be more useful docs: expand downloads page to cover all modules docs: add some improved styling to contact page docs: fill out docs page with useful links docs: remove navigation sidebar from pages docs: remove outdated or duplicated content docs: add master SVG for libvirt logo cfg.mk | 20 +- docs/404.html.in | 5 - docs/Makefile.am | 50 +- docs/archdomain.html.in | 7 - docs/archnetwork.html.in | 54 - docs/archnode.html.in | 7 - docs/archstorage.html.in | 32 - docs/contact.html.in | 4 +- docs/contribute.html.in | 140 ++ docs/deployment.html.in | 50 - docs/docs.html.in | 161 +- docs/downloads.html.in | 391 ++++- docs/fonts/LICENSE.md | 90 ++ docs/fonts/hinted-Overpass-Bold.woff | Bin 0 -> 48136 bytes docs/fonts/hinted-Overpass-BoldItalic.woff | Bin 0 -> 51008 bytes docs/fonts/hinted-Overpass-Italic.woff | Bin 0 -> 51908 bytes docs/fonts/hinted-Overpass-Light.woff | Bin 0 -> 49452 bytes docs/fonts/hinted-Overpass-LightItalic.woff | Bin 0 -> 51752 bytes docs/fonts/hinted-Overpass-Reg.woff | Bin 0 -> 48144 bytes docs/fonts/stylesheet.css | 55 + docs/formatsnapshot.html.in | 6 +- docs/generic.css | 11 +- docs/hvsupport.pl | 3 - docs/index.html.in | 162 +- docs/intro.html.in | 13 - docs/js/jquery-3.1.1.min.js | 4 + docs/js/jquery.rss.min.js | 11 + docs/js/moment.min.js | 7 + docs/libvirt-header-bg.png | Bin 1136 -> 0 bytes docs/libvirt-header-logo.png | Bin 25945 -> 0 bytes docs/libvirt-net-logical.fig | 159 -- docs/libvirt-net-logical.png | Bin 11243 -> 0 bytes docs/libvirt-net-physical.fig | 139 -- docs/libvirt-net-physical.png | Bin 11336 -> 0 bytes docs/libvirt.css | 319 ++-- docs/libvirtLogo.png | Bin 33698 -> 0 bytes docs/libvirtLogo404.png | Bin 32442 -> 0 bytes docs/logo-large-banner.png | Bin 0 -> 86032 bytes docs/logo-small-banner-light.png | Bin 0 -> 19049 bytes docs/logo.svg | 2153 +++++++++++++++++++++++++++ docs/main.css | 1 + docs/page.xsl | 101 +- docs/pending.html.in | 10 - docs/relatedlinks.html.in | 88 -- docs/remote.html.in | 2 +- docs/search.php.in | 2 - docs/sitemap.html.in | 490 ------ docs/todo.cfg-example | 26 - docs/todo.pl | 125 -- 49 files changed, 3263 insertions(+), 1635 deletions(-) delete mode 100644 docs/archdomain.html.in delete mode 100644 docs/archnetwork.html.in delete mode 100644 docs/archnode.html.in delete mode 100644 docs/archstorage.html.in create mode 100644 docs/contribute.html.in delete mode 100644 docs/deployment.html.in create mode 100644 docs/fonts/LICENSE.md create mode 100644 docs/fonts/hinted-Overpass-Bold.woff create mode 100644 docs/fonts/hinted-Overpass-BoldItalic.woff create mode 100644 docs/fonts/hinted-Overpass-Italic.woff create mode 100644 docs/fonts/hinted-Overpass-Light.woff create mode 100644 docs/fonts/hinted-Overpass-LightItalic.woff create mode 100644 docs/fonts/hinted-Overpass-Reg.woff create mode 100644 docs/fonts/stylesheet.css delete mode 100644 docs/intro.html.in create mode 100644 docs/js/jquery-3.1.1.min.js create mode 100644 docs/js/jquery.rss.min.js create mode 100644 docs/js/moment.min.js delete mode 100644 docs/libvirt-header-bg.png delete mode 100644 docs/libvirt-header-logo.png delete mode 100644 docs/libvirt-net-logical.fig delete mode 100644 docs/libvirt-net-logical.png delete mode 100644 docs/libvirt-net-physical.fig delete mode 100644 docs/libvirt-net-physical.png delete mode 100644 docs/libvirtLogo.png delete mode 100644 docs/libvirtLogo404.png create mode 100644 docs/logo-large-banner.png create mode 100644 docs/logo-small-banner-light.png create mode 100644 docs/logo.svg delete mode 100644 docs/pending.html.in delete mode 100644 docs/relatedlinks.html.in delete mode 100644 docs/sitemap.html.in delete mode 100644 docs/todo.cfg-example delete mode 100755 docs/todo.pl -- 2.9.3

8 43

[libvirt] [PATCH v2 0/3] wireshark: Further build system fixes
by Andrea Bolognani 07 Nov '16

07 Nov '16

Changes from v1: * don't attempt to strip the wireshark prefix when we're building the plugindir ourselves * use exec_prefix instead of prefix everywhere (suggested by Viktor Mihajlovski) Andrea Bolognani (3): wireshark: Don't redefine ws_plugindir wireshark: Make fallback path construction more reliable wireshark: Use ${exec_prefix} instead of ${prefix} m4/virt-wireshark.m4 | 25 +++++++++++++------------ tools/Makefile.am | 1 - 2 files changed, 13 insertions(+), 13 deletions(-) -- 2.7.4

2 5