October 2016 - Devel - libvirt List Archives

[libvirt] [PATCH v2] spec: Drop support for Fedora < 23
by Andrea Bolognani 19 Oct '16

19 Oct '16

We only claim support for OSs that are still supported by the respective vendors, which means anything older than Fedora 23 is out. Reword the comment a bit to highlight the criteria. --- Changes from v1: * drop version checks that are now obsolete (thanks Dan) libvirt.spec.in | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 00b95b8..545990c 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1,9 +1,10 @@ # -*- rpm-spec -*- -# This spec file assumes you are building for Fedora 20 or newer, -# or for RHEL 6 or newer. It may need some tweaks for other distros. +# This spec file assumes you are building on a Fedora or RHEL version +# that's still supported by the vendor: that means Fedora 23 or newer, +# or RHEL 6 or newer. It may need some tweaks for other distros. # If neither fedora nor rhel was defined, try to guess them from dist -%if (0%{?fedora} && 0%{?fedora} >= 20) || (0%{?rhel} && 0%{?rhel} >= 6) +%if (0%{?fedora} && 0%{?fedora} >= 23) || (0%{?rhel} && 0%{?rhel} >= 6) %define supported_platform 1 %else %define supported_platform 0 @@ -167,7 +168,7 @@ %endif # Enable wireshark plugins for all distros shipping libvirt 1.2.2 or newer -%if 0%{?fedora} >= 21 +%if 0%{?fedora} %define with_wireshark 0%{!?_without_wireshark:1} %endif @@ -209,7 +210,7 @@ %if 0%{?fedora} >= 25 %define tls_priority "@LIBVIRT,SYSTEM" %else - %if 0%{?fedora} >= 21 + %if 0%{?fedora} %define tls_priority "@SYSTEM" %else %define tls_priority "NORMAL" -- 2.7.4

2 1

[libvirt] [PATCH] spec: Drop support for Fedora < 23
by Andrea Bolognani 19 Oct '16

19 Oct '16

We only claim support for OSs that are still supported by the respective vendors, which means anything older than Fedora 23 is out. Reword the comment a bit to highlight the criteria. --- libvirt.spec.in | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 00b95b8..25dc31d 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1,9 +1,10 @@ # -*- rpm-spec -*- -# This spec file assumes you are building for Fedora 20 or newer, -# or for RHEL 6 or newer. It may need some tweaks for other distros. +# This spec file assumes you are building on a Fedora or RHEL version +# that's still supported by the vendor: that means Fedora 23 or newer, +# or RHEL 6 or newer. It may need some tweaks for other distros. # If neither fedora nor rhel was defined, try to guess them from dist -%if (0%{?fedora} && 0%{?fedora} >= 20) || (0%{?rhel} && 0%{?rhel} >= 6) +%if (0%{?fedora} && 0%{?fedora} >= 23) || (0%{?rhel} && 0%{?rhel} >= 6) %define supported_platform 1 %else %define supported_platform 0 -- 2.7.4

2 2

[libvirt] [PATCH v2 0/2] New libssh transport
by Pino Toscano 19 Oct '16

19 Oct '16

Hi, this series introduces a new libssh transport in libvirt, based on the libssh C library. This library supports what libssh2 does, and more: - easier API for known_hosts handling (there's a ticket upstream to request extensions for it, but what is implemented now works well) - potential GSSAPI authentication (not enabled yet because of a libssh bug [1]) - easier API for ssh-agent support The implementation for the new transport is based on the libssh2 one, hence it shares origin and style. [1] https://red.libssh.org/issues/242 Thanks, Changes from v1 to v2: - implemented keyboard interactive - code polish, and fixes Pino Toscano (2): virNetSocket: allow to not close FD libssh_transport: add new libssh-based transport config-post.h | 2 + configure.ac | 3 + include/libvirt/virterror.h | 2 + m4/virt-libssh.m4 | 26 + src/Makefile.am | 21 +- src/libvirt_libssh.syms | 22 + src/remote/remote_driver.c | 41 ++ src/rpc/virnetclient.c | 123 ++++ src/rpc/virnetclient.h | 13 + src/rpc/virnetlibsshsession.c | 1424 +++++++++++++++++++++++++++++++++++++++++ src/rpc/virnetlibsshsession.h | 80 +++ src/rpc/virnetsocket.c | 184 +++++- src/rpc/virnetsocket.h | 13 + src/util/virerror.c | 9 +- 14 files changed, 1959 insertions(+), 4 deletions(-) create mode 100644 m4/virt-libssh.m4 create mode 100644 src/libvirt_libssh.syms create mode 100644 src/rpc/virnetlibsshsession.c create mode 100644 src/rpc/virnetlibsshsession.h -- 2.7.4

3 10

[libvirt] [RFC] make virDomainQemuMonitorCommand work in any libvirt state
by Nikolay Shirokovskiy 19 Oct '16

19 Oct '16

Hi, all. We would like to use virDomainQemuMonitorCommand to query qemu independently of libvirt state. Currenly it is not possible. This API call takes job condition just like any other call and thus is unavailable on any lengthy(or stucked) synchronous job. I've already posted this question in list, just failed to find the reference. Somebody suggested to use proxy (and even an implementation) in between qemu and libvirt that can inject commands to qemu and filter replies. It is not really convinient. This way test setups will be different from production and we can not investigate problems in production environment. I'd like to drop acquiring job condition in the call as this function does not deal with libvirt state (except for the taint but is is ok, we will not mess things up here). But this is not enough, we need to make qemu monitor deal with many qemu commands simultaneously. Looks like it is quite a big change for test/debug case. But I guess eventually normal user cases can get benefits too from this monitor changes. For example all query API calls that query qemu directly can be changed to not to wait for some synchronous job finishing.(qemuDomainGetBlockJobInfo for example). Nikolay

4 4

[libvirt] [PATCH v3 0/2] Forbid new-line char in name of networks
by Sławek Kapłoński 19 Oct '16

19 Oct '16

v2: http://www.redhat.com/archives/libvir-list/2016-October/msg00451.html Differences in v3: * function to check string moved from src/util/virxml to src/util/virstring * validation if name of network contains \n char moved from parsing XML to functions responsible for create/define new networks Sławek Kapłoński (2): util: Add function to check if string contains some chars Forbid new-line char in name of new networks src/conf/network_conf.c | 2 +- src/libvirt_private.syms | 1 + src/network/bridge_driver.c | 6 ++++++ src/util/virstring.c | 9 +++++++++ src/util/virstring.h | 1 + 5 files changed, 18 insertions(+), 1 deletion(-) -- 2.10.0

2 8

[libvirt] How libvirt address qemu command line args
by zhunxun＠gmail.com 19 Oct '16

19 Oct '16

Now I want to add some args about TPM to domain's XML,so I can start a domain by virt-manager or other virsh command,and then ,I would like to use sVIrt security context to label vTPM and correspondingVM,But I do not know how to get these XML args in libvirt. the key problem is that how can i get and recognize these args!!! related XML content : <qemu:commandline> <qemu:arg value='-enable-kvm'/> <qemu:arg value='-drive'/> <qemu:arg value='file=/root/nvram_2.0-jin.qcow2,if=none,id=nvram0-0-0,format=qcow2'/> <qemu:arg value='-device'/> <qemu:arg value='tpm-tis,tpmdev=tpm-tpm0,id=tpm0'/> <qemu:arg value='-tpmdev'/> <qemu:arg value='libtpms,id=tpm-tpm0,nvram=nvram0-0-0,startup=clear'/> <qemu:arg value='-bios'/> <qemu:arg value='/root/xenSeabios/out/bios.bin'/> </qemu:commandline> zhunxun(a)gmail.com

3 2

[libvirt] [PATCH v2 0/3] fix hot(un)plug of chardev devices with TLS encryption
by Pavel Hrdina 19 Oct '16

19 Oct '16

Pavel Hrdina (3): qemu_alias: introduce qemuAliasChardevFromDevAlias helper qemu_command: create prefixed alias to separate variable qemu: always generate the same alias for tls-creds-x509 object src/qemu/qemu_alias.c | 16 +++++++++ src/qemu/qemu_alias.h | 3 ++ src/qemu/qemu_command.c | 41 ++++++++++++---------- src/qemu/qemu_hotplug.c | 23 +++++++----- ...xml2argv-serial-tcp-tlsx509-chardev-verify.args | 4 +-- .../qemuxml2argv-serial-tcp-tlsx509-chardev.args | 4 +-- 6 files changed, 60 insertions(+), 31 deletions(-) -- 2.10.1

2 5

[libvirt] Qemu: create empty cdrom
by Gromak Yuriy 19 Oct '16

19 Oct '16

Hello. Qemu is latest from master branch. Tryingto start a domain, which is connected toa blankcdrom: <disk type='file' device='cdrom'> <driver name='qemu' type='raw'/> <target dev='sdb' bus='scsi'/> <readonly/> <address type='drive' controller='0' target='1' bus='0' unit='0'/> </disk> But I get an error: qemu-system-x86_64: -drive if=none,id=drive-scsi0-0-1-0,readonly=on,format=raw: Can't use 'raw' as a block driver for the protocol level.

3 2

[libvirt] qemu-guest-agent windows
by Umar Draz 18 Oct '16

18 Oct '16

Hello All, I have install qemu guest agent on windows 10, but unable to get the ip address using this command virsh qemu-agent-command myvm '{ "execute": "guest-network-get-interfaces" }' I am getting the following error on above command. ibvirt: QEMU Driver error : internal error: unable to execute QEMU agent command 'guest-network-get-interfaces': this feature or command is not currently supported but the same command successfully working on linux vms. Would you please help if there any other way to get the interfaces ip of windows vm Br. Umar

4 15

[libvirt] [PATCH] vsh: Using vshError rather than virReportError
by Kothapally Madhu Pavan 18 Oct '16

18 Oct '16

Correcting the error reporting method by using vshError instead of virReportError Signed-off-by: Kothapally Madhu Pavan <kmp(a)linux.vnet.ibm.com> --- tools/virsh-domain.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 050e7fb..c9fabf2 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -10475,9 +10475,9 @@ cmdMigrate(vshControl *ctl, const vshCmd *cmd) if (vshCommandOptBool(cmd, "postcopy-after-precopy")) { if (!vshCommandOptBool(cmd, "postcopy")) { - virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s", - _("--postcopy-after-precopy can only be used with " - "--postcopy")); + vshError(ctl, "%s", + _("argument unsupported: --postcopy-after-precopy can only " + "be used with --postcopy")); goto cleanup; } iterEvent = virConnectDomainEventRegisterAny(

3 2