September 2014 - Devel - libvirt List Archives

[libvirt] [PATCHv2 0/2] Add support for turning off offloading for virtio-net
by Ján Tomko 24 Sep '14

24 Sep '14

v2: rework XML to avoid underscores Ján Tomko (2): conf: add options for disabling segment offloading qemu: wire up virtio-net segment offloading options docs/formatdomain.html.in | 24 ++- docs/schemas/domaincommon.rng | 44 ++++- src/conf/domain_conf.c | 218 ++++++++++++++++++++- src/conf/domain_conf.h | 15 ++ src/qemu/qemu_command.c | 40 ++++ .../qemuxml2argv-net-virtio-disable-offloads.args | 10 + .../qemuxml2argv-net-virtio-disable-offloads.xml | 35 ++++ tests/qemuxml2argvtest.c | 2 + tests/qemuxml2xmltest.c | 1 + 9 files changed, 381 insertions(+), 8 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-net-virtio-disable-offloads.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-net-virtio-disable-offloads.xml -- 1.8.5.5

2 7

[libvirt] [PATCH v2] Fix bug with loading bridge name for active domain during libvirtd start
by Pavel Hrdina 24 Sep '14

24 Sep '14

If you have a bridge network in running domain and libvirtd is restarted the information about host bridge interface is lost from live xml. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1140085 Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- changes in v2: - added error message if bridge name is missing. src/conf/domain_conf.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 9cc118c..0a7d0b8 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -6850,6 +6850,15 @@ virDomainActualNetDefParseXML(xmlNodePtr node, goto error; } VIR_FREE(class_id); + } else if (actual->type == VIR_DOMAIN_NET_TYPE_BRIDGE) { + char *brname = virXPathString("string(./source/@bridge)", ctxt); + if (!brname) { + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("Missing <source> element with bridge name in " + "interface's <actual> element")); + goto error; + } + actual->data.bridge.brname = brname; } bandwidth_node = virXPathNode("./bandwidth", ctxt); -- 1.8.5.5

2 2

[libvirt] [PATCH] Fix bug with loading bridge name for active domain during libvirtd start
by Pavel Hrdina 24 Sep '14

24 Sep '14

If you have a bridge network in running domain and libvirtd is restarted the information about host bridge interface is lost from live xml. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1140085 Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- src/conf/domain_conf.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 3ccec1c..fa4166c 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -6837,6 +6837,10 @@ virDomainActualNetDefParseXML(xmlNodePtr node, goto error; } VIR_FREE(class_id); + } else if (actual->type == VIR_DOMAIN_NET_TYPE_BRIDGE) { + char *brname = virXPathString("string(./source/@bridge)", ctxt); + if (brname) + actual->data.bridge.brname = brname; } bandwidth_node = virXPathNode("./bandwidth", ctxt); -- 1.8.5.5

2 1

[libvirt] [PATCHv2 0/4] Improve backing store error reporting
by Peter Krempa 24 Sep '14

24 Sep '14

New version incorporates some review feedback from John. The changes were borderline-trivial so I've reposted the series. Patch 2/4 is new. Peter Krempa (4): util: storage: Allow metadata crawler to report useful errors qemu: Sanitize argument names and empty disk check in qemuDomainDetermineDiskChain qemu: Report better errors from broken backing chains storage: Improve error message when traversing backing chains src/qemu/qemu_domain.c | 36 +++++++----------------------------- src/qemu/qemu_domain.h | 3 ++- src/qemu/qemu_driver.c | 10 +++++----- src/qemu/qemu_hotplug.c | 2 +- src/qemu/qemu_process.c | 11 +++++++---- src/security/virt-aa-helper.c | 2 +- src/storage/storage_driver.c | 42 +++++++++++++++++++++++++++++++----------- src/storage/storage_driver.h | 3 ++- tests/virstoragetest.c | 2 +- 9 files changed, 57 insertions(+), 54 deletions(-) -- 2.1.0

2 9

[libvirt] [PATCH v4 0/4] Introduce new universal tunable event
by Pavel Hrdina 24 Sep '14

24 Sep '14

This patch series introduce new tunable event to inform management applications about changes of tunable values. With this universal event we will be able to report updates for all different tunable values like cpu tuning, block tinning, memory tinning, etc... There is missing documentation for all events so the documentation for this event will be part of the patches to document all events. The format of returned typedParams will contain params with name composed from prefix and the exact value. For example for cputune the typedParam's field would be "cputune.shares". List of actually returned values will be part of the documentation for the events. Changes from v3: - the cputune event is gone, now we will have one universal event for all tunable values Pavel Hrdina (4): domain_conf: separate structures from virDomainDef event: introduce new event for tunable values add an example how to use tunable event cputune_event: queue the event for cputune updates daemon/remote.c | 45 ++++++++++++++++ examples/object-events/event-test.c | 52 +++++++++++++++++- include/libvirt/libvirt.h.in | 22 ++++++++ src/conf/domain_conf.h | 102 +++++++++++++++++++++--------------- src/conf/domain_event.c | 93 ++++++++++++++++++++++++++++++++ src/conf/domain_event.h | 9 ++++ src/libvirt_private.syms | 2 + src/qemu/qemu_cgroup.c | 18 ++++++- src/qemu/qemu_driver.c | 76 +++++++++++++++++++++++++++ src/remote/remote_driver.c | 42 +++++++++++++++ src/remote/remote_protocol.x | 14 ++++- src/remote_protocol-structs | 9 ++++ tools/virsh-domain.c | 33 ++++++++++++ 13 files changed, 473 insertions(+), 44 deletions(-) -- 1.8.5.5

3 23

[libvirt] [PATCH 0/2] add nodeset check in numatune
by Chen Fan 24 Sep '14

24 Sep '14

for memnode.nodeset in numatune, when setting it more than the host nodes, it should fail. Chen Fan (2): numatune: add check for memnode.nodeset range numatune: move up verification codes in virNumaSetupMemoryPolicy src/conf/numatune_conf.c | 32 ++++++++++++++++++++++++++++++++ src/conf/numatune_conf.h | 4 ++++ src/util/virnuma.c | 15 --------------- 3 files changed, 36 insertions(+), 15 deletions(-) -- 1.9.3

3 6

[libvirt] [PATCH] LXC: emphasis uid start of idmap only accept '0' in docs
by Chen Hanxiao 24 Sep '14

24 Sep '14

We don't accept any other values except '0'. Signed-off-by: Chen Hanxiao <chenhanxiao(a)cn.fujitsu.com> --- docs/formatdomain.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index eefdd5e..bb72452 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -315,7 +315,7 @@ <dl> <dt><code>start</code></dt> - <dd>First user ID in container.</dd> + <dd>First user ID in container. It must be '0'.</dd> <dt><code>target</code></dt> <dd>The first user ID in container will be mapped to this target user ID in host.</dd> -- 1.9.0

3 2

[libvirt] [PATCH V2] libvirt-guests: run after time-sync.target
by Jim Fehlig 23 Sep '14

23 Sep '14

When libvirt-guests is configured to start guests on host boot, it is possible for guests start and read the host clock before it is synchronized. Services such as libvirt-guests that require correct time should use the Special Passive System Unit time-sync.target http://www.freedesktop.org/software/systemd/man/systemd.special.html#time-s… Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- V2 of https://www.redhat.com/archives/libvir-list/2014-September/msg00426.html In V2: Use time-sync.target instead of ntp-wait.service tools/libvirt-guests.service.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libvirt-guests.service.in b/tools/libvirt-guests.service.in index d8d7adf..cc04b6d 100644 --- a/tools/libvirt-guests.service.in +++ b/tools/libvirt-guests.service.in @@ -1,6 +1,6 @@ [Unit] Description=Suspend Active Libvirt Guests -After=network.target libvirtd.service +After=network.target libvirtd.service time-sync.target Documentation=man:libvirtd(8) Documentation=http://libvirt.org -- 1.8.4.5

2 2

[libvirt] [PATCH 0/2] qemu: Fix specifying CPU model with arm on x86
by Cole Robinson 23 Sep '14

23 Sep '14

Patch 1 is a cleanup, just code movement. Patch 2 has the goods, details in the commit message Cole Robinson (2): qemu_command: Split qemuBuildCpuArgStr qemu: Don't compare CPU against host for TCG src/qemu/qemu_command.c | 202 ++++++++++++--------- .../qemuxml2argv-aarch64-virt-default-nic.args | 3 +- .../qemuxml2argv-aarch64-virt-default-nic.xml | 3 + .../qemuxml2argv-aarch64-virt-virtio.args | 3 +- .../qemuxml2argv-aarch64-virt-virtio.xml | 3 + .../qemuxml2argvdata/qemuxml2argv-cpu-exact1.args | 2 +- tests/qemuxml2argvdata/qemuxml2argv-cpu-exact1.xml | 4 +- .../qemuxml2argv-cpu-exact2-nofallback.args | 2 +- .../qemuxml2argv-cpu-exact2-nofallback.xml | 4 +- .../qemuxml2argvdata/qemuxml2argv-cpu-exact2.args | 2 +- tests/qemuxml2argvdata/qemuxml2argv-cpu-exact2.xml | 4 +- .../qemuxml2argv-cpu-fallback.args | 2 +- .../qemuxml2argvdata/qemuxml2argv-cpu-fallback.xml | 4 +- .../qemuxml2argv-cpu-minimum1.args | 2 +- .../qemuxml2argvdata/qemuxml2argv-cpu-minimum1.xml | 4 +- .../qemuxml2argv-cpu-minimum2.args | 2 +- .../qemuxml2argvdata/qemuxml2argv-cpu-minimum2.xml | 4 +- .../qemuxml2argv-cpu-nofallback.xml | 2 +- .../qemuxml2argvdata/qemuxml2argv-cpu-strict1.args | 2 +- .../qemuxml2argvdata/qemuxml2argv-cpu-strict1.xml | 4 +- .../qemuxml2argv-graphics-spice-timeout.args | 2 +- .../qemuxml2argv-graphics-spice-timeout.xml | 4 +- .../qemuxml2argv-pseries-cpu-exact.args | 4 +- tests/qemuxml2argvtest.c | 21 ++- .../qemuxml2xmlout-graphics-spice-timeout.xml | 4 +- 25 files changed, 166 insertions(+), 127 deletions(-) -- 2.1.0

1 2

[libvirt] [PATCH] libvirt-guests: wait for ntp service
by Jim Fehlig 23 Sep '14

23 Sep '14

If an NTP server is configured on the host, it is possible for libvirt-guests to start before the NTP service, in which case guest clocks won't be synchronized to the host clock. Add ntp-wait.service to "After" in libvirt-guests systemd service file, ensuring NTP has synchronized the host clock before starting any guests. Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- tools/libvirt-guests.service.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libvirt-guests.service.in b/tools/libvirt-guests.service.in index d8d7adf..226b3bd 100644 --- a/tools/libvirt-guests.service.in +++ b/tools/libvirt-guests.service.in @@ -1,6 +1,6 @@ [Unit] Description=Suspend Active Libvirt Guests -After=network.target libvirtd.service +After=network.target libvirtd.service ntp-wait.service Documentation=man:libvirtd(8) Documentation=http://libvirt.org -- 1.8.4.5

3 12