January 2013 - Devel - libvirt List Archives

[libvirt] This patch adds the label to lxc-enter-namespace
by Daniel J Walsh 02 Feb '13

02 Feb '13

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 (2nd pass) lxc-enter-namespace allows a process from outside a container to start a process inside a container. One problem with the current code is the process running within the container would run with the label of the process that created it. For example if the admin process is running as unconfined_t and executes the following command # virsh -c lxc:/// lxc-enter-namespace --nolabel dan -- /bin/ps -eZ LABEL PID TTY TIME CMD system_u:system_r:svirt_lxc_net_t:s0:c0.c1023 1 pts/0 00:00:00 systemd system_u:system_r:svirt_lxc_net_t:s0:c0.c1023 3 pts/1 00:00:00 sh system_u:system_r:svirt_lxc_net_t:s0:c0.c1023 24 ? 00:00:00 systemd-journal system_u:system_r:svirt_lxc_net_t:s0:c0.c1023 29 ? 00:00:00 dhclient staff_u:unconfined_r:unconfined_t:s0-s0:c0.c1023 47 ? 00:00:00 ps Note the ps command is running as unconfined_t, After this patch, virsh -c lxc:/// lxc-enter-namespace dan -- /bin/ps -eZ LABEL PID TTY TIME CMD system_u:system_r:svirt_lxc_net_t:s0:c0.c1023 1 pts/0 00:00:00 systemd system_u:system_r:svirt_lxc_net_t:s0:c0.c1023 3 pts/1 00:00:00 sh system_u:system_r:svirt_lxc_net_t:s0:c0.c1023 24 ? 00:00:00 systemd-journal system_u:system_r:svirt_lxc_net_t:s0:c0.c1023 32 ? 00:00:00 dhclient system_u:system_r:svirt_lxc_net_t:s0:c0.c1023 38 ? 00:00:00 ps I also add a --nolabel command to virsh, which can go back to the original behaviour. virsh -c lxc:/// lxc-enter-namespace --nolabel dan -- /bin/ps -eZ LABEL PID TTY TIME CMD system_u:system_r:svirt_lxc_net_t:s0:c0.c1023 1 pts/0 00:00:00 systemd system_u:system_r:svirt_lxc_net_t:s0:c0.c1023 3 pts/1 00:00:00 sh system_u:system_r:svirt_lxc_net_t:s0:c0.c1023 24 ? 00:00:00 systemd-journal system_u:system_r:svirt_lxc_net_t:s0:c0.c1023 32 ? 00:00:00 dhclient staff_u:unconfined_r:unconfined_t:s0-s0:c0.c1023 37 ? 00:00:00 ps Everything seems to be working perfectly now. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlEC320ACgkQrlYvE4MpobPDjwCfTLjGarwDOLA333vE+XVp0Zj2 LYkAn3WGX3h309/kJejbE3uvXnIUCKJV =rwfM -----END PGP SIGNATURE-----

2 2

[libvirt] [PATCH 0/7] documentation improvements - again
by Claudio Bley 01 Feb '13

01 Feb '13

Hi. The first two patches are aimed at avoiding generation of empty argument description lists, which might happen if a function has no documentation for some argument or its return type. This was happening with virTypedParams* functions (see https://www.redhat.com/archives/libvir-list/2013-January/msg01428.html) Patch #3 is just a small cleanup, since a table is not the right thing to use and it looks better in some circumstances. Patch #4 sports processing of code blocks embedded into comments. Basically, it is similar to markdown syntax, except that you only need to indent your code with 2 spaces. Patch #5 prepares for the later patches being able to distinguish between different <pre> blocks. Patch #6 and #7 are pretty much self explanatory, I guess. Note, that SHJS's license is GPLv3. Claudio Bley (7): docs: don't write out empty info attributes for function arguments docs: only generate function argument info for args with a description docs: use a div instead of a 3 column table for undisclosed notices docs: process code blocks similar to markdown docs: add class "description" to div's containing descriptions docs: define style of code blocks inside descriptions docs: syntax highlight code blocks using SHJS docs/apibuild.py | 8 +- docs/libvirt.css | 8 ++ docs/newapi.xsl | 209 +++++++++++++++++++++++++++++-------------------- docs/page.xsl | 5 +- docs/sh_c.min.js | 1 + docs/sh_emacs.min.css | 1 + docs/sh_main.min.js | 4 + 7 files changed, 148 insertions(+), 88 deletions(-) create mode 100644 docs/sh_c.min.js create mode 100644 docs/sh_emacs.min.css create mode 100644 docs/sh_main.min.js -- 1.7.9.5

2 20

[libvirt] Canonical citation for Libvirt
by Lempereur, Brett 01 Feb '13

01 Feb '13

Hi, Is there a canonical paper I can cite for Libvirt in academic publications? The best I've found so far is Bolt, M., Birkenheuer, G., Niehörster, O., & Brinkmann, A. (2010). Non-Intrusive Virtualization Management using Libvirt. Proceedings of the 2nd Design, Automation, and Test in Europe Conference (DATE'10) (pp. 1-6). Dresden, Germany: IEEE. Retrieved from http://ieeexplore.ieee.org/stamp/stamp.jsp?tp=&arnumber=5457142&isnumber=54… A lot of frameworks used in academic work have sort of "standard" citations, people that use the framework tend to cite that paper. The authors get citations, we get cool frameworks, everyone wins. Brett ________________________________ Important Notice: the information in this email and any attachments is for the sole use of the intended recipient(s). If you are not an intended recipient, or a person responsible for delivering it to an intended recipient, you should delete it from your system immediately without disclosing its contents elsewhere and advise the sender by returning the email or by telephoning a number contained in the body of the email. No responsibility is accepted for loss or damage arising from viruses or changes made to this message after it was sent. The views contained in this email are those of the author and not necessarily those of Liverpool John Moores University.

2 1

[libvirt] [Libvirt][Sheepdog]Sheepdog pool/volume storage driver for libvirt problem
by harryxiyou 01 Feb '13

01 Feb '13

Hi Sebastian, Morita and other developers, I have studied Sheepdog pool/volume storage driver for libvirt and i have following questions. Please give me some suggestions. Thanks in advance ;-) 1, In libvirt/src/storage/storage_backend_sheepdog.c, i just find we realized create/delete/resize volume(send these parameters to let libvirtd receive and execute them). I cannot find the operations about snapshot, such as creating/deleting snapshot. I cannot also find the operations about opening/closing cache. 2, In the func create/delete/resize volume, we call func 'virCommandRun(cmd, NULL);' to run these commands, which i think the func send these parameters to daemon libvirtd and libvirtd send these parameters to Sheepdog, then Sheepdog executes them, right? 3, In func "virStorageBackendSheepdogCreateVol", it composes cmd like this "virCommandPtr cmd = virCommandNewArgList(COLLIE, "vdi", "create", vol->name, NULL);" then send create parameters. When Sheepdog receive these parameters, how Sheepdog create this volume? I find Sheepdog create a volume like this. $ qemu-img create sheepdog:Alice 256G 4, What are the essences of func "virStorageBackendSheepdogRefreshPool" and "virStorageBackendSheepdogRefreshVol"? In func "virStorageBackendSheepdogCreateVol", after craete volume operations, we call "virStorageBackendSheepdogRefreshVol". But in func "virStorageBackendSheepdogDeleteVol" and "virStorageBackendSheepdogResizeVol", we do not call "virStorageBackendSheepdogRefreshVol", why? 5, Actually, i am not clear about how QEMU receive these parameters (like create/delete/snapshot, etc) and execute the real jobs? Thanks for anyone's suggestions ;-) -- Thanks Harry Wei

3 8

[libvirt] Release of libvirt-1.0.2
by Daniel Veillard 01 Feb '13

01 Feb '13

As scheduled, I just made the release today, it is tagged in git and tarball and rpms are available at the usual FTP place: ftp://libvirt.org/libvirt/ This is a large release, including over 450 commit, with a lot of code refactoring, improvements and a huge set of fixes a lot of them coming from the cleanup of the Coverity reports. Considering the volume of changes let's schedule the next release (probably 1.0.3) for the end of the month of February. Features: - LXC improvements (Daniel P. Berrange) - S390 architecture improvement (Viktor Mihajlovski) - Power architecture improvement (Li Zhang) - large Coverity report cleanups and associated bug fixes (John Ferlan) - virTypedParams* APIs to helps with those data structures (Jiri Denemark) Documentation: - aesthetical cleanups (Martin Kletzander) - fix missed documentation for virterror functions (Claudio Bley) - util: Fix docs for virBitmapParse (Peter Krempa) - rng: Have colorful *.rng with editor (Osier Yang) - safe{read,write}: Document usage with nonblocking FD (Michal Privoznik) - Generate documentation for virTypedParams* APIs (Jiri Denemark) - event.c source file was renamed as virevent.c (Jiri Denemark) - Add some style and color to the HTML documentation (Claudio Bley) - don't use <i> and <tt> HTML tags (Claudio Bley) - Assign classes to documentation elements (Claudio Bley) - remove extra " (Eric Blake) - maint: typo fix (Eric Blake) - restrict the set of characters for info keys (Claudio Bley) - simplify code (Claudio Bley) - mention git rename detection (Eric Blake) - add some more hacking tips (Eric Blake) - fix typo in isa-serial additions (Laine Stump) - network: fix typos and docs (Guannan Ren) - maint: fix comment typo (Eric Blake) - break longer text into paragraphs in HTML (Claudio Bley) - remove duplicate check in index.add (Claudio Bley) - Add missing flags to migrate documentation (Guido Günther) - Add docs and rng schema for new XML tag sgio (Osier Yang) - Fix the comment grammar (Osier Yang) - Remove the inexistent function in comments (Osier Yang) - fix typo in the word affinities (Martin Kletzander) - Fix documentation for readonly element (Jiri Denemark) - Replace </br> with <br/> in docs/news.html.in (Peter Krempa) Portability: - Make sure we only abort without libcurl if $with_esx = yes (Guido Günther) - build: Fix RPM build errors related to libvirt-lxc API (Viktor Mihajlovski) - build: fix build on BSD (Eric Blake) - build: further fixes for broken if_bridge.h (Eric Blake) - securityselinuxhelper.c: Don't try to include xattr.h if not available (John Ferlan) - build: work around broken kernel header (Eric Blake) - build: avoid m4_expand for RHEL 5 (Eric Blake) - build: move file deleting action from %files list to %install (Yufang Zhang) - build: libvirt-guests files misplaced in specfile (Viktor Mihajlovski) - build: fix mingw rpm build (Eric Blake) - build: fix build with optimization enabled (Eric Blake) - build: make broken -Wlogical-op test be gcc-only (Eric Blake) - util: FreeBSD: stub out CPU affinity functions (Roman Bogorodskiy) - nodeinfo: add FreeBSD support (Roman Bogorodskiy) - build: Check for broken GCC -Wlogical-op in configure (Viktor Mihajlovski) Bug fixes: - conf: Don't format cputune element when not needed (Martin Kletzander) - conf: Fix cpumask leak in virDomainDefFree (Ján Tomko) - qemu: Destroy domain on decompression binary error (Michal Privoznik) - rpc: Fix crash on error paths of message dispatching (Peter Krempa) - vbox: Address false positive for NULL dereference (John Ferlan) - libxl: Fix removing non-persistent domain after save (Jim Fehlig) - libxl: Fix race between destruction of objects (Jim Fehlig) - libxl: Fix races in libxl event code (Jim Fehlig) - libxl: Fix handling of timeouts (Jim Fehlig) - conf: avoid NULL deref for pmsuspended domain state (Eric Blake) - qemu_monitor: Fix tray-open attribute in query-block (Michal Privoznik) - Fix bogus reporting of KVM support for non-native emulators (Daniel P. Berrange) - Move QEMU capabilities initialization later in QEMU startup (Daniel P. Berrange) - Fix performance & reliabilty of QMP probing (Daniel P. Berrange) - qemu: escape ipv6 for rbd network disk hosts (Josh Durgin) - snapshot: fix state after external snapshot of S3 domain (Eric Blake) - python: Fix bindings for virDomainSnapshotGet{Domain,Connect} (Jiri Denemark) - Fix crash free'ing securityDriverNames in QEMU driver (Daniel P. Berrange) - Fix leak of securityDriverNames (Daniel P. Berrange) - Avoid use of free'd memory in auto destroy callback (Daniel P. Berrange) - Ensure nodeinfo struct is initialized to zero (Daniel P. Berrange) - apparmor: Avoid freeing uninitialized pointer (Jiri Denemark) - xen: Actually fix the uninitialized variable (Peter Krempa) - xen: Initialize variable before using (Peter Krempa) - util: Need to add virCommandFree() (John Ferlan) - storage: Need to add virCommandFree() (John Ferlan) - security: Need to add virCommandFree() (John Ferlan) - parallels: Resolve some resource leaks (John Ferlan) - qemu: Re-add driver unlock to qemuDomainSendKey (Viktor Mihajlovski) - conf: Fix usage of virBitmapParse (Peter Krempa) - virbitmaptest: Resolve Coverity errors (John Ferlan) - lxc_process: Avoid passing NULL iface->iname (John Ferlan) - lxc_driver: Need to check for vm before calling virDomainUnlock(vm) (John Ferlan) - tests: Remove VIR_FREE() on static/stack buffer (der.data) (John Ferlan) - Fix nwfilter driver reload/shutdown handling when unprivileged (Daniel P. Berrange) - conf: Check if number of vCPUs fits in the storage variable (Peter Krempa) - tests: Need to initialize 'test' properly on error path (John Ferlan) - virkeepalive: Remove erroneous VIR_FREE(msg) (John Ferlan) - security: Need to initialize 'sens' (John Ferlan) - interface: Need to initialize 'ifaces_list' (John Ferlan) - storage: Need to initialize 'zerobuf' (John Ferlan) - virsh: Need to intialize 'str' (John Ferlan) - lxc: Need to initialize 'dst' (John Ferlan) - virfile: Need to initialize 'looppath' (John Ferlan) - commandtest: Need to initialize 'errbuf' (John Ferlan) - virnetdev: Need to initialize 'pciConfigAddr' (John Ferlan) - virnetsockettest: Need to initialize 'path' (John Ferlan) - virnetserver: Need to initialize 'sigdata' (John Ferlan) - conf: Need to initialize variables before VIR_FREE (John Ferlan) - uml: Avoid resource leak of event in umlInofityEvent (John Ferlan) - selinux: Resolve resource leak using the default disk label (John Ferlan) - util: Need to check child JSON allocation before use (John Ferlan) - parallels: Need to handle virJSONValueObjectGetString error (John Ferlan) - qemu: Reject attempts to create snapshots with names containig '/' (Peter Krempa) - qemu: Don't return success if creation of snapshot save file fails (Peter Krempa) - Fix race condition when destroying guests (Daniel P. Berrange) - storage: Fix lvcreate parameter for backingStore. (Atsushi Kumagai) - virobject: Remove the bogus ! from call to virObjectInitialize() (John Ferlan) - qemu: Check valid activeDev before calling pciDeviceSetUsedBy (John Ferlan) - Followup fix for integer wraparound in port allocator (Daniel P. Berrange) - qemu: Double mutex unlock in qemuDomainModifyDeviceFlags (Viktor Mihajlovski) - fixed xt_physdev warning when defining ip(6)tables rules (Reinier Schoof) - conf: don't fail to parse <boot> when parsing a single device (Laine Stump) - Fix inheritance of virNetClient (Daniel P. Berrange) - Avoid integer wrap on remotePortMax in QEMU driver (Daniel P. Berrange) - python: Avoid freeing uninitialized new_params pointer (Jiri Denemark) - Fix typo in variable name (Guido Günther) - libxl: Fix cleanup on domain start error (Jim Fehlig) - libxl: Check for libxl_ctx_alloc failure (Jim Fehlig) - libxl: Don't free domain death event (Jim Fehlig) - locking: Resolve resource leaks on non error path (John Ferlan) - conf: fix leak in virDomainVcpuPinAdd (Ján Tomko) - conf: fix class_id bitmap leak in virNetworkObj (Ján Tomko) - qemu: fix QEMU_CAPS_NO_ACPI detection (Ján Tomko) - openvz: Need to check 'vm' first before dereferencing 'def' (John Ferlan) - interface: Need to check ifacedef->mac not just ifacedef after strdup() (John Ferlan) - qemu: Don't update count of vCPUs if hot-unplug has failed (Peter Krempa) - libvirt: lxc: don't mkdir when selinux is disabled (Gao feng) - xen: Resolve resource leak with 'cpuset' (John Ferlan) - interface: Resolve resource leak wth 'tmp_iface_objs' (John Ferlan) - storage: Resource resource leak using 'tmp_vols' (John Ferlan) - test: Resource resource leak with 'tmp_vols' (John Ferlan) - rpc: Avoid resource leak of 'socks' if any object append fails (John Ferlan) - util: Resolve resource leak for 'res' in virSetInherit error path. (John Ferlan) - interface: Need to initialize 'add_to_list' (John Ferlan) - lxc: Initialize dst due to potential cleanup usage before setting (John Ferlan) - openvz: Need to initialize 'ret' for kb_per_pages error path (John Ferlan) - parallels: Resolve issues with uninitialized 'ret' value (John Ferlan) - storage: Need to also VIR_FREE(reg) (John Ferlan) - Fix typo LIBCURL_{CFLAGS,LIBS} to CURL_{CFLAGS,LIBS} (Daniel P. Berrange) - Fix build due to previous LXC patch (Daniel P. Berrange) - build: fix incomplete WITH_SASL conversion (Eric Blake) - network: bridge: Fix regression when defining persistent networks (Peter Krempa) - storage: Resolve resource leak using 'vol' buffer (John Ferlan) - phyp: Resolve some file descriptor leaks (John Ferlan) - qemu_agent: Remove agent reference only when disposing it (Michal Privoznik) - libvirt: lxc: fix incorrect parameter of lxcContainerMountProcFuse (Gao feng) - util: Check for NULL 'dev' on input to usbFreeDevice (John Ferlan) - maint: avoid potential promotion issues with [ug]id_t (Eric Blake) - Resolve COPY_PASTE error found by Coverity (John Ferlan) - storage: fix leak in virStorageBackendLogicalMakeVol (Ján Tomko) - cpu: Avoid NULL dereference (John Ferlan) - lxc: Avoid possible NULL dereference on *root prior to opendir(). (John Ferlan) - remote: Avoid calling virAuthConfigLookup() if 'credname' is NULL. (John Ferlan) - vmware: Avoid NULL dereference for 'caps' (John Ferlan) - xen: Avoid possible NULL dereference (John Ferlan) - Fix virLXCPrepareHostDevices method (Daniel P. Berrange) - Only initialize capabilities after setting dir permissions (Daniel P. Berrange) - build: install libvirt sysctl file correctly (Eric Blake) - snapshot: qemu: Fix segfault and vanishing snapshots when redefining (Peter Krempa) - qemu: Detect VGA_QXL capability correctly (Michal Privoznik) - qemu: fix a segfault in qemuProcessWaitForMonitor (Ján Tomko) - parallels: check and handle error for virAsprintf() calls (John Ferlan) - udev: check and handle error for virAsprintf() calls (John Ferlan) - util: fix botched check for new netlink request filters (Laine Stump) - blockjob: fix memleak that prevented block pivot (Eric Blake) - util: fix functions that retrieve SRIOV VF info (Laine Stump) - Fix parsing of arch from domain XML (Daniel P. Berrange) - Fix CPU baseline to not hardcode arch (Daniel P. Berrange) - Fix SELinux security label test (Daniel P. Berrange) - spec: Fix script warning when uninstalling libvirt-client (Cole Robinson) - network: don't require private addresses if dnsmasq uses SO_BINDTODEVICE (Laine Stump) - `apparmor: Fix build (Jiri Denemark) - S390: Fix virSysinfoRead memory corruption (Viktor Mihajlovski) Improvements: - Ignore '.trs' files (Martin Kletzander) - build: Regenerate man pages on version bump (Jiri Denemark) - rng: Change the datatype for volume name for common use (Osier Yang) - rng: Remove the duplicate definition (Osier Yang) - qemu_hotplug: Rework media changing process (Michal Privoznik) - maint: one missed syms file (Eric Blake) - vbox: Adjust the UTF FREE macros (John Ferlan) - virsh: Add --print-xml flag for attach-disk command (Peter Krempa) - libxl: Domain event handler improvements (Jim Fehlig) - libxl: Explicitly remove timeouts (Jim Fehlig) - maint: make it easier to sort syms files (Eric Blake) - qemuDomainSendKey: Relax the qemu driver locking (Michal Privoznik) - node_memory: Add '\n' to help message (Satoru Moriya) - locking: use virStrcpyStatic instead of memcpy (John Ferlan) - Make python objects inherit from 'object' base class (Daniel P. Berrange) - selinux: Properly indent preprocessor directives (Jiri Denemark) - selinux: Only create the selabel_handle once. (Richard W.M. Jones) - parallels_utils: Check return status properly from virCommandRun() (John Ferlan) - test: Add support for thread and core information for the test driver (Peter Krempa) - capabilities: Add additional data to the NUMA topology info (Peter Krempa) - capabilities: Switch CPU data in NUMA topology to a struct (Peter Krempa) - conf: Split out NUMA topology formatting to simplify access to data (Peter Krempa) - schemas: Add schemas for more CPU topology information in the caps XML (Peter Krempa) - schema: Make the cpuset type reusable across schema files (Peter Krempa) - S390: Enhance memballoon handling for virtio-s390 (Viktor Mihajlovski) - qemu_agent: Ignore expected EOFs (Michal Privoznik) - nodeinfo: Use sa_assert() instead of Coverity error tag (John Ferlan) - build: allow virObject to have no parent (Eric Blake) - qemu: Support ram bar size for qxl devices (Alon Levy) - viralloc: Adjust definition of VIR_FREE() for Coverity (John Ferlan) - conf: Improve error messages if parsing of vCPU count fails (Peter Krempa) - virsh-domain: Refactor error paths for cmdCPUStats (Peter Krempa) - fix typos in comments for VIR_DOMAIN_PROCESS_SIGNAL_{PWR,SYS} (Claudio Bley) - storage: Add coverity[dead_error_condition] to avoid error (John Ferlan) - network: Add coverity[leaked_handle] to ignore error (John Ferlan) - remote: Avoid coverity[leaked_storage] message. (John Ferlan) - qemu: Add coverity[negative_returns] tag (John Ferlan) - rpc: Add coverity[dead_error_begin] tag (John Ferlan) - xen: Add coverity[ptr_arith] and [sign_extension] tags (John Ferlan) - nodeinfo: Add coverity[dead_error_begin] and [returned_null] tags (John Ferlan) - lxc: Add coverity[dead_error_begin] tag in switch stmts (John Ferlan) - xend: Address some Coverity false positives (John Ferlan) - security: Use virStrcpy to move the label (John Ferlan) - qemu: Forbid snapshot names starting with '.' (Peter Krempa) - spec: indent %if to make it easier to see conditions (Eric Blake) - Log flags passed to qemuMigrationPrepare{Tunnel,Direct} APIs (Michal Privoznik) - Introduce virTypedParamsClear public API (Jiri Denemark) - virsh: Use virTypedParams* APIs in cpu-stats (Jiri Denemark) - virsh: Use virTypedParams* APIs in node-memory-tune (Jiri Denemark) - virsh: Use virTypedParams* APIs in numatune (Jiri Denemark) - virsh: Use virTypedParams* APIs in memtune (Jiri Denemark) - virsh: Use virTypedParams* APIs in domblkstat (Jiri Denemark) - virsh: Use virTypedParams* APIs in schedinfo (Jiri Denemark) - virsh: Use virTypedParams* APIs in domiftune (Jiri Denemark) - virsh: Use virTypedParams* APIs in blkiotune (Jiri Denemark) - virsh: Use virTypedParams* APIs in blkdeviotune (Jiri Denemark) - Add virTypedParams* APIs (Jiri Denemark) - qemu: Simplify condition with already extracted flag (Peter Krempa) - network: use bandwidth from portgroup when appropriate (Laine Stump) - network: Resolve some issues around vlan copying (John Ferlan) - lock_daemon: Simplify error handling (Peter Krempa) - virsh-volume.c: Switch to C99 initialization of vshCmdOptDef (Michal Privoznik) - virsh-snapshot.c: Switch to C99 initialization of vshCmdOptDef (Michal Privoznik) - virsh-secret.c: Switch to C99 initialization of vshCmdOptDef (Michal Privoznik) - virsh-pool.c: Switch to C99 initialization of vshCmdOptDef (Michal Privoznik) - virsh-nwfilter.c: Switch to C99 initialization of vshCmdOptDef (Michal Privoznik) - virsh-nodedev.c: Switch to C99 initialization of vshCmdOptDef (Michal Privoznik) - virsh-network.c: Switch to C99 initialization of vshCmdOptDef (Michal Privoznik) - virsh-interface.c: Switch to C99 initialization of vshCmdOptDef (Michal Privoznik) - virsh-host.c: Switch to C99 initialization of vshCmdOptDef (Michal Privoznik) - virsh-domain-monitor.c: Switch to C99 initialization of vshCmdOptDef (Michal Privoznik) - virsh-domain.c: Switch to C99 initialization of vshCmdOptDef (Michal Privoznik) - virsh.c: Switch to C99 initialization of vshCmdOptDef (Michal Privoznik) - libvirt.c: fix typo in comment (Claudio Bley) - Move comments after enum members (Claudio Bley) - include virterror_internal.h in threads.h (Hu Tao) - include util.h in cgroup.h (Hu Tao) - call virstateCleanup to do the cleanup before libvirtd exits (Hu Tao) - libxl: Use consistent parameter naming scheme (Jim Fehlig) - libxl: Use consistent style for function definitions (Jim Fehlig) - Convert libxl driver over to use virPortAllocator APIs (Daniel P. Berrange) - Convert QEMU driver over to use virPortAllocator APIs (Daniel P. Berrange) - Add a port allocator class (Daniel P. Berrange) - Convert all rpc classes over to virObjectLockable (Daniel P. Berrange) - Convert virDomainObj, qemuAgent, qemuMonitor, lxcMonitor to virObjectLockable (Daniel P. Berrange) - util: Check for negative indent in virBufferAdd (John Ferlan) - tools: Check return status on virBufferTrim() (John Ferlan) - rpc: Check and message setsockopt() (John Ferlan) - xen: Ignore return status for TCP_NODELAY (John Ferlan) - Add a virObjectLockable class holding a mutex (Daniel P. Berrange) - Allow for multi-level inheritance of virObject classes (Daniel P. Berrange) - Add 'lxc-enter-namespace' command to virsh (Daniel P. Berrange) - build: add new file, for lxc_protocol checking (Eric Blake) - Add implementation of virDomainLxcOpenNamespace to LXC driver (Daniel P. Berrange) - Implement the RPC protocol for the libvirt-lxc.la library (Daniel P. Berrange) - .gitignore: Sort alphabetically (Michal Privoznik) - Add missing stubs to securityselinuxhelper.c (Daniel P. Berrange) - Introduce an LXC specific public API & library (Daniel P. Berrange) - Add a test suite for validating SELinux labelling (Daniel P. Berrange) - Rename HAVE_POLKIT to WITH_POLKIT (Daniel P. Berrange) - Remove unused XMLRPC_REQUIRED var (Daniel P. Berrange) - Convert openwsman check to use LIBVIRT_CHECK_PKG (Daniel P. Berrange) - Convert ssh2 check to use LIBVIRT_CHECK_PKG (Daniel P. Berrange) - Rename HAVE_LIBSSH2 to WITH_SSH2 (Daniel P. Berrange) - Convert curl check over to use LIBVIRT_CHECK_PKG (Daniel P. Berrange) - Rename HAVE_LIBCURL to WITH_CURL (Daniel P. Berrange) - Convert fuse check over to use LIBVIRT_CHECK_PKG (Daniel P. Berrange) - Rename HAVE_FUSE to WITH_FUSE (Daniel P. Berrange) - Rename HAVE_GNUTLS to WITH_GNUTLS (Daniel P. Berrange) - Convert blkid check over to use LIBVIRT_CHECK_PKG (Daniel P. Berrange) - Convert HAVE_LIBBLKID to WITH_BLKID (Daniel P. Berrange) - Convert HAL check to use LIBVIRT_CHECK_PKG (Daniel P. Berrange) - Convert HAVE_HAL to WITH_HAL (Daniel P. Berrange) - Convert udev/pciaccess checks to use LIBVIRT_CHECK_PKG (Daniel P. Berrange) - Convert HAVE_UDEV to WITH_UDEV (Daniel P. Berrange) - Convert avahi check to use LIBVIRT_CHECK_PKG (Daniel P. Berrange) - Convert HAVE_AVAHI to WITH_AVAHI (Daniel P. Berrange) - Convert DBus check to use LIBVIRT_CHECK_PKG (Daniel P. Berrange) - Convert HAVE_DBUS to WITH_DBUS (Daniel P. Berrange) - Convert netcf check to use LIBVIRT_CHECK_PKG (Daniel P. Berrange) - Convert cap-ng check to use LIBVIRT_CHECK_LIB (Daniel P. Berrange) - Convert HAVE_CAPNG to WITH_CAPNG (Daniel P. Berrange) - Convert numactl checks to use LIBVIRT_CHECK_LIB (Daniel P. Berrange) - Convert HAVE_NUMACTL to WITH_NUMACTL (Daniel P. Berrange) - Convert apparmor check to use LIBVIRT_CHECK_LIB (Daniel P. Berrange) - Convert selinux check to use LIBVIRT_CHECK_LIB (Daniel P. Berrange) - Convert HAVE_SELINUX to WITH_SELINUX (Daniel P. Berrange) - qemu: Fix grouping of capabilities strings (Peter Krempa) - network: Report real error if addition of firewall rules fails (Peter Krempa) - virsh: Reformat output of virsh net-list (Peter Krempa) - Convert audit check to use LIBVIRT_CHECK_LIB (Daniel P. Berrange) - Convert HAVE_AUDIT to WITH_AUDIT (Daniel P. Berrange) - Convert sasl check to use LIBVIRT_CHECK_LIB_ALT (Daniel P. Berrange) - Convert HAVE_SASL to WITH_SASL (Daniel P. Berrange) - Convert sanlock check to use LIBVIRT_CHECK_LIB (Daniel P. Berrange) - Convert HAVE_SANLOCK to WITH_SANLOCK (Daniel P. Berrange) - Convert yajl check to use LIBVIRT_CHECK_LIB_ALT (Daniel P. Berrange) - Convert HAVE_YAJL into WITH_YAJL (Daniel P. Berrange) - Add some autoconf helper macros for checking for libraries (Daniel P. Berrange) - build: require avahi instead of avahi-libs on rhel5. (Yufang Zhang) - util: reduce syscalls for virGetDeviceID (Eric Blake) - pass stub driver name instead of pciFindStubDriver (Chunyan Liu) - qemu: add usb-net caps flag (Guannan Ren) - qemu: add usb-serial support (Guannan Ren) - qemu: add usb-serial caps flag (Guannan Ren) - maint: distribute libvirtd.service.in (Eric Blake) - Add RESUME event listener to qemu monitor. (Andres Lagar-Cavilla) - nwfilter: Remove unprivileged code path to set base (John Ferlan) - Make TLS support conditional (Daniel P. Berrange) - qemu: Relax hard RSS limit (Michal Privoznik) - S390: Enable SCLP Console in QEMU driver (J.B. Joret) - S390: Add SCLP console front end support (J.B. Joret) - Rename lxc_protocol.x to lxc_monitor_protocol.x (Daniel P. Berrange) - Add internal APIs for dealing with namespaces (Daniel P. Berrange) - Add a way to return FDs to the RPC caller (Daniel P. Berrange) - Fix receiving of file descriptors from server (Daniel P. Berrange) - Move qemu-XXX commands from virsh-host.c to virsh-domain.c (Daniel P. Berrange) - Ensure we always setup a private mount namespace for LXC controller (Daniel P. Berrange) - Speed up fallback to legacy non-QMP probing (Daniel P. Berrange) - build: Add libxenctrl to LIBXL_LIBS (Jim Fehlig) - build: .service files don't need to be executable (Eric Blake) - build: properly substitute virtlockd.socket (Eric Blake) - build: use common .in replacement mechanism (Eric Blake) - qemu: Check if the shared disk's cdbfilter conflicts with others (Osier Yang) - qemu: set unpriv_sgio when starting domain and attaching disk (Osier Yang) - conf: Parse and format the new XML (Osier Yang) - qemu: Add a hash table for the shared disks (Osier Yang) - util: Prepare helpers for unpriv_sgio setting (Osier Yang) - snapshot: qemu: Allow redefinition of external snapshots (Peter Krempa) - snapshot: qemu: Separate logic blocks with newlines (Peter Krempa) - snapshot: conf: Make virDomainSnapshotIsExternal more reusable (Peter Krempa) - qemu: Implement virDomainOpenChannel API (John Eckersberg) - conf: Add unix socket support to virChrdevOpen (John Eckersberg) - conf: Rename console-specific identifiers to be more generic (John Eckersberg) - conf: Rename virconsole.* to virchrdev.* (John Eckersberg) - api: Add API to tunnel a guest channel via stream (John Eckersberg) - network: fix check for ambiguous lookup (Eric Blake) - Check and handle select() errors from waitsocket(). (John Ferlan) - tests: check and handle error for virAsprintf() calls (John Ferlan) - Check return on mkdir for LOCKSPACE_DIR (John Ferlan) - vmware: silence Coverity warning (John Ferlan) - Install virtlockd.{socket,service} non executable (Guido Günther) - qemu: Don't parse log output when starting up a domain (Michal Privoznik) - build: use autobuild module to make build logs nicer (Eric Blake) - maint: update to latest gnulib (Eric Blake) - sanlock: Chown lease files as well (Michal Privoznik) - python: Adapt to virevent rename (Michal Privoznik) - qemu: Convert some APIs to use qemuDomObjFromDomain (Michal Privoznik) - qemu: Relax locking in DomainHasManagedSaveImage and DomainMonitorCommand (Michal Privoznik) - S390: Re-enable capability probing for virtio devices. (Viktor Mihajlovski) - Sort util files in Makefile.am alphabetically (Daniel P. Berrange) - Rename virterror.c virterror_internal.h to virerror.{c,h} (Daniel P. Berrange) - Rename xml.{c,h} to virxml.{c,h} (Daniel P. Berrange) - Rename uuid.{c,h} to viruuid.{c,h} (Daniel P. Berrange) - Rename util.{c,h} to virutil.{c,h} (Daniel P. Berrange) - Rename threads.{c,h} to virthread.{c,h} (Daniel P. Berrange) - Rename threadpool.{c,h} to virthreadpool.{c,h} (Daniel P. Berrange) - Rename sysinfo.{c,h} to virsysinfo.{c,h} (Daniel P. Berrange) - Rename storage_file.{c,h} to virstoragefile.{c,h} (Daniel P. Berrange) - Rename stats_linux.{c,h} to virstatslinux.{c,h} (Daniel P. Berrange) - Rename sexpr.{c,h} to virsexpr.{c,h} (Daniel P. Berrange) - Merge processinfo.{c,h} into virprocess.{c,h} (Daniel P. Berrange) - Rename pci.{c,h} to virpci.{c,h} (Daniel P. Berrange) - Rename memory.{c,h} to viralloc.{c,h} (Daniel P. Berrange) - Rename logging.{c,h} to virlog.{c,h} (Daniel P. Berrange) - Rename json.{c,h} to virjson.{c,h} (Daniel P. Berrange) - Rename iptables.{c,h} to viriptables.{c,h} (Daniel P. Berrange) - Rename hostusb.{c,h} to virusb.{c,h} (Daniel P. Berrange) - Rename hooks.{c,h} to virhook.{c,h} (Daniel P. Berrange) - Rename event_poll.{c,h} to vireventpoll.{c,h} (Daniel P. Berrange) - Rename event.{c,h} to virevent.{c,h} (Daniel P. Berrange) - Rename ebtables.{c,h} to virebtables.{c,h} (Daniel P. Berrange) - Rename dnsmasq.{c,h} to virdnsmasq.{c,h} (Daniel P. Berrange) - Rename conf.{c,h} to virconf.{c,h} (Daniel P. Berrange) - Rename command.{c,h} to vircommand.{c,h} (Daniel P. Berrange) - Rename buf.{c,h} to virbuffer.{c,h} (Daniel P. Berrange) - Rename bitmap.{c,h} to virbitmap.{c,h} (Daniel P. Berrange) - Rename cgroup.{h,c} to vircgroup.{h,c} (Daniel P. Berrange) - Support all backend serial devices for pSeries guest (Li Zhang) - Remove QEMU_CAPS_NO_ACPI capability for non-x86 platform (Li Zhang) - Set std VGA model as default model for ppc64. (Li Zhang) - Add sysinfo data and enable virSysinfoRead test case for POWER (Li Zhang) - util: add missing error log messages when failing to get netlink VFINFO (Laine Stump) - security: fix #endif comment in security_stack.h (Ján Tomko) - build: use strchr now that we can work around broken gcc (Eric Blake) - Fix arch datatype in vahControl in virt-aa-helper.c (Daniel P. Berrange) - Change string form of VIR_ARCH_ITANIUM back to ia64 (Daniel P. Berrange) - conf: eliminate redundant use of VIR_ALLOC (Martin Kletzander) - Fix libxl driver for virArch changes (Daniel P. Berrange) - Fix test cases for virArch changes (Daniel P. Berrange) - Fix XenAPI driver for virArch changes (Daniel P. Berrange) - Export all symbols from virarch.{c,h} to drivers/tests/etc (Daniel P. Berrange) - Convert QEMU capabilities code to use virArch (Daniel P. Berrange) - spec: Do not install *.py[co] in python examples (Jiri Denemark) - Convert CPU APIs to use virArch (Daniel P. Berrange) - Convert capabilities / domain_conf to use virArch (Daniel P. Berrange) - Convert QEMU command line builder to virArch APIs (Daniel P. Berrange) - Convert nodeGetInfo to virArch APIs (Daniel P. Berrange) - Introduce a set of APIs for managing architectures (Daniel P. Berrange) - build: Fix AUTHORS generation (Jiri Denemark) - network: fix indentation of networkDnsmasqConfContents (Laine Stump) - .gitignore: add tests/sysinfotest (Cole Robinson) - hostusb: Move USB_DEVFS define to hostusb.h to fix the build (Cole Robinson) - daemon: Preface polkit error output with 'polkit:' (Cole Robinson) - Add support for hotplug/unplug of host misc devices in LXC (Daniel P. Berrange) - Add support for hotplug/unplug of host storage devices in LXC (Daniel P. Berrange) - Add support for hotplug/unplug of USB host devices in LXC (Daniel P. Berrange) - Add support for hotplug/unplug of NIC devices in LXC (Daniel P. Berrange) - Add support for hotplug/unplug of disk devices in LXC (Daniel P. Berrange) - Add support for attach/detach/update hostdev devices in config for LXC (Daniel P. Berrange) - Add support for attach/detach/update disk devices in config for LXC (Daniel P. Berrange) - Add support for attach/detach/update net devices in config for LXC (Daniel P. Berrange) - Add basic driver API framework for device attach/detach support in LXC (Daniel P. Berrange) - Add support for misc host device passthrough with LXC (Daniel P. Berrange) - Add support for storage host device passthrough with LXC (Daniel P. Berrange) - Add support for USB host device passthrough with LXC (Daniel P. Berrange) - Add support for disks with LXC (Daniel P. Berrange) - Add support for SELinux labelling of hostdev storage/misc devices (Daniel P. Berrange) - Refactor SELinux security driver hostdev labelling (Daniel P. Berrange) - Allow passing a vroot into security manager hostdev labelling (Daniel P. Berrange) - Skip bulk relabelling of resources in SELinux driver when used with LXC (Daniel P. Berrange) - Refactor LXC NIC creation to allow reuse by hotplug code (Daniel P. Berrange) - Add support for <hostdev mode="capabilities"> (Daniel P. Berrange) - tests: Add tests for sysinfo (Viktor Mihajlovski) - conf: cpu: Break some long lines (Peter Krempa) - conf: cpu: Refactor parsing of vendor_id and fallback attributes (Peter Krempa) - conf: cpu: Fix memory leak when specifying cpu vendor_id manually (Peter Krempa) - conf: cpu: Fix parsing of vendor_id (Ken ICHIKAWA) - Support custom 'svirt_tcg_t' context for TCG based guests (Daniel P. Berrange) - tests: add one -device video device testcase (Guannan Ren) - qemu: use newer -device video device in qemu commandline (Guannan Ren) - conf: add optional attribte primary to video <model> element (Guannan Ren) - qemu: add qemu vga devices caps and one cap to mark them usable (Guannan Ren) Cleanups: - virlog: remove old code comment (Doug Goldstein) - rpc: Revert Coverity tag message (John Ferlan) - rpc: Remove unnecessary calls (John Ferlan) - network: Remove dead code getting, but not using ipdef (John Ferlan) - esx: No need to check for objectSpec (John Ferlan) - parallels: Remove unused JSON fetch of "OS" (John Ferlan) - virsh: Remove unused setting of 'br_node' and 'if_node' (John Ferlan) - util: Remove the unused setting of 'res' for virHashLookup return (John Ferlan) - locking: Remove unnecessary setting of lockspace (John Ferlan) - maint: don't distribute generated .def files (Eric Blake) - spec: remove redundant %if (Eric Blake) - libvirt.h.in: Fix indentation (Michal Privoznik) - Fix wrong indentation for virDomainState (Claudio Bley) - tests: Remove remnants of removing the fake emulator output (John Ferlan) - phyp: Remove deadcode referencing exit_status (John Ferlan) - build: avoid compiler warning (Eric Blake) - maint: formatting cleanups in buf.c (Eric Blake) - conf: minor indentation cleanups (Martin Kletzander) So thanks a lot to everyone who helped in some ways for this release with bug reports, patches, docs, etc! Daniel -- Daniel Veillard | Open Source and Standards, Red Hat veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

2 1

[libvirt] NetworkManager git20121211
by Gene Czarcinski 01 Feb '13

01 Feb '13

I needed some functionality (dynamic dns update) not available in the NetworkManager package available in Fedora 18 so I created my own version based on git20121130. This worked nicely providing the functionality and did not appear to have any bad side effects. Then the NetworkManager git20121211 package appeared in rawhide it is usually better to use a package available from Fedora. So, I got the source rpm and rebuilt it for Fedora 18. This appeared to work fine until I realized that all of the virtual networks did not have the expected IPv4 addresses. Surprisingly, if IPv6 was defined for a network, it was there. After some investigation, I could only see that NetworkManager may be the problem. I downgraded to the git20121130 package and rebooted. The virtual networks were now OK. Any suggestions on how to report this problem? (against what and what release?) I am effectively cross-posting by sending identical messages to the NetworkManager and libvirt mailing lists. Yes, I believe the problem is with NetworkManager but there is a large libvirt impact. Gene

2 3

[libvirt] [PATCH 0/2] more work on qemu add-fd support
by Eric Blake 01 Feb '13

01 Feb '13

As promised, here's my first contribution into what is turning into a joint effort between myself and Stefan to support fd passing in qemu 1.3 and newer. Patch 2 in this series is basically a rewrite of Stefan's patch 1/4, and I tested that the capability was successfully set on qemu 1.3 and clear on qemu 1.2. I'm still wondering what we can do to the testsuite to expose more capability testing of qemu 1.2 and beyond (the existing qemuhelptest.c is hard-coded to -help scraping, which limits its usefulness; qemumonitorjsontest looks like a nice way to replay various QMP sessions, but we'd still need to figure out how to capture appropriate sessions from various qemu versions and replay them in the context of qemuhelptest). Eric Blake (1): qemu: expose qemu 1.3 add-fd monitor command Stefan Berger (1): Add support for QEMU -add-fd support detection src/qemu/qemu_capabilities.c | 22 ++++++++++++- src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_monitor.c | 74 +++++++++++++++++++++++++++++++++++++++++++- src/qemu/qemu_monitor.h | 9 +++--- src/qemu/qemu_monitor_json.c | 73 ++++++++++++++++++++++++++++++++++++++++++- src/qemu/qemu_monitor_json.h | 5 ++- 6 files changed, 176 insertions(+), 8 deletions(-) -- 1.8.1

4 8

[libvirt] [Libvirt]Install Libvirt errors
by harryxiyou 01 Feb '13

01 Feb '13

Hi all, I did following steps to install Libvirt. 1, git clone git://libvirt.org/libvirt.git 2, cd libvirt 3, ./autogen.sh 4, ./configure 5, make 6, sudo make install Therefore, after step 6, "sudo make install", i happened to some errors, which you can find these errors by clicking following link. http://paste.ubuntu.com/1589924/ Could anyone give me some suggestions? Thanks in advance ;-) -- Thanks Harry Wei

3 5

[libvirt] [PATCH] tests: add a comment about our fake qmp
by Eric Blake 01 Feb '13

01 Feb '13

While testing QMP, I used a simple qemu session of 'qemu-kvm -M none -nodefaults -nographic -qmp stdio' for some experiments. But it took me far too long to remember the magic invocation to unlock QMP into accepting normal commands. While I was able to grep libvirt sources and easily find where libvirt expects the normal "QMP" greeting, I could not find the proper reply to that greeting nearby. Reading the testsuite didn't help either, since there we don't emulate the mandatory handshake. But since my grep hit the testsuite, adding a bit of documentation will make it much easier to jog my memory in the future. * tests/qemumonitortestutils.c (QEMU_JSON_GREETING): Mention that the normal counterpart reply is skipped. --- tests/qemumonitortestutils.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/qemumonitortestutils.c b/tests/qemumonitortestutils.c index d1b2ab5..7b90c38 100644 --- a/tests/qemumonitortestutils.c +++ b/tests/qemumonitortestutils.c @@ -1,5 +1,5 @@ /* - * Copyright (C) 2011-2012 Red Hat, Inc. + * Copyright (C) 2011-2013 Red Hat, Inc. * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -439,6 +439,8 @@ static qemuMonitorCallbacks qemuCallbacks = { }; #define QEMU_JSON_GREETING "{\"QMP\": {\"version\": {\"qemu\": {\"micro\": 1, \"minor\": 0, \"major\": 1}, \"package\": \" (qemu-kvm-1.0.1)\"}, \"capabilities\": []}}" +/* We skip the normal handshake reply of "{\"execute\":\"qmp_capabilities\"}" */ + #define QEMU_TEXT_GREETING "QEMU 1.0,1 monitor - type 'help' for more information" qemuMonitorTestPtr qemuMonitorTestNew(bool json, virCapsPtr caps) -- 1.8.1

2 2

[libvirt] [PATCH] spec: Avoid using makeinstall relic
by Jiri Denemark 01 Feb '13

01 Feb '13

The macro was made to help installing broken packages that did not use DESTDIR correctly by overriding individual path variables (prefix, sysconfdir, ...). Newer rpm provides fixed make_install macro that calls make install with just the correct DESTDIR, however it is not available everywhere (e.g., RHEL 5 does not have it). On the other hand the make_install macro is simple and straightforward enough for us to use its expansion directly. --- libvirt.spec.in | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 87253c6..8df908d 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1336,7 +1336,11 @@ gzip -9 ChangeLog %install rm -fr %{buildroot} -%makeinstall SYSTEMD_UNIT_DIR=%{buildroot}%{_unitdir} +# Avoid using makeinstall macro as it changes prefixes rather than setting +# DESTDIR. Newer make_install macro would be better but it's not available +# on RHEL 5, thus we need to expand it here. +make install DESTDIR=%{?buildroot} SYSTEMD_UNIT_DIR=%{_unitdir} + for i in domain-events/events-c dominfo domsuspend hellolibvirt openauth python xml/nwfilter systemtap do (cd examples/$i ; make clean ; rm -rf .deps .libs Makefile Makefile.in) -- 1.8.1.2

2 2