December 2011 - Devel - libvirt List Archives

[libvirt] [PATCH] qemuhelptest: Add new qemuCap flag
by Michal Privoznik 22 Dec '11

22 Dec '11

Latest patch a1a83c587443 introduces new qemu capability flag QEMU_CAPS_FSDEV_READONLY. However, it was missing in qemuhelptest making test for qemu-1.0 fail. --- Pushing under build-breaker rule. tests/qemuhelptest.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/tests/qemuhelptest.c b/tests/qemuhelptest.c index f31c903..60155e7 100644 --- a/tests/qemuhelptest.c +++ b/tests/qemuhelptest.c @@ -647,7 +647,8 @@ mymain(void) QEMU_CAPS_NO_SHUTDOWN, QEMU_CAPS_PCI_ROMBAR, QEMU_CAPS_ICH9_AHCI, - QEMU_CAPS_NO_ACPI); + QEMU_CAPS_NO_ACPI, + QEMU_CAPS_FSDEV_READONLY); return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -- 1.7.3.4

2 1

[libvirt] [PATCH] Add new attribute writeout to <filesystem> element
by Deepak C Shetty 22 Dec '11

22 Dec '11

This introduces new attribute writeout with only supported value as immediate. This will be an optional attribute with no defaults. This helps specify whether to skip the host page cache. When writeout is specified, meaning when writeout=immediate a writeback is explicitly initiated for the dirty pages in the host page cache as part of the guest file write operation. Usage: <filesystem type='mount' accessmode='passthrough' writeout='immediate'> <source dir='/export/to/guest'/> <target dir='mount_tag'/> </filesystem> Currently this only works with type='mount' for the QEMU/KVM driver. Signed-off-by: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com> --- docs/formatdomain.html.in | 8 +++++++- docs/schemas/domaincommon.rng | 5 +++++ src/conf/domain_conf.c | 29 +++++++++++++++++++++++++++-- src/conf/domain_conf.h | 10 ++++++++++ src/qemu/qemu_command.c | 9 +++++++++ 5 files changed, 58 insertions(+), 3 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index c57b7b3..803db8e 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -1303,7 +1303,7 @@ <source name='my-vm-template'/> <target dir='/'/> </filesystem> - <filesystem type='mount' accessmode='passthrough'> + <filesystem type='mount' accessmode='passthrough' writeout='immediate'> <driver type='path'/> <source dir='/export/to/guest'/> <target dir='/import/from/host'/> @@ -1379,6 +1379,12 @@ </dd> </dl> + The filesystem block has an optional attribute <code>writeout='immediate'</code> + to help specify whether to skip the host page cache. When writeout is specified, meaning when + writeout=immediate a writeback is explicitly initiated for the dirty pages in + the host page cache as part of the guest file write operation. When this attribute is not + specified, there are no defaults, meaning explicit writeback won't be initiated. + </dd> <dt><code>source</code></dt> diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng index 27ec1da..2298994 100644 --- a/docs/schemas/domaincommon.rng +++ b/docs/schemas/domaincommon.rng @@ -1106,6 +1106,11 @@ <value>squash</value> </choice> </attribute> + <attribute name="writeout"> + <choice> + <value>immediate</value> + </choice> + </attribute> </optional> </element> </define> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 2c91f82..80b8eab 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -256,6 +256,9 @@ VIR_ENUM_IMPL(virDomainFSAccessMode, VIR_DOMAIN_FS_ACCESSMODE_LAST, "mapped", "squash") +VIR_ENUM_IMPL(virDomainFSWriteout, VIR_DOMAIN_FS_WRITEOUT_LAST, + "default", + "immediate") VIR_ENUM_IMPL(virDomainNet, VIR_DOMAIN_NET_TYPE_LAST, "user", @@ -3258,6 +3261,7 @@ virDomainFSDefParseXML(xmlNodePtr node, char *source = NULL; char *target = NULL; char *accessmode = NULL; + char *writeout = NULL; if (VIR_ALLOC(def) < 0) { virReportOOMError(); @@ -3286,6 +3290,17 @@ virDomainFSDefParseXML(xmlNodePtr node, def->accessmode = VIR_DOMAIN_FS_ACCESSMODE_PASSTHROUGH; } + writeout = virXMLPropString(node, "writeout"); + if (writeout) { + if ((def->writeout = virDomainFSWriteoutTypeFromString(writeout)) < 0) { + virDomainReportError(VIR_ERR_INTERNAL_ERROR, + _("unknown filesystem writeout '%s'"), writeout); + goto error; + } + } else { + def->writeout = VIR_DOMAIN_FS_WRITEOUT_DEFAULT; + } + cur = node->children; while (cur != NULL) { if (cur->type == XML_ELEMENT_NODE) { @@ -3348,6 +3363,7 @@ cleanup: VIR_FREE(target); VIR_FREE(source); VIR_FREE(accessmode); + VIR_FREE(writeout); return def; @@ -10006,6 +10022,7 @@ virDomainFSDefFormat(virBufferPtr buf, const char *type = virDomainFSTypeToString(def->type); const char *accessmode = virDomainFSAccessModeTypeToString(def->accessmode); const char *fsdriver = virDomainFSDriverTypeTypeToString(def->fsdriver); + const char *writeout = virDomainFSWriteoutTypeToString(def->writeout); if (!type) { virDomainReportError(VIR_ERR_INTERNAL_ERROR, @@ -10022,12 +10039,20 @@ virDomainFSDefFormat(virBufferPtr buf, if (def->fsdriver == VIR_DOMAIN_FS_DRIVER_TYPE_PATH || def->fsdriver == VIR_DOMAIN_FS_DRIVER_TYPE_DEFAULT) { virBufferAsprintf(buf, - " <filesystem type='%s' accessmode='%s'>\n", + " <filesystem type='%s' accessmode='%s'", type, accessmode); } else { virBufferAsprintf(buf, - " <filesystem type='%s'>\n", type); + " <filesystem type='%s'", type); } + + /* Dont generate anything if writeout is set to default */ + if (def->writeout) { + virBufferAsprintf(buf, " writeout='%s'", writeout); + } + + /* close the filesystem element */ + virBufferAddLit(buf,">\n"); if (def->fsdriver) { virBufferAsprintf(buf, " <driver type='%s'/>\n", fsdriver); diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 3229a6f..bf4d79b 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -450,12 +450,21 @@ enum virDomainFSAccessMode { VIR_DOMAIN_FS_ACCESSMODE_LAST }; +/* Filesystem Writeout */ +enum virDomainFSWriteout { + VIR_DOMAIN_FS_WRITEOUT_DEFAULT = 0, + VIR_DOMAIN_FS_WRITEOUT_IMMEDIATE, + + VIR_DOMAIN_FS_WRITEOUT_LAST +}; + typedef struct _virDomainFSDef virDomainFSDef; typedef virDomainFSDef *virDomainFSDefPtr; struct _virDomainFSDef { int type; int fsdriver; int accessmode; + int writeout; char *src; char *dst; unsigned int readonly : 1; @@ -1973,6 +1982,7 @@ VIR_ENUM_DECL(virDomainControllerModelUSB) VIR_ENUM_DECL(virDomainFS) VIR_ENUM_DECL(virDomainFSDriverType) VIR_ENUM_DECL(virDomainFSAccessMode) +VIR_ENUM_DECL(virDomainFSWriteout) VIR_ENUM_DECL(virDomainNet) VIR_ENUM_DECL(virDomainNetBackend) VIR_ENUM_DECL(virDomainNetVirtioTxMode) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 1f70eb1..ccfd092 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -108,6 +108,10 @@ VIR_ENUM_IMPL(qemuDomainFSDriver, VIR_DOMAIN_FS_DRIVER_TYPE_LAST, "local", "handle"); +VIR_ENUM_DECL(qemuDomainFSWriteout) +VIR_ENUM_IMPL(qemuDomainFSWriteout, VIR_DOMAIN_FS_WRITEOUT_LAST, + "default", + "immediate"); static void uname_normalize (struct utsname *ut) @@ -1990,6 +1994,7 @@ char *qemuBuildFSStr(virDomainFSDefPtr fs, { virBuffer opt = VIR_BUFFER_INITIALIZER; const char *driver = qemuDomainFSDriverTypeToString(fs->fsdriver); + const char *writeout = qemuDomainFSWriteoutTypeToString(fs->writeout); if (fs->type != VIR_DOMAIN_FS_TYPE_MOUNT) { qemuReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", @@ -2014,6 +2019,10 @@ char *qemuBuildFSStr(virDomainFSDefPtr fs, virBufferAddLit(&opt, ",security_model=none"); } } + + if (fs->writeout != VIR_DOMAIN_FS_WRITEOUT_DEFAULT) { + virBufferAsprintf(&opt, ",writeout=%s", writeout); + } virBufferAsprintf(&opt, ",id=%s%s", QEMU_FSDEV_HOST_PREFIX, fs->info.alias); virBufferAsprintf(&opt, ",path=%s", fs->src);

3 5

[libvirt] question of kvm
by hero 22 Dec '11

22 Dec '11

I want to back up my VM including my own data, but the VM must be 'PASUED' or 'SHUT OFF' if I use 'virt-clone', I want to know how to back up my VM when it's running like make a ghost of windows. Thansk! SunYongGang

2 1

[libvirt] [PATCH 0/4] virsh: Make more commands cancelable via ^C
by Michal Privoznik 22 Dec '11

22 Dec '11

Currently, only migration command allows job progress reporting and cancel via SIGINT. However, there are more job oriented commands which take long time to finish and user might want to cancel them like he can do in migration. Such commands are: dump, save, managedsave. Michal Privoznik (4): virsh: Move job watch code to a separate function virsh: Use do_job_watch in cmdDump virsh: Use do_job_watch in cmdSave virsh: Use do_job_watch in cmdManagedSave tools/virsh.c | 425 +++++++++++++++++++++++++++++++++++++++++-------------- tools/virsh.pod | 24 ++-- 2 files changed, 330 insertions(+), 119 deletions(-) -- 1.7.3.4

2 10

[libvirt] [libvirt-glib 1/2] Add python example for LibvirtGConfig
by Christophe Fergeau 22 Dec '11

22 Dec '11

--- examples/config-test.py | 96 +++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 96 insertions(+), 0 deletions(-) create mode 100644 examples/config-test.py diff --git a/examples/config-test.py b/examples/config-test.py new file mode 100644 index 0000000..92e8a89 --- /dev/null +++ b/examples/config-test.py @@ -0,0 +1,96 @@ +#!/usr/bin/python + +from gi.repository import LibvirtGConfig; + +domain = LibvirtGConfig.Domain.new() +domain.set_name("foo") +domain.set_memory(1024*1024*1024) +domain.set_vcpus(2) +domain.set_lifecycle(LibvirtGConfig.DomainLifecycleEvent.ON_POWEROFF, + LibvirtGConfig.DomainLifecycleAction.DESTROY) + +clock = LibvirtGConfig.DomainClock.new() +clock.set_offset(LibvirtGConfig.DomainClockOffset.UTC) +domain.set_clock(clock) + +os = LibvirtGConfig.DomainOs.new() +os.set_os_type(LibvirtGConfig.DomainOsType.HVM) +os.set_arch("x86_64") +devices = [ LibvirtGConfig.DomainOsBootDevice.CDROM, + LibvirtGConfig.DomainOsBootDevice.NETWORK ] +os.set_boot_devices(devices) +domain.set_os(os) + +disk = LibvirtGConfig.DomainDisk.new() +disk.set_type(LibvirtGConfig.DomainDiskType.FILE) +disk.set_guest_device_type(LibvirtGConfig.DomainDiskGuestDeviceType.DISK) +disk.set_source("/tmp/foo/bar") +disk.set_driver_name("qemu") +disk.set_driver_type("qcow2") +disk.set_target_bus(LibvirtGConfig.DomainDiskBus.IDE) +disk.set_target_dev("hda") +domain.add_device(disk) + +interface = LibvirtGConfig.DomainInterfaceNetwork.new() +interface.set_source("default") +domain.add_device(interface) + +interface = LibvirtGConfig.DomainInterfaceUser.new() +interface.set_ifname("eth0") +interface.set_link_state(LibvirtGConfig.DomainInterfaceLinkState.UP) +interface.set_mac("00:11:22:33:44:55") +interface.set_model("foo") +domain.add_device(interface) + +input = LibvirtGConfig.DomainInput.new() +input.set_device_type(LibvirtGConfig.DomainInputDeviceType.TABLET) +input.set_bus(LibvirtGConfig.DomainInputBus.USB) +domain.add_device(input) + +graphics = LibvirtGConfig.DomainGraphicsSpice.new() +graphics.set_port(1234) +domain.add_device(graphics) + +video = LibvirtGConfig.DomainVideo.new() +video.set_model(LibvirtGConfig.DomainVideoModel.QXL) +domain.add_device(video) + +console = LibvirtGConfig.DomainConsole.new() +pty = LibvirtGConfig.DomainChardevSourcePty.new() +console.set_source(pty) +domain.add_device(console) + +print domain.to_xml() + + +pool = LibvirtGConfig.StoragePool.new() +pool.set_pool_type(LibvirtGConfig.StoragePoolType.DIR) + +pool_source = LibvirtGConfig.StoragePoolSource.new() +pool_source.set_directory("/foo/bar") +pool.set_source(pool_source) + +perms = LibvirtGConfig.StoragePermissions.new() +perms.set_owner(1001) +perms.set_group(1005) +perms.set_mode(0744) +perms.set_label("virt_image_t") + +pool_target = LibvirtGConfig.StoragePoolTarget.new() +pool_target.set_path("/dev/disk/by-path") +pool_target.set_permissions(perms) +pool.set_target(pool_target) + +print pool.to_xml() + + +vol = LibvirtGConfig.StorageVol.new() +vol.set_name("my-vol") +vol.set_capacity(0xdeadbeef) + +vol_target = LibvirtGConfig.StorageVolTarget.new() +vol_target.set_format("qcow2") +vol_target.set_permissions(perms) +vol.set_target(vol_target) + +print vol.to_xml() -- 1.7.7.4

2 4

[libvirt] [PATCH] qemu: Support readonly filesystem passthrough
by Osier Yang 22 Dec '11

22 Dec '11

Upstream QEMU starts to support it from commit 2c74c2cb. --- docs/formatdomain.html.in | 5 +++-- src/qemu/qemu_capabilities.c | 7 ++++++- src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 11 +++++++++++ 4 files changed, 21 insertions(+), 3 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index c57b7b3..9cf0f12 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -1399,8 +1399,9 @@ <dt><code>readonly</code></dt> <dd> - An optional <code>readonly</code> attribute is available but currently - unused. + Enables exporting filesytem as a readonly mount for guest, by + default read-write access is given (currently only works for + QEMU/KVM driver). </dd> </dl> diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index de2bc13..43c7578 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -143,6 +143,7 @@ VIR_ENUM_IMPL(qemuCaps, QEMU_CAPS_LAST, "rombar", "ich9-ahci", "no-acpi", + "fsdev-readonly", ); struct qemu_feature_flags { @@ -981,6 +982,7 @@ qemuCapsComputeCmdFlags(const char *help, virBitmapPtr flags) { const char *p; + const char *fsdev; if (strstr(help, "-no-kqemu")) qemuCapsSet(flags, QEMU_CAPS_KQEMU); @@ -1077,8 +1079,11 @@ qemuCapsComputeCmdFlags(const char *help, qemuCapsSet(flags, QEMU_CAPS_NESTING); if (strstr(help, ",menu=on")) qemuCapsSet(flags, QEMU_CAPS_BOOT_MENU); - if (strstr(help, "-fsdev")) + if ((fsdev = strstr(help, "-fsdev"))) { qemuCapsSet(flags, QEMU_CAPS_FSDEV); + if (strstr(fsdev, "readonly")) + qemuCapsSet(flags, QEMU_CAPS_FSDEV_READONLY); + } if (strstr(help, "-smbios type")) qemuCapsSet(flags, QEMU_CAPS_SMBIOS_TYPE); diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h index 08d8457..c759baf 100644 --- a/src/qemu/qemu_capabilities.h +++ b/src/qemu/qemu_capabilities.h @@ -116,6 +116,7 @@ enum qemuCapsFlags { QEMU_CAPS_PCI_ROMBAR = 76, /* -device rombar=0|1 */ QEMU_CAPS_ICH9_AHCI = 77, /* -device ich9-ahci */ QEMU_CAPS_NO_ACPI = 78, /* -no-acpi */ + QEMU_CAPS_FSDEV_READONLY =79, /* -fsdev readonly supported */ QEMU_CAPS_LAST, /* this must always be the last item */ }; diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 9d3bc23..ea1b763 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -2108,6 +2108,17 @@ char *qemuBuildFSStr(virDomainFSDefPtr fs, virBufferAsprintf(&opt, ",id=%s%s", QEMU_FSDEV_HOST_PREFIX, fs->info.alias); virBufferAsprintf(&opt, ",path=%s", fs->src); + if (fs->readonly) { + if (qemuCapsGet(qemuCaps, QEMU_CAPS_FSDEV_READONLY)) { + virBufferAddLit(&opt, ",readonly"); + } else { + qemuReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("readonly filesystem is not supported by this " + "QEMU binary")); + goto error; + } + } + if (virBufferError(&opt)) { virReportOOMError(); goto error; -- 1.7.7.3

2 2

[libvirt] question on kvm
by hero 22 Dec '11

22 Dec '11

on redhat5.6 and redhat 6.1, I can got the MAC address of the kvm VMs,but I don't know how to get the ip address of the VMs,and virsh has not got a command,can you help me to resolve it.

2 1

[libvirt] [PATCH] nwfilter: Do not require DHCP requests to be broadcast
by Stefan Berger 21 Dec '11

21 Dec '11

Remove the requirement that DHCP messages have to be broadcasted. --- src/nwfilter/nwfilter_ebiptables_driver.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Index: libvirt-acl/src/nwfilter/nwfilter_ebiptables_driver.c =================================================================== --- libvirt-acl.orig/src/nwfilter/nwfilter_ebiptables_driver.c +++ libvirt-acl/src/nwfilter/nwfilter_ebiptables_driver.c @@ -3245,9 +3245,8 @@ ebtablesApplyDHCPOnlyRules(const char *i virBufferAsprintf(&buf, CMD_DEF("$EBT -t nat -A %s" - " -s %s -d Broadcast " + " -s %s" " -p ipv4 --ip-protocol udp" - " --ip-src 0.0.0.0 --ip-dst 255.255.255.255" " --ip-sport 68 --ip-dport 67" " -j ACCEPT") CMD_SEPARATOR CMD_EXEC

2 2

[libvirt] [PATCH 0/4] RFC: grant KVM guests retain arbitrary capabilities
by Taku Izumi 21 Dec '11

21 Dec '11

Hi all, This patchset adds an option for KVM guests to retain arbitrary capabilities. I want KVM guests to retain "cap_sys_rawio" capability, so I tried to run qemu as root user. However because libvirt clears all capability of KVM guest by default, even if guest is running as root user, it doesn't have any capability. I can fulfill my requirement by disabling "clear_emulator_capabilities" option, but it's not good idea considering security risk. I'm happy libvirt could clear unnecessary capabilities instead of clearing all. That is a motivator for creating this patch. By adding "domain_capabilities" element and to domain XML, its domain can retain specified capabilities like the following: ; VM can retain cap_sys_rawio capability # virsh edit VM ... </features> <domain_capabilities> <cap_sys_rawio/> </domain_capabilities> <clock offset='utc'/> ... # virsh start VM # cat /proc/<VM's PID/status ... CapInh: 0000000000000000 CapPrm: fffffffc00020000 CapEff: fffffffc00020000 CapBnd: fffffffc00020000 ... *[PATCH 1/4] conf: add XML schema for domain capabilities *[PATCH 2/4] util: add functions to keep capabilities *[PATCH 3/4] util: extend virExecWithHook() *[PATCH 4/4] qemu: make qemu processes to retain capabilities -- Best regards, Taku Izumi <izumi.taku(a)jp.fujitsu.com>

2 7

[libvirt] [PATCH 1/4] Make drive unit attribute optional in the XML schema
by Michael Ellerman 21 Dec '11

21 Dec '11

The "unit" attribute of a drive address is optional in the code, so should also be in the XML schema. Signed-off-by: Michael Ellerman <michael(a)ellerman.id.au> --- docs/schemas/domaincommon.rng | 8 +++++--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng index 553a6f0..f35eb0b 100644 --- a/docs/schemas/domaincommon.rng +++ b/docs/schemas/domaincommon.rng @@ -2241,9 +2241,11 @@ <ref name="driveBus"/> </attribute> </optional> - <attribute name="unit"> - <ref name="driveUnit"/> - </attribute> + <optional> + <attribute name="unit"> + <ref name="driveUnit"/> + </attribute> + </optional> </define> <define name="virtioserialaddress"> <attribute name="controller"> -- 1.7.7.3

1 4