October 2011 - Devel - libvirt List Archives

[libvirt] [PATCH] qemu: plug memory leak
by ajia＠redhat.com 01 Nov '11

01 Nov '11

From: Alex Jia <ajia(a)redhat.com> Detected by Coverity. Leak introduced in commit 6cabc0b. * src/qemu/qemu_command.c: Clean up on failure. Signed-off-by: Alex Jia <ajia(a)redhat.com> --- src/qemu/qemu_command.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 0936492..02958cb 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -4995,6 +4995,7 @@ qemuBuildCommandLine(virConnectPtr conn, } if (sound->model == VIR_DOMAIN_SOUND_MODEL_ICH6) { + VIR_FREE(modstr); qemuReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", _("this QEMU binary lacks hda support")); goto error; -- 1.7.1

3 4

[libvirt] [PATCH 0/2] V2 Modify generic ethernet interface so it will work when sVirt is enabled with qemu
by Tyler Coumbes 01 Nov '11

01 Nov '11

Version 2 of https://www.redhat.com/archives/libvir-list/2011-September/msg00795.html. Instead of creating a new library for the TAP functions and refactoring code to there I have only refactored the actual TAP creation in util/bridge.c. This simplifies the patch and achieves the same goal. AUTHORS | 1 + src/libvirt_bridge.syms | 2 + src/qemu/qemu_command.c | 79 ++++++++++++++++++++++++++++++-- src/qemu/qemu_command.h | 4 ++ src/qemu/qemu_hotplug.c | 15 ++++++ src/qemu/qemu_process.c | 13 +++++ src/util/bridge.c | 116 +++++++++++++++++++++++++++++++---------------- src/util/bridge.h | 9 ++++ 8 files changed, 196 insertions(+), 43 deletions(-)

2 7

[libvirt] [PATCH v4 0/2] add blkio.weight_device support
by Hu Tao 01 Nov '11

01 Nov '11

This series adds support for blkio.weight_device. changes from v3: - fix some memory leaks - don't store major/minor, do the convertion from device path to major/minor only when enforcing the weight_device limits - use virStrToLong_i instead of atoi - use c_isdigit instead of isdigit - fix some typos Hu Tao (2): Add VIR_TYPED_PARAM_STRING add interface for blkio.weight_device daemon/remote.c | 34 +++++++- include/libvirt/libvirt.h.in | 34 +++++++- src/conf/domain_conf.c | 129 ++++++++++++++++++++++++++- src/conf/domain_conf.h | 16 ++++ src/libvirt.c | 38 ++++++++ src/libvirt_private.syms | 2 + src/qemu/qemu_cgroup.c | 22 +++++ src/qemu/qemu_driver.c | 199 +++++++++++++++++++++++++++++++++++++++-- src/remote/remote_driver.c | 30 ++++++- src/remote/remote_protocol.x | 2 + src/remote_protocol-structs | 2 + src/rpc/gendispatch.pl | 2 +- src/util/cgroup.c | 33 +++++++ src/util/cgroup.h | 3 + src/util/util.c | 15 +++ src/util/util.h | 2 + tools/virsh.c | 69 +++++++++++++-- tools/virsh.pod | 5 +- 18 files changed, 608 insertions(+), 29 deletions(-) -- 1.7.3.1

4 9

Re: [libvirt] [RFC PATCH v3 3/4] qemu: pass virConnectPtr into Domain{Attach, Detach}*
by Daniel P. Berrange 01 Nov '11

01 Nov '11

On Thu, Oct 20, 2011 at 11:01:26AM -0700, Josh Durgin wrote: > From: Sage Weil <sage(a)newdream.net> > > The qemu RBD driver needs access to the conn in order to get the secret > needed for connecting to the ceph cluster. > > Signed-off-by: Sage Weil <sage(a)newdream.net> > --- > src/qemu/qemu_command.c | 5 +++-- > src/qemu/qemu_command.h | 3 ++- > src/qemu/qemu_driver.c | 17 ++++++++--------- > src/qemu/qemu_hotplug.c | 15 +++++++++------ > src/qemu/qemu_hotplug.h | 9 ++++++--- > 5 files changed, 28 insertions(+), 21 deletions(-) Trivial, ACK Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|

2 1

[libvirt] [PATCH] doc: Correct the default werror policy
by Osier Yang 01 Nov '11

01 Nov '11

<quote> @item werror=@var{action},rerror=@var{action} Specify which @var{action} to take on write and read errors. Valid actions are: "ignore" (ignore the error and try to continue), "stop" (pause QEMU), "report" (report the error to the guest), "enospc" (pause QEMU only if the host disk is full; report the error to the guest otherwise). The default setting is @option{werror=enospc} and @option{rerror=report}. @item readonly </quote> libvirt doesn't set any default value for "(r)error_policy", the original doc should mean QEMU sets "report" as the default value for "werror", but it's not true, QEMU uses "enospc" as the default. And it's better to document "(r)error_policy" are only supported by QEMU. --- docs/formatdomain.html.in | 20 +++++++++----------- 1 files changed, 9 insertions(+), 11 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index dc6b152..e98e709 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -1011,19 +1011,17 @@ The optional <code>error_policy</code> attribute controls how the hypervisor will behave on a disk read or write error, possible values are "stop", "report", "ignore", and - "enospace".Since 0.8.0, "report" since - 0.9.7 The default setting of error_policy is "report". - There is also an - optional <code>rerror_policy</code> that controls behavior - for read errors only. Since - 0.9.7. If no rerror_policy is given, error_policy - is used for both read and write errors. If rerror_policy - is given, it overrides the <code>error_policy</code> for - read errors. Also note that "enospace" is not a valid + "enospace".Since 0.8.0 (QEMU and KVM only), + "report" since 0.9.7. QEMU sets error_policy as "enospc" + by default. There is also an optional <code>rerror_policy</code> + that controls behavior for read errors only. + Since 0.9.7 (QEMU and KVM only). If no rerror_policy is + given, error_policy is used for both read and write errors. If + rerror_policy is given, it overrides the <code>error_policy</code> + for read errors. Also note that "enospace" is not a valid policy for read errors, so if <code>error_policy</code> is set to "enospace" and no <code>rerror_policy</code> is - given, the read error policy will be left at its default, - which is "report". + given, QEMU will set the read error policy as "report" by default. </li> <li> The optional <code>io</code> attribute controls specific -- 1.7.6

3 3

[libvirt] building failed
by Wen Congyang 01 Nov '11

01 Nov '11

When I try to build libvirt, I meet the following error messages: ============================== Generating internals/rpc.html.tmp Validating internals/rpc.html GEN libvirt-api.xml GEN html/index.html GEN devhelp/libvirt.devhelp convert -rotate 90 libvirt-net-logical.fig libvirt-net-logical.png make[1]: convert: Command not found make[1]: *** [libvirt-net-logical.png] Error 127 ============================== The command convert does not exist. Which package should I install? PS: I find another command fig2dev can convert *.fig to *.png. Thanks Wen Congyang

5 9

[libvirt] [PATCH] Fix URI alias prefix matching
by Wen Ruo Lv (none) 01 Nov '11

01 Nov '11

From: lvroyce <lvroyce(a)lvroyce-ThinkPad-T420.(none)> URI alias always do prefix matching,because we count length of entry according to config file entry, which should be the given alias' length. e.g.: /etc/libvirt/libvirt.conf uri_aliases = [ "hail=qemu:///system", "sleet=qemu+ssh://root@9.115.122.57/system", "sam=qemu+unix:///system?socket=/var/run/libvirt/libvirt-sock", ] when issue "virsh -c hailly" it will match "hail=qemu:///system" Signed-off-by: Wen Ruo Lv <lvroyce(a)lvroyce-ThinkPad-T420.(none)> --- src/libvirt.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index e9d1a29..54e283f 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -1022,7 +1022,7 @@ virConnectOpenFindURIAliasMatch(virConfValuePtr value, const char *alias, char * return -1; } - if (STREQLEN(entry->str, alias, offset-entry->str)) { + if (STREQLEN(entry->str, alias, strlen(alias))) { VIR_DEBUG("Resolved alias '%s' to '%s'", alias, offset+1); if (!(*uri = strdup(offset+1))) { -- 1.7.4.1

2 1

[libvirt] [PATCH] python: Fix documentation of virStream recv
by Matthias Bolte 01 Nov '11

01 Nov '11

This was fixed in be757a3f7baf93b for libvirt.c. --- I'm pushing this one under the trivial rule. python/libvirt-override-virStream.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/python/libvirt-override-virStream.py b/python/libvirt-override-virStream.py index 92e6fb1..ff53a16 100644 --- a/python/libvirt-override-virStream.py +++ b/python/libvirt-override-virStream.py @@ -90,7 +90,7 @@ "nonblocking stream") def recv(self, nbytes): - """Write a series of bytes to the stream. This method may + """Reads a series of bytes from the stream. This method may block the calling application for an arbitrary amount of time. -- 1.7.4.1

1 0

[libvirt] [PATCH] startupPolicty: Minor cleanups
by Michal Privoznik 31 Oct '11

31 Oct '11

This patch does some cleanups to my previous startupPolicy patchset. --- daemon/remote.c | 2 ++ src/conf/domain_conf.c | 2 +- src/qemu/qemu_domain.c | 20 +++++++++----------- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/daemon/remote.c b/daemon/remote.c index 9d70163..f736e5f 100644 --- a/daemon/remote.c +++ b/daemon/remote.c @@ -496,6 +496,8 @@ static int remoteRelayDomainEventDiskChange(virConnectPtr conn ATTRIBUTE_UNUSED, return 0; mem_error: + VIR_FREE(oldSrcPath_p); + VIR_FREE(newSrcPath_p); virReportOOMError(); return -1; } diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 557d0b9..8f72d37 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -2657,7 +2657,7 @@ virDomainDiskDefParseXML(virCapsPtr caps, if (startupPolicy) { int i; - if ((i = virDomainStartupPolicyTypeFromString(startupPolicy)) < 0) { + if ((i = virDomainStartupPolicyTypeFromString(startupPolicy)) <= 0) { virDomainReportError(VIR_ERR_CONFIG_UNSUPPORTED, _("unknown startupPolicy value '%s'"), startupPolicy); diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 198ebcc..572ea7d 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -1617,9 +1617,8 @@ qemuDomainCheckDiskPresence(struct qemud_driver *driver, { int ret = -1; int i; - int accessRet; virDomainDiskDefPtr disk; - char uuid[VIR_UUID_STRING_BUFLEN] ATTRIBUTE_UNUSED; + char uuid[VIR_UUID_STRING_BUFLEN]; virDomainEventPtr event = NULL; virUUIDFormat(vm->def->uuid, uuid); @@ -1630,11 +1629,10 @@ qemuDomainCheckDiskPresence(struct qemud_driver *driver, if (!disk->startupPolicy || !disk->src) continue; - if ((accessRet = virFileAccessibleAs(disk->src, F_OK, - driver->user, - driver->group)) >= 0) { - /* disk accessible or virFileAccessibleAs() - * terminated with signal*/ + if (virFileAccessibleAs(disk->src, F_OK, + driver->user, + driver->group) >= 0) { + /* disk accessible */ continue; } @@ -1643,7 +1641,7 @@ qemuDomainCheckDiskPresence(struct qemud_driver *driver, break; case VIR_DOMAIN_STARTUP_POLICY_MANDATORY: - virReportSystemError(-accessRet, + virReportSystemError(errno, _("cannot access file '%s'"), disk->src); goto cleanup; @@ -1651,7 +1649,7 @@ qemuDomainCheckDiskPresence(struct qemud_driver *driver, case VIR_DOMAIN_STARTUP_POLICY_REQUISITE: if (!start_with_state) { - virReportSystemError(-accessRet, + virReportSystemError(errno, _("cannot access file '%s'"), disk->src); goto cleanup; @@ -1664,8 +1662,8 @@ qemuDomainCheckDiskPresence(struct qemud_driver *driver, break; } - VIR_DEBUG("Droping disk '%s' on domain '%s' (UUID '%s') " - "due to not accessible source '%s'", + VIR_DEBUG("Dropping disk '%s' on domain '%s' (UUID '%s') " + "due to inaccessible source '%s'", disk->dst, vm->def->name, uuid, disk->src); event = virDomainEventDiskChangeNewFromObj(vm, disk->src, NULL, disk->info.alias, -- 1.7.3.4

2 2

[libvirt] [PATCH V4 0/4] Support for multiple IP addresses using lists
by Stefan Berger 31 Oct '11

31 Oct '11

This patch series builds on the previously posted patch series https://www.redhat.com/archives/libvir-list/2011-October/msg00912.html and introduces the capability to assign a list to a variable and have multiple rules instantiated, one for each item in the list. This means, that if for example a variable like IP has been assigned a list of values IP = [1.2.3.4, 5.6.7.8, 10.0.0.1] it will instantiate 3 rules, which in turn allows us to build filters that can evaluate multiple possible values per field, i.e., allow the filtering for multiple IP addresses (per interface). It would then need David Steven's patch for support of 'RETURN' (and 'CONTINUE') target(s). v4: - following Daniel Berrange's comments - changed (default) behavior of iterator v3: - following Daniel Berrange's comment regarding how a list of items should be represented in the XML v2: - reimplementation of iterator - other nits Regards, Stefan

2 12