March 2009 - Devel - libvirt List Archives

[libvirt] [PATCH] prevent an executed external process to be a zombie
by Ryota Ozaki 31 Mar '09

31 Mar '09

Hi, This patch prevents an executed external process to be a zombie by doing waitpid() even if virPipeReadUntilEOF() fails. Thanks, ozaki-r Signed-off-by: Ryota Ozaki <ozaki.ryota(a)gmail.com>

3 3

[libvirt] Patch to allow setting of svirt XML.
by Daniel J Walsh 31 Mar '09

31 Mar '09

This patch fixes the seclabel handling in domain_conf.c to allow virt-manager to set the seclabel model, type and label. Also adds missing error messages when the xml is incorrect. How much verification should we be doing on this? I have another patch that verifies the model as being a known model and a patch to verify the label is a correct label. (IE SELinux verifies the label is understood by the kernel.) The problem with this second patch is it sucks in security.[ch], security_selinux.[ch] into the libvirt_lxc. Should I be doing this?

2 3

[libvirt] Upcoming 0.6.2 release
by Daniel Veillard 31 Mar '09

31 Mar '09

I would like to make a new release mid or end of next week, considering the number of fixes accumulated in CVS compared to 0.6.1, I guess 0.6.2 makes sense. I think we should look at integrating the new SCSI pool patch, hopefully there is no big issues. If there are mails or patchs which are pending and we forgot to review or ACK, please raise them again so that we can try to get them in time for next release, thanks, Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

4 4

[libvirt] PATCH: Misc error handling / OOM fixes
by Daniel P. Berrange 31 Mar '09

31 Mar '09

I ran the OOM checking test suite again and uncovered a handful of pretty minor bugs - no crashers in real code - just forgetting to report OOM correctly * src/datatypes.c: Convert to use the virReportErrorHelper macro instead of a static function, so we get correct function/line number info * src/domain_conf.c: Fix OOM handling in virXPathNodeSet() call so it reports OOM error, instead of ignoring * src/nodeinfo.c: Use _(...) for error message strings * src/xend_internal.c: Add missing check of virBufferError() func and report OOM error * tests/sexpr2xmltest.c: Reset error object between tests, free capabilities object, don't unref a NULL connection object * tests/testutils.c: Fix crash in OOM testing if single threaded * tests/xml2sexprtest.c: Reset error object between tests Daniel Index: src/datatypes.c =================================================================== RCS file: /data/cvs/libvirt/src/datatypes.c,v retrieving revision 1.9 diff -u -p -r1.9 datatypes.c --- src/datatypes.c 29 Jan 2009 12:10:32 -0000 1.9 +++ src/datatypes.c 30 Mar 2009 11:47:05 -0000 @@ -28,31 +28,15 @@ #define VIR_FROM_THIS VIR_FROM_NONE +#define virLibConnError(conn, code, fmt...) \ + virReportErrorHelper(conn, VIR_FROM_THIS, code, __FILE__, \ + __FUNCTION__, __LINE__, fmt) + /************************************************************************ * * * Domain and Connections allocations * * * ************************************************************************/ -/** - * virLibConnError: - * @conn: the connection if available - * @error: the error number - * @info: extra information string - * - * Handle an error at the connection level - */ -static void -virLibConnError(virConnectPtr conn, virErrorNumber error, const char *info) -{ - const char *errmsg; - - if (error == VIR_ERR_OK) - return; - - errmsg = virErrorMsg(error, info); - virRaiseError(conn, NULL, NULL, VIR_FROM_NONE, error, VIR_ERR_ERROR, - errmsg, info, NULL, 0, 0, errmsg, info); -} /** * virDomainFreeName: Index: src/domain_conf.c =================================================================== RCS file: /data/cvs/libvirt/src/domain_conf.c,v retrieving revision 1.72 diff -u -p -r1.72 domain_conf.c --- src/domain_conf.c 24 Mar 2009 11:16:29 -0000 1.72 +++ src/domain_conf.c 30 Mar 2009 11:47:05 -0000 @@ -2068,7 +2068,10 @@ static virDomainDefPtr virDomainDefParse VIR_FREE(tmp); } - if ((n = virXPathNodeSet(conn, "./features/*", ctxt, &nodes)) > 0) { + n = virXPathNodeSet(conn, "./features/*", ctxt, &nodes); + if (n < 0) + goto error; + if (n) { for (i = 0 ; i < n ; i++) { int val = virDomainFeatureTypeFromString((const char *)nodes[i]->name); if (val < 0) { @@ -2079,8 +2082,8 @@ static virDomainDefPtr virDomainDefParse } def->features |= (1 << val); } + VIR_FREE(nodes); } - VIR_FREE(nodes); if (virDomainLifecycleParseXML(conn, ctxt, "string(./on_reboot[1])", &def->onReboot, VIR_DOMAIN_LIFECYCLE_RESTART) < 0) Index: src/nodeinfo.c =================================================================== RCS file: /data/cvs/libvirt/src/nodeinfo.c,v retrieving revision 1.17 diff -u -p -r1.17 nodeinfo.c --- src/nodeinfo.c 20 Jan 2009 17:13:33 -0000 1.17 +++ src/nodeinfo.c 30 Mar 2009 11:47:05 -0000 @@ -74,8 +74,8 @@ int linuxNodeInfoCPUPopulate(virConnectP buf++; if (*buf != ':') { virRaiseError(conn, NULL, NULL, 0, VIR_ERR_INTERNAL_ERROR, - VIR_ERR_ERROR, NULL, NULL, NULL, 0, 0, - "parsing cpuinfo processor"); + VIR_ERR_ERROR, NULL, NULL, NULL, 0, 0, + "%s", _("parsing cpuinfo processor")); return -1; } nodeinfo->cpus++; @@ -87,8 +87,8 @@ int linuxNodeInfoCPUPopulate(virConnectP buf++; if (*buf != ':' || !buf[1]) { virRaiseError(conn, NULL, NULL, 0, VIR_ERR_INTERNAL_ERROR, - VIR_ERR_ERROR, NULL, NULL, NULL, 0, 0, - "parsing cpuinfo cpu MHz"); + VIR_ERR_ERROR, NULL, NULL, NULL, 0, 0, + "%s", _("parsing cpuinfo cpu MHz")); return -1; } if (virStrToLong_ui(buf+1, &p, 10, &ui) == 0 @@ -103,8 +103,8 @@ int linuxNodeInfoCPUPopulate(virConnectP buf++; if (*buf != ':' || !buf[1]) { virRaiseError(conn, NULL, NULL, 0, VIR_ERR_INTERNAL_ERROR, - VIR_ERR_ERROR, NULL, NULL, NULL, 0, 0, - "parsing cpuinfo cpu cores %c", *buf); + VIR_ERR_ERROR, NULL, NULL, NULL, 0, 0, + "parsing cpuinfo cpu cores %c", *buf); return -1; } if (virStrToLong_ui(buf+1, &p, 10, &id) == 0 @@ -116,8 +116,8 @@ int linuxNodeInfoCPUPopulate(virConnectP if (!nodeinfo->cpus) { virRaiseError(conn, NULL, NULL, 0, VIR_ERR_INTERNAL_ERROR, - VIR_ERR_ERROR, NULL, NULL, NULL, 0, 0, - "no cpus found"); + VIR_ERR_ERROR, NULL, NULL, NULL, 0, 0, + "%s", _("no cpus found")); return -1; } Index: src/xend_internal.c =================================================================== RCS file: /data/cvs/libvirt/src/xend_internal.c,v retrieving revision 1.253 diff -u -p -r1.253 xend_internal.c --- src/xend_internal.c 10 Mar 2009 11:13:32 -0000 1.253 +++ src/xend_internal.c 30 Mar 2009 11:47:06 -0000 @@ -5540,6 +5540,11 @@ xenDaemonFormatSxpr(virConnectPtr conn, virBufferAddLit(&buf, ")"); /* closes (vm */ + if (virBufferError(&buf)) { + virReportOOMError(conn); + return NULL; + } + return virBufferContentAndReset(&buf); error: Index: tests/sexpr2xmltest.c =================================================================== RCS file: /data/cvs/libvirt/tests/sexpr2xmltest.c,v retrieving revision 1.36 diff -u -p -r1.36 sexpr2xmltest.c --- tests/sexpr2xmltest.c 29 Jan 2009 17:02:00 -0000 1.36 +++ tests/sexpr2xmltest.c 30 Mar 2009 11:47:06 -0000 @@ -64,7 +64,8 @@ static int testCompareFiles(const char * fail: free(gotxml); virDomainDefFree(def); - virUnrefConnect(conn); + if (conn) + virUnrefConnect(conn); return ret; } @@ -115,6 +116,7 @@ mymain(int argc, char **argv) #define DO_TEST(in, out, version) \ do { \ struct testInfo info = { in, out, version }; \ + virResetLastError(); \ if (virtTestRun("Xen SEXPR-2-XML " in " -> " out, \ 1, testCompareHelper, &info) < 0) \ ret = -1; \ @@ -163,6 +165,8 @@ mymain(int argc, char **argv) DO_TEST("fv-sound", "fv-sound", 1); DO_TEST("fv-sound-all", "fv-sound-all", 1); + virCapabilitiesFree(caps); + return(ret==0 ? EXIT_SUCCESS : EXIT_FAILURE); } Index: tests/testutils.c =================================================================== RCS file: /data/cvs/libvirt/tests/testutils.c,v retrieving revision 1.26 diff -u -p -r1.26 testutils.c --- tests/testutils.c 2 Feb 2009 20:35:14 -0000 1.26 +++ tests/testutils.c 30 Mar 2009 11:47:06 -0000 @@ -409,7 +435,8 @@ int virtTestMain(int argc, /* Run once for each alloc, failing a different one and validating that the test case failed */ for (n = 0; n < approxAlloc && (!mp || worker) ; n++) { - if ((n % mp) != (worker - 1)) + if (mp && + (n % mp) != (worker - 1)) continue; if (!testDebug) { if (mp) Index: tests/xml2sexprtest.c =================================================================== RCS file: /data/cvs/libvirt/tests/xml2sexprtest.c,v retrieving revision 1.34 diff -u -p -r1.34 xml2sexprtest.c --- tests/xml2sexprtest.c 23 Jan 2009 01:48:47 -0000 1.34 +++ tests/xml2sexprtest.c 30 Mar 2009 11:47:06 -0000 @@ -95,6 +95,7 @@ mymain(int argc, char **argv) #define DO_TEST(in, out, name, version) \ do { \ struct testInfo info = { in, out, name, version }; \ + virResetLastError(); \ if (virtTestRun("Xen XML-2-SEXPR " in " -> " out, \ 1, testCompareHelper, &info) < 0) \ ret = -1; \ -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

2 1

[libvirt] [PATCH 0/2]: Cleanup driver initializers
by Chris Lalancette 30 Mar '09

30 Mar '09

All, This is a small series to cleanup the internal driver initializers. The drivers were using an annoying combination of C-99 style initialization and old-style (C89?) initialization. On top of that, the indentation on some of these was wacky, making it even harder to read. After some discussion with DanB, we determined to go with the old-style initializers because it is sort of a self-documenting TODO list. The first patch converts the internal drivers to all use this style of initialization, and fixes up a few wrong comments along the way. Note that this doesn't cleanup the storage or network initializers; assuming this patch is acceptable, we can do those next. The second patch rips out the internal "getURI" callbacks, since they were never, ever used (and buggy to boot). More details in the second patch. -- Chris Lalancette

2 1

[libvirt] [PATCH 1/2] OpenNebula driver, libvirt-0.6.1
by "Abel Míguez Rodríguez" 30 Mar '09

30 Mar '09

Hi all, We have updated the OpenNebula Driver to libvirt version 0.6.1. Now, the ONE driver is build at the libvirtd daemon, that is the natural place for it. Please feel free to make any comment, to improve the driver's coherence with libvirt's structure. I split the Patches in two e-mais: [PATCH 1/2] includes the patches to be applied to libvirt's sources and building files. [PATCH 2/2] attached the "one driver" source files. All the patches are made to be applied at the git commit: "025b62" (Fix subsystem lookup for older HAL releases) Thanks, Abel Miguez diff --git a/configure.in b/configure.in index 413d27c..fd75a8d 100644 --- a/configure.in +++ b/configure.in @@ -184,6 +184,8 @@ AC_ARG_WITH([openvz], [ --with-openvz add OpenVZ support (on)],[],[with_openvz=yes]) AC_ARG_WITH([lxc], [ --with-lxc add Linux Container support (on)],[],[with_lxc=yes]) +AC_ARG_WITH([one], +[ --with-one add ONE support (on)],[],[with_one=no]) AC_ARG_WITH([test], [ --with-test add test driver support (on)],[],[with_test=yes]) AC_ARG_WITH([remote], @@ -399,6 +401,17 @@ dnl check for kvm headers dnl AC_CHECK_HEADERS([linux/kvm.h]) +dnl OpenNebula driver Compilation setting +dnl + +if test "$with_one" = "yes" ; then + LIBVIRT_FEATURES="$LIBVIRT_FEATURES -DWITH_ONE -I$ONE_LOCATION/include" + ONE_LIBS="-L/usr/local/lib -lxmlrpc_client++ -lxmlrpc -lxmlrpc_util -lxmlrpc_xmlparse -lxmlrpc_xmltok -lxmlrpc++ -lxmlrpc_client -L$ONE_LOCATION/lib -loneapi" + AC_SUBST([ONE_LIBS]) + AC_DEFINE_UNQUOTED([WITH_ONE],1,[whether Open Nebula Driver is enabled]) +fi +AM_CONDITIONAL([WITH_ONE],[test "$with_one" = "yes"]) + dnl Need to test if pkg-config exists PKG_PROG_PKG_CONFIG @@ -1345,6 +1358,7 @@ AC_MSG_NOTICE([ QEMU: $with_qemu]) AC_MSG_NOTICE([ UML: $with_uml]) AC_MSG_NOTICE([ OpenVZ: $with_openvz]) AC_MSG_NOTICE([ LXC: $with_lxc]) +AC_MSG_NOTICE([ ONE: $with_one]) AC_MSG_NOTICE([ Test: $with_test]) AC_MSG_NOTICE([ Remote: $with_remote]) AC_MSG_NOTICE([ Network: $with_network]) diff --git a/include/libvirt/virterror.h b/include/libvirt/virterror.h index 2c3777d..cc98e45 100644 --- a/include/libvirt/virterror.h +++ b/include/libvirt/virterror.h @@ -61,6 +61,7 @@ typedef enum { VIR_FROM_UML, /* Error at the UML driver */ VIR_FROM_NODEDEV, /* Error from node device monitor */ VIR_FROM_XEN_INOTIFY, /* Error from xen inotify layer */ + VIR_FROM_ONE, /* Error from ONE driver */ VIR_FROM_SECURITY, /* Error from security framework */ } virErrorDomain; diff --git a/qemud/Makefile.am b/qemud/Makefile.am index 924e8ad..9d7f61f 100644 --- a/qemud/Makefile.am +++ b/qemud/Makefile.am @@ -120,6 +120,10 @@ if WITH_UML libvirtd_LDADD += ../src/libvirt_driver_uml.la endif +if WITH_ONE + libvirtd_LDADD += ../src/libvirt_driver_one.la +endif + if WITH_STORAGE_DIR libvirtd_LDADD += ../src/libvirt_driver_storage.la endif diff --git a/qemud/qemud.c b/qemud/qemud.c index 4f04355..e1d6113 100644 --- a/qemud/qemud.c +++ b/qemud/qemud.c @@ -78,6 +78,9 @@ #ifdef WITH_NETWORK #include "network_driver.h" #endif +#ifdef WITH_ONE +#include "one_driver.h" +#endif #ifdef WITH_STORAGE_DIR #include "storage_driver.h" #endif @@ -841,6 +844,8 @@ static struct qemud_server *qemudInitialize(int sigread) { virDriverLoadModule("qemu"); virDriverLoadModule("lxc"); virDriverLoadModule("uml"); + virDriverLoadModule("one"); + #else #ifdef WITH_NETWORK networkRegister(); @@ -861,6 +866,10 @@ static struct qemud_server *qemudInitialize(int sigread) { #ifdef WITH_UML umlRegister(); #endif +#ifdef WITH_ONE + oneRegister (); +#endif + #endif virEventRegisterImpl(virEventAddHandleImpl, diff --git a/src/Makefile.am b/src/Makefile.am index d5aac11..a5c2084 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -137,6 +137,10 @@ UML_DRIVER_SOURCES = \ uml_conf.c uml_conf.h \ uml_driver.c uml_driver.h +ONE_DRIVER_SOURCES = \ + one_conf.c one_conf.h \ + one_driver.c one_driver.h + NETWORK_DRIVER_SOURCES = \ network_driver.h network_driver.c @@ -314,6 +318,22 @@ endif libvirt_driver_uml_la_SOURCES = $(UML_DRIVER_SOURCES) endif +if WITH_ONE +if WITH_DRIVER_MODULES +mod_LTLIBRARIES += libvirt_driver_one.la +else +noinst_LTLIBRARIES += libvirt_driver_one.la +# Stateful, so linked to daemon instead +#libvirt_la_LIBADD += libvirt_driver_one.la +endif +libvirt_driver_one_la_LDFLAGS = $(ONE_LIBS) +libvirt_driver_one_la_CFLAGS = "-DWITH_ONE" +if WITH_DRIVER_MODULES +libvirt_driver_one_la_LDFLAGS += -module -avoid-version +endif +libvirt_driver_one_la_SOURCES = $(ONE_DRIVER_SOURCES) +endif + if WITH_NETWORK if WITH_DRIVER_MODULES mod_LTLIBRARIES += libvirt_driver_network.la @@ -402,6 +422,7 @@ EXTRA_DIST += \ $(QEMU_DRIVER_SOURCES) \ $(LXC_DRIVER_SOURCES) \ $(UML_DRIVER_SOURCES) \ + $(ONE_DRIVER_SOURCES) \ $(OPENVZ_DRIVER_SOURCES) \ $(NETWORK_DRIVER_SOURCES) \ $(STORAGE_DRIVER_SOURCES) \ diff --git a/src/domain_conf.c b/src/domain_conf.c index 5bf3483..e4d3249 100644 --- a/src/domain_conf.c +++ b/src/domain_conf.c @@ -54,7 +54,9 @@ VIR_ENUM_IMPL(virDomainVirt, VIR_DOMAIN_VIRT_LAST, "ldom", "test", "vmware", - "hyperv") + "hyperv", + "one") + VIR_ENUM_IMPL(virDomainBoot, VIR_DOMAIN_BOOT_LAST, "fd", diff --git a/src/domain_conf.h b/src/domain_conf.h index dd61467..e8a2bff 100644 --- a/src/domain_conf.h +++ b/src/domain_conf.h @@ -48,6 +48,7 @@ enum virDomainVirtType { VIR_DOMAIN_VIRT_TEST, VIR_DOMAIN_VIRT_VMWARE, VIR_DOMAIN_VIRT_HYPERV, + VIR_DOMAIN_VIRT_ONE, VIR_DOMAIN_VIRT_LAST, }; diff --git a/src/driver.h b/src/driver.h index 62d6fbc..ed3eef7 100644 --- a/src/driver.h +++ b/src/driver.h @@ -20,6 +20,7 @@ typedef enum { VIR_DRV_OPENVZ = 5, VIR_DRV_LXC = 6, VIR_DRV_UML = 7, + VIR_DRV_ONE = 8, } virDrvNo; diff --git a/src/libvirt.c b/src/libvirt.c index bf3453a..cd4b5b7 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -830,6 +830,10 @@ virGetVersion(unsigned long *libVer, const char *type, if (STRCASEEQ(type, "OpenVZ")) *typeVer = LIBVIR_VERSION_NUMBER; #endif +#if WITH_ONE + if (STRCASEEQ(type, "ONE")) + *typeVer = LIBVIR_VERSION_NUMBER; +#endif #if WITH_UML if (STRCASEEQ(type, "UML")) *typeVer = LIBVIR_VERSION_NUMBER; ---- Distributed System Architecture Group (http://dsa-research.org) GridWay, http://www.gridway.org OpenNEbula, http://www.opennebula.org

3 2

[libvirt] KVM update
by Zvi Dubitzky 30 Mar '09

30 Mar '09

I am trying to update the kvm driver and userspace using existing kernel 1) using the tar ball from kvm at sourceforge I can do it , but only kvm -84 is there 2) if i try the latest version from the git tree I am able to do the first 2 steps (make --kerneldir=<exisitng kernel headers> , make sync ) . but the final make fails during compile of libkvm.c. results in the file below (dated 3/29/09) Am I missing something Should I recompile the whole kerenl as a 3) Was the live migrate fixed and tested in the latest kernel version thanks Zvi Dubitzky Virtualization and System Architecture Email:dubi@il.ibm.com IBM Haifa Research Laboratory Phone: +972-4-8296182 Haifa, 31905, ISRAEL

3 2

[libvirt] "invalid connection pointer in virConnectClose" from Python bindings
by Charles Duffy 30 Mar '09

30 Mar '09

Howdy. I'm calling libvirt from a program which occasionally has cause to fork() without an immediate exec(). For the sake of simplicity, I presently call close() on all my virConnect objects [which I then delete] before forking and create new ones later. (I'm not forcing an explicit pre-fork garbage collection at present -- hopefully the close() should make one unnecessary). However, libvirt complains (and very occasionally segfaults) as I try to close the connections: libvir: error : invalid connection pointer in virConnectClose libvir: error : invalid connection pointer in virConnectClose Are there any practices I should be following to avoid this? Alternatively, if it is likely to be related to an issue in the Python bindings, is there something I could do to diagnose? Thanks!

2 1

[libvirt] ANNOUNCE: Perl binding Sys-Virt release 0.2.0
by Daniel P. Berrange 28 Mar '09

28 Mar '09

I've made a long overdue update to the Perl binding for libvirt, Sys-Virt. http://search.cpan.org/CPAN/authors/id/D/DA/DANBERR/Sys-Virt-0.2.0.tar.gz The major changes since last time - Fix network create API, and UUID lookups - Implement storage pool, storage vol, node device, security model, domain events and event loop APIs - Improve way constants are exposed to Perl layer - Fix horrible memory leak in methods returning a hash - Fix integer overflow in APIs using 64-bit ints (aka 'long long') - Minimum required libvirt C library for building is 0.6.1 There is comprehensive API documentation available online http://search.cpan.org/dist/Sys-Virt/ As well as a number of example scripts http://cpansearch.perl.org/src/DANBERR/Sys-Virt-0.2.0/examples/ The master source repository for the Perl binding is now at http://libvirt.org/hg/libvirt-perl/ Thanks to everyone who reported bugs, tested the snapshots and sent patches for this release Regards, Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

1 0

[libvirt] [PATCH 2/2] VirtualBox support to libvirt
by Pritesh Kothari 27 Mar '09

27 Mar '09

Hi All, I have attached a patch which when applied on the HEAD as of today would allow virtualbox support in libvirt. The patch works very well with the VirtualBox OSE version and the 2.2 Beta release. [PATCH 1/2] contains diff of files already in libvirt. [PATCH 2/2] contains new files needed for VirtualBox support. Regards, -pritesh

3 5

[libvirt] libvirt Centos4
by Gian Mario 27 Mar '09

27 Mar '09

Hi to all, i need to compile libvirt-3.3.0 to Centos 4.7. Searching in mailing list i have seen a tread that help me to solve few problems. Actually i face with a error concern glibc, when i run make in libvirt directory, I obtain: /usr/lib64/libgcrypt.so.11: undefined reference to `__read_chk(a)GLIBC_2.4' /usr/lib/gcc/x86_64-redhat-linux/3.4.6/../../../../lib64/libgnutls.so: undefined reference to `__stack_chk_fail(a)GLIBC_2.4' collect2: ld returned 1 exit status make[2]: *** [virsh] Error 1 make[2]: Leaving directory `/root/XEN/libvirt-0.3.3/src' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/root/XEN/libvirt-0.3.3' make: *** [all] Error 2 Any one have some experience on compile libvirt on centos4? there is any possibilities to build it without upgrade glibc? tnks to any help. Ciao e statevi bene. GMario

3 2

[libvirt] PATCH: Support memory ballooning for QEMU
by Daniel P. Berrange 27 Mar '09

27 Mar '09

This patch implements full support for memory ballooning in the QEMU driver. - Fix qemudBuildCommandLine() to set the initial boot time VM memory allocation based off the 'maxmem' config field. - Add call to 'qemudDomainSetMemoryBalloon' immediately at startup to make the guest balloon to initial requested allocation. - In the qemudDomainGetInfo() and qemudDomainDumpXML calls, query the monitor to find current balloon allocation and update config - Implement qemudDomainSetMemory() for running guests using the monitor balloon command In all of these scenarios, if the QEMU being used is too old to support the memory balloon device, the user will get a suitable error or it'll report the statically defined memory allocation from boot time. Daniel diff -r 4bfef84f4d6f src/qemu_conf.c --- a/src/qemu_conf.c Tue Mar 10 12:09:41 2009 +0000 +++ b/src/qemu_conf.c Tue Mar 10 16:16:59 2009 +0000 @@ -870,7 +870,11 @@ int qemudBuildCommandLine(virConnectPtr } \ } while (0) - snprintf(memory, sizeof(memory), "%lu", vm->def->memory/1024); + /* Set '-m MB' based on maxmem, because the lower 'memory' limit + * is set post-startup using the balloon driver. If balloon driver + * is not supported, then they're out of luck anyway + */ + snprintf(memory, sizeof(memory), "%lu", vm->def->maxmem/1024); snprintf(vcpus, sizeof(vcpus), "%lu", vm->def->vcpus); snprintf(domid, sizeof(domid), "%d", vm->def->id); pidfile = virFilePid(driver->stateDir, vm->def->name); diff -r 4bfef84f4d6f src/qemu_driver.c --- a/src/qemu_driver.c Tue Mar 10 12:09:41 2009 +0000 +++ b/src/qemu_driver.c Tue Mar 10 16:16:59 2009 +0000 @@ -122,6 +122,9 @@ static int qemudMonitorCommandExtra(cons const char *extra, const char *extraPrompt, char **reply); +static int qemudDomainSetMemoryBalloon(virConnectPtr conn, + virDomainObjPtr vm, + unsigned long newmem); static struct qemud_driver *qemu_driver = NULL; @@ -1480,6 +1483,7 @@ static int qemudStartVMDaemon(virConnect (qemudDetectVcpuPIDs(conn, vm) < 0) || (qemudInitCpus(conn, vm, migrateFrom) < 0) || (qemudInitPasswords(conn, driver, vm) < 0) || + (qemudDomainSetMemoryBalloon(conn, vm, vm->def->memory) < 0) || (qemudSaveDomainStatus(conn, qemu_driver, vm) < 0)) { qemudShutdownVMDaemon(conn, driver, vm); return -1; @@ -2409,6 +2413,98 @@ cleanup: return ret; } + +#define BALLOON_PREFIX "balloon: actual=" + +/* + * Returns: 0 if balloon not supported, +1 if balloon query worked + * or -1 on failure + */ +static int qemudDomainGetMemoryBalloon(virConnectPtr conn, + virDomainObjPtr vm, + unsigned long *currmem) { + char *reply = NULL; + int ret = -1; + char *offset; + + if (qemudMonitorCommand(vm, "info balloon", &reply) < 0) { + qemudReportError(conn, dom, NULL, VIR_ERR_OPERATION_FAILED, + "%s", _("could not query memory balloon allocation")); + goto cleanup; + } + + /* If the command failed qemu prints: + * device not found, device is locked ... + * No message is printed on success it seems */ + DEBUG ("balloon reply: '%s'", reply); + if ((offset = strstr(reply, BALLOON_PREFIX)) != NULL) { + unsigned int memMB; + char *end; + offset += strlen(BALLOON_PREFIX); + if (virStrToLong_ui(offset, &end, 10, &memMB) < 0) { + qemudReportError(conn, dom, NULL, VIR_ERR_OPERATION_FAILED, + "%s", _("could not parse memory balloon allocation")); + goto cleanup; + } + *currmem = memMB * 1024; + ret = 1; + } else { + /* We don't raise an error here, since its to be expected that + * many QEMU's don't support ballooning + */ + ret = 0; + } + +cleanup: + VIR_FREE(reply); + return ret; +} + +/* + * Returns: 0 if balloon not supported, +1 if balloon query worked + * or -1 on failure + */ +static int qemudDomainSetMemoryBalloon(virConnectPtr conn, + virDomainObjPtr vm, + unsigned long newmem) { + char *cmd; + char *reply = NULL; + int ret = -1; + + /* + * 'newmem' is in KB, QEMU monitor works in MB, and we all wish + * we just worked in bytes with unsigned long long everywhere. + */ + if (virAsprintf(&cmd, "balloon %lu", (newmem / 1024)) < 0) { + virReportOOMError(conn); + goto cleanup; + } + + if (qemudMonitorCommand(vm, cmd, &reply) < 0) { + qemudReportError(conn, dom, NULL, VIR_ERR_OPERATION_FAILED, + "%s", _("could not balloon memory allocation")); + VIR_FREE(cmd); + goto cleanup; + } + VIR_FREE(cmd); + + /* If the command failed qemu prints: + * device not found, device is locked ... + * No message is printed on success it seems */ + DEBUG ("balloon reply: %s", reply); + if (strstr(reply, "\nunknown command:")) { + /* Don't set error - it is expected memory balloon fails on many qemu */ + ret = 0; + } else { + ret = 1; + } + +cleanup: + VIR_FREE(reply); + return ret; +} + + static int qemudDomainSetMemory(virDomainPtr dom, unsigned long newmem) { struct qemud_driver *driver = dom->conn->privateData; virDomainObjPtr vm; @@ -2426,20 +2522,21 @@ static int qemudDomainSetMemory(virDomai goto cleanup; } + if (newmem > vm->def->maxmem) { + qemudReportError(dom->conn, dom, NULL, VIR_ERR_INVALID_ARG, + "%s", _("cannot set memory higher than max memory")); + goto cleanup; + } + if (virDomainIsActive(vm)) { - qemudReportError(dom->conn, dom, NULL, VIR_ERR_NO_SUPPORT, - "%s", _("cannot set memory of an active domain")); - goto cleanup; - } - - if (newmem > vm->def->maxmem) { - qemudReportError(dom->conn, dom, NULL, VIR_ERR_INVALID_ARG, - "%s", _("cannot set memory higher than max memory")); - goto cleanup; - } - - vm->def->memory = newmem; - ret = 0; + ret = qemudDomainSetMemoryBalloon(dom->conn, vm, newmem); + if (ret == 0) + qemudReportError(dom->conn, dom, NULL, VIR_ERR_NO_SUPPORT, + "%s", _("cannot set memory of an active domain")); + } else { + vm->def->memory = newmem; + ret = 0; + } cleanup: if (vm) @@ -2452,6 +2549,8 @@ static int qemudDomainGetInfo(virDomainP struct qemud_driver *driver = dom->conn->privateData; virDomainObjPtr vm; int ret = -1; + int err; + unsigned long balloon; qemuDriverLock(driver); vm = virDomainFindByUUID(&driver->domains, dom->uuid); @@ -2473,8 +2572,15 @@ static int qemudDomainGetInfo(virDomainP } } + err = qemudDomainGetMemoryBalloon(dom->conn, vm, &balloon); + if (err < 0) + goto cleanup; + info->maxMem = vm->def->maxmem; - info->memory = vm->def->memory; + if (err == 0) /* Balloon not supported */ + info->memory = vm->def->memory; + else + info->memory = balloon; info->nrVirtCpu = vm->def->vcpus; ret = 0; @@ -3169,16 +3275,25 @@ static char *qemudDomainDumpXML(virDomai struct qemud_driver *driver = dom->conn->privateData; virDomainObjPtr vm; char *ret = NULL; - - qemuDriverLock(driver); - vm = virDomainFindByUUID(&driver->domains, dom->uuid); - qemuDriverUnlock(driver); - - if (!vm) { - qemudReportError(dom->conn, dom, NULL, VIR_ERR_INVALID_DOMAIN, - "%s", _("no domain with matching uuid")); - goto cleanup; - } + unsigned long balloon; + int err; + + qemuDriverLock(driver); + vm = virDomainFindByUUID(&driver->domains, dom->uuid); + qemuDriverUnlock(driver); + + if (!vm) { + qemudReportError(dom->conn, dom, NULL, VIR_ERR_INVALID_DOMAIN, + "%s", _("no domain with matching uuid")); + goto cleanup; + } + + /* Refresh current memory based on balloon info */ + err = qemudDomainGetMemoryBalloon(dom->conn, vm, &balloon); + if (err < 0) + goto cleanup; + if (err > 0) + vm->def->memory = balloon; ret = virDomainDefFormat(dom->conn, (flags & VIR_DOMAIN_XML_INACTIVE) && vm->newDef ? -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

3 4

[libvirt] Libvirt - Problems in different Versions
by Artur Baruchi 27 Mar '09

27 Mar '09

Hi Guys. Im writing a program that connects to Xen and gets some information (scheduller and memory informations). When executing the program using the libvirt 0.3.3 its working fine, BUT when running using libvirt 0.4.4 it doesnt work. I dont get any error message when compiling or executing, but the informations doesnt come. -> Using libvirt 0.3.3 # gcc -Wall -lxenstore `pkg-config --cflags --libs libvirt` test.c -o test # ./test DOMAINS IDENTIFIED 2 DomID: 0 Max Mem: 4294967292 Sched: 256 DomID: 3 Max Mem: 262144 Sched: 256 # xm list Name ID Mem VCPUs State Time(s) Domain-0 0 616 2 r----- 4751.9 vm01 3 256 2 -b---- 379.7 -> Using libvirt 0.4.4 # gcc -Wall -lxenstore `pkg-config --cflags --libs libvirt` test.c -o test # ./test DOMAINS IDENTIFIED 0 # xm list Name ID Mem VCPUs State Time(s) Domain-0 0 481 2 r----- 89.8 linuxprv01 1 512 1 -b---- 10.8 I executed the same program in other server, with 0.4.4 version, and got the same problem. Is there any difference between those versions? Thanks in advance. Att. Artur Baruchi

2 1

[libvirt] Using libvirt from PHP
by Radek Hladik 26 Mar '09

26 Mar '09

Hi, I am developing wimple web application in PHP to monitor and control VMs using libvirt. I hope it could become simple library for doing basic things with VMs. And I would like to ask for your opinion about different possibilities of calling libvirt. Option 1) I am calling virsh via exec command now (one virsh for every libvirt command). This can be used for local libvirt but it is very inefficient. The overhead for remote libvirt would be unbearable. I could run one virsh per page and use it "interactively" so the overhead gets lower. Option 2) The other option is to create Zend extension which should be able to call libvirt directly from C. However I've never done anything like that so I do not know, whether it is reasonable or not. Option 3) I could also create some "wrapper daemon" in C or other language with libvirt binding. But I think that this is an ugly way :-) Option 4) I could "talk" directly to the libvirt socket. But I am not sure how the communication goes there and whether it is stable or changes with every version. And I consider the socket to be internal thing of libvirt... Is there any other option I missed? And which one would you suggest? Radek

5 5

[libvirt] Monitoring VMs via java application
by Daniel Halle 26 Mar '09

26 Mar '09

Hello all, I want to monitor my VMs with a Java application. Is there a possibility to register an observer or the like which is triggered e.g. after the state of a VM has changed? Or is the only way to use a timer which polls all VMs every xy minutes? Thanks, Daniel -- Infinis GmbH - Taläckerstr. 30 - D-70437 Stuttgart Geschäftsführer: Daniel Schwager, Stefan Hörz - HRB Stuttgart 20964 Tel: 0711-849910-23 - Fax: 0711-849910-923 - daniel.halle(a)infinis.de

2 1

[libvirt] Restoring from a largish 'virsh save' file
by Matt McCowan 26 Mar '09

26 Mar '09

Running into an issue where, if I/O is hampered by load for example, reading a largish state file (created by 'virsh save') is not allowed to complete. qemudStartVMDaemon in src/qemu_driver.c has a loop that waits 10 seconds for the VM to be brought up. An strace against libvirt when doing a 'virsh restore' against a largish state file shows the VM being sent a kill when it's still happily reading from the file. inotify is used in the xen and uml drivers, so I thought it would be a suitable mechanism to delay the timeout loop if the state file was still being read. Is this the right way to solve this problem? I've inlined some (flimsy) mods for comment Regards Matt McCowan --- libvirt.orig/src/qemu_driver.c 2009-03-20 11:17:57.000000000 +0900 +++ libvirt-0.6.1.1/src/qemu_driver.c 2009-03-22 18:36:06.000000000 +0900 @@ -43,6 +43,7 @@ #include <stdio.h> #include <sys/wait.h> #include <sys/ioctl.h> +#include <sys/inotify.h> #if HAVE_NUMACTL #define NUMA_VERSION1_COMPATIBILITY 1 @@ -1310,6 +1309,11 @@ pid_t child; int pos = -1; char ebuf[1024]; + char rpathname[PATH_MAX]; + int fd = 0; + int wd = 0; + int got = 0; + char buf[1024]; struct gemudHookData hookData; hookData.conn = conn; @@ -1430,6 +1434,19 @@ qemudSecurityHook, &hookData); /* wait for qemu process to to show up */ + + /* Times out if using a restore file and that file + is big. Use inotify */ + if (stdin_fd > 0) { + fd = inotify_init(); + + if (snprintf(rpathname, sizeof(rpathname), "/proc/self/fd/%d", + stdin_fd) >= (int)sizeof(rpathname)) { + return -1; + } + wd = inotify_add_watch(fd, rpathname, IN_ACCESS); + } + if (ret == 0) { int retries = 100; int childstat; @@ -1442,7 +1459,15 @@ if ((ret = virFileReadPid(driver->stateDir, vm->def->name, &vm->pid)) == 0) break; usleep(100*1000); - retries--; + + /* Is state file being accessed? */ + got = read(fd, buf, sizeof(buf)); + if (got < 1) + retries--; + } + if (stdin_fd > 0) { + inotify_rm_watch(fd, wd); + close(fd); } if (ret) { qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR,

2 3

Re: [libvirt] Using libvirt from PHP
by Russell Haering 25 Mar '09

25 Mar '09

* Sorry, I somehow sent this to the wrong address * Radek, Not to advertise blatantly, but how attached are you to PHP? I'm currently working on a Django (python) WebApp that (although its *very* pre-release) could probably be adapted to what you're doing. If you are interested in assisting in development you'd be welcome to, or if you just wanted to fork off the code into your own thing you could do that too. My system consists of a python daemon used for actual libvirt interaction and a separate django web interface that interacts with the daemon via AMF over https. If you want to stick with what you have now, you could try doing something similar with a python daemon (you really need something like that for the sake of efficiency anyway, unless you can come up with a better way of maintaining libvirt connections from a stateless webapp) that your PHP frontend connects to. Or you could just steal my daemon code, although at the moment all it really does is monitoring and (as of yesterday) live migrations. What I have so far: http://trac.osuosl.org/trac/virtadmin -- Russell Haering Systems Administrator OSU Open Source Lab Radek Hladik wrote: > > Hi, > > I am developing wimple web application in PHP to monitor and control > > VMs using libvirt. I hope it could become simple library for doing basic > > things with VMs. And I would like to ask for your opinion about > > different possibilities of calling libvirt. > > > > Option 1) I am calling virsh via exec command now (one virsh for every > > libvirt command). This can be used for local libvirt but it is very > > inefficient. The overhead for remote libvirt would be unbearable. I > > could run one virsh per page and use it "interactively" so the overhead > > gets lower. > > Option 2) The other option is to create Zend extension which should be > > able to call libvirt directly from C. However I've never done anything > > like that so I do not know, whether it is reasonable or not. > > Option 3) I could also create some "wrapper daemon" in C or other > > language with libvirt binding. But I think that this is an ugly way :-) > > Option 4) I could "talk" directly to the libvirt socket. But I am not > > sure how the communication goes there and whether it is stable or > > changes with every version. And I consider the socket to be internal > > thing of libvirt... > > > > Is there any other option I missed? And which one would you suggest? > > > > Radek > > > > -- > > Libvir-list mailing list > > Libvir-list(a)redhat.com > > https://www.redhat.com/mailman/listinfo/libvir-list

1 0

[libvirt] Need help for thesis on Xen - disabling HAP for benchmarking purposes
by Alexander Sascha 25 Mar '09

25 Mar '09

Hi, I'm a German student, writing my thesis on "Virtualization with Xen. Analysis and Comparision of Different Techniques such as Paravirtualization, Full Virtualization, and Utilization of Hardware Support Provided by the Processor". I'd like to know how I can disable HAP/RVI/Nested Paging for benchmarking purposes. I read somewhere (http://markmail.org/message/bbnivuqx6vjz7jg4) that Xen developers decided to disable the global grub parameter introducing a per domain flag for HAP instead (hap=0/1). I used virt-manager built in CentOS for setting up all domUs; virt-manager uses libvirt so that no "old-style" configuration files are stored in /etc/xen. I actually don't know how if libvirt-XML-files already support something like <hap>0</hap>. How would you proceed to modify an already existing domain using libvirt/virt-manager? I really do apologize for my "newbie ignorance". Thanks in advance for any useful help. - Alex

2 1

[libvirt] [RFC]: Volume allocation progress reporting
by Cole Robinson 25 Mar '09

25 Mar '09

The attached patch implements storage volume allocation progress reporting for file volumes. Currently, the volume creation process looks like: - Grab the pool lock - Fully allocated the volume - 'define' the volume (so it shows up in 'virsh vol-list', etc) - Lookup the volume object to return - Drop the pool lock The new sequence is: - Grab the pool lock - 'define' the volume (even though nothing is on disk yet) - Drop the pool lock - Allocate the volume as needed - Regrab the pool lock - Lookup the volume object to return - Drop the pool lock (again) Since the volume is 'defined', the user can fetch an object reference in a separate thread, and continually poll the 'info' command for up to date numbers. This also has the benefit of dropping the pool lock during the potentially lengthy allocation, as currently 'virsh pool-list' etc. will block while any volume is being allocated. Non file volumes maintain existing behavior. I tried to make the implementation resistant to user error: say if the pool is deactivated or deleted while the volume is being allocated. The creation process may bail out, but I couldn't produce any bad errors (crashing). There are a few other small fixes in this patch: - Refresh volume info when doing volume dumpxml - Update volume capacity when doing a refresh I've also attached an ugly python script that can test this. Presuming you have a pool named 'default', running python sparse.py --vol-create-info Will launch an allocation, print vol.info in a loop. Feedback appreciated. Thanks, Cole import libvirt import threading import time import sys import optparse poolname = "default" volname = "nonsparsetest" testvol = "testvol" uri = "qemu:///system" testvolxml = """ <volume> <name>%s</name> <capacity>1048576000</capacity> <allocation>0</allocation> <target> <format type='raw'/> </target> </volume> """ % testvol volxml = """ <volume> <name>%s</name> <capacity>1048576000</capacity> <allocation>800000000</allocation> <target> <format type='raw'/> </target> </volume> """ % volname failvol = """ <volume> <name>%s</name> <capacity>1048576000</capacity> <allocation>1048576000</allocation> <target> <format type='bochs'/> </target> </volume> """ % volname poolxml = """ <pool type='dir'> <name>default</name> <target> <path>/var/lib/libvirt/images</path> </target> </pool> """ # Helper functions def exception_wrapper(cmd, args): try: cmd(*args) except Exception, e: print str(e) def make_test_vol(): pool = get_pool() pool.createXML(testvolxml, 0) def del_vol(name=volname): pool = get_pool() vol = pool.storageVolLookupByName(name) vol.delete(0) def del_pool(): pool = get_pool() pool.destroy() pool.undefine() def define_pool(): conn = libvirt.open(uri) pool = conn.storagePoolDefineXML(poolxml, 0) pool.create(0) pool.setAutostart(True) def allocate_thread(xml=volxml): try: del_vol() except: pass pool = get_pool() print "creating vol in thread" vol = pool.createXML(xml, 0) print "creating vol complete." def info_thread(vol): for i in range(0, 40): time.sleep(.5) print vol.info() def get_pool(name=poolname): conn = libvirt.open(uri) return conn.storagePoolLookupByName(name) def get_vol(name=volname): pool = get_pool() return pool.storageVolLookupByName(name) def cmd_vol_create(xml=volxml): exception_wrapper(define_pool, ()) pool = get_pool() print pool.listVolumes() t = threading.Thread(target=allocate_thread, name="Allocating", args=(xml,)) t.start() time.sleep(5) print "\nRefreshing pool and dumping list" pool.refresh(0) print pool.listVolumes() def cmd_vol_fail(): cmd_vol_create(failvol) def cmd_vol_poll(): cmd_vol_create() vol = get_vol() t = threading.Thread(target=info_thread, name="Getting info", args=(vol,)) t.start() def main(): import optparse parser = optparse.OptionParser() parser.add_option("", "--vol-create", action="store_true", dest="vol_create", help="Create a volume nonsparse volume that should " "succeed") parser.add_option("", "--vol-create-info", action="store_true", dest="vol_create_info", help="Create a volume nonsparse volume that should " "succeed, and list info in a loop") parser.add_option("", "--vol-create-fail", action="store_true", dest="vol_fail", help="Create a volume that will fail at the allocate " "stage") options, ignore = parser.parse_args() if options.vol_create: cmd_vol_create() elif options.vol_create_info: cmd_vol_poll() elif options.vol_fail: cmd_vol_fail() else: parser.print_help() sys.exit(1) if __name__ == "__main__": main()

2 2

[libvirt] first cut public API for physical host interface configuration
by Laine Stump 25 Mar '09

25 Mar '09

To get started integrating libnetcf support into libvirt, the attached libvirt.h diff has a first attempt at the public API that will hook up to libnetcf on the libvirtd side. I started out with the virNetwork* API, and modified/removed as seemed appropriate. A few points worth mentioning: virNetwork has "defined" and "active" interfaces, but so far virInterface just has interfaces, as the active/inactive status is really controlled by 1) the "onboot" property in the XML, and 2) whether or not virInterfaceStart() has been called yet. The _virInterface struct that is referenced here is more or less identical to _virnetwork. libnetcf works with netcf structs (one per library instance) and netcf_if structs (one per interface, multiple per library instance. As far as I can see right now, the netcf struct will not need to be referenced directly from the client side, but the netcf_if for each interface is needed, and I guess a cookie representing it will be sent to the client side and stored in the _virInterface. Is that what the UUID in _virNetwork is used for? (I know, I know - "read the code!", it's just quicker to (and avoids misreading on my part) to ask) As before, any and all advice/corrections gratefully accepted! diff --git a/include/libvirt/libvirt.h b/include/libvirt/libvirt.h index 779ea72..cac400e 100644 --- a/include/libvirt/libvirt.h +++ b/include/libvirt/libvirt.h @@ -854,7 +854,73 @@ int virNetworkGetAutostart (virNetworkPtr network, int virNetworkSetAutostart (virNetworkPtr network, int autostart); +/* + * Physical host interface configuration API + */ + +/** + * virInterface: + * + * a virInterface is a private structure representing a virtual interface. + */ +typedef struct _virInterface virInterface; + +/** + * virInterfacePtr: + * + * a virInterfacePtr is pointer to a virInterface private structure, this is the + * type used to reference a virtual interface in the API. + */ +typedef virInterface *virInterfacePtr; + +/* + * Get connection from interface. + */ +virConnectPtr virInterfaceGetConnect (virInterfacePtr interface); + +/* + * List defined interfaces + */ +int virConnectNumOfInterfaces (virConnectPtr conn); +int virConnectListInterfaces (virConnectPtr conn, + char **const names, + int maxnames); + +/* + * Lookup interface by name + */ +virInterfacePtr virInterfaceLookupByName (virConnectPtr conn, + const char *name); + const char *uuid); + +/* + * Define interface (or modify existing interface configuration) + */ +virInterfacePtr virInterfaceDefineXML (virConnectPtr conn, + const char *xmlDesc); + +/* + * Delete interface + */ +int virInterfaceUndefine (virInterfacePtr interface); + +/* + * Activate interface (ie call "ifup") + */ +int virInterfaceStart (virInterfacePtr interface); + +/* + * De-activate interface (call "ifdown") + */ +int virInterfaceStop (virInterfacePtr interface); + +/* + * Interface information + */ +const char* virInterfaceGetName (virInterfacePtr interface); +char * virInterfaceGetXMLDesc (virInterfacePtr interface, + int flags); /** * virStoragePool: *

1 0

[libvirt] virt-top
by Zvi Dubitzky 24 Mar '09

24 Mar '09

Are the sources of virt-top available at some repository to look at . I do not see them in the Download section of libvirt Web site thanks Zvi Dubitzky Virtualization and System Architecture Email:dubi@il.ibm.com IBM Haifa Research Laboratory Phone: +972-4-8296182 Haifa, 31905, ISRAEL

2 1

[libvirt] save/ restore a domain with kvm
by Zvi Dubitzky 24 Mar '09

24 Mar '09

I am working with virsh The version of VIRSH as it shows is : virsh # version Compiled against library: libvir 0.4.4 Using library: libvir 0.4.4 Using API: QEMU 0.4.4 Running hypervisor: QEMU 0.9.1 Under virsh I do the following : 1. suspend a running VM 2. save it to a file with the 'save' command 3. restore the saved domain file with the 'restore' command while the domain is still in the suspend mode or after it was shutdown/destroyed (not seen with 'list --all) In either case I get the error message saying : virsh # restore /home/dubi/xml/vm_dubi2.sav libvir: QEMU error : operation failed: failed to start VM error: Failed to restore domain from /home/dubi/xml/vm_dubi2.xml Any idea what is the failure reason ? The content of the saved domain file isattached: Zvi Dubitzky Virtualization and System Architecture Email:dubi@il.ibm.com IBM Haifa Research Laboratory Phone: +972-4-8296182 Haifa, 31905, ISRAEL

3 5

[libvirt] [PATCH 1/2] VirtualBox support to libvirt
by Pritesh Kothari 24 Mar '09

24 Mar '09

Hi All, I have attached a patch which when applied on the HEAD as of today would allow virtualbox support in libvirt. The patch works very well with the VirtualBox OSE version and the 2.2 Beta release. [PATCH 1/2] contains diff of files already in libvirt. [PATCH 2/2] contains new files needed for VirtualBox support. Regards, -pritesh

3 6

[libvirt] Improve heuristic for default guest architecture
by Soren Hansen 24 Mar '09

24 Mar '09

In libvirt 0.6.1, if you create a domain description of type 'kvm' without an arch set on an x86-64 host, you would get an i686 qemu guest rather than the expected x86-64 kvm guest. This is because virCapabilitiesDefaultGuestArch doesn't take the domain type into consideration, so it just returned the first hvm architecutre that has been registered, which is i686. After applying Dan P's patch, http://www.redhat.com/archives/libvir-list/2009-March/msg00281.html, I now get a i686 kvm guest, since kvm now can do i686 guests from libvirt. This is certainly an improvement, but I think a more reasonable default is to attempt to match the host's architecture. This patch makes virCapabilitiesDefaultGuestArch also check the domain type, and also gives preference to a guest architecture that matches the host's architecture. Index: libvirt-0.6.1/src/capabilities.c =================================================================== --- libvirt-0.6.1.orig/src/capabilities.c 2009-03-19 15:18:09.483317579 +0100 +++ libvirt-0.6.1/src/capabilities.c 2009-03-19 15:42:31.027341187 +0100 @@ -468,14 +468,26 @@ */ extern const char * virCapabilitiesDefaultGuestArch(virCapsPtr caps, - const char *ostype) + const char *ostype, + const char *domain) { - int i; + int i, j; + const char *arch = NULL; for (i = 0 ; i < caps->nguests ; i++) { - if (STREQ(caps->guests[i]->ostype, ostype)) - return caps->guests[i]->arch.name; + if (STREQ(caps->guests[i]->ostype, ostype)) { + for (j = 0 ; j < caps->guests[i]->arch.ndomains ; j++) { + if (STREQ(caps->guests[i]->arch.domains[j]->type, domain)) { + /* Use the first match... */ + if (!arch) + arch = caps->guests[i]->arch.name; + /* ...unless we can match the host's architecture. */ + if (STREQ(caps->guests[i]->arch.name, caps->host.arch)) + return caps->guests[i]->arch.name; + } + } + } } - return NULL; + return arch; } /** Index: libvirt-0.6.1/src/capabilities.h =================================================================== --- libvirt-0.6.1.orig/src/capabilities.h 2009-03-19 15:18:09.507338228 +0100 +++ libvirt-0.6.1/src/capabilities.h 2009-03-19 15:42:31.027341187 +0100 @@ -177,7 +177,8 @@ extern const char * virCapabilitiesDefaultGuestArch(virCapsPtr caps, - const char *ostype); + const char *ostype, + const char *domain); extern const char * virCapabilitiesDefaultGuestMachine(virCapsPtr caps, const char *ostype, Index: libvirt-0.6.1/src/domain_conf.c =================================================================== --- libvirt-0.6.1.orig/src/domain_conf.c 2009-03-19 15:18:09.531341976 +0100 +++ libvirt-0.6.1/src/domain_conf.c 2009-03-19 15:42:31.031345327 +0100 @@ -2146,7 +2146,7 @@ goto error; } } else { - const char *defaultArch = virCapabilitiesDefaultGuestArch(caps, def->os.type); + const char *defaultArch = virCapabilitiesDefaultGuestArch(caps, def->os.type, virDomainVirtTypeToString(def->virtType)); if (defaultArch == NULL) { virDomainReportError(conn, VIR_ERR_INTERNAL_ERROR, _("no supported architecture for os type '%s'"), Index: libvirt-0.6.1/src/xm_internal.c =================================================================== --- libvirt-0.6.1.orig/src/xm_internal.c 2009-03-19 15:18:09.559316828 +0100 +++ libvirt-0.6.1/src/xm_internal.c 2009-03-19 15:42:45.807318313 +0100 @@ -695,7 +695,7 @@ if (!(def->os.type = strdup(hvm ? "hvm" : "xen"))) goto no_memory; - defaultArch = virCapabilitiesDefaultGuestArch(priv->caps, def->os.type); + defaultArch = virCapabilitiesDefaultGuestArch(priv->caps, def->os.type, virDomainVirtTypeToString(def->virtType)); if (defaultArch == NULL) { xenXMError(conn, VIR_ERR_INTERNAL_ERROR, _("no supported architecture for os type '%s'"), -- Soren Hansen | Lead Virtualisation Engineer | Ubuntu Server Team Canonical Ltd. | http://www.ubuntu.com/

3 3

[libvirt] [PATCH] Adding filesystem mount support for openVZ
by Florian Vichot 24 Mar '09

24 Mar '09

Hi everyone, This patch is to allow using the "mount" type in the "filesystem" tag for OpenVZ domains. Example: ... <filesystem type='mount'> <source dir='/path/to/filesystem/directory/' /> <target dir='/path/to/pivot/root/' /> </filesystem> ... This is my first patch to an external project, so don't spare me if I got things wrong :) Also, I'm curious for suggestions as to how I could allow for the target not to be specified in the XML. Because in this case OpenVZ just makes a temporary pivot root in "/var/lib/vz/root/" and that is probably sufficient for most people, who might not want to have to explicitly create a pivot root somewhere, just for mounting the filesystem while it's running. I was thinking either allow for the target tag not to be specified, or add an "auto" attribute to target. Which one sounds better ? Thanks, Florian

3 8