February 2009 - Devel - libvirt List Archives

[libvirt] bridge-to-lan interfaces with network type
by Zhengang Li 21 Feb '09

21 Feb '09

Hi All, The documentation on the libvirt website explains the way to define a bridge to LAN network interfaces with a 'bridge' type. E.g.: <interface type='bridge'> <source bridge='br0'/> <mac address='52:54:00:00:00:11'/> </interface> I'm working in a limited environment. Only 'network' type interfaces can be defined for a guest. Is it possible to define a bridge-to-lan interfaces with a 'network' type? The question actually goes to: How to write a network definition xml for libvirt to use as bridge to LAN type NIC in guest? I tried with 'nat' and 'route' forward in network xml, neither works for me. Regards, Zhengang

3 2

[libvirt] can't install fedora guest
by Farkas Levente 19 Feb '09

19 Feb '09

hi, while i try to install fedora-10 guest on centos-5 host i've got the error bellow virt-manager. our setup: virt-manager-0.6.1-1 libvirt-0.6.0-1 kvm-83-1 ----------------------------------------------- Unable to complete install 'libvirt.libvirtError internal error unable to start guest: Traceback (most recent call last): File "/usr/share/virt-manager/virtManager/create.py", line 717, in do_install dom = guest.start_install(False, meter = meter) File "/usr/lib/python2.4/site-packages/virtinst/Guest.py", line 926, in start_install return self._do_install(consolecb, meter, removeOld, wait) File "/usr/lib/python2.4/site-packages/virtinst/Guest.py", line 966, in _do_install self.domain = self.conn.createLinux(install_xml, 0) File "/usr/lib64/python2.4/site-packages/libvirt.py", line 973, in createLinux if ret is None:raise libvirtError('virDomainCreateLinux() failed', conn=self) libvirtError: internal error unable to start guest: ----------------------------------------------- while this is in virt-manager's log: ----------------------------------------------- [Fri, 06 Feb 2009 10:27:15 virt-manager 31523] DEBUG (Storage:908) Storage volume 'fedora-i386.img' install complete. [Fri, 06 Feb 2009 10:27:15 virt-manager 31523] DEBUG (Guest:964) Creating guest from: <domain type='kvm'> <name>fedora-i386</name> <currentMemory>524288</currentMemory> <memory>524288</memory> <uuid>75330b36-f8e3-8459-2d71-fb47245d7203</uuid> <os> <type arch='x86_64'>hvm</type> <boot dev='cdrom'/> </os> <features> <acpi/><apic/> </features> <clock offset="utc"/> <on_poweroff>destroy</on_poweroff> <on_reboot>destroy</on_reboot> <on_crash>destroy</on_crash> <vcpu>1</vcpu> <devices> <emulator>/usr/bin/qemu-kvm</emulator> <console type='pty'/> <disk type='file' device='disk'> <source file='/var/lib/libvirt/images/fedora-i386.img'/> <target dev='vda' bus='virtio'/> </disk> <disk type='block' device='cdrom'> <source dev='/dev/hda'/> <target dev='hdc' bus='ide'/> <readonly/> </disk> <interface type='bridge'> <source bridge='eth0'/> <mac address='54:52:00:5d:99:c0'/> <model type='virtio'/> </interface> <input type='mouse' bus='ps2'/> <graphics type='vnc' port='-1' keymap='en-us'/> <sound model='es1370'/> </devices> </domain> [Fri, 06 Feb 2009 10:27:16 virt-manager 31523] ERROR (create:735) Unable to complete install 'libvirt.libvirtError internal error unable to start guest: Traceback (most recent call last): File "/usr/share/virt-manager/virtManager/create.py", line 717, in do_install dom = guest.start_install(False, meter = meter) File "/usr/lib/python2.4/site-packages/virtinst/Guest.py", line 926, in start_install return self._do_install(consolecb, meter, removeOld, wait) File "/usr/lib/python2.4/site-packages/virtinst/Guest.py", line 966, in _do_install self.domain = self.conn.createLinux(install_xml, 0) File "/usr/lib64/python2.4/site-packages/libvirt.py", line 973, in createLinux if ret is None:raise libvirtError('virDomainCreateLinux() failed', conn=self) libvirtError: internal error unable to start guest: ' [Fri, 06 Feb 2009 10:27:16 virt-manager 31523] DEBUG (error:76) Uncaught Error: Unable to complete install: 'internal error unable to start guest: ' : Unable to complete install 'libvirt.libvirtError interna l error unable to start guest: Traceback (most recent call last): File "/usr/share/virt-manager/virtManager/create.py", line 717, in do_install dom = guest.start_install(False, meter = meter) File "/usr/lib/python2.4/site-packages/virtinst/Guest.py", line 926, in start_install return self._do_install(consolecb, meter, removeOld, wait) File "/usr/lib/python2.4/site-packages/virtinst/Guest.py", line 966, in _do_install self.domain = self.conn.createLinux(install_xml, 0) File "/usr/lib64/python2.4/site-packages/libvirt.py", line 973, in createLinux if ret is None:raise libvirtError('virDomainCreateLinux() failed', conn=self) libvirtError: internal error unable to start guest: ' ----------------------------------------------- -- Levente "Si vis pacem para bellum!"

4 11

[libvirt] Java binding - JVM crashes .. sometimes
by Daniel Schwager 19 Feb '09

19 Feb '09

Hi, since I updated to the new libvirt-version (CVS snapshot of today), my JVM running my multi-thread application "sometimes" will crashes if I open or close libvirt-connection (on KVM hypervisor). I didn't find out the exact szenario - simple junit tests are running well. But inside my main application (multi tread, multiple fast access to libvirt java interface) will crash the JVM. The crash-report looks like ALWAYS like the following 2 examples. Is there a way to - debug this - make the JNI code more robust ? - make the open/close of libvirt more robust ? I think the JVM crashes, because the libvirt crashes. Is there a way to look inside libvirt to see a "crash" of the native libvirt-prog ? My application runs very well with the old version libvirt-0.4.5. I think, problem starts with >= 0.5. One more: Something, it happens, that a virsh -command on the commandline prints out an error message similar to "Can't connect to hypervisor" (I can't reproduce it at the moment). Multiple repeating the command works well. This happens not often - but sometimes.. Now, the Stacktrace of the crashed JVM ** first ... Instructions: (pc=0x0000000001206351) 0x0000000001206341: c0 48 83 c4 28 5b 41 5c 41 5d 41 5e 41 5f c9 c3 0x0000000001206351: 49 8b 3e e8 47 f7 fc ff 84 c0 74 18 48 8b 15 bc Stack: [0x0000000002430000,0x0000000002531000], sp=0x000000000252f0d0, free space=1020k Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code) V [libjvm.so+0x34a351] V [libjvm.so+0x325201] Java frames: (J=compiled Java code, j=interpreted, Vv=VM code) j org.libvirt.Connect._close(J)I+0 j org.libvirt.Connect.close()V+5 j org.libvirt.Connect.finalize()V+1 v ~StubRoutines::call_stub j java.lang.ref.Finalizer.invokeFinalizeMethod(Ljava/lang/Object;)V+0 j java.lang.ref.Finalizer.runFinalizer()V+45 j java.lang.ref.Finalizer.access$100(Ljava/lang/ref/Finalizer;)V+1 j java.lang.ref.Finalizer$FinalizerThread.run()V+11 v ~StubRoutines::call_stub ... ** Second ... Stack: [0x000000002a061000,0x000000002a162000], sp=0x000000002a15e050, free space=1012k Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code) V [libjvm.so+0x34a351] V [libjvm.so+0x325201] Java frames: (J=compiled Java code, j=interpreted, Vv=VM code) j org.libvirt.Connect._open(Ljava/lang/String;)J+0 j org.libvirt.Connect.<init>(Ljava/lang/String;Z)V+23 j de.dtnet.virtcontroller.server.command.VDomain.open(Ljava/lang/String;)Lorg/libvirt/Connect;+74 ... Viele Gruesse Daniel Schwager ------------------------------------------------------------------- DT Netsolution GmbH - Taläckerstr. 30 - D-70437 Stuttgart Geschäftsführer: Daniel Schwager, Stefan Hörz - HRB Stuttgart 19870 Tel: +49-711-849910-32, Fax: -932 - Mailto:daniel.schwager@dtnet.de

2 5

[libvirt] A problem about libvir
by 刘刚 18 Feb '09

18 Feb '09

Hello, I have a problem for help. I use the libvir library 0.4.2 on Xen 3.2.0, the host OS is Suse 10.2 . I start a windows domain (windows xp). I use the function virDomainAttachDevice() to attach an iSCSI device to the windows domain,but it failed. I can use this function to attach an iSCSI device to a linux domain. How can I attach an iSCSI device to a windows domain ? or libvir doesn't support attach device to windows domain ? thanks a lot! MOBILE: 13622388220 HUAWEI TECHNOLOGIES CO.,LTD. Address: Huawei Industrial Base Bantian Longgang Shenzhen 518129, P.R.China E-mail: liugang8440265(a)huawei.com www.huawei.com

1 0

[libvirt] [PATCH] Remove invalid ATTRIBUTE_UNUSED
by Cole Robinson 18 Feb '09

18 Feb '09

Stumbled on an ATTRIBUTE_UNUSED that is actually used. Patch attached. Thanks, Cole

4 5

[libvirt] [PATCH] Initialize vm def monitor fd
by Cole Robinson 17 Feb '09

17 Feb '09

We weren't properly initializing the monitor fd value in the VM definition structure. If qemu failed to start up, this could lead to closing stdin, which made all sorts of poo hit the fan. The attached patch fixes this. Thanks, Cole

3 4

[libvirt] Bug in qemud/Makefile.in, compiling CVS-snapshot failed.
by Daniel Schwager 17 Feb '09

17 Feb '09

Hi, i checked out the current CVS snapshot (20090217-1530GMT+1), but compiling failed: sh autogen.sh make rpm .... make[4]: Leaving directory `/root/rpmbuild/BUILD/libvirt-0.6.99/src' make[3]: Leaving directory `/root/rpmbuild/BUILD/libvirt-0.6.99/src' Making all in qemud make[3]: Entering directory `/root/rpmbuild/BUILD/libvirt-0.6.99/qemud' Makefile:1284: *** missing separator. Stop. make[3]: Leaving directory `/root/rpmbuild/BUILD/libvirt-0.6.99/qemud' make[2]: *** [all-recursive] Error 1 make[2]: Leaving directory `/root/rpmbuild/BUILD/libvirt-0.6.99' ... Please adapt the qemud/Makefile.in to use TAB instead of spaces in the "remote_protocol.c: remote_protocol.h" make-target. regards Danny

2 1

[libvirt] [PATCH] Fix daemon TCP listen cleanup
by Cole Robinson 17 Feb '09

17 Feb '09

Just looking through the code, I stumbled on a bug in a cleanup routine in the daemon. Patch attached. Thanks, Cole

3 3

[libvirt] [PATCH] Detect bridge name collisions when defining a virtual network
by Cole Robinson 17 Feb '09

17 Feb '09

The attached patch is a partial fix for rhbz 479622. If a virtual network is defined with an explicit bridge name, make sure it doesn't collide with other virtual network bridge names. Thanks, Cole

2 1

[libvirt] [PATCH 1/4] fix problem with MKDIR_P vs mkdir_p
by Maximilian Wilhelm 17 Feb '09

17 Feb '09

From: Matthias Bolte <photon(a)upb.de> configure defines mkdir_p but src/Makefile.am uses MKDIR_P --- src/Makefile.am | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 9d934b4..eff9039 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -589,6 +589,8 @@ endif endif EXTRA_DIST += $(LXC_CONTROLLER_SOURCES) +MKDIR_P = $(mkdir_p) + install-exec-local: $(MKDIR_P) "$(DESTDIR)$(localstatedir)/cache/libvirt" $(MKDIR_P) "$(DESTDIR)$(localstatedir)/lib/libvirt/images" -- 1.5.6.5

3 14

[libvirt] Network Configuration question
by Remko Nolten 17 Feb '09

17 Feb '09

Hi! For a shared virtual hosting project with some friends we need a pretty specialized network configuration. Because we have virtually no time for experimenting (no pun intended), and the hosting organization has no experience with libvirt/KVM configurations they suggested to try and ask here. So, this is the situation: We have a server with one physical connection. Each user gets one virtual machine with its own IP-address (we have our own ip-range). The hosting organization gives us one "main" address 'A' with netmask 255.255.255.0 (/24) and a default gateway for our host machine. Besides this we get a number of addresses B1, B2, etc. with netmask 255.255.255.255 (/32) and without a default gateway. The switch just routes the traffic to our server for each ip-address we own (A and Bn). According to our hosting organization, the normal solution is to configure a loopback interface for each of the ip-addresses on the server so you can configure your software just to use one of the addresses. But we are not sure how this will work out in our virtual environment. Our intuition tells us we need to use the routing network forwarding mode, but when we bring the server to the data center we don't want to have any surprises. :) Here at home I don't have to possibility to create similar circumstances as in the data center due to some restriction from my ISP, so I hope someone can tell me if our intuition is correct or that we need to use some other method. Thanks in advance! -- Remko Nolten Tel: 06-45600767 E-mail: remko(a)nolten.nu

3 4

[libvirt] [PATCH] Don't check volume format for lvm backing store
by Cole Robinson 17 Feb '09

17 Feb '09

With the recently added COW support, we were trying to validate the passed logical volume's format, when there won't ever be one pulled from the xml (logical volumes don't have any valid format values). Just remove this check, and let any validation in this manner be done by the actual call to 'lvcreate'. Thanks, Cole

3 4

[libvirt] [PATCH] Fix generating python bindings
by Cole Robinson 17 Feb '09

17 Feb '09

The recent API additions virSaveLastError and virFreeError upset the python bindings generator. Add a rule to explicitly skip them for the bindings, since (as far as I can tell) the libvirtError class provides everything we need. Thanks, Cole

3 4

[libvirt] [PATCH] Fix virsh {net,pool}-edit
by Cole Robinson 17 Feb '09

17 Feb '09

The dumpxml commands for networks and pools don't support any flag arguments, and in fact explictly fail if flags != 0. This is not the case for vm dumpxml though, and flags were added to the base 'edit' implementation in virsh recently. The net and pool derivatives were not addressing this difference, so any net-edit or pool-edit attempt currently gives an error like: Network error : invalid argument in virNetworkGetXMLDesc The attached patch is one way to fix this. Thanks to Charles Duffy for the report. - Cole

3 7

[libvirt] Per-VM access control
by Jan Kasprzak 17 Feb '09

17 Feb '09

Hello, is it possible to run libvirt as a "hosting-like" environment? we would like to provide virtual machines for our users, but we would like them to be able to reset/reboot/poweroff only their own VMs, connect to the serial console of their own VMs only, and even maybe connect to the graphical console of their own VMs. Is it possible with libvirt, and without giving them shell access to the hosting machine? For the serial console, I thought about creating a ssh-only account with hardcoded "virsh console <their_machine_name>" command, but "virsh console" can be escaped from using ^], so this is not secure - this way they would be able to get access to other VMs as well. Thanks, -Yenya -- | Jan "Yenya" Kasprzak <kas at {fi.muni.cz - work | yenya.net - private}> | | GPG: ID 1024/D3498839 Fingerprint 0D99A7FB206605D7 8B35FCDE05B18A5E | | http://www.fi.muni.cz/~kas/ Journal: http://www.fi.muni.cz/~kas/blog/ | >> If you find yourself arguing with Alan Cox, you’re _probably_ wrong. << >> --James Morris in "How and Why You Should Become a Kernel Hacker" <<

3 2

[libvirt] Compilation Errors
by Russell 16 Feb '09

16 Feb '09

I'm trying to compile libvirt 0.6.0 on Gentoo, but keep encountering the following error: network_driver.c:72: error: expected specifier-qualifier-list before 'brControl' network_driver.c: In function 'networkFindActiveConfigs': <snip - just a bunch of 'struct network_driver' has no member named * > network_driver.c:1382: error: 'struct network_driver' has no member named 'networkConfigDir' network_driver.c:1384: error: 'struct network_driver' has no member named 'networkAutostartDir' network_driver.c:1390: error: 'struct network_driver' has no member named 'networkAutostartDir' network_driver.c:1391: error: 'struct network_driver' has no member named 'networkAutostartDir' make[3]: *** [network_driver.lo] Error 1 make[3]: Leaving directory `/home/russell/libvirt/libvirt-0.6.0/src' make[2]: *** [all] Error 2 make[2]: Leaving directory `/home/russell/libvirt/libvirt-0.6.0/src' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/home/russell/libvirt/libvirt-0.6.0' make: *** [all] Error 2 Every error following the first one refers to networkConfigDir, networkAutostartDir, or logDir, all listed after brControl in the definition of network_driver. What looks to me like the same error has been reported against 0.5.1 here (I haven't tried it myself): http://bugs.gentoo.org/show_bug.cgi?id=254568 My configuration options: ./configure --prefix=/usr --host=i686-pc-linux-gnu --mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share --sysconfdir=/etc --localstatedir=/var/lib --with-avahi --without-storage-iscsi --without-storage-lvm --without-lxc --with-hal --without-openvz --without-storage-disk --without-sasl --without-selinux --without-uml --without-xen --without-qemu --without-devkit --without-polkit --with-remote --disable-iptables-lokkit --localstatedir=/var --with-remote-pid-file=/var/run/libvirtd.pid --build=i686-pc-linux-gnu If other info would help resolve this I'd be happy to try and provide it. Thanks, -- Russell Haering System Administrator OSU Open Source Lab

3 4

[libvirt] [PATCH] Allow off-line removal of devices via xend
by john.levon＠sun.com 16 Feb '09

16 Feb '09

# HG changeset patch # User john.levon(a)sun.com # Date 1233765613 28800 # Node ID bda41ea0cbbdea409447686c30b7afb10b9cae85 # Parent e6b17082b9b9440ce14ad76bd2f4c003ae2404db Allow off-line removal of devices via xend We must avoid xenstore if the domain isn't running. For disks, this works in all xend versions; for NICs, however, this requires a change in netif.py to allow matching by MAC address. Preferring the device ID but falling back to the device ref works best with all versions of xend. Signed-off-by: John Levon <john.levon(a)sun.com> diff --git a/src/xend_internal.c b/src/xend_internal.c --- a/src/xend_internal.c +++ b/src/xend_internal.c @@ -92,11 +92,17 @@ xenDaemonFormatSxprNet(virConnectPtr con int xendConfigVersion, int isAttach); static int -virDomainXMLDevID(virDomainPtr domain, - virDomainDeviceDefPtr dev, - char *class, - char *ref, - int ref_len); +virDomainDevRef(virDomainPtr domain, + virDomainDeviceDefPtr dev, + char *class, + char *ref, + int ref_len); +static int +virDomainDevID(virDomainPtr domain, + int type, + const char *ref, + char *devid, + int devid_len); #endif #define virXendError(conn, code, fmt...) \ @@ -3857,7 +3863,7 @@ xenDaemonAttachDevice(virDomainPtr domai virDomainDeviceDefPtr dev = NULL; virDomainDefPtr def = NULL; virBuffer buf = VIR_BUFFER_INITIALIZER; - char class[8], ref[80]; + char class[8], ref[80], devid[80]; if ((domain == NULL) || (domain->conn == NULL) || (domain->name == NULL)) { virXendError((domain ? domain->conn : NULL), VIR_ERR_INVALID_ARG, @@ -3913,15 +3919,24 @@ xenDaemonAttachDevice(virDomainPtr domai sexpr = virBufferContentAndReset(&buf); - if (virDomainXMLDevID(domain, dev, class, ref, sizeof(ref))) { + devid[0] = '\0'; + + if (virDomainDevRef(domain, dev, class, ref, sizeof(ref)) == -1) + goto cleanup; + + if (domain->id > 0 && + virDomainDevID(domain, dev->type, ref, devid, sizeof(devid)) != -1) { + VIR_DEBUG("device_configure(ref = %s, devid = %s): %s", + ref, devid, sexpr); + /* device exists, attempt to modify it */ + ret = xend_op(domain->conn, domain->name, "op", "device_configure", + "config", sexpr, "dev", devid, NULL); + } else { + VIR_DEBUG("device_create(ref = %s, devid = %s): %s", + ref, devid, sexpr); /* device doesn't exist, define it */ ret = xend_op(domain->conn, domain->name, "op", "device_create", "config", sexpr, NULL); - } - else { - /* device exists, attempt to modify it */ - ret = xend_op(domain->conn, domain->name, "op", "device_configure", - "config", sexpr, "dev", ref, NULL); } cleanup: @@ -3944,7 +3959,7 @@ xenDaemonDetachDevice(virDomainPtr domai xenDaemonDetachDevice(virDomainPtr domain, const char *xml) { xenUnifiedPrivatePtr priv; - char class[8], ref[80]; + char class[8], ref[80], devid[80]; virDomainDeviceDefPtr dev = NULL; virDomainDefPtr def = NULL; int ret = -1; @@ -3975,11 +3990,40 @@ xenDaemonDetachDevice(virDomainPtr domai def, xml, VIR_DOMAIN_XML_INACTIVE))) goto cleanup; - if (virDomainXMLDevID(domain, dev, class, ref, sizeof(ref))) + if (dev->type != VIR_DOMAIN_DEVICE_NET && + dev->type != VIR_DOMAIN_DEVICE_DISK) { + virXendError(domain->conn, VIR_ERR_INTERNAL_ERROR, + _("can't detach device of type %d"), dev->type); goto cleanup; + } + + /* + * First acquire a static reference to the device (MAC address or + * destination disk). We'll use this if the domain isn't running, + * otherwise we'll rely upon the XenStore devid. + */ + + if (virDomainDevRef(domain, dev, class, ref, sizeof(ref)) == -1) { + virXendError(domain->conn, VIR_ERR_INTERNAL_ERROR, + _("can't detach device: not found ")); + goto cleanup; + } + + if (domain->id >= 0) { + if (virDomainDevID(domain, dev->type, ref, devid, sizeof(devid))) + virXendError(domain->conn, VIR_ERR_INTERNAL_ERROR, + _("can't detach device: not found ")); + goto cleanup; + } else { + strncpy(devid, ref, 80); + } + + VIR_DEBUG("device_destroy(type = %s, ref = %s, devid = %s)", + class, ref, devid); ret = xend_op(domain->conn, domain->name, "op", "device_destroy", - "type", class, "dev", ref, "force", "0", "rm_cfg", "1", NULL); + "type", class, "dev", devid, "force", "0", + "rm_cfg", "1", NULL); cleanup: virDomainDefFree(def); @@ -5501,12 +5545,48 @@ error: /** - * virDomainXMLDevID: + * virDomainXMLDevRef: * @domain: pointer to domain object * @dev: pointer to device config object * @class: Xen device class "vbd" or "vif" (OUT) * @ref: Xen device reference (OUT) * + * Return the class (vbd/vif) and reference (MAC address / disk + * destination) of the given device. + * + * Returns 0 in case of success, -1 in case of failure. + */ +static int +virDomainDevRef(virDomainPtr domain, + virDomainDeviceDefPtr dev, + char *class, + char *ref, + int ref_len) +{ + if (dev->type == VIR_DOMAIN_DEVICE_DISK) { + if (dev->data.disk->dst == NULL) + return -1; + strncpy(ref, dev->data.disk->dst, ref_len); + strcpy(class, "vbd"); + } else if (dev->type == VIR_DOMAIN_DEVICE_NET) { + virFormatMacAddr(dev->data.net->mac, ref); + strcpy(class, "vif"); + } else { + virXendError(NULL, VIR_ERR_NO_SUPPORT, + _("no support for device type %d"), dev->type); + return -1; + } + + return 0; +} + +/** + * virDomainXMLDevID: + * @domain: pointer to domain object + * @class: either 'vbd' or 'vif' + * @ref: Xen device reference + * @devid: Xen device ID (OUT) + * * Set class according to XML root, and: * - if disk, copy in ref the target name from description * - if network, get MAC address from description, scan XenStore and @@ -5515,54 +5595,41 @@ error: * Returns 0 in case of success, -1 in case of failure. */ static int -virDomainXMLDevID(virDomainPtr domain, - virDomainDeviceDefPtr dev, - char *class, - char *ref, - int ref_len) +virDomainDevID(virDomainPtr domain, + int type, + const char *ref, + char *devid, + int devid_len) { xenUnifiedPrivatePtr priv = domain->conn->privateData; - char *xref; - - if (dev->type == VIR_DOMAIN_DEVICE_DISK) { - strcpy(class, "vbd"); - if (dev->data.disk->dst == NULL) - return -1; - xenUnifiedLock(priv); - xref = xenStoreDomainGetDiskID(domain->conn, domain->id, - dev->data.disk->dst); - xenUnifiedUnlock(priv); - if (xref == NULL) - return -1; - - strncpy(ref, xref, ref_len); - free(xref); - ref[ref_len - 1] = '\0'; - } else if (dev->type == VIR_DOMAIN_DEVICE_NET) { - char mac[30]; - virDomainNetDefPtr def = dev->data.net; - snprintf(mac, sizeof(mac), "%02x:%02x:%02x:%02x:%02x:%02x", - def->mac[0], def->mac[1], def->mac[2], - def->mac[3], def->mac[4], def->mac[5]); - - strcpy(class, "vif"); - - xenUnifiedLock(priv); - xref = xenStoreDomainGetNetworkID(domain->conn, domain->id, - mac); - xenUnifiedUnlock(priv); - if (xref == NULL) - return -1; - - strncpy(ref, xref, ref_len); - free(xref); - ref[ref_len - 1] = '\0'; + char *id = NULL; + + if (domain->id < 0) { + virXendError(domain->conn, VIR_ERR_INTERNAL_ERROR, + _("devid not available for shutdown domain")); + return -1; + } + + xenUnifiedLock(priv); + + if (type == VIR_DOMAIN_DEVICE_DISK) { + id = xenStoreDomainGetDiskID(domain->conn, domain->id, ref); + + } else if (type == VIR_DOMAIN_DEVICE_NET) { + id = xenStoreDomainGetNetworkID(domain->conn, domain->id, ref); } else { virXendError(NULL, VIR_ERR_NO_SUPPORT, - "%s", _("hotplug of device type not supported")); + _("no support for device type %d"), type); + } + + xenUnifiedUnlock(priv); + + if (id == NULL) return -1; - } - + + strncpy(devid, id, devid_len); + VIR_FREE(id); + devid[devid_len - 1] = '\0'; return 0; }

7 13

[libvirt] Libvirt /proc/cpuinfo processing fails on Linux/Sparc
by Richard W.M. Jones 14 Feb '09

14 Feb '09

Below is what /proc/cpuinfo looks like on an Ultrasparc T1 running Linux. I haven't looked into it in detail yet, but the report from Dennis Gilmore is that this breaks every libvirt command. Presumably we are parsing /proc/cpuinfo at libvirt startup ... (Initially reported by Dennis Gilmore) Rich. cpu : UltraSparc T1 (Niagara) fpu : UltraSparc T1 integrated FPU prom : OBP 4.29.0.a 2008/09/15 11:59 type : sun4v ncpus probed : 32 ncpus active : 32 D$ parity tl1 : 0 I$ parity tl1 : 0 Cpu0ClkTck : 000000003b9aca00 Cpu1ClkTck : 000000003b9aca00 Cpu2ClkTck : 000000003b9aca00 Cpu3ClkTck : 000000003b9aca00 Cpu4ClkTck : 000000003b9aca00 Cpu5ClkTck : 000000003b9aca00 Cpu6ClkTck : 000000003b9aca00 Cpu7ClkTck : 000000003b9aca00 Cpu8ClkTck : 000000003b9aca00 Cpu9ClkTck : 000000003b9aca00 Cpu10ClkTck : 000000003b9aca00 Cpu11ClkTck : 000000003b9aca00 Cpu12ClkTck : 000000003b9aca00 Cpu13ClkTck : 000000003b9aca00 Cpu14ClkTck : 000000003b9aca00 Cpu15ClkTck : 000000003b9aca00 Cpu16ClkTck : 000000003b9aca00 Cpu17ClkTck : 000000003b9aca00 Cpu18ClkTck : 000000003b9aca00 Cpu19ClkTck : 000000003b9aca00 Cpu20ClkTck : 000000003b9aca00 Cpu21ClkTck : 000000003b9aca00 Cpu22ClkTck : 000000003b9aca00 Cpu23ClkTck : 000000003b9aca00 Cpu24ClkTck : 000000003b9aca00 Cpu25ClkTck : 000000003b9aca00 Cpu26ClkTck : 000000003b9aca00 Cpu27ClkTck : 000000003b9aca00 Cpu28ClkTck : 000000003b9aca00 Cpu29ClkTck : 000000003b9aca00 Cpu30ClkTck : 000000003b9aca00 Cpu31ClkTck : 000000003b9aca00 MMU Type : Hypervisor (sun4v) State: CPU0: online CPU1: online CPU2: online CPU3: online CPU4: online CPU5: online CPU6: online CPU7: online CPU8: online CPU9: online CPU10: online CPU11: online CPU12: online CPU13: online CPU14: online CPU15: online CPU16: online CPU17: online CPU18: online CPU19: online CPU20: online CPU21: online CPU22: online CPU23: online CPU24: online CPU25: online CPU26: online CPU27: online CPU28: online CPU29: online CPU30: online CPU31: online -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://et.redhat.com/~rjones/virt-top

2 6

[libvirt] Libvirt for RHEL4 update4
by Gavin Gong 14 Feb '09

14 Feb '09

Hi Guys, We are eagerly trying to deploy libvirt on a production environment based on RHEL4 U4, but unfortunately it seems that for RHEL this API is only available for version5, we can't find any libvirt packages for RHEL4 U4, can you give us some advise for this situation? Thanks. Gavin Gavin Gong 3rd Line Engineer - Server/Database Technology DD: +44(0) 207 517 6581 M: +44(0) 7982 132 869 T: +44(0) 845 459 1111 F: +44(0) 207 517 6501 E: gavin.gong(a)controlcircle.com <mailto:gavin.gong@controlcircle.com> Data Storage Network Security Moorfoot House, 221 Marsh Wall Managed Connectivity Dedicated Hosting London E14 9FH Managed Services http://www.controlcircle.com <http://www.controlcircle.com/> Click here <http://www.controlcircle.com/ProductsNServices/Email-Privacy-and-confid entiality-statement> to view our privacy & confidentiality statement P Please don't print this e-mail unless you really need to.

2 2

[libvirt] [PATCH] Fix migration for 3.3 xend
by John Levon 14 Feb '09

14 Feb '09

# HG changeset patch # User John Levon <john.levon(a)sun.com> # Date 1234535031 28800 # Node ID 3b0d2047df2c53ff2994d2bff4b1123110626ee2 # Parent 0c02b55855c7a3bfa1135887ffb1763ef29179e5 Fix migration for 3.3 xend xend grew a couple of new options for the migration method. As they're ignored on older xend versions, always pass them. Signed-off-by: John Levon <john.levon(a)sun.com> diff --git a/src/xend_internal.c b/src/xend_internal.c --- a/src/xend_internal.c +++ b/src/xend_internal.c @@ -4292,6 +4292,8 @@ xenDaemonDomainMigratePerform (virDomain "destination", hostname, "live", live, "port", port, + "node", "-1", + "ssl", "0", "resource", "0", /* required, xend ignores it */ NULL); VIR_FREE (hostname);

3 2

[libvirt] [PATCH] libvirt.spec patch to fix some rpmlint warnings/errors
by Richard W.M. Jones 14 Feb '09

14 Feb '09

With this patch we remove some of the easier rpmlint warnings and errors. It is by no means rpmlint clean after applying this patch, but the remaining warnings and errors can be ignored. FWIW this is for the libvirt merge review: https://bugzilla.redhat.com/show_bug.cgi?id=226055 I'm not sure about the patch to libvirt.init.in, but rpmlint is quite insistent that we need this, or else we shouldn't start libvirtd by default. Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into Xen guests. http://et.redhat.com/~rjones/virt-p2v

2 6

[libvirt] [PATCH 0/3] Fix aliasing rules warnings with gcc-4.4
by Mark McLoughlin 14 Feb '09

14 Feb '09

Hi, It seems gcc's strict aliasing rules got stricter with gcc-4.4. The basic rule is that two pointers of different types can't be used to reference the same address in memory. One exception is using a char* and another is when different types are members of a union. I've used unions to fix all the warnings I see with current CVS HEAD. I can't say I like the solution all that much, so if anyone has better ideas ... Cheers, Mark.

2 7

[libvirt] [PATCH] avoid two test failures induced by today's error-reporting changes
by Jim Meyering 14 Feb '09

14 Feb '09

I'm applying these fixes to avoid "make check" failures: >From f41517a4250db0961482e097813eb39da5bea963 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Mon, 9 Feb 2009 16:25:36 +0100 Subject: [PATCH] avoid two test failures induced by today's error-reporting changes * tests/cpuset: Adjust expected diagnostic to match new behavior. * tests/undefine: Likewise. --- tests/cpuset | 4 ++-- tests/undefine | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/cpuset b/tests/cpuset index 75303e3..eeb0ee2 100755 --- a/tests/cpuset +++ b/tests/cpuset @@ -1,7 +1,7 @@ #!/bin/sh # ensure that defining with an invalid vCPU cpuset elicits a diagnostic -# Copyright (C) 2008 Free Software Foundation, Inc. +# Copyright (C) 2008-2009 Free Software Foundation, Inc. # This program is free software: you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -36,8 +36,8 @@ sed "s/vcpu>/vcpu cpuset='aaa'>/" xml > xml-invalid || fail=1 # Require failure and a diagnostic. virsh --connect test:///default define xml-invalid > out 2>&1 && fail=1 cat <<\EOF > exp || fail=1 -libvir: Domain Config error : failed Xen syscall topology cpuset syntax error error: Failed to define domain from xml-invalid +error: failed Xen syscall topology cpuset syntax error EOF compare exp out || fail=1 diff --git a/tests/undefine b/tests/undefine index 48e8356..fafdae7 100755 --- a/tests/undefine +++ b/tests/undefine @@ -1,7 +1,7 @@ #!/bin/sh # exercise virsh's "undefine" command -# Copyright (C) 2008 Free Software Foundation, Inc. +# Copyright (C) 2008-2009 Free Software Foundation, Inc. # This program is free software: you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -29,8 +29,8 @@ fail=0 virsh -q -c test:///default undefine test > out 2>&1 test $? = 1 || fail=1 cat <<\EOF > exp || fail=1 -libvir: Test error : internal error Domain 'test' is still running error: Failed to undefine domain test +error: internal error Domain 'test' is still running EOF compare exp out || fail=1 -- 1.6.2.rc0.173.g5e148

3 2

[libvirt] Domain comment/description string?
by Jan Kasprzak 13 Feb '09

13 Feb '09

Hello, I use KVM+qemu for testing various distributions and playing with different versions of software. Now I would like to migrate my virtual machines to libvirt. One of the problems is that I would like to have some sort of comment or description of the machine, which would be displayed in "virsh list" or in virt-manager together with the machine hostname. Example: <name>rei</name> <comment>Fedora rawhide/32bit</comment> or <name>konata</name> <comment>Gentoo x86_64 with KDE 4</comment> Does the libvirt XML format support something like this? Embedding comment inside the <name>...</name> tag does not work. Does libvirt support something like that? Thanks, -Yenya -- | Jan "Yenya" Kasprzak <kas at {fi.muni.cz - work | yenya.net - private}> | | GPG: ID 1024/D3498839 Fingerprint 0D99A7FB206605D7 8B35FCDE05B18A5E | | http://www.fi.muni.cz/~kas/ Journal: http://www.fi.muni.cz/~kas/blog/ | >> If you find yourself arguing with Alan Cox, you’re _probably_ wrong. << >> --James Morris in "How and Why You Should Become a Kernel Hacker" <<

1 0

[libvirt] libvirtd and LVM snapshots
by Nick Moffitt 13 Feb '09

13 Feb '09

I'm working on an existing system that creates, manages, and destroys Xen guests on a pool of host systems, and I use LVM copy-on-write snapshots to keep creation rapid. http://libvirt.org/storage.html describes logical volume pools, for which you simply supply the name of a volume group and it allocates volumes from that. By my reading, it appears one can even provide a list of block devices and they will be carved into extents and pooled into a VG for you. Is there any interface to libvirtd that allows it to create volumes that are snapshots of existing volumes? If not, does anyone have advice for doing so manually in a way that plays smoothly with libvirt? -- Support your droogs! Nick Moffitt nick(a)zork.net

3 6