June 2007 - Devel - libvirt List Archives

[Libvir] Solaris patches applied
by Richard W.M. Jones 15 Jun '07

15 Jun '07

I applied the easy ones: * src/internal.h, src/virsh.c: Replace _N with N_ so that Solaris builds work (Mark Johnson). * src/virsh.c: Add a couple of missing error messages (Mark Johnson). * python/types.c: Fix NULL pointer deref on DEBUG build (Mark Johnson). * src/virsh.c: Spelling fix (Mark Johnson). I can't test if it works on Solaris, but it still builds on Linux. Now to look at the last patch you sent ... Thanks for your contribution to libvirt. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903

1 0

[Libvir] [PATCH] vcpuinfo message
by Mark Johnson 15 Jun '07

15 Jun '07

Another requested error message. This prints out a message if the vcpuinfo failed because the domain was shutdown. same comment as previous patch about I18N. Mark

2 1

[Libvir] [PATCH] Spelling fix
by Mark Johnson 15 Jun '07

15 Jun '07

Hi all, This is the first of 10 or 11 patches I'll be submitting which gets libvirt compiling/working on a Solaris dom0. Also some minor generic bug fixing.. Sorry it took me so long from the Xen Summit.. Starting with a very simple one. :-) As I test them on the cvs tree on Fedora, I'll submit them.. So they'll trickle in over the next couple of days. A couple of them will probably require some discussion and changes. I'm applying the patches with the following # patch -t -s -p1 -i ../patches/spelling on todays CVS gate and tested on a fedora 7 dom0 (LD_PRELOAD=src/.libs/libvirt.so src/.libs/virsh) Thanks, Mark

3 2

[Libvir] [PATCH] null pointer fix on debug build
by Mark Johnson 15 Jun '07

15 Jun '07

this fixes a null pointer dereference in printf on a DEBUG build. Mark

2 1

[Libvir] [PATCH] fix the Japanese messages
by Saori Fukuta 14 Jun '07

14 Jun '07

Hi, We are making a review of the Japanese messages. And we fix Japanese help messages first. Signed-off-by: Saori Fukuta <fukuta.saori(a)jp.fujitsu.com>, Minoru Takata <takata.minoru(a)jp.fujitsu.com> Best regards, Saori Fukuta Minoru Takata

4 5

[Libvir] no vfb for paravirt guest on RHEL 5 and strange args
by Glen Deem 13 Jun '07

13 Jun '07

Hi all, I'm creating a fairy simple paravirt machine under RHEL 5 (Xen 3.0.3, pygrub 0.6). A machine gets created but I see two problems: 1. no graphics console gets enabled (so RedHat VMM does not open it) so I cannot connect to it with vncviewer (am I naive to use vfb fpr a paravirt domU? - libvirt uses it, right?); 2. when I check what config has been used to create the domain (in /var/log/xen/xend.log) I see arguments ("args" or "extra") picked up from a virtual machine created a while age, my present "extra" parameter is ignored. I did regenerate xenstored/tdb and rebooted, still those args appear, drives my nuts :-). I'm actually after the graphics console, but I think both problems are related. Could anybody advise why I get no proper vfb setup (I'd expect a vnc-port vaue appearing in the xen store when it setup properly) and why I get those old args? Thanks in advance, Deem P.S. xm config ============ name = "para-2" memory = "256" disk = [ 'file:/var/lib/para-2.img,hda,w' ] vif = [ 'bridge=xenbr0' ] vfb = ['type=vnc, vncunused=1'] bootloader='/usr/bin/pygrub' vcpus=1 on_reboot = 'restart' on_crash = 'restart' extra = 'ignored' from /var/log/xen/xend.log: ================== [2007-06-12 17:13:56 xend.XendDomainInfo 5445] DEBUG (XendDomainInfo:940) XendDomainInfo.handleShutdownWatch [2007-06-12 17:41:57 xend.XendDomainInfo 5445] DEBUG (XendDomainInfo:190) XendDomainInfo.create(['vm', ['name', 'para-2'], ['memory', '256'], ['on_reboot', 'restart'], ['on_crash', 'restart'], ['vcpus', 1], ['bootloader', '/usr/bin/pygrub'], ['image', ['linux', ['ramdisk', '/var/lib/xen/initrd.NMeE1x'], ['kernel', '/var/lib/xen/vmlinuz.7QoaTW'], ['args', 'nosplash quiet rw acpi=on XXHOST=localhost.localdomain XXLDAP=127.0.0.1 resume2=swap:/dev/mapper/XxxxxxVG-swap vga=791 root=/dev/XxxxxxxVG/root']]], ['device', ['vbd', ['uname', 'file:/var/lib/para-2.img'], ['dev', 'hda'], ['mode', 'w']]], ['device', ['vif', ['bridge', 'xenbr0']]], ['device', ['vkbd']], ['device', ['vfb', ['vncunused', '1'], ['type', 'vnc'], ['display', ':0.0'], ['xauthority', '/root/.xauthfLRNzX']]]])

1 0

[Libvir] New vs old-style hypercalls
by Richard W.M. Jones 12 Jun '07

12 Jun '07

In xen_internal.c we've got code which claims to sniff out whether we are using new-style hypercall ioctls or old-style hypercall ioctls. hc.op = __HYPERVISOR_xen_version; hc.arg[0] = (unsigned long) XENVER_version; hc.arg[1] = 0; cmd = IOCTL_PRIVCMD_HYPERCALL; ret = ioctl(fd, cmd, (unsigned long) &hc); if ((ret != -1) && (ret != 0)) { #ifdef DEBUG fprintf(stderr, "Using new hypervisor call: %X\n", ret); #endif hv_version = ret; xen_ioctl_hypercall_cmd = cmd; goto detect_v2; } /* * check if the old hypercall are actually working */ v0_hc.op = __HYPERVISOR_xen_version; v0_hc.arg[0] = (unsigned long) XENVER_version; v0_hc.arg[1] = 0; cmd = _IOC(_IOC_NONE, 'P', 0, sizeof(v0_hypercall_t)); ret = ioctl(fd, cmd, (unsigned long) &v0_hc); But on 64 bit platforms (not 32 bit) cmd will be identical, so we'll just be trying the same ioctl twice. From <xen/linux/privcmd.h>: typedef struct privcmd_hypercall { __u64 op; __u64 arg[5]; } privcmd_hypercall_t; #define IOCTL_PRIVCMD_HYPERCALL \ _IOC(_IOC_NONE, 'P', 0, sizeof(privcmd_hypercall_t)) From src/xen_internal.c: typedef struct v0_hypercall_struct { unsigned long op; unsigned long arg[5]; } v0_hypercall_t; cmd = _IOC(_IOC_NONE, 'P', 0, sizeof(v0_hypercall_t)); On 64 bit platforms, both structures will be the same size. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903

2 1

[Libvir] about qemu IDE BMDMAState
by Atsushi SAKAI 12 Jun '07

12 Jun '07

Hi, Rich and Dan Following patch will include on Fedora7 updates? http://lists.xensource.com/archives/html/xen-devel/2007-05/msg00564.html This issue also effects Windows FV. Thanks Atsushi SAKAI

3 3

[Libvir] Merging remote patch
by Richard W.M. Jones 11 Jun '07

11 Jun '07

I'm merging the remote patch into libvirt CVS. Things may break, although I'm hoping to keep any brokenness to a minimum. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903

2 3

[Libvir] Suggested list of files to rename
by Richard W.M. Jones 11 Jun '07

11 Jun '07

I've accumulated a collection of files in libvirt which I think should be renamed. This file is in CVS, called 'RENAMES', and attached below. What do you think? Rich. # Suggested list of file renames. # # File renames don't normally go into patches because they make # the patches much harder to read, so list them here instead. # # $Id: RENAMES,v 1.1 2007/06/11 12:25:06 rjones Exp $ # Clearer naming scheme after Xen-unified patch went in. src/xen_internal.c src/xen_internal_hv.c src/xen_internal.h src/xen_internal_hv.h src/proxy_internal.c src/xen_internal_proxy.c src/proxy_internal.h src/xen_internal_proxy.h src/xend_internal.c src/xen_internal_xend.c src/xend_internal.h src/xen_internal_xend.h src/xm_internal.c src/xen_internal_inactive.c src/xm_internal.h src/xen_internal_inactive.h src/xs_internal.c src/xen_internal_xenstore.c src/xs_internal.h src/xen_internal_xenstore.h src/xen_unified.c src/xen_internal.c src/xen_unified.h src/xen_internal.h # Test driver should really be called test_internal. src/test.c src/test_internal.c src/test.h src/test_internal.h # This would be better: src/*_internal*.c src/*_driver*.c src/*_internal*.h src/*_driver*.h # Qemud is now the qemud + remote driver. qemud/protocol.x qemud/qemud_protocol.x qemud/* remote/* -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903

2 1

Réf. : [Libvir] Release of libvirt-0.2.3
by jean-paul.pigache＠bull.net 11 Jun '07

11 Jun '07

Daniel, Good to see all these enhencements in this version. Is there any chance to have this libvirt 0.2.3 in RHEL5.1 ? Jean-Paul Daniel Veillard <veillard(a)redhat.com> Envoyé par : libvir-list-bounces(a)redhat.com 08/06/2007 13:42 Veuillez répondre à veillard Pour : libvir-list(a)redhat.com cc : Objet : [Libvir] Release of libvirt-0.2.3 Nearly 2 months without a release, it was clearly time, a lot of changes had accumulated in CVS. Available from ftp://libvirt.org/libvirt/ * Documentation: - documentation for upcoming remote access (Richard Jones) - virConnectNumOfDefinedDomains doc (Jan Michael) - virsh help messages for dumpxml and net-dumpxml (Chris Wright) * Bug fixes: - RelaxNG schemas regexp fix (Robin Green) - RelaxNG arch bug (Mark McLoughlin) - large buffers bug fixes (Shigeki Sakamoto) - error on out of memory condition (Shigeki Sakamoto) - virshStrdup fix - non-root driver when using Xen bug (Richard Jones) - use --strict-order when running dnsmasq (Daniel Berrange) - virbr0 weirdness on restart (Mark McLoughlin) - keep connection error messages (Richard Jones) - increase QEmu read buffer on help (Daniel Berrange) - rpm dependance on dnsmasq (Daniel Berrange) - fix XML boot device syntax (Daniel Berrange) - QEmu memory bug (Daniel Berrange) - memory leak fix (Masayuki Sunou) - fix compiler flags (Richard Jones) - remove type ioemu on recent Xen HVM for paravirt drivers (Saori Fukuta) - uninitialized string bug (Masayuki Sunou) - allow init even if the daemon is not running - XML to config fix (Daniel Berrange) * Improvements: - add a special error class for the test module (Richard Jones) - virConnectGetCapabilities on proxy (Richard Jones) - allow network driver to decline usage (Richard Jones) - extend error messages for upcoming remote access (Richard Jones) - on_reboot support for QEmu (Daniel Berrange) - save daemon output in a log file (Daniel Berrange) - xenXMDomainDefineXML can override guest config (Hugh Brock) - add attach-device and detach-device commands to virsh (Masayuki Sunou and Mark McLoughlin and Richard Jones) - make virGetVersion case insensitive and Python bindings (Richard Jones) - new scheduler API (Atsushi SAKAI) - localizations updates - add logging option for virsh (Nobuhiro Itou) - allow arguments to be passed to bootloader (Hugh Brock) - increase the test suite (Daniel Berrange and Hugh Brock) * Cleanups: - Remove VIR_DRV_OPEN_QUIET (Richard Jones) - disable xm_internal.c for Xen > 3.0.3 (Daniel Berrange) - unused fields in _virDomain (Richard Jones) - export __virGetDomain and __virGetNetwork for libvirtd only (Richard Jones) - ignore old VNC config for HVM on recent Xen (Daniel Berrange) - various code cleanups - -Werror cleanup (Hugh Brock) thanks to everybody who helped for this release with bug reports or patches ! Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/ -- Libvir-list mailing list Libvir-list(a)redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

2 1

[Libvir] Release of libvirt-0.2.3
by Daniel Veillard 11 Jun '07

11 Jun '07

Nearly 2 months without a release, it was clearly time, a lot of changes had accumulated in CVS. Available from ftp://libvirt.org/libvirt/ * Documentation: - documentation for upcoming remote access (Richard Jones) - virConnectNumOfDefinedDomains doc (Jan Michael) - virsh help messages for dumpxml and net-dumpxml (Chris Wright) * Bug fixes: - RelaxNG schemas regexp fix (Robin Green) - RelaxNG arch bug (Mark McLoughlin) - large buffers bug fixes (Shigeki Sakamoto) - error on out of memory condition (Shigeki Sakamoto) - virshStrdup fix - non-root driver when using Xen bug (Richard Jones) - use --strict-order when running dnsmasq (Daniel Berrange) - virbr0 weirdness on restart (Mark McLoughlin) - keep connection error messages (Richard Jones) - increase QEmu read buffer on help (Daniel Berrange) - rpm dependance on dnsmasq (Daniel Berrange) - fix XML boot device syntax (Daniel Berrange) - QEmu memory bug (Daniel Berrange) - memory leak fix (Masayuki Sunou) - fix compiler flags (Richard Jones) - remove type ioemu on recent Xen HVM for paravirt drivers (Saori Fukuta) - uninitialized string bug (Masayuki Sunou) - allow init even if the daemon is not running - XML to config fix (Daniel Berrange) * Improvements: - add a special error class for the test module (Richard Jones) - virConnectGetCapabilities on proxy (Richard Jones) - allow network driver to decline usage (Richard Jones) - extend error messages for upcoming remote access (Richard Jones) - on_reboot support for QEmu (Daniel Berrange) - save daemon output in a log file (Daniel Berrange) - xenXMDomainDefineXML can override guest config (Hugh Brock) - add attach-device and detach-device commands to virsh (Masayuki Sunou and Mark McLoughlin and Richard Jones) - make virGetVersion case insensitive and Python bindings (Richard Jones) - new scheduler API (Atsushi SAKAI) - localizations updates - add logging option for virsh (Nobuhiro Itou) - allow arguments to be passed to bootloader (Hugh Brock) - increase the test suite (Daniel Berrange and Hugh Brock) * Cleanups: - Remove VIR_DRV_OPEN_QUIET (Richard Jones) - disable xm_internal.c for Xen > 3.0.3 (Daniel Berrange) - unused fields in _virDomain (Richard Jones) - export __virGetDomain and __virGetNetwork for libvirtd only (Richard Jones) - ignore old VNC config for HVM on recent Xen (Daniel Berrange) - various code cleanups - -Werror cleanup (Hugh Brock) thanks to everybody who helped for this release with bug reports or patches ! Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/

2 2

[Libvir] PATCH: Fix bridge device handling with xm config files
by Daniel P. Berrange 07 Jun '07

07 Jun '07

The code for parsing xm config files & generating XML forgot to add in the <source bridge='xenbr0'> elements if an explicit bridge is requested. The reverse direction was already implemeneted. This patch fixes the missing handling of bridge devices & adds a test case Dan -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

2 1

[Libvir] [PATCH] add bootloader_args to libvirt xml to support bootloaders (like pypxeboot for example) that require arguments
by Hugh Brock 07 Jun '07

07 Jun '07

This patch extends libvirt's XML to include a paramater Xen already supports in sexpr, "bootloader_args." The bootloader_args parameter lets you pass arguments -- "mac=aa:12:34:56:78:90" for example -- to a bootloader program that xend invokes when it starts a guest. One such program, pypxeboot, uses the mac= argument to communicate with a dhcp server and retrieve the pxeboot kernel and initrd for a paravirt guest. The patch includes new tests for the bootloader_args XML and sexpr, which pass. Note that for the head of current libvirt, the virsh tests do not pass and virsh will not connect to the xen hypervisor. I don't know if this is my own build environment or some other issue. However the failure is the same with or without this patch, so I am submitting it anyway. Please let me know what you think... --Hugh -- Red Hat Virtualization Group http://redhat.com/virtualization Hugh Brock | virt-manager http://virt-manager.org hbrock(a)redhat.com | virtualization library http://libvirt.org

3 5

[Libvir] tentative next release tomorrow
by Daniel Veillard 07 Jun '07

07 Jun '07

We piled up a lot of patches since 0.2.2, I guess it is time for a new release, so I will try to push 0.2.3 out tomorrow morning. Give a try to the version in CVS (or a recent snapshot), thanks, Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/

1 0

[Libvir] [PATCH] output virsh log to file
by Nobuhiro Itou 07 Jun '07

07 Jun '07

Hi, I made the patch which output debug messages and error messages of virsh to the log file. I think that it is necessary to leave logs to the file for the investigation at the failure. Debug messages can take appointed optional information, and error messages will make it easy to specify a cause. Moreover, I'm thinking about outputting virterror information to the virsh log file by the next step. It is simple specifications as follows. * Destination -- <USER HOME>/.virsh/virsh.log * Log size -- 1MB(1024*1024) * Number of Rotations -- 5 * There is process exclusion. First, will you take in this patch ? And, I have a plan to enhance logging functionality. (for example, libvirt error logging) Signed-off-by: Nobuhiro Itou <fj0873gn(a)aa.jp.fujitsu.com> Thanks, Nobuhiro Itou.

6 18

[Libvir] [PATCH] Cut out "type=ioemu" on Xen3.1
by Saori Fukuta 07 Jun '07

07 Jun '07

Hi, The definition of (type ioemu) is *not* required by Xen3.1. So I cut out it when xendConfigVersion is 4 or later. Signed-off-by: Saori Fukuta <fukuta.saori(a)jp.fujitsu.com> Thanks, Saori Fukuta. Index: xml.c =================================================================== RCS file: /data/cvs/libvirt/src/xml.c,v retrieving revision 1.73 diff -u -p -r1.73 xml.c --- xml.c 23 Apr 2007 07:41:23 -0000 1.73 +++ xml.c 31 May 2007 07:02:01 -0000 @@ -1047,6 +1047,7 @@ virDomainParseXMLDiskDesc(virConnectPtr * @conn: pointer to the hypervisor connection * @node: node containing the interface description * @buf: a buffer for the result S-Expr + * @xendConfigVersion: xend configuration file format * * Parse the one interface the XML description and add it to the S-Expr in buf * This is a temporary interface as the S-Expr interface @@ -1056,7 +1057,7 @@ virDomainParseXMLDiskDesc(virConnectPtr * Returns 0 in case of success, -1 in case of error. */ static int -virDomainParseXMLIfDesc(virConnectPtr conn ATTRIBUTE_UNUSED, xmlNodePtr node, virBufferPtr buf, int hvm) +virDomainParseXMLIfDesc(virConnectPtr conn ATTRIBUTE_UNUSED, xmlNodePtr node, virBufferPtr buf, int hvm, int xendConfigVersion) { xmlNodePtr cur; xmlChar *type = NULL; @@ -1129,7 +1130,8 @@ virDomainParseXMLIfDesc(virConnectPtr co virBufferVSprintf(buf, "(script '%s')", script); if (ip != NULL) virBufferVSprintf(buf, "(ip '%s')", ip); - if (hvm) + /* HVM type ioemu config for xen < 3.1 */ + if (hvm && xendConfigVersion < 4) virBufferAdd(buf, "(type ioemu)", 12); virBufferAdd(buf, ")", 1); @@ -1335,7 +1337,7 @@ virDomainParseXMLDesc(virConnectPtr conn if (nb_nodes > 0) { for (i = 0; i < nb_nodes; i++) { virBufferAdd(&buf, "(device ", 8); - res = virDomainParseXMLIfDesc(conn, nodes[i], &buf, hvm); + res = virDomainParseXMLIfDesc(conn, nodes[i], &buf, hvm, xendConfigVersion); if (res != 0) { free(nodes); goto error; @@ -1494,7 +1496,7 @@ virParseXMLDevice(virConnectPtr conn, ch goto error; } else if (xmlStrEqual(node->name, BAD_CAST "interface")) { - if (virDomainParseXMLIfDesc(conn, node, &buf, hvm) != 0) + if (virDomainParseXMLIfDesc(conn, node, &buf, hvm, xendConfigVersion) != 0) goto error; } cleanup:

3 6

[Libvir] Add scheduler patch?
by Atsushi SAKAI 06 Jun '07

06 Jun '07

Hi, Is there any plan to apply scheduler controller patch? https://www.redhat.com/archives/libvir-list/2007-May/msg00291.html https://www.redhat.com/archives/libvir-list/2007-May/msg00295.html Thanks Atsushi SAKAI

2 12

[Libvir] [PATCH] make xen compile -Werror and without PROXY turned on (the autobuild config)
by Hugh Brock 05 Jun '07

05 Jun '07

$SUBJECT says it all... --Hugh -- Red Hat Virtualization Group http://redhat.com/virtualization Hugh Brock | virt-manager http://virt-manager.org hbrock(a)redhat.com | virtualization library http://libvirt.org

2 1

Re: [Libvir] [PATCH] add scheduler API(take 3?)
by Richard W.M. Jones 04 Jun '07

04 Jun '07

+char * +virDomainGetSchedulerType(virDomainPtr domain, int *nparams) +{ + virConnectPtr conn; + char *schedtype; + + if (domain == NULL) { + TODO + return NULL; + } Is this case an error, or were you thinking of adding more semantics later on here? (and the same comment for virDomainGet/SetSchedulerParameters) +static int +cmdSchedinfo(vshControl * ctl, vshCmd * cmd) +{ [...] + char *str_weight = strdup("weight"); + char *str_cap = strdup("cap"); + + nparams = malloc(sizeof(int)); + *nparams = 0; + + if (!vshConnectionUsability(ctl, ctl->conn, TRUE)) + return FALSE; There's still a problem memory leak here. + /* Currently supports Xen Credit only */ + weight = vshCommandOptInt(cmd, "weight", &weightfound); + if(weightfound){ inputparam++; } + + cap = vshCommandOptInt(cmd, "cap", &capfound); + if(capfound){ inputparam++; } and can this be made so it isn't Xen-specific? + if ((domain == NULL) || (domain->conn == NULL)) + return -1; + + priv = (xenUnifiedPrivatePtr) domain->conn->privateData; + if (priv->handle < 0 || domain->id < 0) + return -1; At the lowest level, these functions should return error messages back to the upper layers. Otherwise users have nothing to diagnose errors with. + /* + * Support only dom_interface_version >=5 + * (Xen3.1.0 or later) + */ + if (dom_interface_version < 5) + return -1; Is this because earlier hypervisors didn't support this, or is it just not implemented? Rich.

3 7

[Libvir] [PATCH] Fix strange error message in virsh attach-device
by Masayuki Sunou 04 Jun '07

04 Jun '07

Hi Now, virsh attach-device displays the following messages when "device" attribute of "disk" element is "floppy" in XML. # virsh attach-device HVM_RH4_file floppy.xml libvir: Xen Daemon error : POST operation failed: (xend.err 'Invalid Configuration: XendConfig: @\x14\xce not a valid device type') error: Failed to attach device from floppy.xml This patch fixes this strange error message displaying "@\x14\xce". Description of this patch VirDomainParseXMLDiskDesc() returns 0 without putting data in virBuffer, when "floppy" is set. Therefore, virParseXMLDevice() returns no initialized data, and xenDaemonAttachDevice() passes Xen this data. Because virDomainParseXMLDesc() works wrong when this patch changes return value of VirDomainParseXMLDiskDesc(),this patch fixes virParseXMLDevice() as follows. - Initialize data - Return error if data does not change. As a result, xenDaemonAttachDevice() doesn't pass strange data to Xen, and Xen doesn't return strange error message. Signed-off-by: Masayuki Sunou <fj1826dm(a)aa.jp.fujitsu.com> Thanks, Masayuki Sunou. ---------------------------------------------------------------------- Index: src/xml.c =================================================================== RCS file: /data/cvs/libvirt/src/xml.c,v retrieving revision 1.73 diff -u -p -r1.73 xml.c --- src/xml.c 23 Apr 2007 07:41:23 -0000 1.73 +++ src/xml.c 25 May 2007 09:46:56 -0000 @@ -1481,6 +1481,7 @@ virParseXMLDevice(virConnectPtr conn, ch return (NULL); buf.size = 1000; buf.use = 0; + memset(buf.content, 0, (size_t)buf.size); xml = xmlReadDoc((const xmlChar *) xmldesc, "domain.xml", NULL, XML_PARSE_NOENT | XML_PARSE_NONET | XML_PARSE_NOERROR | XML_PARSE_NOWARNING); @@ -1492,6 +1493,9 @@ virParseXMLDevice(virConnectPtr conn, ch if (xmlStrEqual(node->name, BAD_CAST "disk")) { if (virDomainParseXMLDiskDesc(conn, node, &buf, hvm, xendConfigVersion) != 0) goto error; + /* SXP is not created when device is "floppy". */ + else if (!strlen(buf.content)) + goto error; } else if (xmlStrEqual(node->name, BAD_CAST "interface")) { if (virDomainParseXMLIfDesc(conn, node, &buf, hvm) != 0) ----------------------------------------------------------------------

2 5

[Libvir] Use virsh to monitor qemud
by Fabian Deutsch 03 Jun '07

03 Jun '07

Hey, I jsut installed Fedora 7 and tried to install some guests and it worked like a charm. I use qemu for full virtulization. A couple of minutes later i stumbled across libvirts virtsh. But now I wonder how I cna use virtsh to connect to qemud - all I get is something like: "Can't connect to hyperisor." - fabiand

3 4

[Libvir] SOLVED Re: cannot use vncviewer and VMM graphics console to access HVM guest on RHES 5
by Glen Deem 03 Jun '07

03 Jun '07

Thanks to Igor Chubin (spasibo) and Richard Jones, the qemu vnc server was listening but I did not connect to its proper port (why libvirt doesn't use <IP>:<domU id> kind of vnc connection and restricts the server to local host only by default?). Regards, Glen On 5/31/07, Glen Deem <xen.inbox@XXXXXXXXX> wrote: > Hi all, > > I've created an HVM guest under RHES 5 (Xen 3.0.3) using "xm create" > but I cannot access it with vncviewer. > > The Virtual Machine Manager also informs about graphics console unavailability. > > What am I doing wrong, please? > > I do > > vncviewer 123.456.789.123:4, > where 4 is the guest id. > > This is the xm config file is: > > name = "hvmGuest" > builder = "hvm" > memory = "500" > disk = [ 'file:/var/lib/red-hat.img,hda,w', ] > vif = [ 'type=ioemu, mac=00:16:3e:34:3b:ba, bridge=xenbr0', ] > device_model = "/usr/lib/xen/bin/qemu-dm" > kernel = "/usr/lib/xen/boot/hvmloader" > vnc=1 > vncunused=1 > apic=1 > acpi=1 > pae=1 > vcpus=1 > serial = "pty" > on_reboot = 'restart' > on_crash = 'restart' > > Thanks a lot in advance. > > Glen from Ottawa, Canada >

4 4

[Libvir] Re: [Xen-users] SOLVED Re: cannot use vncviewer and VMM graphics console to access HVM guest on RHES 5
by Glen Deem 01 Jun '07

01 Jun '07

Hi Dan, I'm with you about the VNC authentication. But I still don't understand the logic behind assigning HVM displays. Instead of clear "domU ID is the display number" (vncunused 0), the Virtual Machine Manager assigns vncunused to 1 and then calculates the 5900+ port, I suppose depending on what port is not occupied (BTW where exactly is this code in the source, please?). Why is that? And how am I suppose to find out what that port number is if I'd want to connect to a VMM-created vm manually with my vnc client? Thanks, Glen Daniel P. Berrange wrote: > On Fri, Jun 01, 2007 at 11:03:36AM -0400, Glen Deem wrote: >> Thanks to Igor Chubin (spasibo) and Richard Jones, the qemu vnc server >> was listening but I did not connect to its proper port (why libvirt >> doesn't use <IP>:<domU id> kind of vnc connection and restricts the >> server to local host only by default?). > > VNC authentication is an utter joke. It can be trivially brute forced > so exposing it on a public IP address is not a good idea, hence the > default is 127.0.0.1, though even that's not ideal because it is still > exposed to local users. Ultimately VNC needs to have SSL/TLS support > integrated into it to allow secure access over public network, which > is something I'm working on for QEMU... > > Dan.

2 1

[Libvir] cannot use vncviewer and VMM graphics console to access HVM guest on RHES 5
by Glen Deem 01 Jun '07

01 Jun '07

Hi all, I've created an HVM guest under RHES 5 (Xen 3.0.3) using "xm create" but I cannot access it with vncviewer. The Virtual Machine Manager also informs about graphics console unavailability. What am I doing wrong, please? I do > vncviewer 123.456.789.123:4, where 4 is the guest id. This is the xm config file is: name = "hvmGuest" builder = "hvm" memory = "500" disk = [ 'file:/var/lib/red-hat.img,hda,w', ] vif = [ 'type=ioemu, mac=00:16:3e:34:3b:ba, bridge=xenbr0', ] device_model = "/usr/lib/xen/bin/qemu-dm" kernel = "/usr/lib/xen/boot/hvmloader" vnc=1 vncunused=1 apic=1 acpi=1 pae=1 vcpus=1 serial = "pty" on_reboot = 'restart' on_crash = 'restart' Thanks a lot in advance. Glen from Ottawa, Canada

3 2