Re: [libvirt] [PATCH v5 3/3] libvirtd: fix crash on termination

On Mon, Oct 30, 2017 at 07:14:39AM -0400, John Ferlan wrote: I must say I don't believe that's true. Reading it back, that patch is wrong IMHO. I haven't gone through all the details of it and I don't remember them from when I rewrote part of it, but the way this should be handled is different. The way you can clearly identify such issues is when you see that one thread determines the validity of data (pointer in this case). This must never happen. That means that the pointer is used from more places than how many references that object has. However each of the pointers for such object should have their own reference. So the problem is probably somewhere else. If I get this correctly, you are removing the servers so that their workers get cleaned up, but that should be done in a separate step. Most probably what daemonServerClose should be doing. This is a workaround, but not a proper fix. If that's not true than the previous commit mentioned here should also be fixed differently. So this is a clear NACK from my POV.