March 2025 - Devel - libvirt List Archives

[PATCH v2 00/21] Add qemu RDP server support
by marcandre.lureau＠redhat.com 17 Mar '25

17 Mar '25

From: Marc-André Lureau <marcandre.lureau(a)redhat.com> Hi, This patch series offers an out-of-process Remote Desktop Protocol (RDP) server solution utilizing QEMU's -display dbus interface, offering improved modularity and potential security benefits compared to built-in server. This initiative was spearheaded by Mihnea Buzatu during the QEMU Summer of Code 2023. The project's goal was to develop an out-of-process RDP server using the -display dbus interface, implemented in Rust. Given that the IronRDP crate lacked some server support at the time, investments in IronRDP were required. I finally released an initial v0.1 version of qemu-rdp on crates.io (https://crates.io/crates/qemu-rdp) That should allow more people to review and evaluate the state of this work. On unix systems, with cargo/rust toolchain installed, it should be as easy as running "cargo install qemu-rdp", apply this patch series for libvirt, set the "rdp_tls_x509_cert_dir" location for your TLS certificates, and configure a VM with both dbus & rdp graphics (run "virsh domdisplay DOMAIN" to get the display connection details). Thanks for the reviews & feedback! v2: thanks to Daniel review - drop extra error report from "qemu: report an error for unsupported graphics" - replace g_return pre-conditions with ATTRIBUTE_NONNULL - improve "qemu/dbus: keep a connection to the VM D-Bus" to also reconnect - use domainLogContext for logging (for virtiofs as well) - check for qemu-rdp availabilty for setting 'rdp' capability - make dbus-addr qemu-rdp capability mandatory - rebased - add r-b tags Marc-André Lureau (21): build-sys: drop -Winline when optimization=g build: fix -Werror=maybe-uninitialized qemu-slirp: drop unneeded check for OOM util: annotate non-null arguments for virGDBusCallMethod() qemu: fall-through for unsupported graphics qemu: add rdp state directory qemu: add qemu RDP configuration conf: parse optional RDP username & password conf: generalize virDomainDefHasSpiceGraphics qemu: use virDomainDefHasGraphics qemu: add RDP ports range allocator qemu: limit to one <graphics type='rdp'> qemu/virtiofs: use domainLogContext qemu/dbus: keep a connection to the VM D-Bus qemu/dbus: log daemon stdout/err, use domainLogContext qemu: validate RDP configuration qemu: add qemu-rdp helper unit qemu: pass virQEMUDriverConfig to capabilities qemu: add 'rdp' capability if qemu-rdp is available qemu: add RDP support tests: add qemu <graphics type='rdp'/> test docs/formatdomain.rst | 25 +- meson.build | 7 +- po/POTFILES | 1 + src/conf/domain_conf.c | 28 +- src/conf/domain_conf.h | 5 +- src/conf/schemas/domaincommon.rng | 10 + src/libvirt_private.syms | 2 +- src/qemu/libvirtd_qemu.aug | 7 + src/qemu/meson.build | 1 + src/qemu/qemu.conf.in | 31 ++ src/qemu/qemu_capabilities.c | 24 +- src/qemu/qemu_capabilities.h | 12 +- src/qemu/qemu_command.c | 9 +- src/qemu/qemu_conf.c | 56 ++- src/qemu/qemu_conf.h | 13 + src/qemu/qemu_dbus.c | 69 ++- src/qemu/qemu_dbus.h | 3 + src/qemu/qemu_domain.c | 1 + src/qemu/qemu_domain.h | 4 + src/qemu/qemu_driver.c | 20 + src/qemu/qemu_extdevice.c | 46 +- src/qemu/qemu_hotplug.c | 49 ++- src/qemu/qemu_hotplug.h | 1 + src/qemu/qemu_process.c | 170 ++++++- src/qemu/qemu_rdp.c | 416 ++++++++++++++++++ src/qemu/qemu_rdp.h | 73 +++ src/qemu/qemu_slirp.c | 6 - src/qemu/qemu_validate.c | 48 +- src/qemu/qemu_virtiofs.c | 53 +-- src/qemu/test_libvirtd_qemu.aug.in | 5 + src/util/virgdbus.h | 13 +- .../domaincapsdata/qemu_10.0.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_10.0.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_10.0.0.s390x.xml | 1 + tests/domaincapsdata/qemu_10.0.0.x86_64.xml | 1 + .../domaincapsdata/qemu_7.0.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_7.0.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_7.0.0.x86_64.xml | 1 + .../domaincapsdata/qemu_7.1.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_7.1.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_7.1.0.x86_64.xml | 1 + .../qemu_7.2.0-hvf.x86_64+hvf.xml | 1 + .../domaincapsdata/qemu_7.2.0-q35.x86_64.xml | 1 + .../qemu_7.2.0-tcg.x86_64+hvf.xml | 1 + .../domaincapsdata/qemu_7.2.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_7.2.0.ppc.xml | 1 + tests/domaincapsdata/qemu_7.2.0.x86_64.xml | 1 + .../domaincapsdata/qemu_8.0.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_8.0.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_8.0.0.x86_64.xml | 1 + .../domaincapsdata/qemu_8.1.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_8.1.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_8.1.0.s390x.xml | 1 + tests/domaincapsdata/qemu_8.1.0.x86_64.xml | 1 + .../domaincapsdata/qemu_8.2.0-q35.x86_64.xml | 1 + .../qemu_8.2.0-tcg-virt.loongarch64.xml | 1 + .../domaincapsdata/qemu_8.2.0-tcg.x86_64.xml | 1 + .../qemu_8.2.0-virt.aarch64.xml | 1 + .../qemu_8.2.0-virt.loongarch64.xml | 1 + tests/domaincapsdata/qemu_8.2.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_8.2.0.armv7l.xml | 1 + tests/domaincapsdata/qemu_8.2.0.s390x.xml | 1 + tests/domaincapsdata/qemu_8.2.0.x86_64.xml | 1 + .../domaincapsdata/qemu_9.0.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_9.0.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_9.0.0.sparc.xml | 1 + tests/domaincapsdata/qemu_9.0.0.x86_64.xml | 1 + .../domaincapsdata/qemu_9.1.0-q35.x86_64.xml | 1 + .../qemu_9.1.0-tcg-virt.riscv64.xml | 1 + .../domaincapsdata/qemu_9.1.0-tcg.x86_64.xml | 1 + .../qemu_9.1.0-virt.riscv64.xml | 1 + tests/domaincapsdata/qemu_9.1.0.s390x.xml | 1 + tests/domaincapsdata/qemu_9.1.0.x86_64.xml | 1 + .../domaincapsdata/qemu_9.2.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_9.2.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_9.2.0.s390x.xml | 1 + tests/domaincapsdata/qemu_9.2.0.x86_64.xml | 1 + tests/domaincapstest.c | 7 +- .../graphics-rdp.x86_64-latest.args | 35 ++ .../graphics-rdp.x86_64-latest.xml | 1 + tests/qemuxmlconfdata/graphics-rdp.xml | 43 ++ tests/qemuxmlconftest.c | 2 + tests/testutilsqemu.c | 10 + tools/nss/libvirt_nss_leases.c | 2 +- tools/nss/libvirt_nss_macs.c | 2 +- 85 files changed, 1218 insertions(+), 138 deletions(-) create mode 100644 src/qemu/qemu_rdp.c create mode 100644 src/qemu/qemu_rdp.h create mode 100644 tests/qemuxmlconfdata/graphics-rdp.x86_64-latest.args create mode 120000 tests/qemuxmlconfdata/graphics-rdp.x86_64-latest.xml create mode 100644 tests/qemuxmlconfdata/graphics-rdp.xml -- 2.47.0

4 42

[PATCH] news: Add item for guest load averages
by Martin Kletzander 17 Mar '25

17 Mar '25

Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- NEWS.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 9c940b1a8176..d7d40cf5546d 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -17,6 +17,8 @@ v11.2.0 (unreleased) * **New features** + * qemu: Added guest load averages to the output of virDomainGetGuestInfo + * **Improvements** * **Bug fixes** -- 2.48.1

2 2

[PATCH] docs: document workaround for DMARC countermeasures
by Daniel P. Berrangé 17 Mar '25

17 Mar '25

From: Daniel P. Berrangé <berrange(a)redhat.com> If a contributor's email domain has a DMARC policy of 'p=quarantine' or 'p=reject', mailman will apply DMARC countermeasures on all mails sent to lists.libvirt.org rewriting the "From" header to remove the sender's email address. e.g. From: Your Name via <lists.libvirt.org> If these countermeasures were not applied, affected mail would either have gon directly to SPAM, or have been entirely rejected. Mailman3 is unable to be configured to guarantee no mangling of the mail body so these countermeasures are unavoidable for lists.libvirt.org. Amongst the various downsides, the From address rewriting has the bad effect of mangling git commit author attribution. To avoid this it is required to add two additional git config settings: $ git config --global format.from "Your Name <your(a)email.com>" $ git config --global format.forceInBodyFrom true Note, *both* are required, even if your ``format.from`` matches your existing git identity, because the latter only takes effect once the former is set. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- docs/submitting-patches.rst | 66 ++++++++++++++++++++++++++++--------- 1 file changed, 51 insertions(+), 15 deletions(-) diff --git a/docs/submitting-patches.rst b/docs/submitting-patches.rst index a5e108550a..b22e4e03b4 100644 --- a/docs/submitting-patches.rst +++ b/docs/submitting-patches.rst @@ -43,21 +43,7 @@ series of two or more patches needs a cover letter. Note that the ``git send-email`` subcommand may not be in the main git package and using it may require installation of a separate package, for example the "git-email" package in Fedora -and Debian. If this is your first time using -``git send-email``, you might need to configure it to point it -to your SMTP server with something like: - -:: - - $ git config --global sendemail.smtpServer stmp.youremailprovider.net - -If you get tired of typing ``--to=devel(a)lists.libvirt.org`` all -the time, you can configure that to be automatically handled as -well: - -:: - - $ git config sendemail.to devel(a)lists.libvirt.org +and Debian. Avoid using mail clients for sending patches, as most of them will mangle the messages in some way, making them unusable for @@ -88,6 +74,56 @@ Moreover, such patch needs to be prefixed correctly with ``git send-email`` (substitute ``v2`` with the correct version if needed though). +Git Configuration +----------------- + +If this is your first time using ``git send-email``, you will probably +need to setup your global git configuration, to point to your outgoing +SMTP server with something like: + +:: + + $ git config --global sendemail.smtpServer stmp.youremailprovider.net + +If your email provider (often your employer) has configured a DMARC +policy for their domain, there are some additional settings that will +be required. Before doing this, check the DMARC policy with + +:: + + $ host -t txt _dmarc.$YOURDOMAIN.COM + +If this returns no output, or contains ``p=none`` then no configuration +is required. If it reports ``p=quarantine`` or ``p=reject``, then the +libvirt lists will apply DMARC countermeasures to your email. To ensure +that git authorship is preserved add + +:: + + $ git config --global format.from "Your Name <your(a)email.com>" + $ git config --global format.forceInBodyFrom true + +This will force git to always add an additional line + +:: + + From: Your Name <your(a)email.com> + +in the body of the patch, guaranteeing correct author records even +when the main ``From`` header is rewritten by mailman. + +If you get tired of typing ``--to=devel(a)lists.libvirt.org`` all +the time, you can configure that to be automatically handled by +adding a local repository setting: + +:: + + $ git config sendemail.to devel(a)lists.libvirt.org + +This last setting is not required if using ``git-publish`` to send +patches, as that auto-identifies the mailing list address from its +config file stored in git. + Review process -------------- -- 2.48.1

3 3

[PATCHv2 0/2] ch: minor fixes - segfault and last meaningful error preservation
by Kirill Shchetiniuk 17 Mar '25

17 Mar '25

During fixing some other issue found out a few minor bugs related to CH driver. First bug is related to monitor object ref count in virCHStartEventHandler and virCHEventHandlerLoop, as object was unrefed by parent while is still used by child thread. Moved object unref to the correct place to the correct thread. Second bug is related to v object ref count in virCHStartEventHandler, as vm object was unrefed, while is still used later, move object unref to after its last usage. Third bug is related to error handling and propagation. Last meaninful error was reset by virCHProcessStop, which have led to unknown error message in virsh. Add error preservation at the begining of the function and restoring it at the end to keep consistent error output Kirill Shchetiniuk (2): ch: virCHProcessStop preserve last meaningful error ch: ref count fix in virCHEventHandlerLoop and virCHStartEventHandler src/ch/ch_events.c | 4 ++-- src/ch/ch_process.c | 5 +++++ 2 files changed, 7 insertions(+), 2 deletions(-) -- 2.48.1

2 3

[PATCH] docs: Fix some types
by Thomas Huth 17 Mar '25

17 Mar '25

From: Thomas Huth <thuth(a)redhat.com> Found with the codespell utility. Signed-off-by: Thomas Huth <thuth(a)redhat.com> --- docs/formatcaps.rst | 2 +- docs/formatdomain.rst | 4 ++-- docs/glib-adoption.rst | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/formatcaps.rst b/docs/formatcaps.rst index da6b215780..7e525487e7 100644 --- a/docs/formatcaps.rst +++ b/docs/formatcaps.rst @@ -39,7 +39,7 @@ The ``<host/>`` element consists of the following child elements: The host CPU architecture and features. Note that, while this element contains a ``topology`` sub-element, - the information contained therein is farily high-level and likely + the information contained therein is fairly high-level and likely not very useful when it comes to optimizing guest vCPU placement. Look into the ``topology`` *element*, described below, for more detailed information. diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index c1876ad467..4bc6a318f5 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -3468,7 +3468,7 @@ paravirtualized driver is specified via the ``disk`` element. automatically distributed among the configured iothreads. Optionally the ``iothread`` element can have multiple ``queue`` - subelements with mandatory ``id`` atribute specifying that the iothread + subelements with mandatory ``id`` attribute specifying that the iothread should be used to handle given virt queue. If queue mapping is present the ``queues`` attribute of ``driver`` must be configured and all configured virt queues must be included in the mapping. The @@ -8423,7 +8423,7 @@ Example: usage of external TPM emulator :since:`Since 9.0.0` This element does not work with the ``passthrough`` backend. - When specified, it is the user's responsability to prevent files from being + When specified, it is the user's responsibility to prevent files from being used by multiple VMs or emulators (swtpm will also use advisory locking). If not specified, the storage configuration is left to libvirt discretion. diff --git a/docs/glib-adoption.rst b/docs/glib-adoption.rst index f969ac80a1..c2cec80eea 100644 --- a/docs/glib-adoption.rst +++ b/docs/glib-adoption.rst @@ -32,7 +32,7 @@ Array operations https://developer.gnome.org/glib/stable/glib-Arrays.html - Instead of using plain C arrays, it is preferrable to use one of + Instead of using plain C arrays, it is preferable to use one of the GLib types, ``GArray``, ``GPtrArray`` or ``GByteArray``. These all use a struct to track the array memory and size together and efficiently resize. -- 2.48.1

3 3

[PATCH] docs: remove references to removed APIs
by Daniel P. Berrangé 17 Mar '25

17 Mar '25

The glib adoption docs was suggesting avoidance of certain APIs that were obsoleted by glib, during the transition period. Now that the referenced APIs no longer exist in libvirt code, they can also be removed from the docs. NB, the virStringListRemoveDuplicates method remains since there is no glib equivalent. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- docs/glib-adoption.rst | 22 ---------------------- 1 file changed, 22 deletions(-) diff --git a/docs/glib-adoption.rst b/docs/glib-adoption.rst index f969ac80a1..046cd821f7 100644 --- a/docs/glib-adoption.rst +++ b/docs/glib-adoption.rst @@ -14,19 +14,6 @@ the GLib APIs straight away where possible. The following is a list of libvirt APIs that should no longer be used in new code, and their suggested GLib replacements: -Memory allocation - ``VIR_ALLOC``, ``VIR_REALLOC``, ``VIR_RESIZE_N``, - ``VIR_EXPAND_N``, ``VIR_SHRINK_N``, ``VIR_FREE`` - - https://developer.gnome.org/glib/stable/glib-Memory-Allocation.html - - Prefer the GLib APIs ``g_new0``/``g_renew``/ ``g_free`` in most - cases. There should rarely be a need to use - ``g_malloc``/``g_realloc``. **NEVER MIX** use of the classic - libvirt memory allocation APIs and GLib APIs within a single - method. Keep the style consistent, converting existing code to - GLib style in a separate, prior commit. - Array operations ``VIR_APPEND_ELEMENT``, ``VIR_INSERT_ELEMENT``, ``VIR_DELETE_ELEMENT`` @@ -37,15 +24,6 @@ Array operations These all use a struct to track the array memory and size together and efficiently resize. -String arrays - ``virStringList*``, ``virStringListCount*`` - - https://developer.gnome.org/glib/stable/glib-String-Utility-Functions.html - - Prefer the NULL-terminated variant instead of storing the count - separately. Prefer ``g_str*v`` functions instead of their ``vir*`` - counterparts. For use with ``g_auto`` GLib provides the ``GStrv`` type. - Objects ``virObject`` -- 2.48.1

2 1

[PATCH] scripts: add execute permission to several files
by Daniel P. Berrangé 17 Mar '25

17 Mar '25

From: Daniel P. Berrangé <berrange(a)redhat.com> Most, but not all, files in scripts have execute permission. While we don't need this in order to launch them via meson/ninja build rules, it is nice to direct execution if they have execution permission. This makes the practice consistent across all scripts. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- scripts/check-drivername.py | 0 scripts/check-remote-protocol.py | 0 scripts/header-ifdef.py | 0 scripts/meson-install-dirs.py | 0 scripts/meson-install-symlink.py | 0 scripts/mock-noinline.py | 0 scripts/prohibit-duplicate-header.py | 0 7 files changed, 0 insertions(+), 0 deletions(-) mode change 100644 => 100755 scripts/check-drivername.py mode change 100644 => 100755 scripts/check-remote-protocol.py mode change 100644 => 100755 scripts/header-ifdef.py mode change 100644 => 100755 scripts/meson-install-dirs.py mode change 100644 => 100755 scripts/meson-install-symlink.py mode change 100644 => 100755 scripts/mock-noinline.py mode change 100644 => 100755 scripts/prohibit-duplicate-header.py diff --git a/scripts/check-drivername.py b/scripts/check-drivername.py old mode 100644 new mode 100755 diff --git a/scripts/check-remote-protocol.py b/scripts/check-remote-protocol.py old mode 100644 new mode 100755 diff --git a/scripts/header-ifdef.py b/scripts/header-ifdef.py old mode 100644 new mode 100755 diff --git a/scripts/meson-install-dirs.py b/scripts/meson-install-dirs.py old mode 100644 new mode 100755 diff --git a/scripts/meson-install-symlink.py b/scripts/meson-install-symlink.py old mode 100644 new mode 100755 diff --git a/scripts/mock-noinline.py b/scripts/mock-noinline.py old mode 100644 new mode 100755 diff --git a/scripts/prohibit-duplicate-header.py b/scripts/prohibit-duplicate-header.py old mode 100644 new mode 100755 -- 2.48.1

2 1

Fwd: system cache dropped
by matus valentin 17 Mar '25

17 Mar '25

Hi, I have a setup with multiple virtual machines (VMs) running on one host, each with a saved state. All VMs share the same parent, which is located on a shared drive. Whenever I restore any VM using virsh restore, the parent is dropped from the system cache, causing all data to be downloaded from the shared drive again. This results in unnecessary network traffic, even though the parent changes very rarely. However, if I create a child from the parent and call virsh create to create a new VM, the parent is never dropped from the system cache. Is this expected behavior? Should the parent be retained in the system cache during a virsh restore operation? Are there any configurations or settings that can prevent the parent from being dropped from the cache? thanks

1 0

[PATCH] NEWS: Mention new 'image_format' parameter for virDomainSaveParams
by Jim Fehlig 14 Mar '25

14 Mar '25

Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- NEWS.rst | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 9c940b1a81..d08a18dc02 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -17,6 +17,14 @@ v11.2.0 (unreleased) * **New features** + * qemu: Add new 'image_format' parameter to virDomainSaveParams + + ``virDomainSaveParams`` now supports an ``image_format`` parameter for + specifying the save image format on a per-domain basis. The parameter + accepts the same values as the driver-wide ``save_image_format`` setting + in ``qemu.conf``. An image format specified via ``virDomainSaveParams`` + takes precedence over the driver-wide setting. + * **Improvements** * **Bug fixes** -- 2.43.0

2 2

[libvirt PATCH 00/10] Unused cleanups
by Ján Tomko 13 Mar '25

13 Mar '25

Patches 4-9/10 all depend on patch 3/10 10/10 can be pushed independently Ján Tomko (10): qemu: seccomp sandbox: remove incorect G_GNUC_UNUSED marker qemu: validate: fs: remove unneeded parameter qemu: remove qemuCaps from qemuBuildObjectCommandlineFromJSON qemu: remove qemuCaps from qemuBuildObjectSecretCommandLine qemu: remove qemuCaps from qemuBuildTLSx509CommandLine qemu: remove qemuCaps from qemuBuildObjectCommandline qemu: remove qemuCaps from qemuBuildIOThreadCommandLine qemu: remove unused vm from qemuBuildSEVSNPCommandLine qemu: remove unused vm from qemuBuildPVCommandLine Remove unreachable breaks right after return src/qemu/qemu_cgroup.c | 2 - src/qemu/qemu_command.c | 110 +++++++++++++------------------ src/qemu/qemu_driver.c | 1 - src/qemu/qemu_hotplug.c | 1 - src/qemu/qemu_monitor_json.c | 1 - src/qemu/qemu_validate.c | 3 +- src/security/security_apparmor.c | 1 - src/vmx/vmx.c | 2 - tools/virsh-domain.c | 1 - tools/virsh-host.c | 2 - tools/vsh.c | 7 -- 11 files changed, 48 insertions(+), 83 deletions(-) -- 2.48.1

4 16