March 2025 - Devel - libvirt List Archives

[PATCH v2 00/22] integrate auto-shutdown of VMs with daemons
by Daniel P. Berrangé 18 Mar '25

18 Mar '25

This series starts the work needed to obsolete the libvirt-guests.sh script which has grown a surprisingly large amount of functionality. Currently the virt daemons will acquire inhibitors to delay OS shutdown when VMs are running. The libvirt-guests.service unit can be used to call libvirt-guests.sh to shutdown running VMs on system shutdown. This split is a bad architecture because libvirt-guests.service will only run once the system has decided to initiate the shutdown sequence. When the user requests as shutdown while inhibitors are present, logind will emit a "PrepareForShutdown" signal over dbus. Applications are supposed to respond to this by preserving state & releasing their inhibitors, which in turns allows shutdown to be initiated. The remote daemon already has support for listening for the "PrepareForShutdown" signal, but only does this for session instances, not system instances. This series essentially takes that logic and expands it to run in the system instances too, thus conceptually making libvirt-guests.service obsolete. It is slightly more complicated than that though for many reasons... Saving running VMs can take a very long time. The inhibitor delay can be as low as 5 seconds, and when killing a service, systemd may not wait very long for it to terminate. libvirt-guests.service deals with this by setting TimeoutStopSecs=0 to make systemd wait forever. This is undesirable to set in libvirtd.service though, as we would like systemd to kill the daemon aggressively if it hangs. The series thus uses the notification protocol to request systemd give it more time to shutdown, as long as we're in the phase of saving running VMs. A bug in this code will still result in systemd waiting forever, which is no different from libvirt-guests.service, but a bug in any other part of the libvirt daemon shutdown code will result in systemd killing us. The existing logic for saving VMs in the session daemons had many feature gaps compared to libvirt-guests.sh. Thus there is code to add support * Requesting graceful OS shutdown if managed save failed * Force poweroff of VMs if no other action worked * Optionally enabling/disabling use of managed save, graceful shutdown and force poweroff, which is more flexible than ON_SHUTDOWN=nnn, as we can try the whole sequence of options * Ability to bypass cache in managed save * Support for one-time autostart of VMs as an official API To aid in testing this logic, virt-admin gains a new command 'virt-admin daemon-shutdown --preserve' All this new functionality is wired up into the QEMU driver, and is made easily accessible to other hypervisor drivers, so would easily be extendable to Xen, CH, LXC drivers, but this is not done in this series. IOW, libvirt-guests.service is not yet fully obsolete. The new functionality is also not enabled by default for the system daemon, it requires explicit admin changes to /etc/libvirt/qemu.conf to enable it. This is because it would clash with execution of the libvirt-guests.service if both were enabled. It is highly desirable that we enable this by default though, so we need to figure out a upgrade story wrt libvirt-guests.service. The only libvirt-guests.sh features not implemented are: * PARALLEL_SHUTDOWN=nn. When doing a graceful shutdown we initiate it on every single VM at once, and then monitor progress of all of them in parallel. * SYNC_TIME=nn When make not attempt to sync guest time when restoring from managed save. This ought to be fixed Daniel P. Berrangé (22): hypervisor: move support for auto-shutdown out of QEMU driver remote: always invoke virStateStop for all daemons hypervisor: expand available shutdown actions hypervisor: custom shutdown actions for transient vs persistent VMs qemu: support automatic VM managed save in system daemon qemu: improve shutdown defaults for session daemon qemu: configurable delay for shutdown before poweroff hypervisor: support bypassing cache for managed save qemu: add config parameter to control auto-save bypass cache src: add new APIs for marking a domain to autostart once conf: implement support for autostart once feature hypervisor: wire up support for auto restore of running domains qemu: wire up support for once only autostart qemu: add config to control if auto-shutdown VMs are restored src: clarify semantics of the various virStateNNN methods rpc: rename virNetDaemonSetShutdownCallbacks rpc: move state stop into virNetDaemon class rpc: don't unconditionally quit after preserving state rpc: fix shutdown sequence when preserving state admin: add 'daemon-shutdown' command rpc: don't let systemd shutdown daemon while saving VMs hypervisor: emit systemd status & log messages while saving docs/manpages/virt-admin.rst | 13 ++ include/libvirt/libvirt-admin.h | 13 ++ include/libvirt/libvirt-domain.h | 4 + src/admin/admin_protocol.x | 11 +- src/admin/admin_server_dispatch.c | 13 ++ src/admin/libvirt-admin.c | 33 ++++ src/admin/libvirt_admin_public.syms | 5 + src/conf/domain_conf.c | 7 +- src/conf/domain_conf.h | 2 + src/conf/virdomainobjlist.c | 8 + src/driver-hypervisor.h | 10 ++ src/hypervisor/domain_driver.c | 246 +++++++++++++++++++++++++++- src/hypervisor/domain_driver.h | 27 +++ src/libvirt-domain.c | 87 ++++++++++ src/libvirt.c | 44 ++++- src/libvirt_private.syms | 3 + src/libvirt_public.syms | 6 + src/libvirt_remote.syms | 4 +- src/qemu/libvirtd_qemu.aug | 6 + src/qemu/qemu.conf.in | 62 +++++++ src/qemu/qemu_conf.c | 75 +++++++++ src/qemu/qemu_conf.h | 7 + src/qemu/qemu_driver.c | 150 ++++++++++++----- src/qemu/test_libvirtd_qemu.aug.in | 6 + src/remote/remote_daemon.c | 84 +++------- src/remote/remote_driver.c | 2 + src/remote/remote_protocol.x | 30 +++- src/remote_protocol-structs | 12 ++ src/rpc/gendispatch.pl | 4 +- src/rpc/virnetdaemon.c | 218 +++++++++++++++++++----- src/rpc/virnetdaemon.h | 35 +++- tools/virsh-domain-monitor.c | 7 + tools/virsh-domain.c | 39 ++++- tools/virt-admin.c | 41 +++++ 34 files changed, 1146 insertions(+), 168 deletions(-) -- 2.48.1

3 39

[PATCH v8 00/18] *** qemu: block: Support block disk along with throttle filters ***
by Harikumar Rajkumar 17 Mar '25

17 Mar '25

*** Support block disk along with throttle filters *** Chun Feng Wu (17): schema: Add new domain elements to support multiple throttle groups schema: Add new domain elements to support multiple throttle filters config: Introduce ThrottleGroup and corresponding XML parsing config: Introduce ThrottleFilter and corresponding XML parsing qemu: monitor: Add support for ThrottleGroup operations tests: Test qemuMonitorJSONGetThrottleGroup and qemuMonitorJSONUpdateThrottleGroup remote: New APIs for ThrottleGroup lifecycle management qemu: Refactor qemuDomainSetBlockIoTune to extract common methods qemu: Implement qemu driver for throttle API qemu: helper: throttle filter nodename and preparation processing qemu: block: Support block disk along with throttle filters config: validate: Verify iotune, throttle group and filter qemuxmlconftest: Add 'throttlefilter' tests test_driver: Test throttle group lifecycle APIs virsh: Refactor iotune options for re-use virsh: Add support for throttle group operations virsh: Add option "throttle-groups" to "attach_disk" Harikumar Rajkumar (1): qemustatusxml2xmldata: Add 'throttlefilter' tests This patch version addresses the feedback provided on patch v5, which includes the following modifications: * Reimplementation of the "get throttle group" to query from the XML. * Allowing the SET API to reset the throttle group config fields to its default in QEMU. * Updating the version to 11.1.0. * Implementing various coding style changes as suggested. * Removal of unnecessary comments. docs/formatdomain.rst | 47 ++ docs/manpages/virsh.rst | 137 +++- include/libvirt/libvirt-domain.h | 14 + src/conf/domain_conf.c | 407 ++++++++++ src/conf/domain_conf.h | 47 ++ src/conf/domain_validate.c | 118 ++- src/conf/schemas/domaincommon.rng | 293 ++++--- src/conf/virconftypes.h | 4 + src/driver-hypervisor.h | 14 + src/libvirt-domain.c | 122 +++ src/libvirt_private.syms | 8 + src/libvirt_public.syms | 6 + src/qemu/qemu_block.c | 136 ++++ src/qemu/qemu_block.h | 49 ++ src/qemu/qemu_command.c | 180 +++++ src/qemu/qemu_command.h | 6 + src/qemu/qemu_domain.c | 77 +- src/qemu/qemu_driver.c | 485 +++++++++--- src/qemu/qemu_hotplug.c | 29 + src/qemu/qemu_monitor.c | 21 + src/qemu/qemu_monitor.h | 9 + src/qemu/qemu_monitor_json.c | 129 +++ src/qemu/qemu_monitor_json.h | 14 + src/remote/remote_daemon_dispatch.c | 105 +++ src/remote/remote_driver.c | 3 + src/remote/remote_protocol.x | 50 +- src/remote_protocol-structs | 28 + src/test/test_driver.c | 367 ++++++--- tests/qemumonitorjsontest.c | 86 ++ .../throttlefilter-in.xml | 392 ++++++++++ .../throttlefilter-out.xml | 393 ++++++++++ tests/qemuxmlactivetest.c | 1 + .../throttlefilter-invalid.x86_64-latest.err | 1 + .../throttlefilter-invalid.xml | 89 +++ .../throttlefilter.x86_64-latest.args | 55 ++ .../throttlefilter.x86_64-latest.xml | 105 +++ tests/qemuxmlconfdata/throttlefilter.xml | 95 +++ tests/qemuxmlconftest.c | 2 + tools/virsh-completer-domain.c | 82 ++ tools/virsh-completer-domain.h | 16 + tools/virsh-domain.c | 736 ++++++++++++++---- 41 files changed, 4428 insertions(+), 530 deletions(-) create mode 100644 tests/qemustatusxml2xmldata/throttlefilter-in.xml create mode 100644 tests/qemustatusxml2xmldata/throttlefilter-out.xml create mode 100644 tests/qemuxmlconfdata/throttlefilter-invalid.x86_64-latest.err create mode 100644 tests/qemuxmlconfdata/throttlefilter-invalid.xml create mode 100644 tests/qemuxmlconfdata/throttlefilter.x86_64-latest.args create mode 100644 tests/qemuxmlconfdata/throttlefilter.x86_64-latest.xml create mode 100644 tests/qemuxmlconfdata/throttlefilter.xml -- 2.39.5 (Apple Git-154)

2 48

[PATCH v2 00/21] Add qemu RDP server support
by marcandre.lureau＠redhat.com 17 Mar '25

17 Mar '25

From: Marc-André Lureau <marcandre.lureau(a)redhat.com> Hi, This patch series offers an out-of-process Remote Desktop Protocol (RDP) server solution utilizing QEMU's -display dbus interface, offering improved modularity and potential security benefits compared to built-in server. This initiative was spearheaded by Mihnea Buzatu during the QEMU Summer of Code 2023. The project's goal was to develop an out-of-process RDP server using the -display dbus interface, implemented in Rust. Given that the IronRDP crate lacked some server support at the time, investments in IronRDP were required. I finally released an initial v0.1 version of qemu-rdp on crates.io (https://crates.io/crates/qemu-rdp) That should allow more people to review and evaluate the state of this work. On unix systems, with cargo/rust toolchain installed, it should be as easy as running "cargo install qemu-rdp", apply this patch series for libvirt, set the "rdp_tls_x509_cert_dir" location for your TLS certificates, and configure a VM with both dbus & rdp graphics (run "virsh domdisplay DOMAIN" to get the display connection details). Thanks for the reviews & feedback! v2: thanks to Daniel review - drop extra error report from "qemu: report an error for unsupported graphics" - replace g_return pre-conditions with ATTRIBUTE_NONNULL - improve "qemu/dbus: keep a connection to the VM D-Bus" to also reconnect - use domainLogContext for logging (for virtiofs as well) - check for qemu-rdp availabilty for setting 'rdp' capability - make dbus-addr qemu-rdp capability mandatory - rebased - add r-b tags Marc-André Lureau (21): build-sys: drop -Winline when optimization=g build: fix -Werror=maybe-uninitialized qemu-slirp: drop unneeded check for OOM util: annotate non-null arguments for virGDBusCallMethod() qemu: fall-through for unsupported graphics qemu: add rdp state directory qemu: add qemu RDP configuration conf: parse optional RDP username & password conf: generalize virDomainDefHasSpiceGraphics qemu: use virDomainDefHasGraphics qemu: add RDP ports range allocator qemu: limit to one <graphics type='rdp'> qemu/virtiofs: use domainLogContext qemu/dbus: keep a connection to the VM D-Bus qemu/dbus: log daemon stdout/err, use domainLogContext qemu: validate RDP configuration qemu: add qemu-rdp helper unit qemu: pass virQEMUDriverConfig to capabilities qemu: add 'rdp' capability if qemu-rdp is available qemu: add RDP support tests: add qemu <graphics type='rdp'/> test docs/formatdomain.rst | 25 +- meson.build | 7 +- po/POTFILES | 1 + src/conf/domain_conf.c | 28 +- src/conf/domain_conf.h | 5 +- src/conf/schemas/domaincommon.rng | 10 + src/libvirt_private.syms | 2 +- src/qemu/libvirtd_qemu.aug | 7 + src/qemu/meson.build | 1 + src/qemu/qemu.conf.in | 31 ++ src/qemu/qemu_capabilities.c | 24 +- src/qemu/qemu_capabilities.h | 12 +- src/qemu/qemu_command.c | 9 +- src/qemu/qemu_conf.c | 56 ++- src/qemu/qemu_conf.h | 13 + src/qemu/qemu_dbus.c | 69 ++- src/qemu/qemu_dbus.h | 3 + src/qemu/qemu_domain.c | 1 + src/qemu/qemu_domain.h | 4 + src/qemu/qemu_driver.c | 20 + src/qemu/qemu_extdevice.c | 46 +- src/qemu/qemu_hotplug.c | 49 ++- src/qemu/qemu_hotplug.h | 1 + src/qemu/qemu_process.c | 170 ++++++- src/qemu/qemu_rdp.c | 416 ++++++++++++++++++ src/qemu/qemu_rdp.h | 73 +++ src/qemu/qemu_slirp.c | 6 - src/qemu/qemu_validate.c | 48 +- src/qemu/qemu_virtiofs.c | 53 +-- src/qemu/test_libvirtd_qemu.aug.in | 5 + src/util/virgdbus.h | 13 +- .../domaincapsdata/qemu_10.0.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_10.0.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_10.0.0.s390x.xml | 1 + tests/domaincapsdata/qemu_10.0.0.x86_64.xml | 1 + .../domaincapsdata/qemu_7.0.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_7.0.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_7.0.0.x86_64.xml | 1 + .../domaincapsdata/qemu_7.1.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_7.1.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_7.1.0.x86_64.xml | 1 + .../qemu_7.2.0-hvf.x86_64+hvf.xml | 1 + .../domaincapsdata/qemu_7.2.0-q35.x86_64.xml | 1 + .../qemu_7.2.0-tcg.x86_64+hvf.xml | 1 + .../domaincapsdata/qemu_7.2.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_7.2.0.ppc.xml | 1 + tests/domaincapsdata/qemu_7.2.0.x86_64.xml | 1 + .../domaincapsdata/qemu_8.0.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_8.0.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_8.0.0.x86_64.xml | 1 + .../domaincapsdata/qemu_8.1.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_8.1.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_8.1.0.s390x.xml | 1 + tests/domaincapsdata/qemu_8.1.0.x86_64.xml | 1 + .../domaincapsdata/qemu_8.2.0-q35.x86_64.xml | 1 + .../qemu_8.2.0-tcg-virt.loongarch64.xml | 1 + .../domaincapsdata/qemu_8.2.0-tcg.x86_64.xml | 1 + .../qemu_8.2.0-virt.aarch64.xml | 1 + .../qemu_8.2.0-virt.loongarch64.xml | 1 + tests/domaincapsdata/qemu_8.2.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_8.2.0.armv7l.xml | 1 + tests/domaincapsdata/qemu_8.2.0.s390x.xml | 1 + tests/domaincapsdata/qemu_8.2.0.x86_64.xml | 1 + .../domaincapsdata/qemu_9.0.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_9.0.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_9.0.0.sparc.xml | 1 + tests/domaincapsdata/qemu_9.0.0.x86_64.xml | 1 + .../domaincapsdata/qemu_9.1.0-q35.x86_64.xml | 1 + .../qemu_9.1.0-tcg-virt.riscv64.xml | 1 + .../domaincapsdata/qemu_9.1.0-tcg.x86_64.xml | 1 + .../qemu_9.1.0-virt.riscv64.xml | 1 + tests/domaincapsdata/qemu_9.1.0.s390x.xml | 1 + tests/domaincapsdata/qemu_9.1.0.x86_64.xml | 1 + .../domaincapsdata/qemu_9.2.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_9.2.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_9.2.0.s390x.xml | 1 + tests/domaincapsdata/qemu_9.2.0.x86_64.xml | 1 + tests/domaincapstest.c | 7 +- .../graphics-rdp.x86_64-latest.args | 35 ++ .../graphics-rdp.x86_64-latest.xml | 1 + tests/qemuxmlconfdata/graphics-rdp.xml | 43 ++ tests/qemuxmlconftest.c | 2 + tests/testutilsqemu.c | 10 + tools/nss/libvirt_nss_leases.c | 2 +- tools/nss/libvirt_nss_macs.c | 2 +- 85 files changed, 1218 insertions(+), 138 deletions(-) create mode 100644 src/qemu/qemu_rdp.c create mode 100644 src/qemu/qemu_rdp.h create mode 100644 tests/qemuxmlconfdata/graphics-rdp.x86_64-latest.args create mode 120000 tests/qemuxmlconfdata/graphics-rdp.x86_64-latest.xml create mode 100644 tests/qemuxmlconfdata/graphics-rdp.xml -- 2.47.0

4 42

[PATCH] news: Add item for guest load averages
by Martin Kletzander 17 Mar '25

17 Mar '25

Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- NEWS.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 9c940b1a8176..d7d40cf5546d 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -17,6 +17,8 @@ v11.2.0 (unreleased) * **New features** + * qemu: Added guest load averages to the output of virDomainGetGuestInfo + * **Improvements** * **Bug fixes** -- 2.48.1

2 2

[PATCH] docs: document workaround for DMARC countermeasures
by Daniel P. Berrangé 17 Mar '25

17 Mar '25

From: Daniel P. Berrangé <berrange(a)redhat.com> If a contributor's email domain has a DMARC policy of 'p=quarantine' or 'p=reject', mailman will apply DMARC countermeasures on all mails sent to lists.libvirt.org rewriting the "From" header to remove the sender's email address. e.g. From: Your Name via <lists.libvirt.org> If these countermeasures were not applied, affected mail would either have gon directly to SPAM, or have been entirely rejected. Mailman3 is unable to be configured to guarantee no mangling of the mail body so these countermeasures are unavoidable for lists.libvirt.org. Amongst the various downsides, the From address rewriting has the bad effect of mangling git commit author attribution. To avoid this it is required to add two additional git config settings: $ git config --global format.from "Your Name <your(a)email.com>" $ git config --global format.forceInBodyFrom true Note, *both* are required, even if your ``format.from`` matches your existing git identity, because the latter only takes effect once the former is set. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- docs/submitting-patches.rst | 66 ++++++++++++++++++++++++++++--------- 1 file changed, 51 insertions(+), 15 deletions(-) diff --git a/docs/submitting-patches.rst b/docs/submitting-patches.rst index a5e108550a..b22e4e03b4 100644 --- a/docs/submitting-patches.rst +++ b/docs/submitting-patches.rst @@ -43,21 +43,7 @@ series of two or more patches needs a cover letter. Note that the ``git send-email`` subcommand may not be in the main git package and using it may require installation of a separate package, for example the "git-email" package in Fedora -and Debian. If this is your first time using -``git send-email``, you might need to configure it to point it -to your SMTP server with something like: - -:: - - $ git config --global sendemail.smtpServer stmp.youremailprovider.net - -If you get tired of typing ``--to=devel(a)lists.libvirt.org`` all -the time, you can configure that to be automatically handled as -well: - -:: - - $ git config sendemail.to devel(a)lists.libvirt.org +and Debian. Avoid using mail clients for sending patches, as most of them will mangle the messages in some way, making them unusable for @@ -88,6 +74,56 @@ Moreover, such patch needs to be prefixed correctly with ``git send-email`` (substitute ``v2`` with the correct version if needed though). +Git Configuration +----------------- + +If this is your first time using ``git send-email``, you will probably +need to setup your global git configuration, to point to your outgoing +SMTP server with something like: + +:: + + $ git config --global sendemail.smtpServer stmp.youremailprovider.net + +If your email provider (often your employer) has configured a DMARC +policy for their domain, there are some additional settings that will +be required. Before doing this, check the DMARC policy with + +:: + + $ host -t txt _dmarc.$YOURDOMAIN.COM + +If this returns no output, or contains ``p=none`` then no configuration +is required. If it reports ``p=quarantine`` or ``p=reject``, then the +libvirt lists will apply DMARC countermeasures to your email. To ensure +that git authorship is preserved add + +:: + + $ git config --global format.from "Your Name <your(a)email.com>" + $ git config --global format.forceInBodyFrom true + +This will force git to always add an additional line + +:: + + From: Your Name <your(a)email.com> + +in the body of the patch, guaranteeing correct author records even +when the main ``From`` header is rewritten by mailman. + +If you get tired of typing ``--to=devel(a)lists.libvirt.org`` all +the time, you can configure that to be automatically handled by +adding a local repository setting: + +:: + + $ git config sendemail.to devel(a)lists.libvirt.org + +This last setting is not required if using ``git-publish`` to send +patches, as that auto-identifies the mailing list address from its +config file stored in git. + Review process -------------- -- 2.48.1

3 3

[PATCHv2 0/2] ch: minor fixes - segfault and last meaningful error preservation
by Kirill Shchetiniuk 17 Mar '25

17 Mar '25

During fixing some other issue found out a few minor bugs related to CH driver. First bug is related to monitor object ref count in virCHStartEventHandler and virCHEventHandlerLoop, as object was unrefed by parent while is still used by child thread. Moved object unref to the correct place to the correct thread. Second bug is related to v object ref count in virCHStartEventHandler, as vm object was unrefed, while is still used later, move object unref to after its last usage. Third bug is related to error handling and propagation. Last meaninful error was reset by virCHProcessStop, which have led to unknown error message in virsh. Add error preservation at the begining of the function and restoring it at the end to keep consistent error output Kirill Shchetiniuk (2): ch: virCHProcessStop preserve last meaningful error ch: ref count fix in virCHEventHandlerLoop and virCHStartEventHandler src/ch/ch_events.c | 4 ++-- src/ch/ch_process.c | 5 +++++ 2 files changed, 7 insertions(+), 2 deletions(-) -- 2.48.1

2 3

[PATCH] docs: Fix some types
by Thomas Huth 17 Mar '25

17 Mar '25

From: Thomas Huth <thuth(a)redhat.com> Found with the codespell utility. Signed-off-by: Thomas Huth <thuth(a)redhat.com> --- docs/formatcaps.rst | 2 +- docs/formatdomain.rst | 4 ++-- docs/glib-adoption.rst | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/formatcaps.rst b/docs/formatcaps.rst index da6b215780..7e525487e7 100644 --- a/docs/formatcaps.rst +++ b/docs/formatcaps.rst @@ -39,7 +39,7 @@ The ``<host/>`` element consists of the following child elements: The host CPU architecture and features. Note that, while this element contains a ``topology`` sub-element, - the information contained therein is farily high-level and likely + the information contained therein is fairly high-level and likely not very useful when it comes to optimizing guest vCPU placement. Look into the ``topology`` *element*, described below, for more detailed information. diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index c1876ad467..4bc6a318f5 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -3468,7 +3468,7 @@ paravirtualized driver is specified via the ``disk`` element. automatically distributed among the configured iothreads. Optionally the ``iothread`` element can have multiple ``queue`` - subelements with mandatory ``id`` atribute specifying that the iothread + subelements with mandatory ``id`` attribute specifying that the iothread should be used to handle given virt queue. If queue mapping is present the ``queues`` attribute of ``driver`` must be configured and all configured virt queues must be included in the mapping. The @@ -8423,7 +8423,7 @@ Example: usage of external TPM emulator :since:`Since 9.0.0` This element does not work with the ``passthrough`` backend. - When specified, it is the user's responsability to prevent files from being + When specified, it is the user's responsibility to prevent files from being used by multiple VMs or emulators (swtpm will also use advisory locking). If not specified, the storage configuration is left to libvirt discretion. diff --git a/docs/glib-adoption.rst b/docs/glib-adoption.rst index f969ac80a1..c2cec80eea 100644 --- a/docs/glib-adoption.rst +++ b/docs/glib-adoption.rst @@ -32,7 +32,7 @@ Array operations https://developer.gnome.org/glib/stable/glib-Arrays.html - Instead of using plain C arrays, it is preferrable to use one of + Instead of using plain C arrays, it is preferable to use one of the GLib types, ``GArray``, ``GPtrArray`` or ``GByteArray``. These all use a struct to track the array memory and size together and efficiently resize. -- 2.48.1

3 3

[PATCH] docs: remove references to removed APIs
by Daniel P. Berrangé 17 Mar '25

17 Mar '25

The glib adoption docs was suggesting avoidance of certain APIs that were obsoleted by glib, during the transition period. Now that the referenced APIs no longer exist in libvirt code, they can also be removed from the docs. NB, the virStringListRemoveDuplicates method remains since there is no glib equivalent. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- docs/glib-adoption.rst | 22 ---------------------- 1 file changed, 22 deletions(-) diff --git a/docs/glib-adoption.rst b/docs/glib-adoption.rst index f969ac80a1..046cd821f7 100644 --- a/docs/glib-adoption.rst +++ b/docs/glib-adoption.rst @@ -14,19 +14,6 @@ the GLib APIs straight away where possible. The following is a list of libvirt APIs that should no longer be used in new code, and their suggested GLib replacements: -Memory allocation - ``VIR_ALLOC``, ``VIR_REALLOC``, ``VIR_RESIZE_N``, - ``VIR_EXPAND_N``, ``VIR_SHRINK_N``, ``VIR_FREE`` - - https://developer.gnome.org/glib/stable/glib-Memory-Allocation.html - - Prefer the GLib APIs ``g_new0``/``g_renew``/ ``g_free`` in most - cases. There should rarely be a need to use - ``g_malloc``/``g_realloc``. **NEVER MIX** use of the classic - libvirt memory allocation APIs and GLib APIs within a single - method. Keep the style consistent, converting existing code to - GLib style in a separate, prior commit. - Array operations ``VIR_APPEND_ELEMENT``, ``VIR_INSERT_ELEMENT``, ``VIR_DELETE_ELEMENT`` @@ -37,15 +24,6 @@ Array operations These all use a struct to track the array memory and size together and efficiently resize. -String arrays - ``virStringList*``, ``virStringListCount*`` - - https://developer.gnome.org/glib/stable/glib-String-Utility-Functions.html - - Prefer the NULL-terminated variant instead of storing the count - separately. Prefer ``g_str*v`` functions instead of their ``vir*`` - counterparts. For use with ``g_auto`` GLib provides the ``GStrv`` type. - Objects ``virObject`` -- 2.48.1

2 1

[PATCH] scripts: add execute permission to several files
by Daniel P. Berrangé 17 Mar '25

17 Mar '25

From: Daniel P. Berrangé <berrange(a)redhat.com> Most, but not all, files in scripts have execute permission. While we don't need this in order to launch them via meson/ninja build rules, it is nice to direct execution if they have execution permission. This makes the practice consistent across all scripts. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- scripts/check-drivername.py | 0 scripts/check-remote-protocol.py | 0 scripts/header-ifdef.py | 0 scripts/meson-install-dirs.py | 0 scripts/meson-install-symlink.py | 0 scripts/mock-noinline.py | 0 scripts/prohibit-duplicate-header.py | 0 7 files changed, 0 insertions(+), 0 deletions(-) mode change 100644 => 100755 scripts/check-drivername.py mode change 100644 => 100755 scripts/check-remote-protocol.py mode change 100644 => 100755 scripts/header-ifdef.py mode change 100644 => 100755 scripts/meson-install-dirs.py mode change 100644 => 100755 scripts/meson-install-symlink.py mode change 100644 => 100755 scripts/mock-noinline.py mode change 100644 => 100755 scripts/prohibit-duplicate-header.py diff --git a/scripts/check-drivername.py b/scripts/check-drivername.py old mode 100644 new mode 100755 diff --git a/scripts/check-remote-protocol.py b/scripts/check-remote-protocol.py old mode 100644 new mode 100755 diff --git a/scripts/header-ifdef.py b/scripts/header-ifdef.py old mode 100644 new mode 100755 diff --git a/scripts/meson-install-dirs.py b/scripts/meson-install-dirs.py old mode 100644 new mode 100755 diff --git a/scripts/meson-install-symlink.py b/scripts/meson-install-symlink.py old mode 100644 new mode 100755 diff --git a/scripts/mock-noinline.py b/scripts/mock-noinline.py old mode 100644 new mode 100755 diff --git a/scripts/prohibit-duplicate-header.py b/scripts/prohibit-duplicate-header.py old mode 100644 new mode 100755 -- 2.48.1

2 1

Fwd: system cache dropped
by matus valentin 17 Mar '25

17 Mar '25

Hi, I have a setup with multiple virtual machines (VMs) running on one host, each with a saved state. All VMs share the same parent, which is located on a shared drive. Whenever I restore any VM using virsh restore, the parent is dropped from the system cache, causing all data to be downloaded from the shared drive again. This results in unnecessary network traffic, even though the parent changes very rarely. However, if I create a child from the parent and call virsh create to create a new VM, the parent is never dropped from the system cache. Is this expected behavior? Should the parent be retained in the system cache during a virsh restore operation? Are there any configurations or settings that can prevent the parent from being dropped from the cache? thanks

1 0