Fwd: system cache dropped
by matus valentin
Hi,
I have a setup with multiple virtual machines (VMs) running on one host,
each with a saved state. All VMs share the same parent, which is located on
a shared drive. Whenever I restore any VM using virsh restore, the parent
is dropped from the system cache, causing all data to be downloaded from
the shared drive again. This results in unnecessary network traffic, even
though the parent changes very rarely. However, if I create a child from
the parent and call virsh create to create a new VM, the parent is never
dropped from the system cache.
Is this expected behavior? Should the parent be retained in the system
cache during a virsh restore operation? Are there any configurations or
settings that can prevent the parent from being dropped from the cache?
thanks
2 weeks, 2 days
[PATCH] rpm: Enable KVM for riscv64 on RHEL 10+
by Andrea Bolognani
Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
---
libvirt.spec.in | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index cb41ea1de1..9217820137 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -8,7 +8,9 @@
%define arches_qemu_kvm %{ix86} x86_64 %{power64} %{arm} aarch64 s390x riscv64
%if 0%{?rhel}
- %if 0%{?rhel} > 8
+ %if 0%{?rhel} >= 10
+ %define arches_qemu_kvm x86_64 aarch64 s390x riscv64
+ %elif 0%{?rhel} >= 9
%define arches_qemu_kvm x86_64 aarch64 s390x
%else
%define arches_qemu_kvm x86_64 %{power64} aarch64 s390x
--
2.48.1
2 weeks, 5 days
[PATCH] NEWS: Mention new 'image_format' parameter for virDomainSaveParams
by Jim Fehlig
Signed-off-by: Jim Fehlig <jfehlig(a)suse.com>
---
NEWS.rst | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index 9c940b1a81..d08a18dc02 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -17,6 +17,14 @@ v11.2.0 (unreleased)
* **New features**
+ * qemu: Add new 'image_format' parameter to virDomainSaveParams
+
+ ``virDomainSaveParams`` now supports an ``image_format`` parameter for
+ specifying the save image format on a per-domain basis. The parameter
+ accepts the same values as the driver-wide ``save_image_format`` setting
+ in ``qemu.conf``. An image format specified via ``virDomainSaveParams``
+ takes precedence over the driver-wide setting.
+
* **Improvements**
* **Bug fixes**
--
2.43.0
2 weeks, 5 days
[libvirt PATCH 00/10] Unused cleanups
by Ján Tomko
Patches 4-9/10 all depend on patch 3/10
10/10 can be pushed independently
Ján Tomko (10):
qemu: seccomp sandbox: remove incorect G_GNUC_UNUSED marker
qemu: validate: fs: remove unneeded parameter
qemu: remove qemuCaps from qemuBuildObjectCommandlineFromJSON
qemu: remove qemuCaps from qemuBuildObjectSecretCommandLine
qemu: remove qemuCaps from qemuBuildTLSx509CommandLine
qemu: remove qemuCaps from qemuBuildObjectCommandline
qemu: remove qemuCaps from qemuBuildIOThreadCommandLine
qemu: remove unused vm from qemuBuildSEVSNPCommandLine
qemu: remove unused vm from qemuBuildPVCommandLine
Remove unreachable breaks right after return
src/qemu/qemu_cgroup.c | 2 -
src/qemu/qemu_command.c | 110 +++++++++++++------------------
src/qemu/qemu_driver.c | 1 -
src/qemu/qemu_hotplug.c | 1 -
src/qemu/qemu_monitor_json.c | 1 -
src/qemu/qemu_validate.c | 3 +-
src/security/security_apparmor.c | 1 -
src/vmx/vmx.c | 2 -
tools/virsh-domain.c | 1 -
tools/virsh-host.c | 2 -
tools/vsh.c | 7 --
11 files changed, 48 insertions(+), 83 deletions(-)
--
2.48.1
2 weeks, 6 days
[PATCH 0/2] src: make it easier to updat the protocol structs files
by Daniel P. Berrangé
This introduces a new target:
ninja -C build regen-admin_protocol
and equiv for other protocol files
Daniel P. Berrangé (2):
src: normalize whitespace in protocol structs files
src: add new target for regenerating protocol structs files
scripts/check-remote-protocol.py | 27 ++++++++++++++++++++++++++-
src/admin_protocol-structs | 2 +-
src/meson.build | 14 ++++++++++++++
src/qemu_protocol-structs | 2 +-
src/remote_protocol-structs | 6 +++---
5 files changed, 45 insertions(+), 6 deletions(-)
--
2.48.1
2 weeks, 6 days
[PATCH 0/6] Couple of memleak fixes
by Michal Privoznik
*** BLURB HERE ***
Michal Prívozník (6):
network: Free inhibitor in networkStateCleanup()
ch: Free retval of curl_slist_append()
ch: Don't leak virCHDomainObjPrivate struct members
ch: Free @iothreads array in virCHProcessSetupIOThreads()
ch: Unref @cfg in virCHProcessStop()
ch: Rework virCHProcessConnectMonitor()
src/ch/ch_domain.c | 3 +++
src/ch/ch_monitor.c | 3 +++
src/ch/ch_process.c | 22 +++++++++++++---------
src/network/bridge_driver.c | 2 ++
4 files changed, 21 insertions(+), 9 deletions(-)
--
2.48.1
2 weeks, 6 days
[PATCH 00/17] qemu: Clean up various unneeded capabilities
by Peter Krempa
The recent bump of minimum qemu version resulted into some capabilities
always being present. I've noticed one while doing a review and from
there I removed a few others, mostly storage related ones as well.
Peter Krempa (17):
qemuBuildCompatDeprecatedCommandLine: Assume that
QEMU_CAPS_COMPAT_DEPRECATED is supported
qemu: capabilities: Retire QEMU_CAPS_COMPAT_DEPRECATED
qemuBuildObjectCommandlineFromJSON: Assume all qemus support
QEMU_CAPS_OBJECT_JSON
qemu: monitor: Drop support for extra wrapper for 'object_add'
util: Drop 'virQEMUBuildCommandLineJSONArrayBitmap'
qemu: capabilities: Retire QEMU_CAPS_OBJECT_JSON
qemu: monitor: Always assume support for
QEMU_CAPS_QMP_QUERY_NAMED_BLOCK_NODES_FLAT
qemu: capabilities: Retire QEMU_CAPS_QMP_QUERY_NAMED_BLOCK_NODES_FLAT
qemu: Always assume supprot for QEMU_CAPS_BLOCKDEV_REOPEN
qemu: capabilities: Retire QEMU_CAPS_BLOCKDEV_REOPEN
qemu: Always assume support for
QEMU_CAPS_BLOCKDEV_SNAPSHOT_ALLOW_WRITE_ONLY
qemu: capabilities: Retire
QEMU_CAPS_BLOCKDEV_SNAPSHOT_ALLOW_WRITE_ONLY
qemu: Always assume support for QEMU_CAPS_INCREMENTAL_BACKUP
qemu: capabilites: Retire QEMU_CAPS_INCREMENTAL_BACKUP
qemu: domain: Remove qemuDomainSupportsCheckpointsBlockjobs
qemu: migration: Always assume support for
QEMU_CAPS_MIGRATION_PARAM_BLOCK_BITMAP_MAPPING
qemu: capabilites: Retire
QEMU_CAPS_MIGRATION_PARAM_BLOCK_BITMAP_MAPPING
src/libvirt_private.syms | 1 -
src/qemu/qemu_backup.c | 18 ---------
src/qemu/qemu_block.c | 4 --
src/qemu/qemu_blockjob.c | 20 ++--------
src/qemu/qemu_capabilities.c | 33 +++++------------
src/qemu/qemu_capabilities.h | 14 +++----
src/qemu/qemu_checkpoint.c | 18 +--------
src/qemu/qemu_command.c | 31 +++-------------
src/qemu/qemu_domain.c | 23 ------------
src/qemu/qemu_domain.h | 4 --
src/qemu/qemu_driver.c | 37 +++++--------------
src/qemu/qemu_migration.c | 10 +----
src/qemu/qemu_monitor.c | 28 +-------------
src/qemu/qemu_monitor_json.c | 2 +-
src/qemu/qemu_monitor_priv.h | 4 --
src/qemu/qemu_snapshot.c | 4 --
src/util/virqemu.c | 36 ------------------
src/util/virqemu.h | 3 --
.../caps_10.0.0_s390x.xml | 7 ----
.../caps_10.0.0_x86_64+amdsev.xml | 7 ----
.../caps_10.0.0_x86_64.xml | 7 ----
.../qemucapabilitiesdata/caps_6.2.0_ppc64.xml | 7 ----
.../caps_6.2.0_x86_64.xml | 7 ----
.../qemucapabilitiesdata/caps_7.0.0_ppc64.xml | 7 ----
.../caps_7.0.0_x86_64.xml | 7 ----
.../qemucapabilitiesdata/caps_7.1.0_ppc64.xml | 7 ----
.../caps_7.1.0_x86_64.xml | 7 ----
tests/qemucapabilitiesdata/caps_7.2.0_ppc.xml | 7 ----
.../caps_7.2.0_x86_64+hvf.xml | 7 ----
.../caps_7.2.0_x86_64.xml | 7 ----
.../caps_8.0.0_x86_64.xml | 7 ----
.../qemucapabilitiesdata/caps_8.1.0_s390x.xml | 7 ----
.../caps_8.1.0_x86_64.xml | 7 ----
.../caps_8.2.0_aarch64.xml | 7 ----
.../caps_8.2.0_armv7l.xml | 7 ----
.../caps_8.2.0_loongarch64.xml | 7 ----
.../qemucapabilitiesdata/caps_8.2.0_s390x.xml | 7 ----
.../caps_8.2.0_x86_64.xml | 7 ----
.../qemucapabilitiesdata/caps_9.0.0_sparc.xml | 7 ----
.../caps_9.0.0_x86_64.xml | 7 ----
.../caps_9.1.0_riscv64.xml | 7 ----
.../qemucapabilitiesdata/caps_9.1.0_s390x.xml | 7 ----
.../caps_9.1.0_x86_64.xml | 7 ----
.../caps_9.2.0_aarch64+hvf.xml | 7 ----
.../qemucapabilitiesdata/caps_9.2.0_s390x.xml | 7 ----
.../caps_9.2.0_x86_64+amdsev.xml | 7 ----
.../caps_9.2.0_x86_64.xml | 7 ----
tests/qemucommandutiltest.c | 30 ---------------
48 files changed, 40 insertions(+), 483 deletions(-)
--
2.48.1
2 weeks, 6 days
[PATCH v4 0/1] add RAPL feature in libvirt
by Anthony Harivel
Hi,
The enhancement in this new version based on last feedback are:
* add more documentation on limitation of the feature
* no more double check of the vmsr socket, once is enough
* virQEMUBuildBufferEscapeComma() is used for user input Path
Because there is no garantie at the moment that the helper will be one
day managed by libvirt, I decided not adding any preparation about this
to avoid any confusion but add more documentation.
If the helper is managed in libvirt, the patch introducing it will also
add the necessary API like mention on the previous review (i.e
mode='unmanaged').
Thanks
Anthony
Anthony Harivel (1):
qemu: Add support for RAPL MSRs feature
docs/formatdomain.rst | 15 +++++++++++++++
src/conf/domain_conf.c | 18 ++++++++++++++++++
src/conf/domain_conf.h | 2 ++
src/conf/schemas/domaincommon.rng | 10 ++++++++++
src/qemu/qemu_command.c | 9 +++++++++
tests/qemuxmlconfdata/kvm-features-off.xml | 1 +
.../kvm-features.x86_64-latest.args | 2 +-
tests/qemuxmlconfdata/kvm-features.xml | 1 +
8 files changed, 57 insertions(+), 1 deletion(-)
--
2.48.1
2 weeks, 6 days
[PATCH] domainbackupxml2xml: Add test case with unix socket server for pull mode backup
by Peter Krempa
While we show the example in the docs we don't have an example XML for
exrecrcising the parser/formatter and schema.
Signed-off-by: Peter Krempa <pkrempa(a)redhat.com>
---
.../backup-pull-unix.xml | 22 ++++++++++++++++++
.../backup-pull-unix.xml | 23 +++++++++++++++++++
tests/genericxml2xmltest.c | 1 +
3 files changed, 46 insertions(+)
create mode 100644 tests/domainbackupxml2xmlin/backup-pull-unix.xml
create mode 100644 tests/domainbackupxml2xmlout/backup-pull-unix.xml
diff --git a/tests/domainbackupxml2xmlin/backup-pull-unix.xml b/tests/domainbackupxml2xmlin/backup-pull-unix.xml
new file mode 100644
index 0000000000..cde9ceafc9
--- /dev/null
+++ b/tests/domainbackupxml2xmlin/backup-pull-unix.xml
@@ -0,0 +1,22 @@
+<domainbackup mode='pull'>
+ <incremental>1525889631</incremental>
+ <server transport='unix' socket='/path/to/server'/>
+ <disks>
+ <disk name='vda' type='file'>
+ <scratch file='/path/to/file'/>
+ </disk>
+ <disk name='hda' backup='no'/>
+ <disk name='vdc' type='file' backupmode='full'>
+ <scratch file='/path/to/file'/>
+ </disk>
+ <disk name='vdd' type='file' backupmode='incremental'>
+ <scratch file='/path/to/file'/>
+ </disk>
+ <disk name='vde' type='file' backupmode='incremental' incremental='blah'>
+ <scratch file='/path/to/file'/>
+ </disk>
+ <disk name='vdf' type='file' incremental='bleh'>
+ <scratch file='/path/to/file'/>
+ </disk>
+ </disks>
+</domainbackup>
diff --git a/tests/domainbackupxml2xmlout/backup-pull-unix.xml b/tests/domainbackupxml2xmlout/backup-pull-unix.xml
new file mode 100644
index 0000000000..811edfdf39
--- /dev/null
+++ b/tests/domainbackupxml2xmlout/backup-pull-unix.xml
@@ -0,0 +1,23 @@
+<domainbackup mode='pull'>
+ <incremental>1525889631</incremental>
+ <server transport='unix' socket='/path/to/server'/>
+ <disks>
+ <disk name='vda' backup='yes' type='file' backupmode='incremental' incremental='1525889631'>
+ <scratch file='/path/to/file'/>
+ </disk>
+ <disk name='hda' backup='no'/>
+ <disk name='vdc' backup='yes' type='file' backupmode='full'>
+ <scratch file='/path/to/file'/>
+ </disk>
+ <disk name='vdd' backup='yes' type='file' backupmode='incremental' incremental='1525889631'>
+ <scratch file='/path/to/file'/>
+ </disk>
+ <disk name='vde' backup='yes' type='file' backupmode='incremental' incremental='blah'>
+ <scratch file='/path/to/file'/>
+ </disk>
+ <disk name='vdf' backup='yes' type='file' backupmode='incremental' incremental='bleh'>
+ <scratch file='/path/to/file'/>
+ </disk>
+ <disk name='vdextradisk' backup='no'/>
+ </disks>
+</domainbackup>
diff --git a/tests/genericxml2xmltest.c b/tests/genericxml2xmltest.c
index 61613d21f9..b46b9515c3 100644
--- a/tests/genericxml2xmltest.c
+++ b/tests/genericxml2xmltest.c
@@ -244,6 +244,7 @@ mymain(void)
DO_TEST_BACKUP("empty");
DO_TEST_BACKUP("backup-pull");
+ DO_TEST_BACKUP("backup-pull-unix");
DO_TEST_BACKUP("backup-pull-seclabel");
DO_TEST_BACKUP("backup-pull-encrypted");
DO_TEST_BACKUP("backup-push");
--
2.48.1
3 weeks
[PATCH 0/2] Remove libnl checks specific to Linux
by Akihiko Odaki
Supersedes: <20250308-require-v1-1-fe6850bf3f30(a)daynix.com>
("[PATCH] util: Require libnl for Linux")
Based on previous discussions, this implements yet another approach to
fix builds without libnl for Linux.
Signed-off-by: Akihiko Odaki <akihiko.odaki(a)daynix.com>
---
Akihiko Odaki (2):
Remove libnl checks specific to Linux
virnetlink: Remove stub functions
src/libvirt_libnl.syms | 23 ++++++
src/libvirt_private.syms | 19 -----
src/meson.build | 6 ++
src/remote/remote_daemon.c | 10 ++-
src/util/meson.build | 5 +-
src/util/virarptable.c | 2 +-
src/util/virnetdev.c | 44 +---------
src/util/virnetdevbridge.c | 33 ++------
src/util/virnetlink.c | 196 +++------------------------------------------
src/util/virnetlink.h | 11 +--
tests/virnetdevtest.c | 10 +--
11 files changed, 65 insertions(+), 294 deletions(-)
---
base-commit: e5299ddf86121d3c792ca271ffcb54900eb19dc3
change-id: 20250312-linux-30e6e1af51a5
Best regards,
--
Akihiko Odaki <akihiko.odaki(a)daynix.com>
3 weeks
