March 2025 - Devel - libvirt List Archives

[PATCH] esx: Refactor esxVI_LookupHostScsiTopologyLunListByTargetName
by Jiri Denemark 11 Mar '25

11 Mar '25

With a specific combination of compiler options gcc reported the following bogus warning (I added a context to it to make the issue visible): ../src/esx/esx_vi.c: In function ‘esxVI_LookupHostScsiTopologyLunListByTargetName’: ../src/esx/esx_vi.c:4674:32: error: potential null pointer dereference [-Werror=null-dereference] 4671 | if (!found || !hostScsiTopologyTarget) 4672 | goto cleanup; 4673 | 4674 | if (!hostScsiTopologyTarget->lun) { | ~~~~~~~~~~~~~~~~~~~~~~^~~~~ Most likely this is caused by found and hostScsiTopologyTarget doing essentially the same thing as found is true if and only if hostScsiTopologyTarget is non-NULL. The found variable is completely redundant. Removing it would be enough, but I decided to make the code a little bit easier to read by not using the iterator variable directly. Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/esx/esx_vi.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/src/esx/esx_vi.c b/src/esx/esx_vi.c index e2589aa69a..aee649b86e 100644 --- a/src/esx/esx_vi.c +++ b/src/esx/esx_vi.c @@ -4616,7 +4616,6 @@ esxVI_LookupHostScsiTopologyLunListByTargetName esxVI_HostScsiTopologyInterface *hostScsiInterfaceList = NULL; esxVI_HostScsiTopologyInterface *hostScsiInterface = NULL; esxVI_HostScsiTopologyTarget *hostScsiTopologyTarget = NULL; - bool found = false; esxVI_HostInternetScsiTargetTransport *candidate = NULL; ESX_VI_CHECK_ARG_LIST(hostScsiTopologyLunList); @@ -4653,22 +4652,21 @@ esxVI_LookupHostScsiTopologyLunListByTargetName /* See vSphere API documentation about HostScsiTopologyInterface */ for (hostScsiInterface = hostScsiInterfaceList; - hostScsiInterface && !found; + hostScsiInterface && !hostScsiTopologyTarget; hostScsiInterface = hostScsiInterface->_next) { - for (hostScsiTopologyTarget = hostScsiInterface->target; - hostScsiTopologyTarget; - hostScsiTopologyTarget = hostScsiTopologyTarget->_next) { + esxVI_HostScsiTopologyTarget *target; + for (target = hostScsiInterface->target; target; target = target->_next) { candidate = esxVI_HostInternetScsiTargetTransport_DynamicCast - (hostScsiTopologyTarget->transport); + (target->transport); if (candidate && STREQ(candidate->iScsiName, name)) { - found = true; + hostScsiTopologyTarget = target; break; } } } - if (!found || !hostScsiTopologyTarget) + if (!hostScsiTopologyTarget) goto cleanup; if (!hostScsiTopologyTarget->lun) { -- 2.48.1

2 1

[PATCH 0/3] Full boot order support on s390x
by Boris Fiuczynski 11 Mar '25

11 Mar '25

This series adds on s390x full boot order support which has been introduced recently in QEMU with the PR https://lore.kernel.org/qemu-devel/20241023131710.906748-1-thuth@redhat.com/ The replies and xml files are removed from the patch in this series and are available in https://gitlab.com/fiuczy/libvirt/-/commits/fullbootorder Boris Fiuczynski (3): qemu: capabilities: Add QEMU_CAPS_VIRTIO_CCW_DEVICE_LOADPARM tests: add capabilities for QEMU 9.2.0 on s390x qemu: command: add multi boot device support on s390x src/qemu/qemu_capabilities.c | 8 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 40 +- src/qemu/qemu_command.h | 6 +- src/qemu/qemu_hotplug.c | 6 +- tests/domaincapsdata/qemu_9.2.0.s390x.xml | 311 + .../caps_5.2.0_s390x.replies | 321 +- .../caps_6.0.0_s390x.replies | 321 +- .../caps_8.1.0_s390x.replies | 321 +- .../caps_8.2.0_s390x.replies | 321 +- .../caps_9.1.0_s390x.replies | 321 +- .../caps_9.2.0_s390x.replies | 36741 ++++++++++++++++ .../qemucapabilitiesdata/caps_9.2.0_s390x.xml | 3752 ++ .../machine-loadparm-hostdev.s390x-9.1.0.args | 33 + .../machine-loadparm-hostdev.s390x-9.1.0.xml | 33 + ...machine-loadparm-hostdev.s390x-latest.args | 4 +- ...-multiple-disks-nets-s390.s390x-9.1.0.args | 40 + ...m-multiple-disks-nets-s390.s390x-9.1.0.xml | 51 + ...multiple-disks-nets-s390.s390x-latest.args | 8 +- ...machine-loadparm-net-s390.s390x-9.1.0.args | 34 + .../machine-loadparm-net-s390.s390x-9.1.0.xml | 32 + ...achine-loadparm-net-s390.s390x-latest.args | 4 +- .../machine-loadparm-s390.s390x-9.1.0.args | 34 + .../machine-loadparm-s390.s390x-9.1.0.xml | 33 + .../machine-loadparm-s390.s390x-latest.args | 4 +- tests/qemuxmlconftest.c | 4 + 26 files changed, 42664 insertions(+), 120 deletions(-) create mode 100644 tests/domaincapsdata/qemu_9.2.0.s390x.xml create mode 100644 tests/qemucapabilitiesdata/caps_9.2.0_s390x.replies create mode 100644 tests/qemucapabilitiesdata/caps_9.2.0_s390x.xml create mode 100644 tests/qemuxmlconfdata/machine-loadparm-hostdev.s390x-9.1.0.args create mode 100644 tests/qemuxmlconfdata/machine-loadparm-hostdev.s390x-9.1.0.xml create mode 100644 tests/qemuxmlconfdata/machine-loadparm-multiple-disks-nets-s390.s390x-9.1.0.args create mode 100644 tests/qemuxmlconfdata/machine-loadparm-multiple-disks-nets-s390.s390x-9.1.0.xml create mode 100644 tests/qemuxmlconfdata/machine-loadparm-net-s390.s390x-9.1.0.args create mode 100644 tests/qemuxmlconfdata/machine-loadparm-net-s390.s390x-9.1.0.xml create mode 100644 tests/qemuxmlconfdata/machine-loadparm-s390.s390x-9.1.0.args create mode 100644 tests/qemuxmlconfdata/machine-loadparm-s390.s390x-9.1.0.xml -- 2.45.0

2 11

[PATCH v1 0/3] Introduce qemuDomainSetVcpuTuneParameters API
by yong.huang＠smartx.com 11 Mar '25

11 Mar '25

From: Hyman Huang <yong.huang(a)smartx.com> This patchset is the prerequisite for the vCPU dirty-limit feature: https://patchew.org/Libvirt/cover.1703135535.git.yong.huang@smartx.com/ As suggested by Daniel: We've generally tried to avoid adding single purpose APIs for tunable parameters, instead using APIs with virTypedParameter arrays to allow bulk updates. I note that we don't appear to have any mechanism currently to set the VCPU scheduler tunables either Perhaps we should have a more general virDomainSetVCPUTuneParameters(virDomainPtr domain, int vcpu, virTypedParameterPtr params, unsigned int params, unsigned int flags); Refer the following link to see more details: https://patchew.org/Libvirt/169397083100.4628.15196043252714532301-0@git.sr… We present the qemuDomainSetVcpuTuneParameters API separately because the patchset is somewhat self-contained. Please review, Yong Hyman Huang (3): libvirt: Add virDomainSetVcpuTuneParameters API qemu_driver: Implement qemuDomainSetVcpuTuneParameters virsh: Use the new API to implement cmdSetvcpu include/libvirt/libvirt-domain.h | 25 ++++++++++++++ src/driver-hypervisor.h | 8 +++++ src/libvirt-domain.c | 56 ++++++++++++++++++++++++++++++++ src/libvirt_public.syms | 5 +++ src/qemu/qemu_driver.c | 29 +++++++++++++++++ src/remote/remote_driver.c | 1 + src/remote/remote_protocol.x | 20 +++++++++++- tools/virsh-domain.c | 10 +++++- 8 files changed, 152 insertions(+), 2 deletions(-) -- 2.27.0

4 6

[PATCH] conf: parse interface/source/@dev for all interface types (with backend type='passt')
by Laine Stump 10 Mar '25

10 Mar '25

The original implementation of the passt backend for vhost-user interfaces erroneously forgot to parse: <source dev='blah'/> for interface type='vhostuser', so it wasn't being added to the passt commandline, and also wasn't being saved to the domain config. Now we parse it no matter what the interface type, and then throw an error during validation if source/@dev was specified and backend type != 'passt' (or if interface type != 'user|vhostuser'). Fixes: 1e9054b9c79d721a55f413c2983c5370044f8f60 Resolves: https://issues.redhat.com/browse/RHEL-82539 Signed-off-by: Laine Stump <laine(a)redhat.com> --- src/conf/domain_conf.c | 10 +++++++--- src/conf/domain_validate.c | 5 +++++ .../net-vhostuser-passt.x86_64-latest.xml | 2 ++ 3 files changed, 14 insertions(+), 3 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index d555873848..5daa1f89e8 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -9938,14 +9938,18 @@ virDomainNetDefParseXML(virDomainXMLOption *xmlopt, break; case VIR_DOMAIN_NET_TYPE_USER: - def->sourceDev = virXMLPropString(source_node, "dev"); - break; - case VIR_DOMAIN_NET_TYPE_NULL: case VIR_DOMAIN_NET_TYPE_LAST: break; } + /* source/@dev is used for two different interface types and *not* + * stored inside the union, so we can parse it out always, and + * then log an error during validation if it was specified for one + * of the interface types that doesn't support it. + */ + def->sourceDev = virXMLPropString(source_node, "dev"); + if ((virtualport_node = virXPathNode("./virtualport", ctxt))) { if (virtualport_flags == 0) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, diff --git a/src/conf/domain_validate.c b/src/conf/domain_validate.c index f2a98f143d..9de442d7d7 100644 --- a/src/conf/domain_validate.c +++ b/src/conf/domain_validate.c @@ -2196,6 +2196,11 @@ virDomainNetDefValidate(const virDomainNetDef *net) } } + if (net->sourceDev && net->backend.type != VIR_DOMAIN_NET_BACKEND_PASST) { + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("The 'dev' attribute of the <source> element can only be used with interface type='user' or type='vhostuser' and backend='passt'.")); + } + if (net->nPortForwards > 0) { size_t p; diff --git a/tests/qemuxmlconfdata/net-vhostuser-passt.x86_64-latest.xml b/tests/qemuxmlconfdata/net-vhostuser-passt.x86_64-latest.xml index a1f9366722..529aff11f8 100644 --- a/tests/qemuxmlconfdata/net-vhostuser-passt.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/net-vhostuser-passt.x86_64-latest.xml @@ -33,6 +33,7 @@ <controller type='pci' index='0' model='pci-root'/> <interface type='vhostuser'> <mac address='00:11:22:33:44:55'/> + <source dev='eth42'/> <ip address='172.17.2.0' family='ipv4' prefix='24'/> <ip address='2001:db8:ac10:fd01::feed' family='ipv6'/> <portForward proto='tcp' address='2001:db8:ac10:fd01::1:10'> @@ -63,6 +64,7 @@ </interface> <interface type='vhostuser'> <mac address='00:11:22:33:44:11'/> + <source dev='eth43'/> <model type='virtio'/> <backend type='passt'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x04' function='0x0'/> -- 2.48.1

2 2

[PATCH v3 0/2] Enable SEV SNP support in ch driver
by Praveen K Paladugu 10 Mar '25

10 Mar '25

This version introduces virStringFormatHex method and uses this method while sending host_data to cloud-hypervisor. Praveen K Paladugu (2): util: Introduce virStringFormatHex ch: Enable SEV SNP support src/ch/ch_monitor.c | 65 ++++++++++++++++++++++++++++++++-------- src/libvirt_private.syms | 1 + src/util/virstring.c | 19 ++++++++++++ src/util/virstring.h | 1 + 4 files changed, 74 insertions(+), 12 deletions(-) -- 2.47.0

2 6

[PATCH 0/4] hw/s390x: Alias @dump-skeys -> @dump-s390-skey and deprecate
by Philippe Mathieu-Daudé 10 Mar '25

10 Mar '25

We are trying to unify all qemu-system-FOO to a single binary. In order to do that we need to remove QAPI target specific code. @dump-skeys is only available on qemu-system-s390x. This series rename it as @dump-s390-skey, making it available on other binaries. We take care of backward compatibility via deprecation. Philippe Mathieu-Daudé (4): hw/s390x: Introduce the @dump-s390-skeys QMP command hw/s390x: Introduce the 'dump_s390_skeys' HMP command hw/s390x: Deprecate the HMP 'dump_skeys' command hw/s390x: Deprecate the QMP @dump-skeys command docs/about/deprecated.rst | 5 +++++ qapi/misc-target.json | 5 +++++ qapi/misc.json | 18 ++++++++++++++++++ include/monitor/hmp.h | 1 + hw/s390x/s390-skeys-stub.c | 24 ++++++++++++++++++++++++ hw/s390x/s390-skeys.c | 19 +++++++++++++++++-- hmp-commands.hx | 17 +++++++++++++++-- hw/s390x/meson.build | 5 +++++ 8 files changed, 90 insertions(+), 4 deletions(-) create mode 100644 hw/s390x/s390-skeys-stub.c -- 2.41.0

7 24

[PATCH 00/16] qemu: Bump minimum qemu to qemu-6.2.0 and clean up capabilities
by Peter Krempa 10 Mar '25

10 Mar '25

Summary: This series was originally just meant to clean up non-release capabilities but it grew since we dropped debian-11 and Michal asked me to add dev-version for amdsev variant. Some of the long patches were truncated, fetch the proper patches at git fetch https://gitlab.com/pipo.sk/libvirt.git qemu_caps Note that this series also drops caps dumps which were not updated from the development version after final version was released. This includes: - caps_6.2.0_aarch64 - caps_7.0.0_aarch64 - caps_8.0.0_riscv64 If anyone cares enough I'll accept a replacement patch updating the caps but as outlined in the commit message I don't think we need to do archaeology for these as we have newer versions. I also pinged the original author of caps_9.2.0_s390x who promised to update the caps. This series also contains current git caps for the 'amdsev' variant per Michal's request. Peter Krempa (16): conf: Drop support for 'sheepdog' disks qemuxmlconftest: Drop tests pinned to qemu-5.2 qemuxmlconftest: Drop tests pinned to qemu-6.0 qemuxmlconftest: Drop tests pinned to qemu-6.1 qemucapabilitiestest: Drop qemu-5.2 data qemucapabilitiestest: Drop qemu-6.0 data qemucapabilitiestest: Drop qemu-6.1 data qemucapabilitiestest: Add 'qemu_9.2.0.aarch64+hvf' test data qemucapabilitiestest: Drop unused fake data 'caps_7.0.0_aarch64+hvf' qemucapabilitiesdata: Drop un-updated 'qemu_6.2.0_aarch64' data qemucapabilitiesdata: Drop un-updated 'caps_7.0.0_aarch64' data qemucapabilitiesdata: Drop un-updated 'qemu_8.0.0_riscv64' data qemu: capabilities: Bump minimum qemu to qemu-6.2 qemu: block: Drop 'sheepdog' protocol support qemucapabilitiestest: Update 'caps_10.0.0_x86_64' to 'v9.2.0-2369-g98c7362b1e' qemucapabilitiestest: Add data for the qemu-10.0 dev cycle on x86_64 for the '+amdsev' variant src/conf/domain_validate.c | 7 + src/qemu/qemu_block.c | 44 +- src/qemu/qemu_capabilities.c | 2 +- ....xml => qemu_10.0.0-q35.x86_64+amdsev.xml} | 870 +- ....xml => qemu_10.0.0-tcg.x86_64+amdsev.xml} | 1245 +- ...6_64.xml => qemu_10.0.0.x86_64+amdsev.xml} | 868 +- .../qemu_5.2.0-tcg-virt.riscv64.xml | 163 - .../domaincapsdata/qemu_5.2.0-tcg.x86_64.xml | 1643 - .../qemu_5.2.0-virt.aarch64.xml | 221 - .../qemu_5.2.0-virt.riscv64.xml | 166 - tests/domaincapsdata/qemu_5.2.0.aarch64.xml | 221 - tests/domaincapsdata/qemu_5.2.0.ppc64.xml | 187 - tests/domaincapsdata/qemu_5.2.0.s390x.xml | 288 - .../domaincapsdata/qemu_6.0.0-q35.x86_64.xml | 1047 - .../domaincapsdata/qemu_6.0.0-tcg.x86_64.xml | 1744 - .../qemu_6.0.0-virt.aarch64.xml | 227 - tests/domaincapsdata/qemu_6.0.0.aarch64.xml | 227 - tests/domaincapsdata/qemu_6.0.0.s390x.xml | 293 - tests/domaincapsdata/qemu_6.0.0.x86_64.xml | 1047 - .../domaincapsdata/qemu_6.1.0-q35.x86_64.xml | 1139 - tests/domaincapsdata/qemu_6.1.0.x86_64.xml | 1139 - .../qemu_6.2.0-virt.aarch64.xml | 234 - tests/domaincapsdata/qemu_6.2.0.aarch64.xml | 234 - .../qemu_7.0.0-virt.aarch64.xml | 233 - tests/domaincapsdata/qemu_7.0.0.aarch64.xml | 233 - .../qemu_8.0.0-tcg-virt.riscv64.xml | 174 - .../qemu_8.0.0-virt.riscv64.xml | 177 - ...hvf.xml => qemu_9.2.0-hvf.aarch64+hvf.xml} | 26 +- ...lies => caps_10.0.0_x86_64+amdsev.replies} | 26336 +++++++++---- ...6_64.xml => caps_10.0.0_x86_64+amdsev.xml} | 2994 +- .../caps_10.0.0_x86_64.replies | 388 +- .../caps_10.0.0_x86_64.xml | 70 +- .../caps_5.2.0_aarch64.replies | 24859 ------------ .../caps_5.2.0_aarch64.xml | 428 - .../caps_5.2.0_ppc64.replies | 28246 ------------- .../qemucapabilitiesdata/caps_5.2.0_ppc64.xml | 1081 - .../caps_5.2.0_riscv64.replies | 20531 ---------- .../caps_5.2.0_riscv64.xml | 131 - .../caps_5.2.0_s390x.replies | 25181 ------------ .../qemucapabilitiesdata/caps_5.2.0_s390x.xml | 3221 -- .../caps_5.2.0_x86_64.replies | 30637 --------------- .../caps_5.2.0_x86_64.xml | 3113 -- .../caps_6.0.0_aarch64.replies | 26869 ------------- .../caps_6.0.0_aarch64.xml | 454 - .../caps_6.0.0_s390x.replies | 26878 ------------- .../qemucapabilitiesdata/caps_6.0.0_s390x.xml | 3235 -- .../caps_6.0.0_x86_64.replies | 32715 ---------------- .../caps_6.0.0_x86_64.xml | 3261 -- .../caps_6.2.0_aarch64.replies | 28023 ------------- .../caps_6.2.0_aarch64.xml | 485 - .../caps_7.0.0_aarch64.replies | 31776 --------------- .../caps_7.0.0_aarch64.xml | 501 - .../caps_8.0.0_riscv64.replies | 27913 ------------- .../caps_8.0.0_riscv64.xml | 157 - ...replies => caps_9.2.0_aarch64+hvf.replies} | 27603 +++++++------ ...h64+hvf.xml => caps_9.2.0_aarch64+hvf.xml} | 647 +- tests/qemusecuritytest.c | 1 - .../cpu-fallback.x86_64-5.2.0.args | 34 - .../cpu-fallback.x86_64-5.2.0.xml | 40 - ...-host-model-fallback-kvm.x86_64-5.2.0.args | 34 - ...u-host-model-fallback-kvm.x86_64-5.2.0.xml | 29 - ...-host-model-fallback-kvm.x86_64-6.0.0.args | 34 - ...u-host-model-fallback-kvm.x86_64-6.0.0.xml | 29 - ...-host-model-fallback-kvm.x86_64-6.1.0.args | 34 - ...u-host-model-fallback-kvm.x86_64-6.1.0.xml | 29 - ...-host-model-fallback-tcg.x86_64-5.2.0.args | 34 - ...u-host-model-fallback-tcg.x86_64-5.2.0.xml | 29 - ...-host-model-fallback-tcg.x86_64-6.0.0.args | 34 - ...u-host-model-fallback-tcg.x86_64-6.0.0.xml | 29 - ...-host-model-fallback-tcg.x86_64-6.1.0.args | 34 - ...u-host-model-fallback-tcg.x86_64-6.1.0.xml | 29 - .../cpu-host-model-kvm.x86_64-5.2.0.args | 39 - .../cpu-host-model-kvm.x86_64-5.2.0.xml | 48 - .../cpu-host-model-kvm.x86_64-6.0.0.args | 39 - .../cpu-host-model-kvm.x86_64-6.0.0.xml | 48 - .../cpu-host-model-kvm.x86_64-6.1.0.args | 39 - .../cpu-host-model-kvm.x86_64-6.1.0.xml | 48 - ...ost-model-nofallback-kvm.x86_64-5.2.0.args | 34 - ...host-model-nofallback-kvm.x86_64-5.2.0.xml | 29 - ...ost-model-nofallback-kvm.x86_64-6.0.0.args | 34 - ...host-model-nofallback-kvm.x86_64-6.0.0.xml | 29 - ...ost-model-nofallback-kvm.x86_64-6.1.0.args | 34 - ...host-model-nofallback-kvm.x86_64-6.1.0.xml | 29 - ...ost-model-nofallback-tcg.x86_64-5.2.0.args | 34 - ...host-model-nofallback-tcg.x86_64-5.2.0.xml | 29 - ...ost-model-nofallback-tcg.x86_64-6.0.0.args | 34 - ...host-model-nofallback-tcg.x86_64-6.0.0.xml | 29 - ...ost-model-nofallback-tcg.x86_64-6.1.0.args | 34 - ...host-model-nofallback-tcg.x86_64-6.1.0.xml | 29 - .../cpu-host-model-tcg.x86_64-5.2.0.args | 39 - .../cpu-host-model-tcg.x86_64-5.2.0.xml | 48 - .../cpu-host-model-tcg.x86_64-6.0.0.args | 39 - .../cpu-host-model-tcg.x86_64-6.0.0.xml | 48 - .../cpu-host-model-tcg.x86_64-6.1.0.args | 39 - .../cpu-host-model-tcg.x86_64-6.1.0.xml | 48 - .../cpu-nofallback.x86_64-5.2.0.err | 1 - .../cpu-nofallback.x86_64-5.2.0.xml | 40 - ...sk-network-rbd-encryption.x86_64-6.0.0.err | 1 - .../disk-network-sheepdog.x86_64-6.0.0.args | 39 - .../disk-network-sheepdog.x86_64-6.0.0.xml | 46 - .../disk-network-sheepdog.x86_64-latest.err | 1 + ...disk-network-tlsx509-nbd.x86_64-5.2.0.args | 38 - .../disk-network-tlsx509-nbd.x86_64-5.2.0.xml | 37 - ...virtio-scsi-reservations.x86_64-5.2.0.args | 43 - ...-virtio-scsi-reservations.x86_64-5.2.0.xml | 53 - .../graphics-vnc-tls-secret.x86_64-5.2.0.args | 37 - .../graphics-vnc-tls-secret.x86_64-5.2.0.xml | 39 - ...ch64-virt-headless.aarch64-latest+hvf.args | 8 +- .../hyperv-passthrough.x86_64-6.1.0.args | 32 - .../hyperv-passthrough.x86_64-6.1.0.xml | 34 - ...othreads-virtio-scsi-pci.x86_64-5.2.0.args | 42 - ...iothreads-virtio-scsi-pci.x86_64-5.2.0.xml | 49 - ...ev-missing-platform-info.x86_64-6.0.0.args | 37 - ...sev-missing-platform-info.x86_64-6.0.0.xml | 43 - .../launch-security-sev.x86_64-6.0.0.args | 37 - .../launch-security-sev.x86_64-6.0.0.xml | 45 - .../luks-disks-source-qcow2.x86_64-5.2.0.args | 62 - .../luks-disks-source-qcow2.x86_64-5.2.0.xml | 107 - ...ory-hotplug-nvdimm-align.x86_64-5.2.0.args | 40 - ...mory-hotplug-nvdimm-align.x86_64-5.2.0.xml | 60 - ...ory-hotplug-nvdimm-label.x86_64-5.2.0.args | 40 - ...mory-hotplug-nvdimm-label.x86_64-5.2.0.xml | 62 - ...mory-hotplug-nvdimm-pmem.x86_64-5.2.0.args | 40 - ...emory-hotplug-nvdimm-pmem.x86_64-5.2.0.xml | 60 - ...-hotplug-nvdimm-readonly.x86_64-5.2.0.args | 40 - ...y-hotplug-nvdimm-readonly.x86_64-5.2.0.xml | 60 - ...mory-hotplug-virtio-pmem.x86_64-5.2.0.args | 40 - ...emory-hotplug-virtio-pmem.x86_64-5.2.0.xml | 55 - .../misc-no-reboot.x86_64-5.2.0.args | 36 - .../misc-no-reboot.x86_64-5.2.0.xml | 38 - .../numatune-memnode.x86_64-5.2.0.args | 39 - .../numatune-memnode.x86_64-5.2.0.xml | 41 - ...0-async-teardown-disabled.s390x-6.0.0.args | 35 - ...90-async-teardown-disabled.s390x-6.0.0.xml | 36 - .../s390-async-teardown.s390x-6.0.0.err | 1 - .../virtio-iommu-x86_64.x86_64-6.1.0.err | 1 - .../virtio-rng-builtin.x86_64-5.2.0.args | 36 - .../virtio-rng-builtin.x86_64-5.2.0.xml | 35 - .../virtio-rng-egd-unix.x86_64-5.2.0.args | 37 - .../virtio-rng-egd-unix.x86_64-5.2.0.xml | 37 - tests/qemuxmlconftest.c | 47 +- 141 files changed, 37729 insertions(+), 357243 deletions(-) rename tests/domaincapsdata/{qemu_5.2.0-q35.x86_64.xml => qemu_10.0.0-q35.x86_64+amdsev.xml} (51%) rename tests/domaincapsdata/{qemu_6.1.0-tcg.x86_64.xml => qemu_10.0.0-tcg.x86_64+amdsev.xml} (67%) rename tests/domaincapsdata/{qemu_5.2.0.x86_64.xml => qemu_10.0.0.x86_64+amdsev.xml} (51%) delete mode 100644 tests/domaincapsdata/qemu_5.2.0-tcg-virt.riscv64.xml delete mode 100644 tests/domaincapsdata/qemu_5.2.0-tcg.x86_64.xml delete mode 100644 tests/domaincapsdata/qemu_5.2.0-virt.aarch64.xml delete mode 100644 tests/domaincapsdata/qemu_5.2.0-virt.riscv64.xml delete mode 100644 tests/domaincapsdata/qemu_5.2.0.aarch64.xml delete mode 100644 tests/domaincapsdata/qemu_5.2.0.ppc64.xml delete mode 100644 tests/domaincapsdata/qemu_5.2.0.s390x.xml delete mode 100644 tests/domaincapsdata/qemu_6.0.0-q35.x86_64.xml delete mode 100644 tests/domaincapsdata/qemu_6.0.0-tcg.x86_64.xml delete mode 100644 tests/domaincapsdata/qemu_6.0.0-virt.aarch64.xml delete mode 100644 tests/domaincapsdata/qemu_6.0.0.aarch64.xml delete mode 100644 tests/domaincapsdata/qemu_6.0.0.s390x.xml delete mode 100644 tests/domaincapsdata/qemu_6.0.0.x86_64.xml delete mode 100644 tests/domaincapsdata/qemu_6.1.0-q35.x86_64.xml delete mode 100644 tests/domaincapsdata/qemu_6.1.0.x86_64.xml delete mode 100644 tests/domaincapsdata/qemu_6.2.0-virt.aarch64.xml delete mode 100644 tests/domaincapsdata/qemu_6.2.0.aarch64.xml delete mode 100644 tests/domaincapsdata/qemu_7.0.0-virt.aarch64.xml delete mode 100644 tests/domaincapsdata/qemu_7.0.0.aarch64.xml delete mode 100644 tests/domaincapsdata/qemu_8.0.0-tcg-virt.riscv64.xml delete mode 100644 tests/domaincapsdata/qemu_8.0.0-virt.riscv64.xml rename tests/domaincapsdata/{qemu_7.0.0-hvf.aarch64+hvf.xml => qemu_9.2.0-hvf.aarch64+hvf.xml} (91%) rename tests/qemucapabilitiesdata/{caps_6.1.0_x86_64.replies => caps_10.0.0_x86_64+amdsev.replies} (68%) rename tests/qemucapabilitiesdata/{caps_6.1.0_x86_64.xml => caps_10.0.0_x86_64+amdsev.xml} (63%) delete mode 100644 tests/qemucapabilitiesdata/caps_5.2.0_aarch64.replies delete mode 100644 tests/qemucapabilitiesdata/caps_5.2.0_aarch64.xml delete mode 100644 tests/qemucapabilitiesdata/caps_5.2.0_ppc64.replies delete mode 100644 tests/qemucapabilitiesdata/caps_5.2.0_ppc64.xml delete mode 100644 tests/qemucapabilitiesdata/caps_5.2.0_riscv64.replies delete mode 100644 tests/qemucapabilitiesdata/caps_5.2.0_riscv64.xml delete mode 100644 tests/qemucapabilitiesdata/caps_5.2.0_s390x.replies delete mode 100644 tests/qemucapabilitiesdata/caps_5.2.0_s390x.xml delete mode 100644 tests/qemucapabilitiesdata/caps_5.2.0_x86_64.replies delete mode 100644 tests/qemucapabilitiesdata/caps_5.2.0_x86_64.xml delete mode 100644 tests/qemucapabilitiesdata/caps_6.0.0_aarch64.replies delete mode 100644 tests/qemucapabilitiesdata/caps_6.0.0_aarch64.xml delete mode 100644 tests/qemucapabilitiesdata/caps_6.0.0_s390x.replies delete mode 100644 tests/qemucapabilitiesdata/caps_6.0.0_s390x.xml delete mode 100644 tests/qemucapabilitiesdata/caps_6.0.0_x86_64.replies delete mode 100644 tests/qemucapabilitiesdata/caps_6.0.0_x86_64.xml delete mode 100644 tests/qemucapabilitiesdata/caps_6.2.0_aarch64.replies delete mode 100644 tests/qemucapabilitiesdata/caps_6.2.0_aarch64.xml delete mode 100644 tests/qemucapabilitiesdata/caps_7.0.0_aarch64.replies delete mode 100644 tests/qemucapabilitiesdata/caps_7.0.0_aarch64.xml delete mode 100644 tests/qemucapabilitiesdata/caps_8.0.0_riscv64.replies delete mode 100644 tests/qemucapabilitiesdata/caps_8.0.0_riscv64.xml rename tests/qemucapabilitiesdata/{caps_7.0.0_aarch64+hvf.replies => caps_9.2.0_aarch64+hvf.replies} (82%) rename tests/qemucapabilitiesdata/{caps_7.0.0_aarch64+hvf.xml => caps_9.2.0_aarch64+hvf.xml} (58%) delete mode 100644 tests/qemuxmlconfdata/cpu-fallback.x86_64-5.2.0.args delete mode 100644 tests/qemuxmlconfdata/cpu-fallback.x86_64-5.2.0.xml delete mode 100644 tests/qemuxmlconfdata/cpu-host-model-fallback-kvm.x86_64-5.2.0.args delete mode 100644 tests/qemuxmlconfdata/cpu-host-model-fallback-kvm.x86_64-5.2.0.xml delete mode 100644 tests/qemuxmlconfdata/cpu-host-model-fallback-kvm.x86_64-6.0.0.args delete mode 100644 tests/qemuxmlconfdata/cpu-host-model-fallback-kvm.x86_64-6.0.0.xml delete mode 100644 tests/qemuxmlconfdata/cpu-host-model-fallback-kvm.x86_64-6.1.0.args delete mode 100644 tests/qemuxmlconfdata/cpu-host-model-fallback-kvm.x86_64-6.1.0.xml delete mode 100644 tests/qemuxmlconfdata/cpu-host-model-fallback-tcg.x86_64-5.2.0.args delete mode 100644 tests/qemuxmlconfdata/cpu-host-model-fallback-tcg.x86_64-5.2.0.xml delete mode 100644 tests/qemuxmlconfdata/cpu-host-model-fallback-tcg.x86_64-6.0.0.args delete mode 100644 tests/qemuxmlconfdata/cpu-host-model-fallback-tcg.x86_64-6.0.0.xml delete mode 100644 tests/qemuxmlconfdata/cpu-host-model-fallback-tcg.x86_64-6.1.0.args delete mode 100644 tests/qemuxmlconfdata/cpu-host-model-fallback-tcg.x86_64-6.1.0.xml delete mode 100644 tests/qemuxmlconfdata/cpu-host-model-kvm.x86_64-5.2.0.args delete mode 100644 tests/qemuxmlconfdata/cpu-host-model-kvm.x86_64-5.2.0.xml delete mode 100644 tests/qemuxmlconfdata/cpu-host-model-kvm.x86_64-6.0.0.args delete mode 100644 tests/qemuxmlconfdata/cpu-host-model-kvm.x86_64-6.0.0.xml delete mode 100644 tests/qemuxmlconfdata/cpu-host-model-kvm.x86_64-6.1.0.args delete mode 100644 tests/qemuxmlconfdata/cpu-host-model-kvm.x86_64-6.1.0.xml delete mode 100644 tests/qemuxmlconfdata/cpu-host-model-nofallback-kvm.x86_64-5.2.0.args delete mode 100644 tests/qemuxmlconfdata/cpu-host-model-nofallback-kvm.x86_64-5.2.0.xml delete mode 100644 tests/qemuxmlconfdata/cpu-host-model-nofallback-kvm.x86_64-6.0.0.args delete mode 100644 tests/qemuxmlconfdata/cpu-host-model-nofallback-kvm.x86_64-6.0.0.xml delete mode 100644 tests/qemuxmlconfdata/cpu-host-model-nofallback-kvm.x86_64-6.1.0.args delete mode 100644 tests/qemuxmlconfdata/cpu-host-model-nofallback-kvm.x86_64-6.1.0.xml delete mode 100644 tests/qemuxmlconfdata/cpu-host-model-nofallback-tcg.x86_64-5.2.0.args delete mode 100644 tests/qemuxmlconfdata/cpu-host-model-nofallback-tcg.x86_64-5.2.0.xml delete mode 100644 tests/qemuxmlconfdata/cpu-host-model-nofallback-tcg.x86_64-6.0.0.args delete mode 100644 tests/qemuxmlconfdata/cpu-host-model-nofallback-tcg.x86_64-6.0.0.xml delete mode 100644 tests/qemuxmlconfdata/cpu-host-model-nofallback-tcg.x86_64-6.1.0.args delete mode 100644 tests/qemuxmlconfdata/cpu-host-model-nofallback-tcg.x86_64-6.1.0.xml delete mode 100644 tests/qemuxmlconfdata/cpu-host-model-tcg.x86_64-5.2.0.args delete mode 100644 tests/qemuxmlconfdata/cpu-host-model-tcg.x86_64-5.2.0.xml delete mode 100644 tests/qemuxmlconfdata/cpu-host-model-tcg.x86_64-6.0.0.args delete mode 100644 tests/qemuxmlconfdata/cpu-host-model-tcg.x86_64-6.0.0.xml delete mode 100644 tests/qemuxmlconfdata/cpu-host-model-tcg.x86_64-6.1.0.args delete mode 100644 tests/qemuxmlconfdata/cpu-host-model-tcg.x86_64-6.1.0.xml delete mode 100644 tests/qemuxmlconfdata/cpu-nofallback.x86_64-5.2.0.err delete mode 100644 tests/qemuxmlconfdata/cpu-nofallback.x86_64-5.2.0.xml delete mode 100644 tests/qemuxmlconfdata/disk-network-rbd-encryption.x86_64-6.0.0.err delete mode 100644 tests/qemuxmlconfdata/disk-network-sheepdog.x86_64-6.0.0.args delete mode 100644 tests/qemuxmlconfdata/disk-network-sheepdog.x86_64-6.0.0.xml create mode 100644 tests/qemuxmlconfdata/disk-network-sheepdog.x86_64-latest.err delete mode 100644 tests/qemuxmlconfdata/disk-network-tlsx509-nbd.x86_64-5.2.0.args delete mode 100644 tests/qemuxmlconfdata/disk-network-tlsx509-nbd.x86_64-5.2.0.xml delete mode 100644 tests/qemuxmlconfdata/disk-virtio-scsi-reservations.x86_64-5.2.0.args delete mode 100644 tests/qemuxmlconfdata/disk-virtio-scsi-reservations.x86_64-5.2.0.xml delete mode 100644 tests/qemuxmlconfdata/graphics-vnc-tls-secret.x86_64-5.2.0.args delete mode 100644 tests/qemuxmlconfdata/graphics-vnc-tls-secret.x86_64-5.2.0.xml delete mode 100644 tests/qemuxmlconfdata/hyperv-passthrough.x86_64-6.1.0.args delete mode 100644 tests/qemuxmlconfdata/hyperv-passthrough.x86_64-6.1.0.xml delete mode 100644 tests/qemuxmlconfdata/iothreads-virtio-scsi-pci.x86_64-5.2.0.args delete mode 100644 tests/qemuxmlconfdata/iothreads-virtio-scsi-pci.x86_64-5.2.0.xml delete mode 100644 tests/qemuxmlconfdata/launch-security-sev-missing-platform-info.x86_64-6.0.0.args delete mode 100644 tests/qemuxmlconfdata/launch-security-sev-missing-platform-info.x86_64-6.0.0.xml delete mode 100644 tests/qemuxmlconfdata/launch-security-sev.x86_64-6.0.0.args delete mode 100644 tests/qemuxmlconfdata/launch-security-sev.x86_64-6.0.0.xml delete mode 100644 tests/qemuxmlconfdata/luks-disks-source-qcow2.x86_64-5.2.0.args delete mode 100644 tests/qemuxmlconfdata/luks-disks-source-qcow2.x86_64-5.2.0.xml delete mode 100644 tests/qemuxmlconfdata/memory-hotplug-nvdimm-align.x86_64-5.2.0.args delete mode 100644 tests/qemuxmlconfdata/memory-hotplug-nvdimm-align.x86_64-5.2.0.xml delete mode 100644 tests/qemuxmlconfdata/memory-hotplug-nvdimm-label.x86_64-5.2.0.args delete mode 100644 tests/qemuxmlconfdata/memory-hotplug-nvdimm-label.x86_64-5.2.0.xml delete mode 100644 tests/qemuxmlconfdata/memory-hotplug-nvdimm-pmem.x86_64-5.2.0.args delete mode 100644 tests/qemuxmlconfdata/memory-hotplug-nvdimm-pmem.x86_64-5.2.0.xml delete mode 100644 tests/qemuxmlconfdata/memory-hotplug-nvdimm-readonly.x86_64-5.2.0.args delete mode 100644 tests/qemuxmlconfdata/memory-hotplug-nvdimm-readonly.x86_64-5.2.0.xml delete mode 100644 tests/qemuxmlconfdata/memory-hotplug-virtio-pmem.x86_64-5.2.0.args delete mode 100644 tests/qemuxmlconfdata/memory-hotplug-virtio-pmem.x86_64-5.2.0.xml delete mode 100644 tests/qemuxmlconfdata/misc-no-reboot.x86_64-5.2.0.args delete mode 100644 tests/qemuxmlconfdata/misc-no-reboot.x86_64-5.2.0.xml delete mode 100644 tests/qemuxmlconfdata/numatune-memnode.x86_64-5.2.0.args delete mode 100644 tests/qemuxmlconfdata/numatune-memnode.x86_64-5.2.0.xml delete mode 100644 tests/qemuxmlconfdata/s390-async-teardown-disabled.s390x-6.0.0.args delete mode 100644 tests/qemuxmlconfdata/s390-async-teardown-disabled.s390x-6.0.0.xml delete mode 100644 tests/qemuxmlconfdata/s390-async-teardown.s390x-6.0.0.err delete mode 100644 tests/qemuxmlconfdata/virtio-iommu-x86_64.x86_64-6.1.0.err delete mode 100644 tests/qemuxmlconfdata/virtio-rng-builtin.x86_64-5.2.0.args delete mode 100644 tests/qemuxmlconfdata/virtio-rng-builtin.x86_64-5.2.0.xml delete mode 100644 tests/qemuxmlconfdata/virtio-rng-egd-unix.x86_64-5.2.0.args delete mode 100644 tests/qemuxmlconfdata/virtio-rng-egd-unix.x86_64-5.2.0.xml -- 2.48.1

3 18

Feature Request: --targetdir option on backup-begin
by Michael Niehren 10 Mar '25

10 Mar '25

Hi, i just playing around with the "new" backup API for switching from the old way and simply want to do full backup's in push mode. If i do so, virsh backup-begin <domain> the backup-Image files are always created in the image directory As the place on the fast nvme's, where the images are lying is very limited, i want to place the backup-image files to be on another harddisk on an mounted dir whithout temporary save them in the image directory. To do so, an --targetdir option on backup-begin would be very useful. best regards Michael

2 1

[PATCH RESEND 0/6] Add support for configuring PCI high memory MMIO size
by Matthew R. Ochs 08 Mar '25

08 Mar '25

Resending this series since it appears my first attempt was not sent to the list due to the "first post" manual moderation delay. =) This patch series adds support for configuring the PCI high memory MMIO window size for aarch64 virt machine types. This feature was recently merged into the QEMU upstream master branch [1] and will be available in QEMU 10.0. It allows users to configure the size of the high memory MMIO window above 4GB, which is particularly useful for systems with large amounts of PCI memory requirements. The feature is exposed through the domain XML as a new PCI feature: <features> <pci> <highmem-mmio-size unit='G'>512</highmem-mmio-size> </pci> </features> When enabled, this configures the size of the PCI high memory MMIO window via QEMU's highmem-mmio-size machine property. The feature is only available for aarch64 virt machine types and requires QEMU support. This series depends on [2] and should be applied on top of those patches. For your convenience, this series is also available on Github [3]. [1] https://github.com/qemu/qemu/commit/f10104aeae3a17f181d5bb37b7fd7dad7fe86cba [2] https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/Z4NQ… [3] git fetch https://github.com/nvmochs/libvirt.git pci_highmem_mmio_size Signed-off-by: Matthew R. Ochs <mochs(a)nvidia.com> Matthew R. Ochs (6): domain: Add PCI configuration feature infrastructure schema: Add PCI configuration feature schema conf: Add PCI configuration XML parsing and formatting qemu: Add capability for PCI high memory MMIO size qemu: Add command line support for PCI high memory MMIO size tests: Add tests for machine PCI features src/conf/domain_conf.c | 103 ++++++++++++++++++ src/conf/domain_conf.h | 6 + src/conf/schemas/domaincommon.rng | 9 ++ src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 6 + src/qemu/qemu_validate.c | 15 +++ .../caps_10.0.0_aarch64.replies | 10 ++ .../caps_10.0.0_aarch64.xml | 1 + ...rch64-virt-machine-pci.aarch64-latest.args | 31 ++++++ ...arch64-virt-machine-pci.aarch64-latest.xml | 30 +++++ .../aarch64-virt-machine-pci.xml | 20 ++++ tests/qemuxmlconftest.c | 2 + 13 files changed, 236 insertions(+) create mode 100644 tests/qemuxmlconfdata/aarch64-virt-machine-pci.aarch64-latest.args create mode 100644 tests/qemuxmlconfdata/aarch64-virt-machine-pci.aarch64-latest.xml create mode 100644 tests/qemuxmlconfdata/aarch64-virt-machine-pci.xml -- 2.46.0

1 6

[PATCH] util: Check libnl function availability
by Akihiko Odaki 07 Mar '25

07 Mar '25

virNetDevBridgeSetupVlans() calls virNetlinkBridgeVlanFilterSet(), which requires libnl. Use the function only when libnl is available to avoid breaking builds. Signed-off-by: Akihiko Odaki <akihiko.odaki(a)daynix.com> --- src/util/virnetdevbridge.c | 122 ++++++++++++++++++++++----------------------- 1 file changed, 61 insertions(+), 61 deletions(-) diff --git a/src/util/virnetdevbridge.c b/src/util/virnetdevbridge.c index c79d0c79b7b16a0a070b5013ed7df9d0a63b1c38..70e82a0029634ddf44c2b933577bf783c89f035c 100644 --- a/src/util/virnetdevbridge.c +++ b/src/util/virnetdevbridge.c @@ -313,66 +313,6 @@ virNetDevBridgePortSetIsolated(const char *brname, return virNetDevBridgePortSet(brname, ifname, "isolated", enable ? 1 : 0); } -static int -virNetDevBridgeSetupVlans(const char *ifname, const virNetDevVlan *virtVlan) -{ - int error = 0; - unsigned short flags; - - if (!virtVlan || !virtVlan->nTags) - return 0; - - // The interface will have been automatically added to vlan 1, so remove it - if (virNetlinkBridgeVlanFilterSet(ifname, RTM_DELLINK, 0, 1, &error) < 0) { - if (error != 0) { - virReportSystemError(-error, - _("error removing vlan filter from interface %1$s"), - ifname); - } - return -1; - } - - // If trunk mode, add the native VLAN then add the others, if any - if (virtVlan->trunk) { - size_t i; - - if (virtVlan->nativeTag) { - flags = BRIDGE_VLAN_INFO_PVID; - if (virtVlan->nativeMode == VIR_NATIVE_VLAN_MODE_UNTAGGED || - virtVlan->nativeMode == VIR_NATIVE_VLAN_MODE_DEFAULT) { - flags |= BRIDGE_VLAN_INFO_UNTAGGED; - } - - if (virNetlinkBridgeVlanFilterSet(ifname, RTM_SETLINK, flags, - virtVlan->nativeTag, &error) < 0) { - goto error; - } - } - - for (i = 0; i < virtVlan->nTags; i++) { - if (virtVlan->tag[i] != virtVlan->nativeTag) - if (virNetlinkBridgeVlanFilterSet(ifname, RTM_SETLINK, 0, - virtVlan->tag[i], &error) < 0) { - goto error; - } - } - } else { - // In native mode, add the single VLAN as pvid untagged - flags = BRIDGE_VLAN_INFO_PVID | BRIDGE_VLAN_INFO_UNTAGGED; - if (virNetlinkBridgeVlanFilterSet(ifname, RTM_SETLINK, flags, - virtVlan->tag[0], &error) < 0) { - goto error; - } - } - - return 0; - - error: - if (error != 0) - virReportSystemError(-error, _("error adding vlan filter to interface %1$s"), ifname); - return -1; -} - #else int @@ -651,7 +591,67 @@ int virNetDevBridgeDelete(const char *brname G_GNUC_UNUSED) * * Returns 0 in case of success or an errno code in case of failure. */ -#if defined(WITH_STRUCT_IFREQ) && defined(SIOCBRADDIF) +#if defined(WITH_STRUCT_IFREQ) && defined(SIOCBRADDIF) && defined(WITH_LIBNL) +static int +virNetDevBridgeSetupVlans(const char *ifname, const virNetDevVlan *virtVlan) +{ + int error = 0; + unsigned short flags; + + if (!virtVlan || !virtVlan->nTags) + return 0; + + // The interface will have been automatically added to vlan 1, so remove it + if (virNetlinkBridgeVlanFilterSet(ifname, RTM_DELLINK, 0, 1, &error) < 0) { + if (error != 0) { + virReportSystemError(-error, + _("error removing vlan filter from interface %1$s"), + ifname); + } + return -1; + } + + // If trunk mode, add the native VLAN then add the others, if any + if (virtVlan->trunk) { + size_t i; + + if (virtVlan->nativeTag) { + flags = BRIDGE_VLAN_INFO_PVID; + if (virtVlan->nativeMode == VIR_NATIVE_VLAN_MODE_UNTAGGED || + virtVlan->nativeMode == VIR_NATIVE_VLAN_MODE_DEFAULT) { + flags |= BRIDGE_VLAN_INFO_UNTAGGED; + } + + if (virNetlinkBridgeVlanFilterSet(ifname, RTM_SETLINK, flags, + virtVlan->nativeTag, &error) < 0) { + goto error; + } + } + + for (i = 0; i < virtVlan->nTags; i++) { + if (virtVlan->tag[i] != virtVlan->nativeTag) + if (virNetlinkBridgeVlanFilterSet(ifname, RTM_SETLINK, 0, + virtVlan->tag[i], &error) < 0) { + goto error; + } + } + } else { + // In native mode, add the single VLAN as pvid untagged + flags = BRIDGE_VLAN_INFO_PVID | BRIDGE_VLAN_INFO_UNTAGGED; + if (virNetlinkBridgeVlanFilterSet(ifname, RTM_SETLINK, flags, + virtVlan->tag[0], &error) < 0) { + goto error; + } + } + + return 0; + + error: + if (error != 0) + virReportSystemError(-error, _("error adding vlan filter to interface %1$s"), ifname); + return -1; +} + int virNetDevBridgeAddPort(const char *brname, const char *ifname, const virNetDevVlan *virtVlan) --- base-commit: e5299ddf86121d3c792ca271ffcb54900eb19dc3 change-id: 20250304-nl-605e05b8c5f2 Best regards, -- Akihiko Odaki <akihiko.odaki(a)daynix.com>

2 3