February 2023 - Devel - libvirt List Archives

[libvirt PATCH 00/33] qemu: Move firmware selection to postparse and add support for QCOW2 firmware
by Andrea Bolognani 03 Mar '23

03 Mar '23

Motivation for these changes can be found in the commit message for patch 20 ("qemu: Move firmware selection from startup to postparse") as well as [RHBZ#2161965]. Patches 01-17 are preparatory fixes/improvements/cleanups. Patches 19-20 move firmware selection from startup to postparse, and patches 21-22 clean up a bit after that change. Patch 20 in particular is significantly larger than I would have liked, but I haven't been able to come up with a way to split it while still preserving bisectability and making things clearer instead of complicating them. If anyone has ideas in this regard, please let me know! Patches 23-27 add support for choosing a firmware format, but are effectively no-op because formats other than raw are still rejected at this point. Patches 28-30 add support for QCOW2 format firmware in the QEMU driver. Patches 31-33 document the changes. [RHBZ#2161965] https://bugzilla.redhat.com/show_bug.cgi?id=2161965 Andrea Bolognani (33): docs: Fix documentation for loader.stateless attribute tests: Set nvramDir in qemuxml2xmltest tests: Rename firmware-manual-efi-rw* tests tests: Use x86_64 for all x86 firmware tests tests: Move firmware tests to CAPS_LATEST tests: Unify input files for firmware tests tests: Enable qemuxml2xml for more firmware tests tests: Add more firmware tests qemu: Introduce qemuDomainDefMachinePostParse() qemu: Introduce qemuDomainDefBootPostParse() conf: Introduce virDomainLoaderDefParseXMLLoader() conf: introduce virDomainLoaderDefNew() qemu: Add convenience local variables qemu: Only fill nvramTemplate for local sources qemu: Clear os.firmwareFeatures after autoselection qemu: Don't pick firmware that requires SMM when smm=off qemu: Don't pick firmware with unsupported format tests: Add descriptors for QCOW2 format firmware builds conf: Export virDomainDefOSValidate() qemu: Move firmware selection from startup to postparse qemu: Move qemuDomainNVRAMPathFormat() to qemu_firmware qemu: Introduce qemuFirmwareEnsureNVRAM() conf: Change handling for empty NVRAM path conf: Parse firmware format drivers: Reject unsupported firmware formats qemu: Filter firmwares based on format qemu: Propagate firmware format conf: Accept QCOW2 firmware format qemu: Add support for QCOW2 format firmware tests: Add more firmware tests docs: Document firmware format attribute news: Document changes to firmware autoselection news: Document support for QCOW2 format firmware NEWS.rst | 16 + docs/formatdomain.rst | 11 +- src/bhyve/bhyve_firmware.c | 9 +- src/conf/domain_conf.c | 123 ++++- src/conf/domain_conf.h | 2 + src/conf/domain_validate.c | 4 +- src/conf/domain_validate.h | 3 + src/conf/schemas/domaincommon.rng | 15 + src/libvirt_private.syms | 2 + src/libxl/libxl_conf.c | 9 +- src/libxl/xen_xl.c | 4 +- src/libxl/xen_xm.c | 2 +- src/qemu/qemu_domain.c | 113 +++-- src/qemu/qemu_domain.h | 5 - src/qemu/qemu_driver.c | 2 - src/qemu/qemu_firmware.c | 460 +++++++++++++----- src/qemu/qemu_firmware.h | 3 +- src/qemu/qemu_process.c | 33 +- .../share/qemu/firmware/65-ovmf-qcow2.json | 35 ++ .../share/qemu/firmware/66-aavmf-qcow2.json | 36 ++ tests/qemufirmwaretest.c | 11 +- .../firmware-auto-bios-not-stateless.xml | 4 +- .../firmware-auto-bios-nvram.xml | 6 +- ...are-auto-bios-stateless.x86_64-latest.args | 16 +- .../firmware-auto-bios-stateless.xml | 4 +- .../firmware-auto-bios.x86_64-latest.args | 16 +- tests/qemuxml2argvdata/firmware-auto-bios.xml | 4 +- ...mware-auto-efi-aarch64.aarch64-latest.args | 22 +- .../firmware-auto-efi-aarch64.xml | 4 +- ...ware-auto-efi-enrolled-keys-no-secboot.xml | 4 +- ...-auto-efi-enrolled-keys.x86_64-latest.args | 18 +- .../firmware-auto-efi-enrolled-keys.xml | 4 +- ...fi-format-loader-qcow2.x86_64-latest.args} | 24 +- ...firmware-auto-efi-format-loader-qcow2.xml} | 6 +- ...efi-format-loader-raw.aarch64-latest.args} | 5 +- ...> firmware-auto-efi-format-loader-raw.xml} | 5 +- ...auto-efi-format-mismatch.x86_64-latest.err | 1 + ... => firmware-auto-efi-format-mismatch.xml} | 7 +- ...vram-qcow2-network-nbd.x86_64-latest.args} | 22 +- ...to-efi-format-nvram-qcow2-network-nbd.xml} | 11 +- ...ormat-nvram-qcow2-path.x86_64-latest.args} | 24 +- ...ware-auto-efi-format-nvram-qcow2-path.xml} | 6 +- ...efi-format-nvram-qcow2.x86_64-latest.args} | 24 +- ... firmware-auto-efi-format-nvram-qcow2.xml} | 6 +- .../firmware-auto-efi-loader-insecure.xml | 4 +- .../firmware-auto-efi-loader-path.xml | 4 +- ...-auto-efi-loader-secure.x86_64-latest.args | 18 +- .../firmware-auto-efi-loader-secure.xml | 4 +- ...to-efi-no-enrolled-keys.x86_64-latest.args | 18 +- .../firmware-auto-efi-no-enrolled-keys.xml | 4 +- ...are-auto-efi-no-secboot.x86_64-latest.args | 18 +- .../firmware-auto-efi-no-secboot.xml | 4 +- ...re-auto-efi-nvram-file.x86_64-latest.args} | 13 +- ...5.xml => firmware-auto-efi-nvram-file.xml} | 9 +- ...fi-nvram-network-iscsi.x86_64-latest.args} | 16 +- ...firmware-auto-efi-nvram-network-iscsi.xml} | 9 +- ...-efi-nvram-network-nbd.x86_64-latest.args} | 16 +- ...> firmware-auto-efi-nvram-network-nbd.xml} | 9 +- ...firmware-auto-efi-nvram.x86_64-latest.args | 18 +- .../firmware-auto-efi-nvram.xml | 6 +- ...rmware-auto-efi-secboot.x86_64-latest.args | 18 +- .../firmware-auto-efi-secboot.xml | 4 +- ...mware-auto-efi-smm-off.x86_64-latest.args} | 17 +- ...-efi.xml => firmware-auto-efi-smm-off.xml} | 5 +- ...ware-auto-efi-stateless.x86_64-latest.args | 16 +- .../firmware-auto-efi-stateless.xml | 4 +- .../firmware-auto-efi.x86_64-latest.args | 18 +- tests/qemuxml2argvdata/firmware-auto-efi.xml | 4 +- ...nual-bios-not-stateless.x86_64-latest.err} | 0 .../firmware-manual-bios-not-stateless.xml | 8 +- .../firmware-manual-bios-stateless.args | 30 -- ...-manual-bios-stateless.x86_64-latest.args} | 12 +- .../firmware-manual-bios-stateless.xml | 8 +- .../firmware-manual-bios.args | 30 -- ...> firmware-manual-bios.x86_64-latest.args} | 12 +- .../qemuxml2argvdata/firmware-manual-bios.xml | 8 +- ...nual-efi-acpi-aarch64.aarch64-latest.args} | 11 +- .../firmware-manual-efi-acpi-aarch64.xml | 6 +- ...re-manual-efi-acpi-q35.x86_64-latest.args} | 11 +- .../firmware-manual-efi-acpi-q35.xml | 6 +- .../firmware-manual-efi-features.xml | 6 +- ...ware-manual-efi-no-path.x86_64-latest.err} | 0 .../firmware-manual-efi-no-path.xml | 6 +- ...al-efi-noacpi-aarch64.aarch64-latest.args} | 11 +- .../firmware-manual-efi-noacpi-aarch64.xml | 6 +- ...e-manual-efi-noacpi-q35.x86_64-latest.err} | 0 .../firmware-manual-efi-noacpi-q35.xml | 6 +- ...e-manual-efi-nvram-file.x86_64-latest.args | 18 +- .../firmware-manual-efi-nvram-file.xml | 8 +- ...efi-nvram-network-iscsi.x86_64-latest.args | 16 +- ...irmware-manual-efi-nvram-network-iscsi.xml | 6 +- ...l-efi-nvram-network-nbd.x86_64-latest.args | 16 +- .../firmware-manual-efi-nvram-network-nbd.xml | 6 +- .../firmware-manual-efi-nvram-stateless.xml | 8 +- ...re-manual-efi-nvram-template-stateless.xml | 6 +- ...nual-efi-nvram-template.x86_64-latest.args | 18 +- .../firmware-manual-efi-nvram-template.xml | 6 +- ...manual-efi-rw-implicit.x86_64-latest.args} | 18 +- ...ml => firmware-manual-efi-rw-implicit.xml} | 8 +- ...firmware-manual-efi-rw.x86_64-latest.args} | 18 +- ...bios-rw.xml => firmware-manual-efi-rw.xml} | 8 +- .../firmware-manual-efi-secure.args | 35 -- ...ware-manual-efi-secure.x86_64-latest.args} | 20 +- .../firmware-manual-efi-secure.xml | 8 +- ...re-manual-efi-stateless.x86_64-latest.args | 16 +- .../firmware-manual-efi-stateless.xml | 6 +- .../qemuxml2argvdata/firmware-manual-efi.args | 32 -- ...=> firmware-manual-efi.x86_64-latest.args} | 13 +- .../qemuxml2argvdata/firmware-manual-efi.xml | 8 +- ...ual-noefi-acpi-aarch64.aarch64-latest.err} | 0 .../firmware-manual-noefi-acpi-aarch64.xml | 4 +- ...-manual-noefi-acpi-q35.x86_64-latest.args} | 9 +- .../firmware-manual-noefi-acpi-q35.xml | 4 +- ...-noefi-noacpi-aarch64.aarch64-latest.args} | 9 +- .../firmware-manual-noefi-noacpi-aarch64.xml | 4 +- ...anual-noefi-noacpi-q35.x86_64-latest.args} | 9 +- .../firmware-manual-noefi-noacpi-q35.xml | 4 +- .../virtio-iommu-aarch64.aarch64-latest.args | 8 +- tests/qemuxml2argvtest.c | 51 +- .../aarch64-virt-graphics.aarch64-latest.xml | 2 +- .../aarch64-virt-headless.aarch64-latest.xml | 2 +- ...ware-auto-bios-stateless.x86_64-latest.xml | 10 +- .../firmware-auto-bios.x86_64-latest.xml | 9 +- ...rmware-auto-efi-aarch64.aarch64-latest.xml | 8 +- ...e-auto-efi-enrolled-keys.x86_64-latest.xml | 15 +- ...efi-format-loader-qcow2.x86_64-latest.xml} | 11 +- ...-efi-format-loader-raw.aarch64-latest.xml} | 8 +- ...nvram-qcow2-network-nbd.x86_64-latest.xml} | 10 +- ...format-nvram-qcow2-path.x86_64-latest.xml} | 11 +- ...-efi-format-nvram-qcow2.x86_64-latest.xml} | 11 +- ...e-auto-efi-loader-secure.x86_64-latest.xml | 12 +- ...uto-efi-no-enrolled-keys.x86_64-latest.xml | 13 +- ...ware-auto-efi-no-secboot.x86_64-latest.xml | 13 +- ...are-auto-efi-nvram-file.x86_64-latest.xml} | 10 +- ...efi-nvram-network-iscsi.x86_64-latest.xml} | 6 +- ...o-efi-nvram-network-nbd.x86_64-latest.xml} | 6 +- .../firmware-auto-efi-nvram.x86_64-latest.xml | 12 +- ...irmware-auto-efi-secboot.x86_64-latest.xml | 14 +- ...rmware-auto-efi-smm-off.x86_64-latest.xml} | 12 +- ...ware-auto-efi-stateless.x86_64-latest.xml} | 10 +- .../firmware-auto-efi.x86_64-latest.xml | 11 +- ...e-manual-bios-stateless.x86_64-latest.xml} | 11 +- ...=> firmware-manual-bios.x86_64-latest.xml} | 11 +- ...anual-efi-acpi-aarch64.aarch64-latest.xml} | 8 +- ...are-manual-efi-acpi-q35.x86_64-latest.xml} | 13 +- ...ual-efi-noacpi-aarch64.aarch64-latest.xml} | 9 +- ...re-manual-efi-nvram-file.x86_64-latest.xml | 10 +- ...-efi-nvram-network-iscsi.x86_64-latest.xml | 6 +- ...al-efi-nvram-network-nbd.x86_64-latest.xml | 6 +- ...nual-efi-nvram-template.x86_64-latest.xml} | 10 +- ...-manual-efi-rw-implicit.x86_64-latest.xml} | 11 +- ... firmware-manual-efi-rw.x86_64-latest.xml} | 11 +- ...mware-manual-efi-secure.x86_64-latest.xml} | 14 +- ...re-manual-efi-stateless.x86_64-latest.xml} | 11 +- ... => firmware-manual-efi.x86_64-latest.xml} | 11 +- ...e-manual-noefi-acpi-q35.x86_64-latest.xml} | 10 +- ...l-noefi-noacpi-aarch64.aarch64-latest.xml} | 7 +- ...manual-noefi-noacpi-q35.x86_64-latest.xml} | 13 +- .../virtio-iommu-aarch64.aarch64-latest.xml | 4 +- tests/qemuxml2xmltest.c | 32 +- 160 files changed, 1408 insertions(+), 990 deletions(-) create mode 100644 tests/qemufirmwaredata/usr/share/qemu/firmware/65-ovmf-qcow2.json create mode 100644 tests/qemufirmwaredata/usr/share/qemu/firmware/66-aavmf-qcow2.json copy tests/qemuxml2argvdata/{firmware-auto-efi-no-enrolled-keys.x86_64-latest.args => firmware-auto-efi-format-loader-qcow2.x86_64-latest.args} (61%) copy tests/qemuxml2argvdata/{firmware-auto-efi-stateless.xml => firmware-auto-efi-format-loader-qcow2.xml} (81%) copy tests/qemuxml2argvdata/{virtio-iommu-aarch64.aarch64-latest.args => firmware-auto-efi-format-loader-raw.aarch64-latest.args} (89%) copy tests/qemuxml2argvdata/{firmware-auto-efi-aarch64.xml => firmware-auto-efi-format-loader-raw.xml} (79%) create mode 100644 tests/qemuxml2argvdata/firmware-auto-efi-format-mismatch.x86_64-latest.err copy tests/qemuxml2argvdata/{firmware-auto-efi-nvram.xml => firmware-auto-efi-format-mismatch.xml} (75%) copy tests/qemuxml2argvdata/{firmware-manual-efi-nvram-network-nbd.x86_64-latest.args => firmware-auto-efi-format-nvram-qcow2-network-nbd.x86_64-latest.args} (61%) copy tests/qemuxml2argvdata/{firmware-manual-efi-nvram-network-nbd.xml => firmware-auto-efi-format-nvram-qcow2-network-nbd.xml} (63%) copy tests/qemuxml2argvdata/{firmware-auto-efi-no-enrolled-keys.x86_64-latest.args => firmware-auto-efi-format-nvram-qcow2-path.x86_64-latest.args} (58%) copy tests/qemuxml2argvdata/{firmware-auto-efi-nvram.xml => firmware-auto-efi-format-nvram-qcow2-path.xml} (76%) copy tests/qemuxml2argvdata/{firmware-auto-efi-no-enrolled-keys.x86_64-latest.args => firmware-auto-efi-format-nvram-qcow2.x86_64-latest.args} (61%) copy tests/qemuxml2argvdata/{firmware-auto-efi-loader-secure.xml => firmware-auto-efi-format-nvram-qcow2.xml} (81%) copy tests/qemuxml2argvdata/{firmware-manual-efi-acpi-q35.args => firmware-auto-efi-nvram-file.x86_64-latest.args} (63%) copy tests/qemuxml2argvdata/{firmware-manual-noefi-acpi-q35.xml => firmware-auto-efi-nvram-file.xml} (60%) copy tests/qemuxml2argvdata/{firmware-manual-efi-nvram-network-iscsi.x86_64-latest.args => firmware-auto-efi-nvram-network-iscsi.x86_64-latest.args} (77%) copy tests/qemuxml2argvdata/{firmware-manual-efi-nvram-network-iscsi.xml => firmware-auto-efi-nvram-network-iscsi.xml} (73%) copy tests/qemuxml2argvdata/{firmware-manual-efi-nvram-network-nbd.x86_64-latest.args => firmware-auto-efi-nvram-network-nbd.x86_64-latest.args} (72%) copy tests/qemuxml2argvdata/{firmware-manual-efi-nvram-network-nbd.xml => firmware-auto-efi-nvram-network-nbd.xml} (67%) copy tests/qemuxml2argvdata/{virtio-iommu-aarch64.aarch64-latest.args => firmware-auto-efi-smm-off.x86_64-latest.args} (67%) copy tests/qemuxml2argvdata/{firmware-auto-efi.xml => firmware-auto-efi-smm-off.xml} (82%) rename tests/qemuxml2argvdata/{firmware-manual-bios-not-stateless.err => firmware-manual-bios-not-stateless.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/firmware-manual-bios-stateless.args copy tests/qemuxml2argvdata/{firmware-manual-noefi-noacpi-q35.args => firmware-manual-bios-stateless.x86_64-latest.args} (60%) delete mode 100644 tests/qemuxml2argvdata/firmware-manual-bios.args copy tests/qemuxml2argvdata/{firmware-manual-noefi-noacpi-q35.args => firmware-manual-bios.x86_64-latest.args} (60%) rename tests/qemuxml2argvdata/{firmware-manual-efi-acpi-aarch64.args => firmware-manual-efi-acpi-aarch64.aarch64-latest.args} (62%) copy tests/qemuxml2argvdata/{firmware-manual-efi-acpi-q35.args => firmware-manual-efi-acpi-q35.x86_64-latest.args} (64%) rename tests/qemuxml2argvdata/{firmware-manual-efi-no-path.err => firmware-manual-efi-no-path.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{firmware-manual-efi-noacpi-aarch64.args => firmware-manual-efi-noacpi-aarch64.aarch64-latest.args} (62%) rename tests/qemuxml2argvdata/{firmware-manual-efi-noacpi-q35.err => firmware-manual-efi-noacpi-q35.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{firmware-manual-bios-rw.x86_64-latest.args => firmware-manual-efi-rw-implicit.x86_64-latest.args} (57%) rename tests/qemuxml2argvdata/{firmware-manual-bios-rw-implicit.xml => firmware-manual-efi-rw-implicit.xml} (60%) rename tests/qemuxml2argvdata/{firmware-manual-bios-rw-implicit.x86_64-latest.args => firmware-manual-efi-rw.x86_64-latest.args} (57%) rename tests/qemuxml2argvdata/{firmware-manual-bios-rw.xml => firmware-manual-efi-rw.xml} (59%) delete mode 100644 tests/qemuxml2argvdata/firmware-manual-efi-secure.args copy tests/qemuxml2argvdata/{firmware-auto-efi-nvram.x86_64-latest.args => firmware-manual-efi-secure.x86_64-latest.args} (70%) delete mode 100644 tests/qemuxml2argvdata/firmware-manual-efi.args rename tests/qemuxml2argvdata/{firmware-manual-efi-acpi-q35.args => firmware-manual-efi.x86_64-latest.args} (63%) rename tests/qemuxml2argvdata/{firmware-manual-noefi-acpi-aarch64.err => firmware-manual-noefi-acpi-aarch64.aarch64-latest.err} (100%) rename tests/qemuxml2argvdata/{firmware-manual-noefi-acpi-q35.args => firmware-manual-noefi-acpi-q35.x86_64-latest.args} (63%) rename tests/qemuxml2argvdata/{firmware-manual-noefi-noacpi-aarch64.args => firmware-manual-noefi-noacpi-aarch64.aarch64-latest.args} (60%) rename tests/qemuxml2argvdata/{firmware-manual-noefi-noacpi-q35.args => firmware-manual-noefi-noacpi-q35.x86_64-latest.args} (64%) copy tests/qemuxml2xmloutdata/{firmware-auto-efi-loader-secure.x86_64-latest.xml => firmware-auto-efi-format-loader-qcow2.x86_64-latest.xml} (74%) copy tests/qemuxml2xmloutdata/{firmware-auto-efi-aarch64.aarch64-latest.xml => firmware-auto-efi-format-loader-raw.aarch64-latest.xml} (74%) copy tests/qemuxml2xmloutdata/{firmware-manual-efi-nvram-network-nbd.x86_64-latest.xml => firmware-auto-efi-format-nvram-qcow2-network-nbd.x86_64-latest.xml} (76%) copy tests/qemuxml2xmloutdata/{firmware-auto-efi-loader-secure.x86_64-latest.xml => firmware-auto-efi-format-nvram-qcow2-path.x86_64-latest.xml} (75%) copy tests/qemuxml2xmloutdata/{firmware-auto-efi-loader-secure.x86_64-latest.xml => firmware-auto-efi-format-nvram-qcow2.x86_64-latest.xml} (74%) copy tests/qemuxml2xmloutdata/{firmware-manual-efi-nvram-file.x86_64-latest.xml => firmware-auto-efi-nvram-file.x86_64-latest.xml} (78%) copy tests/qemuxml2xmloutdata/{firmware-manual-efi-nvram-network-iscsi.x86_64-latest.xml => firmware-auto-efi-nvram-network-iscsi.x86_64-latest.xml} (89%) copy tests/qemuxml2xmloutdata/{firmware-manual-efi-nvram-network-nbd.x86_64-latest.xml => firmware-auto-efi-nvram-network-nbd.x86_64-latest.xml} (88%) copy tests/qemuxml2xmloutdata/{firmware-auto-efi-loader-secure.x86_64-latest.xml => firmware-auto-efi-smm-off.x86_64-latest.xml} (75%) copy tests/qemuxml2xmloutdata/{firmware-auto-bios-stateless.x86_64-latest.xml => firmware-auto-efi-stateless.x86_64-latest.xml} (82%) rename tests/qemuxml2xmloutdata/{firmware-manual-bios-stateless.xml => firmware-manual-bios-stateless.x86_64-latest.xml} (69%) rename tests/qemuxml2xmloutdata/{firmware-manual-bios.xml => firmware-manual-bios.x86_64-latest.xml} (69%) copy tests/qemuxml2xmloutdata/{firmware-auto-efi-aarch64.aarch64-latest.xml => firmware-manual-efi-acpi-aarch64.aarch64-latest.xml} (76%) copy tests/qemuxml2xmloutdata/{firmware-auto-efi-loader-secure.x86_64-latest.xml => firmware-manual-efi-acpi-q35.x86_64-latest.xml} (76%) copy tests/qemuxml2xmloutdata/{firmware-auto-efi-aarch64.aarch64-latest.xml => firmware-manual-efi-noacpi-aarch64.aarch64-latest.xml} (76%) copy tests/qemuxml2xmloutdata/{firmware-manual-efi-nvram-file.x86_64-latest.xml => firmware-manual-efi-nvram-template.x86_64-latest.xml} (78%) copy tests/qemuxml2xmloutdata/{firmware-manual-efi-nvram-file.x86_64-latest.xml => firmware-manual-efi-rw-implicit.x86_64-latest.xml} (72%) copy tests/qemuxml2xmloutdata/{firmware-manual-efi-nvram-file.x86_64-latest.xml => firmware-manual-efi-rw.x86_64-latest.xml} (72%) copy tests/qemuxml2xmloutdata/{firmware-auto-efi-loader-secure.x86_64-latest.xml => firmware-manual-efi-secure.x86_64-latest.xml} (73%) copy tests/qemuxml2xmloutdata/{firmware-manual-efi-nvram-file.x86_64-latest.xml => firmware-manual-efi-stateless.x86_64-latest.xml} (72%) rename tests/qemuxml2xmloutdata/{firmware-manual-efi.xml => firmware-manual-efi.x86_64-latest.xml} (70%) copy tests/qemuxml2xmloutdata/{firmware-auto-efi.x86_64-latest.xml => firmware-manual-noefi-acpi-q35.x86_64-latest.xml} (86%) copy tests/qemuxml2xmloutdata/{firmware-auto-efi-aarch64.aarch64-latest.xml => firmware-manual-noefi-noacpi-aarch64.aarch64-latest.xml} (88%) copy tests/qemuxml2xmloutdata/{firmware-auto-efi.x86_64-latest.xml => firmware-manual-noefi-noacpi-q35.x86_64-latest.xml} (83%) -- 2.39.1

2 36

[PATCH 0/6] Generate ACL permision data in apibuild
by Peter Krempa 03 Mar '23

03 Mar '23

Peter Krempa (6): remote_protocol: Fix list of supported ACL object names apibuild: Add infrastructure for generating ACL flag info into function docs scripts/apibuild: Extract and format API ACLs docs/newapi.xsl: Take API flag data from libvirt-api.xml rather than access/libvirt-access.xml docs|access: Don't build the ACL flags into a separate XML gendispatch: Drop 'aclapi' mode docs/html/meson.build | 32 +------ docs/meson.build | 3 + docs/newapi.xsl | 20 ++--- scripts/apibuild.py | 163 ++++++++++++++++++++++++++++++++++- src/access/meson.build | 16 ---- src/remote/remote_protocol.x | 5 +- src/rpc/gendispatch.pl | 64 +------------- 7 files changed, 176 insertions(+), 127 deletions(-) -- 2.39.2

2 7

[PATCH 0/4] qemu: Let virCommand report errors
by Michal Privoznik 03 Mar '23

03 Mar '23

In a lot of places we catch errors from qemuSecurityCommandRun() only to produce an error report. But we can let virCommand module do the same. Michal Prívozník (4): qemu_slirp: Don't set errfd when starting slirp helper qemu: Don't overwrite error from qemuSecurityCommandRun() qemu: Drop @cmdret argument from qemuSecurityCommandRun() qemu: Let virCommand module translate exitstatus src/qemu/qemu_dbus.c | 11 +---------- src/qemu/qemu_passt.c | 12 +----------- src/qemu/qemu_security.c | 13 ++++++------- src/qemu/qemu_security.h | 3 +-- src/qemu/qemu_slirp.c | 12 +----------- src/qemu/qemu_tpm.c | 9 +-------- src/qemu/qemu_vhost_user_gpu.c | 11 ++--------- 7 files changed, 13 insertions(+), 58 deletions(-) -- 2.39.2

2 6

[libvirt PATCH v6 0/8] Add support for 'blob' to virtio video device
by Jonathon Jongsma 03 Mar '23

03 Mar '23

Add support to libvirt for the 'blob' option for virtio video devices in qemu. Also do a little preparatory refactoring of the video device xml parsing code. This series was basically acked by Jan some time ago, but I made a couple changes and apparently I dropped the ball and forgot to send out the revised series. So here's a v6 after rebasing yet again to current master. changes in v6: - added two new patches: - conf: explicitly set VIR_DOMAIN_VIDEO_TYPE_DEFAULT to 0 - util: add virXMLPropUIntDefault() function - other minor fixes from Jan's review Jonathon Jongsma (8): conf: explicitly set VIR_DOMAIN_VIDEO_TYPE_DEFAULT to 0 conf: Refactor video model parsing util: add virXMLPropUIntDefault() function conf: switch to virXMLProp* functions for parsing video conf: use enum variable for video type conf: add support for 'blob' in virtio video device qemu: Add capability for virtio-gpu.blob qemu: Implement 'blob' support for virtio gpu docs/formatdomain.rst | 7 + src/conf/cpu_conf.c | 9 +- src/conf/domain_conf.c | 134 ++++++++---------- src/conf/domain_conf.h | 5 +- src/conf/domain_validate.c | 13 +- src/conf/numa_conf.c | 7 +- src/conf/schemas/domaincommon.rng | 5 + src/libxl/libxl_conf.c | 10 ++ src/libxl/libxl_domain.c | 11 ++ src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_cgroup.c | 22 ++- src/qemu/qemu_command.c | 3 + src/qemu/qemu_domain.h | 1 + src/qemu/qemu_monitor_json.c | 16 ++- src/qemu/qemu_namespace.c | 22 +++ src/qemu/qemu_process.c | 7 + src/qemu/qemu_validate.c | 9 ++ src/util/virxml.c | 29 +++- src/util/virxml.h | 9 ++ .../caps_6.1.0.x86_64.xml | 1 + .../caps_6.2.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_6.2.0.ppc64.xml | 1 + .../caps_6.2.0.x86_64.xml | 1 + .../caps_7.0.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_7.0.0.ppc64.xml | 1 + .../caps_7.0.0.x86_64.xml | 1 + .../qemucapabilitiesdata/caps_7.1.0.ppc64.xml | 1 + .../caps_7.1.0.x86_64.xml | 1 + .../caps_7.2.0.x86_64.xml | 1 + .../caps_8.0.0.riscv64.xml | 1 + .../caps_8.0.0.x86_64.xml | 1 + .../video-virtio-blob-off.x86_64-latest.args | 39 +++++ .../video-virtio-blob-off.xml | 36 +++++ .../video-virtio-blob-on.x86_64-latest.args | 39 +++++ .../qemuxml2argvdata/video-virtio-blob-on.xml | 36 +++++ tests/qemuxml2argvtest.c | 2 + .../video-virtio-blob-off.x86_64-latest.xml | 48 +++++++ .../video-virtio-blob-on.x86_64-latest.xml | 48 +++++++ tests/qemuxml2xmltest.c | 2 + 40 files changed, 483 insertions(+), 101 deletions(-) create mode 100644 tests/qemuxml2argvdata/video-virtio-blob-off.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/video-virtio-blob-off.xml create mode 100644 tests/qemuxml2argvdata/video-virtio-blob-on.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/video-virtio-blob-on.xml create mode 100644 tests/qemuxml2xmloutdata/video-virtio-blob-off.x86_64-latest.xml create mode 100644 tests/qemuxml2xmloutdata/video-virtio-blob-on.x86_64-latest.xml -- 2.39.0

2 10

[PATCH] security: Add support for SUSE edk2 firmware paths
by Jim Fehlig 02 Mar '23

02 Mar '23

SUSE installs edk2 firmwares for both x86_64 and aarch64 in /usr/share/qemu. Add support for this path in virt-aa-helper and allow locking files within the path in the libvirt qemu abstraction. Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- FYI, I'm fine maintaining this patch downstream if such distro-specific change is unwanted upstream. I've already maintained the virt-aa-helper hunk for several years. src/security/apparmor/libvirt-qemu | 2 +- src/security/virt-aa-helper.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/security/apparmor/libvirt-qemu b/src/security/apparmor/libvirt-qemu index d0289b8943..9af1333b22 100644 --- a/src/security/apparmor/libvirt-qemu +++ b/src/security/apparmor/libvirt-qemu @@ -91,7 +91,7 @@ /usr/share/proll/** r, /usr/share/qemu-efi/** r, /usr/share/qemu-kvm/** r, - /usr/share/qemu/** r, + /usr/share/qemu/** rk, /usr/share/seabios/** r, /usr/share/sgabios/** r, /usr/share/slof/** r, diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c index f6c9703db6..d65d459850 100644 --- a/src/security/virt-aa-helper.c +++ b/src/security/virt-aa-helper.c @@ -481,6 +481,7 @@ valid_path(const char *path, const bool readonly) "/usr/share/AAVMF/", /* for AAVMF images */ "/usr/share/qemu-efi/", /* for AAVMF images */ "/usr/share/qemu-efi-aarch64/", /* for AAVMF images */ + "/usr/share/qemu/", /* SUSE path for OVMF and AAVMF images */ "/usr/lib/u-boot/", /* u-boot loaders for qemu */ "/usr/lib/riscv64-linux-gnu/opensbi" /* RISC-V SBI implementation */ }; -- 2.39.2

3 3

[libvirt PATCH] NEWS: Clarify limitations of passt support
by Andrea Bolognani 01 Mar '23

01 Mar '23

Let users know that we're working on lifting the limitations and that they should not use the feature in production until then. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- NEWS.rst | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/NEWS.rst b/NEWS.rst index 683c147af0..b19c75ceac 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -79,7 +79,9 @@ v9.1.0 (unreleased) connectivity. (NB: On systems that use them, it is still necessary to disable - SELinux/AppArmor to start passt.) + SELinux/AppArmor to start passt. This is a temporary limitation, + and use of the feature in production is strongly discouraged + until it has been lifted.) * qemu: Fix error when attempting to change media in a CDROM drive -- 2.39.2

2 2

[PATCH 0/2] Deprecate support for 32-bit x86 and arm hosts
by Thomas Huth 01 Mar '23

01 Mar '23

We're struggling quite badly with our CI minutes on the shared gitlab runners, so we urgently need to think of ways to cut down our supported build and target environments. qemu-system-i386 and qemu-system-arm are not really required anymore, since nobody uses KVM on the corresponding systems for production anymore, and the -x86_64 and -arch64 variants are a proper superset of those binaries. So it's time to deprecate them and the corresponding 32-bit host environments now. This is a follow-up patch series from the previous discussion here: https://lore.kernel.org/qemu-devel/20230130114428.1297295-1-thuth@redhat.co… where people still mentioned that there is still interest in certain support for 32-bit host hardware. But as far as I could see, there is no real need for 32-bit host support for system emulation on x86 and arm anymore, so it should be fine if we drop these host environments now (these are also the two architectures that contribute the most to the long test times in our CI, so we would benefit a lot by dropping those). Thomas Huth (2): docs/about: Deprecate 32-bit x86 hosts and qemu-system-i386 docs/about: Deprecate 32-bit arm hosts and qemu-system-arm docs/about/deprecated.rst | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) -- 2.31.1

7 36

[PATCH] NEWS: note new passt feature & bugfix for 9.1.0 release
by Laine Stump 28 Feb '23

28 Feb '23

At Stefano's suggestion, this also adds a sentence pointing out that SELinux must be disabled in order for passt support to work. I didn't think to put this info in the NEWS file last month. Signed-off-by: Laine Stump <laine(a)redhat.com> --- I've noticed that in some places, QEMU related points are marked with "QEMU:" and in other places they are marked with "qemu:". In the 9.1.0 sections, the new features all use "qemu:" while the bugfixes all use "QEMU:". I just went along with the flow in both cases, but we should probably do a patch to standardize on one or the other (and then try to stick to it). So which is more appropriate? using the capitalization the way the QEMU project prefers it? Or the capitalization the way the subdirectory in libvirt is named? NEWS.rst | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 1180d75310..df613abc69 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -38,6 +38,13 @@ v9.1.0 (unreleased) A pvpanic device can be now defined as a PCI device (the original is an ISA device) with ``<panic model='pvpanic'/>``. + * qemu: support automatic restart of inadvertantly terminated passt process + + If the passt process that is serving as the backend of a -netdev + stream is terminated unexpectedly, libvirt now listens to QEMU's + notification of this, and starts up a new passt instance, thus + preserving network connectivity. + * **Improvements** * RPM packaging changes @@ -63,6 +70,15 @@ v9.1.0 (unreleased) snapshot when it existed. In addition when external memory only snapshot was created libvirt failed without producing any error. + * QEMU: properly report passt startup errors + + Due to how the child passt process was started, the initial + support for passt (added in 9.0.0) would not see errors + encountered during startup, so libvirt would continue to setup and + start the guest; this led to a running guest with no network + connectivity. This issue has be corrected. + + (NB: it is still necessary to disable SELinux to start passt.) v9.0.0 (2023-01-16) =================== -- 2.39.2

4 6

[PATCH] NEWS: strongly suggest that <backend type='passt'/> not yet be used in production
by Laine Stump 28 Feb '23

28 Feb '23

Based on Stefano's suggestion that the NEWS should not seem to encourage disabling SELinux or AppArmor (which is a valid point) this replaces the "you need to disable SELinux/AppArmor" note with a "please do not use in production because that will require disabling SELinux/AppArmor". Signed-off-by: Laine Stump <laine(a)redhat.com> --- If this change seems okay, anyone who ACKs please push it so that it's in place before Jiri cuts the release (I may not yet be awake at that time of day). NEWS.rst | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/NEWS.rst b/NEWS.rst index af7a3b2c76..b9fe73a747 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -78,8 +78,10 @@ v9.1.0 (unreleased) start the guest; this led to a running guest with no network connectivity. - (NB: On systems that use them, it is still necessary to disable - SELinux/AppArmor to start passt.) + (NB: Please do not use <backend type='passt'/> on production + systems with Linux Security Modules as it currently requires + setting SELinux to permissive mode or disabling selected AppArmor + profiles) v9.0.0 (2023-01-16) -- 2.39.2

1 0

[PATCH] NEWS: Mention two user-visible bug fixes
by Peter Krempa 28 Feb '23

28 Feb '23

Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- NEWS.rst | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index d1f88b3d59..ca93c24150 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -80,6 +80,18 @@ v9.1.0 (unreleased) (NB: it is still necessary to disable SELinux to start passt.) + * qemu: Fix error when attempting to change media in a CDROM drive + + Due to a logic bug introduced in libvirt-9.0 attempts to change media in a + CDROM would previously fail with an error stating that the tray isn't open. + + * qemu: Properly handle block job transitions + + Starting with libvirt-9.0 the block job state machine improperly handled + some job transitions which resulted into some block jobs not being properly + terminated. This could cause problems such as errors when detaching a disk + after snapshot. + v9.0.0 (2023-01-16) =================== -- 2.39.2

2 1