January 2023 - Devel - libvirt List Archives

[PATCH] NEWS: Document virDomainFDAssociate and NULL dereference in virXMLPropStringRequired
by Peter Krempa 13 Jan '23

13 Jan '23

Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- NEWS.rst | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 8482c49b3c..9baf10b8e9 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -38,6 +38,12 @@ v9.0.0 (unreleased) Connecting the VM to a swtpm daemon started outside of libvirt is now possible. + * QEMU: Support for passing FDs instead of opening files for `<disk>` + + A new API `virDomainFDAssociate` gives the users the option to pass FDs + to libvirt and then use them when starting a VM. Currently the FDs can + be used instead of directly opening files as `<disk>` backend. + * **Improvements** * qemu: Prefer PNG for domain screenshots @@ -46,6 +52,11 @@ v9.0.0 (unreleased) * **Bug fixes** + * Fix NULL-pointer dereference `virXMLPropStringRequired` + + Fix a bug where when parsing a XML property which is required to be present + by using `virXMLPropStringRequired` the parser will crash instead of + reporting an error. v8.10.0 (2022-12-01) ==================== -- 2.38.1

2 1

[libvirt PATCH 0/3] Remove <backend upstream='blah'/> per danpb's request, and a couple small cleanups
by Laine Stump 13 Jan '23

13 Jan '23

The first patch implements what danpb suggested yesterday - using <source dev='blah'/> instead of <backend upstream='blah'/> to populate the passt --interface option. The other two are small cleanups I noticed while making the changes in patch 1. jdenemar: feel free to push once they've been reviewed, rather than waiting for me to get up, so that you can get RC2 tagged. Laine Stump (3): conf: remove <backend upstream='xxx'/> attribute qemu: remove commented-out option in passt qemu commandline setup tests: remove unused qemu .args file docs/formatdomain.rst | 9 +++--- src/conf/domain_conf.c | 15 ++++++++-- src/conf/domain_conf.h | 1 + src/conf/schemas/domaincommon.rng | 13 +++++---- src/qemu/qemu_passt.c | 5 ++-- tests/qemuxml2argvdata/net-user-passt.args | 34 ---------------------- tests/qemuxml2argvdata/net-user-passt.xml | 3 +- 7 files changed, 31 insertions(+), 49 deletions(-) delete mode 100644 tests/qemuxml2argvdata/net-user-passt.args -- 2.38.1

2 5

[libvirt PATCH 0/9] Support libvirt-managed QEMU domain <interface> backed by a passt process
by Laine Stump 12 Jan '23

12 Jan '23

passt (https://passt.top) provides a method for connecting a guest to the larger network without requiring any elevated privileges. This set of patches allows libvirt/QEMU users to easily configure a QEMU domain to use passt for the backend of any emulated network interface. More details are in the individual patches, but the short explanation is that you will use: <interface type='user'> <backend type='passt'> ... to select the passt backend. (We decided to do it this way since the concept is so similar to slirp, which was the original "type='user'") The following caveats currently apply: 1) passt support requires "-netdev stream" in QEMU, which is only available starting with qemu-7.2.0. So if you want to test these patches out, you need the latest upstream release of QEMU. 2) SELinux must be set to "permissive". This is of course temporary. As I understand it, the remedy to this is a new SELinux profile for the passt binary, which is outside the control of libvirt and so not something that can be addressed in this patchset (or any other patch to libvirt). 3) Although there is a a new option for QEMU's -netdev that will tell QEMU to attempt to reconnect to a new incarnation of the same socket if passt unexpectedly exits, and a new QEMU event that will be put into QEMU to inform libvirt that the passt process has exited (so that it can start a new, identical passt process), I think this hasn't been pushed upstream yet (??), and I haven't implemented any support for it here. So, if the passt process unexpectedly exits, the guest will be without networking. However, Stefano (passt author) is emphatic that passt will never unexpectedly exit :-) passt has *many* other options that libvirt could support, but the small subset here are the things that seem most useful (and/or were specifically requested by prospective users of passt). It is always easier to add more stuff in the future than to remove "mistakes", so I tried to no go overboard. Laine Stump (9): conf: rename virDomainNetBackend* to virDomainNetDriver* conf: move anonymous backend struct from virDomainNetDef into its own struct conf: put interface <backend> parsing/formatting separate functions conf: add passt XML additions to schema conf: parse/format passt-related XML additions qemu: new capability QEMU_CAPS_NETDEV_STREAM qemu: add passtStateDir to qemu driver config qemu: hook up passt config to qemu domains specfile: require passt for the build if fedora >= 36 or rhel >= 9 docs/formatdomain.rst | 95 +++++- libvirt.spec.in | 7 + meson.build | 1 + po/POTFILES | 1 + src/conf/domain_conf.c | 303 ++++++++++++++++-- src/conf/domain_conf.h | 64 +++- src/conf/domain_validate.c | 32 +- src/conf/schemas/domaincommon.rng | 65 ++++ src/conf/virconftypes.h | 6 + src/libvirt_private.syms | 1 + src/qemu/meson.build | 2 + src/qemu/qemu_capabilities.c | 4 + src/qemu/qemu_capabilities.h | 3 + src/qemu/qemu_command.c | 11 +- src/qemu/qemu_command.h | 3 +- src/qemu/qemu_conf.c | 2 + src/qemu/qemu_conf.h | 1 + src/qemu/qemu_domain.c | 5 +- src/qemu/qemu_domain.h | 3 +- src/qemu/qemu_driver.c | 12 + src/qemu/qemu_extdevice.c | 25 +- src/qemu/qemu_hotplug.c | 26 +- src/qemu/qemu_interface.c | 8 +- src/qemu/qemu_passt.c | 284 ++++++++++++++++ src/qemu/qemu_passt.h | 38 +++ src/qemu/qemu_process.c | 1 + src/qemu/qemu_validate.c | 9 +- src/security/virt-aa-helper.c | 2 +- .../caps_7.2.0.x86_64.xml | 1 + tests/qemuxml2argvdata/net-user-passt.args | 34 ++ .../net-user-passt.x86_64-latest.args | 37 +++ tests/qemuxml2argvdata/net-user-passt.xml | 57 ++++ tests/qemuxml2argvtest.c | 2 + tests/qemuxml2xmloutdata/net-user-passt.xml | 1 + tests/qemuxml2xmltest.c | 1 + 35 files changed, 1087 insertions(+), 60 deletions(-) create mode 100644 src/qemu/qemu_passt.c create mode 100644 src/qemu/qemu_passt.h create mode 100644 tests/qemuxml2argvdata/net-user-passt.args create mode 100644 tests/qemuxml2argvdata/net-user-passt.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/net-user-passt.xml create mode 120000 tests/qemuxml2xmloutdata/net-user-passt.xml -- 2.38.1

5 27

[PATCH V7 00/12] spec: Decompose the daemon subpackage
by Jim Fehlig 12 Jan '23

12 Jan '23

This is V7 of https://listman.redhat.com/archives/libvir-list/2023-January/236586.html The end goal is to remove the libvirt-dameon dependency on the various libvirt-daemon-driver-foo subpackages, allowing installation of a modular daemon configuration without the traditional monolithic libvirtd. Changes from V6: * Revert to including virtlockd and lockd plugin in the hypervisor subpackages * Add NEWS entry Jim Fehlig (12): spec: Move virtlockd to a new subpackage libvirt-daemon-lock spec: Move virtlogd to a new subpackage libvirt-daemon-log spec: Move virtproxyd to a new subpackage libvirt-daemon-proxy spec: Move lockd plugin to a new subpackage spec: Rename the libvirt-lock-sanlock subpackage spec: Move common files and dependencies to libvirt-daemon-common spec: Add module-init-tools dependency to nodedev and lxc drivers spec: Add numad dependency to qemu and lxc drivers spec: Remove libvirt-daemon dependency from drivers spec: Remove libvirt-daemon dependency from hypervisor subpackages kbase: Update rpm-deployment.rst with new subpackages NEWS: Mention split of libvirt-daemon subpackage NEWS.rst | 6 + docs/kbase/rpm-deployment.rst | 48 +++-- libvirt.spec.in | 331 ++++++++++++++++++++++++---------- 3 files changed, 277 insertions(+), 108 deletions(-) -- 2.38.1

3 20

[PATCH] docs: drvqemu: Fix a typo
by Han Han 12 Jan '23

12 Jan '23

Fixes: a677ea92 Signed-off-by: Han Han <hhan(a)redhat.com> --- docs/drvqemu.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/drvqemu.rst b/docs/drvqemu.rst index fa23912937..22d7e6502b 100644 --- a/docs/drvqemu.rst +++ b/docs/drvqemu.rst @@ -295,7 +295,7 @@ to ``system_u:object_r:virt_image_t``. In the case of NFS, there is an alternative option, of enabling the ``virt_use_nfs`` SELinux boolean. There are some network filesystems, however, that propagate SELinux labels -properly, just like a local filesystem (e.g. ceph of CIFS). In such case, +properly, just like a local filesystem (e.g. ceph or CIFS). In such case, dynamic labelling (described below) might prevent migration of a virtual machine as new unique SELinux label is assigned to the virtual machine on the migration destination side. Users are advised to use static labels (``<seclabel -- 2.39.0

2 1

[PATCH v1] qemu: block: fix error when blockcopy target is librbd encrypted
by Or Ozeri 12 Jan '23

12 Jan '23

Encryption secrets are considered a format dependency, even when being used by the storage node itself, as in the case of using encryption engine=librbd. Currently, the storage node is created (blockdev-add) before creating the format dependencies (including encryption secrets). As a result, when trying to perform a blockcopy when the target disk uses librbd encryption, an error of this form is returned: "error: internal error: unable to execute QEMU command 'blockdev-add': No secret with id 'libvirt-5-format-encryption-secret0'" To overcome this error, we change the order of commands so that format dependencies are created BEFORE creating the storage node. Signed-off-by: Or Ozeri <oro(a)il.ibm.com> --- src/qemu/qemu_block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c index e865aa17f9..2aafb2fac7 100644 --- a/src/qemu/qemu_block.c +++ b/src/qemu/qemu_block.c @@ -1490,9 +1490,9 @@ qemuBlockStorageSourceAttachApply(qemuMonitor *mon, qemuBlockStorageSourceAttachData *data) { if (qemuBlockStorageSourceAttachApplyStorageDeps(mon, data) < 0 || + qemuBlockStorageSourceAttachApplyFormatDeps(mon, data) < 0 || qemuBlockStorageSourceAttachApplyStorage(mon, data) < 0 || qemuBlockStorageSourceAttachApplyStorageSlice(mon, data) < 0 || - qemuBlockStorageSourceAttachApplyFormatDeps(mon, data) < 0 || qemuBlockStorageSourceAttachApplyFormat(mon, data) < 0) return -1; -- 2.25.1

1 0

[libvirt PATCH] ci: integration: Set an expiration on logs artifacts
by Erik Skultety 12 Jan '23

12 Jan '23

The default expiry time is 30 days. Since the RPM artifacts coming from the previous pipeline stages are set to expire in 1 day we can set the failed integration job log artifacts to the same value. The sentiment here is that if an integration job legitimately failed (i.e. not with an infrastructure failure) unless it was fixed in the meantime it will fail the next day with the scheduled pipeline again, meaning, that even if the older log artifacts are removed, they'll be immediately replaced with fresh ones. Signed-off-by: Erik Skultety <eskultet(a)redhat.com> --- If you look at: - https://gitlab.com/libvirt/libvirt/-/jobs/3563902921 - https://gitlab.com/libvirt/libvirt/-/jobs/3557946738 you can clearly see that the artifacts are still taking up (although small) some GitLab storage space which is unnecessary since anyone interested in debugging would opt into getting the latest ones anyway. ci/integration-template.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/ci/integration-template.yml b/ci/integration-template.yml index 61cd034009..9141d5cedf 100644 --- a/ci/integration-template.yml +++ b/ci/integration-template.yml @@ -94,6 +94,7 @@ SCRATCH_DIR: "/tmp/scratch" artifacts: name: logs + expire_in: 1 day paths: - logs when: on_failure -- 2.39.0

2 1

[libvirt PATCH] NEWS: document external swtpm backend addition
by Ján Tomko 11 Jan '23

11 Jan '23

Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- NEWS.rst | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 768208ed03..8482c49b3c 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -33,6 +33,11 @@ v9.0.0 (unreleased) <backend type='passt'> ... + * QEMU: add external backend for swtpm + + Connecting the VM to a swtpm daemon started outside of libvirt + is now possible. + * **Improvements** * qemu: Prefer PNG for domain screenshots -- 2.39.0

2 1

[libvirt PATCH 0/2] Coverity inspired fixes for qemuPasstStart
by Jiri Denemark 11 Jan '23

11 Jan '23

Jiri Denemark (2): qemu: Don't check pidfile in qemuPasstStart qemu: Change some gotos in qemuPasstStart to direct return src/qemu/qemu_passt.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) -- 2.39.0

2 3

[libvirt PATCH] conf: Avoid NULL dereference in virDomainNetPortForwardFree
by Jiri Denemark 11 Jan '23

11 Jan '23

In our current code the function is not called with NULL argument, but we should follow our common practice and make it safe anyway. Reported by coverity: /src/conf/domain_conf.c: 2635 in virDomainNetPortForwardFree() 2629 { 2630 size_t i; 2631 2632 if (pf) 2633 g_free(pf->dev); 2634 >>> CID 404359: Null pointer dereferences (FORWARD_NULL) >>> Dereferencing null pointer "pf". 2635 for (i = 0; i < pf->nRanges; i++) 2636 g_free(pf->ranges[i]); 2637 2638 g_free(pf->ranges); 2639 g_free(pf); 2640 } Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/conf/domain_conf.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 598e23b005..e43dee1a60 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -2629,8 +2629,10 @@ virDomainNetPortForwardFree(virDomainNetPortForward *pf) { size_t i; - if (pf) - g_free(pf->dev); + if (!pf) + return; + + g_free(pf->dev); for (i = 0; i < pf->nRanges; i++) g_free(pf->ranges[i]); -- 2.39.0

2 1