June 2022 - Devel - libvirt List Archives

[libvirt PATCH] util: Fix error reporting in virProcessSetMaxMemLock
by Jiri Denemark 10 Jun '22

10 Jun '22

Commit v7.1.0-136-g6a6d6bb520 refactored virProcessSetMaxMemLock by moving its part into a new virProcessSetLimit, but lost "return -1" on error; Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/util/virprocess.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/util/virprocess.c b/src/util/virprocess.c index 5ed0b5d0db..013afd91b4 100644 --- a/src/util/virprocess.c +++ b/src/util/virprocess.c @@ -926,6 +926,7 @@ virProcessSetMaxMemLock(pid_t pid, unsigned long long bytes) _("cannot limit locked memory " "of process %lld to %llu"), (long long int)pid, bytes); + return -1; } VIR_DEBUG("Locked memory for process %lld limited to %llu bytes", -- 2.35.1

2 2

[libvirt PATCH 0/3] firmware: Small fixes and cleanups
by Andrea Bolognani 10 Jun '22

10 Jun '22

Andrea Bolognani (3): vmx: Declare support for firmware autoselection conf: Fix virDomainDefOSValidate() qemu: Simplify handling of virTristateBool values src/conf/domain_validate.c | 6 +++--- src/qemu/qemu_firmware.c | 38 ++++++++++++++++---------------------- src/vmx/vmx.c | 1 + 3 files changed, 20 insertions(+), 25 deletions(-) -- 2.35.3

2 4

[libvirt PATCH v2 0/7] ci: Drop Fedora 34, add Fedora 36
by Andrea Bolognani 09 Jun '22

09 Jun '22

Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/548848259 Only patches 1-5 should be pushed until the issues outlined in https://listman.redhat.com/archives/libvir-list/2022-May/231851.html have been addressed. Changes from [v1] * handle integration tests separately; * don't stop publishing RPMs from the Fedora 35 job [v1] https://listman.redhat.com/archives/libvir-list/2022-May/231838.html Andrea Bolognani (7): ci: Drop Fedora 34 ci: Refresh generated files ci: Add Fedora 36 ci: Move MinGW jobs to Fedora 36 ci: Don't mark any Fedora 36 job as optional ci: Add Fedora 36 to integration tests ci: Move upstream QEMU integration test to Fedora 36 ...ile => fedora-36-cross-mingw32.Dockerfile} | 2 +- ...ile => fedora-36-cross-mingw64.Dockerfile} | 2 +- ...ora-34.Dockerfile => fedora-36.Dockerfile} | 3 +- ci/gitlab.yml | 767 +----------------- ci/gitlab/build-templates.yml | 45 + ci/gitlab/builds.yml | 406 +++++++++ ci/gitlab/container-templates.yml | 52 ++ ci/gitlab/containers.yml | 325 ++++++++ ci/gitlab/sanity-checks.yml | 18 + ci/integration.yml | 24 +- ci/manifest.yml | 5 +- 11 files changed, 869 insertions(+), 780 deletions(-) rename ci/containers/{fedora-35-cross-mingw32.Dockerfile => fedora-36-cross-mingw32.Dockerfile} (98%) rename ci/containers/{fedora-35-cross-mingw64.Dockerfile => fedora-36-cross-mingw64.Dockerfile} (98%) rename ci/containers/{fedora-34.Dockerfile => fedora-36.Dockerfile} (97%) create mode 100644 ci/gitlab/build-templates.yml create mode 100644 ci/gitlab/builds.yml create mode 100644 ci/gitlab/container-templates.yml create mode 100644 ci/gitlab/containers.yml create mode 100644 ci/gitlab/sanity-checks.yml -- 2.35.3

2 17

[libvirt PATCH 0/2] ci: Fixes to enable upstream QEMU integration tests on Fedora 36
by Erik Skultety 09 Jun '22

09 Jun '22

- CVE-2022-24765 handling (>= git-2.35.2) - SELinux relabel the QEMU installation from source Successful pipeline: https://gitlab.com/eskultety/libvirt/-/pipelines/557712098 Erik Skultety (2): ci: integration: SELinux relabel the QEMU we installed from git ci: integration: Set 'safe.directory' when installing QEMU from git ci/integration-template.yml | 6 ++++++ 1 file changed, 6 insertions(+) -- 2.36.1

3 9

[Questions] non-shared disk migration: jobs abort and bandwidth
by Han Han 09 Jun '22

09 Jun '22

Hi developers, Recently, I am researching migration with non-share disk(flags VIR_MIGRATE_NON_SHARED_DISK and VIR_MIGRATE_NON_SHARED_INC). As we know, the non-shared disk migration could have block jobs to copy the disk image from the src host to the dst host. So here are my questions for non-shared disk migration: q1. For the API virDomainMigrate3 with the bandwidth param, could it set the bandwidth of block jobs? q2. For the API virDomainMigrateSetMaxSpeed, could it set the bandwidth of block jobs? q3. For the domain job abort API virDomainAbortJob, could it stop the block job of non-shared disk migration? q4. For the block job bandwidth API virDomainBlockJobSetSpeed, could it set the block job of non-shared disk migration? q5. For the block job abort API virDomainBlockJobAbort, could it stop the block job of non-shared disk migration? Then I got the test results of libvirt-8.4.0-1.el9.x86_64 qemu-kvm-7.0.0-4.el9.x86_64: q1: The bandwidth limit of virDomainMigrate3 is effective to the blockjob: ➜ ~ virsh migrate OVMF qemu+ssh://root@hhan-rhel9--1/system --live --p2p --tls --tls-destination hhan-rhel9--1 --copy-storage-all --disks-uri tcp://hhan-rhel9--1:49156 --bandwidth 2 ➜ ~ virsh blockjob OVMF vda Block Copy: [ 0 %] Bandwidth limit: 2097152 bytes/s (2.000 MiB/s) q2: The virDomainMigrateSetMaxSpeed doesn't change the the bandwidth of block jobs. ➜ ~ virsh migrate-setspeed OVMF 8 ➜ ~ virsh blockjob OVMF vda Block Copy: [ 9 %] Bandwidth limit: 2097152 bytes/s (2.000 MiB/s) q3: The virDomainAbortJob could stop a block job of non-shared disk migration ➜ ~ virsh migrate OVMF qemu+ssh://root@hhan-rhel9--1/system --live --p2p --tls --tls-destination hhan-rhel9--1 --copy-storage-all --disks-uri tcp://hhan-rhel9--1:49156 --bandwidth 2 Then start a virsh event on another terminal: ➜ ~ virsh event --loop --all Abort the domain job: ➜ ~ virsh domjobabort OVMF The error "error: operation aborted: migration out: canceled by client" appears at the terminal of "virsh migrate" The terminal of "virsh event" shows the block job has been failed: event 'block-job' for domain 'OVMF': Block Copy for /var/lib/libvirt/images/OVMF.qcow2 failed event 'block-job-2' for domain 'OVMF': Block Copy for vda failed q4: The block job bandwidth of non-shared disk migration cannot be set by virDomainBlockJobSetSpeed: ➜ ~ virsh blockjob OVMF vda --bandwidth 10 error: Timed out during operation: cannot acquire state change lock (held by monitor=remoteDispatchDomainMigratePerform3Params) q5: The block job of non-shared disk migration cannot be aborted by virDomainBlockJobAbort: ➜ ~ virsh blockjob OVMF vda --abort error: Timed out during operation: cannot acquire state change lock (held by monitor=remoteDispatchDomainMigratePerform3Params) Are the results above expected? Here are my personal thoughts: For the bandwidth in q1 and q2, they are commented as migration bandwidth( https://gitlab.com/libvirt/libvirt/-/blob/master/include/libvirt/libvirt-do… , https://gitlab.com/libvirt/libvirt/-/blob/master/src/libvirt-domain.c#L9696 ), but one works for block jobs while one doesn't. So we should make the comment clear whether they are the bandwidth of VM migration or the bandwidth of migration with blockjobs. What's more, add a flag to virDomainMigrateMaxSpeedFlags to support set bandwidth to the blockjobs in migration. For q4 and q5, if we will not support to change the block job of non-shared disk migration by blockjob APIs, we should note that in the migration doc or the block job doc, to present the difference between this type of block job and the others.

2 2

[PATCH v2 00/15] qemu: Allow setting EventLoopBaseProperties
by Michal Privoznik 08 Jun '22

08 Jun '22

v2 of: https://listman.redhat.com/archives/libvir-list/2022-June/232118.html diff to v1: - switched from <mainloop/> to <defaultiothread/> - switched from long long to int for pool sizes (this means that the 02/16 patch from the original series that introduced virXMLPropLongLong() is no longer needed and thus not in this series). - Extended some docs - Hopefully, I've worked in all Peter's review points. Michal Prívozník (15): virml: Introduce VIR_XML_PROP_NONNEGATIVE flag virDomainDefParseIOThreads: Use g_autoptr() for @iothrid virDomainIOThreadIDDefArrayInit: Decrease scope of @iothrid conf: Move iothread formatter into a separate function conf: Introduce allocator for virDomainIOThreadIDDef conf: Introduce pool_min and pool_max attributes to IOThread qemu: Introduce QEMU_CAPS_IOTHREAD_THREAD_POOL_MAX qemu_validate: Check if QEMU's capable of setting iothread pool size qemu: Generate command line for IOThread pool size include: Introduce typed params for virDomainSetIOThreadParams wrt pool size qemu: Wire up new virDomainSetIOThreadParams parameters virsh: Wire up new virDomainSetIOThreadParams parameters conf: Expose QEMU's main loop object qemu_validate: Check if QEMU's capable of setting main loop pool size qemu: Generate command line for main-loop pool size docs/formatdomain.rst | 14 +- docs/manpages/virsh.rst | 7 +- include/libvirt/libvirt-domain.h | 22 +++ src/conf/domain_conf.c | 162 +++++++++++++++--- src/conf/domain_conf.h | 11 ++ src/conf/schemas/domaincommon.rng | 25 +++ src/conf/virconftypes.h | 2 + src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 26 ++- src/qemu/qemu_driver.c | 62 ++++++- src/qemu/qemu_monitor.h | 4 + src/qemu/qemu_monitor_json.c | 2 + src/qemu/qemu_validate.c | 33 ++++ src/util/virxml.c | 7 + src/util/virxml.h | 3 + .../caps_7.1.0.x86_64.xml | 1 + ...othreads-ids-pool-sizes.x86_64-latest.args | 45 +++++ .../iothreads-ids-pool-sizes.xml | 62 +++++++ tests/qemuxml2argvtest.c | 1 + ...iothreads-ids-pool-sizes.x86_64-latest.xml | 1 + tests/qemuxml2xmltest.c | 1 + tools/virsh-domain.c | 24 ++- 23 files changed, 480 insertions(+), 38 deletions(-) create mode 100644 tests/qemuxml2argvdata/iothreads-ids-pool-sizes.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/iothreads-ids-pool-sizes.xml create mode 120000 tests/qemuxml2xmloutdata/iothreads-ids-pool-sizes.x86_64-latest.xml -- 2.35.1

3 27

[PATCH] virsh: Check whether enough arguments was passed to iothreadset
by Michal Privoznik 08 Jun '22

08 Jun '22

Virsh has iothreadset command which allows setting various attributes of IOThreads. However, when the command is called without any arguments (besides domain and IOThread IDs), then @params stays NULL and is passed to virDomainSetIOThreadParams() which produces rather user unfriendly error message: error: params in virDomainSetIOThreadParams must not be NULL Introduce a check and produce better error message. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- tools/virsh-domain.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 5c4a7d7b8d..cfdaac1942 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -7853,6 +7853,11 @@ cmdIOThreadSet(vshControl *ctl, const vshCmd *cmd) #undef VSH_IOTHREAD_SET_UINT_PARAMS + if (nparams == 0) { + vshError(ctl, _("Not enough arguments passed, nothing to set")); + goto cleanup; + } + if (virDomainSetIOThreadParams(dom, id, params, nparams, flags) < 0) goto cleanup; -- 2.35.1

4 3

[PATCH v2 00/30] Remove some unused includes
by Peng Liang 08 Jun '22

08 Jun '22

2 38

[libvirt PATCH] qemu: Improve error messages using qemuMigrationJobName
by Jiri Denemark 08 Jun '22

08 Jun '22

They were constructed from two separate strings using "%s: %s", which is ugly and does not work well with translations. Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/qemu/qemu_migration.c | 52 ++++++++++++++++++++++----------------- 1 file changed, 30 insertions(+), 22 deletions(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 341395ac6d..849c25b168 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -1847,24 +1847,23 @@ qemuMigrationJobName(virDomainObj *vm) switch (priv->job.asyncJob) { case VIR_ASYNC_JOB_MIGRATION_OUT: - return _("migration out job"); + return _("migration out"); case VIR_ASYNC_JOB_SAVE: - return _("domain save job"); + return _("domain save"); case VIR_ASYNC_JOB_DUMP: - return _("domain core dump job"); - case VIR_ASYNC_JOB_NONE: - return _("undefined"); + return _("domain core dump"); case VIR_ASYNC_JOB_MIGRATION_IN: - return _("migration in job"); + return _("migration in"); case VIR_ASYNC_JOB_SNAPSHOT: - return _("snapshot job"); + return _("snapshot"); case VIR_ASYNC_JOB_START: - return _("start job"); + return _("start"); case VIR_ASYNC_JOB_BACKUP: - return _("backup job"); + return _("backup"); + case VIR_ASYNC_JOB_NONE: case VIR_ASYNC_JOB_LAST: default: - return _("job"); + return _("undefined"); } } @@ -1888,25 +1887,33 @@ qemuMigrationJobCheckStatus(virQEMUDriver *driver, switch (jobData->status) { case VIR_DOMAIN_JOB_STATUS_NONE: - virReportError(VIR_ERR_OPERATION_FAILED, _("%s: %s"), - qemuMigrationJobName(vm), _("is not active")); + virReportError(VIR_ERR_OPERATION_FAILED, + _("job '%s' is not active"), + qemuMigrationJobName(vm)); return -1; case VIR_DOMAIN_JOB_STATUS_FAILED: - virReportError(VIR_ERR_OPERATION_FAILED, _("%s: %s"), - qemuMigrationJobName(vm), - error ? error : _("unexpectedly failed")); + if (error) { + virReportError(VIR_ERR_OPERATION_FAILED, + _("job '%s' failed: %s"), + qemuMigrationJobName(vm), error); + } else { + virReportError(VIR_ERR_OPERATION_FAILED, + _("job '%s' unexpectedly failed"), + qemuMigrationJobName(vm)); + } return -1; case VIR_DOMAIN_JOB_STATUS_CANCELED: - virReportError(VIR_ERR_OPERATION_ABORTED, _("%s: %s"), - qemuMigrationJobName(vm), _("canceled by client")); + virReportError(VIR_ERR_OPERATION_ABORTED, + _("job '%s' canceled by client"), + qemuMigrationJobName(vm)); return -1; case VIR_DOMAIN_JOB_STATUS_POSTCOPY_PAUSED: - virReportError(VIR_ERR_OPERATION_FAILED, _("%s: %s"), - qemuMigrationJobName(vm), - _("post-copy phase failed")); + virReportError(VIR_ERR_OPERATION_FAILED, + _("job '%s' failed in post-copy phase"), + qemuMigrationJobName(vm)); return -1; case VIR_DOMAIN_JOB_STATUS_COMPLETED: @@ -1959,8 +1966,9 @@ qemuMigrationAnyCompleted(virQEMUDriver *driver, if (flags & QEMU_MIGRATION_COMPLETED_ABORT_ON_ERROR && virDomainObjGetState(vm, &pauseReason) == VIR_DOMAIN_PAUSED && pauseReason == VIR_DOMAIN_PAUSED_IOERROR) { - virReportError(VIR_ERR_OPERATION_FAILED, _("%s: %s"), - qemuMigrationJobName(vm), _("failed due to I/O error")); + virReportError(VIR_ERR_OPERATION_FAILED, + _("job '%s' failed due to I/O error"), + qemuMigrationJobName(vm)); goto error; } -- 2.35.1

2 1

[PATCH 00/16] qemu: Allow setting EventLoopBaseProperties
by Michal Privoznik 07 Jun '22

07 Jun '22

QEMU introduced a way to set minimal and maximal number of worker threads for its worker thread pools. Currently, only IOThreads and main loop pools have this ability. Nevertheless, setting these boundaries (and basically making QEMU spawn enough threads upfront) is crucial for real-time workloads where having to spawn a thread may lead to missing the time limit. Michal Prívozník (16): virml: Introduce VIR_XML_PROP_NONNEGATIVE flag virxml: Introduce virXMLPropLongLong() virDomainDefParseIOThreads: Use g_autoptr() for @iothrid virDomainIOThreadIDDefArrayInit: Decrease scope of @iothrid conf: Move iothread formatter into a separate function conf: Introduce allocator for virDomainIOThreadIDDef conf: Introduce pool_min and pool_max attributes to IOThread qemu: Introduce QEMU_CAPS_IOTHREAD_THREAD_POOL_MAX qemu_validate: Check if QEMU's capable of setting iothread pool size qemu: Generate command line for IOThread pool size include: Introduce typed params for virDomainSetIOThreadParams wrt pool size qemu: Wire up new virDomainSetIOThreadParams parameters virsh: Wire up new virDomainSetIOThreadParams parameters conf: Expose QEMU's main loop object qemu_validate: Check if QEMU's capable of setting main loop pool size qemu: Generate command line for main-loop pool size docs/formatdomain.rst | 11 +- docs/manpages/virsh.rst | 7 +- include/libvirt/libvirt-domain.h | 18 ++ src/conf/domain_conf.c | 154 +++++++++++++++--- src/conf/domain_conf.h | 11 ++ src/conf/schemas/domaincommon.rng | 25 +++ src/conf/virconftypes.h | 2 + src/libvirt_private.syms | 1 + src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 48 +++++- src/qemu/qemu_driver.c | 63 ++++++- src/qemu/qemu_monitor.h | 4 + src/qemu/qemu_monitor_json.c | 2 + src/qemu/qemu_validate.c | 44 +++++ src/util/virxml.c | 69 ++++++++ src/util/virxml.h | 12 ++ .../caps_7.1.0.x86_64.xml | 1 + ...othreads-ids-pool-sizes.x86_64-latest.args | 45 +++++ .../iothreads-ids-pool-sizes.xml | 62 +++++++ tests/qemuxml2argvtest.c | 1 + ...iothreads-ids-pool-sizes.x86_64-latest.xml | 1 + tests/qemuxml2xmltest.c | 1 + tools/virsh-domain.c | 24 ++- 24 files changed, 575 insertions(+), 34 deletions(-) create mode 100644 tests/qemuxml2argvdata/iothreads-ids-pool-sizes.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/iothreads-ids-pool-sizes.xml create mode 120000 tests/qemuxml2xmloutdata/iothreads-ids-pool-sizes.x86_64-latest.xml -- 2.35.1

4 37