April 2022 - Devel - libvirt List Archives

[libvirt PATCH 0/7] qemu: Retire two ppc64-specific capabilities
by Andrea Bolognani 19 Apr '22

19 Apr '22

All QEMU versions we support have the corresponding features. Andrea Bolognani (7): tests: Drop pseries-machine-max-cpu-compat qemu: Assume QEMU_CAPS_MACHINE_PSERIES_MAX_CPU_COMPAT qemu: Stop setting QEMU_CAPS_MACHINE_PSERIES_MAX_CPU_COMPAT qemu: Retire QEMU_CAPS_MACHINE_PSERIES_MAX_CPU_COMPAT qemu: Assume QEMU_CAPS_MACHINE_PSERIES_RESIZE_HPT qemu: Stop setting QEMU_CAPS_MACHINE_PSERIES_RESIZE_HPT qemu: Retire QEMU_CAPS_MACHINE_PSERIES_RESIZE_HPT src/qemu/qemu_capabilities.c | 12 +++----- src/qemu/qemu_capabilities.h | 4 +-- src/qemu/qemu_command.c | 8 +---- src/qemu/qemu_validate.c | 8 ----- .../qemucapabilitiesdata/caps_3.1.0.ppc64.xml | 2 -- .../qemucapabilitiesdata/caps_4.0.0.ppc64.xml | 2 -- .../qemucapabilitiesdata/caps_4.2.0.ppc64.xml | 2 -- .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 2 -- .../qemucapabilitiesdata/caps_5.2.0.ppc64.xml | 2 -- .../qemucapabilitiesdata/caps_6.2.0.ppc64.xml | 2 -- .../qemucapabilitiesdata/caps_7.0.0.ppc64.xml | 2 -- .../pseries-machine-max-cpu-compat.args | 29 ------------------- .../pseries-machine-max-cpu-compat.xml | 17 ----------- tests/qemuxml2argvtest.c | 22 ++++---------- tests/qemuxml2xmltest.c | 1 - 15 files changed, 12 insertions(+), 103 deletions(-) delete mode 100644 tests/qemuxml2argvdata/pseries-machine-max-cpu-compat.args delete mode 100644 tests/qemuxml2argvdata/pseries-machine-max-cpu-compat.xml -- 2.35.1

2 8

[libvirt PATCH] qemu: Shorten domain name in virtiofsd log path
by Martin Kletzander 19 Apr '22

19 Apr '22

This helps when starting domains with long names which could possibly end up creating too long of a name for the filesystem. The path is not being saved in the domain config, so there is no need for backwards compatibility. User aliases will always start with "ua-" and the only way paths could collide is to: 1) create a domain named e.g. "asdf-ua" 2) start the domain with virtiofsd debug logs 3) destroy the domain 4) restart libvirt daemon for domain IDs to start from 1 again 5) create a domain named "asdf" 6) add user alias for the virtiofs that is the same as was generated for the first domain, with the required "ua-" prefix 7) start the "asdf" domain at which point the logs for the two domains would end up in the same logfile. Since this is still better than what we had before I think it is not worth fixing this peculiar scenario in this patch. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1817401 Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- src/qemu/qemu_virtiofs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_virtiofs.c b/src/qemu/qemu_virtiofs.c index 7e3324b017ce..67df8b3890b6 100644 --- a/src/qemu/qemu_virtiofs.c +++ b/src/qemu/qemu_virtiofs.c @@ -81,8 +81,9 @@ qemuVirtioFSCreateLogFilename(virQEMUDriverConfig *cfg, const char *alias) { g_autofree char *name = NULL; + g_autofree char *shortname = virDomainDefGetShortName(def); - name = g_strdup_printf("%s-%s", def->name, alias); + name = g_strdup_printf("%s-%s", shortname, alias); return virFileBuildPath(cfg->logDir, name, "-virtiofsd.log"); } -- 2.35.1

3 3

what is virtunixd ? Is there such a daemon?
by Claudio Fontana 19 Apr '22

19 Apr '22

Hello, as I experiment with virsh migration commands (and probably I do things that don't make sense), I got an error I could not understand: # virsh migrate centos7 unix:///tmp/netcat.sock error: Failed to connect socket to '/var/run/libvirt/virtunixd-sock': No such file or directory What is "/var/run/libvirt/virtunixd-sock" ? Should I have a "virtunixd" process running? I am building with non-modularized libvirtd currently, but I could not find a virtunixd module either... Thanks, Claudio

3 3

[PATCH] qemu: Fetch info on NVDIMM-s too when updating memory devices
by Michal Privoznik 19 Apr '22

19 Apr '22

Sometimes it may come handy to learn what address is a NVDIMM mapped to inside a guest. While users can provide an address they want to have NVDIMM mapped to, it's optional. Fortunately, when a domain is being started we issue the 'query-memory-devices' monitor command and the reply is the same for 'dimm' and 'nvdimm' types. Therefore, updating NVDIMM address is trivial. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/qemu/qemu_monitor_json.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index d5622bd6d9..68ee322ad9 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -7484,7 +7484,7 @@ qemuMonitorJSONGetMemoryDeviceInfo(qemuMonitor *mon, meminfo = g_new0(qemuMonitorMemoryDeviceInfo, 1); /* dimm memory devices */ - if (STREQ(type, "dimm")) { + if (STREQ(type, "dimm") || STREQ(type, "nvdimm") ) { if (virJSONValueObjectGetNumberUlong(dimminfo, "addr", &meminfo->address) < 0) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", -- 2.35.1

2 1

[libvirt PATCH] util: Fix stubs for virProcessGet{Stat,Sched}Info()
by Andrea Bolognani 19 Apr '22

19 Apr '22

Commit d73852c49962 moved the original QEMU-specific helpers to the utils module, which resulted in build failures on non-Unix platforms due to the unconditional use of Unix-only symbols such as _SC_CLK_TCK. To deal with that situation, commit d7c64453aa0e made the helpers Linux-only and added stubs for other platforms that, when called, would always fail with ENOSYS. However the original helpers had been carefully written so that, while they would only be able to produce useful output on Linux, they would still succeed on the other Unix platforms where we build the QEMU driver. Restore the original behavior so that calling APIs such as virDomainGetInfo() can once again work on FreeBSD and macOS. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/298 Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/517776953 src/util/virprocess.c | 29 ++++++++++++++++++++--------- 1 file changed, 20 insertions(+), 9 deletions(-) diff --git a/src/util/virprocess.c b/src/util/virprocess.c index b559a4257e..36d7df050a 100644 --- a/src/util/virprocess.c +++ b/src/util/virprocess.c @@ -1875,23 +1875,34 @@ virProcessGetSchedInfo(unsigned long long *cpuWait, #else int -virProcessGetStatInfo(unsigned long long *cpuTime G_GNUC_UNUSED, - int *lastCpu G_GNUC_UNUSED, - long *vm_rss G_GNUC_UNUSED, +virProcessGetStatInfo(unsigned long long *cpuTime, + int *lastCpu, + long *vm_rss, pid_t pid G_GNUC_UNUSED, pid_t tid G_GNUC_UNUSED) { - errno = ENOSYS; - return -1; + /* We don't have a way to collect this information on non-Linux + * platforms, so just report neutral values */ + if (cpuTime) + *cpuTime = 0; + if (lastCpu) + *lastCpu = 0; + if (vm_rss) + *vm_rss = 0; + + return 0; } int -virProcessGetSchedInfo(unsigned long long *cpuWait G_GNUC_UNUSED, +virProcessGetSchedInfo(unsigned long long *cpuWait, pid_t pid G_GNUC_UNUSED, pid_t tid G_GNUC_UNUSED) { - virReportSystemError(ENOSYS, "%s", - _("scheduler information is not supported on this platform")); - return -1; + /* We don't have a way to collect this information on non-Linux + * platforms, so just report neutral values */ + if (cpuWait) + *cpuWait = 0; + + return 0; } #endif /* __linux__ */ -- 2.35.1

2 1

[PATCH 00/14] docs: Convert some pages to rST and clean up (part 5)
by Peter Krempa 14 Apr '22

14 Apr '22

This series corrects some mistakes from previous conversions (local anchor links, ordering of input files) and finishes the conversion of format* documents. Pavel Hrdina (1): docs: Convert 'formatnwfilter' page to rst Peter Krempa (13): docs: meson: Sort list of RST files to build docs: api: Fix local anchor links docs: drivers: Fix local anchor links docs: drvbhve: Fix local anchor links docs: drvesx: Fix local anchor links docs: drvnodedev: Fix local anchor links docs: drvsecret: Fix local anchor links docs: kbase/launch_security_sev: Fix local anchor links docs: kbase/tlscerts: Fix local anchor links docs: pci-hotplug: Fix local anchor links docs: Convert 'formatcaps' page to rst docs: Convert 'formatnetwork' page to rst docs: Convert 'formatnode' page to rst docs/api.rst | 5 +- docs/drivers.rst | 2 +- docs/drvbhyve.rst | 6 +- docs/drvesx.rst | 19 +- docs/drvnodedev.rst | 20 +- docs/firewall.rst | 2 +- docs/formatcaps.html.in | 222 --- docs/formatcaps.rst | 197 +++ docs/formatdomain.rst | 7 +- docs/formatnetwork.html.in | 1479 ----------------- docs/formatnetwork.rst | 1144 +++++++++++++ docs/formatnetworkport.rst | 2 +- docs/formatnode.html.in | 657 -------- docs/formatnode.rst | 556 +++++++ docs/formatnwfilter.html.in | 2471 ---------------------------- docs/formatnwfilter.rst | 1789 ++++++++++++++++++++ docs/formatsecret.rst | 16 +- docs/kbase/launch_security_sev.rst | 2 +- docs/kbase/tlscerts.rst | 7 +- docs/manpages/virsh.rst | 5 +- docs/meson.build | 12 +- docs/pci-hotplug.rst | 5 +- 22 files changed, 3742 insertions(+), 4883 deletions(-) delete mode 100644 docs/formatcaps.html.in create mode 100644 docs/formatcaps.rst delete mode 100644 docs/formatnetwork.html.in create mode 100644 docs/formatnetwork.rst delete mode 100644 docs/formatnode.html.in create mode 100644 docs/formatnode.rst delete mode 100644 docs/formatnwfilter.html.in create mode 100644 docs/formatnwfilter.rst -- 2.35.1

2 16

[libvirt PATCH 00/10] Automatic mutex management - part 6
by Tim Wiederhake 14 Apr '22

14 Apr '22

Use the recently implemented VIR_LOCK_GUARD and VIR_WITH_MUTEX_LOCK_GUARD to simplify mutex management. Tim Wiederhake (10): virstorageobj: Replace deprecated virHash functions virStoragePoolObjAddVol: Simplify error path virStorageVolObjEndAPI: Remove virStorageVolObjNew: Move locking to usage site virstorageobject: Use automatic mutex management virNetServerProcessClients: Remove goto virnetserver: Use automatic mutex management virnetserverclient: Use automatic mutex management security_manager: Use automatic mutex management vz_driver: Use automatic mutex management src/conf/virstorageobj.c | 185 +++++------ src/rpc/virnetserver.c | 295 +++++++----------- src/rpc/virnetserverclient.c | 432 ++++++++++++-------------- src/security/security_manager.c | 524 +++++++++++++------------------- src/vz/vz_driver.c | 50 ++- 5 files changed, 604 insertions(+), 882 deletions(-) -- 2.31.1

2 11

[libvirt PATCH 0/6] ci: Update targets
by Andrea Bolognani 14 Apr '22

14 Apr '22

Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/516876671 Andrea Bolognani (6): ci: Drop FreeBSD -CURRENT ci: Simplify Alpine Linux 3.14 definition ci: Add Alpine Linux 3.15 ci: Add openSUSE Leap 15.3 ci: Move codestyle job to openSUSE Leap 15.3 ci: Drop openSUSE Leap 15.2 .gitlab-ci.yml | 4 +- ci/cirrus/freebsd-current.vars | 16 ---- ci/containers/alpine-315.Dockerfile | 80 +++++++++++++++++++ ...ockerfile => opensuse-leap-153.Dockerfile} | 2 +- ci/gitlab.yml | 26 ++++-- ci/manifest.yml | 14 +--- 6 files changed, 108 insertions(+), 34 deletions(-) delete mode 100644 ci/cirrus/freebsd-current.vars create mode 100644 ci/containers/alpine-315.Dockerfile rename ci/containers/{opensuse-leap-152.Dockerfile => opensuse-leap-153.Dockerfile} (98%) -- 2.35.1

2 8

[libvirt PATCH 0/1] ci: integration: Expose list of installed packages on failure
by Erik Skultety 14 Apr '22

14 Apr '22

Erik Skultety (1): ci: integration: Expose installed packages on failure ci/integration.yml | 1 + 1 file changed, 1 insertion(+) -- 2.34.1

2 2

[PATCH] docs: Fix spelling for Homebrew
by Andrea Bolognani 14 Apr '22

14 Apr '22

Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed as trivial. docs/platforms.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/platforms.rst b/docs/platforms.rst index 90f14b02e8..2e7e35e1c4 100644 --- a/docs/platforms.rst +++ b/docs/platforms.rst @@ -52,7 +52,7 @@ the project will look at CentOS, Debian, Fedora, openSUSE, RHEL, SLES and Ubuntu LTS. Other distros will be assumed to ship similar software versions. For FreeBSD, decisions will be made based on the contents of the ports tree; -for macOS, `HomeBrew`_ will be used, although `MacPorts`_ is expected to carry +for macOS, `Homebrew`_ will be used, although `MacPorts`_ is expected to carry similar versions. Windows @@ -78,7 +78,7 @@ If a hypervisor is not commonly shipped directly by any distro listed above, or until the vendor discontinues support, whichever comes first. -.. _HomeBrew: https://brew.sh/ +.. _Homebrew: https://brew.sh/ .. _MacPorts: https://www.macports.org/ .. _Repology: https://repology.org/ .. _hypervisor drivers: drivers.html -- 2.35.1

1 0