[libvirt PATCH 0/9] ch: use g_auto where possible
by Ján Tomko
While cleaning up the tests, I noticed that the 'ch' driver is
not using g_auto up to its full potential.
Use automatic cleanup where possible and remove redundant labels.
Ján Tomko (9):
ch: use g_auto in virCHMonitorBuildCPUJson
ch: use g_auto in virCHMonitorBuildKernelRelatedJson
ch: use g_auto in virCHMonitorBuildMemoryJson
ch: use g_auto in virCHMonitorBuildDiskJson
ch: use g_auto in virCHMonitorBuildDisksJson
ch: use g_auto in virCHMonitorBuildNetJson
ch: use g_auto in virCHMonitorBuildNetsJson
ch: use g_auto in virCHMonitorBuildVMJson
ch: use g_auto in virCHMonitorNew
src/ch/ch_monitor.c | 167 +++++++++++++++++---------------------------
1 file changed, 63 insertions(+), 104 deletions(-)
--
2.31.1
3 years, 2 months
- 3
- 14
[libvirt PATCH v4 0/4] Add a PCI/PCIe device VPD Capability
by Dmitrii Shcherbakov
Add support for deserializing the binary PCI/PCIe VPD format and
exposing VPD resources as XML elements in a new nested capability
of PCI/PCIe devices called 'vpd'.
The series contains the following incremental changes:
* The PCI VPD parser module, in-memory resource representation
and tests;
* VPD-related helpers added to the virpci module;
* VPD capability support: XML serialization/deserialization from/into
VPD resource data structures;
* Documentation.
The VPD format is specified in "I.3. VPD Definitions" in PCI specs
(2.2+) and "6.28.1 VPD Format" PCIe 4.0. As section 6.28 in PCIe 4.0
notes, the PCI Local Bus and PCIe VPD formats are binary compatible
and PCIe 4.0 merely started incorporating what was already present in
PCI specs.
Linux kernel exposes a binary blob in the VPD format via sysfs since
v2.6.26 (commit 94e6108803469a37ee1e3c92dafdd1d59298602f) which requires
a parser to interpret.
There are usage scenarios where information such as the board serial
number needs to be retrieved from PCI(e) VPD. Projects like Nova can
utilize this information for cases which involve virtual interface
plugging on SmartNIC DPUs but there may be other scenarios and types of
information useful to retrieve from VPD. The fact that the format is
binary requires proper parsing instead of substring searching hence the
full parser is proposed. Likewise, checksum validation requires proper
parsing as well.
A usage example is present here:
https://review.opendev.org/c/openstack/nova/+/808199
The patch follows a prior discussion on the mailing list which has
additional context about the use-case but a narrower proposal:
https://listman.redhat.com/archives/libvir-list/2021-May/msg00873.html
https://www.mail-archive.com/libvir-list@redhat.com/msg218165.html
The new functionality is mostly contained in virpcivpd with a
couple of new functions added to virpci. Additionally, the necessary XML
serialization/deserialization and glue code is added to expose the VPD
capability to external clients as XML.
A new capability flag is added along with a new capability in order to
allow for filtering of PCI devices with the VPD capability using virsh:
virsh nodedev-list --cap vpd
sudo virsh nodedev-dumpxml --device pci_dddd_bb_ss_f
In this example having the root uid is required in order to access the
vpd sysfs entry, therefore, the nodedev XML output will only contain
the VPD capability if virsh is run as root.
The capability is treated as dynamic due to the presence of read-write
sections in the VPD format per PCI/PCIe specs (the idea being that
read-write resource fields may potentially be altered by the DPU OS
over time independently from the host OS).
Unit tests cover the parser functionality (including many possible
invalid cases), in-memory representation as well as XML serialization
and deserialization.
Manual functional testing was performed with 2 DPUs and several other
NIC models which expose PCI(e) VPD. Testing have also been performed
for devices that do not have VPD or those that expose a VPD capability
but exhibit invalid behavior (I/O errors while reading a sysfs entry).
Per the existing guidelines, the implementation relies heavily on glib
for various purposes.
https://libvirt.org/glib-adoption.html
The v4 of the patch includes a number of fixes compared to v3:
* Fixed the patch to correctly build against older glib (2.56.0);
* Notably, glib commit 86c073dba9d82ef3f1bc3d3116b058b9b5c3b1eb (in
2.59.0) fixes g_autolist support for derivable Glib types. To make
things work in 2.56.0 a workaround is conditionally applied;
* virCreateAnonymousFile now uses a temporary file which is
unlinked after creation instead of memfd because OpenSUSE 15.2 does
not have support memfd;
* Keyword resources now use GTree instead of GHashTable as the
underlying data structure:
* This allows for stable ordering which is important for XML2XML tests
as they were failing with when GLib versions were different,
resulting in a different ordering of elements;
* The keyword resource iteration function was complex and got replaced
by a simpler g_tree_foreach-based approach;
* Added more testing: functions added to virpci are now assessed by
creating a mocked vpd file under a mocked sysfs structure while the
parser is still tested in virpcivpdtest file;
* Refactoring:
* Applied changes based on the indent tool operation with some
post-processing;
* Renamed functions which had the Glib naming style to use camel case
where possible. Auto-generated declarations are an exception:
gobject/gtype.h defines type_name##_init, type_name##_class_init,
module_obj_name##_get_type functions which were left unchanged;
* camelCase is now used for local variables and function parameters;
* Replaced //-style comments with multi-line ones;
* Split out one patch into 4 based on distinct features:
* PCI VPD parser functionality and the respective in-memory types;
* VPD helpers in virpci;
* XML serialization/deserialization and VPD capability support;
* Documentation.
Build & test results for targets in ci/manifest.yaml:
ci/helper test --meson-args='-Dexpensive_tests=enabled' <target>
* First Patch:
https://gist.github.com/dshcherb/8388165df0b62b71c2c95fbc351d1aee
* Patches 1 and 2:
https://gist.github.com/dshcherb/33c3f0f6e717788aea24b5dae2210f38
* Patches 1, 2 and 3:
https://gist.github.com/dshcherb/400bcb13d01fd28030f4986e3e178262
* All patches:
https://gist.github.com/dshcherb/b2fc8bd3a349f6357a25da85c542dda3
Dmitrii Shcherbakov (4):
Add a PCI/PCIe device VPD Parser
Add PCI VPD-related helper functions to virpci
Add PCI VPD Capability Support
Add PCI VPD Capability Documentation
build-aux/syntax-check.mk | 4 +-
docs/drvnodedev.html.in | 46 ++
docs/formatnode.html.in | 24 +-
docs/schemas/nodedev.rng | 40 +
include/libvirt/libvirt-nodedev.h | 1 +
po/POTFILES.in | 1 +
src/conf/node_device_conf.c | 271 +++++++
src/conf/node_device_conf.h | 6 +-
src/conf/virnodedeviceobj.c | 7 +-
src/libvirt_private.syms | 17 +
src/node_device/node_device_driver.c | 2 +
src/node_device/node_device_udev.c | 2 +
src/util/meson.build | 1 +
src/util/virpci.c | 62 ++
src/util/virpci.h | 3 +
src/util/virpcivpd.c | 755 ++++++++++++++++++
src/util/virpcivpd.h | 117 +++
src/util/virpcivpdpriv.h | 45 ++
tests/meson.build | 1 +
.../pci_0000_42_00_0_vpd.xml | 33 +
.../pci_0000_42_00_0_vpd.xml | 1 +
tests/nodedevxml2xmltest.c | 1 +
tests/testutils.c | 40 +
tests/testutils.h | 4 +
tests/virpcimock.c | 30 +
tests/virpcitest.c | 64 ++
tests/virpcivpdtest.c | 704 ++++++++++++++++
tools/virsh-nodedev.c | 3 +
28 files changed, 2280 insertions(+), 5 deletions(-)
create mode 100644 src/util/virpcivpd.c
create mode 100644 src/util/virpcivpd.h
create mode 100644 src/util/virpcivpdpriv.h
create mode 100644 tests/nodedevschemadata/pci_0000_42_00_0_vpd.xml
create mode 120000 tests/nodedevxml2xmlout/pci_0000_42_00_0_vpd.xml
create mode 100644 tests/virpcivpdtest.c
--
2.30.2
3 years, 2 months
- 1
- 5
[RFC PATCH 0/1] qemuxml2argvtest: Add DO_TEST_CAPS_LATEST cases for every input file
by Peter Krempa
Our QEMU commandline generation testsuite has still quite a few test
cases based on fake capabilities. This might be okay in many cases but
comparably doesn't scale with any real use case.
I propose we add a DO_TEST_CAPS_LATEST case for every test case we have
(currently this patch does it only for DO_TEST_NOCAPS as example). In
this instance since we are keeping the old test too we can approach it
IMO by just trusting that they are okay.
The DO_TEST_NOCAPS were simple enough for now, but DO_TEST caused few
more problems, thus I'm keeping this open for discussion or potentially
somebody stepping up and fixing another set of test cases as I've did
with 'disk'-related cases.
Peter Krempa (1):
qemuxml2argvtest: Add 'latest' test case for each DO_TEST_NOCAPS case
3 years, 2 months
- 1
- 1
[PATCH 00/20] qemuxml2argvtest: Cleanup and modernize disk-related (and other) tests
by Peter Krempa
This series cleans up disk related tests and ensures that all use real
capabilities.
This is preparation for an upcoming RFC patch adding real caps test for
everything.
Peter Krempa (20):
testCompareXMLToArgv: Avoid use of uninitialized 'monitor_chr'
testQemuInfoInitArgs: Report error if path to 'latest' caps for an
arch is NULL
qemuxml2argvtest: Remove 'boot-strict' case
qemuxml2argvtest: Agregate all 'disk'-related test cases
qemuxml2argvtest: Remove fake caps versions of disk tests we have a
versioned test for
qemuxml2argvtest: Remove negative case for 'luks-disks-source-qcow2'
qemuxml2argvtest: Remove 'disk-usb-nosupport' case
qemuxml2argvtest: Convert encrypted disk test cases to
DO_TEST_CAPS_LATEST
qemuxml2argvtest: Use DO_TEST_CAPS_LATEST_PARSE_ERROR for disk cases
qemuxml2argvtest: Use real caps for all disk frontend property tests
qemuxml2argvtest: Replace 'disk-network-iscsi' by the more
comprehensive 'disk-network-iscsi-modern'
qemuxml2argvtest: Merge 'disk-iscsi' case into 'disk-cache'
qemuxml2argvtest: Modernize 'disk-network-rbd-no-colon' case
qemuxml2argvtest: Modernize outstanding disk-backend related tests
qemuxml2argvtest: Modernize 'disk-floppy-pseries' case
qemuxml2argvtest: Modernize s390x disk tests
tests: qemu: Remove 'virtio-ccw' machine type from fake capabilities
qemuxml2argvtest: Use versioned ("4.1.0") capabilities for pre
'-audiodev' cases
qemuxml2argvtest: Pin old-style '-no-reboot' usage to qemu-5.2
qemuxml2argvtest: remove 'fs9p' cases with fake capabilities.
.../qemuhotplug-base-ccw-live+ccw-virtio.xml | 2 +-
...ith-2-ccw-virtio+ccw-virtio-1-explicit.xml | 2 +-
...with-2-ccw-virtio+ccw-virtio-1-reverse.xml | 2 +-
...otplug-base-ccw-live-with-2-ccw-virtio.xml | 2 +-
...-with-ccw-virtio+ccw-virtio-2-explicit.xml | 2 +-
...-ccw-live-with-ccw-virtio+ccw-virtio-2.xml | 2 +-
...uhotplug-base-ccw-live-with-ccw-virtio.xml | 2 +-
.../qemuhotplug-base-ccw-live.xml | 2 +-
...args => audio-alsa-best.x86_64-4.1.0.args} | 9 +-
...l.err => audio-alsa-full.x86_64-4.1.0.err} | 0
...s => audio-alsa-minimal.x86_64-4.1.0.args} | 9 +-
...=> audio-coreaudio-best.x86_64-4.1.0.args} | 9 +-
... => audio-coreaudio-full.x86_64-4.1.0.err} | 0
...audio-coreaudio-minimal.x86_64-4.1.0.args} | 9 +-
...udio-default-nographics.x86_64-4.1.0.args} | 9 +-
...args => audio-file-best.x86_64-4.1.0.args} | 9 +-
...l.err => audio-file-full.x86_64-4.1.0.err} | 0
...s => audio-file-minimal.x86_64-4.1.0.args} | 9 +-
...l.err => audio-jack-full.x86_64-4.1.0.err} | 0
...rr => audio-jack-minimal.x86_64-4.1.0.err} | 0
...r => audio-many-backends.x86_64-4.1.0.err} | 0
...args => audio-none-best.x86_64-4.1.0.args} | 9 +-
...l.err => audio-none-full.x86_64-4.1.0.err} | 0
...s => audio-none-minimal.x86_64-4.1.0.args} | 9 +-
....args => audio-oss-best.x86_64-4.1.0.args} | 9 +-
...ll.err => audio-oss-full.x86_64-4.1.0.err} | 0
...gs => audio-oss-minimal.x86_64-4.1.0.args} | 9 +-
...> audio-pulseaudio-best.x86_64-4.1.0.args} | 9 +-
...=> audio-pulseaudio-full.x86_64-4.1.0.err} | 0
...udio-pulseaudio-minimal.x86_64-4.1.0.args} | 9 +-
....args => audio-sdl-best.x86_64-4.1.0.args} | 9 +-
...ll.err => audio-sdl-full.x86_64-4.1.0.err} | 0
...gs => audio-sdl-minimal.x86_64-4.1.0.args} | 9 +-
...rgs => audio-spice-best.x86_64-4.1.0.args} | 9 +-
....err => audio-spice-full.x86_64-4.1.0.err} | 0
... => audio-spice-minimal.x86_64-4.1.0.args} | 9 +-
.../qemuxml2argvdata/balloon-ccw-deflate.args | 2 +-
.../qemuxml2argvdata/balloon-ccw-deflate.xml | 2 +-
tests/qemuxml2argvdata/boot-strict.args | 48 ----
tests/qemuxml2argvdata/boot-strict.xml | 66 -----
.../qemuxml2argvdata/console-virtio-ccw.args | 2 +-
tests/qemuxml2argvdata/console-virtio-ccw.xml | 2 +-
...> disk-address-conflict.x86_64-latest.err} | 0
tests/qemuxml2argvdata/disk-aio.args | 34 ---
tests/qemuxml2argvdata/disk-blockio.args | 34 ---
.../disk-blockio.x86_64-latest.args | 39 +++
tests/qemuxml2argvdata/disk-boot-cdrom.args | 33 ---
.../disk-boot-cdrom.x86_64-latest.args | 38 +++
tests/qemuxml2argvdata/disk-boot-disk.args | 33 ---
.../disk-boot-disk.x86_64-latest.args | 38 +++
.../disk-cache.x86_64-2.12.0.args | 2 +-
.../disk-cache.x86_64-latest.args | 2 +-
tests/qemuxml2argvdata/disk-cache.xml | 2 +-
.../qemuxml2argvdata/disk-cdrom-network.args | 35 ---
tests/qemuxml2argvdata/disk-cdrom-tray.args | 36 ---
tests/qemuxml2argvdata/disk-cdrom.args | 37 ---
tests/qemuxml2argvdata/disk-copy_on_read.args | 37 ---
...device-lun-type-invalid.x86_64-latest.err} | 0
tests/qemuxml2argvdata/disk-error-policy.args | 35 ---
...dc-incompatible-address.x86_64-latest.err} | 0
...r => disk-floppy-pseries.ppc64-latest.err} | 0
tests/qemuxml2argvdata/disk-floppy-tray.args | 36 ---
.../disk-floppy-tray.x86_64-latest.args | 42 +++
tests/qemuxml2argvdata/disk-floppy.args | 35 ---
...cow.err => disk-fmt-cow.x86_64-latest.err} | 0
...dir.err => disk-fmt-dir.x86_64-latest.err} | 0
...iso.err => disk-fmt-iso.x86_64-latest.err} | 0
...w.args => disk-fmt-qcow.x86_64-4.1.0.args} | 9 +-
.../disk-fmt-qcow.x86_64-latest.args | 38 +++
tests/qemuxml2argvdata/disk-geometry.args | 32 ---
.../disk-geometry.x86_64-latest.args | 36 +++
...v-scsi-address-conflict.x86_64-latest.err} | 0
...de-incompatible-address.x86_64-latest.err} | 0
tests/qemuxml2argvdata/disk-ide-split.args | 34 ---
.../disk-ide-split.x86_64-latest.args | 39 +++
tests/qemuxml2argvdata/disk-ide-wwn.args | 32 ---
.../disk-ide-wwn.x86_64-latest.args | 36 +++
tests/qemuxml2argvdata/disk-ioeventfd.args | 37 ---
.../disk-ioeventfd.x86_64-latest.args | 42 +++
tests/qemuxml2argvdata/disk-iscsi.args | 31 ---
tests/qemuxml2argvdata/disk-iscsi.xml | 28 --
...-missing-target-invalid.x86_64-latest.err} | 0
.../disk-network-gluster.args | 35 ---
...auth-secrettype-invalid.x86_64-latest.err} | 0
...i-auth-wrong-secrettype.x86_64-latest.err} | 0
.../disk-network-iscsi-modern.args | 47 ----
.../disk-network-iscsi-modern.xml | 88 ------
.../qemuxml2argvdata/disk-network-iscsi.args | 42 ---
.../disk-network-iscsi.x86_64-2.12.0.args | 5 +
.../disk-network-iscsi.x86_64-latest.args | 31 ++-
tests/qemuxml2argvdata/disk-network-iscsi.xml | 25 +-
tests/qemuxml2argvdata/disk-network-nbd.args | 39 ---
...isk-network-rbd-no-colon.x86_64-4.1.0.err} | 0
...sk-network-rbd-no-colon.x86_64-latest.args | 39 +++
.../disk-network-sheepdog.args | 33 ---
...etwork-source-auth-both.x86_64-latest.err} | 0
.../disk-network-source-auth.args | 38 ---
tests/qemuxml2argvdata/disk-network-vxhs.args | 32 ---
tests/qemuxml2argvdata/disk-no-boot.args | 36 ---
.../disk-no-boot.x86_64-latest.args | 42 +++
tests/qemuxml2argvdata/disk-order.args | 38 ---
.../disk-order.x86_64-latest.args | 45 +++
.../qemuxml2argvdata/disk-readonly-disk.args | 34 ---
...rr => disk-same-targets.x86_64-latest.err} | 0
tests/qemuxml2argvdata/disk-sata-device.args | 33 ---
.../disk-sata-device.x86_64-latest.args | 37 +++
...ta-incompatible-address.x86_64-latest.err} | 0
.../disk-scsi-disk-split.args | 42 ---
.../disk-scsi-disk-split.x86_64-latest.args | 49 ++++
...si-disk-vpd-build-error.x86_64-latest.err} | 0
.../qemuxml2argvdata/disk-scsi-disk-vpd.args | 36 ---
.../disk-scsi-disk-vpd.x86_64-latest.args | 41 +++
.../qemuxml2argvdata/disk-scsi-disk-wwn.args | 36 ---
.../disk-scsi-disk-wwn.x86_64-latest.args | 41 +++
...si-incompatible-address.x86_64-latest.err} | 0
.../disk-scsi-lun-passthrough.args | 36 ---
...sk-scsi-lun-passthrough.x86_64-latest.args | 41 +++
tests/qemuxml2argvdata/disk-serial.args | 35 ---
.../disk-serial.x86_64-latest.args | 40 +++
...err => disk-shared-qcow.x86_64-latest.err} | 0
tests/qemuxml2argvdata/disk-snapshot.args | 36 ---
.../disk-snapshot.x86_64-latest.args | 42 +++
...> disk-source-pool-mode.x86_64-4.1.0.args} | 9 +-
.../disk-source-pool-mode.x86_64-latest.args | 45 +++
...rgs => disk-source-pool.x86_64-4.1.0.args} | 13 +-
.../disk-source-pool.x86_64-latest.args | 46 +++
.../disk-usb-device-removable.args | 34 ---
...sk-usb-device-removable.x86_64-latest.args | 39 +++
tests/qemuxml2argvdata/disk-usb-device.args | 34 ---
.../disk-usb-device.x86_64-latest.args | 39 +++
tests/qemuxml2argvdata/disk-usb-nosupport.err | 1 -
tests/qemuxml2argvdata/disk-usb-nosupport.xml | 35 ---
...pci.err => disk-usb-pci.x86_64-latest.err} | 0
.../disk-virtio-ccw-many.args | 36 ---
.../disk-virtio-ccw-many.s390x-latest.args | 43 +++
.../qemuxml2argvdata/disk-virtio-ccw-many.xml | 2 +-
tests/qemuxml2argvdata/disk-virtio-ccw.args | 32 ---
.../disk-virtio-ccw.s390x-latest.args | 37 +++
tests/qemuxml2argvdata/disk-virtio-ccw.xml | 2 +-
.../disk-virtio-s390-zpci.args | 31 ---
.../disk-virtio-s390-zpci.s390x-latest.args | 35 +++
tests/qemuxml2argvdata/disk-virtio.args | 37 ---
.../disk-virtio.x86_64-latest.args | 44 +++
...=> encrypted-disk-usage.x86_64-4.1.0.args} | 11 +-
.../encrypted-disk-usage.x86_64-latest.args | 37 +++
....args => encrypted-disk.x86_64-4.1.0.args} | 11 +-
.../encrypted-disk.x86_64-latest.args | 37 +++
tests/qemuxml2argvdata/event_idx.args | 37 ---
.../event_idx.x86_64-latest.args | 42 +++
tests/qemuxml2argvdata/floppy-drive-fat.args | 33 ---
tests/qemuxml2argvdata/fs9p-ccw.args | 36 ---
tests/qemuxml2argvdata/fs9p.args | 34 ---
.../hostdev-scsi-vhost-scsi-ccw.args | 2 +-
.../hostdev-scsi-vhost-scsi-ccw.xml | 2 +-
...-drive-address-conflict.x86_64-latest.err} | 0
.../iothreads-disk-virtio-ccw.args | 2 +-
.../iothreads-disk-virtio-ccw.xml | 2 +-
...rr => luks-disk-invalid.x86_64-latest.err} | 0
... luks-disks-source-both.x86_64-latest.err} | 0
.../luks-disks-source-qcow2.err | 1 -
...gs => luks-disks-source.x86_64-4.1.0.args} | 17 +-
.../luks-disks-source.x86_64-latest.args | 54 ++++
...isks.args => luks-disks.x86_64-4.1.0.args} | 11 +-
.../luks-disks.x86_64-latest.args | 41 +++
tests/qemuxml2argvdata/misc-no-reboot.args | 31 ---
.../misc-no-reboot.x86_64-5.2.0.args | 35 +++
tests/qemuxml2argvdata/net-virtio-ccw.args | 2 +-
tests/qemuxml2argvdata/net-virtio-ccw.xml | 2 +-
.../non-x86_64-timer-error.err | 2 +-
.../non-x86_64-timer-error.xml | 2 +-
tests/qemuxml2argvdata/virtio-lun.args | 37 ---
.../virtio-lun.x86_64-latest.args | 42 +++
tests/qemuxml2argvdata/virtio-rng-ccw.args | 2 +-
tests/qemuxml2argvdata/virtio-rng-ccw.xml | 2 +-
tests/qemuxml2argvtest.c | 261 +++++++-----------
.../disk-cache.x86_64-2.12.0.xml | 2 +-
.../disk-cache.x86_64-latest.xml | 2 +-
.../qemuxml2xmloutdata/disk-network-iscsi.xml | 25 ++
.../hostdev-scsi-vhost-scsi-ccw.xml | 2 +-
.../iothreads-disk-virtio-ccw.xml | 2 +-
tests/testutilsqemu.c | 8 +-
181 files changed, 1726 insertions(+), 2164 deletions(-)
rename tests/qemuxml2argvdata/{audio-alsa-best.args => audio-alsa-best.x86_64-4.1.0.args} (81%)
rename tests/qemuxml2argvdata/{audio-alsa-full.err => audio-alsa-full.x86_64-4.1.0.err} (100%)
rename tests/qemuxml2argvdata/{audio-alsa-minimal.args => audio-alsa-minimal.x86_64-4.1.0.args} (75%)
rename tests/qemuxml2argvdata/{audio-coreaudio-best.args => audio-coreaudio-best.x86_64-4.1.0.args} (81%)
rename tests/qemuxml2argvdata/{audio-coreaudio-full.err => audio-coreaudio-full.x86_64-4.1.0.err} (100%)
rename tests/qemuxml2argvdata/{audio-coreaudio-minimal.args => audio-coreaudio-minimal.x86_64-4.1.0.args} (75%)
rename tests/qemuxml2argvdata/{audio-default-nographics.args => audio-default-nographics.x86_64-4.1.0.args} (75%)
rename tests/qemuxml2argvdata/{audio-file-best.args => audio-file-best.x86_64-4.1.0.args} (81%)
rename tests/qemuxml2argvdata/{audio-file-full.err => audio-file-full.x86_64-4.1.0.err} (100%)
rename tests/qemuxml2argvdata/{audio-file-minimal.args => audio-file-minimal.x86_64-4.1.0.args} (75%)
rename tests/qemuxml2argvdata/{audio-jack-full.err => audio-jack-full.x86_64-4.1.0.err} (100%)
rename tests/qemuxml2argvdata/{audio-jack-minimal.err => audio-jack-minimal.x86_64-4.1.0.err} (100%)
rename tests/qemuxml2argvdata/{audio-many-backends.err => audio-many-backends.x86_64-4.1.0.err} (100%)
rename tests/qemuxml2argvdata/{audio-none-best.args => audio-none-best.x86_64-4.1.0.args} (80%)
rename tests/qemuxml2argvdata/{audio-none-full.err => audio-none-full.x86_64-4.1.0.err} (100%)
rename tests/qemuxml2argvdata/{audio-none-minimal.args => audio-none-minimal.x86_64-4.1.0.args} (75%)
rename tests/qemuxml2argvdata/{audio-oss-best.args => audio-oss-best.x86_64-4.1.0.args} (82%)
rename tests/qemuxml2argvdata/{audio-oss-full.err => audio-oss-full.x86_64-4.1.0.err} (100%)
rename tests/qemuxml2argvdata/{audio-oss-minimal.args => audio-oss-minimal.x86_64-4.1.0.args} (75%)
rename tests/qemuxml2argvdata/{audio-pulseaudio-best.args => audio-pulseaudio-best.x86_64-4.1.0.args} (82%)
rename tests/qemuxml2argvdata/{audio-pulseaudio-full.err => audio-pulseaudio-full.x86_64-4.1.0.err} (100%)
rename tests/qemuxml2argvdata/{audio-pulseaudio-minimal.args => audio-pulseaudio-minimal.x86_64-4.1.0.args} (75%)
rename tests/qemuxml2argvdata/{audio-sdl-best.args => audio-sdl-best.x86_64-4.1.0.args} (81%)
rename tests/qemuxml2argvdata/{audio-sdl-full.err => audio-sdl-full.x86_64-4.1.0.err} (100%)
rename tests/qemuxml2argvdata/{audio-sdl-minimal.args => audio-sdl-minimal.x86_64-4.1.0.args} (75%)
rename tests/qemuxml2argvdata/{audio-spice-best.args => audio-spice-best.x86_64-4.1.0.args} (80%)
rename tests/qemuxml2argvdata/{audio-spice-full.err => audio-spice-full.x86_64-4.1.0.err} (100%)
rename tests/qemuxml2argvdata/{audio-spice-minimal.args => audio-spice-minimal.x86_64-4.1.0.args} (75%)
delete mode 100644 tests/qemuxml2argvdata/boot-strict.args
delete mode 100644 tests/qemuxml2argvdata/boot-strict.xml
rename tests/qemuxml2argvdata/{disk-address-conflict.err => disk-address-conflict.x86_64-latest.err} (100%)
delete mode 100644 tests/qemuxml2argvdata/disk-aio.args
delete mode 100644 tests/qemuxml2argvdata/disk-blockio.args
create mode 100644 tests/qemuxml2argvdata/disk-blockio.x86_64-latest.args
delete mode 100644 tests/qemuxml2argvdata/disk-boot-cdrom.args
create mode 100644 tests/qemuxml2argvdata/disk-boot-cdrom.x86_64-latest.args
delete mode 100644 tests/qemuxml2argvdata/disk-boot-disk.args
create mode 100644 tests/qemuxml2argvdata/disk-boot-disk.x86_64-latest.args
delete mode 100644 tests/qemuxml2argvdata/disk-cdrom-network.args
delete mode 100644 tests/qemuxml2argvdata/disk-cdrom-tray.args
delete mode 100644 tests/qemuxml2argvdata/disk-cdrom.args
delete mode 100644 tests/qemuxml2argvdata/disk-copy_on_read.args
rename tests/qemuxml2argvdata/{disk-device-lun-type-invalid.err => disk-device-lun-type-invalid.x86_64-latest.err} (100%)
delete mode 100644 tests/qemuxml2argvdata/disk-error-policy.args
rename tests/qemuxml2argvdata/{disk-fdc-incompatible-address.err => disk-fdc-incompatible-address.x86_64-latest.err} (100%)
rename tests/qemuxml2argvdata/{disk-floppy-pseries.err => disk-floppy-pseries.ppc64-latest.err} (100%)
delete mode 100644 tests/qemuxml2argvdata/disk-floppy-tray.args
create mode 100644 tests/qemuxml2argvdata/disk-floppy-tray.x86_64-latest.args
delete mode 100644 tests/qemuxml2argvdata/disk-floppy.args
rename tests/qemuxml2argvdata/{disk-fmt-cow.err => disk-fmt-cow.x86_64-latest.err} (100%)
rename tests/qemuxml2argvdata/{disk-fmt-dir.err => disk-fmt-dir.x86_64-latest.err} (100%)
rename tests/qemuxml2argvdata/{disk-fmt-iso.err => disk-fmt-iso.x86_64-latest.err} (100%)
rename tests/qemuxml2argvdata/{disk-fmt-qcow.args => disk-fmt-qcow.x86_64-4.1.0.args} (77%)
create mode 100644 tests/qemuxml2argvdata/disk-fmt-qcow.x86_64-latest.args
delete mode 100644 tests/qemuxml2argvdata/disk-geometry.args
create mode 100644 tests/qemuxml2argvdata/disk-geometry.x86_64-latest.args
rename tests/qemuxml2argvdata/{disk-hostdev-scsi-address-conflict.err => disk-hostdev-scsi-address-conflict.x86_64-latest.err} (100%)
rename tests/qemuxml2argvdata/{disk-ide-incompatible-address.err => disk-ide-incompatible-address.x86_64-latest.err} (100%)
delete mode 100644 tests/qemuxml2argvdata/disk-ide-split.args
create mode 100644 tests/qemuxml2argvdata/disk-ide-split.x86_64-latest.args
delete mode 100644 tests/qemuxml2argvdata/disk-ide-wwn.args
create mode 100644 tests/qemuxml2argvdata/disk-ide-wwn.x86_64-latest.args
delete mode 100644 tests/qemuxml2argvdata/disk-ioeventfd.args
create mode 100644 tests/qemuxml2argvdata/disk-ioeventfd.x86_64-latest.args
delete mode 100644 tests/qemuxml2argvdata/disk-iscsi.args
delete mode 100644 tests/qemuxml2argvdata/disk-iscsi.xml
rename tests/qemuxml2argvdata/{disk-missing-target-invalid.err => disk-missing-target-invalid.x86_64-latest.err} (100%)
delete mode 100644 tests/qemuxml2argvdata/disk-network-gluster.args
rename tests/qemuxml2argvdata/{disk-network-iscsi-auth-secrettype-invalid.err => disk-network-iscsi-auth-secrettype-invalid.x86_64-latest.err} (100%)
rename tests/qemuxml2argvdata/{disk-network-iscsi-auth-wrong-secrettype.err => disk-network-iscsi-auth-wrong-secrettype.x86_64-latest.err} (100%)
delete mode 100644 tests/qemuxml2argvdata/disk-network-iscsi-modern.args
delete mode 100644 tests/qemuxml2argvdata/disk-network-iscsi-modern.xml
delete mode 100644 tests/qemuxml2argvdata/disk-network-iscsi.args
delete mode 100644 tests/qemuxml2argvdata/disk-network-nbd.args
rename tests/qemuxml2argvdata/{disk-network-rbd-no-colon.err => disk-network-rbd-no-colon.x86_64-4.1.0.err} (100%)
create mode 100644 tests/qemuxml2argvdata/disk-network-rbd-no-colon.x86_64-latest.args
delete mode 100644 tests/qemuxml2argvdata/disk-network-sheepdog.args
rename tests/qemuxml2argvdata/{disk-network-source-auth-both.err => disk-network-source-auth-both.x86_64-latest.err} (100%)
delete mode 100644 tests/qemuxml2argvdata/disk-network-source-auth.args
delete mode 100644 tests/qemuxml2argvdata/disk-network-vxhs.args
delete mode 100644 tests/qemuxml2argvdata/disk-no-boot.args
create mode 100644 tests/qemuxml2argvdata/disk-no-boot.x86_64-latest.args
delete mode 100644 tests/qemuxml2argvdata/disk-order.args
create mode 100644 tests/qemuxml2argvdata/disk-order.x86_64-latest.args
delete mode 100644 tests/qemuxml2argvdata/disk-readonly-disk.args
rename tests/qemuxml2argvdata/{disk-same-targets.err => disk-same-targets.x86_64-latest.err} (100%)
delete mode 100644 tests/qemuxml2argvdata/disk-sata-device.args
create mode 100644 tests/qemuxml2argvdata/disk-sata-device.x86_64-latest.args
rename tests/qemuxml2argvdata/{disk-sata-incompatible-address.err => disk-sata-incompatible-address.x86_64-latest.err} (100%)
delete mode 100644 tests/qemuxml2argvdata/disk-scsi-disk-split.args
create mode 100644 tests/qemuxml2argvdata/disk-scsi-disk-split.x86_64-latest.args
rename tests/qemuxml2argvdata/{disk-scsi-disk-vpd-build-error.err => disk-scsi-disk-vpd-build-error.x86_64-latest.err} (100%)
delete mode 100644 tests/qemuxml2argvdata/disk-scsi-disk-vpd.args
create mode 100644 tests/qemuxml2argvdata/disk-scsi-disk-vpd.x86_64-latest.args
delete mode 100644 tests/qemuxml2argvdata/disk-scsi-disk-wwn.args
create mode 100644 tests/qemuxml2argvdata/disk-scsi-disk-wwn.x86_64-latest.args
rename tests/qemuxml2argvdata/{disk-scsi-incompatible-address.err => disk-scsi-incompatible-address.x86_64-latest.err} (100%)
delete mode 100644 tests/qemuxml2argvdata/disk-scsi-lun-passthrough.args
create mode 100644 tests/qemuxml2argvdata/disk-scsi-lun-passthrough.x86_64-latest.args
delete mode 100644 tests/qemuxml2argvdata/disk-serial.args
create mode 100644 tests/qemuxml2argvdata/disk-serial.x86_64-latest.args
rename tests/qemuxml2argvdata/{disk-shared-qcow.err => disk-shared-qcow.x86_64-latest.err} (100%)
delete mode 100644 tests/qemuxml2argvdata/disk-snapshot.args
create mode 100644 tests/qemuxml2argvdata/disk-snapshot.x86_64-latest.args
rename tests/qemuxml2argvdata/{disk-source-pool-mode.args => disk-source-pool-mode.x86_64-4.1.0.args} (84%)
create mode 100644 tests/qemuxml2argvdata/disk-source-pool-mode.x86_64-latest.args
rename tests/qemuxml2argvdata/{disk-source-pool.args => disk-source-pool.x86_64-4.1.0.args} (73%)
create mode 100644 tests/qemuxml2argvdata/disk-source-pool.x86_64-latest.args
delete mode 100644 tests/qemuxml2argvdata/disk-usb-device-removable.args
create mode 100644 tests/qemuxml2argvdata/disk-usb-device-removable.x86_64-latest.args
delete mode 100644 tests/qemuxml2argvdata/disk-usb-device.args
create mode 100644 tests/qemuxml2argvdata/disk-usb-device.x86_64-latest.args
delete mode 100644 tests/qemuxml2argvdata/disk-usb-nosupport.err
delete mode 100644 tests/qemuxml2argvdata/disk-usb-nosupport.xml
rename tests/qemuxml2argvdata/{disk-usb-pci.err => disk-usb-pci.x86_64-latest.err} (100%)
delete mode 100644 tests/qemuxml2argvdata/disk-virtio-ccw-many.args
create mode 100644 tests/qemuxml2argvdata/disk-virtio-ccw-many.s390x-latest.args
delete mode 100644 tests/qemuxml2argvdata/disk-virtio-ccw.args
create mode 100644 tests/qemuxml2argvdata/disk-virtio-ccw.s390x-latest.args
delete mode 100644 tests/qemuxml2argvdata/disk-virtio-s390-zpci.args
create mode 100644 tests/qemuxml2argvdata/disk-virtio-s390-zpci.s390x-latest.args
delete mode 100644 tests/qemuxml2argvdata/disk-virtio.args
create mode 100644 tests/qemuxml2argvdata/disk-virtio.x86_64-latest.args
rename tests/qemuxml2argvdata/{encrypted-disk-usage.args => encrypted-disk-usage.x86_64-4.1.0.args} (74%)
create mode 100644 tests/qemuxml2argvdata/encrypted-disk-usage.x86_64-latest.args
rename tests/qemuxml2argvdata/{encrypted-disk.args => encrypted-disk.x86_64-4.1.0.args} (74%)
create mode 100644 tests/qemuxml2argvdata/encrypted-disk.x86_64-latest.args
delete mode 100644 tests/qemuxml2argvdata/event_idx.args
create mode 100644 tests/qemuxml2argvdata/event_idx.x86_64-latest.args
delete mode 100644 tests/qemuxml2argvdata/floppy-drive-fat.args
delete mode 100644 tests/qemuxml2argvdata/fs9p-ccw.args
delete mode 100644 tests/qemuxml2argvdata/fs9p.args
rename tests/qemuxml2argvdata/{hostdevs-drive-address-conflict.err => hostdevs-drive-address-conflict.x86_64-latest.err} (100%)
rename tests/qemuxml2argvdata/{luks-disk-invalid.err => luks-disk-invalid.x86_64-latest.err} (100%)
rename tests/qemuxml2argvdata/{luks-disks-source-both.err => luks-disks-source-both.x86_64-latest.err} (100%)
delete mode 100644 tests/qemuxml2argvdata/luks-disks-source-qcow2.err
rename tests/qemuxml2argvdata/{luks-disks-source.args => luks-disks-source.x86_64-4.1.0.args} (80%)
create mode 100644 tests/qemuxml2argvdata/luks-disks-source.x86_64-latest.args
rename tests/qemuxml2argvdata/{luks-disks.args => luks-disks.x86_64-4.1.0.args} (77%)
create mode 100644 tests/qemuxml2argvdata/luks-disks.x86_64-latest.args
delete mode 100644 tests/qemuxml2argvdata/misc-no-reboot.args
create mode 100644 tests/qemuxml2argvdata/misc-no-reboot.x86_64-5.2.0.args
delete mode 100644 tests/qemuxml2argvdata/virtio-lun.args
create mode 100644 tests/qemuxml2argvdata/virtio-lun.x86_64-latest.args
--
2.31.1
3 years, 2 months
- 2
- 23
[PATCH 00/12] qemu: Remove code for old insecure secret passing
by Peter Krempa
We are at the point where we can remove all the code to pass secrets
(RBD/iSCSI authentication passwords) on the commandline in plaintext
as all supported versions of qemu now support -object secret and the
corresponding methods to pass the secrets securely.
Peter Krempa (12):
util: Remove use of virCryptoHaveCipher(VIR_CRYPTO_CIPHER_AES256CBC)
qemu: Always assume presence of QEMU_CAPS_OBJECT_SECRET
qemu: capabilities: Retire QEMU_CAPS_OBJECT_SECRET
qemu: domain: Remove qemuDomainSupportsEncryptedSecret
qemu: domain: Always assume QEMU_CAPS_ISCSI_PASSWORD_SECRET
qemu: capabilities: Retire QEMU_CAPS_ISCSI_PASSWORD_SECRET
qemu: Remove VIR_DOMAIN_SECRET_INFO_TYPE_PLAIN and associated code
qemu: command: Remove qemuBuildGeneralSecinfoURI
qemuBuildSCSIiSCSIHostdevDrvStr: Don't call qemuDiskSourceNeedsProps
qemu: Simplify qemuDomainSecretInfo
qemu: domain: Rename secrets setup function
qemu: command: Remove qemuBuildRBDSecinfoURI
src/libvirt_private.syms | 1 -
src/qemu/qemu_backup.c | 2 +-
src/qemu/qemu_block.c | 40 ++-
src/qemu/qemu_capabilities.c | 6 +-
src/qemu/qemu_capabilities.h | 4 +-
src/qemu/qemu_command.c | 184 +++---------
src/qemu/qemu_domain.c | 274 ++++--------------
src/qemu/qemu_domain.h | 31 +-
src/qemu/qemu_hotplug.c | 4 +-
src/qemu/qemu_migration_params.c | 2 +-
src/storage/storage_util.c | 6 -
src/util/vircrypto.c | 27 --
src/util/vircrypto.h | 2 -
tests/qemublocktest.c | 13 +-
.../caps_2.11.0.s390x.xml | 2 -
.../caps_2.11.0.x86_64.xml | 2 -
.../caps_2.12.0.aarch64.xml | 2 -
.../caps_2.12.0.ppc64.xml | 2 -
.../caps_2.12.0.s390x.xml | 2 -
.../caps_2.12.0.x86_64.xml | 2 -
.../qemucapabilitiesdata/caps_3.0.0.ppc64.xml | 2 -
.../caps_3.0.0.riscv32.xml | 2 -
.../caps_3.0.0.riscv64.xml | 2 -
.../qemucapabilitiesdata/caps_3.0.0.s390x.xml | 2 -
.../caps_3.0.0.x86_64.xml | 2 -
.../qemucapabilitiesdata/caps_3.1.0.ppc64.xml | 2 -
.../caps_3.1.0.x86_64.xml | 2 -
.../caps_4.0.0.aarch64.xml | 2 -
.../qemucapabilitiesdata/caps_4.0.0.ppc64.xml | 2 -
.../caps_4.0.0.riscv32.xml | 2 -
.../caps_4.0.0.riscv64.xml | 2 -
.../qemucapabilitiesdata/caps_4.0.0.s390x.xml | 2 -
.../caps_4.0.0.x86_64.xml | 2 -
.../caps_4.1.0.x86_64.xml | 2 -
.../caps_4.2.0.aarch64.xml | 2 -
.../qemucapabilitiesdata/caps_4.2.0.ppc64.xml | 2 -
.../qemucapabilitiesdata/caps_4.2.0.s390x.xml | 2 -
.../caps_4.2.0.x86_64.xml | 2 -
.../caps_5.0.0.aarch64.xml | 2 -
.../qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 2 -
.../caps_5.0.0.riscv64.xml | 2 -
.../caps_5.0.0.x86_64.xml | 2 -
.../qemucapabilitiesdata/caps_5.1.0.sparc.xml | 2 -
.../caps_5.1.0.x86_64.xml | 2 -
.../caps_5.2.0.aarch64.xml | 2 -
.../qemucapabilitiesdata/caps_5.2.0.ppc64.xml | 2 -
.../caps_5.2.0.riscv64.xml | 2 -
.../qemucapabilitiesdata/caps_5.2.0.s390x.xml | 2 -
.../caps_5.2.0.x86_64.xml | 2 -
.../caps_6.0.0.aarch64.xml | 2 -
.../qemucapabilitiesdata/caps_6.0.0.s390x.xml | 2 -
.../caps_6.0.0.x86_64.xml | 2 -
.../caps_6.1.0.x86_64.xml | 2 -
.../aarch64-aavmf-virtio-mmio.args | 1 +
tests/qemuxml2argvdata/aarch64-acpi-uefi.args | 1 +
.../aarch64-cpu-passthrough.args | 1 +
tests/qemuxml2argvdata/aarch64-gic-host.args | 1 +
.../aarch64-gic-none-tcg.args | 1 +
tests/qemuxml2argvdata/aarch64-gic-v2.args | 1 +
tests/qemuxml2argvdata/aarch64-gic-v3.args | 1 +
.../aarch64-kvm-32-on-64.args | 1 +
.../aarch64-noacpi-nouefi.args | 1 +
.../qemuxml2argvdata/aarch64-noacpi-uefi.args | 1 +
.../qemuxml2argvdata/aarch64-pci-serial.args | 1 +
.../aarch64-traditional-pci.args | 1 +
.../aarch64-usb-controller-nec-xhci.args | 1 +
.../aarch64-usb-controller-qemu-xhci.args | 1 +
.../aarch64-video-default.args | 1 +
.../aarch64-video-virtio-gpu-pci.args | 1 +
.../aarch64-virt-2.6-virtio-pci-default.args | 1 +
.../aarch64-virt-default-nic.args | 1 +
.../qemuxml2argvdata/aarch64-virt-virtio.args | 1 +
.../aarch64-virtio-pci-default.args | 1 +
.../aarch64-virtio-pci-manual-addresses.args | 1 +
tests/qemuxml2argvdata/acpi-table.args | 1 +
.../arm-vexpressa9-basic.args | 1 +
.../arm-vexpressa9-nodevs.args | 1 +
.../arm-vexpressa9-virtio.args | 1 +
tests/qemuxml2argvdata/arm-virt-virtio.args | 1 +
tests/qemuxml2argvdata/audio-alsa-best.args | 1 +
.../qemuxml2argvdata/audio-alsa-minimal.args | 1 +
.../audio-coreaudio-best.args | 1 +
.../audio-coreaudio-minimal.args | 1 +
.../audio-default-nographics.args | 1 +
tests/qemuxml2argvdata/audio-default-sdl.args | 1 +
.../qemuxml2argvdata/audio-default-spice.args | 1 +
tests/qemuxml2argvdata/audio-default-vnc.args | 1 +
tests/qemuxml2argvdata/audio-file-best.args | 1 +
.../qemuxml2argvdata/audio-file-minimal.args | 1 +
tests/qemuxml2argvdata/audio-none-best.args | 1 +
.../qemuxml2argvdata/audio-none-minimal.args | 1 +
tests/qemuxml2argvdata/audio-oss-best.args | 1 +
tests/qemuxml2argvdata/audio-oss-minimal.args | 1 +
.../audio-pulseaudio-best.args | 1 +
.../audio-pulseaudio-minimal.args | 1 +
tests/qemuxml2argvdata/audio-sdl-best.args | 1 +
tests/qemuxml2argvdata/audio-sdl-minimal.args | 1 +
tests/qemuxml2argvdata/audio-spice-best.args | 1 +
.../qemuxml2argvdata/audio-spice-minimal.args | 1 +
tests/qemuxml2argvdata/autoindex.args | 1 +
.../qemuxml2argvdata/balloon-ccw-deflate.args | 1 +
.../qemuxml2argvdata/balloon-device-auto.args | 1 +
.../balloon-device-deflate-off.args | 1 +
.../balloon-device-deflate.args | 1 +
.../balloon-device-period.args | 1 +
tests/qemuxml2argvdata/balloon-device.args | 1 +
.../balloon-mmio-deflate.args | 1 +
tests/qemuxml2argvdata/bios-nvram-secure.args | 1 +
tests/qemuxml2argvdata/bios-nvram.args | 1 +
tests/qemuxml2argvdata/bios.args | 1 +
tests/qemuxml2argvdata/blkiotune-device.args | 1 +
tests/qemuxml2argvdata/blkiotune.args | 1 +
tests/qemuxml2argvdata/boot-cdrom.args | 1 +
tests/qemuxml2argvdata/boot-complex.args | 1 +
tests/qemuxml2argvdata/boot-floppy-q35.args | 1 +
tests/qemuxml2argvdata/boot-floppy.args | 1 +
.../boot-menu-disable-drive.args | 1 +
tests/qemuxml2argvdata/boot-menu-disable.args | 1 +
.../boot-menu-enable-with-timeout.args | 1 +
tests/qemuxml2argvdata/boot-menu-enable.args | 1 +
tests/qemuxml2argvdata/boot-multi.args | 1 +
tests/qemuxml2argvdata/boot-network.args | 1 +
tests/qemuxml2argvdata/boot-order.args | 1 +
tests/qemuxml2argvdata/boot-strict.args | 1 +
tests/qemuxml2argvdata/channel-guestfwd.args | 1 +
tests/qemuxml2argvdata/channel-spicevmc.args | 1 +
.../qemuxml2argvdata/channel-virtio-auto.args | 1 +
.../channel-virtio-autoadd.args | 1 +
.../channel-virtio-autoassign.args | 1 +
.../channel-virtio-default.args | 1 +
.../channel-virtio-state.args | 1 +
.../qemuxml2argvdata/channel-virtio-unix.args | 1 +
tests/qemuxml2argvdata/channel-virtio.args | 1 +
tests/qemuxml2argvdata/chardev-reconnect.args | 1 +
tests/qemuxml2argvdata/clock-catchup.args | 1 +
tests/qemuxml2argvdata/clock-france.args | 1 +
tests/qemuxml2argvdata/clock-hpet-off.args | 1 +
.../clock-localtime-basis-localtime.args | 1 +
tests/qemuxml2argvdata/clock-localtime.args | 1 +
tests/qemuxml2argvdata/clock-realtime.args | 1 +
.../clock-timer-hyperv-rtc.args | 1 +
tests/qemuxml2argvdata/clock-utc.args | 1 +
tests/qemuxml2argvdata/clock-variable.args | 1 +
.../qemuxml2argvdata/console-compat-auto.args | 1 +
.../console-compat-chardev.args | 1 +
tests/qemuxml2argvdata/console-compat.args | 1 +
.../qemuxml2argvdata/console-virtio-ccw.args | 1 +
.../qemuxml2argvdata/console-virtio-many.args | 1 +
tests/qemuxml2argvdata/console-virtio.args | 1 +
tests/qemuxml2argvdata/controller-order.args | 1 +
tests/qemuxml2argvdata/cpu-Haswell-noTSX.args | 1 +
tests/qemuxml2argvdata/cpu-Haswell.args | 1 +
tests/qemuxml2argvdata/cpu-Haswell2.args | 1 +
tests/qemuxml2argvdata/cpu-Haswell3.args | 1 +
tests/qemuxml2argvdata/cpu-cache-disable.args | 1 +
.../qemuxml2argvdata/cpu-cache-disable2.args | 1 +
.../qemuxml2argvdata/cpu-cache-disable3.args | 1 +
.../cpu-cache-emulate-l3.args | 1 +
.../cpu-cache-passthrough.args | 1 +
.../cpu-cache-passthrough2.args | 1 +
.../cpu-check-default-none.args | 1 +
.../cpu-check-default-none2.args | 1 +
.../cpu-check-default-partial.args | 1 +
.../cpu-check-default-partial2.args | 1 +
tests/qemuxml2argvdata/cpu-check-none.args | 1 +
tests/qemuxml2argvdata/cpu-eoi-disabled.args | 1 +
tests/qemuxml2argvdata/cpu-eoi-enabled.args | 1 +
tests/qemuxml2argvdata/cpu-exact1.args | 1 +
.../cpu-exact2-nofallback.args | 1 +
tests/qemuxml2argvdata/cpu-exact2.args | 1 +
tests/qemuxml2argvdata/cpu-fallback.args | 1 +
tests/qemuxml2argvdata/cpu-host-kvmclock.args | 1 +
.../qemuxml2argvdata/cpu-host-model-cmt.args | 1 +
.../cpu-host-model-fallback.args | 1 +
.../cpu-host-model-vendor.args | 1 +
tests/qemuxml2argvdata/cpu-host-model.args | 1 +
.../cpu-host-passthrough-features.args | 1 +
.../cpu-host-passthrough.args | 1 +
.../qemuxml2argvdata/cpu-hotplug-startup.args | 1 +
tests/qemuxml2argvdata/cpu-kvmclock.args | 1 +
tests/qemuxml2argvdata/cpu-minimum1.args | 1 +
tests/qemuxml2argvdata/cpu-minimum2.args | 1 +
.../cpu-no-removed-features.args | 1 +
tests/qemuxml2argvdata/cpu-numa-disjoint.args | 1 +
.../qemuxml2argvdata/cpu-numa-memshared.args | 1 +
.../cpu-numa-no-memory-element.args | 1 +
tests/qemuxml2argvdata/cpu-numa1.args | 1 +
tests/qemuxml2argvdata/cpu-numa2.args | 1 +
tests/qemuxml2argvdata/cpu-s390-features.args | 1 +
tests/qemuxml2argvdata/cpu-s390-zEC12.args | 1 +
tests/qemuxml2argvdata/cpu-strict1.args | 1 +
tests/qemuxml2argvdata/cpu-topology1.args | 1 +
tests/qemuxml2argvdata/cpu-topology2.args | 1 +
tests/qemuxml2argvdata/cpu-topology3.args | 1 +
tests/qemuxml2argvdata/cpu-tsc-frequency.args | 1 +
tests/qemuxml2argvdata/cputune-numatune.args | 1 +
.../qemuxml2argvdata/cputune-zero-shares.args | 1 +
tests/qemuxml2argvdata/cputune.args | 1 +
.../default-kvm-host-arch.args | 1 +
.../default-qemu-host-arch.args | 1 +
tests/qemuxml2argvdata/disk-aio.args | 1 +
tests/qemuxml2argvdata/disk-blockio.args | 1 +
tests/qemuxml2argvdata/disk-boot-cdrom.args | 1 +
tests/qemuxml2argvdata/disk-boot-disk.args | 1 +
.../qemuxml2argvdata/disk-cdrom-network.args | 1 +
tests/qemuxml2argvdata/disk-cdrom-tray.args | 1 +
tests/qemuxml2argvdata/disk-cdrom.args | 1 +
tests/qemuxml2argvdata/disk-copy_on_read.args | 1 +
tests/qemuxml2argvdata/disk-error-policy.args | 1 +
tests/qemuxml2argvdata/disk-floppy-tray.args | 1 +
tests/qemuxml2argvdata/disk-floppy.args | 1 +
tests/qemuxml2argvdata/disk-fmt-qcow.args | 1 +
tests/qemuxml2argvdata/disk-geometry.args | 1 +
tests/qemuxml2argvdata/disk-ide-split.args | 1 +
tests/qemuxml2argvdata/disk-ide-wwn.args | 1 +
tests/qemuxml2argvdata/disk-ioeventfd.args | 1 +
tests/qemuxml2argvdata/disk-iscsi.args | 1 +
.../disk-network-gluster.args | 1 +
.../disk-network-iscsi-modern.args | 10 +-
.../qemuxml2argvdata/disk-network-iscsi.args | 13 +-
tests/qemuxml2argvdata/disk-network-nbd.args | 1 +
.../disk-network-sheepdog.args | 1 +
.../disk-network-source-auth.args | 10 +-
tests/qemuxml2argvdata/disk-network-vxhs.args | 1 +
tests/qemuxml2argvdata/disk-no-boot.args | 1 +
tests/qemuxml2argvdata/disk-order.args | 1 +
.../qemuxml2argvdata/disk-readonly-disk.args | 1 +
tests/qemuxml2argvdata/disk-sata-device.args | 1 +
.../disk-scsi-disk-split.args | 1 +
.../qemuxml2argvdata/disk-scsi-disk-vpd.args | 1 +
.../qemuxml2argvdata/disk-scsi-disk-wwn.args | 1 +
.../disk-scsi-lun-passthrough.args | 1 +
tests/qemuxml2argvdata/disk-serial.args | 1 +
tests/qemuxml2argvdata/disk-snapshot.args | 1 +
.../disk-source-pool-mode.args | 5 +-
tests/qemuxml2argvdata/disk-source-pool.args | 1 +
.../disk-usb-device-removable.args | 1 +
tests/qemuxml2argvdata/disk-usb-device.args | 1 +
.../disk-virtio-ccw-many.args | 1 +
tests/qemuxml2argvdata/disk-virtio-ccw.args | 1 +
.../disk-virtio-s390-zpci.args | 1 +
tests/qemuxml2argvdata/disk-virtio.args | 1 +
tests/qemuxml2argvdata/event_idx.args | 1 +
.../fd-memory-no-numa-topology.args | 1 +
.../fd-memory-numa-topology.args | 1 +
.../fd-memory-numa-topology2.args | 1 +
.../fd-memory-numa-topology3.args | 1 +
tests/qemuxml2argvdata/floppy-drive-fat.args | 1 +
tests/qemuxml2argvdata/fs9p-ccw.args | 1 +
tests/qemuxml2argvdata/fs9p.args | 1 +
.../graphics-egl-headless.args | 1 +
.../graphics-sdl-fullscreen.args | 1 +
tests/qemuxml2argvdata/graphics-sdl.args | 1 +
.../graphics-spice-agent-file-xfer.args | 1 +
.../graphics-spice-agentmouse.args | 1 +
.../graphics-spice-auto-socket-cfg.args | 1 +
.../graphics-spice-auto-socket.args | 1 +
.../graphics-spice-compression.args | 1 +
.../graphics-spice-egl-headless.args | 1 +
.../graphics-spice-no-args.args | 1 +
.../graphics-spice-qxl-vga.args | 1 +
.../qemuxml2argvdata/graphics-spice-sasl.args | 1 +
.../graphics-spice-socket.args | 1 +
.../graphics-spice-timeout.args | 1 +
.../graphics-spice-usb-redir.args | 1 +
tests/qemuxml2argvdata/graphics-spice.args | 1 +
.../graphics-vnc-auto-socket-cfg.args | 1 +
.../graphics-vnc-auto-socket.args | 1 +
.../graphics-vnc-egl-headless.args | 1 +
.../graphics-vnc-no-listen-attr.args | 1 +
tests/qemuxml2argvdata/graphics-vnc-none.args | 1 +
.../qemuxml2argvdata/graphics-vnc-policy.args | 1 +
.../graphics-vnc-remove-generated-socket.args | 1 +
tests/qemuxml2argvdata/graphics-vnc-sasl.args | 1 +
.../graphics-vnc-socket-new-cmdline.args | 1 +
.../qemuxml2argvdata/graphics-vnc-socket.args | 1 +
tests/qemuxml2argvdata/graphics-vnc-tls.args | 1 +
.../graphics-vnc-websocket.args | 1 +
tests/qemuxml2argvdata/graphics-vnc.args | 1 +
.../hostdev-mdev-precreated.args | 1 +
.../hostdev-pci-address-device.args | 1 +
.../hostdev-pci-address-unassigned.args | 1 +
.../qemuxml2argvdata/hostdev-pci-address.args | 1 +
.../hostdev-pci-multifunction.args | 1 +
.../hostdev-scsi-vhost-scsi-ccw.args | 1 +
.../hostdev-scsi-vhost-scsi-pci.args | 1 +
.../hostdev-scsi-vhost-scsi-pcie.args | 1 +
.../hostdev-subsys-mdev-vfio-ccw.args | 1 +
.../hostdev-usb-address-device-boot.args | 1 +
.../hostdev-usb-address-device.args | 1 +
.../qemuxml2argvdata/hostdev-usb-address.args | 1 +
.../hostdev-vfio-multidomain.args | 1 +
.../hostdev-vfio-zpci-autogenerate-fids.args | 1 +
.../hostdev-vfio-zpci-autogenerate-uids.args | 1 +
.../hostdev-vfio-zpci-autogenerate.args | 1 +
.../hostdev-vfio-zpci-boundaries.args | 1 +
.../hostdev-vfio-zpci-ccw-memballoon.args | 1 +
.../hostdev-vfio-zpci-multidomain-many.args | 1 +
tests/qemuxml2argvdata/hostdev-vfio-zpci.args | 1 +
tests/qemuxml2argvdata/hostdev-vfio.args | 1 +
tests/qemuxml2argvdata/hotplug-base.args | 1 +
.../hugepages-default-2M.args | 1 +
.../hugepages-default-system-size.args | 1 +
tests/qemuxml2argvdata/hugepages-default.args | 1 +
.../qemuxml2argvdata/hugepages-memaccess.args | 1 +
.../hugepages-memaccess2.args | 1 +
tests/qemuxml2argvdata/hugepages-nodeset.args | 1 +
.../hugepages-numa-default-2M.args | 1 +
.../hugepages-numa-default-dimm.args | 1 +
.../hugepages-numa-default.args | 1 +
.../hugepages-numa-nodeset-part.args | 1 +
.../hugepages-numa-nodeset.args | 1 +
tests/qemuxml2argvdata/hugepages-shared.args | 1 +
.../qemuxml2argvdata/input-usbmouse-addr.args | 1 +
tests/qemuxml2argvdata/input-usbmouse.args | 1 +
tests/qemuxml2argvdata/input-usbtablet.args | 1 +
tests/qemuxml2argvdata/input-virtio-ccw.args | 1 +
.../iothreads-disk-virtio-ccw.args | 1 +
tests/qemuxml2argvdata/iothreads-disk.args | 1 +
.../iothreads-ids-partial.args | 1 +
tests/qemuxml2argvdata/iothreads-ids.args | 1 +
tests/qemuxml2argvdata/iothreads.args | 1 +
tests/qemuxml2argvdata/kvm-features-off.args | 1 +
tests/qemuxml2argvdata/kvm-features.args | 1 +
tests/qemuxml2argvdata/kvm-pit-delay.args | 1 +
tests/qemuxml2argvdata/kvm-pit-discard.args | 1 +
tests/qemuxml2argvdata/kvmclock.args | 1 +
.../luks-disks-source-qcow2.args | 5 +-
tests/qemuxml2argvdata/luks-disks-source.args | 5 +-
.../mach-virt-console-virtio.args | 1 +
.../mach-virt-serial-native.args | 1 +
.../mach-virt-serial-pci.args | 1 +
.../mach-virt-serial-usb.args | 1 +
.../machine-aeskeywrap-off-cap.args | 1 +
.../machine-aeskeywrap-off-caps.args | 1 +
.../machine-aeskeywrap-on-cap.args | 1 +
.../machine-aeskeywrap-on-caps.args | 1 +
tests/qemuxml2argvdata/machine-aliases1.args | 1 +
tests/qemuxml2argvdata/machine-aliases2.args | 1 +
tests/qemuxml2argvdata/machine-core-off.args | 1 +
tests/qemuxml2argvdata/machine-core-on.args | 1 +
.../machine-deakeywrap-off-cap.args | 1 +
.../machine-deakeywrap-off-caps.args | 1 +
.../machine-deakeywrap-on-cap.args | 1 +
.../machine-deakeywrap-on-caps.args | 1 +
.../machine-keywrap-none-caps.args | 1 +
.../machine-keywrap-none.args | 1 +
...ine-loadparm-multiple-disks-nets-s390.args | 1 +
.../machine-loadparm-net-s390.args | 1 +
.../machine-loadparm-s390.args | 1 +
tests/qemuxml2argvdata/machine-smm-opt.args | 1 +
.../qemuxml2argvdata/machine-vmport-opt.args | 1 +
.../memory-hotplug-dimm-addr.args | 1 +
.../qemuxml2argvdata/memory-hotplug-dimm.args | 1 +
...emory-hotplug-nvdimm-ppc64-abi-update.args | 1 +
.../memory-hotplug-nvdimm-ppc64.args | 1 +
...emory-hotplug-ppc64-nonuma-abi-update.args | 1 +
.../memory-hotplug-ppc64-nonuma.args | 1 +
tests/qemuxml2argvdata/memory-hotplug.args | 1 +
tests/qemuxml2argvdata/memtune-unlimited.args | 1 +
tests/qemuxml2argvdata/memtune.args | 1 +
.../migrate-numa-unaligned.args | 1 +
tests/qemuxml2argvdata/migrate.args | 1 +
tests/qemuxml2argvdata/minimal.args | 1 +
tests/qemuxml2argvdata/misc-acpi.args | 1 +
tests/qemuxml2argvdata/misc-disable-s3.args | 1 +
.../misc-disable-suspends.args | 1 +
tests/qemuxml2argvdata/misc-enable-s4.args | 1 +
tests/qemuxml2argvdata/misc-no-reboot.args | 1 +
tests/qemuxml2argvdata/misc-uuid.args | 1 +
tests/qemuxml2argvdata/monitor-json.args | 1 +
.../multifunction-pci-device.args | 1 +
tests/qemuxml2argvdata/name-escape.args | 2 +-
tests/qemuxml2argvdata/net-client.args | 1 +
tests/qemuxml2argvdata/net-eth-hostip.args | 1 +
tests/qemuxml2argvdata/net-eth-ifname.args | 1 +
tests/qemuxml2argvdata/net-eth-names.args | 1 +
.../net-eth-unmanaged-tap.args | 1 +
tests/qemuxml2argvdata/net-eth.args | 1 +
.../net-hostdev-bootorder.args | 1 +
.../net-hostdev-multidomain.args | 1 +
.../net-hostdev-vfio-multidomain.args | 1 +
tests/qemuxml2argvdata/net-hostdev-vfio.args | 1 +
tests/qemuxml2argvdata/net-hostdev.args | 1 +
tests/qemuxml2argvdata/net-many-models.args | 1 +
tests/qemuxml2argvdata/net-mcast.args | 1 +
tests/qemuxml2argvdata/net-server.args | 1 +
tests/qemuxml2argvdata/net-udp.args | 1 +
tests/qemuxml2argvdata/net-user-addr.args | 1 +
tests/qemuxml2argvdata/net-user.args | 1 +
.../net-vhostuser-multiq.args | 1 +
tests/qemuxml2argvdata/net-vhostuser.args | 1 +
tests/qemuxml2argvdata/net-virtio-ccw.args | 1 +
tests/qemuxml2argvdata/net-virtio-device.args | 1 +
.../net-virtio-disable-offloads.args | 1 +
tests/qemuxml2argvdata/net-virtio-netdev.args | 1 +
.../net-virtio-rxtxqueuesize.args | 1 +
.../net-virtio-teaming-hostdev.args | 1 +
.../qemuxml2argvdata/net-virtio-teaming.args | 1 +
tests/qemuxml2argvdata/net-virtio.args | 1 +
tests/qemuxml2argvdata/nosharepages.args | 1 +
.../numad-auto-memory-vcpu-cpuset.args | 1 +
...o-memory-vcpu-no-cpuset-and-placement.args | 1 +
.../numad-auto-vcpu-static-numatune.args | 1 +
.../numad-static-memory-auto-vcpu.args | 1 +
tests/qemuxml2argvdata/numad.args | 1 +
.../numatune-auto-nodeset-invalid.args | 1 +
.../numatune-auto-prefer.args | 1 +
.../qemuxml2argvdata/numatune-distances.args | 1 +
.../numatune-memnode-no-memory.args | 1 +
tests/qemuxml2argvdata/numatune-memnode.args | 1 +
tests/qemuxml2argvdata/numatune-memory.args | 1 +
tests/qemuxml2argvdata/numatune-no-vcpu.args | 1 +
.../qemuxml2argvdata/pages-dimm-discard.args | 1 +
.../pages-discard-hugepages.args | 1 +
tests/qemuxml2argvdata/pages-discard.args | 1 +
tests/qemuxml2argvdata/panic-double.args | 1 +
tests/qemuxml2argvdata/panic-no-address.args | 1 +
tests/qemuxml2argvdata/panic.args | 1 +
.../parallel-parport-chardev.args | 1 +
.../parallel-tcp-chardev.args | 1 +
tests/qemuxml2argvdata/pci-autoadd-addr.args | 1 +
tests/qemuxml2argvdata/pci-autoadd-idx.args | 1 +
tests/qemuxml2argvdata/pci-autofill-addr.args | 1 +
.../pci-bridge-many-disks.args | 1 +
tests/qemuxml2argvdata/pci-bridge.args | 1 +
tests/qemuxml2argvdata/pci-expander-bus.args | 1 +
tests/qemuxml2argvdata/pci-many.args | 1 +
tests/qemuxml2argvdata/pci-rom-disabled.args | 1 +
tests/qemuxml2argvdata/pci-rom.args | 1 +
.../pci-serial-dev-chardev.args | 1 +
tests/qemuxml2argvdata/pcie-expander-bus.args | 1 +
.../pcie-root-port-model-generic.args | 1 +
.../pcie-root-port-model-ioh3420.args | 1 +
tests/qemuxml2argvdata/pcie-root-port.args | 1 +
tests/qemuxml2argvdata/pcie-root.args | 1 +
.../pcie-switch-downstream-port.args | 1 +
.../pcie-switch-upstream-port.args | 1 +
tests/qemuxml2argvdata/pcihole64-q35.args | 1 +
tests/qemuxml2argvdata/pcihole64.args | 1 +
tests/qemuxml2argvdata/pmu-feature-off.args | 1 +
tests/qemuxml2argvdata/pmu-feature.args | 1 +
tests/qemuxml2argvdata/ppc-dtb.args | 1 +
.../ppc64-usb-controller-legacy.args | 1 +
.../ppc64-usb-controller-qemu-xhci.args | 1 +
.../ppc64-usb-controller.args | 1 +
tests/qemuxml2argvdata/ppce500-serial.args | 1 +
tests/qemuxml2argvdata/pseries-basic.args | 1 +
.../pseries-console-virtio.args | 1 +
.../pseries-cpu-compat-power9.args | 1 +
.../qemuxml2argvdata/pseries-cpu-compat.args | 1 +
tests/qemuxml2argvdata/pseries-cpu-exact.args | 1 +
tests/qemuxml2argvdata/pseries-cpu-le.args | 1 +
tests/qemuxml2argvdata/pseries-features.args | 1 +
.../qemuxml2argvdata/pseries-hostdevs-1.args | 1 +
.../qemuxml2argvdata/pseries-hostdevs-2.args | 1 +
.../qemuxml2argvdata/pseries-hostdevs-3.args | 1 +
.../pseries-machine-max-cpu-compat.args | 1 +
.../pseries-many-buses-1.args | 1 +
.../pseries-many-buses-2.args | 1 +
.../pseries-many-devices.args | 1 +
tests/qemuxml2argvdata/pseries-nvram.args | 1 +
.../pseries-panic-missing.args | 1 +
.../pseries-panic-no-address.args | 1 +
.../pseries-phb-default-missing.args | 1 +
.../pseries-phb-numa-node.args | 1 +
.../qemuxml2argvdata/pseries-phb-simple.args | 1 +
.../pseries-serial-native.args | 1 +
.../qemuxml2argvdata/pseries-serial-pci.args | 1 +
.../qemuxml2argvdata/pseries-serial-usb.args | 1 +
.../qemuxml2argvdata/pseries-usb-default.args | 1 +
tests/qemuxml2argvdata/pseries-usb-kbd.args | 1 +
tests/qemuxml2argvdata/pseries-usb-multi.args | 1 +
.../pseries-vio-user-assigned.args | 1 +
tests/qemuxml2argvdata/pseries-vio.args | 1 +
tests/qemuxml2argvdata/q35-acpi-nouefi.args | 1 +
tests/qemuxml2argvdata/q35-acpi-uefi.args | 1 +
.../q35-default-devices-only.args | 1 +
tests/qemuxml2argvdata/q35-multifunction.args | 1 +
tests/qemuxml2argvdata/q35-noacpi-nouefi.args | 1 +
.../q35-pci-force-address.args | 1 +
tests/qemuxml2argvdata/q35-pcie-autoadd.args | 1 +
tests/qemuxml2argvdata/q35-pcie.args | 1 +
.../q35-pm-disable-fallback.args | 1 +
tests/qemuxml2argvdata/q35-pm-disable.args | 1 +
tests/qemuxml2argvdata/q35-usb2-multi.args | 1 +
tests/qemuxml2argvdata/q35-usb2-reorder.args | 1 +
tests/qemuxml2argvdata/q35-usb2.args | 1 +
.../q35-virt-manager-basic.args | 1 +
tests/qemuxml2argvdata/q35-virtio-pci.args | 1 +
tests/qemuxml2argvdata/q35.args | 1 +
tests/qemuxml2argvdata/qemu-ns-alt.args | 1 +
.../qemu-ns-commandline-ns0.args | 1 +
.../qemu-ns-commandline-ns1.args | 1 +
.../qemuxml2argvdata/qemu-ns-commandline.args | 1 +
.../qemu-ns-domain-commandline-ns0.args | 1 +
.../qemu-ns-domain-commandline.args | 1 +
.../qemuxml2argvdata/qemu-ns-domain-ns0.args | 1 +
tests/qemuxml2argvdata/qemu-ns-no-env.args | 1 +
.../reboot-timeout-disabled.args | 1 +
.../reboot-timeout-enabled.args | 1 +
tests/qemuxml2argvdata/restore-v2-fd.args | 1 +
tests/qemuxml2argvdata/restore-v2.args | 1 +
tests/qemuxml2argvdata/riscv64-virt-pci.args | 1 +
tests/qemuxml2argvdata/riscv64-virt.args | 1 +
.../qemuxml2argvdata/s390-panic-missing.args | 1 +
.../s390-panic-no-address.args | 1 +
tests/qemuxml2argvdata/s390-serial-2.args | 1 +
.../qemuxml2argvdata/s390-serial-console.args | 1 +
tests/qemuxml2argvdata/s390-serial.args | 1 +
tests/qemuxml2argvdata/seclabel-dac-none.args | 1 +
.../seclabel-dynamic-baselabel.args | 1 +
.../seclabel-dynamic-labelskip.args | 1 +
.../seclabel-dynamic-override.args | 1 +
.../seclabel-dynamic-relabel.args | 1 +
tests/qemuxml2argvdata/seclabel-dynamic.args | 1 +
tests/qemuxml2argvdata/seclabel-none.args | 1 +
.../seclabel-static-labelskip.args | 1 +
.../seclabel-static-relabel.args | 1 +
tests/qemuxml2argvdata/seclabel-static.args | 1 +
.../serial-dev-chardev-iobase.args | 1 +
.../qemuxml2argvdata/serial-dev-chardev.args | 1 +
.../qemuxml2argvdata/serial-file-chardev.args | 1 +
tests/qemuxml2argvdata/serial-file-log.args | 1 +
.../qemuxml2argvdata/serial-many-chardev.args | 1 +
.../qemuxml2argvdata/serial-pty-chardev.args | 1 +
.../serial-spiceport-nospice.args | 1 +
tests/qemuxml2argvdata/serial-spiceport.args | 1 +
.../qemuxml2argvdata/serial-tcp-chardev.args | 1 +
.../serial-tcp-telnet-chardev.args | 1 +
.../serial-tcp-tlsx509-chardev-notls.args | 1 +
.../serial-tcp-tlsx509-chardev-verify.args | 1 +
.../serial-tcp-tlsx509-chardev.args | 1 +
.../qemuxml2argvdata/serial-udp-chardev.args | 1 +
.../qemuxml2argvdata/serial-unix-chardev.args | 1 +
tests/qemuxml2argvdata/serial-vc-chardev.args | 1 +
.../shmem-plain-doorbell.args | 1 +
tests/qemuxml2argvdata/shmem.args | 1 +
.../smartcard-controller.args | 1 +
.../smartcard-host-certificates-database.args | 1 +
.../smartcard-host-certificates.args | 1 +
tests/qemuxml2argvdata/smartcard-host.args | 1 +
.../smartcard-passthrough-spicevmc.args | 1 +
.../smartcard-passthrough-tcp.args | 1 +
tests/qemuxml2argvdata/smbios-type-fwcfg.args | 1 +
tests/qemuxml2argvdata/smbios.args | 1 +
tests/qemuxml2argvdata/smp-dies.args | 1 +
tests/qemuxml2argvdata/smp.args | 1 +
tests/qemuxml2argvdata/sound-device.args | 1 +
tests/qemuxml2argvdata/sound.args | 1 +
tests/qemuxml2argvdata/sparc-minimal.args | 1 +
.../usb-controller-default-q35.args | 1 +
.../usb-controller-explicit-q35.args | 1 +
.../usb-controller-qemu-xhci.args | 1 +
.../qemuxml2argvdata/usb-controller-xhci.args | 1 +
tests/qemuxml2argvdata/usb-controller.args | 1 +
.../usb-hub-autoadd-deluxe.args | 1 +
tests/qemuxml2argvdata/usb-hub-autoadd.args | 1 +
tests/qemuxml2argvdata/usb-hub.args | 1 +
.../qemuxml2argvdata/usb-ich9-autoassign.args | 1 +
.../qemuxml2argvdata/usb-ich9-companion.args | 1 +
.../qemuxml2argvdata/usb-ich9-ehci-addr.args | 1 +
.../qemuxml2argvdata/usb-long-port-path.args | 1 +
tests/qemuxml2argvdata/usb-none.args | 1 +
.../usb-piix3-controller.args | 1 +
.../qemuxml2argvdata/usb-port-autoassign.args | 1 +
tests/qemuxml2argvdata/usb-port-missing.args | 1 +
tests/qemuxml2argvdata/usb-ports.args | 1 +
tests/qemuxml2argvdata/usb-redir-boot.args | 1 +
.../usb-redir-filter-version.args | 1 +
tests/qemuxml2argvdata/usb-redir-filter.args | 1 +
tests/qemuxml2argvdata/usb-redir.args | 1 +
.../qemuxml2argvdata/usb-xhci-autoassign.args | 1 +
tests/qemuxml2argvdata/usb1-usb2.args | 1 +
tests/qemuxml2argvdata/user-aliases-usb.args | 1 +
.../vcpu-placement-static.args | 1 +
.../video-device-pciaddr-default.args | 1 +
tests/qemuxml2argvdata/video-none-device.args | 1 +
.../video-qxl-device-vgamem.args | 1 +
tests/qemuxml2argvdata/video-qxl-device.args | 1 +
tests/qemuxml2argvdata/video-qxl-heads.args | 1 +
tests/qemuxml2argvdata/video-qxl-noheads.args | 1 +
.../video-qxl-resolution.args | 1 +
.../video-qxl-sec-device-vgamem.args | 1 +
.../video-qxl-sec-device.args | 1 +
.../video-vga-device-vgamem.args | 1 +
tests/qemuxml2argvdata/video-vga-device.args | 1 +
.../qemuxml2argvdata/video-vga-qxl-heads.args | 1 +
.../video-virtio-gpu-ccw.args | 1 +
.../video-virtio-gpu-device.args | 1 +
.../video-virtio-gpu-sdl-gl.args | 1 +
.../video-virtio-gpu-secondary.args | 1 +
.../video-virtio-gpu-spice-gl.args | 1 +
.../video-virtio-gpu-virgl.args | 1 +
tests/qemuxml2argvdata/video-virtio-vga.args | 1 +
.../virtio-input-passthrough.args | 1 +
tests/qemuxml2argvdata/virtio-input.args | 1 +
tests/qemuxml2argvdata/virtio-lun.args | 1 +
tests/qemuxml2argvdata/virtio-rng-ccw.args | 1 +
.../qemuxml2argvdata/virtio-rng-default.args | 1 +
tests/qemuxml2argvdata/virtio-rng-egd.args | 1 +
.../qemuxml2argvdata/virtio-rng-multiple.args | 1 +
tests/qemuxml2argvdata/virtio-rng-random.args | 1 +
tests/qemuxml2argvdata/vmcoreinfo.args | 1 +
tests/qemuxml2argvdata/watchdog-device.args | 1 +
tests/qemuxml2argvdata/watchdog-dump.args | 1 +
.../qemuxml2argvdata/watchdog-injectnmi.args | 1 +
tests/qemuxml2argvdata/watchdog.args | 1 +
tests/qemuxml2argvdata/x86-kvm-32-on-64.args | 1 +
tests/qemuxml2argvtest.c | 23 +-
tests/vircryptotest.c | 5 -
611 files changed, 710 insertions(+), 591 deletions(-)
--
2.31.1
3 years, 2 months
- 2
- 13
Plans for the next release
by Jiri Denemark
We are getting close to the next release of libvirt. To aim for the
release on Oct 01 I suggest entering the freeze on Monday Sep 27 and
tagging RC2 on Wednesday Sep 29.
I hope this works for everyone.
Jirka
3 years, 2 months
- 1
- 0
[libvirt PATCH] scripts: apibuild: fix spacing
by Ján Tomko
Syntax check reports:
E226 missing whitespace around arithmetic operator
Signed-off-by: Ján Tomko <jtomko(a)redhat.com>
---
Pushed.
scripts/apibuild.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/apibuild.py b/scripts/apibuild.py
index 722fd33f0e..9b29466e1d 100755
--- a/scripts/apibuild.py
+++ b/scripts/apibuild.py
@@ -604,10 +604,10 @@ class CLexer:
continue
j = i
- while (j + 1) < nline and line[j+1] in "+-*><=/%&!|":
+ while (j + 1) < nline and line[j + 1] in "+-*><=/%&!|":
j = j + 1
- self.tokens.append(('op', line[i:j+1]))
+ self.tokens.append(('op', line[i:j + 1]))
i = j + 1
continue
s = i
--
2.31.1
3 years, 2 months
- 1
- 0
[libvirt PATCH] scripts: fix API parsing of *** pointers
by Daniel P. Berrangé
The currrent generated API contains *** pointer types with bogus
whitespace in the middle:
<arg name='keys' type='char ** *' info='pointer to a variable to store authorized keys'/>
because the tokenizer only tries to merge 2 distinct '*' together.
This refactors the code to merge an arbitrary number, resulting
in
<arg name='keys' type='char ***' info='pointer to a variable to store authorized keys'/>
Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com>
---
scripts/apibuild.py | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/scripts/apibuild.py b/scripts/apibuild.py
index b94c0f6c09..722fd33f0e 100755
--- a/scripts/apibuild.py
+++ b/scripts/apibuild.py
@@ -603,13 +603,12 @@ class CLexer:
i = i + 3
continue
- j = i + 1
- if j < nline and line[j] in "+-*><=/%&!|":
- self.tokens.append(('op', line[i:j + 1]))
- i = j + 1
- else:
- self.tokens.append(('op', line[i]))
- i = i + 1
+ j = i
+ while (j + 1) < nline and line[j+1] in "+-*><=/%&!|":
+ j = j + 1
+
+ self.tokens.append(('op', line[i:j+1]))
+ i = j + 1
continue
s = i
while i < nline:
--
2.31.1
3 years, 2 months
- 2
- 1
[PATCH v6 00/16] Introduce virtio-mem <memory/> model
by Michal Privoznik
v6 of:
https://listman.redhat.com/archives/libvir-list/2021-September/msg00333.html
diff to v5:
- Rebased onto current master
- Produce warning (in 05/16) when prealloc was requested for virtio-mem
(it's not officially supported by QEMU yet).
Special thanks goes to David Hildebrand for testing these patches and
giving valuable feedback.
Michal Prívozník (16):
virhostmem: Introduce virHostMemGetTHPSize()
qemu_capabilities: Introduce QEMU_CAPS_DEVICE_VIRTIO_MEM_PCI
qemu_capabilities: Introduce QEMU_CAPS_MEMORY_BACKEND_RESERVE
conf: Introduce virtio-mem <memory/> model
qemu: Build command line for virtio-mem
qemu: Wire up <memory/> live update
qemu: Wire up <memory/> offline update
Introduce <current/> property to virtio-mem
conf: Introduce virDomainMemoryFindByDeviceAlias()
qemu: Wire up MEMORY_DEVICE_SIZE_CHANGE event
qemu: Refresh the current size of virtio-mem on monitor reconnect
qemu: Account for both memballoon and virtio-mem
qemuDomainSetMemoryFlags: Take virtio-mem into consideration
virsh: Introduce update-memory-device command
news: document recent virtio memory addition
kbase: Document virtio-mem
NEWS.rst | 7 +
docs/formatdomain.rst | 45 ++-
docs/kbase/index.rst | 4 +
docs/kbase/memorydevices.rst | 150 ++++++++++
docs/kbase/meson.build | 1 +
docs/manpages/virsh.rst | 30 ++
docs/schemas/domaincommon.rng | 16 ++
examples/c/misc/event-test.c | 17 ++
include/libvirt/libvirt-domain.h | 24 ++
src/conf/domain_conf.c | 126 ++++++++-
src/conf/domain_conf.h | 16 ++
src/conf/domain_event.c | 84 ++++++
src/conf/domain_event.h | 10 +
src/conf/domain_validate.c | 39 +++
src/libvirt_private.syms | 5 +
src/qemu/qemu_alias.c | 10 +-
src/qemu/qemu_capabilities.c | 6 +
src/qemu/qemu_capabilities.h | 4 +
src/qemu/qemu_command.c | 29 +-
src/qemu/qemu_domain.c | 33 ++-
src/qemu/qemu_domain.h | 1 +
src/qemu/qemu_domain_address.c | 38 ++-
src/qemu/qemu_driver.c | 259 +++++++++++++++++-
src/qemu/qemu_hotplug.c | 18 ++
src/qemu/qemu_hotplug.h | 5 +
src/qemu/qemu_monitor.c | 34 +++
src/qemu/qemu_monitor.h | 28 ++
src/qemu/qemu_monitor_json.c | 97 +++++--
src/qemu/qemu_monitor_json.h | 5 +
src/qemu/qemu_process.c | 72 +++++
src/qemu/qemu_validate.c | 8 +
src/remote/remote_daemon_dispatch.c | 30 ++
src/remote/remote_driver.c | 32 +++
src/remote/remote_protocol.x | 15 +-
src/remote_protocol-structs | 7 +
src/security/security_apparmor.c | 1 +
src/security/security_dac.c | 2 +
src/security/security_selinux.c | 2 +
src/util/virhostmem.c | 54 ++++
src/util/virhostmem.h | 3 +
tests/domaincapsmock.c | 9 +
.../caps_5.1.0.x86_64.xml | 1 +
.../caps_5.2.0.x86_64.xml | 1 +
.../caps_6.0.0.x86_64.xml | 1 +
.../caps_6.1.0.x86_64.xml | 2 +
...mory-hotplug-virtio-mem.x86_64-latest.args | 41 +++
.../memory-hotplug-virtio-mem.xml | 67 +++++
tests/qemuxml2argvtest.c | 1 +
...emory-hotplug-virtio-mem.x86_64-latest.xml | 1 +
tests/qemuxml2xmltest.c | 1 +
tools/virsh-domain.c | 181 ++++++++++++
51 files changed, 1617 insertions(+), 56 deletions(-)
create mode 100644 docs/kbase/memorydevices.rst
create mode 100644 tests/qemuxml2argvdata/memory-hotplug-virtio-mem.x86_64-latest.args
create mode 100644 tests/qemuxml2argvdata/memory-hotplug-virtio-mem.xml
create mode 120000 tests/qemuxml2xmloutdata/memory-hotplug-virtio-mem.x86_64-latest.xml
--
2.32.0
3 years, 2 months
- 2
- 18
[PATCH 0/5] qemu: add virtio-blk queue-size option
by Hiroki Narukawa
This is resubmit of "qemu: add virtio-blk queue-size option" after following the review.
The option "queue-size" in virtio-blk was added in qemu-2.12.0, and default value increased from qemu-5.0.0.
However, increasing this value may lead to drop of random access performance.
This is configurable value, so we want to use it via libvirt.
Hiroki Narukawa (5):
qemu: Make disk-virtio-queues tests use DO_TEST_CAPS_LATEST
qemu: add disk queue count ABI stability check
qemu: add queue_size option to disk
qemu: add QEMU_CAPS_VIRTIO_BLK_QUEUE_SIZE capability
qemu: add virtio-blk queue-size option
docs/formatdomain.rst | 4 +-
docs/schemas/domaincommon.rng | 5 +++
src/conf/domain_conf.c | 20 ++++++++++
src/conf/domain_conf.h | 1 +
src/qemu/qemu_capabilities.c | 2 +
src/qemu/qemu_capabilities.h | 1 +
src/qemu/qemu_command.c | 3 ++
src/qemu/qemu_validate.c | 7 ++++
.../caps_2.12.0.aarch64.xml | 1 +
.../caps_2.12.0.ppc64.xml | 1 +
.../caps_2.12.0.s390x.xml | 1 +
.../caps_2.12.0.x86_64.xml | 1 +
.../qemucapabilitiesdata/caps_3.0.0.ppc64.xml | 1 +
.../qemucapabilitiesdata/caps_3.0.0.s390x.xml | 1 +
.../caps_3.0.0.x86_64.xml | 1 +
.../qemucapabilitiesdata/caps_3.1.0.ppc64.xml | 1 +
.../caps_3.1.0.x86_64.xml | 1 +
.../caps_4.0.0.aarch64.xml | 1 +
.../qemucapabilitiesdata/caps_4.0.0.ppc64.xml | 1 +
.../caps_4.0.0.riscv32.xml | 1 +
.../caps_4.0.0.riscv64.xml | 1 +
.../qemucapabilitiesdata/caps_4.0.0.s390x.xml | 1 +
.../caps_4.0.0.x86_64.xml | 1 +
.../caps_4.1.0.x86_64.xml | 1 +
.../caps_4.2.0.aarch64.xml | 1 +
.../qemucapabilitiesdata/caps_4.2.0.ppc64.xml | 1 +
.../qemucapabilitiesdata/caps_4.2.0.s390x.xml | 1 +
.../caps_4.2.0.x86_64.xml | 1 +
.../caps_5.0.0.aarch64.xml | 1 +
.../qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 1 +
.../caps_5.0.0.riscv64.xml | 1 +
.../caps_5.0.0.x86_64.xml | 1 +
.../caps_5.1.0.x86_64.xml | 1 +
.../caps_5.2.0.aarch64.xml | 1 +
.../qemucapabilitiesdata/caps_5.2.0.ppc64.xml | 1 +
.../caps_5.2.0.riscv64.xml | 1 +
.../qemucapabilitiesdata/caps_5.2.0.s390x.xml | 1 +
.../caps_5.2.0.x86_64.xml | 1 +
.../caps_6.0.0.aarch64.xml | 1 +
.../qemucapabilitiesdata/caps_6.0.0.s390x.xml | 1 +
.../caps_6.0.0.x86_64.xml | 1 +
.../caps_6.1.0.x86_64.xml | 1 +
.../disk-virtio-queue-size.args | 35 +++++++++++++++++
.../disk-virtio-queue-size.x86_64-latest.args | 35 +++++++++++++++++
.../disk-virtio-queue-size.xml | 38 +++++++++++++++++++
.../qemuxml2argvdata/disk-virtio-queues.args | 20 ++++++----
.../disk-virtio-queues.x86_64-latest.args | 35 +++++++++++++++++
tests/qemuxml2argvdata/disk-virtio-queues.xml | 5 ++-
tests/qemuxml2argvtest.c | 4 +-
.../disk-virtio-queue-size.x86_64-latest.xml | 38 +++++++++++++++++++
.../disk-virtio-queue-size.xml | 35 +++++++++++++++++
.../disk-virtio-queues.x86_64-latest.xml | 1 +
tests/qemuxml2xmltest.c | 3 +-
53 files changed, 314 insertions(+), 12 deletions(-)
create mode 100644 tests/qemuxml2argvdata/disk-virtio-queue-size.args
create mode 100644 tests/qemuxml2argvdata/disk-virtio-queue-size.x86_64-latest.args
create mode 100644 tests/qemuxml2argvdata/disk-virtio-queue-size.xml
create mode 100644 tests/qemuxml2argvdata/disk-virtio-queues.x86_64-latest.args
create mode 100644 tests/qemuxml2xmloutdata/disk-virtio-queue-size.x86_64-latest.xml
create mode 100644 tests/qemuxml2xmloutdata/disk-virtio-queue-size.xml
create mode 120000 tests/qemuxml2xmloutdata/disk-virtio-queues.x86_64-latest.xml
--
2.17.1
3 years, 2 months
- 2
- 11