April 2021 - Devel - libvirt List Archives

[PATCH v2] qemu: Expose disk serial in virDomainGetGuestInfo()
by Michal Privoznik 14 Apr '21

14 Apr '21

When querying guest info via virDomainGetGuestInfo() the 'guest-get-disks' agent command is called. It may report disk serial number which we parse, but never report nor use for anything else. As it turns out, it may help management application find matching disk in their internals. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- v2 of: https://listman.redhat.com/archives/libvir-list/2021-April/msg00552.html diff to v1: - Filled virsh documentation - Documented that the param is optional and type of string docs/manpages/virsh.rst | 1 + src/libvirt-domain.c | 1 + src/qemu/qemu_driver.c | 19 ++++++++++++++----- 3 files changed, 16 insertions(+), 5 deletions(-) diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst index 813fb0bd60..bccda292a2 100644 --- a/docs/manpages/virsh.rst +++ b/docs/manpages/virsh.rst @@ -2787,6 +2787,7 @@ returned: * ``disk.<num>.partition`` - whether this is a partition or disk * ``disk.<num>.dependency.count`` - the number of device dependencies * ``disk.<num>.dependency.<num>.name`` - a dependency name +* ``disk.<num>.serial`` - optional disk serial number * ``disk.<num>.alias`` - the device alias of the disk (e.g. sda) * ``disk.<num>.guest_alias`` - optional alias assigned to the disk diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 83ff7df9fe..509b7a6d88 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -12561,6 +12561,7 @@ virDomainSetVcpu(virDomainPtr domain, * hold the list of PVs, for LUKS encrypted volume this will * contain the disk where the volume is placed. (Linux) * "disk.<num>.dependency.<num>.name" - a dependency + * "disk.<num>.serial" - optional disk serial number (as string) * "disk.<num>.alias" - the device alias of the disk (e.g. sda) * "disk.<num>.guest_alias" - optional alias assigned to the disk, on Linux * this is a name assigned by device mapper diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 90b5477f00..88ee9e5d5e 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -19951,15 +19951,24 @@ qemuAgentDiskInfoFormatParams(qemuAgentDiskInfo **info, } if (info[i]->address) { + qemuAgentDiskAddress *address = info[i]->address; virDomainDiskDef *diskdef = NULL; + if (address->serial) { + g_snprintf(param_name, VIR_TYPED_PARAM_FIELD_LENGTH, + "disk.%zu.serial", i); + if (virTypedParamsAddString(params, nparams, maxparams, + param_name, address->serial) < 0) + return; + } + /* match the disk to the target in the vm definition */ diskdef = virDomainDiskByAddress(vmdef, - &info[i]->address->pci_controller, - info[i]->address->ccw_addr, - info[i]->address->bus, - info[i]->address->target, - info[i]->address->unit); + &address->pci_controller, + address->ccw_addr, + address->bus, + address->target, + address->unit); if (diskdef) { g_snprintf(param_name, VIR_TYPED_PARAM_FIELD_LENGTH, "disk.%zu.alias", i); -- 2.26.3

3 2

[PATCH] qemu: Expose disk serial in virDomainGetGuestInfo()
by Michal Privoznik 14 Apr '21

14 Apr '21

When querying guest info via virDomainGetGuestInfo() the 'guest-get-disks' agent command is called. It may report disk serial number which we parse, but never report nor use for anything else. As it turns out, it may help management application find matching disk in their internals. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/libvirt-domain.c | 1 + src/qemu/qemu_driver.c | 19 ++++++++++++++----- 2 files changed, 15 insertions(+), 5 deletions(-) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 83ff7df9fe..1c244da650 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -12561,6 +12561,7 @@ virDomainSetVcpu(virDomainPtr domain, * hold the list of PVs, for LUKS encrypted volume this will * contain the disk where the volume is placed. (Linux) * "disk.<num>.dependency.<num>.name" - a dependency + * "disk.<num>.serial" - disk serial number * "disk.<num>.alias" - the device alias of the disk (e.g. sda) * "disk.<num>.guest_alias" - optional alias assigned to the disk, on Linux * this is a name assigned by device mapper diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 90b5477f00..88ee9e5d5e 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -19951,15 +19951,24 @@ qemuAgentDiskInfoFormatParams(qemuAgentDiskInfo **info, } if (info[i]->address) { + qemuAgentDiskAddress *address = info[i]->address; virDomainDiskDef *diskdef = NULL; + if (address->serial) { + g_snprintf(param_name, VIR_TYPED_PARAM_FIELD_LENGTH, + "disk.%zu.serial", i); + if (virTypedParamsAddString(params, nparams, maxparams, + param_name, address->serial) < 0) + return; + } + /* match the disk to the target in the vm definition */ diskdef = virDomainDiskByAddress(vmdef, - &info[i]->address->pci_controller, - info[i]->address->ccw_addr, - info[i]->address->bus, - info[i]->address->target, - info[i]->address->unit); + &address->pci_controller, + address->ccw_addr, + address->bus, + address->target, + address->unit); if (diskdef) { g_snprintf(param_name, VIR_TYPED_PARAM_FIELD_LENGTH, "disk.%zu.alias", i); -- 2.26.3

2 2

[PATCH 00/15] news update since v6.9 to v7.0
by Han Han 14 Apr '21

14 Apr '21

Han Han (15): news: make SEV attrs 'cbitpos' & 'reducedPhysBits' optional news: support device stats collection for SR-IOV VF hostdev news: virt-aa-helper: allow guest to create hard links for mounted paths news: cpu_map: Add EPYC-Rome cpu model news: cpu: Support for XML validation in cpu comparison news: logging: allow max_len=0 to disable log rollover news: qemu: Set noqueue qdisc for TAP devices news: qemu: Introduce virtio free page reporting feature news: qemu: virtiofs can be used without NUMA nodes news: qemu: Add 'fmode' and 'dmode' options for 9pfs news: Introduce VIR_DOMAIN_CHECKPOINT_REDEFINE_VALIDATE flag news: Introduce "migrate_tls_force" qemu.conf option news: qemu: support kvm-poll-control performance hint news: cpu_map: Add Snowridge cpu model news: qemu: Add support for NFS disk protocol NEWS.rst | 79 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 79 insertions(+) -- 2.31.1

3 22

[PATCH] libxl: Add debug statements
by Jim Fehlig 14 Apr '21

14 Apr '21

Over several years of debugging reports related to VM shutdown, destruction, and cleanup, I've found that logging of all events received from libxl and logging the entry of libxlDomainCleanup has proven useful. Add the these debug messages upstream to aid in future debugging. Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- src/libxl/libxl_domain.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c index a25d65629a..917f6f1d81 100644 --- a/src/libxl/libxl_domain.c +++ b/src/libxl/libxl_domain.c @@ -648,6 +648,8 @@ libxlDomainEventHandler(void *data, VIR_LIBXL_EVENT_CONST libxl_event *event) virDomainObj *vm = NULL; g_autoptr(libxlDriverConfig) cfg = NULL; + VIR_DEBUG("Received libxl event '%d' for domid '%d'", event->type, event->domid); + if (event->type != LIBXL_EVENT_TYPE_DOMAIN_SHUTDOWN && event->type != LIBXL_EVENT_TYPE_DOMAIN_DEATH) { VIR_INFO("Unhandled event type %d", event->type); @@ -844,6 +846,9 @@ libxlDomainCleanup(libxlDriverPrivate *driver, unsigned int hostdev_flags = VIR_HOSTDEV_SP_PCI; g_autoptr(virConnect) conn = NULL; + VIR_DEBUG("Cleaning up domain with id '%d' and name '%s'", + vm->def->id, vm->def->name); + #ifdef LIBXL_HAVE_PVUSB hostdev_flags |= VIR_HOSTDEV_SP_USB; #endif -- 2.30.2

2 1

[libvirt PATCH 0/2] fix cgroups BPF FDs leak
by Pavel Hrdina 14 Apr '21

14 Apr '21

Pavel Hrdina (2): vircgroupv2: properly free BPF prog and map FDs vircgroupv2devices: refactor virCgroupV2DevicesRemoveProg src/libvirt_private.syms | 2 +- src/util/vircgroupv2.c | 3 ++- src/util/vircgroupv2devices.c | 14 ++++---------- src/util/vircgroupv2devices.h | 2 +- 4 files changed, 8 insertions(+), 13 deletions(-) -- 2.30.2

3 4

[libvirt PATCH 1/3] nodedev: remove unnecessary null check
by Jonathon Jongsma 14 Apr '21

14 Apr '21

g_strdup_printf() is guaranteed to return a non-NULL value, so remove the unnecessary check for NULL. Signed-off-by: Jonathon Jongsma <jjongsma(a)redhat.com> --- src/util/virmdev.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/util/virmdev.c b/src/util/virmdev.c index 7f4a499536..102eb2bf67 100644 --- a/src/util/virmdev.c +++ b/src/util/virmdev.c @@ -208,9 +208,6 @@ virMediatedDeviceGetIOMMUGroupDev(const char *uuidstr) g_autofree char *iommu_path = NULL; g_autofree char *dev_path = virMediatedDeviceGetSysfsPath(uuidstr); - if (!dev_path) - return NULL; - iommu_path = g_strdup_printf("%s/iommu_group", dev_path); if (!virFileExists(iommu_path)) { -- 2.26.3

3 6

[PATCH v2 0/3] nodedev: Follow up fixes
by Michal Privoznik 14 Apr '21

14 Apr '21

This is a v2 of: https://listman.redhat.com/archives/libvir-list/2021-April/msg00478.html Patches that were reviewed in v1 are merged. The rest is reworked per Erik's suggestions. Michal Prívozník (3): nodedev: Wait for device initialization in all public API callbacks nodedev: Mark device initialization complete even in case of an error nodedev: Don't fail device enumeration if MDEVCTL is missing src/node_device/node_device_driver.c | 24 ++++++++++++++++++++++++ src/node_device/node_device_udev.c | 3 +++ 2 files changed, 27 insertions(+) -- 2.26.3

2 6

[PATCH 0/6] nodedev: Follow up fixes
by Michal Privoznik 14 Apr '21

14 Apr '21

Yesterday I've posted patches that allowed me to start the daemon. But today I tried listing some nodedevs. It uncovered some dormant bugs we had (e.g. 3/6 and 5/6) and one new (6/6). Michal Prívozník (6): nodedev: Rename nodeDeviceWaitInit() nodedev: Wait for device initialization in nodeDeviceCreate() nodedev: Signal initCond with driver locked nodedev: Introduce nodeDeviceInitComplete() nodedev: Mark device initialization complete even in case of an error nodedev: Don't fail device enumeration if MDEVCTL is missing src/node_device/node_device_driver.c | 47 +++++++++++++++++++++------- src/node_device/node_device_driver.h | 2 ++ src/node_device/node_device_udev.c | 7 ++--- 3 files changed, 40 insertions(+), 16 deletions(-) -- 2.26.3

2 15

[PATCH 00/10] To make <transient/> disk sharable for qemu
by Masayoshi Mizuma 14 Apr '21

14 Apr '21

This patch series has two parts; the first part is trying to support for hotplugging disks with <transient/> option for qemu, and make the disk shareable when <shareable/> disk option is set as well. The second part is trying to make shareable the disks with <transient/> disk option which is described on the domain xml. The second part is marked as Work In Progress (WIP) because the design may be modified by the first part changes. Reference: - RFC PATCH: https://listman.redhat.com/archives/libvir-list/2021-January/msg01035.html Masayoshi Mizuma (10): qemu_hotplug: Add transient disk hotplug support qemu_hotplug: make transient disk sharable virsh: Add transient flag for disk hotplug tests/qemuhotplugtest: Add qemu caps flags to the argument of DO_TEST tests/qemumonitortestutils: Add JobStatusChange to update progress of blockdev-create tests/qemuhotplugtest: Add transient disk hotplug test WIP: qemu_snapshot: Add the guest name to the transient disk path WIP: qemu_hotplug: Add asynJob to disk hotplug utilities WIP: qemu_hotplug: make transient disk sharable WIP: tests/qemuxml2argvdata: Add shareable transient disk test src/qemu/qemu_command.c | 11 + src/qemu/qemu_hotplug.c | 262 ++++++++++++++++-- src/qemu/qemu_hotplug.h | 3 + src/qemu/qemu_process.c | 23 +- src/qemu/qemu_process.h | 7 + src/qemu/qemu_snapshot.c | 12 +- src/qemu/qemu_validate.c | 21 +- tests/qemuhotplugtest.c | 199 ++++++++----- .../qemuhotplug-disk-scsi-transient.xml | 7 + .../qemuhotplug-disk-virtio-transient.xml | 7 + ...lug-transient-live+disk-scsi-transient.xml | 65 +++++ ...g-transient-live+disk-virtio-transient.xml | 65 +++++ .../qemuhotplug-transient-live.xml | 51 ++++ tests/qemumonitortestutils.c | 22 +- ...isk-transient-shareable.x86_64-latest.args | 41 +++ .../disk-transient-shareable.xml | 26 ++ tests/qemuxml2argvtest.c | 1 + tools/virsh-domain.c | 8 + 18 files changed, 738 insertions(+), 93 deletions(-) create mode 100644 tests/qemuhotplugtestdevices/qemuhotplug-disk-scsi-transient.xml create mode 100644 tests/qemuhotplugtestdevices/qemuhotplug-disk-virtio-transient.xml create mode 100644 tests/qemuhotplugtestdomains/qemuhotplug-transient-live+disk-scsi-transient.xml create mode 100644 tests/qemuhotplugtestdomains/qemuhotplug-transient-live+disk-virtio-transient.xml create mode 100644 tests/qemuhotplugtestdomains/qemuhotplug-transient-live.xml create mode 100644 tests/qemuxml2argvdata/disk-transient-shareable.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/disk-transient-shareable.xml -- 2.27.0

2 12

[PATCH resend] lib: Drop internal virXXXPtr typedefs
by Michal Privoznik 13 Apr '21

13 Apr '21

2 2