April 2021 - Devel - libvirt List Archives

[PATCH resend] lib: Drop internal virXXXPtr typedefs
by Michal Privoznik 13 Apr '21

13 Apr '21

2 2

[PATCH resend] virfile: Replace AbsPath judgement method with g_path_is_absolute()
by Luke Yue 13 Apr '21

13 Apr '21

The g_path_is_absolute() considers more situations than just a simply "path[0] == '/'". Related issue: https://gitlab.com/libvirt/libvirt/-/issues/12 Signed-off-by: Luke Yue <lukedyue(a)gmail.com> --- src/util/virfile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virfile.c b/src/util/virfile.c index 93fac200cc..3311eaff3d 100644 --- a/src/util/virfile.c +++ b/src/util/virfile.c @@ -3153,7 +3153,7 @@ virFileOpenTty(int *ttyprimary G_GNUC_UNUSED, int virFileAbsPath(const char *path, char **abspath) { - if (path[0] == '/') { + if (g_path_is_absolute(path)) { *abspath = g_strdup(path); } else { g_autofree char *buf = g_get_current_dir(); -- 2.31.1

2 4

[libvirt PATCH] qemu_conf: properly set 'deprecation_behavior' default value
by Pavel Hrdina 13 Apr '21

13 Apr '21

The comment for that option states that the default value is 'none' but it was not set by the code. Fixes: 700450449377be4bf923e91d00f8fe8cf0975f66 Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- src/qemu/qemu_conf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index 77fd7f6df7..68b086be54 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu/qemu_conf.c @@ -295,6 +295,8 @@ virQEMUDriverConfigPtr virQEMUDriverConfigNew(bool privileged, &cfg->nfirmwares) < 0) return NULL; + cfg->deprecationBehavior = g_strdup("none"); + return g_steal_pointer(&cfg); } -- 2.30.2

3 7

[libvirt PATCH v2] Remove references to deleted Makefile.am
by Tim Wiederhake 13 Apr '21

13 Apr '21

Signed-off-by: Tim Wiederhake <twiederh(a)redhat.com> Reviewed-by: Pavel Hrdina <phrdina(a)redhat.com> --- src/admin/libvirt_admin_private.syms | 2 +- src/libvirt_private.syms | 2 +- src/libvirt_remote.syms | 2 +- src/vbox/vbox_tmpl.c | 4 ---- tests/testutils.h | 4 ++-- tools/wireshark/README.rst | 3 +-- 6 files changed, 6 insertions(+), 11 deletions(-) diff --git a/src/admin/libvirt_admin_private.syms b/src/admin/libvirt_admin_private.syms index 157a45341e..d9f38a7155 100644 --- a/src/admin/libvirt_admin_private.syms +++ b/src/admin/libvirt_admin_private.syms @@ -1,6 +1,6 @@ # # General private symbols for libvirt_admin. Add symbols here, and see -# Makefile.am for more details. +# src/admin/meson.build for more details. # # Keep this file sorted by header name, then by symbols with each header. # diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 119768496b..b3f9c9681a 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -1,5 +1,5 @@ # -# General private symbols. Add symbols here, and see Makefile.am for +# General private symbols. Add symbols here, and see src/meson.build for # more details. # # Keep this file sorted by header name, then by symbols with each header. diff --git a/src/libvirt_remote.syms b/src/libvirt_remote.syms index 605271bcb2..11c9e2cb73 100644 --- a/src/libvirt_remote.syms +++ b/src/libvirt_remote.syms @@ -1,6 +1,6 @@ # # Private symbols used in RPC operations. Add symbols here, and see -# Makefile.am for more details. +# src/remote/meson.build for more details. # # Keep this file sorted by header name, then by symbols with each header. # diff --git a/src/vbox/vbox_tmpl.c b/src/vbox/vbox_tmpl.c index d37ffd9a6b..182d4c6b75 100644 --- a/src/vbox/vbox_tmpl.c +++ b/src/vbox/vbox_tmpl.c @@ -1,10 +1,6 @@ /** @file vbox_tmpl.c * Template File to support multiple versions of VirtualBox * at runtime :). - * - * IMPORTANT: - * Please dont include this file in the src/Makefile.am, it - * is automatically include by other files. */ /* diff --git a/tests/testutils.h b/tests/testutils.h index da8ca2dea5..36154e7077 100644 --- a/tests/testutils.h +++ b/tests/testutils.h @@ -30,9 +30,9 @@ #define EXIT_AM_SKIP 77 /* tell Automake we're skipping a test */ #define EXIT_AM_HARDFAIL 99 /* tell Automake that the framework is broken */ -/* Makefile.am provides these two definitions */ +/* Meson provides these two definitions */ #if !defined(abs_srcdir) || !defined(abs_builddir) -# error Fix Makefile.am +# error Fix build system #endif extern virArch virTestHostArch; diff --git a/tools/wireshark/README.rst b/tools/wireshark/README.rst index 8407557748..48296a11ce 100644 --- a/tools/wireshark/README.rst +++ b/tools/wireshark/README.rst @@ -24,8 +24,7 @@ Then dissector will compiled with libvirt itself. Add/Remove protocol from dissector's support -------------------------------------------- -Modify variable ``WS_DISSECTOR_PROTO_FILES`` -in ``tools/wireshark/src/Makefile.am``. +Modify argument ``input`` in ``tools/wireshark/src/libvirt/meson.build``. Changing installation directory ------------------------------- -- 2.26.2

2 1

[libvirt PATCH 00/11] Some additional cleanups to mdev support
by Jonathon Jongsma 13 Apr '21

13 Apr '21

Erik recommended several changes to the mdev series that was just merged and suggested to address them in a follow-up patch series. They're mostly related to simplifying the testing, and shouldn't actually change any behavior (aside from switching to using the long commandline options when executing mdevctl). Erik Skultety (4): nodedev: driver: Swap virMdevctlStart and virMdevctlCreate nodedev: driver: Introduce internal mdevctl commands enum nodedev: driver: Create a generic mdevctl command translator tests: nodedev: Make the mdevctl test function and helper generic Jonathon Jongsma (7): nodedev: don't log error in nodeDeviceFindAddressByName() nodedev: avoid use of VIR_ERR_NO_* errors internally tests: nodedev: switch all test macros to accept a filename nodedev: Switch to using long options for mdevctl nodedev: Remove GetMdevctl*Command() wrappers tests: nodedev: simplify test macros tests: nodedev: remove unused variable src/node_device/node_device_driver.c | 181 ++++++++--------- src/node_device/node_device_driver.h | 43 ++-- ...19_36ea_4111_8f0a_8c9a70e21366-create.argv | 2 + ...9_36ea_4111_8f0a_8c9a70e21366-create.json} | 0 ...19_36ea_4111_8f0a_8c9a70e21366-define.argv | 2 +- ...019_36ea_4111_8f0a_8c9a70e21366-start.argv | 3 +- ...d019_36ea_4111_8f0a_8c9a70e21366-stop.argv | 1 + ..._36ea_4111_8f0a_8c9a70e21366-undefine.argv | 1 + ...39_495e_4243_ad9f_beb3f14c23d9-create.argv | 1 + ...9_495e_4243_ad9f_beb3f14c23d9-create.json} | 0 ...39_495e_4243_ad9f_beb3f14c23d9-define.argv | 2 +- ...d39_495e_4243_ad9f_beb3f14c23d9-start.argv | 1 - ...16_1ca8_49ac_b176_871d16c13076-create.argv | 1 + ...6_1ca8_49ac_b176_871d16c13076-create.json} | 0 ...16_1ca8_49ac_b176_871d16c13076-define.argv | 2 +- ...916_1ca8_49ac_b176_871d16c13076-start.argv | 1 - tests/nodedevmdevctldata/mdevctl-create.argv | 1 - tests/nodedevmdevctldata/mdevctl-stop.argv | 1 - .../nodedevmdevctldata/mdevctl-undefine.argv | 1 - tests/nodedevmdevctltest.c | 192 ++++++------------ 20 files changed, 174 insertions(+), 262 deletions(-) create mode 100644 tests/nodedevmdevctldata/mdev_d069d019_36ea_4111_8f0a_8c9= a70e21366-create.argv rename tests/nodedevmdevctldata/{mdev_d069d019_36ea_4111_8f0a_8c9a70e21366-s= tart.json =3D> mdev_d069d019_36ea_4111_8f0a_8c9a70e21366-create.json} (100%) create mode 100644 tests/nodedevmdevctldata/mdev_d069d019_36ea_4111_8f0a_8c9= a70e21366-stop.argv create mode 100644 tests/nodedevmdevctldata/mdev_d069d019_36ea_4111_8f0a_8c9= a70e21366-undefine.argv create mode 100644 tests/nodedevmdevctldata/mdev_d2441d39_495e_4243_ad9f_beb= 3f14c23d9-create.argv rename tests/nodedevmdevctldata/{mdev_d2441d39_495e_4243_ad9f_beb3f14c23d9-s= tart.json =3D> mdev_d2441d39_495e_4243_ad9f_beb3f14c23d9-create.json} (100%) delete mode 100644 tests/nodedevmdevctldata/mdev_d2441d39_495e_4243_ad9f_beb= 3f14c23d9-start.argv create mode 100644 tests/nodedevmdevctldata/mdev_fedc4916_1ca8_49ac_b176_871= d16c13076-create.argv rename tests/nodedevmdevctldata/{mdev_fedc4916_1ca8_49ac_b176_871d16c13076-s= tart.json =3D> mdev_fedc4916_1ca8_49ac_b176_871d16c13076-create.json} (100%) delete mode 100644 tests/nodedevmdevctldata/mdev_fedc4916_1ca8_49ac_b176_871= d16c13076-start.argv delete mode 100644 tests/nodedevmdevctldata/mdevctl-create.argv delete mode 100644 tests/nodedevmdevctldata/mdevctl-stop.argv delete mode 100644 tests/nodedevmdevctldata/mdevctl-undefine.argv --=20 2.26.3

2 12

[libvirt PATCH v2] hyperv: Handle long CPU models better.
by Dawid Zamirski 13 Apr '21

13 Apr '21

The existing driver code strips down CPU model strings returned by Hyper-V hosts so they fit into the 32 character limit of the virNodeInfo.model field. However, this did not work well for my AMD CPU for which Hyper-V returns the string "AMD FX(tm)-8350 Eight-Core Processor". Therefore, this patch improves that code block to be case insensitive (so that the "(tm)" part is removed) and additionally removes the trailing " Processor" suffix. While this change alone worked for me, I have also added a line to terminate the stripped down string at 32nd character to make sure that any other CPU string we did not come across yet won't trigger the error - the virNodeInfo has other useful info that is arguably more important than CPU model string, e.g. core count, or memory size Signed-off-by: Dawid Zamirski <dzrudy(a)gmail.com> Reviewed-by: Neal Gompa <ngompa13(a)gmail.com> --- Changes since v1: * Added missing Signed-off-by * Add Reviewed-by * Reworded commit message src/hyperv/hyperv_driver.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 17f5be1f0d..6e03aa4f18 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src/hyperv/hyperv_driver.c @@ -1948,14 +1948,14 @@ hypervNodeGetInfo(virConnectPtr conn, virNodeInfoPtr info) if (STRPREFIX(tmp, " ")) { memmove(tmp, tmp + 1, strlen(tmp + 1) + 1); continue; - } else if (STRPREFIX(tmp, "(R)") || STRPREFIX(tmp, "(C)")) { + } else if (STRCASEPREFIX(tmp, "(R)") || STRCASEPREFIX(tmp, "(C)")) { memmove(tmp, tmp + 3, strlen(tmp + 3) + 1); continue; - } else if (STRPREFIX(tmp, "(TM)")) { + } else if (STRCASEPREFIX(tmp, "(TM)")) { memmove(tmp, tmp + 4, strlen(tmp + 4) + 1); continue; - } else if (STRPREFIX(tmp, " @ ")) { - /* Remove " @ X.YZGHz" from the end. */ + } else if (STRPREFIX(tmp, " @ ") || STRPREFIX(tmp, " Processor")) { + /* Remove " @ X.YZGHz" or " Processor" from the end. */ *tmp = '\0'; break; } @@ -1963,13 +1963,12 @@ hypervNodeGetInfo(virConnectPtr conn, virNodeInfoPtr info) ++tmp; } + /* trim whatever is left to 32 characters - better this than nothing */ + processorList->data->Name[31] = '\0'; + /* Fill struct */ - if (virStrcpyStatic(info->model, processorList->data->Name) < 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, - _("CPU model %s too long for destination"), - processorList->data->Name); + if (virStrcpyStatic(info->model, processorList->data->Name) < 0) return -1; - } info->memory = computerSystem->data->TotalPhysicalMemory / 1024; /* byte to kilobyte */ info->mhz = processorList->data->MaxClockSpeed; -- 2.31.1

1 0

[libvirt PATCH] Remove references to deleted Makefile.am
by Tim Wiederhake 12 Apr '21

12 Apr '21

Signed-off-by: Tim Wiederhake <twiederh(a)redhat.com> --- src/admin/libvirt_admin_private.syms | 2 +- src/libvirt_private.syms | 2 +- src/libvirt_remote.syms | 2 +- src/vbox/vbox_tmpl.c | 4 ---- tests/testutils.h | 4 ++-- tools/wireshark/README.rst | 3 +-- 6 files changed, 6 insertions(+), 11 deletions(-) diff --git a/src/admin/libvirt_admin_private.syms b/src/admin/libvirt_admin_private.syms index 157a45341e..d9f38a7155 100644 --- a/src/admin/libvirt_admin_private.syms +++ b/src/admin/libvirt_admin_private.syms @@ -1,6 +1,6 @@ # # General private symbols for libvirt_admin. Add symbols here, and see -# Makefile.am for more details. +# src/admin/meson.build for more details. # # Keep this file sorted by header name, then by symbols with each header. # diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index cb9fe7c80a..123357b761 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -1,5 +1,5 @@ # -# General private symbols. Add symbols here, and see Makefile.am for +# General private symbols. Add symbols here, and see src/meson.build for # more details. # # Keep this file sorted by header name, then by symbols with each header. diff --git a/src/libvirt_remote.syms b/src/libvirt_remote.syms index 605271bcb2..11c9e2cb73 100644 --- a/src/libvirt_remote.syms +++ b/src/libvirt_remote.syms @@ -1,6 +1,6 @@ # # Private symbols used in RPC operations. Add symbols here, and see -# Makefile.am for more details. +# src/remote/meson.build for more details. # # Keep this file sorted by header name, then by symbols with each header. # diff --git a/src/vbox/vbox_tmpl.c b/src/vbox/vbox_tmpl.c index d37ffd9a6b..182d4c6b75 100644 --- a/src/vbox/vbox_tmpl.c +++ b/src/vbox/vbox_tmpl.c @@ -1,10 +1,6 @@ /** @file vbox_tmpl.c * Template File to support multiple versions of VirtualBox * at runtime :). - * - * IMPORTANT: - * Please dont include this file in the src/Makefile.am, it - * is automatically include by other files. */ /* diff --git a/tests/testutils.h b/tests/testutils.h index ff5c98a078..482a6bdc0e 100644 --- a/tests/testutils.h +++ b/tests/testutils.h @@ -30,9 +30,9 @@ #define EXIT_AM_SKIP 77 /* tell Automake we're skipping a test */ #define EXIT_AM_HARDFAIL 99 /* tell Automake that the framework is broken */ -/* Makefile.am provides these two definitions */ +/* Meson provides these two definitions */ #if !defined(abs_srcdir) || !defined(abs_builddir) -# error Fix Makefile.am +# error Fix build system #endif extern virArch virTestHostArch; diff --git a/tools/wireshark/README.rst b/tools/wireshark/README.rst index 8407557748..644818fb85 100644 --- a/tools/wireshark/README.rst +++ b/tools/wireshark/README.rst @@ -24,8 +24,7 @@ Then dissector will compiled with libvirt itself. Add/Remove protocol from dissector's support -------------------------------------------- -Modify variable ``WS_DISSECTOR_PROTO_FILES`` -in ``tools/wireshark/src/Makefile.am``. +Modify variable ``input`` in ``tools/wireshark/src/libvirt/meson.build``. Changing installation directory ------------------------------- -- 2.26.2

2 1

[PATCH 0/2] qemu: blockjob: Fix two issues with block pull job finishing
by Peter Krempa 12 Apr '21

12 Apr '21

Peter Krempa (2): qemuBlockJobProcessEventCompletedPull: Avoid dangling pointer after blockpull qemuBlockJobProcessEventCompletedPull: Add backingStore terminators if base is NULL src/qemu/qemu_blockjob.c | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) -- 2.30.2

2 4

[PATCH 0/5] nodedev: Couple of fixes after last mdevctl patches
by Michal Privoznik 12 Apr '21

12 Apr '21

Recently, the nodedev driver gained ability to define (some type of) devices. However, it uncovered some dormant bugs we had (patches 2/5 and 3/5) and also introduced some (patches 1/5 and 5/5). I've came across these problems because I don't have /etc/mdevctl.d on my machine. Michal Prívozník (5): nodedev: Unlock @priv if initialization of mdevctlMonitors fails nodedev: Lock @priv sooner nodedev: Don't join not spawned threads nodedev: Separate mdevctl monitor setup into a function nodedev: Only set up mdevctl monitors if mdevctl.d exist src/node_device/node_device_udev.c | 75 ++++++++++++++++++++---------- 1 file changed, 51 insertions(+), 24 deletions(-) -- 2.26.3

2 7

[PATCH] bhyve: Fix declaration of 'params' in 'bhyveParsePCIFbuf'
by Peter Krempa 12 Apr '21

12 Apr '21

In commit ad80bba90a3 I've mistakenly didn't delete '**' from the variable declaration when converting it to 'GStrv' Fixes: ad80bba90a3 Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- The patch will be pushed under the build-breaker and trivial rules once the pipeline passes: https://gitlab.com/pipo.sk/libvirt/-/pipelines/285158773 src/bhyve/bhyve_parse_command.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bhyve/bhyve_parse_command.c b/src/bhyve/bhyve_parse_command.c index d86d37b697..2783119a7b 100644 --- a/src/bhyve/bhyve_parse_command.c +++ b/src/bhyve/bhyve_parse_command.c @@ -558,7 +558,7 @@ bhyveParsePCIFbuf(virDomainDefPtr def, virDomainVideoDefPtr video = NULL; virDomainGraphicsDefPtr graphics = NULL; - g_auto(GStrv) **params = NULL; + g_auto(GStrv) params = NULL; GStrv next; if (!(video = virDomainVideoDefNew(xmlopt))) -- 2.30.2

2 1