April 2021 - Devel - libvirt List Archives

[PATCH] XML <source bridge='VMnet0'/> update in <interface type='bridge'/>
by Kristina Hanicova 01 Apr '21

01 Apr '21

Previously, we accepted empty bridge name, because some old versions of VMWare Workstation did not put it into the config. But this doesn't make much sense - to have an interface type bridge with no name. We circumvented this problem by generating an empty name but that is equally wrong. Therefore, fill in missing bridge names (according to the documentation [1] the default bridge name is VMnet0) and error out if bridge name is missing. This partially reverts f246cdb5aca13ac9409b2ad43087e3078615ffcb 1: https://docs.vmware.com/en/VMware-Workstation-Player-for-Linux/16.0/com.vmw… Signed-off-by: Kristina Hanicova <khanicov(a)redhat.com> --- src/vmx/vmx.c | 10 +++------- tests/vmx2xmldata/vmx2xml-fusion-in-the-wild-1.vmx | 2 ++ tests/vmx2xmldata/vmx2xml-fusion-in-the-wild-1.xml | 4 ++-- tests/vmx2xmldata/vmx2xml-ws-in-the-wild-2.vmx | 1 + tests/vmx2xmldata/vmx2xml-ws-in-the-wild-2.xml | 2 +- tests/xml2vmxdata/xml2vmx-fusion-in-the-wild-1.vmx | 2 ++ tests/xml2vmxdata/xml2vmx-fusion-in-the-wild-1.xml | 4 ++-- tests/xml2vmxdata/xml2vmx-ws-in-the-wild-2.vmx | 1 + tests/xml2vmxdata/xml2vmx-ws-in-the-wild-2.xml | 2 +- 9 files changed, 15 insertions(+), 13 deletions(-) diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c index 76d01a36de..82d3409c79 100644 --- a/src/vmx/vmx.c +++ b/src/vmx/vmx.c @@ -2803,11 +2803,8 @@ virVMXParseEthernet(virConfPtr conf, int controller, virDomainNetDefPtr *def) STRCASEEQ(connectionType, "bridged") || STRCASEEQ(connectionType, "custom")) { if (virVMXGetConfigString(conf, networkName_name, &networkName, - true) < 0) + false) < 0) goto cleanup; - - if (!networkName) - networkName = g_strdup(""); } /* vmx:vnet -> def:data.ifname */ @@ -3924,9 +3921,8 @@ virVMXFormatEthernet(virDomainNetDefPtr def, int controller, /* def:type, def:ifname -> vmx:connectionType */ switch (def->type) { case VIR_DOMAIN_NET_TYPE_BRIDGE: - if (STRNEQ(def->data.bridge.brname, "")) - virBufferAsprintf(buffer, "ethernet%d.networkName = \"%s\"\n", - controller, def->data.bridge.brname); + virBufferAsprintf(buffer, "ethernet%d.networkName = \"%s\"\n", + controller, def->data.bridge.brname); if (def->ifname != NULL) { virBufferAsprintf(buffer, "ethernet%d.connectionType = \"custom\"\n", diff --git a/tests/vmx2xmldata/vmx2xml-fusion-in-the-wild-1.vmx b/tests/vmx2xmldata/vmx2xml-fusion-in-the-wild-1.vmx index ef6af19b49..75583bdc53 100644 --- a/tests/vmx2xmldata/vmx2xml-fusion-in-the-wild-1.vmx +++ b/tests/vmx2xmldata/vmx2xml-fusion-in-the-wild-1.vmx @@ -12,9 +12,11 @@ sound.filename = "-1" sound.autodetect = "TRUE" usb.present = "TRUE" ethernet0.present = "TRUE" +ethernet0.networkName = "VMnet0" ethernet0.addressType = "generated" ethernet0.connectionType = "bridged" ethernet1.present = "TRUE" +ethernet1.networkName = "VMnet0" ethernet1.addressType = "generated" ethernet1.connectionType = "bridged" scsi0:0.present = "TRUE" diff --git a/tests/vmx2xmldata/vmx2xml-fusion-in-the-wild-1.xml b/tests/vmx2xmldata/vmx2xml-fusion-in-the-wild-1.xml index 2dd46eb2b1..f6e9f4acdf 100644 --- a/tests/vmx2xmldata/vmx2xml-fusion-in-the-wild-1.xml +++ b/tests/vmx2xmldata/vmx2xml-fusion-in-the-wild-1.xml @@ -26,11 +26,11 @@ <controller type='ide' index='0'/> <interface type='bridge'> <mac address='00:0c:29:3b:64:ea' type='generated'/> - <source bridge=''/> + <source bridge='VMnet0'/> </interface> <interface type='bridge'> <mac address='00:0c:29:3b:64:f4' type='generated'/> - <source bridge=''/> + <source bridge='VMnet0'/> </interface> <video> <model type='vmvga' vram='4096' primary='yes'/> diff --git a/tests/vmx2xmldata/vmx2xml-ws-in-the-wild-2.vmx b/tests/vmx2xmldata/vmx2xml-ws-in-the-wild-2.vmx index 6e078d4d92..172aa686ed 100644 --- a/tests/vmx2xmldata/vmx2xml-ws-in-the-wild-2.vmx +++ b/tests/vmx2xmldata/vmx2xml-ws-in-the-wild-2.vmx @@ -18,6 +18,7 @@ floppy0.startConnected = "FALSE" floppy0.fileName = "" floppy0.autodetect = "TRUE" ethernet0.present = "TRUE" +ethernet0.networkName = "VMnet0" ethernet0.connectionType = "bridged" ethernet0.virtualDev = "e1000" ethernet0.wakeOnPcktRcv = "FALSE" diff --git a/tests/vmx2xmldata/vmx2xml-ws-in-the-wild-2.xml b/tests/vmx2xmldata/vmx2xml-ws-in-the-wild-2.xml index 628dfbaff0..6f8f30393c 100644 --- a/tests/vmx2xmldata/vmx2xml-ws-in-the-wild-2.xml +++ b/tests/vmx2xmldata/vmx2xml-ws-in-the-wild-2.xml @@ -26,7 +26,7 @@ <controller type='ide' index='0'/> <interface type='bridge'> <mac address='00:50:56:2f:d3:46' type='static'/> - <source bridge=''/> + <source bridge='VMnet0'/> <model type='e1000'/> </interface> <video> diff --git a/tests/xml2vmxdata/xml2vmx-fusion-in-the-wild-1.vmx b/tests/xml2vmxdata/xml2vmx-fusion-in-the-wild-1.vmx index 9605e2d6ac..2a81cc0137 100644 --- a/tests/xml2vmxdata/xml2vmx-fusion-in-the-wild-1.vmx +++ b/tests/xml2vmxdata/xml2vmx-fusion-in-the-wild-1.vmx @@ -18,11 +18,13 @@ ide0:0.fileName = "auto detect" floppy0.present = "false" floppy1.present = "false" ethernet0.present = "true" +ethernet0.networkName = "VMnet0" ethernet0.connectionType = "bridged" ethernet0.addressType = "generated" ethernet0.generatedAddress = "00:0c:29:3b:64:ea" ethernet0.generatedAddressOffset = "0" ethernet1.present = "true" +ethernet1.networkName = "VMnet0" ethernet1.connectionType = "bridged" ethernet1.addressType = "generated" ethernet1.generatedAddress = "00:0c:29:3b:64:f4" diff --git a/tests/xml2vmxdata/xml2vmx-fusion-in-the-wild-1.xml b/tests/xml2vmxdata/xml2vmx-fusion-in-the-wild-1.xml index 0bfc7e88af..3052abd740 100644 --- a/tests/xml2vmxdata/xml2vmx-fusion-in-the-wild-1.xml +++ b/tests/xml2vmxdata/xml2vmx-fusion-in-the-wild-1.xml @@ -27,11 +27,11 @@ <controller type='ide' index='0'/> <interface type='bridge'> <mac address='00:0c:29:3b:64:ea'/> - <source bridge=''/> + <source bridge='VMnet0'/> </interface> <interface type='bridge'> <mac address='00:0c:29:3b:64:f4'/> - <source bridge=''/> + <source bridge='VMnet0'/> </interface> <video> <model type='vmvga' vram='4096'/> diff --git a/tests/xml2vmxdata/xml2vmx-ws-in-the-wild-2.vmx b/tests/xml2vmxdata/xml2vmx-ws-in-the-wild-2.vmx index f7f40ec300..eba18eb320 100644 --- a/tests/xml2vmxdata/xml2vmx-ws-in-the-wild-2.vmx +++ b/tests/xml2vmxdata/xml2vmx-ws-in-the-wild-2.vmx @@ -15,6 +15,7 @@ floppy0.present = "false" floppy1.present = "false" ethernet0.present = "true" ethernet0.virtualDev = "e1000" +ethernet0.networkName = "VMnet0" ethernet0.connectionType = "bridged" ethernet0.addressType = "static" ethernet0.address = "00:90:b9:dc:ea:81" diff --git a/tests/xml2vmxdata/xml2vmx-ws-in-the-wild-2.xml b/tests/xml2vmxdata/xml2vmx-ws-in-the-wild-2.xml index 30fb76c818..2bf8699149 100644 --- a/tests/xml2vmxdata/xml2vmx-ws-in-the-wild-2.xml +++ b/tests/xml2vmxdata/xml2vmx-ws-in-the-wild-2.xml @@ -20,7 +20,7 @@ <controller type='scsi' index='0' model='lsilogic'/> <interface type='bridge'> <mac address='00:90:b9:dc:ea:81'/> - <source bridge=''/> + <source bridge='VMnet0'/> <model type='e1000'/> </interface> <video> -- 2.30.2

2 2

Gsoc2021
by Aaryan Singh 01 Apr '21

01 Apr '21

Hello, This is Aaryan, a 2nd-year undergraduate student at Kalinga institute of industrial technology. I have a keen interest in the " test driver API coverage " project. since I have worked in cloud computing and DevOps that's why I am this interested in this project and would love to share my idea and develop it. Thank you

3 2

Release of libvirt-7.2.0
by Jiri Denemark 01 Apr '21

01 Apr '21

The 7.2.0 release of both libvirt and libvirt-python is tagged and signed tarballs and source RPMs are available at https://libvirt.org/sources/ https://libvirt.org/sources/python/ Thanks everybody who helped with this release by sending patches, reviewing, testing, or providing any other feedback. Your work is greatly appreciated. * New features * qemu: Implement domain memory dirty rate calculation API New API ``virDomainStartDirtyRateCalc()`` and virsh command ``domdirtyrate-calc`` are added to start calculating a live domain's memory dirty rate. * qemu: Support reporting memory dirty rate stats The memory dirty rate stats can be obtained through ``virsh domstats --dirtyrate`` via the virConnectGetAllDomainStats API. * qemu: Full disk backups via ``virDomainBackupBegin`` The qemu hypervisor driver now allows taking full disk backups via the ``virDomainBackupBegin`` API and the corresponding virsh wrapper. In future releases the feature will be extended to also support incremental backups (where only the difference since the last backup is copied) when qemu adds the required functionality. * Add support for audio backend specific settings With this release a new ``<audio/>`` element is introduced that allows users to configure audio output for their guests. * Improvements * qemu: Compatibility with QEMU 6.0 for certain hot-(un)-plug operations Libvirt 7.2.0 is required for compatibility with the upcoming QEMU 6.0 release for hotplug and hotunplug of certain devices and helpers, such as iothreads, chardevs, RNG devices, disks with secret, ... * qemu: Various improvements to embedded mode Embedded mode for the QEMU driver, as well as the ``virt-qemu-run`` tool saw improvements in handling of domain life cycle, temporary directories creation (important when using disk secrets) and other minor fixes. * Documentation of split daemon related config files Split daemons read configuration files upon their start. These were never documented though. * Bug fixes * Check host CPU for forbidden features CPU feature policy did not work as expected with ``host-passthrough`` and features supported by physical host. CPU features were not filtered out when ``@check`` was set to ``full``. * Fix virNetworkUpdate() to work with split daemons Due to a bug in our code, virNetworkUpdate() did not work with split daemon unless management application connected to virtnetworkd directly. * qemu: increase locked memory limit when a vDPA device is present Just like VFIO devices, vDPA devices may need to have all guest memory pages locked/pinned in order to operate properly. These devices are now included when calculating the limit for memory lock. * Don't log error if SRIOV PF has no associated netdev Some SRIOV PFs don't have a netdev associated with them in which case libvirtd reported an error and refused to start. This is now fixed. * qemu: Only raise memlock limit if necessary Attempting to set the memlock limit might fail if we're running in a containerized environment where ``CAP_SYS_RESOURCE`` is not available, and if the limit is already high enough there's no point in trying to raise it anyway. * Restore security context of swtpm.log If a guest with emulated TPM was started and the daemon was restarted afterwards, the security context of the per-domain ``swtpm.log`` file was not restored on domain shutdown leaving it unable to be started again. * virtlogd|virtlockd: Fixed crash when upgrading the daemons in-place A bug preventing the in-place upgrade of ``virtlogd`` and ``virtlockd`` daemons was fixed, so they can again be upgraded without dropping the log file descriptors or locks on files. Enjoy. Jirka

1 0

[PATCH] docs: formatnetworkport: Fix typos
by Han Han 01 Apr '21

01 Apr '21

Signed-off-by: Han Han <hhan(a)redhat.com> --- docs/formatnetworkport.html.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/formatnetworkport.html.in b/docs/formatnetworkport.html.in index 199a05f929..2d41552618 100644 --- a/docs/formatnetworkport.html.in +++ b/docs/formatnetworkport.html.in @@ -31,13 +31,13 @@ </p> <pre> -<networkport +<networkport> <uuid>7ae63b5f-fe96-4af0-a7c3-da04ba1b3f54</uuid> <owner> <uuid>06578fc1-c686-46fa-bc2c-220893b466a6</uuid> - <name>myguest<name> + <name>myguest</name> </owner> - <group>webfront<group> + <group>webfront</group> <mac address='52:54:0:7b:35:93'/> ...</pre> -- 2.31.1

2 1

[PATCH resend] lib: Drop internal virXXXPtr typedefs
by Michal Privoznik 01 Apr '21

01 Apr '21

1 0

[PATCH 0/6] qemu: Allow control of deprecation behaviour
by Peter Krempa 01 Apr '21

01 Apr '21

For debugging purposes it's very useful to disable all deprecated commands and fields in qemu. This series implements a qemu.conf knob and a qemu namespace element to control this. The implementation tries to be very conservative to allow downgrades of qemu and such without breaking the startup of the VM. The intention is that developers and CI deployments use the 'crash' option to catch any unexpected qemu disappearance. Note that this applies on top of my series for -object QAPIfication. Based on Markus' -compat series which was now merged to upstream qemu. Peter Krempa (6): docs/drvqemu: Convert to RST qemu: capabilities: Introduce QEMU_CAPS_COMPAT_DEPRECATED qemu: conf: Add 'deprecation_behavior' setting to qemu.conf qemuxml2xmltest: Enable 'qemu-ns' case qemu: Add per-VM control of deprecation behavior qemu: command: Handle formatting of '-compat' options docs/drvqemu.html.in | 743 ------------------ docs/drvqemu.rst | 636 +++++++++++++++ docs/formatdomain.rst | 2 +- docs/manpages/virt-qemu-run.rst | 2 +- docs/meson.build | 2 +- docs/schemas/domaincommon.rng | 16 + src/qemu/libvirtd_qemu.aug | 1 + src/qemu/qemu.conf | 31 + src/qemu/qemu_capabilities.c | 8 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 80 ++ src/qemu/qemu_conf.c | 4 + src/qemu/qemu_conf.h | 2 + src/qemu/qemu_domain.c | 10 +- src/qemu/qemu_domain.h | 5 + src/qemu/test_libvirtd_qemu.aug.in | 1 + .../caps_6.0.0.x86_64.xml | 1 + .../qemu-ns.x86_64-latest.args | 1 + tests/qemuxml2argvdata/qemu-ns.xml | 1 + .../qemu-ns.x86_64-latest.xml | 52 ++ tests/qemuxml2xmltest.c | 1 + 21 files changed, 853 insertions(+), 747 deletions(-) delete mode 100644 docs/drvqemu.html.in create mode 100644 docs/drvqemu.rst create mode 100644 tests/qemuxml2xmloutdata/qemu-ns.x86_64-latest.xml -- 2.29.2

2 15

[libvirt PATCH 0/2] qemu: wire up support for rotation rate for disks
by Daniel P. Berrangé 01 Apr '21

01 Apr '21

By default QEMU doesn't report any rotation information to guests, so guests assume rotational media. This lets the user specify an explicit speed in RPM, or 1 for SSD. This may allow the user to achieve better performance for their virtual disks. Note, however, this doesn't mean that the guest should be given the same setting as the host storage. It is possible that better performance may be achieved with contrary settings from the host. Testing is required to determine this on a case by case basis. Daniel P. Berrangé (2): conf: add support for disk "rotation_rate" property qemu: implement setting of rotation rate for SCSI/IDE disks docs/formatdomain.rst | 13 ++++- docs/schemas/domaincommon.rng | 5 ++ src/conf/domain_conf.c | 11 ++++ src/conf/domain_conf.h | 1 + src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 3 + src/qemu/qemu_validate.c | 22 ++++++++ .../caps_2.12.0.aarch64.xml | 1 + .../caps_4.0.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_4.0.0.ppc64.xml | 1 + .../caps_4.0.0.riscv32.xml | 1 + .../caps_4.0.0.riscv64.xml | 1 + .../qemucapabilitiesdata/caps_4.0.0.s390x.xml | 1 + .../caps_4.0.0.x86_64.xml | 1 + .../caps_4.1.0.x86_64.xml | 1 + .../caps_4.2.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_4.2.0.ppc64.xml | 1 + .../qemucapabilitiesdata/caps_4.2.0.s390x.xml | 1 + .../caps_4.2.0.x86_64.xml | 1 + .../caps_5.0.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 1 + .../caps_5.0.0.riscv64.xml | 1 + .../caps_5.0.0.x86_64.xml | 1 + .../qemucapabilitiesdata/caps_5.1.0.sparc.xml | 1 + .../caps_5.1.0.x86_64.xml | 1 + .../caps_5.2.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_5.2.0.ppc64.xml | 1 + .../caps_5.2.0.riscv64.xml | 1 + .../qemucapabilitiesdata/caps_5.2.0.s390x.xml | 1 + .../caps_5.2.0.x86_64.xml | 1 + .../caps_6.0.0.x86_64.xml | 1 + .../disk-rotation.x86_64-latest.args | 56 +++++++++++++++++++ tests/qemuxml2argvdata/disk-rotation.xml | 38 +++++++++++++ tests/qemuxml2argvtest.c | 1 + .../disk-rotation.x86_64-latest.xml | 55 ++++++++++++++++++ tests/qemuxml2xmltest.c | 1 + 37 files changed, 230 insertions(+), 3 deletions(-) create mode 100644 tests/qemuxml2argvdata/disk-rotation.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/disk-rotation.xml create mode 100644 tests/qemuxml2xmloutdata/disk-rotation.x86_64-latest.xml -- 2.30.2

4 9