December 2021 - Devel - libvirt List Archives

[PATCH] NEWS: Fix spacing between releases
by Andrea Bolognani 08 Dec '21

08 Dec '21

Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed as trivial. NEWS.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/NEWS.rst b/NEWS.rst index a4252d555d..6c8ac1d9f9 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -190,6 +190,7 @@ v7.8.0 (2021-10-01) active. This information can also be retrieved with the new virsh command ``nodedev-info``. + v7.7.0 (2021-09-01) =================== -- 2.31.1

1 0

can cgroup(cpu,mem) limit qemu and obtain right usage
by longguang.yue 08 Dec '21

08 Dec '21

Hi, all: kata runs qemu as a kubernetes pod and use cgroup to limit cpu/memory. my question are : 1. how libvirt obtain qemu's cpu and memory usage， how about non-root mode cpu usage? 2. if qemu is limited in cgroups , does that usage include non-root mode cpu usage? thanks

2 1

[libvirt PATCH] qemu: do not compare missing cpu data
by Ján Tomko 08 Dec '21

08 Dec '21

For x86, we invalidate qemu caps cache if the host CPUID changed. However other cpu drivers do not have the 'getHostData' function implemented. Skip the comparison if we do not have host CPUData available, since virCPUDataIsIdentical always returns an error in that case. https://bugzilla.redhat.com/show_bug.cgi?id=2030119 Fixes: 3bc6f46d305ed82f7314ffc4c2a66847b831a6bd Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- src/qemu/qemu_capabilities.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 0e6e73774a..51828ead53 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -4943,7 +4943,8 @@ virQEMUCapsIsValid(void *data, return false; } - if (virCPUDataIsIdentical(priv->cpuData, qemuCaps->cpuData) != + if (priv->cpuData && + virCPUDataIsIdentical(priv->cpuData, qemuCaps->cpuData) != VIR_CPU_COMPARE_IDENTICAL) { VIR_DEBUG("Outdated capabilities for '%s': host cpuid changed", qemuCaps->binary); -- 2.31.1

2 1

[PATCH] Add VM info to improve error log message for qemu monitor
by Rohit Kumar 08 Dec '21

08 Dec '21

This patch is to determine the VM which had IO or socket hangup error. Signed-off-by: Rohit Kumar <rohit.kumar3(a)nutanix.com> --- src/qemu/qemu_monitor.c | 46 +++++++++++++++++++++++++---------------- 1 file changed, 28 insertions(+), 18 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index 75e0e4ed92..d36db280d9 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -530,13 +530,19 @@ qemuMonitorIO(GSocket *socket G_GNUC_UNUSED, qemuMonitor *mon = opaque; bool error = false; bool hangup = false; + virDomainObj *vm = mon->vm; + g_autofree char *vmName = NULL; + + if (vm != NULL && vm->def != NULL) { + vmName = g_strdup(vm->def->name); + } virObjectRef(mon); /* lock access to the monitor and protect fd */ virObjectLock(mon); #if DEBUG_IO - VIR_DEBUG("Monitor %p I/O on socket %p cond %d", mon, socket, cond); + VIR_DEBUG("Monitor %p I/O on socket %p cond %d vm=%p name=%s", mon, socket, cond, vm, NULLSTR(vmName)); #endif if (mon->fd == -1 || !mon->watch) { virObjectUnlock(mon); @@ -583,8 +589,8 @@ qemuMonitorIO(GSocket *socket G_GNUC_UNUSED, if (!error && !mon->goteof && cond & G_IO_ERR) { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("Invalid file descriptor while waiting for monitor")); + virReportError(VIR_ERR_INTERNAL_ERROR, + _("Invalid file descriptor while waiting for monitor vm_name=%s"), NULLSTR(vmName)); mon->goteof = true; } } @@ -609,13 +615,13 @@ qemuMonitorIO(GSocket *socket G_GNUC_UNUSED, virResetLastError(); } else { if (virGetLastErrorCode() == VIR_ERR_OK && !mon->goteof) - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("Error while processing monitor IO")); + virReportError(VIR_ERR_INTERNAL_ERROR, + _("Error while processing monitor IO vm_name=%s"), NULLSTR(vmName)); virCopyLastError(&mon->lastError); virResetLastError(); } - VIR_DEBUG("Error on monitor %s", NULLSTR(mon->lastError.message)); + VIR_DEBUG("Error on monitor %s vm=%p name=%s", NULLSTR(mon->lastError.message), vm, NULLSTR(vmName)); /* If IO process resulted in an error & we have a message, * then wakeup that waiter */ if (mon->msg && !mon->msg->finished) { @@ -631,22 +637,20 @@ qemuMonitorIO(GSocket *socket G_GNUC_UNUSED, * will try to acquire the virDomainObj *mutex next */ if (mon->goteof) { qemuMonitorEofNotifyCallback eofNotify = mon->cb->eofNotify; - virDomainObj *vm = mon->vm; /* Make sure anyone waiting wakes up now */ virCondSignal(&mon->notify); virObjectUnlock(mon); - VIR_DEBUG("Triggering EOF callback"); + VIR_DEBUG("Triggering EOF callback vm=%p name=%s", vm, NULLSTR(vmName)); (eofNotify)(mon, vm, mon->callbackOpaque); virObjectUnref(mon); } else if (error) { qemuMonitorErrorNotifyCallback errorNotify = mon->cb->errorNotify; - virDomainObj *vm = mon->vm; /* Make sure anyone waiting wakes up now */ virCondSignal(&mon->notify); virObjectUnlock(mon); - VIR_DEBUG("Triggering error callback"); + VIR_DEBUG("Triggering error callback vm=%p name=%s", vm, NULLSTR(vmName)); (errorNotify)(mon, vm, mon->callbackOpaque); virObjectUnref(mon); } else { @@ -932,17 +936,23 @@ qemuMonitorSend(qemuMonitor *mon, qemuMonitorMessage *msg) { int ret = -1; + virDomainObj *vm = mon->vm; + g_autofree char *vmName = NULL; + + if (vm != NULL && vm->def != NULL) { + vmName = g_strdup(vm->def->name); + } /* Check whether qemu quit unexpectedly */ if (mon->lastError.code != VIR_ERR_OK) { - VIR_DEBUG("Attempt to send command while error is set %s", - NULLSTR(mon->lastError.message)); + VIR_DEBUG("Attempt to send command while error is set %s vm=%p name=%s", + NULLSTR(mon->lastError.message), vm, NULLSTR(vmName)); virSetError(&mon->lastError); return -1; } if (mon->goteof) { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("End of file from qemu monitor")); + virReportError(VIR_ERR_INTERNAL_ERROR, + _("End of file from qemu monitor vm_name=%s"), NULLSTR(vmName)); return -1; } @@ -955,15 +965,15 @@ qemuMonitorSend(qemuMonitor *mon, while (!mon->msg->finished) { if (virCondWait(&mon->notify, &mon->parent.lock) < 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("Unable to wait on monitor condition")); + virReportError(VIR_ERR_INTERNAL_ERROR, + _("Unable to wait on monitor condition vm_name=%s"), NULLSTR(vmName)); goto cleanup; } } if (mon->lastError.code != VIR_ERR_OK) { - VIR_DEBUG("Send command resulted in error %s", - NULLSTR(mon->lastError.message)); + VIR_DEBUG("Send command resulted in error %s vm=%p name=%s", + NULLSTR(mon->lastError.message), vm, NULLSTR(vmName)); virSetError(&mon->lastError); goto cleanup; } -- 2.25.1

3 5

[PATCH 0/2] disk iomode validation cleanups
by Peter Krempa 07 Dec '21

07 Dec '21

Peter Krempa (2): qemuValidateDomainDeviceDefDiskFrontend: Fix error message if io='native' is unsupported qemuValidateDomainDeviceDefDiskFrontend: Aggregate disk iomode validation src/qemu/qemu_validate.c | 38 ++++++++++++++++++++++---------------- 1 file changed, 22 insertions(+), 16 deletions(-) -- 2.31.1

2 4

[libvirt PATCH v2] qemu: Enable unprivileged userfaultfd for post-copy migration
by Jiri Denemark 07 Dec '21

07 Dec '21

Userfaultfd is by default allowed only for privileged processes. Since libvirt runs QEMU unprivileged, we need to enable unprivileged access to userfaultfd before starting post-copy migration. Rather than providing a static sysctl configuration file, we set the sysctl knob in runtime once post-copy migration is requested. This way unprivileged_userfaultfd is only enabled once actually used. https://bugzilla.redhat.com/show_bug.cgi?id=1945420 Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- Notes: Version 2: - setting unprivileged_userfaultfd only when it is not already enabled - virReportSystemError replaced with VIR_WARN src/qemu/qemu_migration_params.c | 42 ++++++++++++++++++++++++++++++++ 1 file changed, 42 insertions(+) diff --git a/src/qemu/qemu_migration_params.c b/src/qemu/qemu_migration_params.c index dbc3219826..9ba4811242 100644 --- a/src/qemu/qemu_migration_params.c +++ b/src/qemu/qemu_migration_params.c @@ -804,6 +804,41 @@ qemuMigrationCapsToJSON(virBitmap *caps, } +/** + * qemuMigrationParamsEnableUserfaultfd + * + * Try to enable unprivileged userfaultfd unless it's missing or already + * enabled. Only a warning is logged when we cannot enable it, QEMU will + * report an error when enabling post-copy migration capability. + */ +static void +qemuMigrationParamsEnableUserfaultfd(void) +{ + const char *sysctl = "/proc/sys/vm/unprivileged_userfaultfd"; + g_autofree char *buf = NULL; + + if (!virFileExists(sysctl)) + return; + + if (virFileReadAll(sysctl, 10, &buf) < 0) { + VIR_WARN("Cannot read unprivileged userfaultfd state"); + return; + } + + if (STREQ(buf, "1\n")) { + VIR_DEBUG("Unprivileged userfaultfd already enabled"); + return; + } + + VIR_DEBUG("Enabling unprivileged userfaultfd for post-copy migration"); + + if (virFileWriteStr(sysctl, "1", 0) < 0) { + VIR_WARN("Failed to enable unprivileged userfaultfd: %s", + g_strerror(errno)); + } +} + + /** * qemuMigrationParamsApply * @driver: qemu driver @@ -839,6 +874,13 @@ qemuMigrationParamsApply(virQEMUDriver *driver, goto cleanup; } } else { + /* userfaultfd may only be enabled for privileged processes by default, + * we need to make sure QEMU can use it before enabling post-copy + * migration */ + if (virBitmapIsBitSet(priv->migrationCaps, QEMU_MIGRATION_CAP_POSTCOPY) && + virBitmapIsBitSet(migParams->caps, QEMU_MIGRATION_CAP_POSTCOPY)) + qemuMigrationParamsEnableUserfaultfd(); + if (!(caps = qemuMigrationCapsToJSON(priv->migrationCaps, migParams->caps))) goto cleanup; -- 2.34.1

3 3

[PATCH 0/3] Add virDomainSetLaunchSecurityState API
by Jim Fehlig 06 Dec '21

06 Dec '21

V1 series based on initial RFC found here https://listman.redhat.com/archives/libvir-list/2021-November/msg00460.html This series is compile tested only. Functional testing will require reserving the test machine, configuring it, and writing some form of functional test :-). Is anyone aware of functional tests for the existing SEV-related APIs? Also, it has been a while since I added a new API, so not sure about the current state of the language bindings. Are there any non-automated tasks to expose the API in the various bindings? Jim Fehlig (3): libvirt: Introduce virDomainSetLaunchSecurityState public API remote: Add RPC support for the virDomainSetLaunchSecurityState API qemu: Implement the virDomainSetLaunchSecurityState API include/libvirt/libvirt-domain.h | 35 ++++++++++++++ src/driver-hypervisor.h | 7 +++ src/libvirt-domain.c | 52 +++++++++++++++++++++ src/libvirt_public.syms | 5 ++ src/qemu/qemu_driver.c | 78 ++++++++++++++++++++++++++++++++ src/qemu/qemu_monitor.c | 12 +++++ src/qemu/qemu_monitor.h | 6 +++ src/qemu/qemu_monitor_json.c | 34 ++++++++++++++ src/qemu/qemu_monitor_json.h | 5 ++ src/remote/remote_driver.c | 1 + src/remote/remote_protocol.x | 17 ++++++- src/remote_protocol-structs | 9 ++++ 12 files changed, 260 insertions(+), 1 deletion(-) -- 2.33.0

2 9

Re: [PATCH for-7.0] i386: Deprecate the -no-hpet QEMU command line option
by Thomas Huth 06 Dec '21

06 Dec '21

On 06/12/2021 09.40, Thomas Huth wrote: > The HPET setting has been turned into a machine property a while ago > already, so we should finally do the next step and deprecate the > legacy CLI option, too. > While we're at it, add a proper help text for the machine property, too. > > Signed-off-by: Thomas Huth <thuth(a)redhat.com> > --- > docs/about/deprecated.rst | 6 ++++++ > hw/i386/pc.c | 2 ++ > qemu-options.hx | 2 +- > softmmu/vl.c | 1 + > 4 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst > index 5693abb663..1dfe69aa6a 100644 > --- a/docs/about/deprecated.rst > +++ b/docs/about/deprecated.rst > @@ -198,6 +198,12 @@ form is preferred. > Using ``-drive if=none`` to configure the OTP device of the sifive_u > RISC-V machine is deprecated. Use ``-drive if=pflash`` instead. > > +``-no-hpet`` (since 7.0) > +'''''''''''''''''''''''' > + > +The HPET setting has been turned into a machine property. > +Use ``-machine hpet=off`` instead. [...] Forgot to CC: the libvirt folks, doing so now. Seems like libvirt is still using -no-hpet in some few spots, so I guess these would need to be changed first, before we could finally remove this option in QEMU? Thomas

3 5

[libvirt PATCH v2 0/2] Fix failure to find VF netdev names during virtual network start
by Laine Stump 06 Dec '21

06 Dec '21

The first patch resolves https://bugzilla.redhat.com/2025432, the 2nd simplifies lower level code in the same manner. V1 is here: https://listman.redhat.com/archives/libvir-list/2021-December/msg00000.html Change in V2: Rather than adding an extra bool to the arglist of virPCIGetVirtualFunctionsFull() (what I did in V1), just switch to sending the name of the netdev whose phys_port_id we want to match (called physPortNetDevName) (which will always be non-NULL in the cases where we want) rather than the phys_port_id itself (physPortID) (which may or may not be NULL). This way we don't need an extra arg (we can just check for physPortNetDevName != NULL), and the lower level function can call virNetDevGetPhysPortID() as needed. Also added a similar 2nd patch that pushes the call to virNetDevGetPhysPortID() down even further, into virPCIGetNetName(). This simplifies the callers, and concentrates all calls to virNetDevGetPhysPortID() into a single function (virPCIGetNetName(), duh). Laine Stump (2): util: fix erroneous requirement for phys_port_id to get ifname of a VF util: call virNetDevGetPhysPortID() in less places src/util/virnetdev.c | 24 +++----------------- src/util/virpci.c | 52 ++++++++++++++++++++++++++------------------ src/util/virpci.h | 4 ++-- 3 files changed, 36 insertions(+), 44 deletions(-) -- 2.33.1

2 3

[libvirt PATCH v2 00/15] WIP/RFC: add QEMU "-display dbus" support
by marcandre.lureau＠redhat.com 06 Dec '21

06 Dec '21

From: Marc-André Lureau <marcandre.lureau(a)redhat.com> Hi, This series implements supports for the upcoming QEMU "-display dbus" support. Development is still in progress, but I hope to land the QEMU support early in 6.3 (last version posted: https://patchew.org/QEMU/20211009210838.2219430-1-marcandre.lureau@redhat.c…) By default, libvirt will start a private VM bus (sharing and reusing the existing "vmstate" VM bus & code). The feature set should cover the needs to replace Spice as local client of choice, including 3daccel/dmabuf, audio, clipboard sharing, usb redirection, and arbitrary chardev/channels (for serial etc). The test Gtk4 client is also in progress, currently in development at https://gitlab.com/marcandre.lureau/qemu-display/. A few dependencies, such as zbus, require an upcoming release. virt-viewer & boxes will need a port to Gtk4 to make use of the shared widget. Comments welcome, as we can still adjust the QEMU side etc. thanks v2: after Michal review - split patches for conf & qemu changes - start D-Bus in qemuExtDevicesStart() - use symlinks for xml2xml tests - teach domdisplay to return a dbus URI - rebase & bug fixes Marc-André Lureau (15): qemu: add chardev-vdagent capability check qemu: add -display dbus capability check (to update to 6.3) conf: add <graphics type='dbus'> qemu: start the D-Bus daemon for the display qemu: add -display dbus support virsh: refactor/split cmdDomDisplay() virsh: report the D-Bus bus URI for domdisplay conf: add <audio type='dbus'> support qemu: add audio type 'dbus' conf: add dbus <clipboard> qemu: add dbus clipboard sharing conf: add <serial type='dbus'> qemu: add -chardev dbus support qemu: add usbredir type 'dbus' docs: document <graphics> type dbus docs/formatdomain.rst | 43 +- docs/schemas/basictypes.rng | 7 + docs/schemas/domaincommon.rng | 71 ++++ src/bhyve/bhyve_command.c | 1 + src/conf/domain_conf.c | 141 ++++++- src/conf/domain_conf.h | 15 + src/conf/domain_validate.c | 41 +- src/libxl/libxl_conf.c | 1 + src/qemu/qemu_capabilities.c | 6 + src/qemu/qemu_capabilities.h | 2 + src/qemu/qemu_command.c | 80 +++- src/qemu/qemu_domain.c | 1 + src/qemu/qemu_driver.c | 10 +- src/qemu/qemu_extdevice.c | 13 + src/qemu/qemu_hotplug.c | 1 + src/qemu/qemu_monitor_json.c | 10 + src/qemu/qemu_process.c | 40 +- src/qemu/qemu_validate.c | 33 ++ src/security/security_dac.c | 2 + src/vmx/vmx.c | 1 + .../domaincapsdata/qemu_6.2.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_6.2.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_6.2.0.x86_64.xml | 1 + .../caps_6.1.0.x86_64.xml | 1 + .../caps_6.2.0.aarch64.xml | 1 + .../caps_6.2.0.x86_64.replies | 10 +- .../caps_6.2.0.x86_64.xml | 2 + .../graphics-dbus-address.args | 30 ++ .../graphics-dbus-address.xml | 35 ++ .../qemuxml2argvdata/graphics-dbus-audio.args | 33 ++ .../qemuxml2argvdata/graphics-dbus-audio.xml | 45 +++ .../graphics-dbus-chardev.args | 32 ++ .../graphics-dbus-chardev.xml | 43 ++ .../graphics-dbus-clipboard.args | 31 ++ .../graphics-dbus-clipboard.xml | 35 ++ tests/qemuxml2argvdata/graphics-dbus-p2p.args | 30 ++ tests/qemuxml2argvdata/graphics-dbus-p2p.xml | 33 ++ .../graphics-dbus-usbredir.args | 34 ++ .../graphics-dbus-usbredir.xml | 30 ++ tests/qemuxml2argvdata/graphics-dbus.args | 30 ++ tests/qemuxml2argvdata/graphics-dbus.xml | 33 ++ tests/qemuxml2argvtest.c | 21 + .../graphics-dbus-address.xml | 1 + .../graphics-dbus-audio.xml | 1 + .../graphics-dbus-chardev.xml | 1 + .../graphics-dbus-clipboard.xml | 1 + .../qemuxml2xmloutdata/graphics-dbus-p2p.xml | 1 + tests/qemuxml2xmloutdata/graphics-dbus.xml | 1 + tests/qemuxml2xmltest.c | 20 + tools/virsh-domain.c | 366 +++++++++--------- 50 files changed, 1231 insertions(+), 192 deletions(-) create mode 100644 tests/qemuxml2argvdata/graphics-dbus-address.args create mode 100644 tests/qemuxml2argvdata/graphics-dbus-address.xml create mode 100644 tests/qemuxml2argvdata/graphics-dbus-audio.args create mode 100644 tests/qemuxml2argvdata/graphics-dbus-audio.xml create mode 100644 tests/qemuxml2argvdata/graphics-dbus-chardev.args create mode 100644 tests/qemuxml2argvdata/graphics-dbus-chardev.xml create mode 100644 tests/qemuxml2argvdata/graphics-dbus-clipboard.args create mode 100644 tests/qemuxml2argvdata/graphics-dbus-clipboard.xml create mode 100644 tests/qemuxml2argvdata/graphics-dbus-p2p.args create mode 100644 tests/qemuxml2argvdata/graphics-dbus-p2p.xml create mode 100644 tests/qemuxml2argvdata/graphics-dbus-usbredir.args create mode 100644 tests/qemuxml2argvdata/graphics-dbus-usbredir.xml create mode 100644 tests/qemuxml2argvdata/graphics-dbus.args create mode 100644 tests/qemuxml2argvdata/graphics-dbus.xml create mode 120000 tests/qemuxml2xmloutdata/graphics-dbus-address.xml create mode 120000 tests/qemuxml2xmloutdata/graphics-dbus-audio.xml create mode 120000 tests/qemuxml2xmloutdata/graphics-dbus-chardev.xml create mode 120000 tests/qemuxml2xmloutdata/graphics-dbus-clipboard.xml create mode 120000 tests/qemuxml2xmloutdata/graphics-dbus-p2p.xml create mode 120000 tests/qemuxml2xmloutdata/graphics-dbus.xml -- 2.34.1.8.g35151cf07204

4 19

[PATCH 00/17] qemu: Add support for blocking writes for the blockdev-mirror job
by Peter Krempa 03 Dec '21

03 Dec '21

Blocking writes ensure that the mirroring converges even when the guest is I/O intensive with a fast local storage and slow mirror. This patchset does it by introducing flags which use the blocking mode as it will have performance impact, and for guests which do I/O in bursts it might be detrimental to their performance. One could argue that both the copy job and migration have the expectations of actually using the copy so ensuring that it converges might be also something we'd want to do by default. This would obviously greatly simplify this series, but I didn't want to change the default. Peter Krempa (17): qemu: monitor: Avoid ternary operators in helpers for drive/blockdev-mirror qemuMonitorJSONHandleShutdown: Use virTristateBoolFromBool qemuMonitorJSONEjectMedia: Use a bool directly for constructing JSON with 'b' modifier qemuMonitorJSONMigrate: Extract flags prior to constructing command qemuMonitorJSONGraphicsRelocate: Clean up command argument construction qemu: monitor: Add support for 'write-blocking' copy mode for blockdev-mirror include: virDomainBlockCopyFlags: Convert to prefix comments virDomainBlockCopy: Introduce VIR_DOMAIN_BLOCK_COPY_SYNCHRONOUS_WRITES flag qemuDomainBlockCopy: Implement VIR_DOMAIN_BLOCK_COPY_SYNCHRONOUS_WRITES include: virDomainMigrateFlags: Remove "block alignment" whitespace man: virsh: Separate paragrapsh describing distinct flags VIR_REQUIRE_FLAG_(GOTO|RET): Add parens around arguments in expansion virDomainMigrate: Introduce VIR_MIGRATE_NON_SHARED_SYNCHRONOUS_WRITES flag qemu: migration: Implement VIR_MIGRATE_NON_SHARED_SYNCHRONOUS_WRITES docs: Convert 'migration' doc to RST docs: migration: Add a paragraph about non-shared storage migration NEWS: Mention synchronous copy job additions NEWS.rst | 12 + docs/manpages/virsh.rst | 45 +- docs/meson.build | 2 +- docs/migration.html.in | 688 ------------------------------- docs/migration.rst | 490 ++++++++++++++++++++++ include/libvirt/libvirt-domain.h | 63 +-- src/internal.h | 4 +- src/libvirt-domain.c | 26 ++ src/qemu/qemu_driver.c | 17 +- src/qemu/qemu_migration.c | 17 +- src/qemu/qemu_migration.h | 1 + src/qemu/qemu_monitor.c | 10 +- src/qemu/qemu_monitor.h | 3 +- src/qemu/qemu_monitor_json.c | 67 ++- src/qemu/qemu_monitor_json.h | 3 +- tests/qemumonitorjsontest.c | 2 +- tools/virsh-domain.c | 22 +- 17 files changed, 707 insertions(+), 765 deletions(-) delete mode 100644 docs/migration.html.in create mode 100644 docs/migration.rst -- 2.31.1

2 21

[PATCH 00/16] Clean up of virJSONValueFree usage and few related refactors
by Peter Krempa 03 Dec '21

03 Dec '21

Peter Krempa (16): qemu: hotplug: Use automatic freeing for virJSONValue qemuDomainHotplugAddIOThread: Automatically free virJSONValue qemuMonitorBlockdevCreate: Use double pointer instead of always consuming '@props' virLockDaemonClientPreExecRestart: Modernize JSON object construction virLockDaemonPostExecRestart: Automatically free temporary variables virLockDaemonPostExecRestart: Refactor cleanup virLogDaemonPostExecRestart: Use automatic freeing for variables virLogDaemonPostExecRestart: Refactor cleanup virCHProcessUpdateInfo: Automatically free virJSONValue tests/virnetdaemontest.c: testExecRestart: Automatically free virJSONValue-s qemuAgentGuestSync: Don't use goto for looping qemuMonitorJSONGetCPUModelExpansion: Don't use goto for looping qemuMonitorAddObject: Use g_clear_pointer for a free and reset operation qemuAgentIOProcessLine: refactor cleanup qemu: agent: Automatically free virJSONValue-s qemu: agent: Remove unneeded cleanup sections src/ch/ch_process.c | 4 +- src/locking/lock_daemon.c | 85 ++++------ src/logging/log_daemon.c | 42 ++--- src/qemu/qemu_agent.c | 304 ++++++++++++++++------------------- src/qemu/qemu_block.c | 3 +- src/qemu/qemu_driver.c | 3 +- src/qemu/qemu_hotplug.c | 13 +- src/qemu/qemu_monitor.c | 20 +-- src/qemu/qemu_monitor.h | 2 +- src/qemu/qemu_monitor_json.c | 79 +++++---- src/qemu/qemu_monitor_json.h | 2 +- tests/virnetdaemontest.c | 6 +- 12 files changed, 254 insertions(+), 309 deletions(-) -- 2.31.1

2 17

[libvirt PATCH] libxl: libxlLoggerFileFree: remove redundant NULL assignment
by Ján Tomko 03 Dec '21

03 Dec '21

The 'file' pointer is already zeroed in virFileFclose and never read again. Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- Pushed as trivial. src/libxl/libxl_logger.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/libxl/libxl_logger.c b/src/libxl/libxl_logger.c index 44ee5a95da..4708553f29 100644 --- a/src/libxl/libxl_logger.c +++ b/src/libxl/libxl_logger.c @@ -53,7 +53,6 @@ libxlLoggerFileFree(void *payload) { FILE *file = payload; VIR_FORCE_FCLOSE(file); - file = NULL; } G_GNUC_PRINTF(5, 0) static void -- 2.31.1

1 0

[libvirt PATCH] meson: Improve network driver enablement logic
by Andrea Bolognani 03 Dec '21

03 Dec '21

The Homebrew package explicitly enables this driver despite us disabling it by default on macOS, so it must be functional to at least some extent and certainly can't be causing any build failures. Additionally, if the user has explicitly asked for the network driver to be enabled but libvirtd is disabled for whatever reason, we should error out instead of silently disabling the network driver. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Homebrew formula showing that the network driver is explicitly enabled in the package: https://github.com/Homebrew/homebrew-core/blob/3aff61292a3ed16bc715ba23fc2f… Test pipeline showing that enabling the network driver by default on macOS doesn't result in build failures: https://gitlab.com/abologna/libvirt/-/pipelines/421956249 meson.build | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/meson.build b/meson.build index ba2f0d21de..cea8bbfa0c 100644 --- a/meson.build +++ b/meson.build @@ -1645,10 +1645,10 @@ if not get_option('driver_ch').disabled() and host_machine.system() == 'linux' a endif endif -# there's no use compiling the network driver without the libvirt -# daemon, nor compiling it for macOS, where it breaks the compile -if not get_option('driver_network').disabled() and conf.has('WITH_LIBVIRTD') and host_machine.system() != 'darwin' +if not get_option('driver_network').disabled() and conf.has('WITH_LIBVIRTD') conf.set('WITH_NETWORK', 1) +elif get_option('driver_network').enabled() + error('libvirtd must be enabled to build the network driver') endif if udev_dep.found() and conf.has('WITH_LIBVIRTD') -- 2.31.1

2 1

[PATCH 0/3] lib: Use g_autoptr() for virDomainDef
by Michal Privoznik 03 Dec '21

03 Dec '21

*** BLURB HERE *** Michal Prívozník (3): virdomainobjlist: Use g_autofree lib: Use g_autoptr() for virDomainDef lib: Drop some needles labels src/bhyve/bhyve_driver.c | 15 +++----- src/bhyve/bhyve_parse_command.c | 23 +++++------- src/ch/ch_driver.c | 6 ++-- src/conf/domain_conf.c | 10 ++---- src/conf/virdomainobjlist.c | 33 ++++++------------ src/esx/esx_driver.c | 14 +++----- src/libxl/libxl_domain.c | 24 +++++-------- src/libxl/libxl_driver.c | 62 ++++++++++++--------------------- src/libxl/libxl_migration.c | 3 +- src/libxl/xen_xl.c | 34 ++++++++---------- src/libxl/xen_xm.c | 18 ++++------ src/lxc/lxc_driver.c | 24 +++++-------- src/lxc/lxc_native.c | 40 ++++++++++----------- src/openvz/openvz_conf.c | 3 +- src/openvz/openvz_driver.c | 9 ++--- src/qemu/qemu_saveimage.c | 21 ++++------- src/qemu/qemu_snapshot.c | 6 ++-- src/test/test_driver.c | 39 +++++++-------------- src/vbox/vbox_common.c | 14 +++----- src/vmware/vmware_conf.c | 6 ++-- src/vmware/vmware_driver.c | 10 ++---- src/vmx/vmx.c | 12 +++---- src/vz/vz_driver.c | 24 +++++-------- src/vz/vz_sdk.c | 41 ++++++++++------------ tests/securityselinuxtest.c | 8 ++--- 25 files changed, 182 insertions(+), 317 deletions(-) -- 2.32.0

2 6

[PATCH v2 0/4] Add an option to use virDomainGetSecurityLabelList and test it
by Luke Yue 03 Dec '21

03 Dec '21

diff to v1: - Add some variety when filling the test driver seclabels array - Split 2/3 in v1 to function patch and align output patch link to v1: https://listman.redhat.com/archives/libvir-list/2021-September/msg00015.html link to CI: https://gitlab.com/lukedyue/libvirt/-/pipelines/422002148 Luke Yue (4): test_driver: Implement virDomainGetSecurityLabelList virsh: Add '--full-seclabels' option for dominfo virsh: Realign some outputs tests: Add test for virDomainGetSecurityLabelList docs/manpages/virsh.rst | 5 ++- src/test/test_driver.c | 43 ++++++++++++++++++ tests/virsh-undefine | 8 ++-- tests/virshtest.c | 77 ++++++++++++++++---------------- tools/virsh-domain-monitor.c | 85 ++++++++++++++++++++++++------------ 5 files changed, 147 insertions(+), 71 deletions(-) -- 2.34.1

1 4

[PATCH v4 0/8] Implement detach device related APIs for test driver
by Luke Yue 03 Dec '21

03 Dec '21

diff to v3: - Add virDomainDeviceDefOperationsCallbacks to xmlopt for de-duplicating purpose - Add virDomainDeviceTypeFlags for de-duplicating purpose - Remove the memballoon helper function - Squash test_driver commits - Move test device xmls to generichotplugdata - Reimplement tests with internal APIs link to v3: https://listman.redhat.com/archives/libvir-list/2021-November/msg00288.html link to CI: https://gitlab.com/lukedyue/libvirt/-/pipelines/421921587 Luke Yue (8): conf: Introduce virDomainInputDefRemove and fix memory leak conf: Introduce virDomainDeviceDefOperationsCallbacks to xmlopt conf: Add virDomainDeviceTypeFlags and use it in various drivers conf: Add tpm helpers for future use domain_driver: extract DetachXXXDeviceConfig related functions and use them test_driver: Implement virDomainDetachDeviceFlags examples: xml: test: add xml for testing devices related APIs tests: Add generichotplugtest examples/xml/test/meson.build | 1 + examples/xml/test/testdomfc5.xml | 54 ++ examples/xml/test/testnodeinline.xml | 54 ++ src/bhyve/bhyve_domain.c | 2 +- src/ch/ch_conf.c | 2 +- src/conf/domain_conf.c | 572 +++++++++++++++++- src/conf/domain_conf.h | 135 ++++- src/conf/virconftypes.h | 2 + src/hyperv/hyperv_driver.c | 3 +- src/libvirt_private.syms | 21 + src/libxl/libxl_conf.c | 3 +- src/libxl/libxl_domain.c | 8 + src/libxl/libxl_domain.h | 1 + src/libxl/libxl_driver.c | 73 +-- src/lxc/lxc_conf.c | 3 +- src/lxc/lxc_domain.c | 7 + src/lxc/lxc_domain.h | 1 + src/lxc/lxc_driver.c | 62 +- src/openvz/openvz_conf.c | 2 +- src/qemu/qemu_conf.c | 3 +- src/qemu/qemu_domain.c | 39 ++ src/qemu/qemu_domain.h | 6 + src/qemu/qemu_driver.c | 204 +------ src/qemu/qemu_process.c | 2 +- src/security/virt-aa-helper.c | 2 +- src/test/test_driver.c | 197 +++++- src/vbox/vbox_common.c | 2 +- src/vmware/vmware_driver.c | 2 +- src/vmx/vmx.c | 2 +- src/vz/vz_driver.c | 2 +- tests/bhyveargv2xmltest.c | 2 +- .../generichotplug-controller.xml | 1 + .../generichotplug-disk-cdrom.xml | 5 + .../generichotplug-filesystem.xml | 6 + .../generichotplug-hostdev.xml | 5 + .../generichotplug-input.xml | 1 + .../generichotplug-interface.xml | 6 + .../generichotplug-lease.xml | 5 + .../generichotplug-memballoon.xml | 3 + .../generichotplug-memory.xml | 6 + .../generichotplugdata/generichotplug-rng.xml | 4 + .../generichotplug-shmem.xml | 4 + .../generichotplug-sound.xml | 3 + .../generichotplugdata/generichotplug-tpm.xml | 5 + .../generichotplug-vsock.xml | 3 + .../generichotplug-watchdog.xml | 1 + tests/generichotplugtest.c | 178 ++++++ tests/meson.build | 1 + tests/testutils.c | 2 +- 49 files changed, 1377 insertions(+), 331 deletions(-) create mode 100644 tests/generichotplugdata/generichotplug-controller.xml create mode 100644 tests/generichotplugdata/generichotplug-disk-cdrom.xml create mode 100644 tests/generichotplugdata/generichotplug-filesystem.xml create mode 100644 tests/generichotplugdata/generichotplug-hostdev.xml create mode 100644 tests/generichotplugdata/generichotplug-input.xml create mode 100644 tests/generichotplugdata/generichotplug-interface.xml create mode 100644 tests/generichotplugdata/generichotplug-lease.xml create mode 100644 tests/generichotplugdata/generichotplug-memballoon.xml create mode 100644 tests/generichotplugdata/generichotplug-memory.xml create mode 100644 tests/generichotplugdata/generichotplug-rng.xml create mode 100644 tests/generichotplugdata/generichotplug-shmem.xml create mode 100644 tests/generichotplugdata/generichotplug-sound.xml create mode 100644 tests/generichotplugdata/generichotplug-tpm.xml create mode 100644 tests/generichotplugdata/generichotplug-vsock.xml create mode 100644 tests/generichotplugdata/generichotplug-watchdog.xml create mode 100644 tests/generichotplugtest.c -- 2.34.1

1 8

Release of libvirt-7.10.0
by Jiri Denemark 03 Dec '21

03 Dec '21

The 7.10.0 release of both libvirt and libvirt-python is tagged and signed tarballs and source RPMs are available at https://libvirt.org/sources/ https://libvirt.org/sources/python/ Thanks everybody who helped with this release by sending patches, reviewing, testing, or providing feedback. Your work is greatly appreciated. * New features * Added virt-pki-query-dn binary This binary helps users figure out the format of Distinguished Name from a certificate file the way that libvirt expects it in tls_allowed_dn_list option of libvirtd.conf configuration file * Improvements * qemu: Report guest interface information in ``virDomainGetGuestInfo`` Libvirt is now able to report interface information from the guest's perspective (using guest agent). * qemu: detect guest side errors during device removal Libvirt is now able to detect guest side errors during device removal by using the DEVICE_UNPLUG_GUEST_ERROR event, available in QEMU 6.2.0. * Minimum SSF setting The libvirtd.conf option tcp_min_ssf can be used to override the minimum permitted security strength factor for non-TLS remote connections. The current hardcoded minimum is 56 (single-DES) and will be raised to 112 in the future. Setting a minimum lower than 112 is not supported. * qemu: Report stats also for block copy destination and backup job scratch images The statistics are available via the bulk domain stats API. * Bug fixes * qemu: Don't format 'ramfb' attribute when disabled Fix a regression caused by the conversion to JSON -device arguments where 'ramfb' would be put on the commandline of 'vfio-pci' which doesn't have it, thus breaking VMs with a mediated host device. * qemu: Fix block copy and backup to encrypted storage An oversight in last release lead to a spurious error being reported when encrypted storage was requested for disk images which are not directly backing the disk, which is now fixed. Enjoy. Jirka

4 3

[PATCH] Fix reboot command for LXC containers
by joachim.falk＠jfalk.de 03 Dec '21

03 Dec '21

From: Joachim Falk <joachim.falk(a)gmx.de> The virNetDaemonQuit(dmn) command in virLXCControllerSignalChildIO triggers an early close of all clients of lxc_controller. Here, libvirtd itself is a client of this controller, and the client connection is used to notify libvirtd if a reboot of the container is required. However, the client connection was closed before such a status could be sent to libvirtd. To fix this bug, we will immediately send the reboot or shutdown status of the container to libvirtd, and only after client disconnect will we trigger virNetDaemonQuit. Fixes: #237 Bug: https://gitlab.com/libvirt/libvirt/-/issues/237 Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=991773 Signed-off-by: Joachim Falk <joachim.falk(a)gmx.de> --- src/lxc/lxc_controller.c | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/src/lxc/lxc_controller.c b/src/lxc/lxc_controller.c index 444f728af4..039efcd7c7 100644 --- a/src/lxc/lxc_controller.c +++ b/src/lxc/lxc_controller.c @@ -894,8 +894,10 @@ static void virLXCControllerClientCloseHook(virNetServerClient *client) virLXCController *ctrl = virNetServerClientGetPrivateData(client); VIR_DEBUG("Client %p has closed", client); - if (ctrl->client == client) + if (ctrl->client == client) { ctrl->client = NULL; + VIR_DEBUG("Client has gone away"); + } if (ctrl->inShutdown) { VIR_DEBUG("Arm timer to quit event loop"); virEventUpdateTimeout(ctrl->timerShutdown, 0); @@ -1006,8 +1008,11 @@ static int lxcControllerClearCapabilities(void) static bool wantReboot; static virMutex lock = VIR_MUTEX_INITIALIZER; +static int +virLXCControllerEventSendExit(virLXCController *ctrl, + int exitstatus); -static void virLXCControllerSignalChildIO(virNetDaemon *dmn, +static void virLXCControllerSignalChildIO(virNetDaemon *dmn G_GNUC_UNUSED, siginfo_t *info G_GNUC_UNUSED, void *opaque) { @@ -1018,7 +1023,6 @@ static void virLXCControllerSignalChildIO(virNetDaemon *dmn, ret = waitpid(-1, &status, WNOHANG); VIR_DEBUG("Got sig child %d vs %lld", ret, (long long)ctrl->initpid); if (ret == ctrl->initpid) { - virNetDaemonQuit(dmn); virMutexLock(&lock); if (WIFSIGNALED(status) && WTERMSIG(status) == SIGHUP) { @@ -1026,6 +1030,7 @@ static void virLXCControllerSignalChildIO(virNetDaemon *dmn, wantReboot = true; } virMutexUnlock(&lock); + virLXCControllerEventSendExit(ctrl, wantReboot ? 1 : 0); } } @@ -2276,9 +2281,10 @@ virLXCControllerEventSendExit(virLXCController *ctrl, VIR_DEBUG("Waiting for client to complete dispatch"); ctrl->inShutdown = true; virNetServerClientDelayedClose(ctrl->client); - virNetDaemonRun(ctrl->daemon); + } else { + VIR_DEBUG("Arm timer to quit event loop"); + virEventUpdateTimeout(ctrl->timerShutdown, 0); } - VIR_DEBUG("Client has gone away"); return 0; } @@ -2430,8 +2436,6 @@ virLXCControllerRun(virLXCController *ctrl) rc = virLXCControllerMain(ctrl); - virLXCControllerEventSendExit(ctrl, rc); - cleanup: VIR_FORCE_CLOSE(control[0]); VIR_FORCE_CLOSE(control[1]); -- 2.30.2

2 1

[PATCH] Fix reboot command for LXC containers
by Joachim Falk 02 Dec '21

02 Dec '21

The virNetDaemonQuit(dmn) command in virLXCControllerSignalChildIO triggers an early close of all clients of lxc_controller. Here, libvirtd itself is a client of this controller, and the client connection is used to notify libvirtd if a reboot of the container is required. However, the client connection was closed before such a status could be sent to libvirtd. To fix this bug, we will immediately send the reboot or shutdown status of the container to libvirtd, and only after client disconnect will we trigger virNetDaemonQuit. Fixes: #237 Bug: https://gitlab.com/libvirt/libvirt/-/issues/237 Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=991773 Signed-off-by: Joachim Falk <joachim.falk(a)gmx.de> --- src/lxc/lxc_controller.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/src/lxc/lxc_controller.c b/src/lxc/lxc_controller.c index 444f728af4..75107822ba 100644 --- a/src/lxc/lxc_controller.c +++ b/src/lxc/lxc_controller.c @@ -894,8 +894,10 @@ static void virLXCControllerClientCloseHook(virNetServerClient *client) virLXCController *ctrl = virNetServerClientGetPrivateData(client); VIR_DEBUG("Client %p has closed", client); - if (ctrl->client == client) + if (ctrl->client == client) { ctrl->client = NULL; + VIR_DEBUG("Client has gone away"); + } if (ctrl->inShutdown) { VIR_DEBUG("Arm timer to quit event loop"); virEventUpdateTimeout(ctrl->timerShutdown, 0); @@ -1006,6 +1008,9 @@ static int lxcControllerClearCapabilities(void) static bool wantReboot; static virMutex lock = VIR_MUTEX_INITIALIZER; +static int +virLXCControllerEventSendExit(virLXCController *ctrl, + int exitstatus); static void virLXCControllerSignalChildIO(virNetDaemon *dmn, siginfo_t *info G_GNUC_UNUSED, @@ -1015,10 +1020,10 @@ static void virLXCControllerSignalChildIO(virNetDaemon *dmn, int ret; int status; + ignore_value(dmn); ret = waitpid(-1, &status, WNOHANG); VIR_DEBUG("Got sig child %d vs %lld", ret, (long long)ctrl->initpid); if (ret == ctrl->initpid) { - virNetDaemonQuit(dmn); virMutexLock(&lock); if (WIFSIGNALED(status) && WTERMSIG(status) == SIGHUP) { @@ -1026,6 +1031,7 @@ static void virLXCControllerSignalChildIO(virNetDaemon *dmn, wantReboot = true; } virMutexUnlock(&lock); + virLXCControllerEventSendExit(ctrl, wantReboot ? 1 : 0); } } @@ -2276,9 +2282,10 @@ virLXCControllerEventSendExit(virLXCController *ctrl, VIR_DEBUG("Waiting for client to complete dispatch"); ctrl->inShutdown = true; virNetServerClientDelayedClose(ctrl->client); - virNetDaemonRun(ctrl->daemon); + } else { + VIR_DEBUG("Arm timer to quit event loop"); + virEventUpdateTimeout(ctrl->timerShutdown, 0); } - VIR_DEBUG("Client has gone away"); return 0; } @@ -2430,8 +2437,6 @@ virLXCControllerRun(virLXCController *ctrl) rc = virLXCControllerMain(ctrl); - virLXCControllerEventSendExit(ctrl, rc); - cleanup: VIR_FORCE_CLOSE(control[0]); VIR_FORCE_CLOSE(control[1]); -- 2.30.2

2 2

[libvirt PATCH 0/5] Add bus-lock-ratelimit
by Tim Wiederhake 02 Dec '21

02 Dec '21

This was introduced recently in QEMU, see https://bugzilla.redhat.com/show_bug.cgi?id=1982165: Bus locks disrupts overall performance since it blocks all other cores (which must wait for the bus lock to be released before their memory operations). For VMM, it can detect every bus lock acquired by guest VMs and induces a VM exit. So VMM can count the number/frequency of bus lock and take some throttling action or just kill the guest. Tim Wiederhake (5): conf: Add bus-lock-ratelimit qemu: Add bus-lock-ratelimit doc: schema: Add bus-lock-ratelimit to domain schema tests: Add tests for bus-lock-ratelimit doc: Document new bus-lock-ratelimit option docs/formatdomain.rst | 4 +++ docs/schemas/domaincommon.rng | 7 +++++ src/conf/domain_conf.c | 34 +++++++++++++++++++++++ src/conf/domain_conf.h | 2 ++ src/qemu/qemu_command.c | 4 +++ src/qemu/qemu_validate.c | 1 + tests/qemuxml2argvdata/kvm-features.args | 2 +- tests/qemuxml2argvdata/kvm-features.xml | 1 + tests/qemuxml2xmloutdata/kvm-features.xml | 1 + 9 files changed, 55 insertions(+), 1 deletion(-) -- 2.31.1

2 6

[libvirt PATCH 00/14] qemu snapshot revert cleanup and refactor
by Pavel Hrdina 02 Dec '21

02 Dec '21

Pavel Hrdina (14): qemu_snapshot: revert: fix incorrect jump to cleanup qemu_snapshot: revert: drop unused variable qemu_snapshot: revert: use g_autoptr qemu_snapshot: revert: jump to endjob instead of calling qemuProcessEndJob qemu_snapshot: revert: remove cleanup label qemu_snapshot: revert: move validation to separate function qemu_snapshot: revert: move config prepare code to separate function qemu_snapshot: revert: emit event right after they are created qemu_snapshot: revert: refactor cleanup section qemu_snapshot: revert: move saving metadata to separate function qemu_snapshot: revert: save metadata within qemu process job qemu_snapshot: revert: move active snapshot revert to separate function qemu_snapshot: revert: rename qemuSnapshotRevertInactive qemu_snapshot: revert: move inactive snapshot to separate function src/qemu/qemu_snapshot.c | 554 ++++++++++++++++++++++----------------- 1 file changed, 320 insertions(+), 234 deletions(-) -- 2.31.1

2 16

[libvirt PATCH] qemu: Enable unprivileged userfaultfd for post-copy migration
by Jiri Denemark 02 Dec '21

02 Dec '21

Userfaultfd is by default allowed only for privileged processes. Since libvirt runs QEMU unprivileged, we need to enable unprivileged access to userfaultfd before starting post-copy migration. Rather than providing a static sysctl configuration file, we set the sysctl knob in runtime once post-copy migration is requested. This way unprivileged_userfaultfd is only enabled once actually used. https://bugzilla.redhat.com/show_bug.cgi?id=1945420 Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/qemu/qemu_migration_params.c | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/src/qemu/qemu_migration_params.c b/src/qemu/qemu_migration_params.c index dbc3219826..a9449ed1ff 100644 --- a/src/qemu/qemu_migration_params.c +++ b/src/qemu/qemu_migration_params.c @@ -804,6 +804,24 @@ qemuMigrationCapsToJSON(virBitmap *caps, } +static void +qemuMigrationParamsEnableUserfaultfd(virDomainObj *vm) +{ + const char *sysctl = "/proc/sys/vm/unprivileged_userfaultfd"; + + if (!virFileExists(sysctl)) + return; + + VIR_DEBUG("Enabling unprivileged userfaultfd for post-copy migration of " + "domain %s", vm->def->name); + + if (virFileWriteStr(sysctl, "1", 0) < 0) { + virReportSystemError(errno, "%s", + _("failed to enable unprivileged userfaultfd")); + } +} + + /** * qemuMigrationParamsApply * @driver: qemu driver @@ -839,6 +857,13 @@ qemuMigrationParamsApply(virQEMUDriver *driver, goto cleanup; } } else { + /* userfaultfd may only be enabled for privileged processes by default, + * we need to make sure QEMU can use it before enabling post-copy + * migration */ + if (virBitmapIsBitSet(priv->migrationCaps, QEMU_MIGRATION_CAP_POSTCOPY) && + virBitmapIsBitSet(migParams->caps, QEMU_MIGRATION_CAP_POSTCOPY)) + qemuMigrationParamsEnableUserfaultfd(vm); + if (!(caps = qemuMigrationCapsToJSON(priv->migrationCaps, migParams->caps))) goto cleanup; -- 2.34.1

3 2

[PATCH 0/3] qemu: Simplify qemuDomainGetStats() related code
by Michal Privoznik 02 Dec '21

02 Dec '21

*** BLURB HERE *** Michal Prívozník (3): qemu: Drop comma after QEMU_CAPS_LAST in queryDirtyRateRequired[] qemu: prefer .requiredCaps for VIR_DOMAIN_STATS_IOTHREAD qemuConnectGetAllDomainStats: Simplify qemuDomainGetStats() error handling src/qemu/qemu_driver.c | 36 ++++++++++++++++++------------------ 1 file changed, 18 insertions(+), 18 deletions(-) -- 2.32.0

2 4

[PATCH v2] virnetdevveth: Do report error if creating veth fails
by Michal Privoznik 02 Dec '21

02 Dec '21

For some weird reason we are ignoring errors when creating veth pair that netlink reports. This affects the LXC driver which creates interfaces for container in virLXCProcessSetupInterfaces(). If creating a veth pair fails, no error is reported and the control jumps onto cleanup label where some cryptic error message is reported instead (something about inability to remove veth pair). Let's report error that netlink returned - it's probably the most accurate reason anyways. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/225 Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- v2 of: https://listman.redhat.com/archives/libvir-list/2021-December/msg00016.html diff to v1: - Report error only if it wasn't already reported (error == 0) src/util/virnetdevveth.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/util/virnetdevveth.c b/src/util/virnetdevveth.c index 7133af44a2..b580e105ac 100644 --- a/src/util/virnetdevveth.c +++ b/src/util/virnetdevveth.c @@ -38,10 +38,19 @@ VIR_LOG_INIT("util.netdevveth"); static int virNetDevVethCreateInternal(const char *veth1, const char *veth2) { - int status; /* Just ignore it */ + int error = 0; virNetlinkNewLinkData data = { .veth_peer = veth2 }; - return virNetlinkNewLink(veth1, "veth", &data, &status); + if (virNetlinkNewLink(veth1, "veth", &data, &error) < 0) { + if (error != 0) { + virReportSystemError(-error, + _("unable to create %s <-> %s veth pair"), + veth1, veth2); + } + return -1; + } + + return 0; } static int -- 2.32.0

2 1