November 2021 - Devel - libvirt List Archives

[libvirt PATCH v2 00/12] Expose TPM availability in domain capabilities
by Daniel P. Berrangé 25 Nov '21

25 Nov '21

If we can report whuether TPM is available, then mgmt apps can enable it by default for new VMs. This is important because OS like Win11 consider TPM to be mandatory. In v2: - Avoid triggering reporting of errors when querying caps - Only skip reporting of emulator backend when swtpm is missing, not entire tpm suppport - Lots of refactoring to support point 1. Daniel P. Berrangé (12): util: use consistent naming for swtpm global variables util: rename typedef for parsing swtpm capabilities util: refactor TPM helper methods to reduce duplicationm util: replace TPM global variables with a struct array util: don't export virTPMEmulatorInit method util: ensure all TPM global vars access is protected by lock util: pull TPM capabilities probing out of main init method util: add a method for checking if swtpm is available conf: add TPM devices to domain capabilities qemu: fill in domain capabilities for TPMs qemu: mock swtpm initialization in tests run: detect daemons when run via wrapper commands docs/schemas/domaincaps.rng | 10 + run.in | 22 +- src/conf/domain_capabilities.c | 14 ++ src/conf/domain_capabilities.h | 10 + src/libvirt_private.syms | 2 +- src/qemu/qemu_capabilities.c | 34 +++ src/qemu/qemu_capabilities.h | 3 + src/qemu/qemu_tpm.c | 6 - src/util/virtpm.c | 232 ++++++++++-------- src/util/virtpm.h | 3 +- .../domaincapsdata/qemu_2.11.0-q35.x86_64.xml | 9 + .../domaincapsdata/qemu_2.11.0-tcg.x86_64.xml | 9 + tests/domaincapsdata/qemu_2.11.0.s390x.xml | 1 + tests/domaincapsdata/qemu_2.11.0.x86_64.xml | 9 + .../domaincapsdata/qemu_2.12.0-q35.x86_64.xml | 10 + .../domaincapsdata/qemu_2.12.0-tcg.x86_64.xml | 10 + .../qemu_2.12.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_2.12.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_2.12.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_2.12.0.s390x.xml | 1 + tests/domaincapsdata/qemu_2.12.0.x86_64.xml | 10 + .../domaincapsdata/qemu_3.0.0-q35.x86_64.xml | 10 + .../domaincapsdata/qemu_3.0.0-tcg.x86_64.xml | 10 + tests/domaincapsdata/qemu_3.0.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_3.0.0.s390x.xml | 1 + tests/domaincapsdata/qemu_3.0.0.x86_64.xml | 10 + .../domaincapsdata/qemu_3.1.0-q35.x86_64.xml | 10 + .../domaincapsdata/qemu_3.1.0-tcg.x86_64.xml | 10 + tests/domaincapsdata/qemu_3.1.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_3.1.0.x86_64.xml | 10 + .../domaincapsdata/qemu_4.0.0-q35.x86_64.xml | 10 + .../domaincapsdata/qemu_4.0.0-tcg.x86_64.xml | 10 + .../qemu_4.0.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_4.0.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_4.0.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_4.0.0.s390x.xml | 1 + tests/domaincapsdata/qemu_4.0.0.x86_64.xml | 10 + .../domaincapsdata/qemu_4.1.0-q35.x86_64.xml | 10 + .../domaincapsdata/qemu_4.1.0-tcg.x86_64.xml | 10 + tests/domaincapsdata/qemu_4.1.0.x86_64.xml | 10 + .../domaincapsdata/qemu_4.2.0-q35.x86_64.xml | 10 + .../domaincapsdata/qemu_4.2.0-tcg.x86_64.xml | 10 + .../qemu_4.2.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_4.2.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_4.2.0.ppc64.xml | 6 + tests/domaincapsdata/qemu_4.2.0.s390x.xml | 1 + tests/domaincapsdata/qemu_4.2.0.x86_64.xml | 10 + .../domaincapsdata/qemu_5.0.0-q35.x86_64.xml | 10 + .../domaincapsdata/qemu_5.0.0-tcg.x86_64.xml | 10 + .../qemu_5.0.0-virt.aarch64.xml | 9 + tests/domaincapsdata/qemu_5.0.0.aarch64.xml | 9 + tests/domaincapsdata/qemu_5.0.0.ppc64.xml | 10 + tests/domaincapsdata/qemu_5.0.0.x86_64.xml | 10 + .../domaincapsdata/qemu_5.1.0-q35.x86_64.xml | 10 + .../domaincapsdata/qemu_5.1.0-tcg.x86_64.xml | 10 + tests/domaincapsdata/qemu_5.1.0.sparc.xml | 1 + tests/domaincapsdata/qemu_5.1.0.x86_64.xml | 10 + .../domaincapsdata/qemu_5.2.0-q35.x86_64.xml | 10 + .../domaincapsdata/qemu_5.2.0-tcg.x86_64.xml | 10 + .../qemu_5.2.0-virt.aarch64.xml | 9 + tests/domaincapsdata/qemu_5.2.0.aarch64.xml | 9 + tests/domaincapsdata/qemu_5.2.0.ppc64.xml | 10 + tests/domaincapsdata/qemu_5.2.0.s390x.xml | 1 + tests/domaincapsdata/qemu_5.2.0.x86_64.xml | 10 + .../domaincapsdata/qemu_6.0.0-q35.x86_64.xml | 10 + .../domaincapsdata/qemu_6.0.0-tcg.x86_64.xml | 10 + .../qemu_6.0.0-virt.aarch64.xml | 9 + tests/domaincapsdata/qemu_6.0.0.aarch64.xml | 9 + tests/domaincapsdata/qemu_6.0.0.s390x.xml | 1 + tests/domaincapsdata/qemu_6.0.0.x86_64.xml | 10 + .../domaincapsdata/qemu_6.1.0-q35.x86_64.xml | 10 + .../domaincapsdata/qemu_6.1.0-tcg.x86_64.xml | 10 + tests/domaincapsdata/qemu_6.1.0.x86_64.xml | 10 + .../domaincapsdata/qemu_6.2.0-q35.x86_64.xml | 10 + .../domaincapsdata/qemu_6.2.0-tcg.x86_64.xml | 10 + .../qemu_6.2.0-virt.aarch64.xml | 9 + tests/domaincapsdata/qemu_6.2.0.aarch64.xml | 9 + tests/domaincapsdata/qemu_6.2.0.ppc64.xml | 10 + tests/domaincapsdata/qemu_6.2.0.x86_64.xml | 10 + tests/domaincapstest.c | 9 + 80 files changed, 731 insertions(+), 127 deletions(-) -- 2.33.1

2 24

[libvirt PATCH 0/7] do not check return value of qemuDomainObjExitMonitor
by Ján Tomko 25 Nov '21

25 Nov '21

Ján Tomko (7): qemu: qemuDomainObjExitMonitor: do not warn on unused result qemu: do not propagate return value of qemuDomainObjExitMonitor qemu: do not check return value of qemuDomainObjExitMonitor qemu: do not check return value of qemuDomainObjExitMonitor qemu: remove ignore_value for qemuDomainObjExitMonitor qemu: turn qemuDomainObjExitMonitor into void qemu: absorb qemuDomainObjExitMonitorInternal src/qemu/THREADS.txt | 5 - src/qemu/qemu_backup.c | 22 ++-- src/qemu/qemu_block.c | 28 ++-- src/qemu/qemu_blockjob.c | 31 ++--- src/qemu/qemu_checkpoint.c | 12 +- src/qemu/qemu_domain.c | 54 +++----- src/qemu/qemu_domain.h | 7 +- src/qemu/qemu_driver.c | 173 +++++++++++-------------- src/qemu/qemu_hotplug.c | 214 +++++++++++-------------------- src/qemu/qemu_migration.c | 65 +++++----- src/qemu/qemu_migration_cookie.c | 3 +- src/qemu/qemu_migration_params.c | 12 +- src/qemu/qemu_process.c | 75 +++++------ src/qemu/qemu_snapshot.c | 11 +- 14 files changed, 291 insertions(+), 421 deletions(-) -- 2.31.1

2 9

[PATCH v2 0/2] qemu_alias: Refactor functions
by Kristina Hanicova 25 Nov '21

25 Nov '21

This is v2 of: https://listman.redhat.com/archives/libvir-list/2021-November/msg00748.html Diff to v1: * changed return type of functions if possible - when function always returned success (suggested by Martin) Kristina Hanicova (2): qemu_alias: Rewrite of code pattern qemu_alias: change return type to void if possible src/qemu/qemu_alias.c | 185 +++++++++++++++------------------------- src/qemu/qemu_alias.h | 44 +++++----- src/qemu/qemu_hotplug.c | 43 ++++------ 3 files changed, 105 insertions(+), 167 deletions(-) -- 2.31.1

2 4

[PATCH v2] qemu: Rewrite code to the pattern
by Kristina Hanicova 25 Nov '21

25 Nov '21

I have seen this pattern a lot in the project, so I decided to rewrite code I stumbled upon to the same pattern as well. Signed-off-by: Kristina Hanicova <khanicov(a)redhat.com> --- This is v2 of: https://listman.redhat.com/archives/libvir-list/2021-November/msg00747.html Diff to v1: * adding variable 'rc' to fix buggy code and keep the code equivalent (suggested by Jano) src/qemu/qemu_driver.c | 22 +++++++++------------- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 1959b639da..5c4b493f64 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -15975,6 +15975,7 @@ qemuDomainSetBlockIoTune(virDomainPtr dom, g_autofree char *drivealias = NULL; const char *qdevid = NULL; int ret = -1; + int rc = 0; size_t i; virDomainDiskDef *conf_disk = NULL; virDomainDiskDef *disk; @@ -16229,13 +16230,10 @@ qemuDomainSetBlockIoTune(virDomainPtr dom, !virStorageSourceIsEmpty(disk->src)) { qemuDomainObjEnterMonitor(driver, vm); - ret = qemuMonitorSetBlockIoThrottle(priv->mon, drivealias, qdevid, - &info); - if (qemuDomainObjExitMonitor(driver, vm) < 0) - ret = -1; - if (ret < 0) + rc = qemuMonitorSetBlockIoThrottle(priv->mon, drivealias, qdevid, &info); + + if (qemuDomainObjExitMonitor(driver, vm) < 0 || rc < 0) goto endjob; - ret = -1; } virDomainDiskSetBlockIOTune(disk, &info); @@ -16310,6 +16308,7 @@ qemuDomainGetBlockIoTune(virDomainPtr dom, g_autofree char *drivealias = NULL; const char *qdevid = NULL; int ret = -1; + int rc = 0; int maxparams; virCheckFlags(VIR_DOMAIN_AFFECT_LIVE | @@ -16361,10 +16360,9 @@ qemuDomainGetBlockIoTune(virDomainPtr dom, goto endjob; } qemuDomainObjEnterMonitor(driver, vm); - ret = qemuMonitorGetBlockIoThrottle(priv->mon, drivealias, qdevid, &reply); - if (qemuDomainObjExitMonitor(driver, vm) < 0) - goto endjob; - if (ret < 0) + rc = qemuMonitorGetBlockIoThrottle(priv->mon, drivealias, qdevid, &reply); + + if (qemuDomainObjExitMonitor(driver, vm) < 0 || rc < 0) goto endjob; } @@ -17375,10 +17373,8 @@ qemuDomainSetTime(virDomainPtr dom, if (virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_RTC_RESET_REINJECTION)) { qemuDomainObjEnterMonitor(driver, vm); rv = qemuMonitorRTCResetReinjection(priv->mon); - if (qemuDomainObjExitMonitor(driver, vm) < 0) - goto endjob; - if (rv < 0) + if (qemuDomainObjExitMonitor(driver, vm) < 0 || rv < 0) goto endjob; } -- 2.31.1

3 2

[PATCH] util: fix cache invalidation of swtpm capabilities
by Daniel P. Berrangé 24 Nov '21

24 Nov '21

The check for whether the swtpm binary was modified is checking pointers to the mtime field in two distinct structs, so will always compare different. This resulted in re-probing swtpm capabilities every time, as many as 20 times for a single VM launch. Fixes: commit 01cf7a1bb9f1da27ad8bcbaa82c4f7a948c6a793 Author: Stefan Berger <stefanb(a)us.ibm.com> Date: Thu Jul 25 14:22:04 2019 -0400 tpm: Check whether previously found executables were updated Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- src/util/virtpm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virtpm.c b/src/util/virtpm.c index 8a77ba98ff..ffec23a535 100644 --- a/src/util/virtpm.c +++ b/src/util/virtpm.c @@ -301,7 +301,7 @@ virTPMEmulatorInit(void) findit = true; if (!findit && - &statbuf.st_mtime != &prgs[i].stat->st_mtime) + statbuf.st_mtime != prgs[i].stat->st_mtime) findit = true; } -- 2.33.1

4 3

[PATCH] qemu: Rewrite code to the pattern
by Kristina Hanicova 24 Nov '21

24 Nov '21

I have seen this pattern a lot in the project, so I decided to rewrite code I stumbled upon to the same pattern as well. Signed-off-by: Kristina Hanicova <khanicov(a)redhat.com> --- src/qemu/qemu_driver.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 1959b639da..b938687189 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -16231,10 +16231,9 @@ qemuDomainSetBlockIoTune(virDomainPtr dom, qemuDomainObjEnterMonitor(driver, vm); ret = qemuMonitorSetBlockIoThrottle(priv->mon, drivealias, qdevid, &info); - if (qemuDomainObjExitMonitor(driver, vm) < 0) - ret = -1; - if (ret < 0) + if (qemuDomainObjExitMonitor(driver, vm) < 0 || ret < 0) goto endjob; + ret = -1; } @@ -16362,9 +16361,7 @@ qemuDomainGetBlockIoTune(virDomainPtr dom, } qemuDomainObjEnterMonitor(driver, vm); ret = qemuMonitorGetBlockIoThrottle(priv->mon, drivealias, qdevid, &reply); - if (qemuDomainObjExitMonitor(driver, vm) < 0) - goto endjob; - if (ret < 0) + if (qemuDomainObjExitMonitor(driver, vm) < 0 || ret < 0) goto endjob; } @@ -17375,10 +17372,7 @@ qemuDomainSetTime(virDomainPtr dom, if (virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_RTC_RESET_REINJECTION)) { qemuDomainObjEnterMonitor(driver, vm); rv = qemuMonitorRTCResetReinjection(priv->mon); - if (qemuDomainObjExitMonitor(driver, vm) < 0) - goto endjob; - - if (rv < 0) + if (qemuDomainObjExitMonitor(driver, vm) < 0 || rv < 0) goto endjob; } -- 2.31.1

3 3

[libvirt PATCH 0/3] Expose TPM availability in domain capabilities
by Daniel P. Berrangé 24 Nov '21

24 Nov '21

If we can report whuether TPM is available, then mgmt apps can enable it by default for new VMs. This is important because OS like Win11 consider TPM to be mandatory. Daniel P. Berrangé (3): conf: add TPM devices to domain capabilities qemu: fill in domain capabilities for TPMs qemu: mock swtpm initialization in tests docs/schemas/domaincaps.rng | 10 ++++++ src/conf/domain_capabilities.c | 14 ++++++++ src/conf/domain_capabilities.h | 10 ++++++ src/qemu/qemu_capabilities.c | 32 +++++++++++++++++++ src/qemu/qemu_capabilities.h | 3 ++ .../domaincapsdata/qemu_2.11.0-q35.x86_64.xml | 9 ++++++ .../domaincapsdata/qemu_2.11.0-tcg.x86_64.xml | 9 ++++++ tests/domaincapsdata/qemu_2.11.0.s390x.xml | 6 ++++ tests/domaincapsdata/qemu_2.11.0.x86_64.xml | 9 ++++++ .../domaincapsdata/qemu_2.12.0-q35.x86_64.xml | 10 ++++++ .../domaincapsdata/qemu_2.12.0-tcg.x86_64.xml | 10 ++++++ .../qemu_2.12.0-virt.aarch64.xml | 6 ++++ tests/domaincapsdata/qemu_2.12.0.aarch64.xml | 6 ++++ tests/domaincapsdata/qemu_2.12.0.ppc64.xml | 6 ++++ tests/domaincapsdata/qemu_2.12.0.s390x.xml | 6 ++++ tests/domaincapsdata/qemu_2.12.0.x86_64.xml | 10 ++++++ .../domaincapsdata/qemu_3.0.0-q35.x86_64.xml | 10 ++++++ .../domaincapsdata/qemu_3.0.0-tcg.x86_64.xml | 10 ++++++ tests/domaincapsdata/qemu_3.0.0.ppc64.xml | 6 ++++ tests/domaincapsdata/qemu_3.0.0.s390x.xml | 6 ++++ tests/domaincapsdata/qemu_3.0.0.x86_64.xml | 10 ++++++ .../domaincapsdata/qemu_3.1.0-q35.x86_64.xml | 10 ++++++ .../domaincapsdata/qemu_3.1.0-tcg.x86_64.xml | 10 ++++++ tests/domaincapsdata/qemu_3.1.0.ppc64.xml | 6 ++++ tests/domaincapsdata/qemu_3.1.0.x86_64.xml | 10 ++++++ .../domaincapsdata/qemu_4.0.0-q35.x86_64.xml | 10 ++++++ .../domaincapsdata/qemu_4.0.0-tcg.x86_64.xml | 10 ++++++ .../qemu_4.0.0-virt.aarch64.xml | 4 +++ tests/domaincapsdata/qemu_4.0.0.aarch64.xml | 4 +++ tests/domaincapsdata/qemu_4.0.0.ppc64.xml | 4 +++ tests/domaincapsdata/qemu_4.0.0.s390x.xml | 4 +++ tests/domaincapsdata/qemu_4.0.0.x86_64.xml | 10 ++++++ .../domaincapsdata/qemu_4.1.0-q35.x86_64.xml | 10 ++++++ .../domaincapsdata/qemu_4.1.0-tcg.x86_64.xml | 10 ++++++ tests/domaincapsdata/qemu_4.1.0.x86_64.xml | 10 ++++++ .../domaincapsdata/qemu_4.2.0-q35.x86_64.xml | 10 ++++++ .../domaincapsdata/qemu_4.2.0-tcg.x86_64.xml | 10 ++++++ .../qemu_4.2.0-virt.aarch64.xml | 4 +++ tests/domaincapsdata/qemu_4.2.0.aarch64.xml | 4 +++ tests/domaincapsdata/qemu_4.2.0.ppc64.xml | 6 ++++ tests/domaincapsdata/qemu_4.2.0.s390x.xml | 4 +++ tests/domaincapsdata/qemu_4.2.0.x86_64.xml | 10 ++++++ .../domaincapsdata/qemu_5.0.0-q35.x86_64.xml | 10 ++++++ .../domaincapsdata/qemu_5.0.0-tcg.x86_64.xml | 10 ++++++ .../qemu_5.0.0-virt.aarch64.xml | 9 ++++++ tests/domaincapsdata/qemu_5.0.0.aarch64.xml | 9 ++++++ tests/domaincapsdata/qemu_5.0.0.ppc64.xml | 10 ++++++ tests/domaincapsdata/qemu_5.0.0.x86_64.xml | 10 ++++++ .../domaincapsdata/qemu_5.1.0-q35.x86_64.xml | 10 ++++++ .../domaincapsdata/qemu_5.1.0-tcg.x86_64.xml | 10 ++++++ tests/domaincapsdata/qemu_5.1.0.sparc.xml | 4 +++ tests/domaincapsdata/qemu_5.1.0.x86_64.xml | 10 ++++++ .../domaincapsdata/qemu_5.2.0-q35.x86_64.xml | 10 ++++++ .../domaincapsdata/qemu_5.2.0-tcg.x86_64.xml | 10 ++++++ .../qemu_5.2.0-virt.aarch64.xml | 9 ++++++ tests/domaincapsdata/qemu_5.2.0.aarch64.xml | 9 ++++++ tests/domaincapsdata/qemu_5.2.0.ppc64.xml | 10 ++++++ tests/domaincapsdata/qemu_5.2.0.s390x.xml | 4 +++ tests/domaincapsdata/qemu_5.2.0.x86_64.xml | 10 ++++++ .../domaincapsdata/qemu_6.0.0-q35.x86_64.xml | 10 ++++++ .../domaincapsdata/qemu_6.0.0-tcg.x86_64.xml | 10 ++++++ .../qemu_6.0.0-virt.aarch64.xml | 9 ++++++ tests/domaincapsdata/qemu_6.0.0.aarch64.xml | 9 ++++++ tests/domaincapsdata/qemu_6.0.0.s390x.xml | 4 +++ tests/domaincapsdata/qemu_6.0.0.x86_64.xml | 10 ++++++ .../domaincapsdata/qemu_6.1.0-q35.x86_64.xml | 10 ++++++ .../domaincapsdata/qemu_6.1.0-tcg.x86_64.xml | 10 ++++++ tests/domaincapsdata/qemu_6.1.0.x86_64.xml | 10 ++++++ .../domaincapsdata/qemu_6.2.0-q35.x86_64.xml | 10 ++++++ .../domaincapsdata/qemu_6.2.0-tcg.x86_64.xml | 10 ++++++ .../qemu_6.2.0-virt.aarch64.xml | 9 ++++++ tests/domaincapsdata/qemu_6.2.0.aarch64.xml | 9 ++++++ tests/domaincapsdata/qemu_6.2.0.ppc64.xml | 10 ++++++ tests/domaincapsdata/qemu_6.2.0.x86_64.xml | 10 ++++++ tests/domaincapstest.c | 9 ++++++ 75 files changed, 661 insertions(+) -- 2.33.1

4 14

[PATCH] util: virExec may blocked by reading pipe if grandchild prematurely exit
by Yi Wang 24 Nov '21

24 Nov '21

From: Xu Chao <xu.chao6(a)zte.com.cn> When VIR_EXEC_DAEMON is set, if virPidFileAcquirePath/virSetInherit failed, then pipesync[0] can not be closed when granchild process exit, because pipesync[1] still opened in child process. and then saferead in child process may blocked forever, and left grandchild process in defunct state. Signed-off-by: Xu Chao <xu.chao6(a)zte.com.cn> Signed-off-by: Yi Wang <wang.yi59(a)zte.com.cn> --- src/util/vircommand.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/util/vircommand.c b/src/util/vircommand.c index fead373729..fa71f40d81 100644 --- a/src/util/vircommand.c +++ b/src/util/vircommand.c @@ -782,6 +782,9 @@ virExec(virCommand *cmd) } if (pid > 0) { + /* close pipe[1], then the pipe can be closed if grandchild + * died prematurely */ + VIR_FORCE_CLOSE(pipesync[1]); /* The parent expect us to have written the pid file before * exiting. Wait here for the child to write it and signal us. */ if (cmd->pidfile && -- 2.27.0

2 1

[PATCH 0/4] virXXXListAdd: Transfer definition ownership
by Michal Privoznik 24 Nov '21

24 Nov '21

At a lot of places we have the following pattern: virXXXDef *def = parseDef(); if (!(obj = virXXXObjListAdd(def))) goto clenaup; def = NULL; cleanup: virXXXDefFree(def); The 'def = NULL' step is necessary because the ownership of the definition was transferred onto the object. Well, this approach is fragile as it relies on developers remembering to set the variable explicitly. If the virXXXObjListAdd() would take address of @def then the explicit set to NULL can be left out. Please note, I've reworked only a few virXXXObjListAdd() functions to see whether these are desired or not. If merged, I can post patches for the rest. Michal Prívozník (4): virInterfaceObjListAssignDef: Transfer definition ownership virSecretObjListAdd: Transfer definition ownership virStoragePoolObjListAdd: Transfer definition ownership virDomainObjListAdd: Transfer definition ownership src/bhyve/bhyve_driver.c | 6 ++---- src/ch/ch_driver.c | 7 ++----- src/conf/domain_conf.c | 8 ++++---- src/conf/domain_conf.h | 2 +- src/conf/virdomainobjlist.c | 22 +++++++++++++--------- src/conf/virdomainobjlist.h | 2 +- src/conf/virinterfaceobj.c | 25 +++++++++++++++++++------ src/conf/virinterfaceobj.h | 2 +- src/conf/virsecretobj.c | 26 ++++++++++++++------------ src/conf/virsecretobj.h | 2 +- src/conf/virstorageobj.c | 29 ++++++++++++++++------------- src/conf/virstorageobj.h | 2 +- src/libxl/libxl_domain.c | 3 +-- src/libxl/libxl_driver.c | 30 ++++++++++-------------------- src/libxl/libxl_migration.c | 6 ++---- src/lxc/lxc_driver.c | 24 ++++++++---------------- src/openvz/openvz_conf.c | 3 +-- src/openvz/openvz_driver.c | 10 ++++------ src/qemu/qemu_driver.c | 30 ++++++++++-------------------- src/qemu/qemu_migration.c | 3 +-- src/qemu/qemu_snapshot.c | 9 +++------ src/secret/secret_driver.c | 4 ++-- src/storage/storage_driver.c | 5 ++--- src/test/test_driver.c | 31 ++++++++++++------------------- src/vmware/vmware_conf.c | 6 ++---- src/vmware/vmware_driver.c | 10 ++++------ 26 files changed, 137 insertions(+), 170 deletions(-) -- 2.32.0

2 5

[PATCH 0/2] libxl: Remove dead code
by Jim Fehlig 24 Nov '21

24 Nov '21

I was too lazy to dig through history, but I think 1/2 was the result of too much copy and paste when originally implementing jobs in the libxl driver. For 2/2, I think there was some ill-conceived locking of the libxlDomainObjPrivate in the past. Its use was killed but the object remained virObjectLockable. Jim Fehlig (2): libxl: Remove unused macros libxl: Don't derive libxlDomainObjPrivate from virObjectLockable src/libxl/libxl_domain.c | 38 ++++++-------------------------------- src/libxl/libxl_domain.h | 7 ------- 2 files changed, 6 insertions(+), 39 deletions(-) -- 2.33.0

2 3