October 2020 - Devel - libvirt List Archives

[libvirt PATCH 0/9] qemu: use g_new0 (glib chronicles)
by Ján Tomko 06 Oct '20

06 Oct '20

With the exception of qemu_migrate_cookie and qemu_slirp which should be dealt with by Peter's series. Ján Tomko (9): qemu: separate out VIR_ALLOC calls qemu: capabilities: use g_new0 qemu: domain: use g_new0 qemu: driver: use g_new0 qemu: monitor: json: use g_new0 qemu: process: use g_new0 qemu: command: use g_new0 qemu: firmware: use g_new0 qemu: use g_new0 src/qemu/qemu_agent.c | 6 +- src/qemu/qemu_block.c | 15 ++--- src/qemu/qemu_capabilities.c | 48 +++++--------- src/qemu/qemu_cgroup.c | 6 +- src/qemu/qemu_command.c | 35 ++++------- src/qemu/qemu_conf.c | 20 +++--- src/qemu/qemu_domain.c | 55 ++++++---------- src/qemu/qemu_domain_address.c | 3 +- src/qemu/qemu_driver.c | 62 +++++++----------- src/qemu/qemu_firmware.c | 34 ++++------ src/qemu/qemu_hotplug.c | 29 ++++----- src/qemu/qemu_migration.c | 6 +- src/qemu/qemu_monitor.c | 13 +--- src/qemu/qemu_monitor_json.c | 112 +++++++++++---------------------- src/qemu/qemu_namespace.c | 3 +- src/qemu/qemu_process.c | 75 +++++++++------------- src/qemu/qemu_saveimage.c | 3 +- src/qemu/qemu_vhost_user.c | 17 +++-- 18 files changed, 190 insertions(+), 352 deletions(-) -- 2.26.2

3 15

[libvirt PATCH] examples: fix storage volume size schema
by Daniel P. Berrangé 06 Oct '20

06 Oct '20

There is no such <storage> element, <capacity> and <allocation> exist at the top level. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- examples/xml/storage/vol-cow.xml | 6 ++---- examples/xml/storage/vol-qcow.xml | 6 ++---- examples/xml/storage/vol-qcow2.xml | 6 ++---- examples/xml/storage/vol-raw.xml | 6 ++---- examples/xml/storage/vol-sparse.xml | 6 ++---- examples/xml/storage/vol-vmdk.xml | 6 ++---- 6 files changed, 12 insertions(+), 24 deletions(-) diff --git a/examples/xml/storage/vol-cow.xml b/examples/xml/storage/vol-cow.xml index 1d80a01f4b..f2bf1b4950 100644 --- a/examples/xml/storage/vol-cow.xml +++ b/examples/xml/storage/vol-cow.xml @@ -1,9 +1,7 @@ <volume type="file"> <name>cow.img</name> - <storage> - <allocation>0</allocation> - <capacity unit="T">1</capacity> - </storage> + <allocation>0</allocation> + <capacity unit="T">1</capacity> <target> <format type="cow"/> </target> diff --git a/examples/xml/storage/vol-qcow.xml b/examples/xml/storage/vol-qcow.xml index af2011d66a..6c30329f39 100644 --- a/examples/xml/storage/vol-qcow.xml +++ b/examples/xml/storage/vol-qcow.xml @@ -1,9 +1,7 @@ <volume type="file"> <name>qcow.img</name> - <storage> - <allocation>0</allocation> - <capacity unit="T">1</capacity> - </storage> + <allocation>0</allocation> + <capacity unit="T">1</capacity> <target> <format type="qcow"/> </target> diff --git a/examples/xml/storage/vol-qcow2.xml b/examples/xml/storage/vol-qcow2.xml index 9d944a78d7..14639da796 100644 --- a/examples/xml/storage/vol-qcow2.xml +++ b/examples/xml/storage/vol-qcow2.xml @@ -1,9 +1,7 @@ <volume type="file"> <name>qcow2.img</name> - <storage> - <allocation>0</allocation> - <capacity unit="T">1</capacity> - </storage> + <allocation>0</allocation> + <capacity unit="T">1</capacity> <target> <format type="qcow2"/> </target> diff --git a/examples/xml/storage/vol-raw.xml b/examples/xml/storage/vol-raw.xml index 59d4b457b1..bc4e049a35 100644 --- a/examples/xml/storage/vol-raw.xml +++ b/examples/xml/storage/vol-raw.xml @@ -1,7 +1,5 @@ <volume type="file"> <name>raw.img</name> - <storage> - <allocation unit="M">10</allocation> - <capacity unit="M">1000</capacity> - </storage> + <allocation unit="M">10</allocation> + <capacity unit="M">1000</capacity> </volume> diff --git a/examples/xml/storage/vol-sparse.xml b/examples/xml/storage/vol-sparse.xml index c529a490d9..2ec9f0b748 100644 --- a/examples/xml/storage/vol-sparse.xml +++ b/examples/xml/storage/vol-sparse.xml @@ -1,7 +1,5 @@ <volume type="file"> <name>sparse.img</name> - <storage> - <allocation>0</allocation> - <capacity unit="T">1</capacity> - </storage> + <allocation>0</allocation> + <capacity unit="T">1</capacity> </volume> diff --git a/examples/xml/storage/vol-vmdk.xml b/examples/xml/storage/vol-vmdk.xml index 5af0a8499f..05309a1438 100644 --- a/examples/xml/storage/vol-vmdk.xml +++ b/examples/xml/storage/vol-vmdk.xml @@ -1,9 +1,7 @@ <volume type="file"> <name>vmdk3.img</name> - <storage> - <allocation>0</allocation> - <capacity unit="T">1</capacity> - </storage> + <allocation>0</allocation> + <capacity unit="T">1</capacity> <target> <format type="vmdk"/> </target> -- 2.26.2

2 2

[PATCH] mailmap: consolidate my email addresses
by Matt Coleman 06 Oct '20

06 Oct '20

Signed-off-by: Matt Coleman <matt(a)datto.com> --- .mailmap | 1 + 1 file changed, 1 insertion(+) diff --git a/.mailmap b/.mailmap index 2b080568bc..9dfb7a832b 100644 --- a/.mailmap +++ b/.mailmap @@ -47,6 +47,7 @@ <fidencio(a)redhat.com> <fabiano(a)fidencio.org> <shi_lei(a)massclouds.com> <shilei.massclouds(a)gmx.com> <adrian.brzezinski(a)eo.pl> <redhat(a)adrb.pl> +<matt(a)datto.com> <mcoleman(a)datto.com> # Name consolidation: # Preferred author spelling <preferred email> -- 2.27.0

3 2

[libvirt PATCH 00/12] util: use g_new0 (glib chronicles)
by Ján Tomko 06 Oct '20

06 Oct '20

2 13

Re: [PATCH 1/1] Optional free-page-reporting can be enabled/disabled for memballon device of model 'virtio'.
by Peter Krempa 06 Oct '20

06 Oct '20

On Mon, Oct 05, 2020 at 17:40:48 -0400, Nico Pache wrote: > I'm not super familiar with the code base so followed the 2 > autodeflate commits as a guide. > > I had a few questions regarding your feedback. > > > > The patch is also missing test XML addition for the qemuxml2argvtest and > > qemuxml2xmltest. > > > can you please explain the qemuxml2xmltest files. I don't get what they do. qemuxml2argvtest takes the input file from qemuxml2argvdata/testname.xml which is a VM xml file and invokes internals which generate the command line which would be used to start qemu. This is then checked against qemuxml2argvdata/testname.args Similarly qemuxml2xmltest takes the same input file as the above test (literally the same, from the qemuxml2argv directory) and parses it and formats it back applying any internal validation and default filling. The output is compared against qemuxml2xmloutdata/testname.xml Note that you just have to provide the input file and invocation macro and you can then run the testsuite instructing it to generate the expected output files: VIR_TEST_REGENERATE_OUTPUT=1 tests/qemuxml2argvtest And commit the result after verifying that it has the new bits formatted. (Yes the testsuite will fail on the first round.) You can either provide your own input file, but it needs have certain settings (such as path to emulator) right to work with the tests so it's usually simpler to just copy and modify an appropriate existing test input file. The added bonus of the above is that those files are also automatically checked for conformance with the XML schema. Please note that any new tests added to the qemuxml2* test suite should use the DO_TEST_CAPS_* (such as DO_TEST_CAPS_LATEST, which invokes the test with capabilities of the latest version of x86_64 qemu) macros to invoke it rather than the now obsolete DO_TEST (without CAPS) where you are enumerating the qemu capability flags manually. > Also do I commit the additional testing files with the src/qemu changes or > in a separate commit? Either of them is fine. They just must apply, compile and pass the tests after every commit. > Will changing *virtio-balloon-pci.free-page-reporting* to > *virtio-balloon.free-page-reporting* encompass all the possible > virtio-balloon options? yup, that sounds reasonable > > Thanks in advance! > --Nico

1 0

[libvirt PATCH 0/4] virsh: use g_new0 (glib chronicles)
by Ján Tomko 06 Oct '20

06 Oct '20

Ján Tomko (4): virsh: do not add bools into size calculations virsh: use g_new0 instead of vsh[CM]alloc virsh: delete vsh[CM]alloc virsh: network-port: remove pointless comment tools/virsh-checkpoint.c | 11 +++++++---- tools/virsh-domain-monitor.c | 11 +++++------ tools/virsh-domain.c | 24 ++++++++++++------------ tools/virsh-host.c | 22 +++++++++++----------- tools/virsh-interface.c | 8 ++++---- tools/virsh-network.c | 9 ++++----- tools/virsh-nodedev.c | 12 ++++++------ tools/virsh-nwfilter.c | 8 ++++---- tools/virsh-pool.c | 8 ++++---- tools/virsh-secret.c | 6 +++--- tools/virsh-snapshot.c | 14 ++++++++------ tools/virsh-volume.c | 8 ++++---- tools/vsh.c | 30 ++++++------------------------ tools/vsh.h | 6 ------ 14 files changed, 78 insertions(+), 99 deletions(-) -- 2.26.2

2 5

[PATCH] rpm: Enable Xen support on AArch64
by Neal Gompa 05 Oct '20

05 Oct '20

Starting with Linux 5.9, Xen Dom0 works on commonly available AArch64 devices, such as the Raspberry Pi 4. Reference: https://xenproject.org/2020/09/29/xen-on-raspberry-pi-4-adventures/ Signed-off-by: Neal Gompa <ngompa13(a)gmail.com> --- libvirt.spec.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index aa2bc84be9..470782b23e 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -97,8 +97,8 @@ # Finally set the OS / architecture specific special cases -# Xen is available only on i386 x86_64 ia64 -%ifnarch %{ix86} x86_64 ia64 +# Xen is available only on i386 x86_64 ia64 aarch64 +%ifnarch %{ix86} x86_64 ia64 aarch64 %define with_libxl 0 %endif -- 2.26.2

4 5

restrictions for virtiofs (related to commit: 88957116c9 for libvirt 6.9.0)
by Masayoshi Mizuma 05 Oct '20

05 Oct '20

Hello Jan, and Michal, commit: 88957116c9 ("qemu: Use memory-backend-* for regular guest memory") gets the system memory sharable without numa config. The qemu options with the patch will be like as: -machine pc-q35-5.2,accel=kvm,usb=off,vmport=off,smm=on,dump-guest-core=off,memory-backend=pc.ram \ -object memory-backend-file,id=pc.ram,mem-path=/var/lib/libvirt/qemu/ram/2-Test/pc.ram,share=yes,size=17179869184 \ So, we can remove the numa restriction of virtiofs, right? The patch to remove that is the bottom of this email. And, 88957116c9 seems to introduce another restriction which we cannot create numa nodes on the machine. I got the following message when I set the numa config and started the VM: 2020-10-02T00:31:46.780374Z qemu-system-x86_64: '-machine memory-backend' and '-numa memdev' properties are mutually exclusive qemu rejects the -machine memory-backend' and '-numa memdev' because it may cause crash. commit: ea81f98bce ("numa: prevent usage of -M memory-backend and -numa memdev at the same time") introduced the check. Do you have any ideas to solve above? =================================================================== From: Masayoshi Mizuma <m.mizuma(a)jp.fujitsu.com> Date: Fri, 2 Oct 2020 10:50:06 -0400 Subject: [PATCH] qemu: Remove the number of numa restriction for virtiofs virtiofs requires at least one numa node to access the system memory as shared memory. 88957116c9 ("qemu: Use memory-backend-* for regular guest memory") gets the system memory sharable without the numa config. Let's remove the number of numa restriction for virtiofs. Signed-off-by: Masayoshi Mizuma <m.mizuma(a)jp.fujitsu.com> --- src/qemu/qemu_validate.c | 44 ++++++++++++++++++++-------------------- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index a212605579..b5372e7499 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -3475,36 +3475,36 @@ qemuValidateDomainDefVirtioFSSharedMemory(const virDomainDef *def) size_t numa_nodes = virDomainNumaGetNodeCount(def->numa); size_t i; - if (numa_nodes == 0) { + if ((!numa_nodes) && (def->mem.access != VIR_DOMAIN_MEMORY_ACCESS_SHARED)) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("virtiofs requires one or more NUMA nodes")); + _("virtiofs requires shared memory")); return -1; - } - - for (i = 0; i < numa_nodes; i++) { - virDomainMemoryAccess node_access = - virDomainNumaGetNodeMemoryAccessMode(def->numa, i); + } else { + for (i = 0; i < numa_nodes; i++) { + virDomainMemoryAccess node_access = + virDomainNumaGetNodeMemoryAccessMode(def->numa, i); - switch (node_access) { - case VIR_DOMAIN_MEMORY_ACCESS_DEFAULT: - if (def->mem.access != VIR_DOMAIN_MEMORY_ACCESS_SHARED) { + switch (node_access) { + case VIR_DOMAIN_MEMORY_ACCESS_DEFAULT: + if (def->mem.access != VIR_DOMAIN_MEMORY_ACCESS_SHARED) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("virtiofs requires shared memory")); + return -1; + } + break; + case VIR_DOMAIN_MEMORY_ACCESS_SHARED: + break; + case VIR_DOMAIN_MEMORY_ACCESS_PRIVATE: virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", _("virtiofs requires shared memory")); return -1; - } - break; - case VIR_DOMAIN_MEMORY_ACCESS_SHARED: - break; - case VIR_DOMAIN_MEMORY_ACCESS_PRIVATE: - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("virtiofs requires shared memory")); - return -1; - case VIR_DOMAIN_MEMORY_ACCESS_LAST: - default: - virReportEnumRangeError(virDomainMemoryAccess, node_access); - return -1; + case VIR_DOMAIN_MEMORY_ACCESS_LAST: + default: + virReportEnumRangeError(virDomainMemoryAccess, node_access); + return -1; + } } } return 0; -- 2.27.0 Thanks, Masa

2 3

[PATCHv3 4/5] qemu: add docs for 'fmode' and 'dmode' options
by Brian Turek 05 Oct '20

05 Oct '20

Adds documentation for QEMU 9pfs 'fmode' and 'dmode' options. Signed-off-by: Brian Turek <brian.turek(a)gmail.com> --- docs/formatdomain.rst | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index cc4f91d4ea..085f29ef8f 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -3062,6 +3062,12 @@ A directory on the host that can be accessed directly from the guest. <target dir='/import/from/host'/> <readonly/> </filesystem> + <filesystem type='mount' accessmode='mapped' fmode='644' dmode='755'> + <driver type='path'/> + <source dir='/export/to/guest'/> + <target dir='/import/from/host'/> + <readonly/> + </filesystem> <filesystem type='file' accessmode='passthrough'> <driver type='loop' format='raw'/> <source file='/export/to/guest.img'/> @@ -3140,6 +3146,12 @@ A directory on the host that can be accessed directly from the guest. "virtio-non-transitional", or "virtio". See `Virtio transitional devices <#elementsVirtioTransitional>`__ for more details. + The filesystem element has optional attributes ``fmode`` and ``dmode``. + These two attributes control the creation mode for files and directories + when used with the ``mapped`` value for ``accessmode`` (:since:`since 6.9.0, + requires QEMU 2.10` ). If not specified, QEMU creates files with mode + ``600`` and directories with mode ``700``. + The filesystem element has an optional attribute ``multidevs`` which specifies how to deal with a filesystem export containing more than one device, in order to avoid file ID collisions on guest when using 9pfs ( -- 2.25.1

1 0

[PATCHv3 3/5] qemu: add schema 'fmode' and 'dmode' options
by Brian Turek 05 Oct '20

05 Oct '20

Adds schema to validate the 'fmode' and 'dmode' attributes on a 'fileystem' node. Checks to ensure that the values are 1-4 octal digits long. Signed-off-by: Brian Turek <brian.turek(a)gmail.com> --- docs/schemas/domaincommon.rng | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng index 316d93fb69..6c814d600a 100644 --- a/docs/schemas/domaincommon.rng +++ b/docs/schemas/domaincommon.rng @@ -26,6 +26,12 @@ </element> </define> + <define name='createMode'> + <data type="unsignedInt"> + <param name='pattern'>[0-7]{1,4}</param> + </data> + </define> +  @@ -2736,6 +2742,16 @@ </choice> </attribute> </optional> + <optional> + <attribute name="fmode"> + <ref name='createMode'/> + </attribute> + </optional> + <optional> + <attribute name="dmode"> + <ref name='createMode'/> + </attribute> + </optional> <optional> <element name='readonly'> <empty/> -- 2.25.1

1 0