April 2019 - Devel - libvirt List Archives

[libvirt] [PATCH v1] network: Convert to virErrorRestore/virErrorPreserveLast
by Syed Humaid 23 Apr '19

23 Apr '19

Replaced usage of virSaveLastError and virSetError/virFreeError with virErrorPreserveLast and virErrorRestore respectively. Signed-off-by: Syed Humaid <syedhumaidbinharoon(a)gmail.com> --- src/network/bridge_driver.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index f824b8b4f3..dc21ac642c 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -2495,7 +2495,7 @@ networkStartNetworkVirtual(virNetworkDriverStatePtr driver, err4: if (!save_err) - save_err = virSaveLastError(); + virErrorPreserveLast(&save_err); dnsmasqPid = virNetworkObjGetDnsmasqPid(obj); if (dnsmasqPid > 0) { @@ -2505,18 +2505,18 @@ networkStartNetworkVirtual(virNetworkDriverStatePtr driver, err3: if (!save_err) - save_err = virSaveLastError(); + virErrorPreserveLast(&save_err); ignore_value(virNetDevSetOnline(def->bridge, 0)); err2: if (!save_err) - save_err = virSaveLastError(); + virErrorPreserveLast(&save_err); if (def->forward.type != VIR_NETWORK_FORWARD_OPEN) networkRemoveFirewallRules(def); err1: if (!save_err) - save_err = virSaveLastError(); + virErrorPreserveLast(&save_err); if (macTapIfName) { VIR_FORCE_CLOSE(tapfd); @@ -2528,13 +2528,10 @@ networkStartNetworkVirtual(virNetworkDriverStatePtr driver, err0: if (!save_err) - save_err = virSaveLastError(); + virErrorPreserveLast(&save_err); ignore_value(virNetDevBridgeDelete(def->bridge)); - if (save_err) { - virSetError(save_err); - virFreeError(save_err); - } + virErrorRestore(&save_err); /* coverity[leaked_handle] - 'tapfd' is not leaked */ return -1; } -- 2.20.1

2 1

[libvirt] [PATCH 0/3] Couple of mem leak fixes
by Michal Privoznik 23 Apr '19

23 Apr '19

*** BLURB HERE *** Michal Prívozník (3): qemucaps2xmltest: Don't leak @binary libxlDriverConfigDispose: Free @configBaseDir too vmx: Free @firmware in virVMXParseConfig src/libxl/libxl_conf.c | 1 + src/vmx/vmx.c | 1 + tests/qemucaps2xmltest.c | 3 +-- 3 files changed, 3 insertions(+), 2 deletions(-) -- 2.21.0

3 6

[libvirt] [PATCH 0/3] qemu: monitor: detect more snapshot errors
by Cole Robinson 23 Apr '19

23 Apr '19

qemu in Fedora 30 rejects migration if the VM has nested VMX configured. This means managedsave and snapshots are rejected too. Unfortunately the scraping we need to resort to with the text monitor snapshot commands is not detecting that 'savevm' actually failed, so the snapshot appears to succeed. https://bugzilla.redhat.com/show_bug.cgi?id=1697997 qemu 4.0.0 will add an 'Error: ' prefix to most hmp command errors (qemu commit 66363e9a43f), let's use that to detect error as well Cole Robinson (3): qemu: monitor: cleanup loadvm error handling qemu: monitor cleanup delvm error handling qemu: monitor: check for common 'Error: ' string src/qemu/qemu_monitor_text.c | 39 ++++++++++++++++++------------------ 1 file changed, 20 insertions(+), 19 deletions(-) -- 2.21.0

2 4

[libvirt] New Feature: Intel MKTME Support
by Carvalho, Larkins L 23 Apr '19

23 Apr '19

Hello Team, Greetings. We want to add Intel MKTME support to the Libvirt. Intel MKTME is a capability to encrypt entirety of physical memory of a system similar to AMD SEV. Please let us know what are the expectations from us to initiate the design and development of the feature. Regards, Larkins Carvalho Intel Corporation

5 15

[libvirt] [PATCH] news: add note about optional "Removed features" section
by Daniel P. Berrangé 18 Apr '19

18 Apr '19

Most releases don't need a "Removed features" section so don't include it in the template by default, but leave a reminder in case it is relevant. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- docs/news.xml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index b4926dd906..5346a25132 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -30,6 +30,12 @@ </section> </release> + If relevant for a given release, add a section for removed + features too + + <section title="Removed features"> + </section> + --> <libvirt> -- 2.20.1

2 1

[libvirt] [PATCH v3 0/2] qemu: Honor memory mode='strict'
by Michal Privoznik 18 Apr '19

18 Apr '19

v3 of: diff to v2: - Not calling qemuSetupCpusetMems() in qemuProcessLaunch - Dropping qemuSetupCpusetMems() Michal Prívozník (2): qemu: Set up EMULATOR thread and cpuset.mems before exec()-ing qemu qemu_cgroup: Remove unused qemuSetupCpusetMems src/qemu/qemu_cgroup.c | 35 ----------------------------------- src/qemu/qemu_cgroup.h | 1 - src/qemu/qemu_process.c | 8 ++++---- 3 files changed, 4 insertions(+), 40 deletions(-) -- 2.21.0

2 3

[libvirt] [PATCH 0/4] qemu_hotplug: Check for duplicate drive addresses
by Michal Privoznik 18 Apr '19

18 Apr '19

This is an alternative approach to: https://www.redhat.com/archives/libvir-list/2019-March/msg01111.html which caused regression to which a proposed fix is here: https://www.redhat.com/archives/libvir-list/2019-April/msg00756.html One of the selling points was that having this check in virDomainDefCompatibleDevice() will fix the problem across all drivers. Well, turns out, some drivers don't care (e.g. lxc) and some have a different workflow and thus don't need that check. Michal Prívozník (4): conf: Expose virDomainSCSIDriveAddressIsUsed qemuhotplugtest: Don't plug a SCSI disk at unit 7 qemu_hotplug: Check for duplicate drive addresses Revert "domain_conf: check device address before attach" src/conf/domain_conf.c | 11 +---------- src/conf/domain_conf.h | 4 ++++ src/libvirt_private.syms | 1 + src/qemu/qemu_hotplug.c | 6 ++++++ tests/qemuhotplugtest.c | 2 +- .../qemuhotplug-disk-scsi-2.xml | 2 +- ...-base-without-scsi-controller-live+disk-scsi-2.xml | 4 ++-- 7 files changed, 16 insertions(+), 14 deletions(-) -- 2.21.0

3 10

[libvirt] [PATCH 0/3] qemu: more firmware path improvements
by Daniel P. Berrangé 18 Apr '19

18 Apr '19

Daniel P. Berrangé (3): m4: allow default firmware list to be empty rpm: disable default firmware list on RHEL and Fedora >= 31 qemu: stop including real paths in nvram config option libvirt.spec.in | 6 +++++- m4/virt-loader-nvram.m4 | 16 ++++++++++------ src/qemu/qemu.conf | 11 +++++------ 3 files changed, 20 insertions(+), 13 deletions(-) -- 2.20.1

2 4

[libvirt] Why virsh domxml-to-native qemu-argv changes PCI slot number
by Tal Attaly 18 Apr '19

18 Apr '19

Hi, I have bridge type interface defined with slot 3 - <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/> but after running virsh domxml-to-native qemu-argv I get slot 2- -netdev tap,fd=21,id=hostnet0 -device e1000,netdev=hostnet0,id=net0,mac=f2:ff:ff:ff:ff:07,bus=pci.0,addr=0x2 Any idea why it's happen and how to keep the slot number? Libvirt version is 4.5.0 here is the full domain XML - <domain type='kvm' xmlns:qemu='http://libvirt.org/schemas/domain/qemu/1.0'> <name>vm1</name> <uuid>dbad303e-fc1b-454e-8861-712bf1766a64</uuid> <memory unit='KiB'>4194304</memory> <currentMemory unit='KiB'>4194304</currentMemory> <vcpu placement='static'>1</vcpu> <os> <type arch='x86_64' machine='pc-i440fx-2.12'>hvm</type> <boot dev='hd'/> </os> <features> <acpi/> <apic/> </features> <cpu mode='custom' match='exact' check='partial'> <model fallback='allow'>SandyBridge-IBRS</model> </cpu> <clock offset='utc'> <timer name='rtc' tickpolicy='catchup'/> <timer name='pit' tickpolicy='delay'/> <timer name='hpet' present='no'/> </clock> <on_poweroff>destroy</on_poweroff> <on_reboot>restart</on_reboot> <on_crash>destroy</on_crash> <pm> <suspend-to-mem enabled='no'/> <suspend-to-disk enabled='no'/> </pm> <devices> <emulator>/qemu/x86_64-softmmu/qemu-system-x86_64</emulator> <disk type='file' device='disk'> <driver name='qemu' type='qcow2'/> <source file='/var/lib/libvirt/images/vm.img'/> <target dev='hda' bus='ide'/> <address type='drive' controller='0' bus='0' target='0' unit='0'/> </disk> <controller type='usb' index='0' model='ich9-ehci1'> <address type='pci' domain='0x0000' bus='0x00' slot='0x04' function='0x7'/> </controller> <controller type='usb' index='0' model='ich9-uhci1'> <master startport='0'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x04' function='0x0' multifunction='on'/> </controller> <controller type='usb' index='0' model='ich9-uhci2'> <master startport='2'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x04' function='0x1'/> </controller> <controller type='usb' index='0' model='ich9-uhci3'> <master startport='4'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x04' function='0x2'/> </controller> <controller type='ide' index='0'> <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x1'/> </controller> <controller type='pci' index='0' model='pci-root'/> <interface type='bridge'> <mac address='f2:ff:ff:ff:ff:07'/> <source bridge='br0:'/> <model type='e1000'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/> </interface> <serial type='tcp'> <source mode='bind' host='10.210.27.119' service='9999'/> <protocol type='telnet'/> <target type='isa-serial' port='0'> <model name='isa-serial'/> </target> </serial> <console type='tcp'> <source mode='bind' host='10.210.27.119' service='9999'/> <protocol type='telnet'/> <target type='serial' port='0'/> </console> <input type='mouse' bus='ps2'/> <input type='keyboard' bus='ps2'/> <memballoon model='virtio'> <address type='pci' domain='0x0000' bus='0x00' slot='0x05' function='0x0'/> </memballoon> </devices> <qemu:commandline> <qemu:env name='CONFIG_FILE' value='/opt/cfg/qemu.cfg'/> </qemu:commandline> </domain> Thanks, Tal

3 2

[libvirt] [PATCH v1 0/4] RFC CPU Model Comparison via QMP
by Collin Walling 18 Apr '19

18 Apr '19

This is a preview of the CPU comparison (and soon baseline) patches. Comments are welcome on all aspects, as they will help guide the development of the baseline implementation. The first couple of patches simply refactor code. The first introduces an XML -> CPU def helper to be used to extract the CPU definition prior to sending it to the comparison functions. The second patch refactors some of the code from CPU model expansion to be later used by comparison and baseline. Currently, only one of the functions from the refactoring is reused for comparison. The other two will come into play when baseline is implemented. The third is the typical "new capability" patch to introduce query-cpu-model-comparison and test data for s390x. The last patch implements the qemuMonitorJSON function for query-cpu-model-comparison and hooks it up to virsh hypervisor-cpu-compare. This is posted as an RFC to make sure these patches are set in the correct direction before tackling the baseline patches. Thanks! Collin Walling (4): cpu_conf: xml to cpu definition parse helper qemu: monitor: helper functions for CPU models qemu_capabilities: introduce QEMU_CAPS_QUERY_CPU_MODEL_COMPARISON qemu: monitor: implement query-cpu-model-comparison src/conf/cpu_conf.c | 30 +++ src/conf/cpu_conf.h | 6 + src/cpu/cpu.c | 14 +- src/libvirt_private.syms | 1 + src/qemu/qemu_capabilities.c | 49 ++++ src/qemu/qemu_capabilities.h | 10 + src/qemu/qemu_driver.c | 10 + src/qemu/qemu_monitor.c | 22 ++ src/qemu/qemu_monitor.h | 10 + src/qemu/qemu_monitor_json.c | 223 +++++++++++++++--- src/qemu/qemu_monitor_json.h | 11 + .../caps_2.10.0.s390x.xml | 1 + .../caps_2.11.0.s390x.xml | 1 + .../caps_2.12.0.s390x.xml | 1 + .../qemucapabilitiesdata/caps_2.8.0.s390x.xml | 1 + .../qemucapabilitiesdata/caps_2.9.0.s390x.xml | 1 + .../qemucapabilitiesdata/caps_3.0.0.s390x.xml | 1 + 17 files changed, 343 insertions(+), 49 deletions(-) -- 2.20.1

2 8