March 2019 - Devel - libvirt List Archives

[libvirt] [PATCH 0/5] qemu: hotplug: Media change improvements (blockdev-add saga)
by Peter Krempa 02 Apr '19

02 Apr '19

First patch is not entirely relevant in this series. Peter Krempa (5): qemu: domain: Use VIR_AUTOFREE in qemuDomainObjPrivateXMLParseBlockjobs qemu: hotplug: Remove unused copies of virQEMUDriverConfigPtr qemu: hotplug: Use VIR_AUTOUNREF for virQEMUDriverConfigPtr qemu: hotplug: Disallow media change while blockjob is active qemu: domain: Forbid copy_on_read option also for floppies src/qemu/qemu_domain.c | 23 +++++++++++++------ src/qemu/qemu_hotplug.c | 51 ++++++++++++++++------------------------- 2 files changed, 36 insertions(+), 38 deletions(-) -- 2.20.1

2 10

[libvirt] Can jobs suck like qemu-pr-helper does be transfered to libvirtd?
by Zhangbo (Oscar) 02 Apr '19

02 Apr '19

Hi all: qemu-pr-helper exits to help qemu do the high-privileged scsi related jobs. LIBVIRTD is responsible to launch qemu-pr-helper and qemu, and set selinux/DAC labels for them and their socket. # # # # # ___________ # ___________|libvirtd |__________ # | |___________| | # | | | # | | | # _________|________ _____|______ ___|____ # | qemu-pr-helper |__| vm1.sock |_____| qemu1 | # |__________________| |____________| |________| There may be other jobs quite like qemu-pr-helper, shall we make them as "complex" as the qemu-pr-helper scheme? Will it be OK to just let qemu send an EVENT to libvirtd, and let libvirtd do the SCSI/other jobs? Will it be OK if we remove qemu-pr-helper and similar processes? What's the disadvantage if we let libvirtd do there high privileged jobs instead qemu-pr-helper-like processes? Thanks!

2 6

[libvirt] vcpupin reports bogus vcpu affinities
by Allen, John 02 Apr '19

02 Apr '19

Sent this out to the list a few days ago, but never saw it appear on the archives. Resending--hopefully this makes it to the list. --- For pinned vcpus, vcpupin will report inaccurate affinity values on machines with high core counts (256 cores in my case). The problem is produced as follows: $ virsh vcpupin myguest 0 4 $ virsh vcpupin myguest 0 VCPU CPU Affinity --------------------------- 0 4,192,194,196-197 Running taskset on the qemu threads shows the correct affinity, so this seems to be a reporting problem. Strangely, the value "192" is significant. If I pin a cpu greater than 192, the problem no longer appears. I believe the cause of the problem in my case is that in this case in src/conf/domain_conf.c:virDomainDefGetVcpuPinInfoHelper: ... if (vcpu && vcpu->cpumask) bitmap = vcpu->cpumask; ... vcpu->cpumask is "shortened" in that it is only long enough to contain the last set bit in the mask. However, when we go to copy the mask to the buffer that is returned, we use the masklen passed to the function which is the "full" masklen with a bit for each cpu. So it seems virBitmapToDataBuf copies some extra data past the end of the bitmask. Why the "192" value is always set and I typically see similar bogus bits set is still unknown. What is the function meant to assume in this case? Is it sane to assume that the bitmask is the full length of the buffer here and it's the responsibility of the setter of vcpu->cpumask to provide the length of the bitmap we're expecting? Or should we assume that we may receive a shortened bitmask here and expand the bitmask before copying to the buffer? -John

2 1

[libvirt] [PATCH v2 0/7] extend virsh domstate to show additional information
by Bjoern Walk 01 Apr '19

01 Apr '19

This patch series introduces the ability to save additional information for the domain state and exposes this information in virsh domstate. For example in the case of QEMU guest panic events, we can provide additional information like the crash reason or register state of the domain. This information usually gets logged in the domain log but for debugging it is useful to have it accessible from the client. Therefore, let's introduce a new public API function, virDomainGetStateParams, an extensible version of virDomainGetState, which returns the complete state of the domain, including newly introduced additional information. Let's also extend virsh domstate and introduce a new parameter --info to show the domain state, reason and additional information when available. virsh domstate --info guest1 crashed (panicked: s390: core='1' psw-mask='0x1234000000000000' \ psw-addr='0x0000000000001234' reason='disabled-wait') Previous version is here: https://www.redhat.com/archives/libvir-list/2018-July/msg00686.html v1 -> v2: * refactored the public API according to discussions to provide a more machine-parsable interface Bjoern Walk (7): qemu: monitor: move event data structure to domain qemu: domain: store and update panic info lib: introduce virDomainGetStateParams function remote: implement remoteDomainGetStateParams qemu: implement qemuDomainGetStateParams virsh: domstate: report detailed state if available news: add entry for virDomainGetStateParams docs/news.xml | 11 +++ include/libvirt/libvirt-domain.h | 76 +++++++++++++++++ src/driver-hypervisor.h | 9 ++ src/libvirt-domain.c | 64 ++++++++++++++ src/libvirt_public.syms | 1 + src/qemu/qemu_domain.c | 89 +++++++++++++++++++- src/qemu/qemu_domain.h | 47 +++++++++++ src/qemu/qemu_driver.c | 126 +++++++++++++++++++++++++++- src/qemu/qemu_monitor.c | 53 +----------- src/qemu/qemu_monitor.h | 48 ++--------- src/qemu/qemu_monitor_json.c | 20 ++--- src/qemu/qemu_process.c | 2 +- src/remote/remote_daemon_dispatch.c | 50 +++++++++++ src/remote/remote_driver.c | 44 ++++++++++ src/remote/remote_protocol.x | 22 ++++- src/remote_protocol-structs | 12 +++ tools/virsh-domain-monitor.c | 102 +++++++++++++++++++--- tools/virsh.pod | 5 +- 18 files changed, 658 insertions(+), 123 deletions(-) -- 2.17.0

2 21

[libvirt] [PATCH] apparmor: support QEMU hppa, nios2, or1k, riscv32 and riscv64
by intrigeri+libvirt＠boum.org 01 Apr '19

01 Apr '19

From: intrigeri <intrigeri+libvirt(a)boum.org> Fixes: https://bugs.debian.org/914940 --- src/security/apparmor/libvirt-qemu | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/security/apparmor/libvirt-qemu b/src/security/apparmor/libvirt-qemu index 474aaefdf8..165558fe83 100644 --- a/src/security/apparmor/libvirt-qemu +++ b/src/security/apparmor/libvirt-qemu @@ -103,6 +103,7 @@ /usr/bin/qemu-system-alpha rmix, /usr/bin/qemu-system-arm rmix, /usr/bin/qemu-system-cris rmix, + /usr/bin/qemu-system-hppa rmix, /usr/bin/qemu-system-i386 rmix, /usr/bin/qemu-system-lm32 rmix, /usr/bin/qemu-system-m68k rmix, @@ -113,10 +114,14 @@ /usr/bin/qemu-system-mips64el rmix, /usr/bin/qemu-system-mipsel rmix, /usr/bin/qemu-system-moxie rmix, + /usr/bin/qemu-system-nios2 rmix, + /usr/bin/qemu-system-or1k rmix, /usr/bin/qemu-system-or32 rmix, /usr/bin/qemu-system-ppc rmix, /usr/bin/qemu-system-ppc64 rmix, /usr/bin/qemu-system-ppcemb rmix, + /usr/bin/qemu-system-riscv32 rmix, + /usr/bin/qemu-system-riscv64 rmix, /usr/bin/qemu-system-s390x rmix, /usr/bin/qemu-system-sh4 rmix, /usr/bin/qemu-system-sh4eb rmix, -- 2.20.1

3 7

[libvirt] [PATCH v2 0/4] apps: update the listed libvirt apps
by Daniel P. Berrangé 01 Apr '19

01 Apr '19

Purge apps that are dead and fix broken links Daniel P. Berrangé (4): apps: remove dead archipel project apps: update link for buildbot apps: drop link for zenoss software apps: remove VM Manager android app docs/apps.html.in | 39 +-------------------------------------- 1 file changed, 1 insertion(+), 38 deletions(-) -- 2.20.1

2 5

[libvirt] Entering freeze for libvirt-5.2.0
by Daniel Veillard 01 Apr '19

01 Apr '19

I'm a bit late but the Candidate Release 1 is tagged in git and I have pushed the signed tarball and rpms to the usual place: ftp://libvirt.org/libvirt/ This seems to be working in my limited testing, the CI is mostly green https://ci.centos.org/view/libvirt/ except for a few side things, so with a bit of luck that will work well. I may push the RC2 saturday morning, and then if everything looks good we can have the release on Tuesday. In the meantime, give it a try, especially on different platforms or OSes, thanks, Daniel -- Daniel Veillard | Red Hat Developers Tools http://developer.redhat.com/ veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

1 1

[libvirt] [PATCH] news: Update for 5.2.0 release
by Andrea Bolognani 30 Mar '19

30 Mar '19

Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- docs/news.xml | 37 +++++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 2067830848..fcf8520132 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -148,8 +148,45 @@ tables are not required. </description> </change> + <change> + <summary> + Don't default to building the QEMU driver + </summary> + <description> + Historically, the QEMU driver has been special in that it was + enabled by default, with the option to explicitly opt-out of it; + starting now, we're enabling it opportunistically if we detect that + all requirements are available, just like we do with other drivers. + </description> + </change> </section> <section title="Bug fixes"> + <change> + <summary> + virt-host-validate: Fix IOMMU check on s390x + </summary> + </change> + <change> + <summary> + qemu: Allow creating pSeries guests with graphics and no USB mouse + </summary> + <description> + It's now possible to prevent libvirt from automatically adding a + USB mouse to pSeries guests by including a USB tablet in the input + XML: doing so is desiderable as using a tablet results in a much + better user experience when working with GUIs. + </description> + </change> + <change> + <summary> + qemu: Set $HOME and XGD variables for qemu:///system guests + </summary> + <description> + This avoids files being accidentally created under <code>/</code> or + the guests not being able to start because they lack the necessary + permissions to write to that location. + </description> + </change> </section> </release> <release version="v5.1.0" date="2019-03-04"> -- 2.20.1

2 1

[libvirt] [PATCH 0/4] apps: update the listed libvirt apps
by Daniel P. Berrangé 30 Mar '19

30 Mar '19

Purge apps that are dead and fix broken links Daniel P. Berrangé (4): apps: remove dead archipel project apps: update link for buildbot apps: update link for zenoss software apps: remove VM Manager android app docs/apps.html.in | 35 ++--------------------------------- 1 file changed, 2 insertions(+), 33 deletions(-) -- 2.20.1

2 10

[libvirt] [PATCH 0/6] qemu: caps: Clean up virQEMUCapsInitQMPMonitor
by Peter Krempa 29 Mar '19

29 Mar '19

Some cleanups done while attempting to implement a new capability. Peter Krempa (6): qemu: caps: Separate capabilities based on qemu version qemu: caps: Aggregate all caps post-processing into a function qemu: capabilities: Move logic deciding whether to probe into probing functions qemu: caps: Don't leak package name string in virQEMUCapsInitQMPMonitor qemu: caps: Remove cleanup section in virQEMUCapsInitQMPMonitor qemu: caps: Remove pointless debug message in virQEMUCapsInitQMPMonitor src/qemu/qemu_capabilities.c | 278 +++++++++++++++++++---------------- 1 file changed, 150 insertions(+), 128 deletions(-) -- 2.20.1

2 12