November 2019 - Devel - libvirt List Archives

[libvirt] [PATCH] src: lxc: Fix typo in a Makefile variable
by Michal Privoznik 11 Nov '19

11 Nov '19

In commit 0985a9597bb0348d46c0d18dc548a676bf0ad8e2 we stopped distributing generated source file. This is done by prepending binary_SOURCES variable with "nodist_". However, there is a typo - the prefix is "nodst_" instead of "nodist_". Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Pushed under trivial rule. src/lxc/Makefile.inc.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lxc/Makefile.inc.am b/src/lxc/Makefile.inc.am index d3a7cbf93b..6aaec09fb4 100644 --- a/src/lxc/Makefile.inc.am +++ b/src/lxc/Makefile.inc.am @@ -127,7 +127,7 @@ augeastest_DATA += lxc/test_virtlxcd.aug CLEANFILES += lxc/virtlxcd.aug virtlxcd_SOURCES = $(REMOTE_DAEMON_SOURCES) -nodst_virtlxcd_SOURCES = $(REMOTE_DAEMON_GENERATED) +nodist_virtlxcd_SOURCES = $(REMOTE_DAEMON_GENERATED) virtlxcd_CFLAGS = \ $(REMOTE_DAEMON_CFLAGS) \ -DDAEMON_NAME="\"virtlxcd\"" \ -- 2.23.0

1 0

[libvirt] [PATCH 0/5] Update news for versions from 5.7 to 5.8
by Han Han 11 Nov '19

11 Nov '19

Han Han (5): news: Support for kvm dedicated performance hint in 5.7 news: Support unmanaged macvtap devices in 5.8 news: Support to run SLIRP networking in a separate process in 5.8 news: Support vhost-user-gpu in 5.8 news: Introduce virConnectSetIdentity API in 5.8 docs/news.xml | 56 +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 56 insertions(+) -- 2.24.0.rc1

4 10

[libvirt] [PATCH] src: add missing include access path for bhyve and vz drivers
by Pavel Hrdina 08 Nov '19

08 Nov '19

Commit <b98f90cf913965243c6e2c49a52aa170a48093ef> forgot to update bhyve and vz Makefile files as well. Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- Pushed under build-breaker rule. src/bhyve/Makefile.inc.am | 1 + src/vz/Makefile.inc.am | 1 + 2 files changed, 2 insertions(+) diff --git a/src/bhyve/Makefile.inc.am b/src/bhyve/Makefile.inc.am index de9fbe9239..1fc100d5ab 100644 --- a/src/bhyve/Makefile.inc.am +++ b/src/bhyve/Makefile.inc.am @@ -42,6 +42,7 @@ libvirt_driver_bhyve_la_LDFLAGS = $(AM_LDFLAGS_MOD_NOUNDEF) libvirt_driver_bhyve_impl_la_CFLAGS = \ -I$(srcdir)/access \ + -I$(builddir)/access \ -I$(srcdir)/conf \ $(AM_CFLAGS) \ $(NULL) diff --git a/src/vz/Makefile.inc.am b/src/vz/Makefile.inc.am index 1757c8ba10..acada11148 100644 --- a/src/vz/Makefile.inc.am +++ b/src/vz/Makefile.inc.am @@ -29,6 +29,7 @@ libvirt_driver_vz_la_LDFLAGS = $(AM_LDFLAGS_MOD_NOUNDEF) libvirt_driver_vz_impl_la_CFLAGS = \ -I$(srcdir)/conf \ -I$(srcdir)/access \ + -I$(builddir)/access \ $(AM_CFLAGS) \ $(PARALLELS_SDK_CFLAGS) \ $(LIBNL_CFLAGS) \ -- 2.23.0

1 0

[libvirt] [jenkins-ci PATCH v2] Add python3-docutils package for libvirt
by Daniel P. Berrangé 08 Nov '19

08 Nov '19

This is needed to acquire the rst2html command line tool Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- guests/vars/mappings.yml | 5 +++++ guests/vars/projects/libvirt.yml | 1 + 2 files changed, 6 insertions(+) diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml index ba0f1cf..81d0916 100644 --- a/guests/vars/mappings.yml +++ b/guests/vars/mappings.yml @@ -795,6 +795,11 @@ mappings: default: polkit deb: policykit-1 + python3-docutils: + default: python3-docutils + CentOS7: python36-docutils + FreeBSD: py36-docutils + python2: default: python Fedora: python2 diff --git a/guests/vars/projects/libvirt.yml b/guests/vars/projects/libvirt.yml index 8fcb286..780a5aa 100644 --- a/guests/vars/projects/libvirt.yml +++ b/guests/vars/projects/libvirt.yml @@ -46,6 +46,7 @@ packages: - openwsman - parted - polkit + - python3-docutils - qemu-img - radvd - readline -- 2.23.0

2 2

[libvirt] [PATCH 0/2] qemu: Check for job being set when getting iothread stats
by Michal Privoznik 08 Nov '19

08 Nov '19

I've been playing with domstats and encountered a crasher. Here's the fix. Michal Prívozník (2): qemu: Warn on possibly incorrect usage of EnterMonitor* qemu: Check for job being set when getting iothread stats src/qemu/qemu_domain.c | 5 +++++ src/qemu/qemu_driver.c | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) -- 2.23.0

2 7

[libvirt] [jenkins-ci PATCH 0/5] Add Fedora 31, drop Fedora 29
by Andrea Bolognani 08 Nov '19

08 Nov '19

You know the drill :) Andrea Bolognani (5): guests: Explicitly enable ssh root login in kickstart guests: Add Fedora 31 Start building on Fedora 31 Stop building on Fedora 29 guests: Drop Fedora 29 guests/configs/kickstart.cfg | 12 +++ guests/configs/preseed.cfg | 12 ++- guests/host_vars/libvirt-fedora-29/docker.yml | 2 - guests/host_vars/libvirt-fedora-31/docker.yml | 2 + .../install.yml | 2 +- .../main.yml | 2 +- guests/inventory | 2 +- guests/playbooks/build/jobs/defaults.yml | 4 +- guests/playbooks/build/projects/libosinfo.yml | 2 +- .../playbooks/build/projects/libvirt-dbus.yml | 3 +- .../build/projects/libvirt-go-xml.yml | 2 +- .../playbooks/build/projects/libvirt-go.yml | 2 +- .../build/projects/libvirt-sandbox.yml | 4 +- .../playbooks/build/projects/libvirt-tck.yml | 4 +- guests/playbooks/build/projects/libvirt.yml | 2 +- .../build/projects/osinfo-db-tools.yml | 2 +- .../playbooks/build/projects/virt-manager.yml | 6 +- .../playbooks/build/projects/virt-viewer.yml | 2 +- guests/vars/vault.yml | 82 +++++++++---------- jenkins/jobs/defaults.yaml | 4 +- jenkins/projects/libosinfo.yaml | 2 +- jenkins/projects/libvirt-dbus.yaml | 4 +- jenkins/projects/libvirt-go-xml.yaml | 2 +- jenkins/projects/libvirt-go.yaml | 2 +- jenkins/projects/libvirt-sandbox.yaml | 4 +- jenkins/projects/libvirt-tck.yaml | 4 +- jenkins/projects/libvirt.yaml | 2 +- jenkins/projects/osinfo-db-tools.yaml | 2 +- jenkins/projects/virt-manager.yaml | 6 +- jenkins/projects/virt-viewer.yaml | 2 +- 30 files changed, 100 insertions(+), 83 deletions(-) delete mode 100644 guests/host_vars/libvirt-fedora-29/docker.yml create mode 100644 guests/host_vars/libvirt-fedora-31/docker.yml rename guests/host_vars/{libvirt-fedora-29 => libvirt-fedora-31}/install.yml (66%) rename guests/host_vars/{libvirt-fedora-29 => libvirt-fedora-31}/main.yml (95%) -- 2.21.0

3 11

[libvirt] [PATCH v2 0/2] Deprecate implicit filters
by Vladimir Sementsov-Ogievskiy 08 Nov '19

08 Nov '19

v2: Don't deprecate drive-backup, it is unrelated thing and will be resent in separate. Don't deprecate drive-mirror. Instead add filter-node-name to drive-mirror to behave like blockdev-mirror Fix all broken iotests. Vladimir Sementsov-Ogievskiy (2): qapi: add filter-node-name option to drive-mirror qapi: deprecate implicit filters qemu-deprecated.texi | 6 ++++++ qapi/block-core.json | 14 ++++++++++++-- include/block/block_int.h | 10 +++++++++- blockdev.c | 12 +++++++++++- tests/qemu-iotests/094 | 1 + tests/qemu-iotests/095 | 6 ++++-- tests/qemu-iotests/109 | 1 + tests/qemu-iotests/127 | 1 + tests/qemu-iotests/141 | 5 ++++- tests/qemu-iotests/144 | 3 ++- tests/qemu-iotests/156 | 1 + tests/qemu-iotests/161 | 7 +++++++ tests/qemu-iotests/161.out | 1 + tests/qemu-iotests/185 | 3 +++ tests/qemu-iotests/191 | 2 ++ tests/qemu-iotests/229 | 1 + tests/qemu-iotests/247 | 8 +++++--- tests/qemu-iotests/249 | 5 +++-- tests/qemu-iotests/249.out | 2 +- 19 files changed, 75 insertions(+), 14 deletions(-) -- 2.21.0

4 9

[libvirt] s390: change default cpu model to host-model?
by Christian Borntraeger 08 Nov '19

08 Nov '19

On the KVM forum I have discussed the default cpu model mode on s390. Right now if the xml does not specify anything, libvirt defaults to not specifying anything on the qemu command line (no -cpu statement) which is the equivalent of -cpu host for s390 which is equivalent to host-passthrough. While this enables all features it does not provide any migration safety by default. So in fact we are kind of "broken" right now when it comes to safery. So we discussed that it would make sense that an empty xml should actually be defaulted to host-model, which results in - as of today - the same guest features but in a migration safe way. There is another change planned right now to actually make the cpu model present in an xml if none was specified. So we could actually do this change before, together or after te other. Jiri and I think it probably makes most sense to have both changes at the same time (in terms of libvirt version). Does anyone see an issue with changing the default model mode to "host-model" if the xml does not specify anything else? Christian

3 10

[libvirt] [PATCH v2 00/39] Introduce NVMe support
by Michal Privoznik 08 Nov '19

08 Nov '19

v2 of: https://www.redhat.com/archives/libvir-list/2019-July/msg00675.html As usual, you can find my patches on my github: https://github.com/zippy2/libvirt/tree/nvme_v3 https://travis-ci.org/zippy2/libvirt/builds/590033775 (Yeah, my branch is really called _v3 because reasons) diff to v1: - A lot. Hopefully all Peter's comments are worked in Michal Prívozník (39): virhostdev: Fix const correctness of virHostdevIs{PCINet,SCSI,Mdev}Device() virhostdev: Introduce and use virHostdevIsVFIODevice conf: Introduce virDomainDefHasMdevHostdev qemu_hostdev: Introduce qemuHostdevNeedsVFIO() qemu: Introduce qemuDomainNeedsVFIO qemu_cgroup: Teardown Cgroup for more host device types qemu: Explicitly add/remove /dev/vfio/vfio to/from NS/CGroups qemu_domain: Drop few useless checks in qemuDomainGetHostdevPath qemuDomainGetHostdevPath: Drop @freeTmpPath qemuDomainGetHostdevPath: Use more VIR_AUTOFREE/VIR_AUTOPTR qemuDomainGetHostdevPath: Don't include /dev/vfio/vfio in returned paths qemu: Drop some 'cleanup' labels virpci: Introduce and use virPCIDeviceAddressGetIOMMUGroupDev virHostdevPreparePCIDevices: Separate out function body virHostdevReAttachPCIDevices: Separate out function body virpci: Introduce virPCIDeviceAddressCopy qemuMigrationSrcIsSafe: Rework slightly schemas: Introduce disk type NVMe conf: Format and parse NVMe type disk virstoragefile: Introduce virStorageSourceChainHasNVMe domain_conf: Introduce virDomainDefHasNVMeDisk util: Introduce virNVMeDevice module virhostdev: Include virNVMeDevice module virpcimock: Introduce NVMe driver and devices virhostdevtest: Test virNVMeDevice assignment qemu: prepare NVMe devices too qemu: Take NVMe disks into account when calculating memlock limit qemu: Create NVMe disk in domain namespace qemu: Mark NVMe disks as 'need VFIO' qemu: Allow NVMe disk in CGroups security_selinux: Simplify virSecuritySELinuxSetImageLabelInternal virSecuritySELinuxRestoreImageLabelInt: Don't skip non-local storage qemu_capabilities: Introduce QEMU_CAPS_DRIVE_NVME qemu: Generate command line of NVMe disks qemu_monitor_text: Catch IOMMU/VFIO related errors in qemuMonitorTextAddDrive qemu: Don't leak storage perms on failure in qemuDomainAttachDiskGeneric qemu: Allow forcing VFIO when computing memlock limit qemu_hotplug: Prepare NVMe disks on hotplug virsh: Introduce nvme disk to domblklist docs/formatdomain.html.in | 57 ++- docs/schemas/domaincommon.rng | 32 ++ src/conf/domain_conf.c | 129 ++++- src/conf/domain_conf.h | 6 + src/libvirt_private.syms | 30 ++ src/libxl/xen_xl.c | 1 + src/qemu/qemu_block.c | 25 + src/qemu/qemu_capabilities.c | 4 + src/qemu/qemu_capabilities.h | 3 + src/qemu/qemu_cgroup.c | 216 ++++++--- src/qemu/qemu_command.c | 6 +- src/qemu/qemu_domain.c | 409 +++++++++------- src/qemu/qemu_domain.h | 17 +- src/qemu/qemu_driver.c | 4 + src/qemu/qemu_hostdev.c | 80 ++- src/qemu/qemu_hostdev.h | 18 + src/qemu/qemu_hotplug.c | 39 +- src/qemu/qemu_migration.c | 30 +- src/qemu/qemu_monitor_text.c | 7 + src/qemu/qemu_process.c | 7 + src/security/security_apparmor.c | 33 +- src/security/security_dac.c | 30 ++ src/security/security_selinux.c | 82 ++-- src/util/Makefile.inc.am | 2 + src/util/virhostdev.c | 455 ++++++++++++++++-- src/util/virhostdev.h | 44 +- src/util/virnvme.c | 454 +++++++++++++++++ src/util/virnvme.h | 95 ++++ src/util/virpci.c | 29 ++ src/util/virpci.h | 5 + src/util/virstoragefile.c | 73 +++ src/util/virstoragefile.h | 19 + .../caps_2.12.0.aarch64.xml | 1 + .../caps_2.12.0.ppc64.xml | 1 + .../caps_2.12.0.s390x.xml | 1 + .../caps_2.12.0.x86_64.xml | 1 + .../qemucapabilitiesdata/caps_3.0.0.ppc64.xml | 1 + .../caps_3.0.0.riscv32.xml | 1 + .../caps_3.0.0.riscv64.xml | 1 + .../qemucapabilitiesdata/caps_3.0.0.s390x.xml | 1 + .../caps_3.0.0.x86_64.xml | 1 + .../qemucapabilitiesdata/caps_3.1.0.ppc64.xml | 1 + .../caps_3.1.0.x86_64.xml | 1 + .../caps_4.0.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_4.0.0.ppc64.xml | 1 + .../caps_4.0.0.riscv32.xml | 1 + .../caps_4.0.0.riscv64.xml | 1 + .../qemucapabilitiesdata/caps_4.0.0.s390x.xml | 1 + .../caps_4.0.0.x86_64.xml | 1 + .../caps_4.1.0.x86_64.xml | 1 + tests/qemumemlocktest.c | 2 +- .../disk-nvme.x86_64-latest.args | 53 ++ tests/qemuxml2argvdata/disk-nvme.xml | 63 +++ tests/qemuxml2argvtest.c | 1 + tests/qemuxml2xmloutdata/disk-nvme.xml | 1 + tests/qemuxml2xmltest.c | 1 + tests/virhostdevtest.c | 97 ++++ tests/virpcimock.c | 3 + tests/virpcitestdata/0000-01-00.0.config | Bin 0 -> 4096 bytes tests/virpcitestdata/0000-02-00.0.config | Bin 0 -> 4096 bytes tools/virsh-domain-monitor.c | 31 +- 61 files changed, 2330 insertions(+), 381 deletions(-) create mode 100644 src/util/virnvme.c create mode 100644 src/util/virnvme.h create mode 100644 tests/qemuxml2argvdata/disk-nvme.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/disk-nvme.xml create mode 120000 tests/qemuxml2xmloutdata/disk-nvme.xml create mode 100644 tests/virpcitestdata/0000-01-00.0.config create mode 100644 tests/virpcitestdata/0000-02-00.0.config -- 2.21.0

2 50

[libvirt] [jenkins-ci PATCH] Add python-docutils package for libvirt
by Daniel P. Berrangé 08 Nov '19

08 Nov '19

This is needed to acquire the rst2html command line tool Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- guests/vars/mappings.yml | 5 +++++ guests/vars/projects/libvirt.yml | 1 + 2 files changed, 6 insertions(+) diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml index ba0f1cf..a6df789 100644 --- a/guests/vars/mappings.yml +++ b/guests/vars/mappings.yml @@ -795,6 +795,11 @@ mappings: default: polkit deb: policykit-1 + python-docutils: + default: python3-docutils + CentOS7: python2-docutils + FreeBSD: py36-docutils + python2: default: python Fedora: python2 diff --git a/guests/vars/projects/libvirt.yml b/guests/vars/projects/libvirt.yml index 8fcb286..38a979a 100644 --- a/guests/vars/projects/libvirt.yml +++ b/guests/vars/projects/libvirt.yml @@ -46,6 +46,7 @@ packages: - openwsman - parted - polkit + - python-docutils - qemu-img - radvd - readline -- 2.23.0

2 1