May 2018 - Devel - Libvirt List Archives

[libvirt] [dbus PATCH v2 0/3] Domain Events

by Katerina Koukiou

Katerina Koukiou (3): events: Register VIR_DOMAIN_EVENT_ID_BLOCK_JOB_2 events: Register VIR_DOMAIN_EVENT_ID_GRAPHICS events: Register VIR_DOMAIN_EVENT_ID_IO_ERROR_REASON data/org.libvirt.Domain.xml | 25 ++++++++++ src/events.c | 119 ++++++++++++++++++++++++++++++++++++++++++++ src/util.h | 2 + 3 files changed, 146 insertions(+) -- 2.15.0

6 years, 6 months

2
6
0 / 0

[libvirt] [dbus PATCH] connect: Remove unused variable

by Andrea Bolognani

Clang catches the issue: ../../src/connect.c:532:26: error: unused variable 'domain' [-Werror,-Wunused-variable] g_autoptr(virDomain) domain = NULL; ^ Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- src/connect.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/connect.c b/src/connect.c index 6719e21..14a60dc 100644 --- a/src/connect.c +++ b/src/connect.c @@ -529,7 +529,6 @@ virtDBusConnectDomainSaveImageGetXMLDesc(GVariant *inArgs, GError **error) { virtDBusConnect *connect = userData; - g_autoptr(virDomain) domain = NULL; const gchar *file; guint flags; g_autofree gchar *xml = NULL; -- 2.17.0

6 years, 6 months

2
1
0 / 0

[libvirt] [PATCH 0/3] Finish replacements for virDomainObjCheckActive

by clem＠lse.epita.fr

From: Clementine Hayat <clem(a)lse.epita.fr> Follow-up of https://www.redhat.com/archives/libvir-list/2018-April/msg01591.html Here is the changes asked by Ján Tomko: * Refactor also checks when the error message is close to "domain is not running" * Add forgotten checks in qemu_migration.c * Revert one incorrect change in lxc_driver.c Clementine Hayat (3): qemu: start using virDomainObjCheckActive lxc: start using virDomainObjCheckActive bhyve: start using virDomainObjCheckActive src/bhyve/bhyve_driver.c | 15 +-- src/lxc/lxc_driver.c | 65 ++------- src/qemu/qemu_domain.c | 5 +- src/qemu/qemu_driver.c | 271 ++++++++------------------------------ src/qemu/qemu_migration.c | 10 +- 5 files changed, 74 insertions(+), 292 deletions(-) -- 2.17.0

6 years, 6 months

2
4
0 / 0

[libvirt] [PATCH 0/2] Some include cleanups

by Ján Tomko

Ján Tomko (2): virutil.c: do not include ioctl.h virutil.c: do not include stdarg.h src/util/virutil.c | 2 -- 1 file changed, 2 deletions(-) -- 2.16.1

6 years, 6 months

2
4
0 / 0

[libvirt] [PATCH] maint: typo fix in VIR_MIGRATE_PARAM_URI

by Eric Blake

s/filed/field/ Signed-off-by: Eric Blake <eblake(a)redhat.com> --- Pushing under the trivial rule include/libvirt/libvirt-domain.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h index 12fd34037e..d7cbd18796 100644 --- a/include/libvirt/libvirt-domain.h +++ b/include/libvirt/libvirt-domain.h @@ -837,7 +837,7 @@ typedef enum { * the destination host has multiple interfaces and a specific interface is * required to transmit migration data. * - * This filed may not be used when VIR_MIGRATE_TUNNELLED flag is set. + * This field may not be used when VIR_MIGRATE_TUNNELLED flag is set. */ # define VIR_MIGRATE_PARAM_URI "migrate_uri" -- 2.14.3

6 years, 6 months

1
0
0 / 0

[libvirt] [PATCH v5 0/7] Enable memory-backend-file.discard-data

by Michal Privoznik

v5 of: https://www.redhat.com/archives/libvir-list/2018-April/msg02029.html diff to v4: - last patch in the original series is split into two, - more tests added - couple of small changes (e.g. s/int/virTristateBool/) Michal Privoznik (7): qemuMonitorJSONGetDeviceProps: Separate props processing qemu_monitor: Introduce qemuMonitorGetObjectProps qemu_capabilities: Introduce QEMU_CAPS_QOM_LIST_PROPERTIES qemu_capabilities: Introduce QEMU_CAPS_OBJECT_MEMORY_FILE_DISCARD conf: Move virDomainMemtune formatting into a separate function conf: Introduce memoryBacking/discard qemu: Implement memoryBacking/discard docs/formatdomain.html.in | 34 +- docs/schemas/cputypes.rng | 5 + docs/schemas/domaincommon.rng | 10 + src/conf/domain_conf.c | 150 +- src/conf/domain_conf.h | 3 + src/conf/numa_conf.c | 27 + src/conf/numa_conf.h | 3 + src/libvirt_private.syms | 1 + src/qemu/qemu_capabilities.c | 22 + src/qemu/qemu_capabilities.h | 4 + src/qemu/qemu_command.c | 27 +- src/qemu/qemu_monitor.c | 13 + src/qemu/qemu_monitor.h | 3 + src/qemu/qemu_monitor_json.c | 89 +- src/qemu/qemu_monitor_json.h | 4 + .../caps_2.12.0.aarch64.replies | 416 +- tests/qemucapabilitiesdata/caps_2.12.0.aarch64.xml | 4 +- .../qemucapabilitiesdata/caps_2.12.0.ppc64.replies | 4454 ++++++++++---------- tests/qemucapabilitiesdata/caps_2.12.0.ppc64.xml | 4 +- .../qemucapabilitiesdata/caps_2.12.0.s390x.replies | 78 +- tests/qemucapabilitiesdata/caps_2.12.0.s390x.xml | 2 + .../caps_2.12.0.x86_64.replies | 804 ++-- tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml | 4 +- tests/qemuxml2argvdata/hugepages-pages.args | 12 +- tests/qemuxml2argvdata/hugepages-pages.xml | 3 +- tests/qemuxml2argvdata/hugepages-pages3.args | 3 +- tests/qemuxml2argvdata/hugepages-pages3.xml | 4 +- tests/qemuxml2argvdata/hugepages-pages7.args | 3 +- tests/qemuxml2argvdata/hugepages-pages7.xml | 4 +- tests/qemuxml2argvtest.c | 9 +- tests/qemuxml2xmloutdata/hugepages-pages.xml | 3 +- tests/qemuxml2xmloutdata/hugepages-pages3.xml | 4 +- 32 files changed, 3337 insertions(+), 2869 deletions(-) -- 2.16.1

6 years, 6 months

2
10
0 / 0

[libvirt] [PATCH v2 0/4] Reimplement logging wildcards to use full shell glob syntax

by Daniel P. Berrangé

This series provides a more generalized support for wildcards in logging and removes the ordering constraint. Changed in v2: - Improve various config file comments (Erik) - Always use fnmatch as performance hit vs strstr will be inconsequential in real world (Dan). Daniel P. Berrangé (4): Revert "util: virlog: Introduce wildcard to log filters" log: rename virLogFlags to virLogFilterFlags to match docs log: support logging using shell wildcard syntax log: update docs for daemons to improve user understanding src/locking/test_virtlockd.aug.in | 2 +- src/locking/virtlockd.conf | 65 +++++++++++++++++++++++++---------- src/logging/test_virtlogd.aug.in | 2 +- src/logging/virtlogd.conf | 68 +++++++++++++++++++++++++----------- src/remote/libvirtd.conf | 72 +++++++++++++++++++++++---------------- src/remote/test_libvirtd.aug.in | 2 +- src/util/virlog.c | 49 +++----------------------- src/util/virlog.h | 3 +- 8 files changed, 146 insertions(+), 117 deletions(-) -- 2.14.3

6 years, 6 months

2
10
0 / 0

[libvirt] [dbus PATCH 0/2] Fixes required before first release

by Katerina Koukiou

Katerina Koukiou (2): domain: Replace State property with GetState method Replace uint -> int wherever libvirt uses int type data/org.libvirt.Connect.xml | 18 +++++------ data/org.libvirt.Domain.xml | 26 +++++++++------- data/org.libvirt.Network.xml | 2 +- data/org.libvirt.Secret.xml | 2 +- data/org.libvirt.StoragePool.xml | 2 +- src/connect.c | 6 ++-- src/domain.c | 67 ++++++++++++++++++++++------------------ src/events.c | 12 +++---- src/network.c | 4 +-- src/secret.c | 2 +- src/storagepool.c | 2 +- tests/test_domain.py | 9 +++--- 12 files changed, 80 insertions(+), 72 deletions(-) -- 2.15.0

6 years, 6 months

3
6
0 / 0

[libvirt] [PATCH] virbuffer: Set child buffer indent properly

by Michal Privoznik

There's this macro virBufferSetChildIndent which sets offset of child buffer from given parent buffer. However, it is calling virBufferAdjustIndent() which only adds adjustment instead of calling virBufferSetIndent() which clears out any adjustment previously set. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/util/virbuffer.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virbuffer.h b/src/util/virbuffer.h index 4f5ed162fb..e95ee878a1 100644 --- a/src/util/virbuffer.h +++ b/src/util/virbuffer.h @@ -112,7 +112,7 @@ void virBufferSetIndent(virBufferPtr, int indent); * child buffer. */ # define virBufferSetChildIndent(childBuf_, parentBuf_) \ - virBufferAdjustIndent(childBuf_, virBufferGetIndent(parentBuf_, false) + 2) + virBufferSetIndent(childBuf_, virBufferGetIndent(parentBuf_, false) + 2) int virBufferGetIndent(const virBuffer *buf, bool dynamic); -- 2.16.1

6 years, 6 months

2
1
0 / 0

[libvirt] [dbus PATCH 00/22] StoragePool remains and Domain Events

by Katerina Koukiou

Katerina Koukiou (22): Implement StoragePoolCreateXML method for Connect Interface Implement StoragePoolDefineXML method for Connect Interface events: Register VIR_STORAGE_POOL_EVENT_ID_REFRESH events: Register VIR_DOMAIN_EVENT_ID_AGENT_LIFECYCLE events: Register VIR_DOMAIN_EVENT_ID_BALLOON_CHANGE events: Register VIR_DOMAIN_EVENT_ID_BLOCK_JOB events: Register VIR_DOMAIN_EVENT_ID_BLOCK_JOB_2 events: Register VIR_DOMAIN_EVENT_ID_CONTROL_ERROR events: Register VIR_DOMAIN_EVENT_ID_DEVICE_REMOVAL_FAILED events: Register VIR_DOMAIN_EVENT_ID_GRAPHICS events: Register VIR_DOMAIN_EVENT_ID_REBOOT events: Register VIR_DOMAIN_EVENT_ID_IO_ERROR events: Register VIR_DOMAIN_EVENT_ID_IO_ERROR_REASON events: Register VIR_DOMAIN_EVENT_ID_JOB_COMPLETED events: Register VIR_DOMAIN_EVENT_ID_METADATA_CHANGE events: Register VIR_DOMAIN_EVENT_ID_MIGRATION_ITERATION events: Register VIR_DOMAIN_EVENT_ID_PMSUSPEND events: Register VIR_DOMAIN_EVENT_ID_PMSUSPEND_DISK events: Register VIR_DOMAIN_EVENT_ID_PMWAKEUP events: Register VIR_DOMAIN_EVENT_ID_RTC_CHANGE events: Register VIR_DOMAIN_EVENT_ID_TUNABLE events: Register VIR_DOMAIN_EVENT_ID_WATCHDOG data/org.libvirt.Connect.xml | 14 + data/org.libvirt.Domain.xml | 108 ++++++++ data/org.libvirt.StoragePool.xml | 4 + src/connect.c | 62 +++++ src/events.c | 549 +++++++++++++++++++++++++++++++++++++++ tests/test_connect.py | 48 ++++ tests/test_storage.py | 10 + 7 files changed, 795 insertions(+) -- 2.15.0

6 years, 6 months

2
45
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Devel May 2018