[libvirt] [PATCH v2 0/4] qemu: track presence of blockjobs in status XML (blockdev-add saga)
by Peter Krempa
V2:
Patches 1/4 and 3/4 are new. Patch 2/4 and 4/4 were fixed to use
virTristateBool.
Peter Krempa (4):
util: Add functions to simplify bool->virTristate(Bool|Switch)
assignment
qemu: domain: Mark if no blockjobs are active in the status XML
qemu: process: Simplify acces to individual disk when reconnecting
qemu: process: Don't redetect backing chain on reconnect
src/libvirt_private.syms | 2 ++
src/qemu/qemu_domain.c | 38 ++++++++++++++++++++++++++++++++++++++
src/qemu/qemu_domain.h | 3 +++
src/qemu/qemu_process.c | 22 +++++++++++++---------
src/util/virutil.c | 20 ++++++++++++++++++++
src/util/virutil.h | 3 +++
tests/qemuxml2xmltest.c | 44 ++++++++++++++++++++++++++++++++++++++++++++
7 files changed, 123 insertions(+), 9 deletions(-)
--
2.14.1
7 years
[libvirt] [PATCH v3 0/3] qemu: Watchdog plug/unplug
by Michal Privoznik
v3 of:
https://www.redhat.com/archives/libvir-list/2017-September/msg00974.html
diff to v2:
- Peter's review worked int
- Dropped audit patch
- More check on watchdog device
Michal Privoznik (3):
qemuDomainDeviceDefValidate: Validate watchdog
qemu: hot-plug of watchdog
qemu: hot-unplug of watchdog
src/qemu/qemu_alias.c | 13 +-
src/qemu/qemu_alias.h | 2 +
src/qemu/qemu_command.c | 2 +-
src/qemu/qemu_command.h | 4 +-
src/qemu/qemu_domain.c | 51 ++++++++
src/qemu/qemu_driver.c | 14 ++-
src/qemu/qemu_hotplug.c | 139 +++++++++++++++++++++
src/qemu/qemu_hotplug.h | 6 +
src/qemu/qemu_monitor.c | 12 ++
src/qemu/qemu_monitor.h | 2 +
src/qemu/qemu_monitor_json.c | 28 +++++
src/qemu/qemu_monitor_json.h | 3 +
tests/qemuhotplugtest.c | 14 ++-
.../qemuhotplug-watchdog-full.xml | 4 +
.../qemuhotplug-watchdog.xml | 1 +
.../qemuhotplug-base-live+watchdog.xml | 56 +++++++++
16 files changed, 345 insertions(+), 6 deletions(-)
create mode 100644 tests/qemuhotplugtestdevices/qemuhotplug-watchdog-full.xml
create mode 100644 tests/qemuhotplugtestdevices/qemuhotplug-watchdog.xml
create mode 100644 tests/qemuhotplugtestdomains/qemuhotplug-base-live+watchdog.xml
--
2.13.5
7 years
[libvirt] [PATCH 0/6] qemu: track presence of blockjobs in status XML (blockdev-add saga)
by Peter Krempa
Add a flag to the status XML to tell that no blockjobs are running, so
that we don't have to reprobe the backing chain on libvirt restart when
no jobs were running.
Later on when we will be able to recover jobs we can improve that even
for running jobs.
Peter Krempa (6):
qemu: blockjob: Always save status XML after block event
qemu: blockjob: Always save config XML when a blockjob is finished
qemu: driver: Save status XML when starting a block job
tests: qemuxml2xml: Simplify adding to the status XML expect string
generator
qemu: domain: Mark if no blockjobs are active in the status XML
qemu: process: Don't redetect backing chain on reconnect
src/qemu/qemu_blockjob.c | 16 +++-------
src/qemu/qemu_domain.c | 39 +++++++++++++++++++++++
src/qemu/qemu_domain.h | 3 ++
src/qemu/qemu_driver.c | 32 ++++++++++---------
src/qemu/qemu_process.c | 19 +++++++----
tests/qemuxml2xmltest.c | 83 +++++++++++++++++++++++++++++++++++++-----------
6 files changed, 141 insertions(+), 51 deletions(-)
--
2.14.1
7 years
[libvirt] [PATCH] news: Document domifstat and QoS changes made recently
by Michal Privoznik
In cea3715b2e9 and d86fd2402e9d2 I've fixed domifstat and QoS
that was reversed for some types of interfaces. Document this
in the news file.
Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
---
docs/news.xml | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/docs/news.xml b/docs/news.xml
index 72e15567c..d1117154a 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -39,6 +39,17 @@
<section title="Improvements">
</section>
<section title="Bug fixes">
+ <change>
+ <summary>
+ Fix swapped interface statistics and QoS
+ </summary>
+ <description>
+ Due to internal implementation, reported statistics for
+ some types of interfaces were swapped (RX appeared in
+ TX and vice versa). Similarly, QoS was set in reversed
+ way. This is fixed now.
+ </description>
+ </change>
</section>
</release>
<release version="v3.8.0" date="2017-10-04">
--
2.13.6
7 years
[libvirt] [PATCH v1 0/7] qemu: Assign device aliases at define time
by Michal Privoznik
Rather big change because I had to update a lot of domain XMLs under tests/.
You can find the patches at mu github too:
https://github.com/zippy2/libvirt/commits/aliases
All the changes to the tests are result of VIR_TEST_REGENERATE_OUTPUT=1.
For more reference see:
https://bugzilla.redhat.com/show_bug.cgi?id=1434451
Michal Privoznik (7):
qemu_command: Drop useless alias checks
qemuAssignDeviceRNGAlias: Allow index to be passed
qemu: Move device alias assignment to separate functions
qemu: Allow regeneration of aliases
domain: Add virDomainDefAssignAliasesCallback
qemu: Assign device aliases at define time
conf: Format device alias into inactive XML too
src/conf/domain_conf.c | 14 +-
src/conf/domain_conf.h | 13 ++
src/qemu/qemu_alias.c | 225 +++++++++++++++++++--
src/qemu/qemu_alias.h | 7 +-
src/qemu/qemu_command.c | 21 +-
src/qemu/qemu_domain.c | 24 +++
src/qemu/qemu_driver.c | 2 +-
src/qemu/qemu_hotplug.c | 2 +-
src/qemu/qemu_process.c | 2 +-
.../disk_snapshot_redefine.xml | 21 +-
.../external_vm_redefine.xml | 16 +-
tests/domainsnapshotxml2xmlout/full_domain.xml | 16 +-
tests/domainsnapshotxml2xmlout/metadata.xml | 16 +-
tests/qemuargv2xmldata/qemuargv2xml-boot-cdrom.xml | 19 +-
.../qemuargv2xmldata/qemuargv2xml-boot-floppy.xml | 24 ++-
.../qemuargv2xmldata/qemuargv2xml-boot-network.xml | 19 +-
.../qemuargv2xml-clock-localtime.xml | 19 +-
tests/qemuargv2xmldata/qemuargv2xml-clock-utc.xml | 19 +-
.../qemuargv2xml-console-compat.xml | 21 +-
.../qemuargv2xml-disk-cdrom-empty.xml | 20 +-
tests/qemuargv2xmldata/qemuargv2xml-disk-cdrom.xml | 20 +-
.../qemuargv2xml-disk-drive-boot-cdrom.xml | 20 +-
.../qemuargv2xml-disk-drive-boot-disk.xml | 20 +-
.../qemuargv2xml-disk-drive-cache-directsync.xml | 20 +-
.../qemuargv2xml-disk-drive-cache-unsafe.xml | 20 +-
.../qemuargv2xml-disk-drive-cache-v2-none.xml | 20 +-
.../qemuargv2xml-disk-drive-cache-v2-wb.xml | 20 +-
.../qemuargv2xml-disk-drive-cache-v2-wt.xml | 20 +-
...muargv2xml-disk-drive-error-policy-enospace.xml | 20 +-
.../qemuargv2xml-disk-drive-error-policy-stop.xml | 20 +-
...xml-disk-drive-error-policy-wreport-rignore.xml | 20 +-
.../qemuargv2xml-disk-drive-fmt-qcow.xml | 20 +-
.../qemuargv2xml-disk-drive-network-gluster.xml | 19 +-
.../qemuargv2xml-disk-drive-network-iscsi-auth.xml | 19 +-
.../qemuargv2xml-disk-drive-network-iscsi.xml | 19 +-
.../qemuargv2xml-disk-drive-network-nbd-export.xml | 20 +-
...argv2xml-disk-drive-network-nbd-ipv6-export.xml | 20 +-
.../qemuargv2xml-disk-drive-network-nbd-ipv6.xml | 20 +-
.../qemuargv2xml-disk-drive-network-nbd-unix.xml | 20 +-
.../qemuargv2xml-disk-drive-network-nbd.xml | 20 +-
.../qemuargv2xml-disk-drive-network-rbd-auth.xml | 20 +-
...emuargv2xml-disk-drive-network-rbd-ceph-env.xml | 20 +-
.../qemuargv2xml-disk-drive-network-rbd-ipv6.xml | 20 +-
.../qemuargv2xml-disk-drive-network-rbd.xml | 23 ++-
.../qemuargv2xml-disk-drive-network-sheepdog.xml | 20 +-
.../qemuargv2xmldata/qemuargv2xml-disk-floppy.xml | 25 ++-
tests/qemuargv2xmldata/qemuargv2xml-disk-many.xml | 22 +-
tests/qemuargv2xmldata/qemuargv2xml-disk-usb.xml | 20 +-
.../qemuargv2xmldata/qemuargv2xml-disk-virtio.xml | 22 +-
.../qemuargv2xml-graphics-sdl-fullscreen.xml | 20 +-
.../qemuargv2xmldata/qemuargv2xml-graphics-sdl.xml | 20 +-
.../qemuargv2xml-graphics-vnc-policy.xml | 20 +-
.../qemuargv2xml-graphics-vnc-sasl.xml | 20 +-
.../qemuargv2xml-graphics-vnc-socket.xml | 20 +-
.../qemuargv2xml-graphics-vnc-tls.xml | 20 +-
.../qemuargv2xml-graphics-vnc-websocket.xml | 18 +-
.../qemuargv2xmldata/qemuargv2xml-graphics-vnc.xml | 20 +-
.../qemuargv2xml-hostdev-pci-address.xml | 20 +-
.../qemuargv2xml-hostdev-usb-address.xml | 20 +-
.../qemuargv2xmldata/qemuargv2xml-hyperv-panic.xml | 17 +-
tests/qemuargv2xmldata/qemuargv2xml-hyperv.xml | 17 +-
.../qemuargv2xml-input-usbmouse.xml | 23 ++-
.../qemuargv2xml-input-usbtablet.xml | 23 ++-
.../qemuargv2xmldata/qemuargv2xml-kvm-features.xml | 17 +-
tests/qemuargv2xmldata/qemuargv2xml-kvmclock.xml | 17 +-
.../qemuargv2xml-machine-aeskeywrap-off-argv.xml | 4 +-
.../qemuargv2xml-machine-aeskeywrap-on-argv.xml | 4 +-
.../qemuargv2xml-machine-core-off.xml | 19 +-
.../qemuargv2xml-machine-core-on.xml | 19 +-
.../qemuargv2xml-machine-deakeywrap-off-argv.xml | 4 +-
.../qemuargv2xml-machine-deakeywrap-on-argv.xml | 4 +-
.../qemuargv2xml-machine-keywrap-none-argv.xml | 4 +-
tests/qemuargv2xmldata/qemuargv2xml-mem-scale.xml | 19 +-
tests/qemuargv2xmldata/qemuargv2xml-migrate.xml | 19 +-
tests/qemuargv2xmldata/qemuargv2xml-misc-acpi.xml | 19 +-
.../qemuargv2xml-misc-disable-s3.xml | 19 +-
.../qemuargv2xml-misc-disable-suspends.xml | 19 +-
.../qemuargv2xml-misc-enable-s4.xml | 19 +-
.../qemuargv2xml-misc-no-reboot.xml | 19 +-
tests/qemuargv2xmldata/qemuargv2xml-misc-uuid.xml | 19 +-
.../qemuargv2xml-net-eth-ifname.xml | 20 +-
tests/qemuargv2xmldata/qemuargv2xml-net-eth.xml | 20 +-
tests/qemuargv2xmldata/qemuargv2xml-net-user.xml | 20 +-
tests/qemuargv2xmldata/qemuargv2xml-net-virtio.xml | 20 +-
.../qemuargv2xml-nographics-vga-display.xml | 19 +-
.../qemuargv2xml-nographics-vga.xml | 19 +-
.../qemuargv2xmldata/qemuargv2xml-nosharepages.xml | 19 +-
.../qemuargv2xmldata/qemuargv2xml-parallel-tcp.xml | 20 +-
.../qemuargv2xmldata/qemuargv2xml-pseries-disk.xml | 18 +-
.../qemuargv2xml-pseries-nvram.xml | 6 +-
.../qemuargv2xml-qemu-ns-no-env.xml | 19 +-
.../qemuargv2xml-reboot-timeout-disabled.xml | 17 +-
.../qemuargv2xml-reboot-timeout-enabled.xml | 17 +-
tests/qemuargv2xmldata/qemuargv2xml-restore-v2.xml | 19 +-
tests/qemuargv2xmldata/qemuargv2xml-serial-dev.xml | 21 +-
.../qemuargv2xmldata/qemuargv2xml-serial-file.xml | 21 +-
.../qemuargv2xmldata/qemuargv2xml-serial-many.xml | 22 +-
tests/qemuargv2xmldata/qemuargv2xml-serial-pty.xml | 21 +-
.../qemuargv2xml-serial-tcp-telnet.xml | 21 +-
tests/qemuargv2xmldata/qemuargv2xml-serial-tcp.xml | 21 +-
tests/qemuargv2xmldata/qemuargv2xml-serial-udp.xml | 22 +-
.../qemuargv2xmldata/qemuargv2xml-serial-unix.xml | 21 +-
tests/qemuargv2xmldata/qemuargv2xml-serial-vc.xml | 21 +-
tests/qemuargv2xmldata/qemuargv2xml-smp.xml | 19 +-
tests/qemuargv2xmldata/qemuargv2xml-sound.xml | 29 ++-
tests/qemuargv2xmldata/qemuargv2xml-watchdog.xml | 23 ++-
tests/qemuhotplugtest.c | 2 +-
.../ppc64-modern-bulk-result-conf.xml | 14 +-
.../ppc64-modern-individual-result-conf.xml | 14 +-
.../x86-modern-bulk-result-conf.xml | 14 +-
.../x86-modern-individual-add-result-conf.xml | 14 +-
.../x86-old-bulk-result-conf.xml | 14 +-
.../qemuxml2argv-blkdeviotune-group-num.xml | 17 +-
.../qemuxml2argv-blkdeviotune-max-length.xml | 17 +-
.../qemuxml2argv-blkdeviotune-max.xml | 17 +-
.../qemuxml2argv-disk-drive-detect-zeroes.xml | 17 +-
.../qemuxml2argv-encrypted-disk-usage.xml | 15 +-
.../qemuxml2argv-hostdev-scsi-vhost-scsi-ccw.xml | 4 +
.../qemuxml2argv-hostdev-scsi-vhost-scsi-pci.xml | 18 +-
.../qemuxml2argv-hugepages-memaccess.xml | 17 +-
.../qemuxml2argv-hugepages-memaccess2.xml | 17 +-
.../qemuxml2argv-hugepages-pages4.xml | 16 +-
.../qemuxml2argv-hugepages-pages5.xml | 16 +-
.../qemuxml2argv-hugepages-pages6.xml | 16 +-
.../qemuxml2argv-hugepages-pages7.xml | 17 +-
.../qemuxml2argv-intel-iommu-caching-mode.xml | 22 +-
.../qemuxml2argv-intel-iommu-device-iotlb.xml | 17 +-
.../qemuxml2argv-intel-iommu-eim.xml | 17 +-
tests/qemuxml2argvdata/qemuxml2argv-luks-disks.xml | 16 +-
.../qemuxml2argv-memory-hotplug-nvdimm-access.xml | 17 +-
.../qemuxml2argv-memory-hotplug-nvdimm-label.xml | 17 +-
.../qemuxml2argv-memory-hotplug-nvdimm.xml | 17 +-
.../qemuxml2argv-net-user-addr.xml | 20 +-
...muxml2argv-serial-tcp-tlsx509-chardev-notls.xml | 19 +-
.../qemuxml2argv-virtio-options.xml | 27 ++-
tests/qemuxml2argvtest.c | 9 +
.../qemuxml2xmlout-aarch64-aavmf-virtio-mmio.xml | 6 +
.../qemuxml2xmlout-aarch64-gic-none-tcg.xml | 4 +-
.../qemuxml2xmlout-aarch64-pci-serial.xml | 8 +-
.../qemuxml2xmlout-aarch64-video-default.xml | 8 +-
...qemuxml2xmlout-aarch64-video-virtio-gpu-pci.xml | 8 +-
.../qemuxml2xmlout-aarch64-virtio-pci-default.xml | 18 +-
...2xmlout-aarch64-virtio-pci-manual-addresses.xml | 11 +-
.../qemuxml2xmlout-acpi-table.xml | 18 +-
.../qemuxml2xmlout-autoindex.xml | 47 ++++-
.../qemuxml2xmlout-balloon-device-auto.xml | 16 +-
.../qemuxml2xmlout-balloon-device-period.xml | 16 +-
.../qemuxml2xmlout-bios-nvram-os-interleave.xml | 22 +-
.../qemuxml2xmlout-bios-nvram.xml | 20 +-
.../qemuxml2xmlout-blkdeviotune.xml | 17 +-
.../qemuxml2xmlout-blkiotune-device.xml | 16 +-
.../qemuxml2xmlout-blkiotune.xml | 16 +-
.../qemuxml2xmlout-boot-cdrom.xml | 19 +-
.../qemuxml2xmlout-boot-floppy-q35.xml | 22 +-
.../qemuxml2xmlout-boot-floppy.xml | 24 ++-
...muxml2xmlout-boot-menu-disable-with-timeout.xml | 16 +-
.../qemuxml2xmlout-boot-menu-disable.xml | 16 +-
...emuxml2xmlout-boot-menu-enable-with-timeout.xml | 16 +-
.../qemuxml2xmlout-boot-multi.xml | 16 +-
.../qemuxml2xmlout-boot-network.xml | 19 +-
.../qemuxml2xmlout-boot-order.xml | 24 ++-
.../qemuxml2xmlout-bootindex-floppy-q35.xml | 22 +-
.../qemuxml2xmlout-channel-guestfwd.xml | 17 +-
.../qemuxml2xmlout-channel-unix-source-path.xml | 22 +-
.../qemuxml2xmlout-channel-virtio-auto.xml | 25 ++-
.../qemuxml2xmlout-channel-virtio-state-active.xml | 20 +-
...emuxml2xmlout-channel-virtio-state-inactive.xml | 20 +-
.../qemuxml2xmlout-channel-virtio.xml | 18 +-
.../qemuxml2xmlout-chardev-label.xml | 19 +-
.../qemuxml2xmlout-clock-catchup.xml | 16 +-
.../qemuxml2xmlout-clock-localtime.xml | 19 +-
.../qemuxml2xmlout-clock-timer-hyperv-rtc.xml | 14 +-
.../qemuxml2xmlout-clock-utc.xml | 19 +-
.../qemuxml2xmlout-console-compat-auto.xml | 18 +-
.../qemuxml2xmlout-console-compat.xml | 21 +-
.../qemuxml2xmlout-console-compat2.xml | 23 ++-
.../qemuxml2xmlout-console-virtio-many.xml | 22 +-
.../qemuxml2xmlout-console-virtio.xml | 18 +-
.../qemuxml2xmlout-controller-usb-order.xml | 16 +-
.../qemuxml2xmlout-cpu-check-default-none.xml | 14 +-
.../qemuxml2xmlout-cpu-check-default-none2.xml | 14 +-
.../qemuxml2xmlout-cpu-check-default-partial.xml | 14 +-
.../qemuxml2xmlout-cpu-check-default-partial2.xml | 14 +-
.../qemuxml2xmlout-cpu-check-full.xml | 14 +-
.../qemuxml2xmlout-cpu-check-none.xml | 14 +-
.../qemuxml2xmlout-cpu-check-partial.xml | 14 +-
.../qemuxml2xmlout-cpu-empty.xml | 14 +-
.../qemuxml2xmlout-cpu-eoi-disabled.xml | 14 +-
.../qemuxml2xmlout-cpu-eoi-enabled.xml | 14 +-
.../qemuxml2xmlout-cpu-host-kvmclock.xml | 14 +-
.../qemuxml2xmlout-cpu-host-model-features.xml | 15 +-
...emuxml2xmlout-cpu-host-passthrough-features.xml | 16 +-
.../qemuxml2xmlout-cpu-kvmclock.xml | 14 +-
.../qemuxml2xmlout-cpu-numa-disjoint.xml | 14 +-
.../qemuxml2xmlout-cpu-numa-disordered.xml | 14 +-
.../qemuxml2xmlout-cpu-numa-memshared.xml | 14 +-
.../qemuxml2xmlout-cpu-numa-no-memory-element.xml | 14 +-
.../qemuxml2xmlout-cpu-numa1.xml | 14 +-
.../qemuxml2xmlout-cpu-numa2.xml | 14 +-
.../qemuxml2xmlout-cputune-iothreads.xml | 16 +-
...l2xmlout-cputune-iothreadsched-zeropriority.xml | 16 +-
.../qemuxml2xmlout-cputune-iothreadsched.xml | 16 +-
.../qemuxml2xmlout-cputune-numatune.xml | 17 +-
.../qemuxml2xmlout-cputune-zero-shares.xml | 16 +-
.../qemuxml2xmloutdata/qemuxml2xmlout-cputune.xml | 16 +-
.../qemuxml2xmlout-default-kvm-host-arch.xml | 14 +-
.../qemuxml2xmlout-default-qemu-host-arch.xml | 14 +-
.../qemuxml2xmlout-disk-active-commit.xml | 16 +-
.../qemuxml2xmloutdata/qemuxml2xmlout-disk-aio.xml | 17 +-
.../qemuxml2xmlout-disk-backing-chains-active.xml | 19 +-
...qemuxml2xmlout-disk-backing-chains-inactive.xml | 19 +-
.../qemuxml2xmlout-disk-cdrom-empty.xml | 20 +-
.../qemuxml2xmlout-disk-cdrom.xml | 20 +-
.../qemuxml2xmlout-disk-copy_on_read.xml | 19 +-
.../qemuxml2xmlout-disk-drive-boot-cdrom.xml | 20 +-
.../qemuxml2xmlout-disk-drive-boot-disk.xml | 20 +-
.../qemuxml2xmlout-disk-drive-cache-directsync.xml | 20 +-
.../qemuxml2xmlout-disk-drive-cache-unsafe.xml | 20 +-
.../qemuxml2xmlout-disk-drive-cache-v2-none.xml | 20 +-
.../qemuxml2xmlout-disk-drive-cache-v2-wb.xml | 20 +-
.../qemuxml2xmlout-disk-drive-cache-v2-wt.xml | 20 +-
.../qemuxml2xmlout-disk-drive-copy-on-read.xml | 16 +-
.../qemuxml2xmlout-disk-drive-discard.xml | 17 +-
...xml2xmlout-disk-drive-error-policy-enospace.xml | 20 +-
...qemuxml2xmlout-disk-drive-error-policy-stop.xml | 20 +-
...out-disk-drive-error-policy-wreport-rignore.xml | 20 +-
.../qemuxml2xmlout-disk-drive-fmt-qcow.xml | 20 +-
.../qemuxml2xmlout-disk-drive-network-gluster.xml | 20 +-
...emuxml2xmlout-disk-drive-network-iscsi-auth.xml | 19 +-
.../qemuxml2xmlout-disk-drive-network-iscsi.xml | 19 +-
...emuxml2xmlout-disk-drive-network-nbd-export.xml | 20 +-
...l2xmlout-disk-drive-network-nbd-ipv6-export.xml | 20 +-
.../qemuxml2xmlout-disk-drive-network-nbd-ipv6.xml | 20 +-
.../qemuxml2xmlout-disk-drive-network-nbd-unix.xml | 20 +-
.../qemuxml2xmlout-disk-drive-network-nbd.xml | 20 +-
.../qemuxml2xmlout-disk-drive-network-rbd-auth.xml | 20 +-
...uxml2xmlout-disk-drive-network-rbd-ceph-env.xml | 20 +-
.../qemuxml2xmlout-disk-drive-network-rbd-ipv6.xml | 20 +-
.../qemuxml2xmlout-disk-drive-network-rbd.xml | 23 ++-
.../qemuxml2xmlout-disk-drive-network-sheepdog.xml | 20 +-
.../qemuxml2xmlout-disk-drive-network-vxhs.xml | 18 +-
.../qemuxml2xmlout-disk-floppy.xml | 25 ++-
.../qemuxml2xmlout-disk-many.xml | 22 +-
.../qemuxml2xmlout-disk-mirror-active.xml | 19 +-
.../qemuxml2xmlout-disk-mirror-inactive.xml | 19 +-
.../qemuxml2xmlout-disk-mirror-old-inactive.xml | 19 +-
.../qemuxml2xmlout-disk-mirror-old.xml | 19 +-
.../qemuxml2xmlout-disk-scsi-device-auto.xml | 18 +-
.../qemuxml2xmlout-disk-scsi-device.xml | 18 +-
.../qemuxml2xmlout-disk-scsi-disk-vpd.xml | 18 +-
...muxml2xmlout-disk-scsi-lun-passthrough-sgio.xml | 18 +-
.../qemuxml2xmlout-disk-scsi-megasas.xml | 18 +-
.../qemuxml2xmlout-disk-scsi-mptsas1068.xml | 18 +-
.../qemuxml2xmlout-disk-scsi-virtio-scsi.xml | 18 +-
.../qemuxml2xmlout-disk-scsi-vscsi.xml | 18 +-
.../qemuxml2xmlout-disk-source-pool-mode.xml | 19 +-
.../qemuxml2xmlout-disk-source-pool.xml | 18 +-
.../qemuxml2xmlout-disk-usb-device.xml | 17 +-
...qemuxml2xmlout-disk-virtio-scsi-cmd_per_lun.xml | 16 +-
.../qemuxml2xmlout-disk-virtio-scsi-ioeventfd.xml | 16 +-
...qemuxml2xmlout-disk-virtio-scsi-max_sectors.xml | 16 +-
.../qemuxml2xmlout-disk-virtio-scsi-num_queues.xml | 16 +-
.../qemuxml2xmlout-disk-virtio.xml | 22 +-
.../qemuxml2xmlout-encrypted-disk.xml | 15 +-
.../qemuxml2xmlout-eoi-disabled.xml | 14 +-
.../qemuxml2xmlout-eoi-enabled.xml | 14 +-
.../qemuxml2xmlout-event_idx.xml | 19 +-
.../qemuxml2xmlout-floppy-drive-fat.xml | 20 +-
.../qemuxml2xmlout-graphics-listen-network.xml | 17 +-
.../qemuxml2xmlout-graphics-listen-network2.xml | 17 +-
.../qemuxml2xmlout-graphics-sdl-fullscreen.xml | 20 +-
.../qemuxml2xmlout-graphics-sdl.xml | 20 +-
...muxml2xmlout-graphics-spice-auto-socket-cfg.xml | 19 +-
.../qemuxml2xmlout-graphics-spice-auto-socket.xml | 19 +-
.../qemuxml2xmlout-graphics-spice-compression.xml | 18 +-
.../qemuxml2xmlout-graphics-spice-qxl-vga.xml | 18 +-
.../qemuxml2xmlout-graphics-spice-socket.xml | 19 +-
.../qemuxml2xmlout-graphics-spice-timeout.xml | 25 ++-
.../qemuxml2xmlout-graphics-spice.xml | 18 +-
...qemuxml2xmlout-graphics-vnc-auto-socket-cfg.xml | 20 +-
.../qemuxml2xmlout-graphics-vnc-auto-socket.xml | 19 +-
.../qemuxml2xmlout-graphics-vnc-no-listen-attr.xml | 20 +-
...graphics-vnc-remove-generated-socket-active.xml | 20 +-
...aphics-vnc-remove-generated-socket-inactive.xml | 20 +-
.../qemuxml2xmlout-graphics-vnc-sasl.xml | 20 +-
.../qemuxml2xmlout-graphics-vnc-socket.xml | 19 +-
.../qemuxml2xmlout-graphics-vnc-tls.xml | 20 +-
.../qemuxml2xmlout-graphics-vnc-websocket.xml | 18 +-
.../qemuxml2xmlout-graphics-vnc.xml | 20 +-
.../qemuxml2xmlout-hostdev-mdev-precreated.xml | 20 +-
.../qemuxml2xmlout-hostdev-pci-address.xml | 20 +-
...qemuxml2xmlout-hostdev-scsi-autogen-address.xml | 29 ++-
.../qemuxml2xmlout-hostdev-scsi-large-unit.xml | 18 +-
.../qemuxml2xmlout-hostdev-scsi-lsi-iscsi-auth.xml | 19 +-
.../qemuxml2xmlout-hostdev-scsi-lsi-iscsi.xml | 19 +-
.../qemuxml2xmlout-hostdev-scsi-lsi.xml | 18 +-
.../qemuxml2xmlout-hostdev-scsi-rawio.xml | 18 +-
.../qemuxml2xmlout-hostdev-scsi-readonly.xml | 18 +-
.../qemuxml2xmlout-hostdev-scsi-sgio.xml | 18 +-
.../qemuxml2xmlout-hostdev-scsi-shareable.xml | 18 +-
...muxml2xmlout-hostdev-scsi-virtio-iscsi-auth.xml | 19 +-
.../qemuxml2xmlout-hostdev-scsi-virtio-iscsi.xml | 19 +-
.../qemuxml2xmlout-hostdev-scsi-virtio-scsi.xml | 18 +-
.../qemuxml2xmlout-hostdev-usb-address.xml | 20 +-
.../qemuxml2xmlout-hostdev-vfio.xml | 17 +-
.../qemuxml2xmlout-hugepages-pages.xml | 16 +-
.../qemuxml2xmlout-hugepages-pages2.xml | 16 +-
.../qemuxml2xmlout-hugepages-pages3.xml | 16 +-
.../qemuxml2xmlout-hugepages-shared.xml | 16 +-
.../qemuxml2xmlout-hugepages.xml | 16 +-
.../qemuxml2xmlout-hyperv-off.xml | 14 +-
.../qemuxml2xmlout-hyperv-panic.xml | 17 +-
tests/qemuxml2xmloutdata/qemuxml2xmlout-hyperv.xml | 17 +-
.../qemuxml2xmlout-input-usbmouse.xml | 23 ++-
.../qemuxml2xmlout-input-usbtablet.xml | 23 ++-
.../qemuxml2xmlout-intel-iommu-machine.xml | 17 +-
.../qemuxml2xmlout-intel-iommu.xml | 17 +-
.../qemuxml2xmlout-interface-driver.xml | 21 +-
.../qemuxml2xmlout-interface-server.xml | 33 ++-
.../qemuxml2xmlout-iothreads-disk-virtio-ccw.xml | 7 +-
.../qemuxml2xmlout-iothreads-disk.xml | 21 +-
.../qemuxml2xmlout-iothreads-ids-partial.xml | 19 +-
.../qemuxml2xmlout-iothreads-ids.xml | 19 +-
.../qemuxml2xmlout-iothreads-virtio-scsi-ccw.xml | 8 +-
.../qemuxml2xmlout-iothreads-virtio-scsi-pci.xml | 22 +-
.../qemuxml2xmlout-iothreads.xml | 19 +-
.../qemuxml2xmlout-kvm-features-off.xml | 14 +-
.../qemuxml2xmlout-kvm-features.xml | 17 +-
.../qemuxml2xmloutdata/qemuxml2xmlout-kvmclock.xml | 17 +-
tests/qemuxml2xmloutdata/qemuxml2xmlout-lease.xml | 17 +-
.../qemuxml2xmlout-machine-core-off.xml | 19 +-
.../qemuxml2xmlout-machine-core-on.xml | 19 +-
...t-machine-loadparm-multiple-disks-nets-s390.xml | 5 +
.../qemuxml2xmlout-memory-hotplug-dimm.xml | 18 +-
.../qemuxml2xmlout-memory-hotplug-nonuma.xml | 14 +-
.../qemuxml2xmlout-memory-hotplug.xml | 16 +-
.../qemuxml2xmlout-memorybacking-set.xml | 14 +-
.../qemuxml2xmlout-memorybacking-unset.xml | 14 +-
.../qemuxml2xmlout-memtune-unlimited.xml | 16 +-
.../qemuxml2xmloutdata/qemuxml2xmlout-memtune.xml | 16 +-
.../qemuxml2xmlout-metadata-duplicate.xml | 16 +-
.../qemuxml2xmloutdata/qemuxml2xmlout-metadata.xml | 16 +-
.../qemuxml2xmloutdata/qemuxml2xmlout-migrate.xml | 19 +-
.../qemuxml2xmloutdata/qemuxml2xmlout-minimal.xml | 16 +-
.../qemuxml2xmlout-misc-acpi.xml | 19 +-
.../qemuxml2xmlout-misc-disable-s3.xml | 19 +-
.../qemuxml2xmlout-misc-disable-suspends.xml | 19 +-
.../qemuxml2xmlout-misc-enable-s4.xml | 19 +-
.../qemuxml2xmlout-misc-no-reboot.xml | 19 +-
.../qemuxml2xmlout-misc-uuid.xml | 19 +-
.../qemuxml2xmlout-net-bandwidth.xml | 27 ++-
.../qemuxml2xmlout-net-bandwidth2.xml | 25 ++-
.../qemuxml2xmlout-net-coalesce.xml | 22 +-
.../qemuxml2xmlout-net-eth-hostip.xml | 20 +-
.../qemuxml2xmlout-net-eth-ifname.xml | 20 +-
.../qemuxml2xmloutdata/qemuxml2xmlout-net-eth.xml | 20 +-
.../qemuxml2xmlout-net-hostdev-vfio.xml | 17 +-
.../qemuxml2xmlout-net-hostdev.xml | 17 +-
.../qemuxml2xmlout-net-midonet.xml | 17 +-
.../qemuxml2xmloutdata/qemuxml2xmlout-net-mtu.xml | 22 +-
.../qemuxml2xmlout-net-openvswitch.xml | 17 +-
.../qemuxml2xmloutdata/qemuxml2xmlout-net-udp.xml | 17 +-
.../qemuxml2xmloutdata/qemuxml2xmlout-net-user.xml | 20 +-
.../qemuxml2xmlout-net-vhostuser.xml | 22 +-
.../qemuxml2xmlout-net-virtio-device.xml | 17 +-
.../qemuxml2xmlout-net-virtio-disable-offloads.xml | 17 +-
...qemuxml2xmlout-net-virtio-network-portgroup.xml | 19 +-
.../qemuxml2xmlout-net-virtio-rxtxqueuesize.xml | 17 +-
.../qemuxml2xmlout-net-virtio.xml | 20 +-
.../qemuxml2xmlout-nographics-vga.xml | 19 +-
.../qemuxml2xmlout-nosharepages.xml | 19 +-
...emuxml2xmlout-numad-auto-memory-vcpu-cpuset.xml | 16 +-
...ad-auto-memory-vcpu-no-cpuset-and-placement.xml | 16 +-
.../qemuxml2xmlout-numad-auto-vcpu-no-numatune.xml | 16 +-
...emuxml2xmlout-numad-static-vcpu-no-numatune.xml | 16 +-
.../qemuxml2xmlout-numatune-auto-prefer.xml | 14 +-
.../qemuxml2xmlout-numatune-memnode-no-memory.xml | 14 +-
.../qemuxml2xmlout-numatune-memnode.xml | 14 +-
.../qemuxml2xmlout-panic-double.xml | 17 +-
.../qemuxml2xmlout-panic-isa.xml | 20 +-
.../qemuxml2xmlout-panic-no-address.xml | 20 +-
.../qemuxml2xmlout-panic-pseries.xml | 8 +-
tests/qemuxml2xmloutdata/qemuxml2xmlout-panic.xml | 20 +-
.../qemuxml2xmlout-pci-autoadd-addr.xml | 24 ++-
.../qemuxml2xmlout-pci-autoadd-idx.xml | 25 ++-
.../qemuxml2xmlout-pci-autofill-addr.xml | 17 +-
.../qemuxml2xmlout-pci-bridge-many-disks.xml | 125 +++++++++++-
.../qemuxml2xmlout-pci-bridge.xml | 51 ++++-
.../qemuxml2xmlout-pci-expander-bus.xml | 52 ++++-
.../qemuxml2xmloutdata/qemuxml2xmlout-pci-many.xml | 45 ++++-
.../qemuxml2xmloutdata/qemuxml2xmlout-pci-rom.xml | 20 +-
.../qemuxml2xmlout-pci-serial-dev-chardev.xml | 18 +-
.../qemuxml2xmlout-pcie-expander-bus.xml | 85 +++++++-
...qemuxml2xmlout-pcie-root-port-model-generic.xml | 20 +-
...qemuxml2xmlout-pcie-root-port-model-ioh3420.xml | 19 +-
.../qemuxml2xmlout-pcie-root-port.xml | 21 +-
.../qemuxml2xmlout-pcie-root.xml | 17 +-
.../qemuxml2xmlout-pcie-switch-downstream-port.xml | 29 ++-
.../qemuxml2xmlout-pcie-switch-upstream-port.xml | 23 ++-
.../qemuxml2xmlout-pcihole64-gib.xml | 11 +-
.../qemuxml2xmlout-pcihole64-none.xml | 11 +-
.../qemuxml2xmlout-pcihole64-q35.xml | 16 +-
.../qemuxml2xmlout-pcihole64.xml | 11 +-
.../qemuxml2xmlout-pmu-feature-off.xml | 17 +-
.../qemuxml2xmlout-pmu-feature.xml | 17 +-
.../qemuxml2xmlout-ppc64-usb-controller-legacy.xml | 3 +
.../qemuxml2xmlout-ppc64-usb-controller.xml | 3 +
.../qemuxml2xmlout-pseries-cpu-compat-power9.xml | 8 +-
.../qemuxml2xmlout-pseries-cpu-compat.xml | 8 +-
.../qemuxml2xmlout-pseries-cpu-exact.xml | 8 +-
.../qemuxml2xmlout-pseries-hostdevs-1.xml | 14 +-
.../qemuxml2xmlout-pseries-hostdevs-2.xml | 14 +-
.../qemuxml2xmlout-pseries-hostdevs-3.xml | 13 +-
.../qemuxml2xmlout-pseries-many-buses-1.xml | 11 +-
.../qemuxml2xmlout-pseries-many-buses-2.xml | 11 +-
.../qemuxml2xmlout-pseries-many-devices.xml | 42 +++-
.../qemuxml2xmlout-pseries-nvram.xml | 6 +-
.../qemuxml2xmlout-pseries-panic-missing.xml | 8 +-
.../qemuxml2xmlout-pseries-panic-no-address.xml | 8 +-
.../qemuxml2xmlout-pseries-phb-default-missing.xml | 11 +-
.../qemuxml2xmlout-pseries-phb-numa-node.xml | 12 +-
.../qemuxml2xmlout-pseries-phb-simple.xml | 11 +-
.../qemuxml2xmlout-pv-spinlock-disabled.xml | 14 +-
.../qemuxml2xmlout-pv-spinlock-enabled.xml | 14 +-
.../qemuxml2xmlout-q35-default-devices-only.xml | 18 +-
.../qemuxml2xmlout-q35-multifunction.xml | 33 ++-
.../qemuxml2xmlout-q35-pci-force-address.xml | 26 ++-
.../qemuxml2xmlout-q35-pcie-autoadd.xml | 41 +++-
.../qemuxml2xmloutdata/qemuxml2xmlout-q35-pcie.xml | 42 +++-
.../qemuxml2xmlout-q35-usb2-multi.xml | 33 ++-
.../qemuxml2xmlout-q35-usb2-reorder.xml | 33 ++-
.../qemuxml2xmloutdata/qemuxml2xmlout-q35-usb2.xml | 25 ++-
.../qemuxml2xmlout-q35-virt-manager-basic.xml | 33 ++-
.../qemuxml2xmlout-q35-virtio-pci.xml | 42 +++-
tests/qemuxml2xmloutdata/qemuxml2xmlout-q35.xml | 23 ++-
.../qemuxml2xmlout-qemu-ns-no-env.xml | 19 +-
.../qemuxml2xmlout-reboot-timeout-disabled.xml | 17 +-
.../qemuxml2xmlout-reboot-timeout-enabled.xml | 17 +-
.../qemuxml2xmlout-restore-v2.xml | 19 +-
.../qemuxml2xmlout-s390-defaultconsole.xml | 9 +-
.../qemuxml2xmlout-s390-panic-missing.xml | 3 +
.../qemuxml2xmlout-s390-panic-no-address.xml | 3 +
.../qemuxml2xmlout-s390-panic.xml | 3 +
.../qemuxml2xmlout-seclabel-dac-none.xml | 16 +-
.../qemuxml2xmlout-seclabel-device-multiple.xml | 16 +-
.../qemuxml2xmlout-seclabel-dynamic-baselabel.xml | 16 +-
.../qemuxml2xmlout-seclabel-dynamic-labelskip.xml | 16 +-
...emuxml2xmlout-seclabel-dynamic-none-relabel.xml | 18 +-
.../qemuxml2xmlout-seclabel-dynamic-none.xml | 16 +-
.../qemuxml2xmlout-seclabel-dynamic-override.xml | 17 +-
.../qemuxml2xmlout-seclabel-dynamic-relabel.xml | 16 +-
.../qemuxml2xmlout-seclabel-none.xml | 16 +-
.../qemuxml2xmlout-seclabel-static-labelskip.xml | 16 +-
.../qemuxml2xmlout-seclabel-static.xml | 16 +-
.../qemuxml2xmlout-serial-spiceport-nospice.xml | 18 +-
.../qemuxml2xmlout-serial-spiceport.xml | 23 ++-
.../qemuxml2xmlout-serial-target-port-auto.xml | 20 +-
.../qemuxml2xmlout-serial-tcp-tlsx509-chardev.xml | 19 +-
.../qemuxml2xmlout-shmem-plain-doorbell.xml | 25 ++-
tests/qemuxml2xmloutdata/qemuxml2xmlout-shmem.xml | 25 ++-
.../qemuxml2xmlout-smartcard-controller.xml | 19 +-
.../qemuxml2xmlout-smartcard-host-certificates.xml | 19 +-
.../qemuxml2xmlout-smartcard-host.xml | 19 +-
...muxml2xmlout-smartcard-passthrough-spicevmc.xml | 19 +-
.../qemuxml2xmlout-smartcard-passthrough-tcp.xml | 19 +-
.../qemuxml2xmlout-smbios-multiple-type2.xml | 16 +-
tests/qemuxml2xmloutdata/qemuxml2xmlout-smbios.xml | 16 +-
tests/qemuxml2xmloutdata/qemuxml2xmlout-smp.xml | 19 +-
.../qemuxml2xmlout-sound-device.xml | 34 +++-
tests/qemuxml2xmloutdata/qemuxml2xmlout-sound.xml | 29 ++-
.../qemuxml2xmlout-tap-vhost-incorrect.xml | 20 +-
.../qemuxml2xmlout-tap-vhost.xml | 21 +-
.../qemuxml2xmlout-tpm-passthrough.xml | 15 +-
.../qemuxml2xmlout-usb-controller-default-q35.xml | 18 +-
.../qemuxml2xmlout-usb-controller-explicit-q35.xml | 18 +-
.../qemuxml2xmlout-usb-controller.xml | 14 +-
.../qemuxml2xmlout-usb-ich9-ehci-addr.xml | 25 ++-
.../qemuxml2xmloutdata/qemuxml2xmlout-usb-none.xml | 17 +-
.../qemuxml2xmlout-usb-piix3-controller.xml | 14 +-
.../qemuxml2xmlout-usb-port-missing.xml | 17 +-
.../qemuxml2xmlout-usb-redir-filter-version.xml | 16 +-
.../qemuxml2xmlout-usb-redir-filter.xml | 19 +-
.../qemuxml2xmlout-usb-redir.xml | 19 +-
.../qemuxml2xmlout-vcpu-placement-static.xml | 17 +-
.../qemuxml2xmlout-vhost_queues.xml | 21 +-
...qemuxml2xmlout-video-device-pciaddr-default.xml | 19 +-
.../qemuxml2xmlout-video-qxl-heads.xml | 19 +-
.../qemuxml2xmlout-video-qxl-noheads.xml | 17 +-
.../qemuxml2xmlout-video-virtio-gpu-device.xml | 17 +-
.../qemuxml2xmlout-video-virtio-gpu-secondary.xml | 16 +-
.../qemuxml2xmlout-video-virtio-gpu-spice-gl.xml | 17 +-
.../qemuxml2xmlout-video-virtio-gpu-virgl.xml | 17 +-
.../qemuxml2xmlout-virtio-input-passthrough.xml | 15 +-
.../qemuxml2xmlout-virtio-input.xml | 17 +-
.../qemuxml2xmlout-virtio-lun.xml | 19 +-
.../qemuxml2xmlout-virtio-rng-egd.xml | 15 +-
.../qemuxml2xmlout-virtio-rng-random.xml | 15 +-
.../qemuxml2xmloutdata/qemuxml2xmlout-watchdog.xml | 23 ++-
tests/qemuxml2xmltest.c | 63 +++++-
499 files changed, 7768 insertions(+), 1683 deletions(-)
--
2.13.5
7 years
[libvirt] [PATCH v2] docs, rng: Adjust storage pool name grammar checks
by John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=1475250
It's possible to define and start a pool with a '.' in the
name; however, when trying to add a volume to a domain using
the storage pool source with a '.' in the storage pool name,
the domain RNG validation fails because RNG uses 'genericName'
which does not allow a '.' in the name.
Domain XML def parsing has a virXMLValidateAgainstSchema which
generates the error. The Storage Pool XML def parsing has no
call to virXMLValidateAgainstSchema. The only Storage Pool name
validation occurs in virStoragePoolDefParseXML to ensure the
name doesn't have a '/' in it and in storagePoolDefineXML to
call virXMLCheckIllegalChars using the same parameter "\n" as
qemuDomainDefineXMLFlags would check after the RNG check
could be succesful.
In order to resolve this, create a poolName definition in
storagecommon.rng that will mimic the domain name regex that
disallows a newline character, but add the "/" in the exclude
list. Then modify the pool and volume source name definitions
to key off that poolName.
Signed-off-by: John Ferlan <jferlan(a)redhat.com>
---
v1: https://www.redhat.com/archives/libvir-list/2017-September/msg01037.html
Change only to add '/' before the newline in poolName
docs/schemas/domaincommon.rng | 2 +-
docs/schemas/storagecommon.rng | 8 ++++++++
docs/schemas/storagepool.rng | 4 ++--
3 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng
index bac371ea3..89515564f 100644
--- a/docs/schemas/domaincommon.rng
+++ b/docs/schemas/domaincommon.rng
@@ -1674,7 +1674,7 @@
<optional>
<element name="source">
<attribute name="pool">
- <ref name="genericName"/>
+ <ref name="poolName"/>
</attribute>
<attribute name="volume">
<ref name="volName"/>
diff --git a/docs/schemas/storagecommon.rng b/docs/schemas/storagecommon.rng
index 717f3c603..edee1b084 100644
--- a/docs/schemas/storagecommon.rng
+++ b/docs/schemas/storagecommon.rng
@@ -6,6 +6,14 @@
<!-- This schema is not designed for standalone use; another file
must include both this file and basictypes.rng -->
+ <define name="poolName">
+ <data type="string">
+ <!-- Use literal newline instead of \n for bug in libxml2 2.7.6 -->
+ <param name="pattern">[^/
+]+</param>
+ </data>
+ </define>
+
<define name='encryption'>
<element name='encryption'>
<attribute name='format'>
diff --git a/docs/schemas/storagepool.rng b/docs/schemas/storagepool.rng
index f0117bd69..52b2044be 100644
--- a/docs/schemas/storagepool.rng
+++ b/docs/schemas/storagepool.rng
@@ -209,7 +209,7 @@
<interleave>
<optional>
<element name='name'>
- <ref name='genericName'/>
+ <ref name='poolName'/>
</element>
</optional>
<optional>
@@ -223,7 +223,7 @@
<define name='commonmetadata'>
<interleave>
<element name='name'>
- <ref name='genericName'/>
+ <ref name='poolName'/>
</element>
<optional>
<element name='uuid'>
--
2.13.6
7 years
[libvirt] [PATCH] spec: Enable qemu driver on s390x on RHEL/CentOS
by Jiri Denemark
Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com>
---
libvirt.spec.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index 48f193f0c4..e053f05f1c 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -35,7 +35,7 @@
%define with_qemu_tcg 0
%define qemu_kvm_arches x86_64
%if 0%{?rhel} >= 7
- %define qemu_kvm_arches x86_64 %{power64} aarch64
+ %define qemu_kvm_arches x86_64 %{power64} aarch64 s390x
%endif
%endif
--
2.14.2
7 years
[libvirt] [PATCH 0/7] qemu: refactor disk startup handling (blockdev-add saga)
by Peter Krempa
This is a collection of patches which refactor and fix disk startup code
which are part of my work on the blockdev-add feature.
Peter Krempa (7):
qemu: process: document parameters for startup preparing functions
qemu: migration: Extract flags for starting VM into a variable
qemu: process: Pass flags to qemuProcessPrepareHost
qemu: domain: Document and export qemuDomainCheckDiskStartupPolicy
qemu: process: Move 'volume' translation to domain prepare stage
qemu: process: Move TLS setup for storage source to
qemuProcessPrepareDomainStorage
qemu: process: move disk presence checking to host setup function
src/qemu/qemu_domain.c | 90 ++++++++----------------------------------
src/qemu/qemu_domain.h | 13 +++----
src/qemu/qemu_migration.c | 12 +++---
src/qemu/qemu_process.c | 99 ++++++++++++++++++++++++++++++++++++++++-------
src/qemu/qemu_process.h | 2 +-
5 files changed, 117 insertions(+), 99 deletions(-)
--
2.14.1
7 years
[libvirt] [PATCH 0/7] Fix reversed stats/QoS for macvtap
by Michal Privoznik
This is initiated by:
https://bugzilla.redhat.com/show_bug.cgi?id=1497410
Long story short, in some cases host and domain are on the same side of RX/TX
stats/QoS.
Michal Privoznik (7):
lxc: Drop useless ifdef __linux__
qemuDomainInterfaceStats: Check for the actual type of interface
conf: Introduce virDomainNetFindByName
src: Use virDomainNetFindByName
virNetDevTapInterfaceStats: Allow caller to not swap the statistics
QoS: Set classes and filters in proper direction
libvirt-domain: Document interface stats POV
src/conf/domain_conf.c | 31 ++++++++++---
src/conf/domain_conf.h | 38 +++++++++++++++-
src/libvirt-domain.c | 4 +-
src/libvirt_private.syms | 1 +
src/libxl/libxl_driver.c | 23 +++++-----
src/lxc/lxc_driver.c | 38 ++++++----------
src/lxc/lxc_process.c | 3 +-
src/network/bridge_driver.c | 2 +-
src/openvz/openvz_driver.c | 23 +++++-----
src/qemu/qemu_command.c | 3 +-
src/qemu/qemu_driver.c | 41 +++++++++--------
src/qemu/qemu_hotplug.c | 6 ++-
src/test/test_driver.c | 28 +++---------
src/util/virnetdevbandwidth.c | 43 ++++++++++++------
src/util/virnetdevbandwidth.h | 3 +-
src/util/virnetdevtap.c | 99 ++++++++++++++++++++++++++++--------------
src/util/virnetdevtap.h | 3 +-
src/xen/xen_hypervisor.c | 2 +-
tests/virnetdevbandwidthtest.c | 2 +-
19 files changed, 236 insertions(+), 157 deletions(-)
--
2.13.5
7 years
[libvirt] [PATCH] tests: Fix build with clang
by Jiri Denemark
clang doesn't like mode_t type as an argument to va_arg():
error: second argument to 'va_arg' is of promotable type 'mode_t' (aka
'unsigned short'); this va_arg has undefined behavior because arguments
will be promoted to 'int'
mode = va_arg(ap, mode_t);
^~~~~~
Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com>
---
Pushed as a build-breaker.
tests/virfilewrapper.c | 2 +-
tests/virusbmock.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/virfilewrapper.c b/tests/virfilewrapper.c
index 1d1d182708..3fd7f7aa8f 100644
--- a/tests/virfilewrapper.c
+++ b/tests/virfilewrapper.c
@@ -267,7 +267,7 @@ int open(const char *path, int flags, ...)
*/
if (flags & O_CREAT) {
va_start(ap, flags);
- mode = va_arg(ap, mode_t);
+ mode = (mode_t) va_arg(ap, int);
va_end(ap);
}
diff --git a/tests/virusbmock.c b/tests/virusbmock.c
index f430a2edad..12083e2362 100644
--- a/tests/virusbmock.c
+++ b/tests/virusbmock.c
@@ -101,7 +101,7 @@ int open(const char *pathname, int flags, ...)
*/
if (flags & O_CREAT) {
va_start(ap, flags);
- mode = va_arg(ap, mode_t);
+ mode = (mode_t) va_arg(ap, int);
va_end(ap);
}
--
2.14.2
7 years