July 2016 - Devel - libvirt List Archives

[libvirt] [PATCH 0/2] vz: add tcp and udp serial device support
by Nikolay Shirokovskiy 19 Jul '16

19 Jul '16

Nikolay Shirokovskiy (2): vz: add mode of unix socket serial device to xml dump vz: add tcp and udp serial device support src/vz/vz_sdk.c | 111 ++++++++++++++++++++++++++++++++++++++++++++++++-------- 1 file changed, 96 insertions(+), 15 deletions(-) -- 1.8.3.1

2 3

[libvirt] [PATCH 0/9] vz: define and other cleanups
by Nikolay Shirokovskiy 19 Jul '16

19 Jul '16

'vz: cleanup loading domain code' is main patch and 'vz: use domain list infrastructure to deal with private domain' is a preparation for it. Other patches are mostly minor bugfixes and cleanups. After the main patch driver lock is locked for very small time so massively parallel domain definition is not serialized by vz driver anymore. NOTE: Applied on top of: [PATCH] vz: get rid of unused home state variable in private domain obj [PATCH 0/5] fix destination domain synchronization Nikolay Shirokovskiy (9): vz: remove unnecessary labels in simple API calls vz: restore accidentally removed locks around close callback calls vz: fix leaks in prlsdkCreate* functions vz: make error handling idiomatic in prlsdkCreateVm vz: use domain list infrastructure to deal with private domain vz: cleanup loading domain code vz: dont remove domain from list on client object error vz: use single variable for domain vz: don't fail unregister on sending event error src/vz/vz_driver.c | 154 +++++++++++++---------------------- src/vz/vz_sdk.c | 229 ++++++++++++++++++++++++----------------------------- src/vz/vz_sdk.h | 11 +-- src/vz/vz_utils.c | 58 ++++++-------- src/vz/vz_utils.h | 7 +- 5 files changed, 194 insertions(+), 265 deletions(-) -- 1.8.3.1

2 20

[libvirt] ANNOUNCE: libvirt 1.3.3.2 maintenance release
by Cole Robinson 19 Jul '16

19 Jul '16

libvirt 1.3.3.2 is now available. This is a maintenance release of libvirt 1.3.3 with additional bugfixes that have accumulated upstream since the initial release. This release can be downloaded at: http://libvirt.org/sources/stable_updates/libvirt-1.3.3.2.tar.gz Changes in this version: * spec: Fix indentation * conf: Allow disks with identical WWN or serial * libvirt.spec.in: require systemd-container on >= f24 * qemu: SCSI hostdev hot-plug: Fix automatic creation of SCSI controllers * qemu: hot-plug: Fix broken SCSI disk hot-plug * qemu: Let empty default VNC password work as documented * virCgroupValidateMachineGroup: Reflect change in CGroup struct naming * spec: Advertise nvram paths of official fedora edk2 builds * qemu: hotplug: wait for the tray to eject only for drives with a tray * qemu: hotplug: Fix error reported when cdrom tray is locked * qemu: hotplug: Extract code for waiting for tray eject * qemu: hotplug: Report error if we hit tray status timeout * qemu: hotplug: Skip waiting for tray opening if qemu doesn't notify us * qemu: process: Fix and improve disk data extraction * qemu: Move and rename qemuDomainCheckEjectableMedia to qemuProcessRefreshDisks * qemu: Extract more information about qemu drives * qemu: Move struct qemuDomainDiskInfo to qemu_domain.h * qemu: process: Refresh ejectable media tray state on VM start * iscsi: Remove initiatoriqn from virISCSIScanTargets * util: Remove disabling of autologin for iscsi-targets * iscsi: Add exit status checking for virISCSIGetSession * util: Add exitstatus parameter to virCommandRunRegex * xlconfigtests: use qemu-xen in all test data files * libxl: don't attempt to probe a non-existent emulator * Fix tests to include video ram size * Fill out default vram in DeviceDefPostParse * Call per-device post-parse callback even on implicit video * Move virDomainDefPostParseInternal after virDomainDeviceDefPostParse * conf: use VIR_APPEND_ELEMENT in virDomainDefAddImplicitVideo * conf: reduce indentation in virDomainDefAddImplicitVideo * domain_conf: fix migration/managedsave with usb keyboard For info about past maintenance releases, see: http://wiki.libvirt.org/page/Maintenance_Releases Thanks, Cole

1 0

[libvirt] ANNOUNCE: libvirt 1.2.18.4 maintenance release
by Cole Robinson 19 Jul '16

19 Jul '16

libvirt 1.2.18.4 is now available. This is a maintenance release of libvirt 1.2.18 with additional bugfixes that have accumulated upstream since the initial release. This release can be downloaded at: http://libvirt.org/sources/stable_updates/libvirt-1.2.18.4.tar.gz Changes in this version: * qemu: Let empty default VNC password work as documented * spec: Fix error in last backport * spec: Advertise nvram paths of official fedora edk2 builds For info about past maintenance releases, see: http://wiki.libvirt.org/page/Maintenance_Releases Thanks, Cole

1 0

[libvirt] [PATCH v3 0/4] devices: filesystem: type volume
by Olga Krishtal 18 Jul '16

18 Jul '16

The patches introduce new filesystem type volume: <filesystem type='volume' accessmode='passthrough'> <driver type='ploop' format='ploop'/> <source pool='pool' volume='volume'/> <target dir='/'/> </filesystem> This makes possible to use storage volumes as the source for disks. v2: -split patches -rebased v3: - fixed check for template fs. - refactoring Olga Krishtal (4): filesystem: adds possibility to use storage pool as fs source devices: filesystems: added volume type vz: refactoring of prlsdkCreateCt vz: support filesystem type volume src/conf/domain_audit.c | 4 +- src/conf/domain_conf.c | 52 ++++++++++++--- src/conf/domain_conf.h | 4 +- src/libvirt_private.syms | 1 + src/lxc/lxc_cgroup.c | 2 +- src/lxc/lxc_container.c | 50 +++++++-------- src/lxc/lxc_controller.c | 18 +++--- src/lxc/lxc_native.c | 5 +- src/lxc/lxc_process.c | 4 +- src/openvz/openvz_conf.c | 6 +- src/openvz/openvz_driver.c | 4 +- src/qemu/qemu_command.c | 2 +- src/storage/storage_driver.c | 4 ++ src/vbox/vbox_common.c | 6 +- src/vmx/vmx.c | 6 +- src/vz/vz_driver.c | 2 +- src/vz/vz_sdk.c | 147 +++++++++++++++++++++++++++++++++++-------- src/vz/vz_sdk.h | 2 +- 18 files changed, 227 insertions(+), 92 deletions(-) -- 1.8.3.1

3 7

[libvirt] [PATCH] vz: fix
by Olga Krishtal 18 Jul '16

18 Jul '16

Please, ignore previous patch. Olga Krishtal (1): vz: fixed null-pointer dereference in applying graphic params src/vz/vz_sdk.c | 1 + 1 file changed, 1 insertion(+) -- 1.8.3.1

3 3

[libvirt] [PATCH 0/5] fix destination domain synchronization
by Nikolay Shirokovskiy 18 Jul '16

18 Jul '16

Patch 4 is main one. Others are fixes and ground works. Nikolay Shirokovskiy (5): vz: don't pass empty and unused fields in migration cookie vz: fix missed defined domain event vz: fix memory leaks in prlsdkLoadDomains vz: fix destination domain synchronization vz: issue domain undefined event on finish step if needed src/vz/vz_driver.c | 175 ++++++++++++++++++++++++++++------------------------- src/vz/vz_sdk.c | 28 ++++++--- src/vz/vz_sdk.h | 5 ++ 3 files changed, 118 insertions(+), 90 deletions(-) -- 1.8.3.1

2 7

[libvirt] [PATCHv4 0/9] Assign addresses to USB devices
by Ján Tomko 18 Jul '16

18 Jul '16

v4: allow empty port="" (meaning: assign one from the specified bus) Ján Tomko (9): Allow omitting USB port Store USB port path as an array of integers Introduce virDomainUSBAddressSet Add functions for adding USB controllers to addrs Add functions for adding USB hubs to addrs Reserve existing USB addresses Assign addresses to USB devices Assign addresses on USB device hotplug Auto-add one hub if there are too many USB devices docs/schemas/domaincommon.rng | 8 +- src/conf/device_conf.h | 2 +- src/conf/domain_addr.c | 529 +++++++++++++++++++++ src/conf/domain_addr.h | 62 +++ src/conf/domain_conf.c | 23 +- src/libvirt_private.syms | 12 + src/qemu/qemu_command.c | 6 +- src/qemu/qemu_domain.h | 1 + src/qemu/qemu_domain_address.c | 155 +++++- src/qemu/qemu_hotplug.c | 27 ++ .../qemuhotplug-hotplug-base-live+disk-usb.xml | 1 + .../qemuxml2argvdata/qemuxml2argv-bios-nvram.args | 2 +- tests/qemuxml2argvdata/qemuxml2argv-bios.args | 2 +- .../qemuxml2argv-controller-order.args | 8 +- .../qemuxml2argv-disk-usb-device-removable.args | 3 +- .../qemuxml2argv-disk-usb-device.args | 2 +- .../qemuxml2argv-graphics-spice-timeout.args | 2 +- .../qemuxml2argv-graphics-spice-usb-redir.args | 2 +- ...muxml2argv-hostdev-usb-address-device-boot.args | 2 +- .../qemuxml2argv-hostdev-usb-address-device.args | 2 +- .../qemuxml2argv-hostdev-usb-address.args | 2 +- .../qemuxml2argv-hugepages-numa.args | 6 +- .../qemuxml2argv-input-usbmouse.args | 2 +- .../qemuxml2argv-input-usbtablet.args | 2 +- .../qemuxml2argv-pseries-usb-kbd.args | 2 +- .../qemuxml2argv-serial-spiceport.args | 2 +- .../qemuxml2argv-smartcard-controller.args | 2 +- .../qemuxml2argv-smartcard-host-certificates.args | 2 +- .../qemuxml2argv-smartcard-host.args | 2 +- ...emuxml2argv-smartcard-passthrough-spicevmc.args | 2 +- .../qemuxml2argv-smartcard-passthrough-tcp.args | 2 +- .../qemuxml2argv-sound-device.args | 2 +- .../qemuxml2argv-usb-hub-autoadd.args | 28 ++ .../qemuxml2argv-usb-hub-autoadd.xml | 23 + .../qemuxml2argv-usb-hub-conflict.args | 25 + .../qemuxml2argv-usb-hub-conflict.xml | 22 + .../qemuxml2argv-usb-port-autoassign.args | 28 ++ .../qemuxml2argv-usb-port-autoassign.xml | 27 ++ .../qemuxml2argv-usb-port-missing.args | 26 + .../qemuxml2argv-usb-port-missing.xml | 25 + .../qemuxml2argv-usb-redir-boot.args | 2 +- tests/qemuxml2argvdata/qemuxml2argv-usb-redir.args | 2 +- tests/qemuxml2argvtest.c | 12 + .../qemuxml2xmlout-usb-port-missing.xml | 36 ++ tests/qemuxml2xmltest.c | 1 + 45 files changed, 1090 insertions(+), 46 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-usb-hub-autoadd.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-usb-hub-autoadd.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-usb-hub-conflict.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-usb-hub-conflict.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-usb-port-autoassign.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-usb-port-autoassign.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-usb-port-missing.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-usb-port-missing.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-usb-port-missing.xml -- 2.7.3

3 24

[libvirt] [PATCH 0/4] test: have default URI use file parsing helpers
by Cole Robinson 18 Jul '16

18 Jul '16

This series reworks test:///default open handling to use the same XML parsing helpers that a non-default test://$PATH open uses. Saves some code, and makes it easier to extend test:///default, for example in patch #4 which we want for testing nodedev events Cole Robinson (4): test: Introduce testOpenParse test: Move testOpenDefault definition later test: Have test:///default open use file parsing helpers test: Add scsi vport nodedev to test:///default src/test/test_driver.c | 326 +++++++++++++++++++++---------------------------- 1 file changed, 141 insertions(+), 185 deletions(-) -- 2.7.4

2 6

[libvirt] [PATCH] qemu: Fix migration from old libvirt
by Jiri Denemark 18 Jul '16

18 Jul '16

Older libvirt versions send persistent XML in a migration cookie even when VIR_MIGRATE_PERSIST_DEST flag is not used, but current libvirt properly fails if the cookie contains unexpected flags. Thus migration from old libvirt fails with internal error: Unsupported migration cookie feature persistent unless VIR_MIGRATE_PERSIST_DEST flag is set. https://bugzilla.redhat.com/show_bug.cgi?id=1320500 Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/qemu/qemu_migration.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 0b1770b..463e624 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -6183,8 +6183,9 @@ qemuMigrationFinish(virQEMUDriverPtr driver, cookie_flags = QEMU_MIGRATION_COOKIE_NETWORK | QEMU_MIGRATION_COOKIE_STATS | QEMU_MIGRATION_COOKIE_NBD; - if (flags & VIR_MIGRATE_PERSIST_DEST) - cookie_flags |= QEMU_MIGRATION_COOKIE_PERSISTENT; + /* Some older versions of libvirt always send persistent XML in the cookie + * even though VIR_MIGRATE_PERSIST_DEST was not used. */ + cookie_flags |= QEMU_MIGRATION_COOKIE_PERSISTENT; if (!(mig = qemuMigrationEatCookie(driver, vm, cookiein, cookieinlen, cookie_flags))) -- 2.9.2

2 1