April 2013 - Devel - libvirt List Archives

[libvirt] [PATCH] Use camelCase for XML attribute numQueues
by Martin Kletzander 24 Apr '13

24 Apr '13

In commit d4bf0a9, we used num_queues for an attribute in the XML, but the consensus is that we use camelCase for that. Since there was no release yet (the above commit describes as v1.0.4-65-gd4bf0a9), we still have time to change it. Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- This patch applies on top of Laine's RNG tightening patch [1] and it was proposed in that thread as well. [1] http://www.redhat.com/archives/libvir-list/2013-April/msg01320.html --- docs/formatdomain.html.in | 2 +- docs/schemas/domaincommon.rng | 2 +- src/conf/domain_conf.c | 6 +++--- src/qemu/qemu_command.c | 2 +- tests/qemuxml2argvdata/qemuxml2argv-disk-virtio-scsi-num_queues.xml | 2 +- 5 files changed, 7 insertions(+), 7 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 0cc56d9..a5be162 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -2135,7 +2135,7 @@ controller. A "scsi" controller has an optional attribute <code>model</code>, which is one of "auto", "buslogic", "ibmvscsi", "lsilogic", "lsisas1068", "lsisas1078", "virtio-scsi" or - "vmpvscsi". The attribute <code>num_queues</code> + "vmpvscsi". The attribute <code>numQueues</code> (<span class="since">1.0.5 (QEMU and KVM only)</span>) specifies the number of queues for the controller. For best performance, it's recommended to specify a value matching the number of vCPUs. A "usb" diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng index 3976b82..bcb1453 100644 --- a/docs/schemas/domaincommon.rng +++ b/docs/schemas/domaincommon.rng @@ -1444,7 +1444,7 @@ </attribute> </optional> <optional> - <attribute name="num_queues"> + <attribute name="numQueues"> <ref name="unsignedInt"/> </attribute> </optional> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 1643f30..0487053 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -5195,10 +5195,10 @@ virDomainControllerDefParseXML(xmlNodePtr node, def->model = -1; } - if ((num_queues = virXMLPropString(node, "num_queues"))) { + if ((num_queues = virXMLPropString(node, "numQueues"))) { if (virStrToLong_ui(num_queues, NULL, 10, &def->num_queues) < 0) { virReportError(VIR_ERR_XML_ERROR, - _("Malformed 'num_queues' value '%s'"), num_queues); + _("Malformed 'numQueues' value '%s'"), num_queues); goto error; } } @@ -13531,7 +13531,7 @@ virDomainControllerDefFormat(virBufferPtr buf, } if (def->num_queues) - virBufferAsprintf(buf, " num_queues='%u'", def->num_queues); + virBufferAsprintf(buf, " numQueues='%u'", def->num_queues); switch (def->type) { case VIR_DOMAIN_CONTROLLER_TYPE_VIRTIO_SERIAL: diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 009d42d..65675b7 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -3574,7 +3574,7 @@ qemuBuildControllerDevStr(virDomainDefPtr domainDef, !(def->type == VIR_DOMAIN_CONTROLLER_TYPE_SCSI && def->model == VIR_DOMAIN_CONTROLLER_MODEL_SCSI_VIRTIO_SCSI)) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("'num_queues' is only supported by virtio-scsi controller")); + _("'numQueues' is only supported by virtio-scsi controller")); return NULL; } diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-virtio-scsi-num_queues.xml b/tests/qemuxml2argvdata/qemuxml2argv-disk-virtio-scsi-num_queues.xml index dfa9cf1..063ccf7 100644 --- a/tests/qemuxml2argvdata/qemuxml2argv-disk-virtio-scsi-num_queues.xml +++ b/tests/qemuxml2argvdata/qemuxml2argv-disk-virtio-scsi-num_queues.xml @@ -20,7 +20,7 @@ <address type='drive' controller='0' bus='0' target='0' unit='0'/> </disk> <controller type='usb' index='0'/> - <controller type='scsi' index='0' model='virtio-scsi' num_queues='8'/> + <controller type='scsi' index='0' model='virtio-scsi' numQueues='8'/> <memballoon model='virtio'/> </devices> </domain> -- 1.8.1.5

5 12

[libvirt] internal error Cannot find suitable CPU model for given data
by yue 23 Apr '13

23 Apr '13

hi,all: if xml configuration is not right? <cpu match="exact"> <model>Nehalem</model> <topology cores="1" sockets="1" threads="1"/> </cpu> thanks

2 1

[libvirt] Patch sets proper SELinux context on /proc/meminfo (proc_t)
by dwalsh＠redhat.com 23 Apr '13

23 Apr '13

[PATCH] Fuse file system mounted at /proc/meminfo needs correct

2 2

[libvirt] [PATCH 0/2] Prefer -machine accel={tcg, kvm} over -{dis, en}able-kvm
by Jiri Denemark 23 Apr '13

23 Apr '13

Jiri Denemark (2): qemu: Move -enable-kvm and friends earlier in the command line qemu: Use -machine accel=tcg|kvm when available src/qemu/qemu_command.c | 141 ++++++++++++--------- .../qemuxml2argv-cpu-host-kvmclock.args | 2 +- .../qemuxml2argv-cpu-kvmclock.args | 2 +- tests/qemuxml2argvdata/qemuxml2argv-kvm.args | 4 + tests/qemuxml2argvdata/qemuxml2argv-kvm.xml | 22 ++++ .../qemuxml2argv-machine-core-off.args | 2 +- .../qemuxml2argv-machine-core-on.args | 2 +- .../qemuxml2argv-machine-usb-opt.args | 2 +- tests/qemuxml2argvtest.c | 1 + 9 files changed, 113 insertions(+), 65 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-kvm.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-kvm.xml -- 1.8.2.1

2 5

Re: [libvirt] [PATCHv2] Configure native vlan modes on Open vSwitch ports
by james robson 23 Apr '13

23 Apr '13

> Date: Thu, 18 Apr 2013 14:14:32 -0400 > From: Laine Stump <laine(a)laine.org> > To: libvir-list(a)redhat.com > Subject: Re: [libvirt] [PATCHv2] Configure native vlan modes on Open > vSwitch ports > Message-ID: <51703808.2000504(a)laine.org> > Content-Type: text/plain; charset=ISO-8859-1 > > On 04/18/2013 01:44 PM, james robson wrote: > > Hello, > > Has any one been able to review this yet? I realise that the 'Since > > 1.0.3' in the doc page is now out of date, but is the code itself > > acceptable? > > I was hoping that someone with more knowledge of Open vSwitch and/or > vlan tagging/trunking/native mode would repond to the message (Kyle?) > but there was silence instead... > > > > > > > > diff --git a/tests/networkxml2xmlin/openvswitch-net.xml > > b/tests/networkxml2xmlin/openvswitch-net.xml > > index a3d82b1..93c49d5 100644 > > --- a/tests/networkxml2xmlin/openvswitch-net.xml > > +++ b/tests/networkxml2xmlin/openvswitch-net.xml > > @@ -21,4 +21,13 @@ > > <parameters profileid='alice-profile'/> > > </virtualport> > > </portgroup> > > + <portgroup name='tagged'> > > + <vlan native_mode='tagged' native_tag='123'> > > + <tag id='555'/> > > + <tag id='444'/> > > + </vlan> > > + <virtualport> > > + <parameters profileid='tagged-profile'/> > > + </virtualport> > > + </portgroup> > > As brought up again in a separate conversation today, we prefer to use > camelCase rather than underscored in attribute and element names. So, if > we were to use the layout you're proposing, the attributes should be > called "nativeMode" and "nativeTag". > > However, I'm wondering if there might be a better way to structure it. > What about this? > > > <vlan trunk='yes'> > <tag id='123' native='tagged|untagged'/> (or whatever values are > appropriate) > <tag id='555'/> > <tag id='444'/> > </vlan> > > Do I understand correctly that native mode is telling what to do with > packets that come in untagged, and that (using your nomenclature > "native_mode='yes' native_tag='123'" means "when an untagged packet come > in from this interface, it should be tagged as 123 before forwarding"? That is correct, setting the native vlan changes how an untagged packet is handled when it enters the port. The difference between the 'tagged' and 'untagged' modes is in how packets on the native vlan are processed before exiting the port. > And what happens when native_mode='yes' but there is no native_tag? In that case you configuration is invalid, and will get an error. > (that's what I was trying to describe with <tag id='123' > native='untagged'/>, but I don't even know if that makes sense, because > I don't know exactly what is the native vlan tag and what is done with > it :-) That arrangement would make sense, I chose the arrangement I did for two main reasons. There can only be one native vlan on a port, making it an attribute of the 'vlan' tag enforces this. Also, I wanted to keep the validation and processing separate rather than add 'if native' branches to the loops that operate on the vlan id list. I can see the advantage of having a single setting to configure the native vlan, rather than the two attributes I proposed. If the new suggestion is preferred I can rework my patch to use that format. > Also, is it valid to have a native_mode/native_tag if trunk='no'? (right > now trunk is automatically set to 'yes' if there is more than one vlan tag) It isn't valid to have trunk='no' and the native settings. Therefore "<vlan trunk='no' native_mode='tagged' native_tag='123'>" will get an error if you try to enter it. If no "trunk" attribute is set explicitly then it will be set to 'yes'. This means "<vlan native_mode='tagged' native_tag='123'>" is equivalent to "<vlan trunk='yes' native_mode='tagged' native_tag='123'>". > > > </network> > > diff --git a/tests/networkxml2xmlout/openvswitch-net.xml > > b/tests/networkxml2xmlout/openvswitch-net.xml > > index a3d82b1..ab3d797 100644 > > --- a/tests/networkxml2xmlout/openvswitch-net.xml > > +++ b/tests/networkxml2xmlout/openvswitch-net.xml > > @@ -21,4 +21,13 @@ > > <parameters profileid='alice-profile'/> > > </virtualport> > > </portgroup> > > + <portgroup name='tagged'> > > + <vlan trunk='yes' native_mode='tagged' native_tag='123'> > > + <tag id='555'/> > > + <tag id='444'/> > > + </vlan> > > + <virtualport> > > + <parameters profileid='tagged-profile'/> > > + </virtualport> > > + </portgroup> > > </network> > > > Protected by Websense Hosted Email Security -- www.websense.com

2 4

[libvirt] [PATCHv2 0/6] Add support for guest-agent based cpu hot(un)plug
by Peter Krempa 23 Apr '13

23 Apr '13

This version contains fixes requested by Eric on patches 1/6, 3/6 and 4/6. Patch 2/6 is new in the series. I tweaked some details in 5/6 and 6/6 but they weren't reviewed in version 1. Changes are described in the patches themselves. Peter Krempa (6): virsh-domain: Refactor cmdVcpucount and fix output on inactive domains conf: Reword error message to be more universal qemu_agent: Introduce helpers for agent based CPU hot(un)plug API: Introduce VIR_DOMAIN_VCPU_AGENT, for agent based CPU hot(un)plug qemu: Implement request of vCPU state using the guest agent qemu: Implement support for VIR_DOMAIN_VCPU in qemuDomainSetVcpusFlags include/libvirt/libvirt.h.in | 1 + src/conf/domain_conf.c | 2 +- src/libvirt.c | 24 +++- src/qemu/qemu_agent.c | 148 ++++++++++++++++++++++ src/qemu/qemu_agent.h | 12 ++ src/qemu/qemu_driver.c | 189 +++++++++++++++++++++++++--- tools/virsh-domain.c | 292 +++++++++++++++++++++---------------------- tools/virsh.pod | 13 +- 8 files changed, 510 insertions(+), 171 deletions(-) -- 1.8.1.5

3 15

[libvirt] What about next release ?
by Daniel Veillard 23 Apr '13

23 Apr '13

We are getting quite close to the end of the month, if we want to stick to the 'end of month release' I guess we need to enter the freeze for 1.0.5 at the end of the week say Friday, and then push the release, assuming there is no big problem on Thursday next week (May 2, I could probably do it on May 1 but most civilized people will enjoy the May 1 day off so that should not change that much ;-) Daniel -- Daniel Veillard | Open Source and Standards, Red Hat veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

3 3

[libvirt] domblkstat not reporting disk errors
by SHREE DUTH AWASTHI 23 Apr '13

23 Apr '13

Hi All, We are using libvirt 0.10.2 with hypervisor QEMU 0.14.1 We see that our hardware doesnt report any disk errors ( virsh domblkstat) CENTOS(Libvirt version 0.9.4) virsh # domblkstat fp-cla0 hda hda rd_req 59837 hda rd_bytes 477478400 hda wr_req 462795 hda wr_bytes 5631972352 *hda errs 0 * Our hardware (libvirt version 0.10.2) virsh # domblkstat CLA-0 hda hda rd_req 11 hda rd_bytes 217088 hda wr_req 0 hda wr_bytes 0 Could you please let us know if it is a known issue or does libvirt have any dependency for this ? Please throw more light on this. Thanks and Regards, Shree Duth Awasthi.

1 0

[libvirt] [PATCH] Omitting braces with a single-line body
by harryxiyou＠gmail.com 23 Apr '13

23 Apr '13

From: Harry Wei <harryxiyou(a)gmail.com> After i read libvirt/HACKING file, i find we should Omit braces with a single-line body. So this patch fix this coding style problem for Sheepdog storage backend driver. Signed-off-by: Harry Wei <harryxiyou(a)gmail.com> --- src/storage/storage_backend_sheepdog.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/src/storage/storage_backend_sheepdog.c b/src/storage/storage_backend_sheepdog.c index 35a3a04..15fa29c 100644 --- a/src/storage/storage_backend_sheepdog.c +++ b/src/storage/storage_backend_sheepdog.c @@ -97,12 +97,10 @@ virStorageBackendSheepdogAddHostArg(virCommandPtr cmd, const char *address = "localhost"; int port = 7000; if (pool->def->source.nhost > 0) { - if (pool->def->source.hosts[0].name != NULL) { + if (pool->def->source.hosts[0].name != NULL) address = pool->def->source.hosts[0].name; - } - if (pool->def->source.hosts[0].port) { + if (pool->def->source.hosts[0].port) port = pool->def->source.hosts[0].port; - } } virCommandAddArg(cmd, "-a"); virCommandAddArgFormat(cmd, "%s", address); @@ -210,11 +208,10 @@ virStorageBackendSheepdogParseVdiList(virStorageVolDefPtr vol, continue; /* skip space */ - if (p + 2 < next) { + if (p + 2 < next) p += 2; - } else { + else return -1; - } /* skip name */ while (*p != '\0' && *p != ' ') { -- 1.7.9.5

4 4

[libvirt] [libvirt-designer] Add missing files to EXTRA_DIST
by Christophe Fergeau 22 Apr '13

22 Apr '13

This fixes make distcheck --- I've pushed this under the trivial rule. Christophe Makefile.am | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Makefile.am b/Makefile.am index 9ef319a..726d475 100644 --- a/Makefile.am +++ b/Makefile.am @@ -10,6 +10,8 @@ EXTRA_DIST = \ $(PACKAGE).spec \ $(pkgconfig_DATA:%.pc=%.pc.in) \ AUTHORS.in \ + GNUmakefile \ + maint.mk \ README.in \ $(NULL) -- 1.8.1.4

1 0