April 2010 - Devel - libvirt List Archives

[libvirt] [PATCH] Properly advertise cpuselection guest capability
by Jiri Denemark 08 Apr '10

08 Apr '10

There's no sense in advertising cpuselection capability when host CPU is not properly detected and advertised in host capabilities. --- src/qemu/qemu_conf.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index 3fb0074..ff5bd43 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu/qemu_conf.c @@ -892,7 +892,8 @@ qemudCapsInitGuest(virCapsPtr caps, guest->arch.defaultInfo.emulator_mtime = binary_mtime; - if (qemudProbeCPUModels(binary, info->arch, &ncpus, NULL) == 0 + if (caps->host.cpu + && qemudProbeCPUModels(binary, info->arch, &ncpus, NULL) == 0 && ncpus > 0 && !virCapabilitiesAddGuestFeature(guest, "cpuselection", 1, 0)) goto error; -- 1.7.0.4

2 4

[libvirt] [PATCH] qemudDomainGetSecurityLabel: avoid dead store to "type"
by Jim Meyering 08 Apr '10

08 Apr '10

And another: >From 61f50761015a82906aec31e5a1cdeef0eaf2b0a1 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Wed, 7 Apr 2010 17:51:56 +0200 Subject: [PATCH] qemudDomainGetSecurityLabel: avoid dead store to "type" * src/qemu/qemu_driver.c (qemudDomainGetSecurityLabel): Remove store and declaration. --- src/qemu/qemu_driver.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 1e60591..f5cf1f1 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -5564,7 +5564,6 @@ static int qemudDomainGetSecurityLabel(virDomainPtr dom, virSecurityLabelPtr sec { struct qemud_driver *driver = (struct qemud_driver *)dom->conn->privateData; virDomainObjPtr vm; - const char *type; int ret = -1; qemuDriverLock(driver); @@ -5580,7 +5579,7 @@ static int qemudDomainGetSecurityLabel(virDomainPtr dom, virSecurityLabelPtr sec goto cleanup; } - if (!(type = virDomainVirtTypeToString(vm->def->virtType))) { + if (!virDomainVirtTypeToString(vm->def->virtType)) { qemuReportError(VIR_ERR_INTERNAL_ERROR, _("unknown virt type in domain definition '%d'"), vm->def->virtType); -- 1.7.1.rc0.212.gbd88f

2 2

[libvirt] [PATCH] Don't ignore guest CPU selection when unsupported by HV
by Jiri Denemark 08 Apr '10

08 Apr '10

When qemu libvirt driver doesn't support guest CPU selection with given qemu binary, guests requiring specific CPU should fail to start instead of being silently supplied with a default CPU. --- src/qemu/qemu_conf.c | 13 ++++++++++--- 1 files changed, 10 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index 592360f..3fb0074 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu/qemu_conf.c @@ -3249,9 +3249,16 @@ qemuBuildCpuArgStr(const struct qemud_driver *driver, virBuffer buf = VIR_BUFFER_INITIALIZER; int i; - if (def->cpu && def->cpu->model - && qemudProbeCPUModels(emulator, ut->machine, &ncpus, &cpus) < 0) - goto cleanup; + if (def->cpu && def->cpu->model) { + if (qemudProbeCPUModels(emulator, ut->machine, &ncpus, &cpus) < 0) + goto cleanup; + + if (!ncpus || !host) { + qemuReportError(VIR_ERR_NO_SUPPORT, "%s", + _("CPU specification not supported by hypervisor")); + goto cleanup; + } + } if (ncpus > 0 && host) { virCPUCompareResult cmp; -- 1.7.0.4

2 2

[libvirt] [PATCH] Document all options of virsh dumpxml
by Jiri Denemark 08 Apr '10

08 Apr '10

--- tools/virsh.pod | 13 +++++++++---- 1 files changed, 9 insertions(+), 4 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index a59e9b0..9e9f4e0 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -342,10 +342,15 @@ configuration format named by I<format>. Dumps the core of a domain to a file for analysis. -=item B<dumpxml> I<domain-id> - -Output the domain information as an XML dump to stdout, this format -can be used by the B<create> command. +=item B<dumpxml> I<domain-id> optional I<--inactive> I<--security-info> I<--update-cpu> + +Output the domain information as an XML dump to stdout, this format can be used +by the B<create> command. Additional options affecting the XML dump may be +used. I<--inactive> tells virsh to dump domain configuration that will be used +on next start of the domain as opposed to the current domain configuration. +Using I<--security-info> security sensitive information will also be included +in the XML dump. I<--update-cpu> updates domain CPU requirements according to +host CPU. =item B<edit> I<domain-id> -- 1.7.0.4

2 2

[libvirt] [PATCH] createRawFileOpHook: avoid dead stores
by Jim Meyering 08 Apr '10

08 Apr '10

Here are two more dead stores. >From 7c3d498d8572556d72d4633e9b39f89a08a0a682 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Wed, 7 Apr 2010 18:30:55 +0200 Subject: [PATCH] createRawFileOpHook: avoid dead stores * src/storage/storage_backend.c (createRawFileOpHook): Remove dead stores and declaration of each stored-to variable. --- src/storage/storage_backend.c | 9 +++------ 1 files changed, 3 insertions(+), 6 deletions(-) diff --git a/src/storage/storage_backend.c b/src/storage/storage_backend.c index 7294a00..f0074ed 100644 --- a/src/storage/storage_backend.c +++ b/src/storage/storage_backend.c @@ -308,12 +308,11 @@ static int createRawFileOpHook(int fd, void *data) { * update every 9s is a fair-enough trade-off */ unsigned long long bytes = 512 * 1024 * 1024; - int r; if (bytes > remain) bytes = remain; - if ((r = safezero(fd, 0, hdata->vol->allocation - remain, - bytes)) != 0) { + if (safezero(fd, 0, hdata->vol->allocation - remain, + bytes) != 0) { ret = errno; virReportSystemError(errno, _("cannot fill file '%s'"), hdata->vol->target.path); @@ -322,9 +321,7 @@ static int createRawFileOpHook(int fd, void *data) { remain -= bytes; } } else { /* No progress bars to be shown */ - int r; - - if ((r = safezero(fd, 0, 0, remain)) != 0) { + if (safezero(fd, 0, 0, remain) != 0) { ret = errno; virReportSystemError(errno, _("cannot fill file '%s'"), hdata->vol->target.path); -- 1.7.1.rc0.212.gbd88f

2 1

[libvirt] [PATCH] xenXMDomainDefineXML: remove dead store and useless/leaky virGetDomain
by Jim Meyering 08 Apr '10

08 Apr '10

clang complained about the dead store. Dan Berrange confirmed that this code has been useless-looking for ages. >From e6315e0b0d4b83b744cff86529b6b9e3144e2012 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Wed, 7 Apr 2010 20:17:44 +0200 Subject: [PATCH] xenXMDomainDefineXML: remove dead store and useless/leaky virGetDomain * src/xen/xm_internal.c (xenXMDomainDefineXML): Remove useless and leak-inducing call to virGetDomain, as well as decl of now-unused local. --- src/xen/xm_internal.c | 5 ----- 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/src/xen/xm_internal.c b/src/xen/xm_internal.c index d1265ba..a7a09a0 100644 --- a/src/xen/xm_internal.c +++ b/src/xen/xm_internal.c @@ -2622,7 +2622,6 @@ cleanup: */ virDomainPtr xenXMDomainDefineXML(virConnectPtr conn, const char *xml) { virDomainPtr ret; - virDomainPtr olddomain; char filename[PATH_MAX]; const char * oldfilename; virDomainDefPtr def = NULL; @@ -2688,10 +2687,6 @@ virDomainPtr xenXMDomainDefineXML(virConnectPtr conn, const char *xml) { goto error; } - /* XXX wtf.com is this line for - it appears to be amemory leak */ - if (!(olddomain = virGetDomain(conn, def->name, entry->def->uuid))) - goto error; - /* Remove the name -> filename mapping */ if (virHashRemoveEntry(priv->nameConfigMap, def->name, NULL) < 0) { xenXMError(VIR_ERR_INTERNAL_ERROR, -- 1.7.1.rc0.212.gbd88f

2 1

[libvirt] qemuDomainSnapshotLoad leak
by Jim Meyering 08 Apr '10

08 Apr '10

clang reports that the assignment to "snap" below is a dead store. Actually it's also a leak, and it seems like it deserves a diagnostic if/when that function returns NULL. It looks to me like this function should return something other than "void", so that it can inform its caller of such a failure. No? This is from qemu_driver.c: static void qemuDomainSnapshotLoad(void *payload, const char *name ATTRIBUTE_UNUSED, void *data) { ... virDomainSnapshotObjPtr snap = NULL; ... while ((entry = readdir(dir))) { ... def = virDomainSnapshotDefParseString(xmlStr, 0); if (def == NULL) { /* Nothing we can do here, skip this one */ VIR_ERROR("Failed to parse snapshot XML from file '%s'", fullpath); VIR_FREE(xmlStr); continue; } snap = virDomainSnapshotAssignDef(&vm->snapshots, def); VIR_FREE(xmlStr); } /* FIXME: qemu keeps internal track of snapshots. We can get access * to this info via the "info snapshots" monitor command for running * domains, or via "qemu-img snapshot -l" for shutoff domains. It would * be nice to update our internal state based on that, but there is a * a problem. qemu doesn't track all of the same metadata that we do. * In particular we wouldn't be able to fill in the <parent>, which is * pretty important in our metadata. */ virResetLastError(); cleanup: if (dir) closedir(dir); VIR_FREE(snapDir); virDomainObjUnlock(vm); }

2 4

[libvirt] [PATCH] maint: s/initialis/initializ/
by Eric Blake 08 Apr '10

08 Apr '10

git grep found 12 of the former but 100 of the latter in src/. * src/remote/remote_driver.c (initialise_gnutls): Rename... (initialize_gnutls): ...to this. (doRemoteOpen): Adjust caller. * src/xen/xen_driver.c (xenUnifiedOpen): Adjust output string. * src/util/network.c: Adjust comments. Suggested by Matthias Bolte. --- Should be a pretty trivial conversion from British to American English for a single word. Is it worth adding a rule to cfg.mk to have 'make syntax-check' diagnose future introductions of 'initialis.*'? src/remote/remote_driver.c | 14 +++++++------- src/util/network.c | 8 ++++---- src/xen/xen_driver.c | 4 ++-- 3 files changed, 13 insertions(+), 13 deletions(-) diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index 20ad6c8..d5b68dd 100644 --- a/src/remote/remote_driver.c +++ b/src/remote/remote_driver.c @@ -271,7 +271,7 @@ void remoteDomainEventQueueFlush(int timer, void *opaque); static char *get_transport_from_scheme (char *scheme); /* GnuTLS functions used by remoteOpen. */ -static int initialise_gnutls (virConnectPtr conn); +static int initialize_gnutls (virConnectPtr conn); static gnutls_session_t negotiate_gnutls_on_connection (virConnectPtr conn, struct private_data *priv, int no_verify); #ifdef WITH_LIBVIRTD @@ -425,7 +425,7 @@ doRemoteOpen (virConnectPtr conn, transport = trans_unix; } - /* Local variables which we will initialise. These can + /* Local variables which we will initialize. These can * get freed in the failed: path. */ char *name = NULL, *command = NULL, *sockname = NULL, *netcat = NULL; @@ -579,7 +579,7 @@ doRemoteOpen (virConnectPtr conn, /* Connect to the remote service. */ switch (transport) { case trans_tls: - if (initialise_gnutls (conn) == -1) goto failed; + if (initialize_gnutls (conn) == -1) goto failed; priv->uses_tls = 1; priv->is_secure = 1; @@ -1140,12 +1140,12 @@ check_cert_file(const char *type, const char *file) static int -initialise_gnutls (virConnectPtr conn) +initialize_gnutls (virConnectPtr conn) { - static int initialised = 0; + static int initialized = 0; int err; - if (initialised) return 0; + if (initialized) return 0; gnutls_global_init (); @@ -1193,7 +1193,7 @@ initialise_gnutls (virConnectPtr conn) return -1; } - initialised = 1; + initialized = 1; return 0; } diff --git a/src/util/network.c b/src/util/network.c index 76f2791..6e24792 100644 --- a/src/util/network.c +++ b/src/util/network.c @@ -1,7 +1,7 @@ /* * network.c: network helper APIs for libvirt * - * Copyright (C) 2009-2009 Red Hat, Inc. + * Copyright (C) 2009-2010 Red Hat, Inc. * * See COPYING.LIB for the License of this software * @@ -116,7 +116,7 @@ virSocketParseIpv6Addr(const char *val, virSocketAddrPtr addr) { /* * virSocketFormatAddr: - * @addr: an initialised virSocketAddrPtr + * @addr: an initialized virSocketAddrPtr * * Returns a string representation of the given address * Returns NULL on any error @@ -158,7 +158,7 @@ virSocketFormatAddr(virSocketAddrPtr addr) { /* * virSocketSetPort: - * @addr: an initialised virSocketAddrPtr + * @addr: an initialized virSocketAddrPtr * @port: the port number to set * * Set the transport layer port of the given virtSocketAddr @@ -189,7 +189,7 @@ virSocketSetPort(virSocketAddrPtr addr, int port) { /* * virSocketGetPort: - * @addr: an initialised virSocketAddrPtr + * @addr: an initialized virSocketAddrPtr * * Returns the transport layer port of the given virtSocketAddr * Returns -1 if @addr is invalid diff --git a/src/xen/xen_driver.c b/src/xen/xen_driver.c index 68b627a..5ab169d 100644 --- a/src/xen/xen_driver.c +++ b/src/xen/xen_driver.c @@ -297,7 +297,7 @@ xenUnifiedOpen (virConnectPtr conn, virConnectAuthPtr auth, int flags) } if (virMutexInit(&priv->lock) < 0) { xenUnifiedError(VIR_ERR_INTERNAL_ERROR, - "%s", _("cannot initialise mutex")); + "%s", _("cannot initialize mutex")); VIR_FREE(priv); return VIR_DRV_OPEN_ERROR; } @@ -1892,7 +1892,7 @@ out: } -/*----- Register with libvirt.c, and initialise Xen drivers. -----*/ +/*----- Register with libvirt.c, and initialize Xen drivers. -----*/ /* The interface which we export upwards to libvirt.c. */ static virDriver xenUnifiedDriver = { -- 1.6.6.1

2 2

[libvirt] Live Migration with non-shared storage for kvm
by Kenneth Nagin 08 Apr '10

08 Apr '10

On February 16th I posted a patch and description for libvirt support of 'Live Migration with non-shared strorage for kvm.' What is the status of the proposed enhancement? Kenneth Nagin

2 4

[libvirt] [PATCH] domain_event.c: don't deref NULL on an OOM error path
by Jim Meyering 07 Apr '10

07 Apr '10

This fixes a pair of potential segfault-inducing bugs: >From 7ca7e9cd366b17e41da9207b68de7e9166a88da2 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Mon, 29 Mar 2010 17:43:01 +0200 Subject: [PATCH] domain_event.c: don't deref NULL on an OOM error path * src/conf/domain_event.c (virDomainEventGraphicsNewFromDom): Return NULL when handling out-of-memory error, rather than falling through with ev=NULL and then assigning to ev->member. (virDomainEventGraphicsNewFromObj): Likewise. --- src/conf/domain_event.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_event.c b/src/conf/domain_event.c index 41c70fc..1cf03e3 100644 --- a/src/conf/domain_event.c +++ b/src/conf/domain_event.c @@ -681,19 +681,19 @@ virDomainEventPtr virDomainEventGraphicsNewFromDom(virDomainPtr dom, { virDomainEventPtr ev = virDomainEventNewInternal(VIR_DOMAIN_EVENT_ID_GRAPHICS, dom->id, dom->name, dom->uuid); if (ev) { ev->data.graphics.phase = phase; if (!(ev->data.graphics.authScheme = strdup(authScheme))) { virDomainEventFree(ev); - ev = NULL; + return NULL; } ev->data.graphics.local = local; ev->data.graphics.remote = remote; ev->data.graphics.subject = subject; } return ev; } @@ -706,19 +706,19 @@ virDomainEventPtr virDomainEventGraphicsNewFromObj(virDomainObjPtr obj, { virDomainEventPtr ev = virDomainEventNewInternal(VIR_DOMAIN_EVENT_ID_GRAPHICS, obj->def->id, obj->def->name, obj->def->uuid); if (ev) { ev->data.graphics.phase = phase; if (!(ev->data.graphics.authScheme = strdup(authScheme))) { virDomainEventFree(ev); - ev = NULL; + return NULL; } ev->data.graphics.local = local; ev->data.graphics.remote = remote; ev->data.graphics.subject = subject; } return ev; } -- 1.7.0.3.448.g82eeb

2 2