December 2010 - Devel - libvirt List Archives

[libvirt] [PATCH 00/10] Re-arrange the QEMU driver code
by Daniel P. Berrange 17 Dec '10

17 Dec '10

The QEMU driver is getting horribly large & I constantly find myself getting lost in it. This series re-arranges the code, pulling out the following areas of functionality into new files - capabilities construction - command line arg generation/parsing - domain private data / namespace handling - audit reporting - cgroup management - host device management - device hotplug There is no functional change in any of these patches. A handful of methods have been renamed if they started with the obsolete 'qemud' prefix. Since these patches will massively conflict with any further patches to the QEMU driver, the sooner they're applied the better... There is more to be pulled out later which is slightly more entangled / difficult - Events - Process startup/shutdown - Migration Daniel

2 27

[libvirt] VolumeCreateXML "XML" description for ESX
by Sherif Nagy 16 Dec '10

16 Dec '10

Hello, I am using libvirt 0.8.6 "python bindings " can someone point me to where i find the XML description of creating volumes using storagecolumecreateXML function ? i am getting libvir: ESX error : internal error Volume name 'nameXXXX.vmdk' doesn't have expected format '<directory>/<file>' thank you regards, Sherif

3 9

[libvirt] [PATCH] maint: doc fix
by Eric Blake 16 Dec '10

16 Dec '10

* src/libvirt.c: Avoid duplicate word. --- I'm pushing this under the trivial rule. src/libvirt.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index 4188b45..ff2ac93 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -3297,7 +3297,7 @@ error: * @flags: currently unused, pass 0 * * Reads a domain XML configuration document, and generates - * generates a native configuration file describing the domain. + * a native configuration file describing the domain. * The format of the native data is hypervisor dependant. * * Returns a 0 terminated UTF-8 encoded native config datafile, or NULL in case of error. -- 1.7.3.3

1 0

[libvirt] [Patch v4] Add VMware Workstation and Player driver
by Jean-Baptiste Rouault 16 Dec '10

16 Dec '10

* Changes since v3: Fix x86_64 guests support checking Use UNIX PID for the VM ID Use virDomainObjIsDuplicate() where applicable Remove the (normally) last duplicated errors Various minor fixes

2 2

[libvirt] [PATCH 0/8] Early preview: Re-factoring XDR RPC code
by Daniel P. Berrange 16 Dec '10

16 Dec '10

NB: This patch series isn't intended to be applied yet. The current remote driver and libvirtd daemon have a horrible mix of network I/O, RPC dispatch and RPC handling functionality. It it neccessary to introduce a new daemon to provide a lock manager for VM disks. Doing so would effectively require cut+paste of a large part of libvirtd code since there are no reusable APis in it. Likewise for the client side. To address this problem, this series is an attempt to produce a reusable set of APIs for building RPC servers and clients. The new APIs will handle all the networking/sockets functionality and all the RPC dispatch/serialization/deserialization code. This will enable libvirtd and the remote driver to be gutted, so that they only contain the code for actually implementing the RPC handlers. Thus a lock daemon + lock plugin can be provided without any code duplication. This will also make it far easier for us to introduce new RPC programs, eg an administrative program to allow libvirtd itself to be manipulated, say, to changing logging levels on the fly, kill mis-behaving network client, etc, etc. It would also make it practical to experiment with splitting libvirtd up into smaller daemons each handling one area of functionality. This would in turn make it practical to write useful SELinux policy for confining libvirt daemons This series is *far* from complete. The streams stuff is completely missing in the new APis. I have also not yet gutted libvirtd, only the remote driver. It is also not fully tested for ABI wire compatibility with existing libvirtd, though I believe it is correctly preserving ABI. The diffstat is slightly mis-leading because lots of code remains to be deleted from daemon/libvirtd.c and daemon/dispatch.c. None the less, it is expected that the total lines will increase, but this wll be offset by the improved code clarity and separation of functionality. Daniel daemon/event.c | 3 src/Makefile.am | 90 + src/remote/remote_driver.c | 2530 ++++++-------------------------------- src/rpc/virnetclient.c | 1237 ++++++++++++++++++ src/rpc/virnetclient.h | 60 src/rpc/virnetclientprogram.c | 258 +++ src/rpc/virnetclientprogram.h | 71 + src/rpc/virnetclientsaslcontext.c | 246 +++ src/rpc/virnetclientsaslcontext.h | 66 src/rpc/virnetmessage.c | 215 +++ src/rpc/virnetmessage.h | 31 src/rpc/virnetprotocol.c | 108 + src/rpc/virnetprotocol.h | 81 + src/rpc/virnetprotocol.x | 162 ++ src/rpc/virnetserver.c | 654 +++++++++ src/rpc/virnetserver.h | 74 + src/rpc/virnetserverclient.c | 974 ++++++++++++++ src/rpc/virnetserverclient.h | 40 src/rpc/virnetservermessage.h | 20 src/rpc/virnetserverprogram.c | 437 ++++++ src/rpc/virnetserverprogram.h | 76 + src/rpc/virnetserverservice.c | 208 +++ src/rpc/virnetserverservice.h | 32 src/rpc/virnetsocket.c | 715 ++++++++++ src/rpc/virnetsocket.h | 97 + src/rpc/virnettlscontext.c | 611 +++++++++ src/rpc/virnettlscontext.h | 63 src/util/logging.c | 4 src/util/threadpool.c | 178 ++ src/util/threadpool.h | 23 src/virtlockd.c | 620 +++++++++ 31 files changed, 7866 insertions(+), 2118 deletions(-)

3 27

[libvirt] contribution: qemu hook script to manage guests network bandwidth
by Dominik Klein 16 Dec '10

16 Dec '10

Hi we had the need to manage guests bandwidth. Therefore I wrote a qemu hook script that achieves this and, if there is any interest in that, would like to contribute it to the project. This script will only work on linux hosts. It effectively limits the bandwidth a guest can _send_. It only somewhat effectively limits the bandwidth a guest can _receive_. While well behaving tcp connections slow down when packets are being delayed/dropped, with udp, we are facing a different situation. During my tests, udp was always way slower (factor 10) than actually configured (using iperf -u). Since only tcp matters to us in this situation, we consider it "good enough". Also: This mechanism does by no means protect you from ddos or the like. So what does the script do? The script uses iptables to mark packets from- and to a virtual machine. Depending on these marks, packets will be filtered into tc classes which limit bandwidth to a configurable amount. The configuration allows for groups of vms which share an amount of bandwidth while each machine has its guaranteed bandwidth in high network usage situations. Documentation is part of the script. If you like, feel free to include it. If you have any comments or questions, talk! :) Regards Dominik

1 0

[libvirt] [C# bindings][PATCH]
by arnaud.champion＠devatom.fr 16 Dec '10

16 Dec '10

?Hi, here is another patch for C# bindings. I have update our project DAVIM with latest C# bindings and it show some naming errors. This patch correct it. Arnaud

2 1

[libvirt] "virsh setvcpus" does not work.
by Ken'ichi Ohmichi 16 Dec '10

16 Dec '10

Hi, I tested "virsh setvcpus" command and it did not work like the following: # virsh setvcpus RHEL5.5GA_Guest.img 2 error: internal error unable to execute QEMU command 'cpu_set': The command cpu_set has not been ound # Has this problem been fixed already on upstream ? o Test environment Host OS: RHEL6.0 (x86_64) qemu-kvm: 0.12.1.2-2.113.el6 libvirt : 0.8.1-27.el6 Guetst OS: RHEL5.5 o GDB output (gdb) b qerror_report_internal Breakpoint 1 at 0x497a50: file qerror.c, line 412. (gdb) c Continuing. [New Thread 0x7f726a9fc710 (LWP 23964)] Breakpoint 1, qerror_report_internal ( file=0x57e9d0 "/builddir/build/BUILD/qemu-kvm-0.12.1.2/monitor.c", linenr=4427, func=0x582af0 "handle_qmp_command", fmt=0x57ee90 "{ 'class': 'CommandNotFound', 'data': { 'name': %s } }") at qerror.c:412 412 { (gdb) bt #0 qerror_report_internal ( file=0x57e9d0 "/builddir/build/BUILD/qemu-kvm-0.12.1.2/monitor.c", linenr=4427, func=0x582af0 "handle_qmp_command", fmt=0x57ee90 "{ 'class': 'CommandNotFound', 'data': { 'name': %s } }") at qerror.c:412 #1 0x00000000004133ae in handle_qmp_command (parser=<value optimized out>, tokens=<value optimized out>) at /usr/src/debug/qemu-kvm-0.12.1.2/monitor.c:4427 #2 0x0000000000495d52 in json_message_process_token (lexer=0x1ab5d70, token=0x22037b0, type=JSON_OPERATOR, x=61, y=9170) at json-streamer.c:56 #3 0x0000000000495ab3 in json_lexer_feed_char (lexer=0x1ab5d70, ch=125 '}') at json-lexer.c:299 #4 0x0000000000495be7 in json_lexer_feed (lexer=0x1ab5d70, buffer=0x7ffff19b4510 "}F\232\001", size=1) at json-lexer.c:322 #5 0x00000000004124d2 in monitor_control_read (opaque=<value optimized out>, buf=<value optimized out>, size=<value optimized out>) at /usr/src/debug/qemu-kvm-0.12.1.2/monitor.c:4478 #6 0x00000000004b6b8a in qemu_chr_read (opaque=0x19a43a0) at qemu-char.c:154 #7 tcp_chr_read (opaque=0x19a43a0) at qemu-char.c:2072 #8 0x000000000040b4af in main_loop_wait (timeout=1000) at /usr/src/debug/qemu-kvm-0.12.1.2/vl.c:4234 #9 0x0000000000428a2a in kvm_main_loop () at /usr/src/debug/qemu-kvm-0.12.1.2/qemu-kvm.c:2133 #10 0x000000000040e5cb in main_loop (argc=<value optimized out>, argv=<value optimized out>, envp=<value optimized out>) at /usr/src/debug/qemu-kvm-0.12.1.2/vl.c:4444 #11 main (argc=<value optimized out>, argv=<value optimized out>, envp=<value optimized out>) at /usr/src/debug/qemu-kvm-0.12.1.2/vl.c:6601 (gdb) Thanks Ken'ichi Ohmichi

2 2

Re: [libvirt] system / session URI
by arnaud.champion＠devatom.fr 15 Dec '10

15 Dec '10

Okay, thanks for the explaination. This explain why I can't do some network thing with session URI ;) Thanks a lot Regards, Arnaud ---------------------------------------- De: "Eric Blake" <eblake(a)redhat.com> Envoyé: mercredi 15 décembre 2010 23:09 A: arnaud.champion(a)devatom.fr Objet: Re: [libvirt] system / session URI On 12/15/2010 02:19 PM, arnaud.champion(a)devatom.fr wrote: > ?Hi, > > Can someone explain (or point me to a document that explain) what are the differences between these two URI : > > qemu+tcp://xxx.xxx.xxx.xxx/system > qemu+tcp://xxx.xxx.xxx.xxx/session http://libvirt.org/uri.html#URI_qemu System URIs connect to the system libvirtd daemon (started by system init scripts), which is shared among all users on the machine, and which allows access to anything that requires superuser capabilities (such as creating tun devices for networking). Session URIs connect to a per-user daemon (which will be started automatically if needed), and which cannot access anything that the user cannot access (and unfortunately, given that no one has yet figured out how to make Linux share tun devices with ordinary users, that means that session guests are currently rather limited because they will not have networking support). The goal is to make things support full virtualization under session URIs, once the kernel adds the support we need for networking. -- Eric Blake eblake(a)redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org

1 0

[libvirt] system / session URI
by arnaud.champion＠devatom.fr 15 Dec '10

15 Dec '10

?Hi, Can someone explain (or point me to a document that explain) what are the differences between these two URI : qemu+tcp://xxx.xxx.xxx.xxx/system qemu+tcp://xxx.xxx.xxx.xxx/session Regards, Arnaud

2 1