May 2009 - Devel - libvirt List Archives

[libvirt] Latest git tree doesn't compile
by Florian Vichot 13 May '09

13 May '09

Hello everyone, I just got the latest and grooviest libvirt from the git tree at : git://git.et.redhat.com/libvirt.git but compiling fails: /bin/bash ../mylibtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I.. -I../gnulib/lib -I../gnulib/lib -I../include -I../include -I../qemud -I/usr/include/libxml2 -DLIBDIR=\""/usr/local/lib"\" -DBINDIR=\""/usr/local/libexec"\" -DSBINDIR=\""/usr/local/sbin"\" -DSYSCONF_DIR="\"/usr/local/etc\"" -DLOCALEBASEDIR=\""/usr/local/share/locale"\" -DLOCAL_STATE_DIR=\""/usr/local/var"\" -DGETTEXT_PACKAGE=\"libvirt\" -Wall -Wformat -Wformat-security -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wextra -Wshadow -Wcast-align -Wwrite-strings -Waggregate-return -Wstrict-prototypes -Winline -Wredundant-decls -Wno-sign-compare -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fasynchronous-unwind-tables -g -O2 -MT lxc_driver.lo -MD -MP -MF .deps/lxc_driver.Tpo -c -o lxc_driver.lo lxc_driver.c (CC) -o lxc_driver.lo lxc_driver.c lxc_container.c: In function 'lxcContainerDropCapabilities': lxc_container.c:657: error: 'PR_CAPBSET_DROP' undeclared (first use in this function) lxc_container.c:657: error: (Each undeclared identifier is reported only once lxc_container.c:657: error: for each function it appears in.) Apparently, my machine doesn't have the PR_CAPBSET_DROP flag defined. It's inexistent in sys/capability.h and "man prctl". I run a Ubuntu 8.04, kernel is 2.6.24-24-openvz. Am I missing headers that are not tested for in the ./configure ? If not, any way that functionality could be disabled on distros that don't support it ? Thanks, Florian

2 2

[libvirt] [PATCH] avoid XML attributes escaping problems
by Daniel Veillard 13 May '09

13 May '09

The associated patch solves https://bugzilla.redhat.com/show_bug.cgi?id=499791 where ' or " character in attribute values may lead to non well-formed XML. This takes the simplest approach to always escape then to ' and " since this is completely equivalent from an XML point of view and avoid the trouble. Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

2 2

[libvirt] create domain for existing xp image
by Gunnar Thielebein 13 May '09

13 May '09

I want to create a domain for an existing xp machine via virt-install. The command is taken from this wiki article http://wiki.libvirt.org/page/QEMUSwitchToLibvirt: > virt-install --accelerate --hvm --connect qemu:///system -n xp -r 512 > --cdrom=/dev/null --file=WinXP.img --vnc --noautoconsole --os-type > windows --os-variant winxp --force When I start and connect I see message: > We apologize for the inconvenience, > ... > A recent hardware or software change might have caused this. When I look at the features I saw that it lacks acpi so it changes image HAL table. Is it intentional missing for that os/variant?

1 0

[libvirt] [PATCH 0/5] Interface Config public APIs and remote stubs
by Laine Stump 13 May '09

13 May '09

These 5 patches contain the public virInterface*() API definition, the local plumbing, and the RPC glue. The test driver and real driver are still TBI, but having this in will allow other people to work on related stuff. Other things still needed: python/java bindings cli commands in virsh I'm sure lots of other things I don't know about yet. Note that I have added a couple things to the API that I previously didn't realize were needed (virInterfaceRef and virInterfaceFree - I had figured the client side would just pass around a cookie, not actually have storage associated with it).

3 17

[libvirt] PATCH: Fix virsh reporting open errors
by Daniel P. Berrange 13 May '09

13 May '09

The error handling refactor we did in virsh a few months back, accidentally means we never report the real libvirt error message for the initial connection attempt. This patch fixes it Daniel Index: src/virsh.c =================================================================== RCS file: /data/cvs/libvirt/src/virsh.c,v retrieving revision 1.202 diff -u -p -r1.202 virsh.c --- src/virsh.c 28 Apr 2009 10:55:45 -0000 1.202 +++ src/virsh.c 8 May 2009 16:36:30 -0000 @@ -6876,6 +6876,7 @@ vshInit(vshControl *ctl) * such as "help". */ if (!ctl->conn) { + virshReportError(ctl); vshError(ctl, FALSE, "%s", _("failed to connect to the hypervisor")); return FALSE; } -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

2 1

[libvirt] qemu error: package not installed
by Nigel Goddard 13 May '09

13 May '09

I get the following error on Ubuntu 8.04 when tryint to install the libvirt-bin package: Setting up libvirt-bin (0.4.0-2ubuntu8.1) ... * Starting libvirt management daemon libvirtd libvir: QEMU error : cannot create bridge 'vnet%d' : Package not installed Failed to autostart network 'default': cannot create bridge 'vnet%d' : Package not installed Can anyone advise which package I need to install? thanks Nigel -- ============================================ Nigel Goddard Axiope Limited ngoddard(a)axiope.com Tel: +44 787 967 1811 http://www.axiope.com Fax: +44 871 251 4870 -------------------------------------------- Registered in Scotland. Registered address: Quartermile One, 15 Lauriston Place Edinburgh EH3 9EP, United Kingdom ============================================

4 3

[libvirt] [PATCH 0/7] virStorageVolCreateXMLFrom API
by Cole Robinson 12 May '09

12 May '09

Hi all, The following patches implement a new API call: virStorageVolCreateXMLFrom. virStorageVolPtr virStorageVolCreateXMLFrom(virStoragePoolPtr pool, const char *xmldesc, unsigned int flags, virStorageVolPtr clonevol) Arguments function similar to the regular volume create API, except the parameter 'clonevol' is used as the input source. The API allows for volume cloning, possibly across pools, or within the same pool but converting volume formats. Tests I performed (and ensured that a VM booted without complaints from the new image): Raw -> Raw (with successful sparse detection) Raw -> QCOW2 QCOW2 -> Raw QCOW2 -> QCOW2 QCOW2 -> VMDK Raw partition ('disk' volume) -> Raw file Thanks, Cole Cole Robinson (7): Add public API stubs for virStorageVolCreateXMLFrom Remote driver plumbing for virStorageVolCreateXMLFrom Test driver implementation of virStorageVolCreateXMLFrom Virsh commands vol-clone and vol-create-from Storage driver implementation for CreateXMLFrom Break out FS volume build routines to their own functions. VolumeCreateXMLFrom FS storage backend implementation. include/libvirt/libvirt.h | 4 + include/libvirt/libvirt.h.in | 4 + qemud/remote.c | 34 +++ qemud/remote_dispatch_args.h | 1 + qemud/remote_dispatch_prototypes.h | 7 + qemud/remote_dispatch_ret.h | 1 + qemud/remote_dispatch_table.h | 5 + qemud/remote_protocol.c | 24 ++ qemud/remote_protocol.h | 18 ++ qemud/remote_protocol.x | 15 +- src/driver.h | 6 + src/libvirt.c | 61 +++++- src/libvirt_public.syms | 5 + src/remote_internal.c | 33 +++ src/storage_backend.h | 2 + src/storage_backend_fs.c | 491 +++++++++++++++++++++++++----------- src/storage_driver.c | 153 +++++++++++- src/test.c | 95 +++++++ src/virsh.c | 177 +++++++++++++- 19 files changed, 985 insertions(+), 151 deletions(-)

3 19

[libvirt] [PATCH] Fix error squashing when refreshing file volumes
by Cole Robinson 12 May '09

12 May '09

When refreshing a file based pool, errors hit when determining a volume's format were being squashed, reporting OOM instead. The attached patch fixes the error reporting here. Reported by Jason Guiditta. Thanks, Cole

3 3

[libvirt] PATCH: Another attempt to fix vbox driver open
by Daniel P. Berrange 12 May '09

12 May '09

The patches we just applied for the VirtualBox open method still were not quite right. It would return VIR_DRV_OPEN_DECLINED when uri==NULL, but before doing so it would have set conn->uri to vbox:///session. So even though it declined the connection, all the later drivers would now ignore it. Also, it now returns DECLINED for some real errors that should be reported to the user. Here's an alternative idea I've had for trying to address this. Some goals: - If the user gives a URI with a vbox:/// prefix, we should always handle it, unless a 'server' is set when we leave it to the remote driver - If an invalid path is given we must give back a real error code - If after deciding the URI is for us, any initialization fails we must raise an error. - If the vbox glue layer is missing, we should still raise errors for requested URIs, so user knows their URI is correct. To do this, I've taken the approach of registering a dummy vbox driver if the glue layer is missing. This just parses the URI and always returns an error for any vbox:// URIs that would otherwise work Daniel Index: src/vbox/vbox_driver.c =================================================================== RCS file: /data/cvs/libvirt/src/vbox/vbox_driver.c,v retrieving revision 1.2 diff -u -p -r1.2 vbox_driver.c --- src/vbox/vbox_driver.c 6 May 2009 13:51:19 -0000 1.2 +++ src/vbox/vbox_driver.c 8 May 2009 16:35:57 -0000 @@ -34,6 +34,7 @@ #include "logging.h" #include "vbox_driver.h" #include "vbox_XPCOMCGlue.h" +#include "virterror_internal.h" #define VIR_FROM_THIS VIR_FROM_VBOX @@ -43,15 +44,25 @@ extern virDriver vbox22Driver; extern virDriver vbox25Driver; #endif +static virDriver vboxDriverDummy; + +#define VIR_FROM_THIS VIR_FROM_VBOX + +#define vboxError(conn, code, fmt...) \ + virReportErrorHelper(conn, VIR_FROM_VBOX, code, __FILE__, \ + __FUNCTION__, __LINE__, fmt) int vboxRegister(void) { virDriverPtr driver; uint32_t uVersion; - /* vboxRegister() shouldn't fail as that will render libvirt unless. - * So, we use the v2.2 driver as a fallback/dummy. + /* + * If the glue layer won' initialize, we register a driver + * with a dummy open method, so we can report nicer errors + * if the user requests a vbox:// URI which we know won't + * ever work */ - driver = &vbox22Driver; + driver = &vboxDriverDummy; /* Init the glue and get the API version. */ if (VBoxCGlueInit() == 0) { @@ -79,7 +90,7 @@ int vboxRegister(void) { } } else { - DEBUG0("VBoxCGlueInit failed"); + DEBUG0("VBoxCGlueInit failed, using dummy driver"); } if (virRegisterDriver(driver) < 0) @@ -87,3 +98,46 @@ int vboxRegister(void) { return 0; } + +static virDrvOpenStatus vboxOpenDummy(virConnectPtr conn, + virConnectAuthPtr auth ATTRIBUTE_UNUSED, + int flags ATTRIBUTE_UNUSED) { + uid_t uid = getuid(); + + if (conn->uri == NULL || + conn->uri->scheme == NULL || + STRNEQ (conn->uri->scheme, "vbox") || + conn->uri->server != NULL) + return VIR_DRV_OPEN_DECLINED; + + if (conn->uri->path == NULL || STREQ(conn->uri->path, "")) { + vboxError(conn, VIR_ERR_INTERNAL_ERROR, "%s", + _("no VirtualBox drviver path specified (try vbox:///session)")); + return VIR_DRV_OPEN_ERROR; + } + + if (uid != 0) { + if (STRNEQ (conn->uri->path, "/session")) { + vboxError(conn, VIR_ERR_INTERNAL_ERROR, + _("unknown driver path '%s' specified (try vbox:///session)"), conn->uri->path); + return VIR_DRV_OPEN_ERROR; + } + } else { /* root */ + if (STRNEQ (conn->uri->path, "/system") && + STRNEQ (conn->uri->path, "/session")) { + vboxError(conn, VIR_ERR_INTERNAL_ERROR, + _("unknown driver path '%s' specified (try vbox:///system)"), conn->uri->path); + return VIR_DRV_OPEN_ERROR; + } + } + + vboxError(conn, VIR_ERR_INTERNAL_ERROR, "%s", + _("unable to initialize VirtualBox driver API")); + return VIR_DRV_OPEN_ERROR; +} + +static virDriver vboxDriverDummy = { + VIR_DRV_VBOX, + "VBOX", + .open = vboxOpenDummy, +}; Index: src/vbox/vbox_tmpl.c =================================================================== RCS file: /data/cvs/libvirt/src/vbox/vbox_tmpl.c,v retrieving revision 1.5 diff -u -p -r1.5 vbox_tmpl.c --- src/vbox/vbox_tmpl.c 8 May 2009 10:18:26 -0000 1.5 +++ src/vbox/vbox_tmpl.c 8 May 2009 16:35:57 -0000 @@ -216,16 +216,6 @@ no_memory: } static int vboxInitialize(virConnectPtr conn, vboxGlobalData *data) { - - if (VBoxCGlueInit() != 0) { - vboxError(conn, VIR_ERR_INTERNAL_ERROR, "Can't Initialize VirtualBox, VBoxCGlueInit failed."); - goto cleanup; - } - - /* This is for when glue init failed and we're serving as dummy driver. */ - if (g_pfnGetFunctions == NULL) - goto cleanup; - /* Get the API table for out version, g_pVBoxFuncs is for the oldest version of the API that we support so we cannot use that. */ data->pFuncs = g_pfnGetFunctions(VBOX_XPCOMC_VERSION); @@ -291,13 +281,13 @@ static int vboxExtractVersion(virConnect } static void vboxUninitialize(vboxGlobalData *data) { + if (!data) + return; + if (data->pFuncs) data->pFuncs->pfnComUninitialize(); VBoxCGlueTerm(); - if (!data) - return; - virDomainObjListFree(&data->domains); virCapabilitiesFree(data->caps); VIR_FREE(data); @@ -306,52 +296,62 @@ static void vboxUninitialize(vboxGlobalD static virDrvOpenStatus vboxOpen(virConnectPtr conn, virConnectAuthPtr auth ATTRIBUTE_UNUSED, int flags ATTRIBUTE_UNUSED) { - vboxGlobalData *data; + vboxGlobalData *data = NULL; uid_t uid = getuid(); if (conn->uri == NULL) { conn->uri = xmlParseURI(uid ? "vbox:///session" : "vbox:///system"); if (conn->uri == NULL) { + virReportOOMError(conn); return VIR_DRV_OPEN_ERROR; } - } else if (conn->uri->scheme == NULL || - conn->uri->path == NULL ) { - return VIR_DRV_OPEN_DECLINED; } - if (STRNEQ (conn->uri->scheme, "vbox")) + if (conn->uri->scheme == NULL || + STRNEQ (conn->uri->scheme, "vbox")) + return VIR_DRV_OPEN_DECLINED; + + /* Leave for remote driver */ + if (conn->uri->server != NULL) return VIR_DRV_OPEN_DECLINED; + if (conn->uri->path == NULL || STREQ(conn->uri->path, "")) { + vboxError(conn, VIR_ERR_INTERNAL_ERROR, "%s", + _("no VirtualBox drviver path specified (try vbox:///session)")); + return VIR_DRV_OPEN_ERROR; + } + if (uid != 0) { - if (STRNEQ (conn->uri->path, "/session")) - return VIR_DRV_OPEN_DECLINED; + if (STRNEQ (conn->uri->path, "/session")) { + vboxError(conn, VIR_ERR_INTERNAL_ERROR, + _("unknown driver path '%s' specified (try vbox:///session)"), conn->uri->path); + return VIR_DRV_OPEN_ERROR; + } } else { /* root */ if (STRNEQ (conn->uri->path, "/system") && - STRNEQ (conn->uri->path, "/session")) - return VIR_DRV_OPEN_DECLINED; + STRNEQ (conn->uri->path, "/session")) { + vboxError(conn, VIR_ERR_INTERNAL_ERROR, + _("unknown driver path '%s' specified (try vbox:///system)"), conn->uri->path); + return VIR_DRV_OPEN_ERROR; + } } if (VIR_ALLOC(data) < 0) { virReportOOMError(conn); - goto cleanup; + return VIR_DRV_OPEN_ERROR; } - if (!(data->caps = vboxCapsInit())) - goto cleanup; - - if (vboxInitialize(conn, data) < 0) - goto cleanup; - - if (vboxExtractVersion(conn, data) < 0) - goto cleanup; + if (!(data->caps = vboxCapsInit()) || + vboxInitialize(conn, data) < 0 || + vboxExtractVersion(conn, data) < 0) { + vboxUninitialize(data); + return VIR_DRV_OPEN_ERROR; + } conn->privateData = data; DEBUG0("in vboxOpen"); return VIR_DRV_OPEN_SUCCESS; -cleanup: - vboxUninitialize(data); - return VIR_DRV_OPEN_DECLINED; } static int vboxClose(virConnectPtr conn) { -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

4 5

[libvirt] [PATCH] also enable bridges without IP address
by Ludwig Nussel 12 May '09

12 May '09

Bridges that are not up won't forward packets Signed-off-by: Ludwig Nussel <ludwig.nussel(a)suse.de> cu Ludwig --- src/network_driver.c | 9 +++------ 1 files changed, 3 insertions(+), 6 deletions(-) diff --git a/src/network_driver.c b/src/network_driver.c index a17a769..a163b15 100644 --- a/src/network_driver.c +++ b/src/network_driver.c @@ -836,8 +836,7 @@ static int networkStartNetworkDaemon(virConnectPtr conn, goto err_delbr; } - if (network->def->ipAddress && - (err = brSetInterfaceUp(driver->brctl, network->def->bridge, 1))) { + if ((err = brSetInterfaceUp(driver->brctl, network->def->bridge, 1))) { virReportSystemError(conn, err, _("failed to bring the bridge '%s' up"), network->def->bridge); @@ -878,8 +877,7 @@ static int networkStartNetworkDaemon(virConnectPtr conn, networkRemoveIptablesRules(driver, network); err_delbr1: - if (network->def->ipAddress && - (err = brSetInterfaceUp(driver->brctl, network->def->bridge, 0))) { + if ((err = brSetInterfaceUp(driver->brctl, network->def->bridge, 0))) { char ebuf[1024]; networkLog(NETWORK_WARN, _("Failed to bring down bridge '%s' : %s\n"), network->def->bridge, virStrerror(err, ebuf, sizeof ebuf)); @@ -920,8 +918,7 @@ static int networkShutdownNetworkDaemon(virConnectPtr conn, networkRemoveIptablesRules(driver, network); char ebuf[1024]; - if (network->def->ipAddress && - (err = brSetInterfaceUp(driver->brctl, network->def->bridge, 0))) { + if ((err = brSetInterfaceUp(driver->brctl, network->def->bridge, 0))) { networkLog(NETWORK_WARN, _("Failed to bring down bridge '%s' : %s\n"), network->def->bridge, virStrerror(err, ebuf, sizeof ebuf)); } -- 1.6.2.1

3 2

[libvirt] PATCH: ALlow for quiet build
by Daniel P. Berrange 12 May '09

12 May '09

This is a simpler version of http://www.redhat.com/archives/libvir-list/2009-April/msg00523.html just overriding the LIBTOOL variable in configure.in, instead of in each Makefile.am As before you still need 'make -s' to get full effect Daniel diff -r f94c0624da5c configure.in --- a/configure.in Fri May 08 11:41:29 2009 +0100 +++ b/configure.in Mon May 11 16:46:08 2009 +0100 @@ -57,6 +57,9 @@ dnl Support building Win32 DLLs (must ap AC_LIBTOOL_WIN32_DLL AM_PROG_LIBTOOL +dnl Override normal libtool in favour of our quiet version +LIBTOOL='$(SHELL) $(top_srcdir)/mylibtool' +AC_SUBST([LIBTOOL]) AM_PROG_CC_C_O diff -r f94c0624da5c mylibtool --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/mylibtool Mon May 11 16:46:08 2009 +0100 @@ -0,0 +1,58 @@ +#!/bin/sh + +mode=libtool +cfiles="" +ofiles="" +afiles="" + +wantnext=0 +for v in "$@" +do + case $v + in + --mode=compile) + mode=CC + ;; + --mode=link) + mode=LD + ;; + esac + + case $v + in + *.c) + cfiles="$cfiles $v" + ;; + *.o) + if [ "$mode" = "LD" -o "$wantnext" = "1" ]; then + ofiles="$ofiles $v" + fi + ;; + *.lo) + if [ "$mode" = "LD" -o "$wantnext" = "1" ]; then + ofiles="$ofiles $v" + fi + ;; + esac + + if [ "$mode" = "LD" -a "$wantnext" = "1" ]; then + afiles="$afiles $v" + fi + + if [ "$v" = "-o" ]; then + wantnext=1 + else + wantnext=0 + fi +done + +args="" +test -n "$afiles" && args="$args -o$afiles" +test -n "$ofiles" -a "$mode" = "CC" && args="$args -o" +test -n "$ofiles" && args="$args$ofiles" +test -n "$cfiles" && args="$args$cfiles" + +echo "($mode)$args" + +here=`dirname $0` +exec $here/libtool --silent "$@" -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

3 2

[libvirt] Java binding
by Zvi Dubitzky 12 May '09

12 May '09

Who is the contact for libvirt Java binding ? In a late mail I said that the Java binding crashes upon live migrate when the dname=null . It does not crash if dname = source domain name even though works slow. The C code of libvirt / libvirt.c /virDomainMigrate () says in its header that : "If a hypervisor supports renaming domains during migration, * then you may set the dname parameter to the new name (otherwise * it keeps the same name). If this is not supported by the * hypervisor, dname must be NULL or else you will get an error." So in the kvm case dname = NULL works for the C binding but not for the JAVA binding as it should . Any idea ? thanks Zvi Dubitzky Virtualization and System Architecture Email:dubi@il.ibm.com IBM Haifa Research Laboratory Phone: +972-4-8296182 Haifa, 31905, ISRAEL

2 1

[libvirt] PATCH: 0/4: Fix the event loop (again) no really, this time its fixed.
by Daniel P. Berrange 12 May '09

12 May '09

Back in March I attempted to fix the event loop handling of deleted file handles http://www.redhat.com/archives/libvir-list/2009-March/msg00246.html but have merely succeeded in screwing it up in a different fun & exciting way. That patch fixed a case where there was a deleted file handle in the list at the time virEventRunOnce() starts. Which was nice. Not nice, though was that it then breaks the case where a file handle is deleted during the course of dispatching events afer poll(). Investigating this also identified that when we were marking a file handle as deleted, we were forgetting to run virEventInterrupt(), which meant that in some cases the main thread would not be woken up until the next event triggers. Not very critical, but at the same time, not good because it delays cleanup & release of resources. This series of patches fixes the problems, and more importantly, adds a unit test which cover these nasty edge cases. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

3 10

[libvirt] QEMU/KVM auto-detection bug
by Chris Lalancette 12 May '09

12 May '09

All, Even with Guido/Pritesh's recent changes to the vbox open routine, the auto-detection in libvirt is currently broken. What happens is that in src/libvirt.c:do_open(), at the start of the loop to auto-detect drivers, ret->uri is NULL. As each driver declines, it remains NULL. However, the very first thing the vboxOpen() routine does is: if (conn->uri == NULL) { conn->uri = xmlParseURI(uid ? "vbox:///session" : "vbox:///system"); if (conn->uri == NULL) { return VIR_DRV_OPEN_ERROR; } So, any driver that is trying to auto-probe after vboxOpen sees a conn->uri with a scheme of vbox and a path of system/session, and they all fail (including Qemu, which is what I'm mostly concerned with at the moment). In point of fact, this whole auto-detection thing is fragile. We got away with it before because the qemuOpen() routine bombs out before doing the whole conn->uri == NULL check, but in general, it's very easy for one buggy driver to mess up auto-detection for all drivers. Any thoughts about where to go here? We should obviously fix the vboxOpen() routine to not mess with the URI if it's going to fail. Additionally, I was thinking that maybe we should reset conn->uri to NULL in each iteration of the auto-detection loop. While that might leak memory for buggy drivers, it should at least make this whole thing less fragile. Thoughts? -- Chris Lalancette

3 5

[libvirt] [PATCH 1/6] Allow multiple monitor devices (v2)
by Anthony Liguori 12 May '09

12 May '09

Right now only one monitor device can be enabled at a time. In order to support asynchronous notification of events, I would like to introduce a 'wait' command that waits for an event to occur. This implies that we need an additional monitor session to allow commands to still be executed while waiting for an asynchronous notification. Signed-off-by: Anthony Liguori <aliguori(a)us.ibm.com> diff --git a/vl.c b/vl.c index 4bd173f..f78cabb 100644 --- a/vl.c +++ b/vl.c @@ -184,6 +184,9 @@ int main(int argc, char **argv) /* Max number of bluetooth switches on the commandline. */ #define MAX_BT_CMDLINE 10 +/* Maximum number of monitor devices */ +#define MAX_MONITOR_DEVICES 10 + /* XXX: use a two level table to limit memory usage */ #define MAX_IOPORTS 65536 @@ -4252,8 +4255,9 @@ int main(int argc, char **argv, char **envp) int hda_index; int optind; const char *r, *optarg; - CharDriverState *monitor_hd = NULL; - const char *monitor_device; + CharDriverState *monitor_hds[MAX_MONITOR_DEVICES]; + const char *monitor_devices[MAX_MONITOR_DEVICES]; + int monitor_device_index; const char *serial_devices[MAX_SERIAL_PORTS]; int serial_device_index; const char *parallel_devices[MAX_PARALLEL_PORTS]; @@ -4324,7 +4328,6 @@ int main(int argc, char **argv, char **envp) kernel_cmdline = ""; cyls = heads = secs = 0; translation = BIOS_ATA_TRANSLATION_AUTO; - monitor_device = "vc:80Cx24C"; serial_devices[0] = "vc:80Cx24C"; for(i = 1; i < MAX_SERIAL_PORTS; i++) @@ -4340,6 +4343,11 @@ int main(int argc, char **argv, char **envp) virtio_consoles[i] = NULL; virtio_console_index = 0; + monitor_devices[0] = "vc:80Cx24C"; + for (i = 1; i < MAX_MONITOR_DEVICES; i++) + monitor_devices[i] = NULL; + monitor_device_index = 0; + usb_devices_index = 0; nb_net_clients = 0; @@ -4723,7 +4731,12 @@ int main(int argc, char **argv, char **envp) break; } case QEMU_OPTION_monitor: - monitor_device = optarg; + if (monitor_device_index >= MAX_MONITOR_DEVICES) { + fprintf(stderr, "qemu: too many monitor devices\n"); + exit(1); + } + monitor_devices[monitor_device_index] = optarg; + monitor_device_index++; break; case QEMU_OPTION_serial: if (serial_device_index >= MAX_SERIAL_PORTS) { @@ -4974,8 +4987,8 @@ int main(int argc, char **argv, char **envp) serial_devices[0] = "stdio"; if (parallel_device_index == 0) parallel_devices[0] = "null"; - if (strncmp(monitor_device, "vc", 2) == 0) - monitor_device = "stdio"; + if (strncmp(monitor_devices[0], "vc", 2) == 0) + monitor_devices[0] = "stdio"; } #ifndef _WIN32 @@ -5184,14 +5197,14 @@ int main(int argc, char **argv, char **envp) #endif /* Maintain compatibility with multiple stdio monitors */ - if (!strcmp(monitor_device,"stdio")) { + if (!strcmp(monitor_devices[0],"stdio")) { for (i = 0; i < MAX_SERIAL_PORTS; i++) { const char *devname = serial_devices[i]; if (devname && !strcmp(devname,"mon:stdio")) { - monitor_device = NULL; + monitor_devices[0] = NULL; break; } else if (devname && !strcmp(devname,"stdio")) { - monitor_device = NULL; + monitor_devices[0] = NULL; serial_devices[i] = "mon:stdio"; break; } @@ -5208,11 +5221,20 @@ int main(int argc, char **argv, char **envp) } } - if (monitor_device) { - monitor_hd = qemu_chr_open("monitor", monitor_device, NULL); - if (!monitor_hd) { - fprintf(stderr, "qemu: could not open monitor device '%s'\n", monitor_device); - exit(1); + for (i = 0; i < MAX_MONITOR_DEVICES; i++) { + const char *devname = monitor_devices[i]; + if (devname && strcmp(devname, "none")) { + char label[32]; + if (i == 0) + snprintf(label, sizeof(label), "monitor"); + else + snprintf(label, sizeof(label), "monitor%d", i); + monitor_hds[i] = qemu_chr_open(label, devname, NULL); + if (!monitor_hds[i]) { + fprintf(stderr, "qemu: could not open monitor device '%s'\n", + devname); + exit(1); + } } } @@ -5335,8 +5357,13 @@ int main(int argc, char **argv, char **envp) text_consoles_set_display(display_state); qemu_chr_initial_reset(); - if (monitor_device && monitor_hd) - monitor_init(monitor_hd, MONITOR_USE_READLINE | MONITOR_IS_DEFAULT); + for (i = 0; i < MAX_MONITOR_DEVICES; i++) { + if (monitor_devices[i] && monitor_hds[i]) { + monitor_init(monitor_hds[i], + MONITOR_USE_READLINE | + ((i == 0) ? MONITOR_IS_DEFAULT : 0)); + } + } for(i = 0; i < MAX_SERIAL_PORTS; i++) { const char *devname = serial_devices[i];

11 60

[libvirt] PATCH: Fix QEMU arg detection for kvm >= 85
by Daniel P. Berrange 11 May '09

11 May '09

The -help output from KVM >= 85 is now large than we expected. This patch increases the buffer from 8k to 64k when reading help. It also provides more detailed error messages should something go wrong in the future. Two examples of improved error reporting # virsh -c qemu:///system start VirtTest error: Failed to start domain VirtTest error: Unable to read QEMU help output: Value too large for defined data type # virsh -c qemu:///system start VirtTest error: Failed to start domain VirtTest error: internal error cannot parse QEMU version number in 'QEMU PC emulator version 0.9.1 (kvm-79), Copyright (c) 2003-2008 Fabrice Bellard' Daniel Index: src/qemu_conf.c =================================================================== RCS file: /data/cvs/libvirt/src/qemu_conf.c,v retrieving revision 1.145 diff -u -p -r1.145 qemu_conf.c --- src/qemu_conf.c 8 May 2009 10:07:16 -0000 1.145 +++ src/qemu_conf.c 8 May 2009 10:37:22 -0000 @@ -431,18 +431,28 @@ int qemudExtractVersionInfo(const char * return -1; char *help = NULL; - enum { MAX_HELP_OUTPUT_SIZE = 8192 }; + enum { MAX_HELP_OUTPUT_SIZE = 1024*64 }; int len = virFileReadLimFD(newstdout, MAX_HELP_OUTPUT_SIZE, &help); - if (len < 0) + if (len < 0) { + virReportSystemError(NULL, errno, "%s", + _("Unable to read QEMU help output")); goto cleanup2; + } if (sscanf(help, "QEMU PC emulator version %u.%u.%u (kvm-%u)", &major, &minor, &micro, &kvm_version) != 4) kvm_version = 0; - if (!kvm_version && sscanf(help, "QEMU PC emulator version %u.%u.%u", - &major, &minor, &micro) != 3) + if (!kvm_version && + sscanf(help, "QEMU PC emulator version %u.%u.%u", + &major, &minor, &micro) != 3) { + char *eol = strchr(help, '\n'); + if (eol) *eol = '\0'; + qemudReportError(NULL, NULL, NULL, VIR_ERR_INTERNAL_ERROR, + _("cannot parse QEMU version number in '%s'"), + help); goto cleanup2; + } version = (major * 1000 * 1000) + (minor * 1000) + micro; Index: src/qemu_driver.c =================================================================== RCS file: /data/cvs/libvirt/src/qemu_driver.c,v retrieving revision 1.236 diff -u -p -r1.236 qemu_driver.c --- src/qemu_driver.c 8 May 2009 10:11:14 -0000 1.236 +++ src/qemu_driver.c 8 May 2009 10:37:22 -0000 @@ -1379,12 +1379,8 @@ static int qemudStartVMDaemon(virConnect if (qemudExtractVersionInfo(emulator, NULL, - &qemuCmdFlags) < 0) { - qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR, - _("Cannot determine QEMU argv syntax %s"), - emulator); + &qemuCmdFlags) < 0) goto cleanup; - } if (qemuPrepareHostDevices(conn, vm->def) < 0) goto cleanup; @@ -3703,12 +3699,8 @@ static int qemudDomainChangeEjectableMed if (qemudExtractVersionInfo(vm->def->emulator, NULL, - &qemuCmdFlags) < 0) { - qemudReportError(conn, dom, NULL, VIR_ERR_INTERNAL_ERROR, - _("Cannot determine QEMU argv syntax %s"), - vm->def->emulator); + &qemuCmdFlags) < 0) return -1; - } if (qemuCmdFlags & QEMUD_CMD_FLAG_DRIVE) { if (!(devname = qemudDiskDeviceName(conn, newdisk))) -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

2 1

[libvirt] [PATCH v2 0/4] Improve QEMU process startup error
by Cole Robinson 11 May '09

11 May '09

Error reporting for failed QEMU processes isn't too great at the moment. A couple cases I have hit: - Trying to start a VM with a cdrom pointing to a nonexistent file. The svirt hook function choked on this and indicated as much in the domain log, but I still had to wait for the pidfile timeout (10 seconds), and the only error reported was 'Domain did not show up'. - QEMU dies quickly at startup. Happened with the pulse audio issue, or if we build cli args incorrectly. The reporting here varies: if QEMU dies before writing out the pidfile, the above case applies. If the pidfile is written, we timeout in ReadLogOutput, and it's hit or miss whether we even report the logfile output to the user. The following patches improve the above cases by ensuring we never have to wait for a timeout, and that the logfile output is always reported in the error message. Changes since v1: Drop patch 1 + 2 (applied separately) Patch 7 is pretty isolated, so was resent to list separately. Don't waitpid in virExecDaemonize if virExec fails. Remove needless pidfile loop in qemudStartVMDaemon. Thanks, Cole Cole Robinson (4): Add helper function virExecDaemonize Report qemu log data if we fail to daemonize the process. Add pidfile argument to __virExec Check that QEMU is still alive while reading startup output. src/libvirt_private.syms | 2 +- src/proxy_internal.c | 16 +--- src/qemu_conf.c | 7 -- src/qemu_driver.c | 89 +++++++++++-------- src/remote_internal.c | 15 +--- src/uml_driver.c | 11 +-- src/util.c | 90 +++++++++++++++++--- src/util.h | 15 +++- .../qemuxml2argvdata/qemuxml2argv-boot-cdrom.args | 2 +- .../qemuxml2argvdata/qemuxml2argv-boot-floppy.args | 2 +- .../qemuxml2argv-boot-network.args | 2 +- .../qemuxml2argvdata/qemuxml2argv-bootloader.args | 2 +- .../qemuxml2argv-clock-localtime.args | 2 +- tests/qemuxml2argvdata/qemuxml2argv-clock-utc.args | 2 +- .../qemuxml2argv-console-compat.args | 2 +- .../qemuxml2argv-disk-cdrom-empty.args | 2 +- .../qemuxml2argvdata/qemuxml2argv-disk-cdrom.args | 2 +- .../qemuxml2argv-disk-drive-boot-cdrom.args | 2 +- .../qemuxml2argv-disk-drive-boot-disk.args | 2 +- .../qemuxml2argv-disk-drive-cache-v1-none.args | 2 +- .../qemuxml2argv-disk-drive-cache-v1-wb.args | 2 +- .../qemuxml2argv-disk-drive-cache-v1-wt.args | 2 +- .../qemuxml2argv-disk-drive-cache-v2-none.args | 2 +- .../qemuxml2argv-disk-drive-cache-v2-wb.args | 2 +- .../qemuxml2argv-disk-drive-cache-v2-wt.args | 2 +- .../qemuxml2argv-disk-drive-fmt-qcow.args | 2 +- .../qemuxml2argv-disk-drive-shared.args | 2 +- .../qemuxml2argvdata/qemuxml2argv-disk-floppy.args | 2 +- tests/qemuxml2argvdata/qemuxml2argv-disk-many.args | 2 +- tests/qemuxml2argvdata/qemuxml2argv-disk-usb.args | 2 +- .../qemuxml2argvdata/qemuxml2argv-disk-virtio.args | 2 +- .../qemuxml2argvdata/qemuxml2argv-disk-xenvbd.args | 2 +- .../qemuxml2argv-graphics-sdl-fullscreen.args | 2 +- .../qemuxml2argv-graphics-sdl.args | 2 +- .../qemuxml2argv-graphics-vnc-sasl.args | 2 +- .../qemuxml2argv-graphics-vnc-tls.args | 2 +- .../qemuxml2argv-graphics-vnc.args | 2 +- .../qemuxml2argv-hostdev-pci-address.args | 2 +- .../qemuxml2argv-hostdev-usb-address.args | 2 +- .../qemuxml2argv-hostdev-usb-product.args | 2 +- .../qemuxml2argv-input-usbmouse.args | 2 +- .../qemuxml2argv-input-usbtablet.args | 2 +- tests/qemuxml2argvdata/qemuxml2argv-input-xen.args | 2 +- tests/qemuxml2argvdata/qemuxml2argv-migrate.args | 2 +- tests/qemuxml2argvdata/qemuxml2argv-minimal.args | 2 +- tests/qemuxml2argvdata/qemuxml2argv-misc-acpi.args | 2 +- .../qemuxml2argv-misc-no-reboot.args | 2 +- tests/qemuxml2argvdata/qemuxml2argv-misc-uuid.args | 2 +- .../qemuxml2argv-net-eth-ifname.args | 2 +- tests/qemuxml2argvdata/qemuxml2argv-net-eth.args | 2 +- tests/qemuxml2argvdata/qemuxml2argv-net-user.args | 2 +- .../qemuxml2argvdata/qemuxml2argv-net-virtio.args | 2 +- .../qemuxml2argv-parallel-tcp.args | 2 +- .../qemuxml2argvdata/qemuxml2argv-restore-v1.args | 2 +- .../qemuxml2argvdata/qemuxml2argv-restore-v2.args | 2 +- .../qemuxml2argvdata/qemuxml2argv-serial-dev.args | 2 +- .../qemuxml2argvdata/qemuxml2argv-serial-file.args | 2 +- .../qemuxml2argvdata/qemuxml2argv-serial-many.args | 2 +- .../qemuxml2argvdata/qemuxml2argv-serial-pty.args | 2 +- .../qemuxml2argv-serial-tcp-telnet.args | 2 +- .../qemuxml2argvdata/qemuxml2argv-serial-tcp.args | 2 +- .../qemuxml2argvdata/qemuxml2argv-serial-udp.args | 2 +- .../qemuxml2argvdata/qemuxml2argv-serial-unix.args | 2 +- tests/qemuxml2argvdata/qemuxml2argv-serial-vc.args | 2 +- tests/qemuxml2argvdata/qemuxml2argv-sound.args | 2 +- 65 files changed, 211 insertions(+), 148 deletions(-)

2 9

[libvirt] [PATCH 2/3] support for "Host only" and "Internal" networks in VirtualBox driver
by Pritesh Kothari 11 May '09

11 May '09

Hi All, As discussed on the list resending the networking patch's. the patch's are as below: [PATCH 1/3]: contains support for "Internal" network in libvirt [PATCH 2/3]: contains support for "Host only" and "Internal" networks in VirtualBox driver [PATCH 3/3]: contains networking API for hostonly networks in VirtualBox driver in libvirt (it contains all the fix's proposed on list along with two extra *DefinedNetworks functions) The patches work as per cvs checkin today. (git SHA1 ID: 9136ae2056b45ea83854d3fe31d860f645b8c883) Regards, Pritesh

3 2

[libvirt] [PATCH 1/3] support for "Internal" network in libvirt
by Pritesh Kothari 11 May '09

11 May '09

Hi All, As discussed on the list resending the networking patch's. the patch's are as below: [PATCH 1/3]: contains support for "Internal" network in libvirt [PATCH 2/3]: contains support for "Host only" and "Internal" networks in VirtualBox driver [PATCH 3/3]: contains networking API for hostonly networks in VirtualBox driver in libvirt (it contains all the fix's proposed on list along with two extra *DefinedNetworks functions) The patches work as per cvs checkin today. (git SHA1 ID: 9136ae2056b45ea83854d3fe31d860f645b8c883) Regards, Pritesh

3 2

[libvirt] Status and plans for next release
by Daniel Veillard 11 May '09

11 May '09

Seems I didn't send any reminder about the next release plans on Friday, so here is a recap: - feature freeze on the 22nd so we have 2 more week to work on reviewing and adding OpenNebula/Power drivers and try to get the NPIV, netcf and secure migration patches in. It's likely not everything will make the release cut but we can try ! - target for next release is Friday 29th So far we have mostly a lot of bug fixes and VirtualBox driver updates commited since 0.6.3, Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

1 0

[libvirt] Java binding blockStats bug (libvirt-java-0.2.1)
by Zvi Dubitzky 11 May '09

11 May '09

running blcokStats() with Java binding (libvirt-java-0.2.1 ) I get an exception Inspecting the src/jni/org_libvirt_Domain.c is see the following lines of code : JNIEXPORT jobject JNICALL Java_org_libvirt_Domain__1blockStats (JNIEnv *env, jobject obj, jlong VDP, jstring j_path){ struct _virDomainBlockStats stats; jobject j_stats; jclass stats_cls=(*env)->FindClass(env, "org/libvirt/DomainInterfaceStats"); const char *path = (*env)->GetStringUTFChars(env, j_path, NULL); if(virDomainBlockStats((virDomainPtr)VDP, path, &stats, sizeof(struct _virDomainBlockStats))<0){ (*env)->ReleaseStringUTFChars(env, j_path, path); return NULL; } . . . The bold line should be replaced by : jclass stats_cls=(*env)->FindClass(env, "org/libvirt/DomainBlockStats") as we deal here with blockStats and not network interface Stats ! thanks Zvi Dubitzky Virtualization and System Architecture Email:dubi@il.ibm.com IBM Haifa Research Laboratory Phone: +972-4-8296182 Haifa, 31905, ISRAEL

2 1

[libvirt] Fw: Java api for domain migration
by Zvi Dubitzky 10 May '09

10 May '09

Sorry , clarification: Bottom line is that the Java binding of libvirt should accept 'dname' parameter = null as the C libvirt case does without crashing The below stament that " If I try to specify a meaningful 'dname' then if it is the same name as the original host domain 'name' I will get a message saying : invalid domain pointer in no domain with matching id -1." is not correct. The migrate works under Java in this case as in the C case i.e the domain is migrated to the destination host but remains paused there for a long time until resumed there. If the 'dname' is null then the migration is faster but that works ok only with the libvirt C library. It crashes with the Java binding . Zvi Dubitzky Virtualization and System Architecture Email:dubi@il.ibm.com IBM Haifa Research Laboratory Phone: +972-4-8296182 Haifa, 31905, ISRAEL ----- Forwarded by Zvi Dubitzky/Haifa/IBM on 10/05/2009 13:29 ----- Zvi Dubitzky/Haifa/IBM 10/05/2009 13:14 To libvir-list(a)redhat.com cc Subject Fw: Java api for domain migration Hi I think I detected the origin of the libvirt Java binding crash in the case of domain migration though I do not know how to fix it yet . The fix should be in the src/jni/org_libvirt_Domain.c / migrate function. First: It turns out the that the C libvirt interface for migrate ( libvirt 0.6.1. + kvm-84) has a limitation with specifying the 'dname' parameter . It should be NULL to work ok , meaning the domain is migrated from the old host to the new host under the same domain name . If I try to specify a meaningful 'dname' then if it is the same name as the original host domain 'name' I will get a message saying : invalid domain pointer in no domain with matching id -1. If I am using 'dname' different than the original host domain 'name' it will complain that no such domain is found on the target host. So using NULL for 'dname' is the only one that makes the migrate work Using 'dname' = NULL with the Java binding causes it though to crash as below (see .log file). Fixing the jni code as below (see added 'if') does not help: src/jni/org_libvirt_Domain.c -------------------------------- JNIEXPORT jlong JNICALL Java_org_libvirt_Domain__1migrate (JNIEnv *env, jobject obj, jlong VDP, jobject dconn, jlong flags, jstring j_dname, jstring j_uri, jlong bandwidth){ virConnectPtr destVCP; const char *dname=NULL; const char *uri=NULL; //if String="", we pass NULL to the library if((*env)->GetStringLength(env, j_dname)>0) dname=(*env)->GetStringUTFChars(env, j_dname, NULL); //if String="", we pass NULL to the library if((*env)->GetStringLength(env, j_uri)>0) uri=(*env)->GetStringUTFChars(env, j_uri, NULL); //Extract the destination Conn Ptr destVCP=(virConnectPtr)(*env)->GetLongField(env, dconn, (*env)->GetFieldID(env, (*env)->GetObjectClass(env, dconn), "VCP", "J")); jlong retval = (jlong)virDomainMigrate((virDomainPtr)VDP, destVCP, flags, dname, uri, bandwidth) ; if (dname) (*env)->ReleaseStringUTFChars(env, j_dname, dname); if (uri) (*env)->ReleaseStringUTFChars(env, j_uri, uri); return retval; } Please your advice on how to solve the migrate for the Java binding thanks Zvi Dubitzky Virtualization and System Architecture Email:dubi@il.ibm.com IBM Haifa Research Laboratory Phone: +972-4-8296182 Haifa, 31905, ISRAEL ----- Forwarded by Zvi Dubitzky/Haifa/IBM on 10/05/2009 12:59 ----- Zvi Dubitzky/Haifa/IBM 07/05/2009 13:49 To libvir-list(a)redhat.com cc Subject Java api for libvirt migration I am trying to do a migrate of VM with libvirt 0.6.1 and kvm-84 . I am successful in doing it many times via the C interface . I can do most of the basic libvirt activity via the libvirt JAVA library (libvirt-java-0.2.1). When it comes to a migrate the JVM fails wit a log file attached below . Can someone help. My memory consumption in my JAVA test code is small. The migrate parameters I am sending with the Java are identical to those I use in the C case and is: destDomain = localDomain.migrate (dcon, // destination host Connect object VIR_MIGRATE_LIVE, null, //const char *dname destination domain name target_uri, //"tcp:9.148.28.13:4444" 0 // unsigned long bandwidth) - do not specify ); thanks Zvi Dubitzky Virtualization and System Architecture Email:dubi@il.ibm.com IBM Haifa Research Laboratory Phone: +972-4-8296182 Haifa, 31905, ISRAEL

1 0

[libvirt] Fw: Java api for domain migration
by Zvi Dubitzky 10 May '09

10 May '09

Hi I think I detected the origin of the libvirt Java binding crash in the case of domain migration though I do not know how to fix it yet . The fix should be in the src/jni/org_libvirt_Domain.c / migrate function. First: It turns out the that the C libvirt interface for migrate ( libvirt 0.6.1. + kvm-84) has a limitation with specifying the 'dname' parameter . It should be NULL to work ok , meaning the domain is migrated from the old host to the new host under the same domain name . If I try to specify a meaningful 'dname' then if it is the same name as the original host domain 'name' I will get a message saying : invalid domain pointer in no domain with matching id -1. If I am using 'dname' different than the original host domain 'name' it will complain that no such domain is found on the target host. So using NULL for 'dname' is the only one that makes the migrate work Using 'dname' = NULL with the Java binding causes it though to crash as below (see .log file). Fixing the jni code as below (see added 'if') does not help: src/jni/org_libvirt_Domain.c -------------------------------- JNIEXPORT jlong JNICALL Java_org_libvirt_Domain__1migrate (JNIEnv *env, jobject obj, jlong VDP, jobject dconn, jlong flags, jstring j_dname, jstring j_uri, jlong bandwidth){ virConnectPtr destVCP; const char *dname=NULL; const char *uri=NULL; //if String="", we pass NULL to the library if((*env)->GetStringLength(env, j_dname)>0) dname=(*env)->GetStringUTFChars(env, j_dname, NULL); //if String="", we pass NULL to the library if((*env)->GetStringLength(env, j_uri)>0) uri=(*env)->GetStringUTFChars(env, j_uri, NULL); //Extract the destination Conn Ptr destVCP=(virConnectPtr)(*env)->GetLongField(env, dconn, (*env)->GetFieldID(env, (*env)->GetObjectClass(env, dconn), "VCP", "J")); jlong retval = (jlong)virDomainMigrate((virDomainPtr)VDP, destVCP, flags, dname, uri, bandwidth) ; if (dname) (*env)->ReleaseStringUTFChars(env, j_dname, dname); if (uri) (*env)->ReleaseStringUTFChars(env, j_uri, uri); return retval; } Please your advice on how to solve the migrate for the Java binding thanks Zvi Dubitzky Virtualization and System Architecture Email:dubi@il.ibm.com IBM Haifa Research Laboratory Phone: +972-4-8296182 Haifa, 31905, ISRAEL ----- Forwarded by Zvi Dubitzky/Haifa/IBM on 10/05/2009 12:59 ----- Zvi Dubitzky/Haifa/IBM 07/05/2009 13:49 To libvir-list(a)redhat.com cc Subject Java api for libvirt migration I am trying to do a migrate of VM with libvirt 0.6.1 and kvm-84 . I am successful in doing it many times via the C interface . I can do most of the basic libvirt activity via the libvirt JAVA library (libvirt-java-0.2.1). When it comes to a migrate the JVM fails wit a log file attached below . Can someone help. My memory consumption in my JAVA test code is small. The migrate parameters I am sending with the Java are identical to those I use in the C case and is: destDomain = localDomain.migrate (dcon, // destination host Connect object VIR_MIGRATE_LIVE, null, //const char *dname destination domain name target_uri, //"tcp:9.148.28.13:4444" 0 // unsigned long bandwidth) - do not specify ); thanks Zvi Dubitzky Virtualization and System Architecture Email:dubi@il.ibm.com IBM Haifa Research Laboratory Phone: +972-4-8296182 Haifa, 31905, ISRAEL

1 0

[libvirt] migration fails
by jens 09 May '09

09 May '09

Hello, I tried to migrate a kvm domain to a second identical machine with the command: virsh migrate --live dom1 qemu+ssh://second.machine.org/system which leads me to an unresponsive virsh on the second machine - 'virsh list' just takes forever and qemu wasn't started (the domain was not migrated), finally I have to kill libvirtd on the second machine. Because I'm new to libvirt I searched the web to find a solution for this behavior but without success. Please can someone on the list point me to the right direction how I can use libvirt to migrate kvm domains? I use kernel 2.6.29.1 and kvm-85 with libvirt 0.6.2 on an debian unstable system. Attached are debug logs generated by the source- and destination-machine. Thank you very much Jens

5 7

[libvirt] [PATCH] change permissions of directories in cgroups
by Ryota Ozaki 08 May '09

08 May '09

Hi, This patch creates a directory in cgroups with an ordinary permission 0755 (rwxr-xr-x) instead of 0655 (rw-r-xr-x). I guess 0655 is not expected and just a mistake, or is there a special reason? Thanks, ozaki-r Signed-off-by: Ryota Ozaki <ozaki.ryota(a)gmail.com> >From 4829855bc0baa3c75806f106bc0e54eb1da75eea Mon Sep 17 00:00:00 2001 From: Ryota Ozaki <ozaki.ryota(a)gmail.com> Date: Fri, 8 May 2009 03:23:50 +0900 Subject: [PATCH] change permissions of directories in cgroups This patch creates a directory in cgroups with an ordinary permission 0755 (rwxr-xr-x) instead of 0655 (rw-r-xr-x). --- src/cgroup.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/cgroup.c b/src/cgroup.c index d1d44a2..50517e2 100644 --- a/src/cgroup.c +++ b/src/cgroup.c @@ -436,7 +436,7 @@ static int virCgroupMakeGroup(const char *name) virCgroupFree(&root); if (access(path, F_OK) != 0) { - if (mkdir(path, 0655) < 0) { + if (mkdir(path, 0755) < 0) { rc = -errno; VIR_FREE(path); break; -- 1.6.0.6

3 3