[libvirt] [PATCH] Fix '-pie' build with clang
Commit 97e70a593589e8f0432a748b4b93c3cdc18b9e5a added the option -pie to CFLAGS and LDFLAGS, however '-pie' is just a linker option. That wouldn't be a problem. However, clang is checking for that and outputs an error or unused argument: error: argument unused during compilation: '-pie' Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- m4/virt-compile-pie.m4 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/m4/virt-compile-pie.m4 b/m4/virt-compile-pie.m4 index c0fb346ff784..a2df38ea7272 100644 --- a/m4/virt-compile-pie.m4 +++ b/m4/virt-compile-pie.m4 @@ -26,7 +26,7 @@ AC_DEFUN([LIBVIRT_COMPILE_PIE],[ ;; dnl All code is position independent on Win32 target *) gl_COMPILER_OPTION_IF([-fPIE -DPIE -pie], [ - PIE_CFLAGS="-fPIE -DPIE -pie" + PIE_CFLAGS="-fPIE -DPIE" PIE_LDFLAGS="-pie" ]) esac -- 2.7.1
On Tue, 2016-02-09 at 13:13 +0100, Martin Kletzander wrote:
Commit 97e70a593589e8f0432a748b4b93c3cdc18b9e5a added the option -pie to CFLAGS and LDFLAGS, however '-pie' is just a linker option. That wouldn't be a problem. However, clang is checking for that and outputs an error or unused argument:
error: argument unused during compilation: '-pie'
Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- m4/virt-compile-pie.m4 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/m4/virt-compile-pie.m4 b/m4/virt-compile-pie.m4 index c0fb346ff784..a2df38ea7272 100644 --- a/m4/virt-compile-pie.m4 +++ b/m4/virt-compile-pie.m4 @@ -26,7 +26,7 @@ AC_DEFUN([LIBVIRT_COMPILE_PIE],[ ;; dnl All code is position independent on Win32 target *) gl_COMPILER_OPTION_IF([-fPIE -DPIE -pie], [ - PIE_CFLAGS="-fPIE -DPIE -pie" + PIE_CFLAGS="-fPIE -DPIE" PIE_LDFLAGS="-pie" ]) esac
ACK -- Andrea Bolognani Software Engineer - Virtualization Team
participants (2)
-
Andrea Bolognani -
Martin Kletzander