[libvirt] [PATCHv2] spec: add missing dep of libvirt-daemon-config-network
From: Thierry Parmentelat <thierry.parmentelat@inria.fr> When building modules, libvirt-daemon-config-network requires libvirt-daemon-driver-network to ensure the 'default' network is setup properly Signed-off-by: Eric Blake <eblake@redhat.com> --- v2: make dep dependent on whether subpackage is created libvirt.spec.in | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libvirt.spec.in b/libvirt.spec.in index 4d804e6..d3e6048 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -720,6 +720,9 @@ Summary: Default configuration files for the libvirtd daemon Group: Development/Libraries Requires: libvirt-daemon = %{version}-%{release} + %if %{with_driver_modules} +Requires: libvirt-daemon-driver-network = %{version}-%{release} + %endif %description daemon-config-network Default configuration files for setting up NAT based networking -- 1.8.5.3
On Wed, Feb 12, 2014 at 01:25:11PM -0700, Eric Blake wrote:
From: Thierry Parmentelat <thierry.parmentelat@inria.fr>
When building modules, libvirt-daemon-config-network requires libvirt-daemon-driver-network to ensure the 'default' network is setup properly
Signed-off-by: Eric Blake <eblake@redhat.com> ---
v2: make dep dependent on whether subpackage is created
libvirt.spec.in | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/libvirt.spec.in b/libvirt.spec.in index 4d804e6..d3e6048 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -720,6 +720,9 @@ Summary: Default configuration files for the libvirtd daemon Group: Development/Libraries
Requires: libvirt-daemon = %{version}-%{release} + %if %{with_driver_modules} +Requires: libvirt-daemon-driver-network = %{version}-%{release} + %endif
%description daemon-config-network Default configuration files for setting up NAT based networking -- 1.8.5.3
ACK. Shouldn't the same be done with the daemon-config-nwfilter package? ACK for that too if you want to add it to this patch (or separately). Martin
On 02/12/2014 02:26 PM, Martin Kletzander wrote:
On Wed, Feb 12, 2014 at 01:25:11PM -0700, Eric Blake wrote:
From: Thierry Parmentelat <thierry.parmentelat@inria.fr>
When building modules, libvirt-daemon-config-network requires libvirt-daemon-driver-network to ensure the 'default' network is setup properly
Signed-off-by: Eric Blake <eblake@redhat.com> ---
v2: make dep dependent on whether subpackage is created
ACK.
Thanks; pushed.
Shouldn't the same be done with the daemon-config-nwfilter package? ACK for that too if you want to add it to this patch (or separately).
Separate patch; coming up later once I do more testing. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
participants (2)
-
Eric Blake -
Martin Kletzander