[libvirt] how to make syntax-check on tar-tall released-version
Hi all: I downloaded libvirt v1.3.4 from http://libvirt.org/sources, and try to make syntax-check inside the code tree. But I encounted with many problems, first, I need to have file .gitignore and directory .git, and then have gnulib, many problems still comes out after that. I still have not fixed the problems until now. So what's the right way to make syntax-check on released-version libvirt project? Thanks in advance. Oscar.
On Fri, Jun 24, 2016 at 09:58:59AM +0000, Zhangbo (Oscar) wrote:
Hi all: I downloaded libvirt v1.3.4 from http://libvirt.org/sources, and try to make syntax-check inside the code tree. But I encounted with many problems, first, I need to have file .gitignore and directory .git, and then have gnulib, many problems still comes out after that. I still have not fixed the problems until now. So what's the right way to make syntax-check on released-version libvirt project? Thanks in advance.
You're not. The syntax-check rule is for developers to use before merging code to git master. There's no reason to use it on released versions Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
Hi all: I downloaded libvirt v1.3.4 from http://libvirt.org/sources, and try to make syntax-check inside the code tree. But I encounted with many problems, first, I need to have file .gitignore and directory .git, and then have gnulib, many problems still comes out after that. I still have not fixed the problems until now. So what's the right way to make syntax-check on released-version libvirt project? Thanks in advance.
You're not. The syntax-check rule is for developers to use before merging code to git master. There's no reason to use it on released versions
Here's my situation: I want to use libvirt v1.3.4 as my own git base, the steps are: 1 Download libvirt v1.3.4 from http://libvirt.org/sources 2 add .gitignore inside the code tree 3 run "git init" to generate my own git tree 4 do some develop work 5 FAILED to do make syntax-check If we want to have our own git repository, what's the right way to do? Is it necessary to do "git fork" rather than "git init" to do development work?
Regards, Daniel --
On Sat, Jun 25, 2016 at 12:49:41AM +0000, Zhangbo (Oscar) wrote:
Hi all: I downloaded libvirt v1.3.4 from http://libvirt.org/sources, and try to make syntax-check inside the code tree. But I encounted with many problems, first, I need to have file .gitignore and directory .git, and then have gnulib, many problems still comes out after that. I still have not fixed the problems until now. So what's the right way to make syntax-check on released-version libvirt project? Thanks in advance.
You're not. The syntax-check rule is for developers to use before merging code to git master. There's no reason to use it on released versions
Here's my situation: I want to use libvirt v1.3.4 as my own git base, the steps are: 1 Download libvirt v1.3.4 from http://libvirt.org/sources 2 add .gitignore inside the code tree 3 run "git init" to generate my own git tree 4 do some develop work 5 FAILED to do make syntax-check
If we want to have our own git repository, what's the right way to do? Is it necessary to do "git fork" rather than "git init" to do development work?
Why on earth are you even doing this. Just clone the real git repository in the normal manner. We always want all patches to be submitted against git master, not released versions. Even if you did want to work on an old release, you can just checkout the vN.N.N-maint branch from the main git repo. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
On Sat, 2016-06-25 at 00:49 +0000, Zhangbo (Oscar) wrote:
Here's my situation: I want to use libvirt v1.3.4 as my own git base, the steps are: 1 Download libvirt v1.3.4 from http://libvirt.org/sources 2 add .gitignore inside the code tree 3 run "git init" to generate my own git tree 4 do some develop work 5 FAILED to do make syntax-check If we want to have our own git repository, what's the right way to do? Is it necessary to do "git fork" rather than "git init" to do development work?
Yeah, you'll want to clone the upstream git repository using git clone git://libvirt.org/libvirt.git You'll then be able create your development branch based on 1.3.4 with git branch devel v1.3.4 git checkout devel Once you've done that, 'make syntax-check' will work. Please note that, unless you have very specific needs, you should base your development on the master branch instead of the 1.3.4 release: among other things, that's a requirement for having your changes merged upstream. -- Andrea Bolognani / Red Hat / Virtualization
participants (3)
-
Andrea Bolognani -
Daniel P. Berrange -
Zhangbo (Oscar)