On Fri, Jul 31, 2009 at 12:40:59PM -0400, Cole Robinson wrote:

If redefining a domain in the xen xm driver, we unconditionally set the domain ID to -1. This can make a running domain appear inactive, and really confuse things. Just drop the offending code, since virGetDomain already sets the ID to -1 if required.

Fix pointed out by Dan Berrange, more info can be found at https://bugzilla.redhat.com/show_bug.cgi?id=508278

ACK, looks good.

diff --git a/src/xm_internal.c b/src/xm_internal.c index 9d021eb..2ca4506 100644 --- a/src/xm_internal.c +++ b/src/xm_internal.c @@ -2640,9 +2640,7 @@ virDomainPtr xenXMDomainDefineXML(virConnectPtr conn, const char *xml) { goto error; }

- if ((ret = virGetDomain(conn, def->name, def->uuid))) - ret->id = -1; - + ret = virGetDomain(conn, def->name, def->uuid); xenUnifiedUnlock(priv); return (ret);

Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|