[libvirt] no check of freeMem before restoring a VM in libxl-driver, is it a bug?
in func 'libxlDomainRestoreFlags',it doesn't use 'libxlFreeMem' to check whether there are enough memory before restoring the vm!It just restore the vm anyway,until xenlight found no enough space in the middle of the process Is this a bug?or It's designed this way by purpose?Thanks in advance.
Oscar Ben wrote:
in func 'libxlDomainRestoreFlags',it doesn't use 'libxlFreeMem' to check whether there are enough memory before restoring the vm!It just restore the vm anyway,until xenlight found no enough space in the middle of the process Is this a bug?or It's designed this way by purpose?
libxlDomainRestoreFlags doesn't call libxlFreeMem directly, but it does call libxlVmStart, which afaics calls libxlFreeMem when restoring. Have you seen restore fail without a helpful error when there is insufficient memory to host the domain? Regards, Jim
participants (2)
-
Jim Fehlig -
Oscar Ben