[libvirt] [PATCH] build: restore mingw build
* bootstrap.conf (gnulib_modules): Add chmod. --- Pushing under the build-breaker rule; ./autobuild.sh failed to cross-compile to mingw due to commit d596c6d requiring chown(). The gnulib function is just an always-failing stub on mingw, but at least it lets things link again. bootstrap.conf | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/bootstrap.conf b/bootstrap.conf index 282768b..1eb8f8f 100644 --- a/bootstrap.conf +++ b/bootstrap.conf @@ -1,6 +1,6 @@ # Bootstrap configuration. -# Copyright (C) 2010 Red Hat, Inc. +# Copyright (C) 2010-2011 Red Hat, Inc. # This library is free software; you can redistribute it and/or # modify it under the terms of the GNU Lesser General Public @@ -23,6 +23,7 @@ areadlink base64 c-ctype canonicalize-lgpl +chmod close connect configmake -- 1.7.3.4
On 01/12/2011 05:44 PM, Eric Blake wrote:
* bootstrap.conf (gnulib_modules): Add chmod. ---
Pushing under the build-breaker rule; ./autobuild.sh failed to cross-compile to mingw due to commit d596c6d requiring chown(). The gnulib function is just an always-failing stub on mingw, but at least it lets things link again.
Aargh - emailed the wrong version of the patch. s/chmod/chown/g, to get what I actually pushed, because the link failure was for chown (mingw already has a somewhat functional chmod, it is the concept of chown that is completely lacking).
@@ -23,6 +23,7 @@ areadlink base64 c-ctype canonicalize-lgpl +chmod close connect configmake
-- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
On 01/12/2011 05:50 PM, Eric Blake wrote:
On 01/12/2011 05:44 PM, Eric Blake wrote:
* bootstrap.conf (gnulib_modules): Add chmod. ---
Pushing under the build-breaker rule; ./autobuild.sh failed to cross-compile to mingw due to commit d596c6d requiring chown(). The gnulib function is just an always-failing stub on mingw, but at least it lets things link again.
Aargh - emailed the wrong version of the patch.
Also attributed the wrong commit. The link failure was: CC libvirt_driver_security_la-security_manager.lo cc1: warnings being treated as errors security/security_dac.c: In function 'virSecurityDACSetOwnership': security/security_dac.c:101:5: error: implicit declaration of function 'chown' [-Wimplicit-function-declaration] which implies commit d6623003c6 was to blame (and fortunately, that this is not a released build regression, since 0.8.7 did not contain that commit.) -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
participants (1)
-
Eric Blake