[libvirt] [PATCH] virt-aa-helper should require <uuid> in XML
When <uuid> is not in the XML, a virUUIDGenerate() ends up being called which is unnecessary and can lead to crashes if /dev/urandom isn't available because virRandomInitialize() is not called within virt-aa-helper. This patch adds verify_xpath_context() and updates caps_mockup() to use it. This is https://launchpad.net/bugs/672943 -- Jamie Strandboge | http://www.canonical.com
On 11/11/2010 12:33 PM, Jamie Strandboge wrote:
When <uuid> is not in the XML, a virUUIDGenerate() ends up being called which is unnecessary and can lead to crashes if /dev/urandom isn't available because virRandomInitialize() is not called within virt-aa-helper. This patch adds verify_xpath_context() and updates caps_mockup() to use it.
Makes sense that virt-aa-helper can have stricter requirements on the XML passed to it, since it should not be directly used by end users. ACK, and pushed. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
participants (2)
-
Eric Blake -
Jamie Strandboge