[libvirt] [PATCH] Fix memory leak in virsh

--- tools/virsh.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 4e37f2d..8c123bb 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -10935,8 +10935,10 @@ vshCommandParse(vshControl *ctl, vshCommandParser *parser) if (tk == VSH_TK_ERROR) goto syntaxError; - if (tk != VSH_TK_ARG) + if (tk != VSH_TK_ARG) { + VIR_FREE(tkdata); break; + } if (cmd == NULL) { /* first token must be command name */ -- 1.7.3.1 -- Thanks, Hu Tao

On 12/22/2010 12:12 AM, Hu Tao wrote:
--- tools/virsh.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c index 4e37f2d..8c123bb 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -10935,8 +10935,10 @@ vshCommandParse(vshControl *ctl, vshCommandParser *parser)
if (tk == VSH_TK_ERROR) goto syntaxError; - if (tk != VSH_TK_ARG) + if (tk != VSH_TK_ARG) { + VIR_FREE(tkdata); break; + }
ACK, and pushed. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org

On Wed, Dec 22, 2010 at 08:48:37AM -0700, Eric Blake wrote:
On 12/22/2010 12:12 AM, Hu Tao wrote:
--- tools/virsh.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c index 4e37f2d..8c123bb 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -10935,8 +10935,10 @@ vshCommandParse(vshControl *ctl, vshCommandParser *parser)
if (tk == VSH_TK_ERROR) goto syntaxError; - if (tk != VSH_TK_ARG) + if (tk != VSH_TK_ARG) { + VIR_FREE(tkdata); break; + }
ACK, and pushed.
Thanks. -- Thanks, Hu Tao
participants (2)
-
Eric Blake
-
Hu Tao