[libvirt] [PATCH] network_conf: Don't free uninitialized pointers while parsing DNS SRV
If the user specified invalid protocol type in a network's SRV record the error path ended up in freeing uninitialized pointers causing a daemon crash. *network_conf.c: virNetworkDNSSrvDefParseXML(): initialize local variables --- src/conf/network_conf.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c index 60cd888..515bc36 100644 --- a/src/conf/network_conf.c +++ b/src/conf/network_conf.c @@ -574,10 +574,10 @@ virNetworkDNSSrvDefParseXML(virNetworkDNSDefPtr def, xmlNodePtr cur, xmlXPathContextPtr ctxt) { - char *domain; - char *service; - char *protocol; - char *target; + char *domain = NULL; + char *service = NULL; + char *protocol = NULL; + char *target = NULL; int port; int priority; int weight; -- 1.7.8.6
On 06/28/2012 03:48 PM, Peter Krempa wrote:
If the user specified invalid protocol type in a network's SRV record the error path ended up in freeing uninitialized pointers causing a daemon crash.
*network_conf.c: virNetworkDNSSrvDefParseXML(): initialize local variables --- src/conf/network_conf.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-)
ACK. -- Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
On 06/28/12 23:52, Eric Blake wrote:
On 06/28/2012 03:48 PM, Peter Krempa wrote:
If the user specified invalid protocol type in a network's SRV record the error path ended up in freeing uninitialized pointers causing a daemon crash.
*network_conf.c: virNetworkDNSSrvDefParseXML(): initialize local variables --- src/conf/network_conf.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-)
ACK.
Pushed; Thanks for a quick review. Peter
On Thu, Jun 28, 2012 at 11:58:01PM +0200, Peter Krempa wrote:
On 06/28/12 23:52, Eric Blake wrote:
On 06/28/2012 03:48 PM, Peter Krempa wrote:
If the user specified invalid protocol type in a network's SRV record the error path ended up in freeing uninitialized pointers causing a daemon crash.
*network_conf.c: virNetworkDNSSrvDefParseXML(): initialize local variables --- src/conf/network_conf.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-)
ACK.
Pushed; Thanks for a quick review.
Thanks, Peter, that fixes the crash for me. Dave
Peter
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
participants (3)
-
Dave Allan -
Eric Blake -
Peter Krempa